From patchwork Fri Jun 23 14:35:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Ser X-Patchwork-Id: 13290742 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEC6AEB64DD for ; Fri, 23 Jun 2023 14:35:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D662410E646; Fri, 23 Jun 2023 14:35:34 +0000 (UTC) Received: from mail-40136.proton.ch (mail-40136.proton.ch [185.70.40.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB4B510E646 for ; Fri, 23 Jun 2023 14:35:33 +0000 (UTC) Date: Fri, 23 Jun 2023 14:35:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail; t=1687530930; x=1687790130; bh=YymGHJVx8QAcRL69nLPQXQjGsZNGlGI/V7ryyUEOLlo=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=gS7v6vJzv8Vmwfn1Eu3cHidzn2mGhwERnfNEKbIqE8rVaBWyqxu1l6bebFLgR7K51 5Uvc+letVzqJ2YTjUdYLd3St36g/eCJbgBXVTVrXu1D8Eu8+y8WcWFx4JtyYAE4ZDp FN0AM/Q+Jpb+/aXfaNE5jfaRVPu2PPWWVUkflQm/W87vmoDjnbwKLhke2DQYgkPG4n 4a2JK7llv+2nDalnpA6iM81g5iMQFnHGySLQnV9PMK0S8qdv6ems3cHbRQ+kKLWUYq GizTmOer2ZTCAyv1e6Fo+X3e1kFnvxivkSBlT8XVqV8hXN3qdujWAhFlgWxO8E7UCi PXcMLEJK0MVww== To: dri-devel@lists.freedesktop.org From: Simon Ser Subject: [PATCH] drm/kms: log when querying an object not included in lease Message-ID: <20230623143514.38707-1-contact@emersion.fr> Feedback-ID: 1358184:user:proton MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" User-space may query an existing object not included in a lease. Make it easier to debug such situations by logging a debug message. Signed-off-by: Simon Ser Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_mode_object.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mode_object.c b/drivers/gpu/drm/drm_mode_object.c index ba1608effc0f..ac0d2ce3f870 100644 --- a/drivers/gpu/drm/drm_mode_object.c +++ b/drivers/gpu/drm/drm_mode_object.c @@ -147,8 +147,10 @@ struct drm_mode_object *__drm_mode_object_find(struct drm_device *dev, obj = NULL; if (obj && drm_mode_object_lease_required(obj->type) && - !_drm_lease_held(file_priv, obj->id)) + !_drm_lease_held(file_priv, obj->id)) { + drm_dbg_kms(dev, "[OBJECT:%d] not included in lease", id); obj = NULL; + } if (obj && obj->free_cb) { if (!kref_get_unless_zero(&obj->refcount))