From patchwork Sat Feb 2 14:53:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wen Yang X-Patchwork-Id: 10797667 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A621A13B4 for ; Tue, 5 Feb 2019 16:16:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93BD62BA78 for ; Tue, 5 Feb 2019 16:16:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 86D532BBA8; Tue, 5 Feb 2019 16:16:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FORGED_HOTMAIL_RCVD2,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B17A72C63E for ; Tue, 5 Feb 2019 16:16:21 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 08617266FA5; Tue, 5 Feb 2019 16:50:34 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7534D267477; Sat, 2 Feb 2019 15:53:26 +0100 (CET) Received: from APC01-HK2-obe.outbound.protection.outlook.com (mail-oln040092255021.outbound.protection.outlook.com [40.92.255.21]) by alsa0.perex.cz (Postfix) with ESMTP id 6506A2666B3 for ; Sat, 2 Feb 2019 15:53:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fBX/b7FDrGDeNymzrl8vXnNgYH6oaUOxZPNd9g1b9To=; b=srdGZ3qWs3B2QwnIc/t5KRmUopFR0U8Eyg6VkROckKGRzlvA/nv5fqPb1SJyyjIulfbUC3Sx8USSl4JuS/f8GppK8FWej84aFJAYpQgRknhORmjXGo0fh/Km5HekoI5Qabfw7RVnbUOzOndr9Crn6Q3rwxPOUMGHbsW0s3JyajakGWXfkycocPELr/uT+r1LywEzYC6ObkKWi2Q87APYc6Yt8JZXRjT2k9nUROIAd45sOHc+mPd9kSGuQ1VdU5L9CG1UwTn0ANvHcTdByiKEBzXAqgEAVZNq14xePlf7KJCtzeAqSOrg0DnPY67BkZ3PY9qtoZukF/IZvfFoASaoGg== Received: from SG2APC01FT042.eop-APC01.prod.protection.outlook.com (10.152.250.52) by SG2APC01HT180.eop-APC01.prod.protection.outlook.com (10.152.251.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1580.10; Sat, 2 Feb 2019 14:53:16 +0000 Received: from HK0PR02MB3634.apcprd02.prod.outlook.com (10.152.250.52) by SG2APC01FT042.mail.protection.outlook.com (10.152.251.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1580.10 via Frontend Transport; Sat, 2 Feb 2019 14:53:16 +0000 Received: from HK0PR02MB3634.apcprd02.prod.outlook.com ([fe80::d582:b3ef:f46a:4735]) by HK0PR02MB3634.apcprd02.prod.outlook.com ([fe80::d582:b3ef:f46a:4735%3]) with mapi id 15.20.1580.019; Sat, 2 Feb 2019 14:53:16 +0000 From: wen yang To: "timur@kernel.org" , "nicoleotsuka@gmail.com" , "Xiubo.Lee@gmail.com" Thread-Topic: [PATCH] ASoC: fsl-asoc-card: fix object reference leaks in fsl_asoc_card_probe Thread-Index: AQHUuwcHc2EgeT3L+EyE3/rHliwXIA== Date: Sat, 2 Feb 2019 14:53:16 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR02CA0155.apcprd02.prod.outlook.com (2603:1096:201:1f::15) To HK0PR02MB3634.apcprd02.prod.outlook.com (2603:1096:203:97::14) x-incomingtopheadermarker: OriginalChecksum:C79B53D005D6DB53784A0FF9DC5E86CF1185F3D7612F302E8C08DBED10DA9A88; UpperCasedChecksum:87473CF4E8A150B30C2FB790DF09E0BF0883E7D04480361A6F1DBB50AFDCB4B1; SizeAsReceived:9015; Count:63 x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-tmn: [CqFvKAlht5upTb62EfTE6mOXSS5xhyWW] x-microsoft-original-message-id: <1549119027-31919-1-git-send-email-yellowriver2010@hotmail.com> x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SG2APC01HT180; 6:HCcZszwGYN+FP5u2qetBMt6w4mCG88cGiYwEYnXhMrDWDl6zfKt2Dkr2AZ6HK6sNcF3h/Pi0Cy3ySe5J2k+cvCnEwZCrFLmatc7L9Xu3ruxiFNwKWYVQSPNpae2ZmOdYJb60WWXi0cRACBaRFXxxgF18kb05Wn+cVmhrGlfaPTqKL+QM83YL1gQEkBfQZtKx861v7mkpUgKFT60QSRfQyYUqGN5Ie9NtZ6sQe72JsI6o3WAEoSbG6QOeS4MOJ5PxY3B2MvMX4+Xs7YDy1L52AGUXLCNRbFC6LvYwiq1ZdvnmW/HIQ3oyCWQNrSgdZeD81JdwytyLMP9zjgkH5qvpB7z+bQaX7maI3qv2uz36Ic6oeJMgRJnSI1OkmJyh8kH+VbPbGShzbWCeipUPGdYmdrzb39ysVOJZtStTUVX+R+mEWa4GCiqdQHobB4VJyM4tyFqCyz7xi68BmKBefvhHPQ==; 5:GtBG4GHfilNocDxYzdA08xH6Xl4rMrrxbMU8ZYMuGcurymXVaVa3TfHTCge2a59ndERw15VvxCkuBN7QRV5iRS5t+NHsFLD4KNWOrAQT1YgC5mfSsSl5eJu7aLavvyOqQ27OrArhRocKd4MmmU4MEaryHqTLZEUmjMYNsvfbOD638cpEozKvmeouMke8BarwRhhM6yXLQAxN/1m/g9WqFA==; 7:buBRYXWCJteRhZ8+nfeauAw9FRIlbwY4LJ9h5EO0dz3i8L6TYYJrJltrjz27m8FupGaM2QZUYXVE4MVb2Jmr0BJksW3afMnkLVQ0g11l/TYFoM/mIC13IaxXZAvAAbVuKXeXhu6zbwetduTIU60h8g== x-incomingheadercount: 63 x-eopattributedmessage: 0 x-ms-exchange-slblob-mailprops: 7MJMDUNTCtz4oVbBjKUKY9bzavrGWT4EpeMG9XHo6M2qjnYi4Q/xa8a+4sA2o0OsqNoEde0QPjlq/SpI040ovWp6FgUKqNT4kzTGgXsga66/nH62Znz/eJq4bs+e8r15myuvTOXIYPr7fIMCwn9fitEM8Pizr0hIPUSsI6ktRNIlbMMCoY47Zen/WUQjgY3eH2jpmF4FLuJAPIdyXmmdB3ANRuixFjeOG7v1D363VZ6iWDBHn/0GYpMhfkXbkGA0piZIXD2p4MVoMB5OMX/yi+3VA3wGYEBef0Keu0kF76BefJAkDi/9dvogcu0VmwMOjFKGx9FvPC/l2vinVe1BMg9GH47AmwkQEpgZw6Z5uD7yemQpfFJ1eNES8nMDn8uM0vBLwYPQ0RB541ri5HCl3jisMtMnUUI8CoOGnH/4R9btF053rM66MycUxHwE7wJTzN70SHluAxe5d4ADiL2f67ZSISzfEKY90IEmNZG9IPOFzcGfLYP9DfjDpZGAeww9XLyzI1Nbpr+m5K+ZDFvalmKg70bmxsljYWo4uz0dodmLMfEtEy1oQwEISpdYrMMTaTJ/geoFXDi9v+H2SyAAUDKHr1vyr2LJKKCiXQF4n5zUCaaH2oVyT8wJ8V1cPJZw/BQ+arAvWGLq8ObdHqsbcK3BdT7DFgA0GJuANYQS980nkH2tcpeTrdFzdco2KJcrXcKmgWPksgFYmH8zFO5ELJTLjs1Drmk8wzu3zMUWYAb+kzTk3wvLhQ== x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(20181119070)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(201702181274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045); SRVR:SG2APC01HT180; x-ms-traffictypediagnostic: SG2APC01HT180: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(4566010)(82015058); SRVR:SG2APC01HT180; BCL:0; PCL:0; RULEID:; SRVR:SG2APC01HT180; x-microsoft-antispam-message-info: LzhMgRVKF3jDSjRzHlIFncw/S/NT6GqxkfT9PVjG+5Bi01gKpmeLE7urjl4uqTWq MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 9a4e3081-9524-43cf-bfc3-dcaef82d5da1 X-MS-Exchange-CrossTenant-Network-Message-Id: 01a37251-b303-448a-e36f-08d6891e29f5 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 9a4e3081-9524-43cf-bfc3-dcaef82d5da1 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2019 14:53:15.8433 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2APC01HT180 X-Mailman-Approved-At: Tue, 05 Feb 2019 16:50:32 +0100 Cc: "alsa-devel@alsa-project.org" , "linuxppc-dev@lists.ozlabs.org" , wen yang , Takashi Iwai , "linux-kernel@vger.kernel.org" , Liam Girdwood , Mark Brown , Wen Yang , "festevam@gmail.com" Subject: [alsa-devel] [PATCH] ASoC: fsl-asoc-card: fix object reference leaks in fsl_asoc_card_probe X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. Signed-off-by: Wen Yang Cc: Timur Tabi Cc: Nicolin Chen Cc: Xiubo Li Cc: Fabio Estevam Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-devel@alsa-project.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org --- sound/soc/fsl/fsl-asoc-card.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index 81f2fe2..60f87a0 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c @@ -689,6 +689,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev) asrc_fail: of_node_put(asrc_np); of_node_put(codec_np); + put_device(&cpu_pdev->dev); fail: of_node_put(cpu_np);