From patchwork Mon Jun 26 13:35:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 13292942 X-Patchwork-Delegate: mhiramat@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C89EFEB64DC for ; Mon, 26 Jun 2023 13:35:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbjFZNfQ (ORCPT ); Mon, 26 Jun 2023 09:35:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbjFZNfQ (ORCPT ); Mon, 26 Jun 2023 09:35:16 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DFACE73 for ; Mon, 26 Jun 2023 06:35:14 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fa99f6a4a1so7594425e9.3 for ; Mon, 26 Jun 2023 06:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687786512; x=1690378512; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=CSXSrL5SBC6uysg7fDXpV4R+sOE/vGqBgFIZWIbj7pw=; b=EDg/JYJGZHQwgJsLcFq9/ITSErd0gEgwbs2B4EI87mfwR+DHdGWPwKDMv96ICBrWM4 WqFunED0vhQtUzVRkuue+yeasq5UfMt+tCQb64KjCfQOaHx/ZBopTIlpSZqdCxdlVVff ohEobd+9qAxavA6NVYulWWiCbgLdb12y2VmU9/5Vc9rBOcjdHWaieY8Rm+VrF+WMUkpa JhHcnCU4tVj8s3SN1dgNsC2VAv59kUZxtH1zpBvcrASH8tImi/R6hx076/3JKSBF1BFo kE0LxRzEhDCEiegJ7Pf8uHAe/Uk50OQACxhG8bh0XWCn6DkcLcHyWE6XacRHV8Pm0KTr syxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687786512; x=1690378512; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CSXSrL5SBC6uysg7fDXpV4R+sOE/vGqBgFIZWIbj7pw=; b=RbzX2DXgjr3xAF5cY7yUxleZTM/o7T4bHfe11833IWrJlAPbCIT0a/5DjCBuKL6/lb PhrVtbRXxt0p4dexA/7I6cZkYExnxjnEusE/Iod5K+2SLCvhgjWWSa8HfrUCKcHYgMsD XrXAGKHYXDSKpty2M9SBcTI5Q3rw/zUBKP7DdjkvD2GP2RhtznFsTDEFH8+/ckihdAGP UkiH+58pHhQwReqRsfKfBSk6f1UCognL7AsaDJLaj/0lSC8smx48D48n4uR84x3Nrp/1 lE7yxFMo9vz8WOwE2Y/8GBBRn1yFYh9csBpV2jKN3+p+zqjT2Qm35jm9wlxo172Ziq0c pWQQ== X-Gm-Message-State: AC+VfDz281I/F6k8/7a/NnBVKE1AioWZOGZNCPNOQiPOyKGYNsn3Bc2B 8OqZCg/JFJ5gNSGoON0WUUh3tA== X-Google-Smtp-Source: ACHHUZ7WdbGtDIPRhHdOfpa04nv2W0iY1lsc6UFWYGvhTfoDiKA98kj0m9x9EYimTM6Ba0V8jGNOxw== X-Received: by 2002:a7b:ce8a:0:b0:3f9:8c3:6805 with SMTP id q10-20020a7bce8a000000b003f908c36805mr21926578wmj.7.1687786512617; Mon, 26 Jun 2023 06:35:12 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003fa9a00d74csm2125136wmo.3.2023.06.26.06.35.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 06:35:10 -0700 (PDT) Date: Mon, 26 Jun 2023 16:35:06 +0300 From: Dan Carpenter To: Steven Rostedt , Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] tracing/probes: Delete dead code in trace_eprobe_tp_update_arg() Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org This code was recently refactored and now the "ret" variable is always zero. Delete the check for non-zero. Signed-off-by: Dan Carpenter Acked-by: Masami Hiramatsu (Google) Reviewed-by: Steven Rostedt (Google) --- This code was changed in 1b8b0cd754cd (tracing/probes: Move event parameter fetching code to common parser) kernel/trace/trace_eprobe.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c index cb0077ba2b49..b5181d690b4d 100644 --- a/kernel/trace/trace_eprobe.c +++ b/kernel/trace/trace_eprobe.c @@ -797,10 +797,7 @@ static int trace_eprobe_tp_update_arg(struct trace_eprobe *ep, const char *argv[ return ret; /* Handle symbols "@" */ - if (!ret) - ret = traceprobe_update_arg(&ep->tp.args[i]); - - return ret; + return traceprobe_update_arg(&ep->tp.args[i]); } static int trace_eprobe_parse_filter(struct trace_eprobe *ep, int argc, const char *argv[])