From patchwork Thu Jun 29 18:43:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Wunderlich X-Patchwork-Id: 13297209 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBF19EB64D9 for ; Thu, 29 Jun 2023 18:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J3ZPCos+Pya2fODiwVzzVkL3rVv80vNTYttKO7F2y38=; b=LnMfGQAZG0UlE2 tABG1+N5M8SMCKVdKSDlp1KW6REtCibEm2az1feULSSDIpK44thnE7Mu6aguhfzOjRDTpPVf3kIiZ teIhZ31PITg5ER4L9yoZI3LonOdZXArtNFDE+zlDEpi5pUAy5oQDckUm+gj+GPNT0ysDsGNHSZPsn tH7OsDXbc85Aj79lqRr6J9Gxmoq/YEsUnVm2jWMbKMXWxWCqrFI9UuKV276bkXnouGccF/1NG/xht hzvXioZDwJBWKJlrZuOwB8hE30kJzAoMhbyCHD8ZUOkR9h7U10akjbKMPQzl8ikCT13O+Z5wHg5g5 JmxF8+r0VjTu6AxbWG9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEwcP-001nSc-2g; Thu, 29 Jun 2023 18:43:49 +0000 Received: from mxout3.routing.net ([2a03:2900:1:a::8]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qEwcD-001nNj-0Y; Thu, 29 Jun 2023 18:43:43 +0000 Received: from mxbox2.masterlogin.de (unknown [192.168.10.89]) by mxout3.routing.net (Postfix) with ESMTP id A99DF605D2; Thu, 29 Jun 2023 18:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1688064213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KKwn4pI+xbCMED6ZrjRNts/9bUc9vmXTiZ+7Mh6MCJo=; b=IuoPkO4nES4sD7aKHkl3yJuMO9wW83z8euR0VrDgqxiD4ItrWnf57ouhYuJaBZxvn7Awcd tosMG8V2vFIr8FsCGgrRB+ucVrOwuzr7W6gmpfqDmh5KydHrSgF6VohYv5O4ANOqpcWYRq +H0bMt/M9A8r6wQyhcwS1Xu8ysdteoQ= Received: from frank-G5.. (fttx-pool-157.180.227.241.bambit.de [157.180.227.241]) by mxbox2.masterlogin.de (Postfix) with ESMTPSA id C0D411007BC; Thu, 29 Jun 2023 18:43:32 +0000 (UTC) From: Frank Wunderlich To: linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Chaotian Jing , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wenbin Mei , Sam Shih , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/2] dt-bindings: mmc: mtk-sd: drop assigned-clocks/clock-parents Date: Thu, 29 Jun 2023 20:43:17 +0200 Message-Id: <20230629184318.551317-2-linux@fw-web.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230629184318.551317-1-linux@fw-web.de> References: <20230629184318.551317-1-linux@fw-web.de> MIME-Version: 1.0 X-Mail-ID: d645d265-62e5-466c-9f7d-58ccb7702d42 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230629_114337_373231_0D8927CB X-CRM114-Status: UNSURE ( 8.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Frank Wunderlich MT7986 has 2 clock-parents and these properties are not needed in driver binding. So drop them completely. Signed-off-by: Frank Wunderlich Acked-by: Conor Dooley --- v2: - drop assigned-clock* completely based on discussion with Krzysztof in v1 --- Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml index 46eefdd19a2c..3fffa467e4e1 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml @@ -91,16 +91,6 @@ properties: should switch dat1 pin to GPIO mode. maxItems: 1 - assigned-clocks: - description: - PLL of the source clock. - maxItems: 1 - - assigned-clock-parents: - description: - parent of source clock, used for HS400 mode to get 400Mhz source clock. - maxItems: 1 - hs400-ds-delay: $ref: /schemas/types.yaml#/definitions/uint32 description: From patchwork Thu Jun 29 18:43:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Wunderlich X-Patchwork-Id: 13297210 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7589EB64DD for ; Thu, 29 Jun 2023 18:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TFuwujWv/JG0hj3d+0HXZz8fjlsy2qmag6uzA7pKhvU=; b=xmrnyqERF9Wts7 fkMTxDNLMOx8af9RmXioM3M/b7SszeAH+Np3f9U3jQKRNIYZ40v0GdVTFSL0h4bAc0kRvI08Btbsl aZayn2Ga4DdjIYYgP2iUjLV1moXBEJIDXI0eZRxypP6wGBj3w6bq/al4u6GB6hpQerdNPQ7zBqRZo IQSGtDn81MoWymrERWtWZgtyPxaGXTVtR2xfJ90iTRk3mPXoCVqhMK8iH9ppINesFwB5QZ0Kl9vO5 ohSmwj2xrDVnDR9IjTIOMU9v8a0N4sOL7DpjkLDJMmYVSC5hIdgayUFUGC+m8rwU1dpwDU6UuDiJ+ dQTMvjKArJ//I36qQLWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEwcZ-001nWv-2P; Thu, 29 Jun 2023 18:43:59 +0000 Received: from mxout3.routing.net ([2a03:2900:1:a::8]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qEwcD-001nNt-24; Thu, 29 Jun 2023 18:43:45 +0000 Received: from mxbox2.masterlogin.de (unknown [192.168.10.89]) by mxout3.routing.net (Postfix) with ESMTP id 92923605D4; Thu, 29 Jun 2023 18:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1688064214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I8cdP6cF+nwTWlyfboIiQYyzWM6TGbsre5s255hDw1E=; b=OGbX55DGj/xtkG/hWVz4Qo4R1i22zFNmJxp55CTfnwcpyzy+ao4f+YL/q9cUmFsKtmh3WQ SfRGV00+DKFU+AFks3cdLH1xvu04AOhJ1j452P0Cwd2PdgQB6gWydKc7cZXbj/KnAUW/gn Ox6Nxq39V7ltXPJoF8QFFi+sFdSePNc= Received: from frank-G5.. (fttx-pool-157.180.227.241.bambit.de [157.180.227.241]) by mxbox2.masterlogin.de (Postfix) with ESMTPSA id 916DD10009B; Thu, 29 Jun 2023 18:43:33 +0000 (UTC) From: Frank Wunderlich To: linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Chaotian Jing , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wenbin Mei , Sam Shih , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Eric Woudstra , stable@vger.kernel.org Subject: [PATCH v2 2/2] arm64: dts: mt7986: fix emmc hs400 mode without uboot initialization Date: Thu, 29 Jun 2023 20:43:18 +0200 Message-Id: <20230629184318.551317-3-linux@fw-web.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230629184318.551317-1-linux@fw-web.de> References: <20230629184318.551317-1-linux@fw-web.de> MIME-Version: 1.0 X-Mail-ID: 79a3025b-a2bb-4026-a6d2-40902656f0e4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230629_114337_837372_88F5CBB2 X-CRM114-Status: GOOD ( 10.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Eric Woudstra Eric reports errors on emmc with hs400 mode when booting linux on bpi-r3 without uboot [1]. Booting with uboot does not show this because clocks seem to be initialized by uboot. Fix this by adding assigned-clocks and assigned-clock-parents like it's done in uboot [2]. [1] https://forum.banana-pi.org/t/bpi-r3-kernel-fails-setting-emmc-clock-to-416m-depends-on-u-boot/15170 [2] https://github.com/u-boot/u-boot/blob/master/arch/arm/dts/mt7986.dtsi#L287 Cc: stable@vger.kernel.org Fixes: 513b49d19b34 ("arm64: dts: mt7986: add mmc related device nodes") Signed-off-by: Eric Woudstra Signed-off-by: Frank Wunderlich Reviewed-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi index 68539ea788df..207510abda89 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi @@ -374,6 +374,10 @@ mmc0: mmc@11230000 { reg = <0 0x11230000 0 0x1000>, <0 0x11c20000 0 0x1000>; interrupts = ; + assigned-clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>, + <&topckgen CLK_TOP_EMMC_250M_SEL>; + assigned-clock-parents = <&apmixedsys CLK_APMIXED_MPLL>, + <&topckgen CLK_TOP_NET1PLL_D5_D2>; clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>, <&infracfg CLK_INFRA_MSDC_HCK_CK>, <&infracfg CLK_INFRA_MSDC_CK>,