From patchwork Wed Jul 5 06:48:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13301716 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B122EB64DD for ; Wed, 5 Jul 2023 06:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=h/vLbxB709ms4JPEPAsKMTThNAZX6D6iJKveA5U2pcc=; b=Yo4cUZ7MAH1pOX DHpptlx7keGaYscfePFq8loVVrZ9isP4hwRlUpg0v/KNdiWYrWC64dIdXxecoQJwwJbQSB7Kf/RM+ 1a5VOXlWzeCJgvoBMs/8S0D7v4Xu+cDpwRxLpNf94iVZ+k9jOihj2cBAg4OjuIvXjdV3XBpj0fJQJ kfnoOYSQC1bM68covAlZt4l9J1kuV/MWgbeA0IJi+fXFSCyjv7vlxoWfV4nxkmBI0Q8ONyRkKGq8S SIBmK/XBUd8KqE1E3sTeKFeuPWMcdzvTL+kvDeTk8mtXcWIGZgOepyiTTtfRpGClXpW7NiIEDSoz6 eKVjrpjj/QkVvOis7AZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJp-00Ew2y-0T; Wed, 05 Jul 2023 06:48:53 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJm-00Ew1F-2I for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 06:48:51 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-99313a34b2dso332835166b.1 for ; Tue, 04 Jul 2023 23:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688539728; x=1691131728; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4BLpQcyu9Z+TkFkMMBNPXxj0TsUd7XYOG3VtXDiVEos=; b=hd2auJm2gJxE4NaPzfdgf5PK1CXoj2u+Yk2TzKUjTKUuiTR57+YdVsmoPUOSVY3uHK nZIqRZP+CHOzMM+ajppHFqCX2bLcbnAH7p6kiFs4MN/ffNpLpVGUotjq+IEdg22Y+aFJ gZAArYBhp5Y9VrkANFgq0PDYvXjoMqtwHnq9Xt8N+PWQRBOAKXfDP/ls1ItbOKLcLyfR FWKgS8WumdEdYJsGaa/MLDzxYJbixjGpIxKA3h2j8Gx0141ogqoRiYBhNs1piK6eNZiK +iv4iHQHsfbW+cAaLGb8Ax7bzq27wMHWMlI1I9nfGIsFNAmqV2HX4QwNjg85ETb15k5V dOlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688539728; x=1691131728; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4BLpQcyu9Z+TkFkMMBNPXxj0TsUd7XYOG3VtXDiVEos=; b=dlAoCUZl1ELZ1gSTPycDljcpD8KhRMY7bDR1dhADuQ6LHPnFX/A2T3o7joLrkIg4Og BWVOJjhZjcoDGiFoFv7rNQHqPvTSjpuLlqqwuLitCbizWG8K1C7TcrKRUOPPSjj8FctC farbKHyV1JcArQ43i7PIWjPS2D2MFvkvdZ/B/Ptp6I3fppTcYRZSua0A5qUe/8rtkPI9 kjnOuVrKKu6aNX6AAmNx18JpiRa9Sxdua97MBYSPb/6+Ixk+EsFCCW/xiphzjeAHmQtg f5QKB5nQaav3Sf3hjqG33U08qMcPI7jaZN3bsSbxAJNzsu+v7FvblolXHATURJG6HTAt JERg== X-Gm-Message-State: ABy/qLYNlbGu1CHKJDn9uE9iua72lJmoL4FfBw3r+QLiDjjPNwEUT0Dv mloW9p+r2F94CmLrh8kkPqgzzg== X-Google-Smtp-Source: APBJJlFdr/JqlYyk0Iw3f97ZqtublI4upHtqJRPCgBSEDqIv2RXPje/WG4Qau16mX2OZcIDrN04zeQ== X-Received: by 2002:a17:906:57ca:b0:96f:8666:5fc4 with SMTP id u10-20020a17090657ca00b0096f86665fc4mr11686557ejr.50.1688539728502; Tue, 04 Jul 2023 23:48:48 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id lj14-20020a170906f9ce00b00992bea2e9d2sm7504836ejb.62.2023.07.04.23.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 23:48:48 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 1/3] arm64: dts: rockchip: correct audio-codec interrupt flag in eaidk-610 Date: Wed, 5 Jul 2023 08:48:21 +0200 Message-Id: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_234850_743810_13A87109 X-CRM114-Status: GOOD ( 14.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts index d1f343345f67..6464ef4d113d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts @@ -773,7 +773,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio0>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>; From patchwork Wed Jul 5 06:48:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13301717 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A11DC001B0 for ; Wed, 5 Jul 2023 06:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7bDZhWRUI6q5f264ywpoQtLtKwKsJJ6JVxvd31bpZkg=; b=pqBcxQwnuUWHB+ Oy22SD2aIexuyYf6GEMJtw5E50I7N7kOXb5Rniu4ROaca9/T+RsD1dC4CRGsaDEPPgI1WkZEZ8Bhc 54Ki68FB9ZT90a5W/t3P6gIvfyzuPNc3KMiWWffPZHEaoj8/h9DD4+CDKzA6FsFL+6KyiokKkYfFm WPwamY1qPtttDslCFFc0JTWcKlSb09uD+Y6fcNsEpd8mGhvtCAH2MRMYSmXLK0VYNkHtCV8FGSbIH 96GE8pT7RMqoGGp4/1D/NCAd0/QjpPB3k+W8EQ+f8M8WtVtRGI/XhK1GLzdaYCERl48KVGc9+WAwU pxAy0jrSYQQ7bRdSV4AQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJr-00Ew3e-0S; Wed, 05 Jul 2023 06:48:55 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJn-00Ew1M-0h for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 06:48:53 +0000 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-98e011f45ffso612162466b.3 for ; Tue, 04 Jul 2023 23:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688539729; x=1691131729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u+MkrFMagkeIVy8ddwJ2oj2EHTlEbXRG0oh1YfYd/3Q=; b=iiIjNFLGPfjNj1fI30V62Stc1tnzX5ajqXD6ASSEccaJfwC3Z8MJ2KpUhYDD5cH0a7 onLqb4b4fXe9mNW+xfaqEI4MFTjKn+nuLKx6lpj5To7cIzsG4YDHiwXMTR7n69zXpCJB yonJuaE21eWHaezgbQTi2qw/ds0JHwuwXTF6ODm8TfMkrLwJgGHXovis3SfvqDlv25qD fmMpPRQxEEfi9CVKpPCkmtxz0dmFVYi7NZq4CY/bB0qcle6THyLWn5H9+U5AfD0toC9S anMvmvEaSgM1osViu/yAINGF3cWluHzXriqR79J9LKnm7kGgmq/pMQsrVQnkZMc7gABq gcPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688539729; x=1691131729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u+MkrFMagkeIVy8ddwJ2oj2EHTlEbXRG0oh1YfYd/3Q=; b=Z08bE5BYvN89eFCWBn0de6XriKCNun70n/+/nEqRqd93iFrHAn4fUAisF6SvAuaR8A HUEXCg03D9UAd/9vhAi2jOsaRbXELp2kyl+IhzgDL2AhPvWX5nAhXMo6VkeVGzeZojK4 2M+rHxOXCmgq2cofgoWh+FE/HD0r2csgO/CZTHZwmk1bIOEWVc3VQqyMTjZM6CWfCbl3 10Zfn+eo/yeQ1wI1AcDavVJDxxcLFFlZSpgwTvvaWpWGnzfkQ93LrPn+nSbkgtlB3ULG Ttz5hRmo+Pj5Q3djvw7osmwjm/yJsYovpbiIZx1e+P6Sk2lH8IiMg62xEWNMgtKAhI5c zIfA== X-Gm-Message-State: ABy/qLYIKMwilRUyUUaH32NoBJom38GY6TFvcLyDCVFm9WwmRjY0Telb PbK4vYPdZnAak1togPXlhzsrQHJr2fyw6yhPclM= X-Google-Smtp-Source: APBJJlHZl5PdNH0abYjBIDke2wCYFd5fP0UDSLJrYwlY2J0QoorN8lhH7IR9wBK+aqDps2wJxkgQKQ== X-Received: by 2002:a17:906:37cc:b0:973:cc48:f19c with SMTP id o12-20020a17090637cc00b00973cc48f19cmr8818117ejc.56.1688539729764; Tue, 04 Jul 2023 23:48:49 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id lj14-20020a170906f9ce00b00992bea2e9d2sm7504836ejb.62.2023.07.04.23.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 23:48:49 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 2/3] arm64: dts: rockchip: correct audio-codec interrupt flag in Rock Pi 4B Date: Wed, 5 Jul 2023 08:48:22 +0200 Message-Id: <20230705064823.9210-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org> References: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_234851_251834_895DA179 X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW Signed-off-by: Krzysztof Kozlowski Tested-by: Christopher Obbard --- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts index cec3b7b1b947..8a17c1eaae15 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts @@ -31,7 +31,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio0>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>; From patchwork Wed Jul 5 06:48:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13301718 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CF72EB64DD for ; Wed, 5 Jul 2023 06:49:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sofoUHzDtM7rTrO53wOFnpxlMATje1Vb38scJv0kq4c=; b=VxhIR1EW2FTA91 Cc/GbapCe68Zfz0h3iWbw/I6W0R2pywMbR6A89B8jRzIK3cmZAv/65dLP021ulRJiFog/c1bC0m1G Owm6VzVSr2rqFmeoLxPu45dtLYSVi7iPL6a9yBjYrO4hhsZDWYTl+H0U8RBLUm8pWCx9L+6wrfFAV IRu1/itOeSe8DOzvaiMOZWZxjtl9VB9VCmf0FVcBpI/y+fweDpPYbG+Nseu5YoHK+XJXm33Cne9zR 5d3pRWb2ucpuKdxLrqoR+LunWm2jS6RMRg03/lLptlRbeeJvSMauUBiNZlLGKMTb4i+nZH4yDhoa7 RjakBatzDaQG7n0UVXnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJt-00Ew48-0J; Wed, 05 Jul 2023 06:48:57 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJo-00Ew2I-0p for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 06:48:53 +0000 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-993a37b79e2so26722366b.1 for ; Tue, 04 Jul 2023 23:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688539731; x=1691131731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GB4bpNO3SAJRb4aZuiOoT5tlPntO7wrJyRlzhpgfep0=; b=D6HXcgpHibNmK6NkqhcOhTtIW5+ekU9iXxP97snkK3BNydz/RuVs6uGiuGiUOotYHc pJIMnec7dx93W7yNBm7gBJ3WuDLzdOM2JoWQ2C+Pf2fCE2T7VPbT5j8BpE5dOqkA9NF9 oaYY7rFY0iPy7STFlXVDbPz38v8etgYx4yYI28cBb7HWdymSgzfqiXV8Lu+HZ15cRyuk +A2aRwh8w+E1aGoNFZaf610DUh9YoIdypgtHu7f7p+jlvISmjSsVqJhQolms0NBmP/hb QzCP/CYVepxNleUQvOreWm4BGHNJfQWNAOYLBgqmzgBtfokh8u7Ug0VpQUtv6xipPxY/ lyag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688539731; x=1691131731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GB4bpNO3SAJRb4aZuiOoT5tlPntO7wrJyRlzhpgfep0=; b=a9w+5U2xqtMOlpeBrgRiFmVtC69SbjFpaWVT3dGIhYldmCvT0LqqPclXLXIuZd6n0L oWU8qdhbqFXQ0PpJ5lLby4nHLyzPY5C911xnsTvwZmKsZEddaiKHDiB7MJTORgfaYc+0 ZbH/BbGEKJMW0D/cmw1/OvKZPpWnAz85rP7rMhDQRbb06JXC+YmOIqTUKpQ3D1OdTuKk E7JcahkYCB2atAvmNcyZV4tnroSV/DiDuZRXqNUhAprDAZ6KswvDVXHgFyO16m3D+Hqz WRt4QkEy45aSddQh6wrLSvfuSU+MwbbXSqqkwjDBiaiyNST59KwNnxPWC6hf/mBiO8UL xVrg== X-Gm-Message-State: ABy/qLal7Upaf9oN2ouyzB4w9CNVkdCEtkRKusldh+u+uzC9oPE25Gx4 iHwNLtYfnb+l2CSjiYjtV/RgPA== X-Google-Smtp-Source: APBJJlGqxp0nR/roJ4vSdQwDqZktpU71hnPcawgc4zAU5CBltXqnjOabo4Kgh5z0KdGtSqmZXiPVgg== X-Received: by 2002:a17:906:c28f:b0:978:90cc:bf73 with SMTP id r15-20020a170906c28f00b0097890ccbf73mr10185458ejz.48.1688539730997; Tue, 04 Jul 2023 23:48:50 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id lj14-20020a170906f9ce00b00992bea2e9d2sm7504836ejb.62.2023.07.04.23.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 23:48:50 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 3/3] arm64: dts: rockchip: correct audio-codec interrupt flag in Box Demo Date: Wed, 5 Jul 2023 08:48:23 +0200 Message-Id: <20230705064823.9210-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org> References: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_234852_310068_A6CBE058 X-CRM114-Status: GOOD ( 14.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts index 322f3e809f15..0c18406e4c59 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts @@ -416,7 +416,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio2>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_h>;