From patchwork Fri Jul 7 13:58:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13304904 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB999EB64DA for ; Fri, 7 Jul 2023 13:59:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58E638E0001; Fri, 7 Jul 2023 09:59:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53DF68D0001; Fri, 7 Jul 2023 09:59:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42CED8E0001; Fri, 7 Jul 2023 09:59:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 32F188D0001 for ; Fri, 7 Jul 2023 09:59:35 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 17F3D160D90 for ; Fri, 7 Jul 2023 13:59:34 +0000 (UTC) X-FDA: 80984973468.25.F367AF6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id DE0F8C0013 for ; Fri, 7 Jul 2023 13:59:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aRL5AxlB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688738371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MGtpw5Ijohgjr845woqe5tjbTFDfrclnX+uXDY4qJTo=; b=dKWxXmkdQWCR0YOKEb93Rr40QO6j1TrNMxaI8UzMeXLakFFB004Y5BAgcASerweBde6kpO rkVCAOhgXZzvgeDraz+tu7QmLVqortKJ4F19BLkkKX0aQnWNy/+7/Xoc7i4AFOrzDnh32x Rh0bfr4Je2ibMEzM20LF+ZcUyuMYBnQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aRL5AxlB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688738372; a=rsa-sha256; cv=none; b=bzor9R1gUBZytcnJsqteVr4Q9WDf0/I93AtbDv0e5CsFCrueKro4D2VAKe7Jw+WEHYsDuW 3RjzKABa4wdvtVABCH3IuJxIosibW8PMsZTh+XtsjH3y76Zb7WRJFrgHuBqDdvh539++Hc 8H37XbugA4kNcj2Y0Vs7nj5AVXEq+f4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MGtpw5Ijohgjr845woqe5tjbTFDfrclnX+uXDY4qJTo=; b=aRL5AxlBSb4PaUD34NiwlMu4GApcFNtukh3LtU6OZdLF1waYQury/HkFRiqXxNsZyVNfai 7sCc9GEWg+HpBVsV3W5Cxkvo3ABtCkE1ZB7L+Lk3WKqmWhZbNodkxCnrIxUzaOW/FS/VHS bMy2M8YCvK5jJxWHDr9f9knd5H2Feag= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-91-jdBeycFfMpWPcS0WdIfb0g-1; Fri, 07 Jul 2023 09:59:27 -0400 X-MC-Unique: jdBeycFfMpWPcS0WdIfb0g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7A140185A791; Fri, 7 Jul 2023 13:59:26 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BEDF2166B25; Fri, 7 Jul 2023 13:59:10 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot , dmaengine@vger.kernel.org Subject: [PATCH 1/8] idmaengine: make FSL_EDMA and INTEL_IDMA64 depends on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:45 +0800 Message-Id: <20230707135852.24292-2-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: DE0F8C0013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: q1qtxzir5d5s1ymxiihmiwa3hburwgh7 X-HE-Tag: 1688738371-356345 X-HE-Meta: U2FsdGVkX18/tw5b5x0IMVCan2gMvqAl0gX0AhiFHVTljObfLo8ZW/GVIfAKb3LT/ALN3evKyiHSJLoR09X8Ekvl2o0Swd6MOp3adQ0hKwIjRlrBK0mGprHYakYZxlKnTnvaLRVlrFVjdFqZC6n5pB362hKpgw8iRGbVe1Pxnwaz3SYurSRam1ca6ElXM0vHgIAxVq2hrfzz3GzhBsyKlG/6b0IED/7H8TiRsVBG1cB+Cxsul2Ok7pJPjv5+xfXaL4LnkVfng0bJ4l7wVOQ5qeJAVLYpSMO8ZJPI7hogNPgHhn3Z0FrstBS1iqAuVCQzvz1/cBmfxSrm4NrzOyTXtGN+8e5qRtZyyhxJb1CCxxuq3j2fk3aC06f3vRRoHyj1iuftxdn+FxCiNG5m5WPFMGpTZqXmjKdTyB4E3dlbXL7cc3ds0Kccq2/5mn62WVVfgyvtoiGRbNl5dtrGiM+IwsOLy+EAbOmSF1IUQfLKsqr9pjKznfU4iDDeQZMedAz+uniUO7PGgENcJ7NMvtMu6Z5V24GaA36WsM2fkpTu6qG8Vgua6VytjyoT2O131rU5LGzwR6BXGHJc2v1JiTQG30XzO0ON68oQkaqu2WG8JjPiODC2KtJFUsqVjCn6aOfo2unSisWsHNgdoCE+IGaZGfHnsW1NDrnVr7JZnBOnm3HQaL3ETILxHgYBxSrVbf+jaa8Hoo50vY8BbqWL/F5ekpxRQPFZzTTxrI/S9kGIlOv9pxPBvH+X0orYND8UHCYEaxLFOUESk/qdX4l2aHmmaPrskyuRFKVyYaf3yNXNY6PhcBm+Q5GcMzTItQIneVtVlQ2ocpeQsxisQP9KWV+v2jyAR6K8CccYMt93YfCBk8hLjlCZ4/K2Q4PlRI4hvyCGz8fraF7kWmYWUI22mVb6crsEaV2J6FKqfqm4pZ6fmzLCB5uR8fbAxHqkX9Rcl2AfgJSmPIKCCz+zzS3fSwD kNVOLwFq cpoLvHpItNxLDWrg7JMM9soeUPo+3kGUG2yCo+njMOz8dCM6rxTt1s8VO8uKuJy8fQaQVDalGUgBEOx+QmOV4+S1WrX0ZiRvkJvaynu9mpymJxQb3cGe9nQZdyUX7BYGuku2qRKlqowKpLVE4D6w89px3Ux0w0jqBOjPh/GilG6T8HDHrsQXVK9iEBeiEtOotfmCwY3nnsNsZ1ikxZH9C09u0SglaKSBXskJCPffz77hSwEqdg9jJ8ZELlfLAH2wGOFwKCqbjVjgHw9IADXYBVMUJj+ZqA1ZTJNVJ9pAF72uRnF4s2ouB7pmt5hFgiuIqxc+yhBcbMcJzbyeGT+4bIo8MHDPfXFm2KuVJcZjNzrpc9pYDOGO9oP5QHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let FSL_EDMA and INTEL_IDMA64 depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset. -------- ERROR: modpost: "devm_platform_ioremap_resource" [drivers/dma/fsl-edma.ko] undefined! ERROR: modpost: "devm_platform_ioremap_resource" [drivers/dma/idma64.ko] undefined! -------- Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Vinod Koul Cc: dmaengine@vger.kernel.org --- drivers/dma/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 644c188d6a11..08fdd0e2ed1b 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -211,6 +211,7 @@ config FSL_DMA config FSL_EDMA tristate "Freescale eDMA engine support" depends on OF + depends on HAS_IOMEM select DMA_ENGINE select DMA_VIRTUAL_CHANNELS help @@ -280,6 +281,7 @@ config IMX_SDMA config INTEL_IDMA64 tristate "Intel integrated DMA 64-bit support" + depends on HAS_IOMEM select DMA_ENGINE select DMA_VIRTUAL_CHANNELS help From patchwork Fri Jul 7 13:58:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13304905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F07F4C001B0 for ; Fri, 7 Jul 2023 13:59:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9102F8E0002; Fri, 7 Jul 2023 09:59:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BFD18D0001; Fri, 7 Jul 2023 09:59:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 761388E0002; Fri, 7 Jul 2023 09:59:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 64D408D0001 for ; Fri, 7 Jul 2023 09:59:45 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A872CB094D for ; Fri, 7 Jul 2023 13:59:44 +0000 (UTC) X-FDA: 80984973888.03.0706821 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id CDB941C0018 for ; Fri, 7 Jul 2023 13:59:42 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OXsb0xPF; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688738382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CxwA3DJ3ViKIdzagr2m8kE8L4GOotWrmViZBn3jHWi4=; b=3R/klrsDUhPNYNavj/MJaP1St1MwMkH62c1XClJduCjKBh049Zw9qWyhuawTB+a2BqEVrV ZoyzfnTjOZTqC5hrC3kPEWX1w0fIv7DdiRgojhaV3yrQyXRMbPdxN9xcRT3oPLKqJKYtML cV/QA9Cgzt/pxWl3x9NWeI/Vh8qs/IY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688738382; a=rsa-sha256; cv=none; b=129pa70zg5BDKhSELcotUluOOqYEcyrwso55+kGZ3wo931BuKZLd1BV3joIEFJHumyxuAQ EOTvl+alnSjv9HgBSA4C3cnAEGZ8Y4H3FOZJ/oyey8J4ubolaa3OlX40MMtmKse8vUadfY 5KZcy9nI/XhaJbTJ9UrAnGtY5//KkoE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OXsb0xPF; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CxwA3DJ3ViKIdzagr2m8kE8L4GOotWrmViZBn3jHWi4=; b=OXsb0xPFHJHwq5RIcut7u6yv6VMAT2AVKnnKCPQVpwLj3XBBWt2rJMASgHUn+DwfRHd1RA afT8kL3pcdlMknfzq8JaCXFshoYp8qfmH0djqBMf1aKtetDTSKxkHwjxHjK9lT2q5PqLUS v4KyJixFgXzdPb1CfQs6Jg7NIKMvuB4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-660-K_nqMDSSN4WPFTDThD3jNA-1; Fri, 07 Jul 2023 09:59:40 -0400 X-MC-Unique: K_nqMDSSN4WPFTDThD3jNA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 60093856F66; Fri, 7 Jul 2023 13:59:39 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4677C2166B25; Fri, 7 Jul 2023 13:59:26 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot Subject: [PATCH 2/8] char: xillybus: make XILLYBUS_OF depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:46 +0800 Message-Id: <20230707135852.24292-3-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: CDB941C0018 X-Rspam-User: X-Stat-Signature: 9mf15nzui3mks9pm8i3jkz4do37cn6n7 X-Rspamd-Server: rspam03 X-HE-Tag: 1688738382-888999 X-HE-Meta: U2FsdGVkX18zVJ/6hEgFfNauLNVVjgPICtqySHbocpMkZc066Q9mvUaQkTBYiaygeuDW5rIDK/iCywrmJzQd27iFhIgQLZuc8kFWhvju2CkFVGzjAW4/aoRU0bg7BuPa35qxTmSH/8wY6nojH5hca8mDsFj3k0t1xaWwDdo01mF1Cow6SRrzZWUkT1Be6ocNCFiyu4C3y+isJ14q1Qm2EK5lnGwObx7cYqc8LGAsQd/V719ujooDWlgb5Jkzb8xN627g+7Wo7Ri0HuqmFPIjSc3dz5S9BNrA+BnmPfmILv+Vpf+/xllqbyUKzJjetIz/x74P5QRDvURN/Z/p0TnSSY8Ih4bJJryLtJgEOSYLwVcjyuBSNvRwh5rn229uejKRJxJM0/wVO10KurxhRzFgmrg5cMx3cD5lEcHXbJ+Be7gGc6vJ2EcsSnd/3wP0QYBhfewYyqtCQDIorrE+e8eiZ1SZtmOA6qlpu2i3kZUIhIRLL+KT+KcgW6B2ZiuRAmVET2c8fKtqW4EMKDdOuhLt3cG2RnkoFfNHNQtBY8kDp3DYU/+5N5Mb9ppiok6AR0UvB70ZNHKqwB/Hh7NKL1RqUJRfOc7Quap8LGOBEoWhORc+eb32E/dqeClm/j85L6jQrNu43lcLJw/4YOTLvlhyejxbuyoE5YYpOA3TVZJ4iW7edFxOw2SziwlSKSQhO4qYk3mPyQfK/48N41amLGZfKayyyBBvvsHhXIhHb8XSYMzBXDbTMEBauze/XL0kMj/JAgJcBMfdwsh3xa9bRCsJypsE1sgoEsp27w4A4AvOjAa9biFABqbVyxyTJzGSOzVdBl1f/PrD1WAcTl2oa5+xO8XOe5/LaUIQIEP9QSL8FG1AmQOHNBWzQqgY17jfQuCMf6zI8xY7l7XGrbIUG52JgK3a4sXfsowWpY6XhYmqz9UZUThouHVwFz9p0vaqitIvMXUvtrCr/zUqySbI1cU YniHx0E0 4r9LOn0E3DZNgK4bsC5FPNWqN02dhcqUtJEq5npGQigUk0RcoQDoKKH2KF7gMyCLUV/MOoTc+Jp2djB9uyhJt73nMtA5sKeShIq7j8gf0LlsA0/N9/1tV5CKyh9hce3FSDNicfGbPab4rKYSV/mLFsU+jkHcGzWD3lsfYuKai/SAaFFIfhzLPI4XxJN/P7F8RVMCIRVOcdMbP8xMQeBy0g/KQHv/8cmMxTDN1cLcf/sLUuBJn0AJGzNqLvqy0UY2kOA1PhDpl/l+MQGyWjCL6aLX7HAFlmIfobbPKlA8KkIB+PhxOAX9bxro+D9ZAyyFWo/pv0P8qzqBLSNlrvAjuKiw5B8Khu+U0IYegIUH+6pRYbEpewnt0efEiI9JB/LUYAwxsbHU4T9bc1HyReq8b+xD7OZXlB8/K9FTi0u7EqcKXl1t5XiFKkJ1kSUDJZ9uZmk+aohmMv/ybdfs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let XILLYBUS_OF depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset: ------ ERROR: modpost: "devm_platform_ioremap_resource" [drivers/char/xillybus/xillybus_of.ko] undefined! ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Eli Billauer Cc: Arnd Bergmann Cc: Greg Kroah-Hartman --- drivers/char/xillybus/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/xillybus/Kconfig b/drivers/char/xillybus/Kconfig index a8036dad437e..f51d533390a9 100644 --- a/drivers/char/xillybus/Kconfig +++ b/drivers/char/xillybus/Kconfig @@ -29,7 +29,7 @@ config XILLYBUS_PCIE config XILLYBUS_OF tristate "Xillybus over Device Tree" - depends on OF && HAS_DMA + depends on OF && HAS_DMA && HAS_IOMEM help Set to M if you want Xillybus to find its resources from the Open Firmware Flattened Device Tree. If the target is an embedded From patchwork Fri Jul 7 13:58:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13304906 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6FE2EB64DA for ; Fri, 7 Jul 2023 14:00:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 678298E0003; Fri, 7 Jul 2023 10:00:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 628B28D0001; Fri, 7 Jul 2023 10:00:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C9DB8E0003; Fri, 7 Jul 2023 10:00:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3DEC18D0001 for ; Fri, 7 Jul 2023 10:00:03 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A4DBC1A0DC7 for ; Fri, 7 Jul 2023 14:00:02 +0000 (UTC) X-FDA: 80984974644.26.514EAAE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 592D640010 for ; Fri, 7 Jul 2023 13:59:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hfvv+j2x; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688738400; a=rsa-sha256; cv=none; b=v2qKK/jNIz8SKzXh1D1Z2ZfwOrGAzJPZgxSWZiHhd4hm0C48qLlXwguxaNUjzw1HuijBIC ROMavz14LiUo1cQXuqurMem+l6N9J0lfOKaNioWiEqI/CsTzfmIPDwt/Rt+YnXa86W8659 TdhUjvZAm9n/johfyRGHyqpKnzycKJ8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hfvv+j2x; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688738400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JY3wTP5/IT5Fuk6lBBENe/zUdzUPUkbX4RiZeJtGthU=; b=oUsKszXVXnKMoJKjftXzKcCLs4bK50uWmeY5QYkAvUwu97U9CpC23eWarqY0k9JATijr5D j1D383kHYlMpWTMzAQQqOFczLAzsgixA1RhQ3LgYvbNq8F0yZSE/QyBB5pHVbNr1Uieyey s6X2vA/rozb8++ZtVq5tu5PVvM8uiEo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JY3wTP5/IT5Fuk6lBBENe/zUdzUPUkbX4RiZeJtGthU=; b=Hfvv+j2xcJoQj9OrkpSxiT0/QSjeX0oPEbg3RnboDvUSBuDqdau3HQiyuI2+ELCVaChcKS khZxilkiC9LYAw7MiUANtt+KTa6oQaqZpAX0vTta5B5Q7BFEwseEmyXkIjMW9i4TCh8GOG DIrNst9I1CFDpbBf2MOYCS+H+o3e/WA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-613-sTmYJ2YlOgSgjm1LqC6m8A-1; Fri, 07 Jul 2023 09:59:54 -0400 X-MC-Unique: sTmYJ2YlOgSgjm1LqC6m8A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3B5BB856F66; Fri, 7 Jul 2023 13:59:53 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 315AB2166B25; Fri, 7 Jul 2023 13:59:39 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot Subject: [PATCH 3/8] misc: open-dice: make OPEN_DICE depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:47 +0800 Message-Id: <20230707135852.24292-4-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 592D640010 X-Stat-Signature: 738q9yt7rt8ruwxj11b58ywjxp169hhe X-Rspam-User: X-HE-Tag: 1688738399-342840 X-HE-Meta: U2FsdGVkX190GdpgsQfqF/l4Wng8PveR8u/96UZ71yR5TwqKwic1XF0Cn+tT7nATOYgqnImMM0f68WAsOhiecoKYw6ytpsiYhRMWZq/lq4roAqorc1JXZVrmLLoOFKjfT3JGP95ihakYtdsxIXx6pbKrlaaM1bZDWM9R4nLOCUPinq6yDb83Ckc1H0T/b/jc7AdPmr4hX5Qz8/nztJQF3OctaOGRJj3SfKI4MLBigsl0Z2mEghepalI90A4Fzh5AmYSYwh99aqQQaBcSdtl24QTQLaWzbv7AzpLFBqwNMwOMBvbn17xiKVkaSDMfZ4sPoRT13Abg+vH/n3TVg9EtoMquy/6T+mgPe5eISbxchiCoqkUTpgnFGl0AtktEbykxmTtnG2adQVxd709gFrR7hJQIcTI0l5Cgv7racgWE4EcNiAwxZMl6qHd6WZ+t1djHSmuigvicovriOITJ2c8jdCoVBUaEk6s2NS93nEu1LAs9Am8ug1rt4twu9baGwuBeevJ0UZGwR+sx9Wag7D0Z1UxBQ/scr2RuCXoVsfJHyC+FEI1lp3L8BgDHgeQ2grwDmhVpHafOfiCpOuJ7rsU1CYlmOs01J8OMWltFsrR9HO9w4lXXSfvKpsUxwKXQSBpEyDUD09K0d5VlPUGQXP3S32z7Q+tdFq+mTEZ5dXRU/NSyhisjjJe+HwJoCHvk72C2rjHN3cd76MN0zlsFlM5C8w0q96bxA41Gim5cxahiYYxH0AUKpXb+fBEpTXjZVpkjacinwoBAT2Y6U1Yfe07Vl7F4OvVvrTaewEZ2u4Mq2eVPG0XWXg6eSsKz1BN7N42PAAt4SUFZZVOYdlIhoZjuXoU4vW8ZJYgzdIzIdUptly7E4XLbaAzy8qOELuMlvOGr3W4TJhsgjgeNEsIgDkZt947OVfpOHKbYHkoJbnBUznNcaF3G8sHU5IlnKIENES8nbzG2DyRhAO+h65+KdeH H/rYFDIk 3tqJRmPdTrKe0WN27U2FW2aeqkAb2jhTkepi3Bs0QgYy8bnSd1Tq5JIt+chWHryFa7c0uLFG2bQyDK1K9GqNGNwEV6yap6+IuWh+LnTyjXD/LM8iZkgWDv5SDe4VWqtfrnDAvMOzkKrtvUctq8rl9Kw3AjassyWHZsMXqpaEf/ittGTObgj5u8h+WX4AWXpsrpxBPi21QGKhrmQ7Aa4V0kCIEmu8uv01BUtcfv4RGYc03Iejpnt/TTMyTT07Y+kB62KgJuKjU+D02ZxrQCadmSejv2iKF5uQHVv711z+wHfZo6QOSnWSid9gwHExlkLopIjc/c4nLbImqs9V1dpkG5rKJ41sQySJ5FVxX6hRmGEDL5Bjl8fiM7YDTY8KULbkmhBUy/nIYWZvEenmAyJfDcCekwu+kBP0Hou9iZLI6QExp9vUqthCvsI3i7U4os3XzxJLNR3pKuMPNv34= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let OPEN_DICE depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset: ------ ERROR: modpost: "devm_memremap" [drivers/misc/open-dice.ko] undefined! ERROR: modpost: "devm_memunmap" [drivers/misc/open-dice.ko] undefined! ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Derek Kiernan Cc: Dragan Cvetic Cc: Arnd Bergmann Cc: Greg Kroah-Hartman --- drivers/misc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 75e427f124b2..cadd4a820c03 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -496,6 +496,7 @@ config HISI_HIKEY_USB config OPEN_DICE tristate "Open Profile for DICE driver" depends on OF_RESERVED_MEM + depends on HAS_IOMEM help This driver exposes a DICE reserved memory region to userspace via a character device. The memory region contains Compound Device From patchwork Fri Jul 7 13:58:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13304907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D1A2EB64DA for ; Fri, 7 Jul 2023 14:00:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A480C8D0007; Fri, 7 Jul 2023 10:00:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F8628D0001; Fri, 7 Jul 2023 10:00:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C0698D0007; Fri, 7 Jul 2023 10:00:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 798088D0001 for ; Fri, 7 Jul 2023 10:00:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 785321A0DCF for ; Fri, 7 Jul 2023 14:00:25 +0000 (UTC) X-FDA: 80984975610.05.A0D2C26 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 02B93140010 for ; Fri, 7 Jul 2023 14:00:13 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DLzUHdth; spf=pass (imf09.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688738415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HPZ+j/W/x+bTEIUCrpmryT6rAOoCFvsSsqkhgyHlcOs=; b=a7GM+2k3iEw1C1lpFyF7DOJZZtxBY/UOWbs/NTYE7ribAEvdYXug1/CeucjJ212pgCOrnT eR4PewmS16MxRdu+6TB+aW389ZAK4iq9OkHQZLMG4izsfSQbELexxJ/NORC8NQxWqlYZaG 9ZCfpa2xhnN5yDtS4jxhF28ZjIDlkzQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DLzUHdth; spf=pass (imf09.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688738415; a=rsa-sha256; cv=none; b=udUbNC54orExFj+T73k4jeyOiW2bCLU7AanSoN8RnoEM1QqjTEwZKiMZEXtZVS1UDxQdrH UDaIH7A5W338lN4rgxjvav7Kt7kU7hHxlMaCgKx9X01ctY21Wark7SQVeRs58VJ9HGcrWz dlGejwmyAyA0q5skzsJjMquUiCfipC8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPZ+j/W/x+bTEIUCrpmryT6rAOoCFvsSsqkhgyHlcOs=; b=DLzUHdthoOunr7DQLJbo1axZLKr+1dfnEDcNI29rNywV8FUAnGYqv3QBoDpXaU9yjilWmR eKj97judUHCVF/4R+QKrWovZLuph7TIIsWarCaASGCcwDvBP2jz+YfjPD9SSK2uuFT54Zv qyq5cmKUIWsEpbKDylgLz9Iw6kmodKk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-Y6FTdWTiNrKHrUZxO4Wg0w-1; Fri, 07 Jul 2023 10:00:09 -0400 X-MC-Unique: Y6FTdWTiNrKHrUZxO4Wg0w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A2AEB101A528; Fri, 7 Jul 2023 14:00:07 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 34C782166B25; Fri, 7 Jul 2023 13:59:54 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot Subject: [PATCH 4/8] pcmcia : make PCMCIA depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:48 +0800 Message-Id: <20230707135852.24292-5-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: 02B93140010 X-Rspam-User: X-Stat-Signature: wngjzi8ce4jguudgpc9np854o3hk9175 X-Rspamd-Server: rspam01 X-HE-Tag: 1688738413-991608 X-HE-Meta: U2FsdGVkX1/QopWnAkFWbm58KUaFWdxL3v44mw558mxswoC7GBEBUI/08x7PPZILi365WJNEKZ3v2nNlSsbX6Dr7rEWsYeVFmNKjUcmGtN61R6eS0Vs8TgRT6i7Dt05iTVSbBUynri04YmtjKcqn5Dpa1tmhO78ptLQkwk19BQOEpjGFuEnzhtNvYpzuZjdf2tw/2beSgTrMwcN6JQ09guTvxFQluRLi8E5k/RQ8LZXD6eiqS52Mbp7ll6r2WpnEfdg9ZXRGEBAbKWjvwCxyfEpQhMtFqpiVK412tcWpBJs9djE1PrPDlJCt2u5hOo4Ozi64kSWw6w/LAlzjXDpTCAY3jHpDnyIMqIxzcHhISo2nvhXIdSSRsls9Rr3LjiN5/kMHLII8kTPO5EeMlYrUtc9FRFV5DP5v8q7tajpWPU6ELOS1csQWmMTnwnPjI3ZYA+Va4A8/4jAhw1wWeDuh/LA8Ru5KpBxzrU1zx6DNuoIgsx6AfJDo4Z6A79x4N5pzL0MyYDPmC6tqAVCVMiDLY3XRyODMteG4H0vo7tnl40MMTm0UFxWwFuH1HS/Vsb9AZLxDfXIa5n3Lqb8dS+TiWbFxuAB/Hx982APQGznpi1NXomOgD25rHa3psAPE8/nTzCfYuf8stPaz6j5aYm2l560k2EOCtFMuqMYY60BRbk64M4co/xs5LIL90fDIfpFgo7ByacVL3z5tUaGl6CYQZZH+wxWzjVHdFYfCyMRbCDAdjEPVgYo+7rTg6q3XXeruDN8WPa+j2VdN7nx8ehn4NcIjhktW/Ptzs5cFiyjTycUy7wvaEPswjYeitSSuHGG6laCJEj3K0UAKfVYl9TxLZxy2fWgoCUFED3N9IEsRU1qkfkEkNWGEQI5T2FUCjMidQcPYzxRh+8EuuwX8InclegIGcwyiZ4gBXdi4G8Ttoxq25brpN2oB+iRgiLGkcBOIfmC1WloKiUO/h6s64HA vIS2RjAv MHIsecFqGnxRmygBN5t6ZeV9T3u98vHpu0S2M4MokQIKyv6y3fmLKSsdoFeSgBvyVljT/sLGIC7W4jaqLeIG1p0waKhHE/r41WGLkoEdV8QuRYZ20jGr2jarDQno2hj0SFB2r/AT01nxGT5EaczzjFflYTnPnvCyz4+n/7OIx0uSMmDlBapsyGXGne9kCceoXIumFV2sOpWDFlCqhqiJnRwJLmqFIdSl2wKHgTZyP3jGRnd/20UGOrfWYEDkgLz6vzXPScZXpdzKQTUWBAx9VPec1PEiNZZb4zOD5IdoL5dzdfj6VOf8NIItUdheHL3rbocNjDFqiO1TIr7ETV6eVdcdfAcc3gEmxySIuQ4s52fev3CRRmKAtikTkkmmwk5t2e4ZXxNGsVJdYaIgACYMNS3ZbSpWj/2Lsxp+wPH2ENn5HRz3oIJRL3IbQ4ZZSDXfDlJ3r4fTHAa5NZuD/28+jRoxN1hXmQlg/zwJwAy9FPvO/XTBDL2SoR2JeCFZizKIX8ijTK4Oz9ELiWT2+WSv+grfdu+We2q73bGLO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let depend PCMCIA on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset. ------ ld: drivers/pcmcia/cistpl.o: in function `set_cis_map': cistpl.c:(.text+0x1202): undefined reference to `ioremap' ld: cistpl.c:(.text+0x13b0): undefined reference to `iounmap' ld: cistpl.c:(.text+0x14a6): undefined reference to `iounmap' ld: cistpl.c:(.text+0x1544): undefined reference to `ioremap' ld: drivers/pcmcia/cistpl.o: in function `release_cis_mem': cistpl.c:(.text+0x3f14): undefined reference to `iounmap' ------ Besides, many other Kconfig option, e.g IPWIRELESS, PCMCIA_PCNET, PCMCIA_FMVJ18X, PCMCIA_SMC91C92 which depends on PCMCIA also will cause compiling error if enabled. ------ ERROR: modpost: "iounmap" [drivers/tty/ipwireless/ipwireless.ko] undefined! ERROR: modpost: "ioremap" [drivers/tty/ipwireless/ipwireless.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/8390/pcnet_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/8390/pcnet_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/fujitsu/fmvj18x_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/fujitsu/fmvj18x_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/smsc/smc91c92_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/smsc/smc91c92_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/xircom/xirc2ps_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/xircom/xirc2ps_cs.ko] undefined! ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/arcnet/com90xx.ko] undefined! ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Reviewed-by: Niklas Schnelle Acked-by: Arnd Bergmann Cc: Dominik Brodowski Cc: Arnd Bergmann Cc: Jonathan Cameron Cc: Linus Walleij Cc: Thomas Bogendoerfer --- drivers/pcmcia/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig index e72419d7e72e..dddb235dd020 100644 --- a/drivers/pcmcia/Kconfig +++ b/drivers/pcmcia/Kconfig @@ -19,6 +19,7 @@ if PCCARD config PCMCIA tristate "16-bit PCMCIA support" + depends on HAS_IOMEM select CRC32 default y help From patchwork Fri Jul 7 13:58:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13304923 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A492EB64DA for ; Fri, 7 Jul 2023 14:01:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCE288D0007; Fri, 7 Jul 2023 10:01:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7F148D0001; Fri, 7 Jul 2023 10:01:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A46658D0007; Fri, 7 Jul 2023 10:01:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9391A8D0001 for ; Fri, 7 Jul 2023 10:01:54 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5193B140D86 for ; Fri, 7 Jul 2023 14:01:54 +0000 (UTC) X-FDA: 80984979348.27.AAA6BFC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 7F86C800C5 for ; Fri, 7 Jul 2023 14:00:30 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ah6bZaw8; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688738433; a=rsa-sha256; cv=none; b=eh5IHpNpJ8dcPDHQeg/SiVCARl2SuOU5zqif9qjIkLbIuPQfbWMDUEyDIiNqSQgYfnkexB EJbACblMVeMjhfkaOLa2BLokQyLUlpPaMkqjI6MymgKqU6t/mN5NBwhDOLJvYrheFMrU0Z C69rDnjbKQ/EXc4v+G67bDC+abK5XyU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ah6bZaw8; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688738433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tw4V2NfImeC5GfdO0ctBGdDxwJlMQmkR6fz8vyJ73Zo=; b=7s3Dt78y849gqbtxHtVtsvVvNnHexirQDm9IDV3JDru9Rs5PnQ17chQuHKBXJOATZWgu1P JKMNFe/d8///mKY3IBikfGvGnkA25hM4a97uCWLpdePTdINnwiP+5Hfp9EPWDGo6z9/cwk Y8/ajpBNJ5u1LAFNT5zYeB8LA8Dre0g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tw4V2NfImeC5GfdO0ctBGdDxwJlMQmkR6fz8vyJ73Zo=; b=Ah6bZaw8+YzP88nZEJpShZQWy0LBJDP5ZlN5f9uJ1rQMQvVJdOgd9/LtVftZgmntbhkcVz SHUXPRDsdMyx+CesHRlYKaaWF6Kw3Nc1q+QKV664LPCRuDruLHdBZMeTCHCIyYNn5DnoaM pM/0zW0uJix0mlxXSG60oDtDN+7ve4w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-GcVuy2HmPeOr0kuq4Z8fqQ-1; Fri, 07 Jul 2023 10:00:25 -0400 X-MC-Unique: GcVuy2HmPeOr0kuq4Z8fqQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1BDDC88D543; Fri, 7 Jul 2023 14:00:23 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 594D02166B26; Fri, 7 Jul 2023 14:00:08 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot , netdev@vger.kernel.org Subject: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:49 +0800 Message-Id: <20230707135852.24292-6-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7F86C800C5 X-Stat-Signature: s4jq66wbda7ygbfkobk77iuiwfoit7a6 X-HE-Tag: 1688738430-38707 X-HE-Meta: U2FsdGVkX19QOoMtY5syvN6Q3/A0yoak7nAr70501xS/akkt0zVSraRn+n7lhdxUN5EU15wion4Y7e2v6Vh/HwJqrW+urZTnLLaWSXK1VjsCPnb8r2sUPP3vk8WwYdt7CSLQNarmfL8vvJbz2CFIH++sKek4ZB/eK6hBAqRUS/pOx0rScdl6jK30B8lXQjranbLb6PKn5Y6FPa40E7hxX3EDgMpincgsu+xWd7OOegi5yYYZYzObXiVaZ3LtnbJJBsSReAVq7g/c6qc1NDd4pHa7boSEcJnSNrcgItwlmaT1uSteG1Xcb2L5iAHL2fdPUb5m2v+aJBRhRGzz0lOMhylVOQVmyMb5WyDEQD4EmXITkYKEv806hIXfA3JfhJnvre2V0Exqs5BqdmunLChVj0Fo+oTpuYh5d6jqsFl8TZ1vp4nLi70W/RlW85Q3/7Ip2x9tncMtpNSwkSumKyocRqBPLxCJ5u0XR6mmef54x6bcNe0ziUD8hbP3aQAoKRfPBz5tMLNpOfq8ya5K4GZGj45pcddoL4j7HTrp98ZgiVrB8KUf5qSNGwOzSshPm8e7/xGI3QNX04FKxwAzQqENLWHnT5zlonSrEUm5Pe3V/YGsnbHncNxMSI1KN3t0qcnLhu7FMevhJE1mJ9PoUEbXeSmImeQAwqd2S5jItuF5XUmzXBmiNB2Z/1pbOkgZO9PwsJnIe02A7tM1uEyO3B/l7ovQQPJNmL4r9WYwz2lDH52vO/vtGJWLoKglevV8mpGuV6ukvQCJmgzSy6RgxL7LTXBM8h22vLOahoVGnHkf3ybkCnDEh0fwEkaRKAuJw3hiHR77/ii02m+fp8LHuzilEU4rTqzYw9OwbNf+Wjfe4aaazNvHz4qjwlFn8WFG2U5NZqaIFkocg4OTwTQyuZrGTtXj0ZKJP7gxHuu3YwVqMTq66WoaE+m8msquXVIgDD7vn0jNjE5KqL8OnK0ytzo ESSfDt3B PZsGWHtphd5kRrspwqDjPThDNs90VbeZY88OVQuVLDCrhPEEH6W8jpXgefaaSp1yIozPswEEFGF+stLA1WI8jbw02oPgczoOzJ4iVRt5aJKthnyoC6602provivVtsMr0POOq59uaJ7ptimQp/QKW0O/x1bAKzX4ZvMY9MEM8/Bumi3q8CMX/B9oKAC2nmx4MOm4/qRCaLdo3Qu0RS3eSGSZjwRANDpvjWzq3b1Nl0vzXp/hwdVfu2SSBu9jcfF0L5wzCSr/wPWk04T+VdRF/+CdqKo6B+dv+nTwTe6svOvZhAbCdFZvbklfSYeTlLI25FubZSVzK53D9l3HBECteI9Hy1EYIKfyaVOEtt9p9rb+E1b55RpaPK/rPlzGta4ECyeCXCOj/i2tLS8SV8XTcOEEyK20YeQomQuHg5yq3ikQ969DsKkLUU8FRk3CRz1fDCDTtXufQad0MfNE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset: ------ ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Joyce Ooi Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: netdev@vger.kernel.org Reviewed-by: Simon Horman Tested-by: Simon Horman # build-tested --- drivers/net/ethernet/altera/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/altera/Kconfig b/drivers/net/ethernet/altera/Kconfig index 17985319088c..4ef819a9a1ad 100644 --- a/drivers/net/ethernet/altera/Kconfig +++ b/drivers/net/ethernet/altera/Kconfig @@ -2,6 +2,7 @@ config ALTERA_TSE tristate "Altera Triple-Speed Ethernet MAC support" depends on HAS_DMA + depends on HAS_IOMEM select PHYLIB select PHYLINK select PCS_LYNX From patchwork Fri Jul 7 13:58:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13304926 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DD0EC001B0 for ; Fri, 7 Jul 2023 14:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BBCA8E0003; Fri, 7 Jul 2023 10:04:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 144AC8D0001; Fri, 7 Jul 2023 10:04:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED9B78E0003; Fri, 7 Jul 2023 10:04:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D6D018D0001 for ; Fri, 7 Jul 2023 10:04:15 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2F2EAAFDD1 for ; Fri, 7 Jul 2023 14:04:15 +0000 (UTC) X-FDA: 80984985270.22.338AA5B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id BABBF400A6 for ; Fri, 7 Jul 2023 14:00:44 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZExKTsPg; spf=pass (imf17.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688738445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CWfLRI5TOebRN6fQYNsjbIhOePrgTeydAOSGhfAOwjI=; b=pTsXwZvaN4SYe4uPTJSy1aCYfF+xD/jhyCRcye9L3UwFw7TObJ5Kufx6uKDhgApnOeP9KD jNIorYdEV60tm7iwOYe5tOWnxzebGXOPsn/+6wXvWt98QfuPXzPQ6hL0YWO9EaSQnEkfNN l1IFiB26eQRlg5JfquZsKj+gnpFWFOA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688738445; a=rsa-sha256; cv=none; b=WpyQohOJkPN4NF/6MXds2LEUdCkYBeSzOEwEX4NG3XpAkMslhG7GFbGMedlWKZbPJ+yt4B UGdRl93JHkhXdZevVV9NApZ5y5Gur18u/TOADxM6tBsRq68iiAtU2ANkFuHddJNWbQSELr 8Fvo84IF1Nwv7UrHOMpST+57P6zxJwA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZExKTsPg; spf=pass (imf17.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CWfLRI5TOebRN6fQYNsjbIhOePrgTeydAOSGhfAOwjI=; b=ZExKTsPgmCYEZdZVQYqSir9ElisNgST4rV23LV7uPTmsIkznw6jbzZ1UbyI19HGc/X1N1F H9K+RX/grXEboDxgTJTKyY9r+tamYvPdOnxK+CtnXPLaqeZt9Gf5LUFKL4hrJhvZOiapwJ AKdKqR1Jx15WtBJQ3Y0f0y9PZY9KbHw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-464-zGZQbIWXMSycsrfTt_BANg-1; Fri, 07 Jul 2023 10:00:38 -0400 X-MC-Unique: zGZQbIWXMSycsrfTt_BANg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0AE34104458F; Fri, 7 Jul 2023 14:00:37 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0FAD52166B25; Fri, 7 Jul 2023 14:00:23 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot Subject: [PATCH 6/8] irqchip/al-fic: make AL_FIC depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:50 +0800 Message-Id: <20230707135852.24292-7-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: BABBF400A6 X-Rspam-User: X-Stat-Signature: upwtjfq5tctohhp5crcfu7ukcn57qszm X-Rspamd-Server: rspam03 X-HE-Tag: 1688738444-851427 X-HE-Meta: U2FsdGVkX19uBeH3SdlUHBg3w7eCCwgtgl45XiyslFx5fNv3u62HmSLdxKBBKm/325DUsTcX75XY/iy09FL39hSudpF8wmzRKTEMv0iCspsTAYD6V+AY0ES5LL6KWIMF+BmD/kf3rVPP2boLyZ9HScQuJ1VWehwjwEfeCL+vFpUDyom/zHC52SoAF3PxIRI9LOtkTXiY54EamgW8D0eosSeFGZa4KtNaryFBCjUzgaurwTH6JaZz/iV/tSAkcdVI+deb7HMYiBKV16jDruLjDTqTehesV77WOMNu8nvdzsnfo54BaZ70yGePlubMW8yeXEeWgXMC+wJ5dzPLp6cts7WTAwg55GhruFDVs1aC2nqR5ZL+gbmeFwUVVfKMwj+jMepAivHyJIpTN+TMsB3wwR3a0KrEa8TOM1++gq/aurjJ+W0mfNS7QLoi9CC5o1l/tq0VXqFeKZejKINF91m+mdHEvkaeTRMaoR0TrEp/nI5VMOzFI+dApBwfnNj8c8xKeIoti5q1AXj+Zm/1tMBjcsev5OZp03/IjyC5Uo0cpEKJIBvBdJRWqGbXoKZibAFIrFJ0yrWX6Z5CrBu6GEnS5FjwU+aH1K/6AFqS8SC+yM1ZIpc+AL6IMAIa6JGc9+dAOlKpP4l/21B+BNtCHpHH7eMnrv6H/XZ28gxtRlKR1u3GzdgZLLFf1ZKw7DuE5tKoYhVmVlLI3/phlHMeoqGUEcsghLtWICAT2ZerZqi+9V9BT0fzNTNJv2Db1mgU2QIMUrjWAxKhO3lkpPRNhPrVNOkS1WPAyety8lenM6O90bmfGNRzLkNKi2Gr+iUqlX7pXf7R7jt+2GVj7jIQUMXaALIph0kLqbz6104iEZ7XPhk9aPT8Mbw647QCMGQUo8jh5Ok2ISubsajPMvaSXklFN5u0+uKrtz2sp44+B2tpyWp5pmhwaE/M7WZO2DO2eUjCcvTkTGAF9fM7pMKTQ3c f12zul/B 5EOh6zvjjcCafJosgrzkTwuIV7JdEZYEAe3MByHbbBOFo0OnFu5Hsi7eGSc4z1AelgxIHEovTelXyCNPPDGYRfV4aqnWyWC4/6ETe1Ia3oyBpzQENeYYZxBgm389MKjLCaOqSNwyx3FiK6pKfwoq6bTBihHtrMG00Wtrp41h+WSRixQPc000WI59iw1hx8bWkeYeN6/0y9phfqQ6GDpGw5zG1Nbz9f9qbidoLsX2xFF/FGXx6/oUDagIj7kKY4bSLhgxJ9Goaej4dLT72ZV1D6JwdE840dgZ+Z3BkljguFRZVMlz2gYKxapdK2gbWO2pqmCzmKWT7R1j6olvR3aiWXUXdW4RMnxY/qA7rdnbjdA1RFQYB+JN8ca3Ndw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let AL_FIC depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset: ------ ld: drivers/irqchip/irq-al-fic.o: in function `al_fic_init_dt': irq-al-fic.c:(.init.text+0x76): undefined reference to `of_iomap' ld: irq-al-fic.c:(.init.text+0x4ce): undefined reference to `iounmap' ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Thomas Gleixner Cc: Marc Zyngier --- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 09e422da482f..4b9036c6d45b 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -89,6 +89,7 @@ config ALPINE_MSI config AL_FIC bool "Amazon's Annapurna Labs Fabric Interrupt Controller" depends on OF + depends on HAS_IOMEM select GENERIC_IRQ_CHIP select IRQ_DOMAIN help From patchwork Fri Jul 7 13:58:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13304924 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABACAEB64DA for ; Fri, 7 Jul 2023 14:02:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A2198E0002; Fri, 7 Jul 2023 10:02:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 452448D0001; Fri, 7 Jul 2023 10:02:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31A428E0002; Fri, 7 Jul 2023 10:02:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1F4798D0001 for ; Fri, 7 Jul 2023 10:02:18 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E78B480DAF for ; Fri, 7 Jul 2023 14:02:17 +0000 (UTC) X-FDA: 80984980314.02.372E47D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 9BE171C013E for ; Fri, 7 Jul 2023 14:00:53 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YxlFRE65; spf=pass (imf18.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688738455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xp6rJXv98R80P+/7EHwV7cdYFXbRakzdmgAQwoPVD+8=; b=cj6CcL4ZJaZObR20ZCaE6/g9JTVvPABUtf/DIgi/00bC3Ia3lZlhLXDrTLDJaqgouVCteo bijkWNO/2n9YYzALFajBj6Kd59Nx2sK/D3EKVXIFpP7CG82nGkd0Afj+DWDUsZD8lmwBvG 4fcNhXk6OYN805MPTn/tkilWRFAXr+w= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YxlFRE65; spf=pass (imf18.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688738455; a=rsa-sha256; cv=none; b=yOXnbkSS4fSf2XXILHajs1DzppLPScQDHNyIl+HNsdNjZGo+XdxFwjlyOhNQ1PNpwroDRN qBEZ73CMpv/6avgbNkyZEYYSuvlhCuFrJR7h4zPUyXWeNn0e3PEjSI2FtuXD/Ma5f07T5f ZdNhGy27FQs9PXmqmmSa6b/iWs7nNhw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xp6rJXv98R80P+/7EHwV7cdYFXbRakzdmgAQwoPVD+8=; b=YxlFRE659Nn/v7UGQHjhv+1ilo+Ttq05+rUZwJRIoIC0VII7/5x138v6Ad442577n1/c2W SeGGgrIxyV/eofWz8JfUNZMyMBrComozAQ2Rv7gRn5g3r9U8xOC0PtkRJAAoeihASNKc7v aisWs47yZ4IvE57iFlAe5oVT5otc4Jo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-357-nvdKaUNuNZK_NsivSrgL-g-1; Fri, 07 Jul 2023 10:00:52 -0400 X-MC-Unique: nvdKaUNuNZK_NsivSrgL-g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D30CF1C060CC; Fri, 7 Jul 2023 14:00:50 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id D64122166B25; Fri, 7 Jul 2023 14:00:38 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot , linux-clk@vger.kernel.org Subject: [PATCH 7/8] clk: fixed-mmio: make COMMON_CLK_FIXED_MMIO depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:51 +0800 Message-Id: <20230707135852.24292-8-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: 9BE171C013E X-Rspam-User: X-Stat-Signature: ejxfmgq47k14989ac3n6xqjxrkziwmek X-Rspamd-Server: rspam01 X-HE-Tag: 1688738453-242487 X-HE-Meta: U2FsdGVkX18VFIu1DVgkqOZL3hUnaZbv4XBleIWzRURP1sFjQCSpfWQp1MzLOzESXacQAuY06uiUvoixPMWQYrRLm+kCRecT9cfYtg6rE/CkRedrKKyoCKXhGxZT5EMgougCeVTCzXlcj849obktMVhAbd3P8ysbiw2w5F6DnCDIQWf5hftWFepYIlLqHk0aSC7hGvnUj8GXD2PoyqerEuStRoqpEm2yXxUYW2zACFAII5buGo0w2IxvRsuS2fFNaYagixY9QuCI/Z8xf92emxxQutUUX0Ak5xm/4eOkJ34hFXqS4Rzca98tID76DrujveuDBWAhcV8W7cJ0iktGRoU9o5YTBtiOyC+jx2PCHDfgdqetYNS32XvQmStsmR4kvwjF41cCAbjOsoXDecxf40nEsFyKpDxm4SaKYTbxdmMWx9K1LYmup83rZKfQxrCBIU5onWsDSMYx/M0shdyeRxQKx8JtgJwOYrOnlfkjHhOWNVjQ3v3rPLqvNdBzjZlKg3RuVlvKo9eL5lEcbVX/G3Ty1yE6k33kfig/hZgnTRiloA6NphWSNsCcQV+ZTwueySjl7F3VSoHpeFet96KeNUf3BLDrPseu6kcAzg6i/Y5LXas+nndY5ChZQ+PXc7BVoT76C0hMU13UwiEh6HHbhCXwK8FZQgF22e3Hp2MZ2l4ukAReJd2fH+OrkeAdAVrvJDRTisMw0CysHUKEW7NZ5Z1TKiC9UC1NZJDYMuZDeCA9qPO5lbAqy96VeqebBAxp2H362ejRyvSfAzXWXI4C/NheyrTtn1172Pu6cSzjvTD0ZaMqK3ArHCjNxsspsS9uJvZPbt/CY2BpbFyixntj6oDZ30av1u7DWnLZT5BFed4qKzlGiy/dIufRWjiMtm/ccmfKuDsr0j8l+gMIHgifRQY3uPDX9Hf8iqXnGlJPe8EO3+7o4rpOFXh7RykcxFy0/qXKjGGKEC2JyAzAVl9 26MBLQ0+ eKpot8Y+9LYIRTPHhErDRZDj5y+8U+ulRBN1O31f0sohoKYR4RXrKOGppQiu0ZECfo7rKUHD5v/U0Y16ijCGHnZVmHPsf84/TgC/KjOd5z9dtGNauwxe4fFEhVNi+u+bzCTyzsziEFMmagC/6UIVwFoCUjQk7Bpz5Hu+hnCsB239RSCeXk5m9k6DTjl4TDbTha7PanilyofanhDGBmuL3ZdjE6v/KlSdiZc0z9ydRQlluX09uK9oZ/ryzHH5XgM7/g6Xa5Rr4SBLdbYA5JpJEpcP7H54w95pGBbcNgo/oD2NNkGVNUseWq0OHftL9z3tdEqnvbMHoRLNwpKrezUG6aNJ1eV2p6G8T9HVH6k618PzA5ZZi5/I82dUCowa3Pcet2N+rqFfV5844VATJtdOesGnUbubnvBlPfU+9o+Z95PI9AUrHdz7XoIhFAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let COMMON_CLK_FIXED_MMIO depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset: ------ ld: drivers/clk/clk-fixed-mmio.o: in function `fixed_mmio_clk_setup': clk-fixed-mmio.c:(.text+0x5e): undefined reference to `of_iomap' ld: clk-fixed-mmio.c:(.text+0xba): undefined reference to `iounmap' ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-clk@vger.kernel.org --- drivers/clk/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 93f38a8178ba..6b3b424addab 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -444,6 +444,7 @@ config COMMON_CLK_BD718XX config COMMON_CLK_FIXED_MMIO bool "Clock driver for Memory Mapped Fixed values" depends on COMMON_CLK && OF + depends on HAS_IOMEM help Support for Memory Mapped IO Fixed clocks From patchwork Fri Jul 7 13:58:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13304925 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00521C001B0 for ; Fri, 7 Jul 2023 14:03:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 935DA8E0002; Fri, 7 Jul 2023 10:03:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E5A78D0001; Fri, 7 Jul 2023 10:03:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 786B68E0002; Fri, 7 Jul 2023 10:03:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 66A1F8D0001 for ; Fri, 7 Jul 2023 10:03:20 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 32823A0DBB for ; Fri, 7 Jul 2023 14:03:20 +0000 (UTC) X-FDA: 80984982960.24.77B9A87 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id C62CEC021B for ; Fri, 7 Jul 2023 14:01:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i+RzuGw+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688738473; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hsDLZOIaMsdutOawC63k62k7hxKuoez0tGZig9GdB48=; b=mbaUnPQGIO7QNbTBghSv9/AQIfPa2pqfBwYyQE1gDj9V1FkYg+63eG0cS4HE1UkFFYggae O2i9ZoaXeWb8hde0JEQOmSGYrYyGMYcNLWmARQ9V35UYGTbH/CA++QjTdveMG3CxodFqbF tfDiMjuqs2Q5EOxI6RE602Ry6CXxhus= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i+RzuGw+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688738473; a=rsa-sha256; cv=none; b=voSw6EKD76YmykhmYMYDfspss+Rn2qEK4Co6lrQjq9AsTthoPzv2/5g7kQf7PSXMq+VJw2 02HUsEFyGnI1MudTEl41Ljv6TC8F58TRZSMYWISuBCgABBiPnQhwdltA+1vfeFcx7SNZwF 0/8Sq2lt51V1Z5agw3SwV+e8Khxc2EU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hsDLZOIaMsdutOawC63k62k7hxKuoez0tGZig9GdB48=; b=i+RzuGw+SvMpOQnYT6xdWgaJnsyTLNI3wNSGmmrYdbUN0c1YnJmZslYckylYBCgTVtBaRz hGkN/xr6yQz4cb/fybJ4wac1FzJ/wlKNmP9BG4crXH+H/BahMNukDdO7J2amD3Wp5thu+s M3x8e3lZlY/8ui5QK+6U3Rvu070/vnc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-_yX0V8PePHiNzeIA8hA2sA-1; Fri, 07 Jul 2023 10:01:05 -0400 X-MC-Unique: _yX0V8PePHiNzeIA8hA2sA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B612100812B; Fri, 7 Jul 2023 14:01:04 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id A18962166B25; Fri, 7 Jul 2023 14:00:51 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot , devicetree@vger.kernel.org Subject: [PATCH 8/8] of: make OF_EARLY_FLATTREE depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:52 +0800 Message-Id: <20230707135852.24292-9-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C62CEC021B X-Stat-Signature: 1freyc63j893kim91rbjbem3uouug7tg X-HE-Tag: 1688738470-554166 X-HE-Meta: U2FsdGVkX19jvlzw9+BgyA1p8qj7Wh4eegBvjR0zUOFUx1BAGO7tCF7xvdbqMLMToha4KuafqjLEJ5PT6k2QhzNCFFNh7pGfhmSqyOU2k4CElb1odRuzPqX/wYNklT+yvK7vdiSWtz5hKO7/EPNgXDRoGUjnvVsEeAWNSIG3fqbHXIWjhx1TdRtTY8RphG70W316gdx3NL8RncT0+TZYrPODAsMsTqQx3iSfiX87zJJLD2AfTcbiXMi81BI7VMJQxH0I6WSJ76umxhEDd4T612nXOJmSBAxyKQQ1KkLPaL0eAf0eyyqR292bVNRVl/HrsBT9V8I3tkkw2PcTJRv/iY21TmRM1KlnLAMDWovPBjIDjIf3H6438RBf0EirdnYvr/qj3nXpBY9t9ORQ111Arh8C4uVRKkAbX4dNGwWkwbBnO3fD9ck+5ZoM8k2kw3yyHxaXr0obbdh9AJ8beyvutpJRyq0H88jXmrQaF+L2j7dCclnFPTmshLXtDqxqmxe+StaZha/4ByGdFQt6WLa+CtgJmVIFDLWafZ/12r2WVvaMu61aFJio0BCq3VU1u2ZAdK9o2JyUiXgtE2/bObREiFtxOTaMVYlZnm4hyrYUX9Rt1xmzlJilUy189LuacEV44JBJF8cGC3+3UrOy0djE6yUwhg4o3MBa3lYW3FAoNYbXErgggc26hEJd1HJkO6KpZI3C36CzP867V2uloureap0SNeIEEABxDExDV6KM4gDHwNGIgIQxdZGOpCUuNiYwMaEkaw5pe5kgHt1KlxTo8nogVxGCTglKoBc/6EOqXHhg+nyz13RfLq0MxR8FVGDr8FmmkKkafWiH1hkEHP1K8NPwjxmweHuX2OvGekgHwZNlf6rCqipY9a/M5JJzE2IscgecTW64nCOdAUhFnbyey3xRKhAkhES/ZxS8DB2Sp2z327rLHjb+SJi3XEykqTkAHLfRWbzGMCDufKKm6ub VwotJ/p1 2DfcD+1ydKuGYCTZuUDuRNmc5b1qFddfeY+IMTCLC7ls/1RDfj2FGRigmrI+rg5JyeA7j1zyLlfx00qFrMo+fyHq7NF8Ebk8g77J2eXETQjguX6++dbWCscSo4toQSRTiYN8BYeWGTjsXeMChOW8aPyBfYW1NtW5WQ3rGhAO2voJghcAGuTmFWoIm1wBIA804q9iVwho3yinEYfb20YYvN4nHhJkjmhv0aA2lTEeiYwo5XkDt4/YjlumEeL4locb4FyppUADGyiNey1XWdbAvCcf/J8vTNtGUdp/3Rc13MNnFfY/Q0tveVye6VMn/6yeL88HZuUv/CjxDCHYNFKqnqiaaBNRIh1O/5bcOHJqFrAUEn3crfJ9lg86Q2IdyYMWxCyJBMLBlHe6XUKo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. In LKP error report at below on s390: ------ ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory': coherent.c:(.text+0x102): undefined reference to `memremap' ld: coherent.c:(.text+0x226): undefined reference to `memunmap' ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory': coherent.c:(.text+0x8b8): undefined reference to `memunmap' ld: kernel/dma/coherent.o: in function `dma_release_coherent_memory': coherent.c:(.text+0x9aa): undefined reference to `memunmap' ------ In the config file, several Kconfig options are: ------ '# CONFIG_PCI is not set' CONFIG_OF_EARLY_FLATTREE=y CONFIG_DMA_DECLARE_COHERENT=y ------ So, enabling OF_EARLY_FLATTREE will select DMA_DECLARE_COHERENT and cause above building errors even though they are not needed because CONFIG_PCI is disabled. Here let OF_EARLY_FLATTREE depend on HAS_IOMEM so that it won't be built to cause compiling error if PCI is unset. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Rob Herring Cc: Frank Rowand Cc: devicetree@vger.kernel.org --- drivers/of/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig index e40f10bf2ba4..da9826accb1b 100644 --- a/drivers/of/Kconfig +++ b/drivers/of/Kconfig @@ -55,7 +55,7 @@ config OF_FLATTREE config OF_EARLY_FLATTREE bool - select DMA_DECLARE_COHERENT if HAS_DMA + select DMA_DECLARE_COHERENT if HAS_DMA && HAS_IOMEM select OF_FLATTREE config OF_PROMTREE