From patchwork Mon Jul 10 13:19:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 13307134 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 941BAEB64D9 for ; Mon, 10 Jul 2023 13:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=m2fg6Qeh7B71tKwoAh7jYFinBZm5KKvkFaPertaYbVA=; b=SzaTZN1gcVfvG+ rDeLDcwrVlhDuuw/QqULsKgP7/nzaFwYUVYrPlgHpXB30+OynRfiCRz3NUzDc/d000qK3Dsi54Do5 5Gmi80uBucFMbioBJ1rWWfl83fmT4PCLNInd/y3URdSqVfOauvR1/NgzoAif31pJ8++uJgF5ntvMt GIDdrBuzF7LsKItpPiK/QlJhZC3jj2zWV6IDosfYw3WEd3SK62JlMIIjbnyDu6m8Wj08u8949rdxV OTYLKIPciBr20x/jH2eo8EVqirf0UKIVrhIftD2MdcIHagmnIPK7FnNnVHZoY2bGCtPSzl7VpK5/K sAdf5NDLOfiZdTI+1TTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIqoj-00BjmN-0A; Mon, 10 Jul 2023 13:20:41 +0000 Received: from mail-sgaapc01on20720.outbound.protection.outlook.com ([2a01:111:f400:feab::720] helo=APC01-SG2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIqob-00Bjfo-27 for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 13:20:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=htOVpUO2j8elDid3u3guFhgnz17pMmqPGz0E4aB5G8WgPzdgwgoY7jGCVXTQGpV+UKILVK356RCbdzOpZonetQaFT2IYIehIzNWpBW40B60z5bV/OgOViapPYzy/AxedSwGaee/DOz2SB4OWgDvI/UjidVNYuYQFNhgxCQqpu8ZrtXwI4Wn95ivvm5uIEpoRQQYstqiJoO5meMzYzIag02MmOuFbNI3kyHPlemvWwk1H+rjxqEwAv074wtjqVv2mXxZXWbOXSPj7wwd41kt7YJQqIRmFByb6HG0ZM51JOKHwt/lGidQv/sXpVDNlsyNjK/davTZwBQDDlc/v3wvD3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fs+EtTk758No/dWDSdfwTWpFXRynKbiaOREM2MESQn4=; b=PihuN6cO2+1tqQ0BxY9BkcZK5riTFqD4f5yrjqgIkFww7anlwdidLzB/7cXzPeUiO3JMHhu1pg0c5/XkdzSo0arJemMM6xRou3KQpX8IzVBFcRhpHIC7sRXDOiMgkTkDDEu0nkEroWlCHtXlqNuwZO8SCYhWQkRRRb+ajZ/zz3l0mYddSiZTkPZTmjgKUhWSKbTAqBjn3HWCNESJn5EOSDTmPJZ/T0kDIDrMrx8uzBptL2vPz4G1kKI+38gtXwUw3HTMte3xLVwfOpeGl+VjdAi4TSsFsVpjg36e/vDc5pZNvtu14ruVEheKRgUuIAadjh+2IzjnlvfoV44KFKlpHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fs+EtTk758No/dWDSdfwTWpFXRynKbiaOREM2MESQn4=; b=e6+SJ2Ff74lGYIRyLlWS/gH4e9qeUPe4UahvESCw6W7a5NGWTASypO/4BObv3ztcCKRa6o/qBpcVEXdDkx+VtWkyncEKU9LQk42dvSKgjmM8z0hCcThKEWbehgeY/M+otKYPju3lk3aJIY2OK8N+WdxstPpquwphCAUiANLsDWZ8z1NxXVR6y0mrvLd6v7G9TL/Zt74SxMPDbRCl16FrXarPh3QWsxm/lY5YwIfd4W38UhOcbvqShmWGRkmD71TwBkGKbb5O4MTmswcw6PGGQUXfoIR8I+EbsdTrKYDIgBIoK7ohJ8ezrxPLeSRkc+djzsYMU6yn+GPo0jmv6GFTlg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SG2PR06MB5131.apcprd06.prod.outlook.com (2603:1096:4:1ce::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Mon, 10 Jul 2023 13:20:12 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Mon, 10 Jul 2023 13:20:12 +0000 From: Yangtao Li To: Sascha Hauer , Pengutronix Kernel Team , Helge Deller , Shawn Guo , Fabio Estevam , NXP Linux Team , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: Yangtao Li , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] fbdev: imxfb: Removed unneeded release_mem_region Date: Mon, 10 Jul 2023 21:19:58 +0800 Message-Id: <20230710132001.50764-1-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 X-ClientProxiedBy: SGBP274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::17) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SG2PR06MB5131:EE_ X-MS-Office365-Filtering-Correlation-Id: c236b37b-e1fd-46d8-a131-08db8148639b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mS3vPm/H1rv4xygV6WaSNmQdASxQUrCoCXxA3t8M4RHe16SkoK8KwJNs3qdZ93Q/BC/zkKLIIwRMdYN9TkJyuQdUEMcYHmXRmOyf8C8BdNYlqcEHPUeyRTiYVvOw0koC90Ag/m8YsJKbTn39Esvv0UklLmI/4DTnzEBvjo6VqADLRM9Hw+iopl+ipuRwqCixSWZzqRRVrcVAZg7/xkaUkBjWP32iWQBjkV/44xfVCcVONQXPvFqICTnMAY8P3k7nvTHVG8wAi+KcIWkxkYR4h16321THvSmQP2uCn+Vbtj0Tl/Yuywmwonvb3O5A+q2eun2vKNE7ZAojU57h+x+x/aoaqTZ1nBaQ1fMSGRTE9s2dKeueQa5EgmJv+Ydg5hcaGtRNGt7sYdXqnGsvBzRU5gCBaFafrK/8IMfJLl+20IfhtsvA7rnCvqmRZ76zEH560dOoZGPDF/2dEonpHdfCeYhiEbNbVbDWoAc1w0YhGUdouGMUws8OYADAv0xLjY8s0ARsE+YSzADaAyOFikYUm2rWpz1PEWIEqziFP+G7hpRU3kLoKTuSaIjc6hGWvuFye7lLio5TnXzr03pDF8d1d33Ejy934XCBwMwUhI3cDZcmtr0ZSqNE/0RgKvhtfFnH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199021)(38350700002)(86362001)(38100700002)(36756003)(6666004)(6486002)(52116002)(110136005)(26005)(6506007)(186003)(6512007)(1076003)(2616005)(7416002)(5660300002)(2906002)(66556008)(316002)(478600001)(66946007)(8936002)(66476007)(8676002)(83380400001)(4326008)(4744005)(41300700001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: islLeWcQBhH4+AToX3FcMqMKCqus2bQKwqb3NNOwZNfiw49ggPzoGugAodV2hFoDXReUlCfOYq7Ff6xEpwU0MidH4CgIDEkehPi10RyPkhBNaN6nvzX6An2tJ1Mh6m68WagWwD4wfAzuNoifrHr1DAwwoiY7tccTCDVLkzk9rH+5VFX50rHReI+/Qk+nbqn2WC2s1i9AqNpnJgbFmKLviIdeV7Any5B0QPjP2MDeFlpcx8L/KbfzKqLcZMuMhAyFb1YYfIzPeXlOIqbzazT7Ero47mXa7cYLh2R16u1vxQ3JoJ8XyJulrzY13Zpxbqwrtcv7O9NOgh0/NHZqrDmaro/k0S7yImI9mqa71LxsAthxsiEHFpPUIA+65C+9hIADWBUibnXkG4lX4cx67CVsMyBkJ67k+7Q2us2rXxLfu2TW8Kakyusd0zLElCyZjBR3bRzkGqjG9lcSbucdlYVi8r/4DMTxq+gW8bgoZQM9XBaI5XkIYWQX9Kh2RIub0u8ZYmCRnN9x7zP5kBXl8SHUnlNORjzFMfZfNO4P0vHk98/vqTOZzOhfxyhlSgO/w+jxnqmG579inQia/5xC0ZsuUhj8hHTHCqUM2JEv5Qk4tgEQ+T8Rqb2wWda2bADR2zEk4+L5G2kGaCJThaOL6XYVEEz17xqEAlbxZfLtVnYn/QETOhCiOQOCnqb09MwImlx8gMhpSX5HPbcfuHXGCxXBp97Tfa+uFf6q8bNFsByPXJJkXvpa6ruH7qhizQIrMMo3jqIXG3vAKV4ZzSQpNYg4RpFbjntXccgjqliZXmwCd+q6oFQd1lypFOGPTLiUzRpC+h+hBiAIvQE1ApU0WWbB/qAzsjYN+5rkeCWYt+41YcmIs3ZLMSmf8HnzmGZfiBd0EmpTklt9b/dzNRVlGJ/k28cD2V8r/UACNdY39jwXv3eEsM/pK1fuVdxYV2BKwcAgeShWmqaU0vyghhlMAT+wqcQ6AOiZMkZ4azt36dHuykEtuZOG9bsy9g8RjYIjI34Xwir4n2IG+HKDkgs7Y82CyPeiKnY8Qd4gME7Lx7mUzbLHvLMa/cgvTGZkZG1LXzrwtNzKbjmTmVvdbz4qlLCYtBu2EVN9wtzq7+D0jpglsxvgQKrM3MkIL+bk/x5Uhq3CtF2lx02b542CFqu6ZEuUYWEOQwWmfDfCS23o1sC6paVqTAnEX9+Db6O08X/wnBbxPkxcmsHQNcwxL0zcHUq/saSyYvw8IKnUZKL31tm4o5unEL+tpBTT4MeagrcV79LcM/WJm+yt8KTtfFfOJGS5Kkg5l4HYAPkUCHpqLNgCaaeJYU9tgxBUpSl2zlhlV/fY0MPSja2yzVfT5zwTdoFndrxigvdL/5DQIYWDOfW0XOWannwmtpYMCC0gYvNWhpiulCbcxXHK8c+0Y5wfHnryzqCcEH/8I9boVSZITavRw+o5Y4PfAANT3uEoWWsrOQk1JduToZDtHPxi2EbYA5Nu7WT3JVVsGAHYQHf/chnB1DtUtj14cFmV9/R/YPcLUiMdDHVilNbXDsS5aSeg4r03WUvGTFmr/IOPUhrqi86GucpcwshxFPAkWJWgsMUf0GTy X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c236b37b-e1fd-46d8-a131-08db8148639b X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 13:20:11.4121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: laGEcHXNLlipK8dw2WLzhy0Mjii6dOQGBunFhp2pgwCp8MhQbxqMXqpjxHb1nCAMM15aXWOiXaGsIiHGS0BvBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB5131 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_062033_692767_E9916010 X-CRM114-Status: UNSURE ( 8.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary release_mem_region from the error path to prevent mem region from being released twice, which could avoid resource leak or other unexpected issues. Fixes: b083c22d5114 ("video: fbdev: imxfb: Convert request_mem_region + ioremap to devm_ioremap_resource") Signed-off-by: Yangtao Li --- drivers/video/fbdev/imxfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index 04f3bf30a529..385c4715c7b7 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -1043,7 +1043,6 @@ static int imxfb_probe(struct platform_device *pdev) failed_map: failed_ioremap: failed_getclock: - release_mem_region(res->start, resource_size(res)); failed_of_parse: kfree(info->pseudo_palette); failed_init: From patchwork Mon Jul 10 13:19:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 13307132 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8454EB64D9 for ; Mon, 10 Jul 2023 13:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2Zrr++jwSD/TiEOv5uD/d+GV3FEPOWFbsJJgMGGI9CA=; b=0huXppT1eChtzu TIQwZJq/r6CJ8UQiL4JxLTEjF2ArINDk2f+jqM0LhYJQxmVDRJo8KtMKOxDRV858NzrKbJVwLcTiZ Wkw0Zyf+QtfrDwGlithkcB/VLnOM3eu/g2DxoeIE+CgMu4OHmDEt+woWkO6NWM/3s64V6JqjRz/Tj Oh/AfQSqdIEJEB7arAyRw4mgB3WIfGrr4s5uJiH/+n//5ehOeQJNniixl6uOFBNj4/fCUTqzV5dA2 tO6rdGfj9uI9zZQgH9D2VhmGm/nqjU3Hw2r/fj7OT99/MCgxbkQ9T29W3RSjQcBnsA/4YOV1bz3sg 83WCf0ysypA+FDvKDD5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIqoc-00Bjjz-23; Mon, 10 Jul 2023 13:20:34 +0000 Received: from mail-sgaapc01on20720.outbound.protection.outlook.com ([2a01:111:f400:feab::720] helo=APC01-SG2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIqoZ-00Bjfo-32 for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 13:20:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OqVnUls3ywsy+qXHsZnAW82u59H7KCldHaN3Vrqd4XyGjB0Ty9pw2iSicVMNsrAoObqrOh6RbCdARcgjZYhjmt+ky0TIQUzmdnvS4BC8i3xCRT/X0k8IVdUULpvOyoK00aPKzkQIdjPLt52mlRilXadk7gS0FtvKBjpoC6S1N04jwnlUxPsOhssY+gEmfTa+wL4G1yA8nz5biRJKOM68UsrUBgscLJSoHpHE9F2jizxW3p78Go5bEK9IUsXpsDT5zKaPvhGmI0JMy7iaU3VSXCBkYUoNeG4By9X/mHh/anWi+GIuGbhuiQY6E2ILjgSUnRoPHX65zbtAoXiMaSbk4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9uLvBxlgOCiMfG4qdNtV1IihRj/C0F45jnM1mERrGXg=; b=Umm7w5KBoZBV5ucmkRNz2SnrqGixsOoAZW87BSO32VcDa+4XQwUsRl/USAOtj0WaVC6g+KAUGJD+s4NfP03RAJPm5mt9+JYb2c26lPQWA01h22VvwR0AvEtAM3eKrS+Ol9ic055wkel1vo18BnqxS5HmcJA3hwXNGxtTL7rWzKE5X4eaNCQXIEJ8c110uEhVpIVaPgXHDm27Es/M2Ju7lCwtu7i0WhLsbazyXDWaNFjpM/yFEr7y56arkWB386hweIwBzi5KyP2PVaGeBKA7/Y0a1R27vf1orlow856j6fPhg3vX4Tr6hVuPl/n+Xfee/YeSeyTo/KFa35LBfT5OHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9uLvBxlgOCiMfG4qdNtV1IihRj/C0F45jnM1mERrGXg=; b=c75HHhkn7MivlFBNy7fg2hkCaPXCZkAhh2eO+Q02qa2hS02bTHuQ14Al1IN2/Tez6eA7KgAgq0U5aHO5dPfFyNpOvjIl64wpHneLc/dQBe2L885U8jATWguHsoXmgShyLY+zodfnoV4W9xcr+IEp5xjd959o0/5gd7ltX33qJz4l2XZN6V73hNq1xxv7eK99Q0LVK6RY3XhVEFUbJ4IqDqL56IvhcI4fgBrDJnA3XCyRNxyKsBtj7Q/Iu2+MuMRAODEpwX6uy2np8NTCtXO8uVShr516GJrbZ+GqsCmupCLw36H8zeGaZ2T9n9enT/mpSsQ0TQCuZgXvR8/G75UBxg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SG2PR06MB5131.apcprd06.prod.outlook.com (2603:1096:4:1ce::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Mon, 10 Jul 2023 13:20:13 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Mon, 10 Jul 2023 13:20:13 +0000 From: Yangtao Li To: Sascha Hauer , Pengutronix Kernel Team , Helge Deller , Shawn Guo , Fabio Estevam , NXP Linux Team Cc: Yangtao Li , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] fbdev: imxfb: Convert to devm_kmalloc_array() Date: Mon, 10 Jul 2023 21:19:59 +0800 Message-Id: <20230710132001.50764-2-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230710132001.50764-1-frank.li@vivo.com> References: <20230710132001.50764-1-frank.li@vivo.com> X-ClientProxiedBy: SGBP274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::17) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SG2PR06MB5131:EE_ X-MS-Office365-Filtering-Correlation-Id: 276f9f91-5ddb-4655-a604-08db814864f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6SSFd6f+wfaTpX6YRr732cjKEzpmJoyHk6xCxA+71gViXA9WGqPaPpqt3UB/96fPoJHwsvw+x3Vl+gNL2DdCgS/h1qVscgOHV5Et2fGcrdTESOANefHZdOx8Htpy3VuVx1DLfNsCV4k0+wGt/Mkg6CfGbqxkUT6BoznWs8IyQvJhefX0167ging3uSAzTdTRQW9TvgIHIEwE7nl0yXBj4AvFNqXMlGR4lbkG/TM4ld7+w827Ml6l28KHTKPlBrjmNKlLxngoYbpmj47Pgu2fOrcOMDsmWIV1fXysxTZUfGfOKX8dAdqWG07liNXp+XZNKrzw1qgWkh7IE+HA8M04LpiqaIQyoHM7yBnmu9kVr+hnCL4T6Xa8EC6V1NBv9/xXKZDUQw7e2HsCPLa7YHit7jKIJamhDyJ3h5z/3gRCcdP2rr+JZX6V3x83HlVCeZmFOazj0mRCJwo7AeVb9LID1w0PS2On5g/PvZsr+K+6FwgzyeW/gX9J4Nt4onysAY4fWIQm3fM7nq+2W4RHSUY7g8WWusDfqX6gLzG2JQFogFI29kU5x4lPSJrF8jOs3PHPPENE54UzgaoqgXOeI0SlS7yghiApNLF+vAunxC57qLxkcscUWQeGxPKQuxJkThsi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199021)(38350700002)(86362001)(38100700002)(66899021)(36756003)(6666004)(6486002)(52116002)(110136005)(26005)(6506007)(186003)(6512007)(1076003)(2616005)(7416002)(5660300002)(2906002)(66556008)(316002)(478600001)(66946007)(8936002)(66476007)(8676002)(83380400001)(4326008)(41300700001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: y2KBrwTh3t4RAWiKGKbDwmNpawuXRltKBB3PlMN46FNKozk9wyJl/nTQCKkcpJJXuuLHNBpBs5FThdka+4ICuhPN6p9Fh4mpfQEiSXmjF2OJurRsZnHEtPhXKjvugB20CmBr4iqtfFJk8sZSzmnoA4IpnFpyLqZPxDCfCezmmSZiMXjCksF7xVry9tqjMaayKPTqlRkyg1JA2g4YGaUvhk4KNWq9XIaE4zNnANB7JubmJ9qKI3Hnl7Z09iAEWHqcu5vZFkm77v4Ejwsz+N3QOKLpzjfMQh1E+cOIVijo9BF6i7RKdjAwYRaQGVMcCydbaxCycNhnfXCvE5sIlYJhjiHTcIM1LfNpN72xuoo813xmHyBy+AQ2Ds6Nkp3+T5CSiCjOdcEpYQ6Z+uE1azEZngGL5Z9SXpl7yr5In7TUo+tkJUonBSbIosgASFgN6qjVup5D8K0nJcUKMd2uIuFggwzR8ewjVpYgRoSYcDhGzkJ1XaW8R0eDv0S1k4H7qDRb94ZRD+1nrIDDtnFQQQPzrVdzBwLwyxAGzul7vg/6NnocYu8LZC5p4LiGHOmCp4lAwRrWhJp592COqnlBowzUuRixRYYIoKMWRk1rgOWRW0Dw5dgKeoqhk33oDLUFLgmMkdgvbhCmwyU2lTZXdX1GKcM6CifLS2aha9k9l5HWgEhq7BwUKvBv5bIIJXTbSw30M9Gt1Hk2DYr+xZuKGIHpRKut2dzJZ765g1xbSZIw/joFMnZSXng+Qle+ar8F6Bh9GT5b318cgdYCV5ydTgvcuYd5apRGtbG0tb/pjm6W9HnUE1frkL0wBw8x9tiWVB4TWU9jUAwn2fImjAsaGlkfUff9ojBzimv1GLFnol87rtnFObY0aGVbJFifIK9ZDU4y0MMPx+BpirdwFkimBJWQynT4KWfijFxVve0AMcvcOtx0SfSvdVXrgt3qlkEhrSzwlqQa9k7ugFMvju8+2+UEArpxXoG7J4hVONnFrpdkp7DyoTxp2Tr1GoVeibaKgndnhPDW8uMS9EXmMgBTF+AW5sPAai2SFrEBY61Sjw9kKDlbMHrQgtJdmcWF04CuTAJpZW5ShAhSneJUcIltoKMQ91c0bzOnGy+fQ4eheCNM8KK5QyKcwwriFZvrl8CMID5Men2H5+dBwmXTPW27HEj9mtndXg1ZGA1NEwkIsy0fG9wR5dxFmkFpkgnpMpquNsIHzlfZZGDuf3XV7qfqOHUXcDdzU1vlfJ/kmN3h2fn8kEOZbPUiLeOEl0+rVav8fcHmTlOQkdMeAMLfSBgYX9e9l7Ra0nOnyHkrEFijFEt9OFA9Zc3xI1Hm4uSgGbdbdcSofDVxHVGG8BCYCASrvaLFC3XYab54VD6fACf4R5HYJlcbbYnteiRgMhq/4WKexRnZlWbsJOaJIM0VXsP5yc6sxFjrYYRcVed0D4/MJUs2HMTkreSrlzo7erV6yhIvmcuKEcGzCXmjvnVpbwWRl0Xq949khI+ezr98FifhCYEAczNd+lhlUah7BAogiqVZxPV7nH1cRESu18TjS1WILFcaAsdVSEP4nfsVHWoZuR/9H3sIWm/8BOBrgnJmb8zny71J X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 276f9f91-5ddb-4655-a604-08db814864f7 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 13:20:13.6796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DxiIoVvxQ745r9sa42n0GICWlS2MLeoD3MdvwXRgwc7dRvD4Nk4a1Im0XZJKxbw/biyS7a6uumvBAnwVJduZjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB5131 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_062031_977647_364F3205 X-CRM114-Status: UNSURE ( 9.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org No need for manual kfree in the error path and the remove function. Signed-off-by: Yangtao Li --- drivers/video/fbdev/imxfb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index 385c4715c7b7..7020b5f6434d 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -673,7 +673,8 @@ static int imxfb_init_fbinfo(struct platform_device *pdev) pr_debug("%s\n",__func__); - info->pseudo_palette = kmalloc_array(16, sizeof(u32), GFP_KERNEL); + info->pseudo_palette = devm_kmalloc_array(&pdev->dev, 16, + sizeof(u32), GFP_KERNEL); if (!info->pseudo_palette) return -ENOMEM; @@ -1044,7 +1045,6 @@ static int imxfb_probe(struct platform_device *pdev) failed_ioremap: failed_getclock: failed_of_parse: - kfree(info->pseudo_palette); failed_init: framebuffer_release(info); return ret; @@ -1061,7 +1061,6 @@ static void imxfb_remove(struct platform_device *pdev) fb_dealloc_cmap(&info->cmap); dma_free_wc(&pdev->dev, fbi->map_size, info->screen_buffer, fbi->map_dma); - kfree(info->pseudo_palette); framebuffer_release(info); } From patchwork Mon Jul 10 13:20:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 13307135 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C119EB64D9 for ; Mon, 10 Jul 2023 13:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BjnYFXB/tu69CqFDEWWcxUkn0U6HOECoxEFouGGVCts=; b=PZHdKBRRWvZPkE RQICcZpQCbB7s+cK7eaufEx/PK1P6BzUMTadntkHA7NU+IMOmOBrkwST3OiLuElT5rHLyR9BHC7Eo /Cwe+cM7o5/k5cwUt1Lmg8UwRPH5cSPdBYFGqgDKIRx2yw18Bs+ugbQIB2USKTwzRNLS57qZyNk44 wLo1tXQAtDtHda9XycC/9kPFSuag7wnqF3klNN1wK0YWuEkr4a537SdvE7hKYyRG1pNc2dHVcNSx8 uca/Zzkc91l3V1jtx5ZEkI0E7eN3Lz8QXGoC6Wp5mpGX4zFxZ03akTyjQ0k6hG7r5T0pCei3RExQM WymmK/evdZfRe+JZjD8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIqoj-00Bjmd-1n; Mon, 10 Jul 2023 13:20:41 +0000 Received: from mail-sgaapc01on20720.outbound.protection.outlook.com ([2a01:111:f400:feab::720] helo=APC01-SG2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIqod-00Bjfo-0q for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 13:20:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dN8Pk6UmfAmCOi/yV9UApqR7xOjvTuHu69XwHIgfIwKeHUFWNryN+JcXzCRZ7oh25Q1DfYfLDuubzJcoMf8E+0z2/hEpENlfqwzCyIqr61KgCKgfFlGyMp/Fp77rk6PciP6cLuD/aAyaOYNNm/38n9Vbz6Dg2PbQfTRl3OLtSJgC0A+tpSgWwSFERsRPTbRxrHbyXqkx2luxnqloKZ/pLZcMfLYvSArH63FWrifwgYFSVwZ8FTtPyn9T6jNKsysUfEdFGY0RgSuKlFAG4Gh6Wt2IAxC73XA6tUPJW7stic7t4CZRfMb9E/ct472QuMjK+fZCIDe7uUJCMne3pnzUwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yWZj1Nag3gBRifYS71xzwmE9Gz0lr0/Mqy+4hbv/PI0=; b=A7yy07US4rsP9PrphwzWIecoZI+thBNePXxLmM1kJ2TsbFZK8dGoPMvLRk4xEhUz/gIWlH2iMRCCwcIUdQtfLvvuWVdUs4tg+pqH/+djFlNGHkv5lDa0B4U8q1wzjjP96Gw+pHRb6vMzjuUx1AT2hHluUEtwJqaq43MAZbmSi5830BzckiDljevBvfmTu03r27eFnkulssQl5cvnYAitPsTRX4LKp8bmbKA+riqS0vfswYVPh0+nC2tbonvi4GuMaK0ZAmpSf3JtlihQtD4uaBmwv/BMAkFXJnSAdhG5pQI/TFQkZfWIYjztpDsm80Ik2+lwmI2nXCSVYFVM8MTFKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yWZj1Nag3gBRifYS71xzwmE9Gz0lr0/Mqy+4hbv/PI0=; b=IW+3KkjTzy2i+s6iOlRY9VSu3cJNLkFBBNxiN6k7LxBrXlREHPx+yRuA0iAa8gXHokt5WlC3gYR4lI3rqZ4PSmTFAkBx0XwEi9W+nYDP5jUcpy3Bn4UpbBD0vBW7ft39YDMRjrLwrlaQMfw6T7lbSlUhwOURaXumvZaBR/cJSeG71smo4kdZFMBuaoMgBtCMT7xEXGy2MpZoHSNH8bdBBteBvVgoATnAOFRUL3KUvPyxckhp4pmxmeOJQmUHs/p489njvOj+K9hK3zrnkXKOzgC78jzSJszaKsDdER2WPqD2/Zdv6cpTGtxrphkJNGxhSYP1GRCKQCoB75pg/DLuHg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SG2PR06MB5131.apcprd06.prod.outlook.com (2603:1096:4:1ce::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Mon, 10 Jul 2023 13:20:16 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Mon, 10 Jul 2023 13:20:16 +0000 From: Yangtao Li To: Sascha Hauer , Pengutronix Kernel Team , Helge Deller , Shawn Guo , Fabio Estevam , NXP Linux Team Cc: Yangtao Li , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/4] fbdev: imxfb: Convert to devm_platform_ioremap_resource() Date: Mon, 10 Jul 2023 21:20:00 +0800 Message-Id: <20230710132001.50764-3-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230710132001.50764-1-frank.li@vivo.com> References: <20230710132001.50764-1-frank.li@vivo.com> X-ClientProxiedBy: SGBP274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::17) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SG2PR06MB5131:EE_ X-MS-Office365-Filtering-Correlation-Id: 2034c2e6-bb90-4771-1dbe-08db81486688 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xJEoGisALoOZhGS0l5YX627AgWmElhFTSpO2LEpUcfWoZjFdFqoviR/lKMJbuC1clPROmmSELvf95rShz8DMpxZvMZJ15IVgfIeUlxEVmKM5qjoaHD8SFQme4XGzuLeRPNwwapfFoukLCJo9wCKkIt6KHzlUtcX5YKu5NopquxMtmEO9qCitwHbhrbRJxsbWhOXlOyRitlGcHac6s/ijCtK0xeZCrQz+HQtCVdwq9VWY0h62id1Eepk+2rR7F9W+IECdJ+argJDCRRjzUnZVNvMqaSOfP9sPlicoYsgmaVOcsxwb7vYDX6eC/UUdMFQQCASVQmuYoTE24UvZki+Fp0zVhVvIwnM7SqM670PtugSszdBOnzDSkOfQ2hDlkc6WTRB9L9U8OAH/FVFE35ns6HL5ByZTm6Kz1G7DdQ7l8JAuix/8NqiQa15xL5bHTtCOsTIb4HEIh4CVXehHUvr+6QxvjUS+rHEIwGTwJmrBmKlX3HtRG3KAA1KgGE6v+NY1mXV3yY8dbrdJ07uGrx82hiWt7D5ffc6xQpJ0umUMYNejqHcULtVTuTOVRQDckSF65ho4Jc456Yep0jwZru9HiE6XFqwCW7f7X4G+q7/1DYMCyDDjlByQ89gsuOc6uDet X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199021)(38350700002)(86362001)(38100700002)(36756003)(6666004)(6486002)(52116002)(110136005)(26005)(6506007)(186003)(6512007)(1076003)(2616005)(7416002)(5660300002)(2906002)(66556008)(316002)(478600001)(66946007)(8936002)(66476007)(8676002)(83380400001)(4326008)(41300700001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Xylkbb01x1myo3KuV0eseSgfQrIkFzybxTeozMC1qMFNH0mOWu6AV6HK07+Y8LqZHRAz+NSDGe/SWSdVjwlg4/yIfJ9dVJyKCxnJR2+GXmz6sWn797Nv29xaMLZwGXTZw6SVf0vek19RTFyK1RTAxJZDBbkdh42Cl3Ee+/dnG95a3NUDnp/DE6h7IGtWB5AdUREyYNwMelLGvVByt4pGtRR33sqmcvd/S7QVo1DijAZYC3fYDFrySxe4IIXWfwL1CHrWKKSFdMZVz0ltXdNrZAqXA6cpTuuq9Z2INgu9Ii+TJwMfXgSXozUWkkBXuK/5WZuXFAuKS4HH28QRy7iTzeSRBV2hYHzNPfays7I/nKwo5WUcjUOny65Lty2Xkq3rQNkdddVv5f18oXA7L3Ny7w4332hEleg1l71LjwLlRxuQtbSycWlPMQ9R0EUD1I7SSVKlDwGTSrauoqLDk06gBecJSCd3g1e1ayztx9SDNGi7MuGIHVhv1v2YWKTtXIrgzYyagesZ8/MyI8VNmKrvvQfYyOh8WMqPDaZ+knV+1ndlX5Fb+h3WfBdYVfY/5OKP5oC/b+YxGUATYpc4Hw/P3OvexD4ZYCf/lE+zcLmXeD1cAmajoDlJIVsec3uSs5SziEcpRM8YQc/aeiR5IkJAtBDPN/TStv5urUugsDb0UWCGHXMESEmSj3KCeKxzvmHGWVuQy1Ta/aQgIf7bm0UlV0Fv89DmuTUxluXempVyBNQV9ddbCQwdaGAKey4xGXQkZQ+WubLVxVqGExnw4FjrLUOo87J2McP6QYA6fQVhTRlzqvwmnRNL9BdhYlCnQzPb0s+HD8gK0HGpvukRU4eAFchLISBLy/bACg7M2en0WjBkEVugU7pDKN3fl6bCdKuq8t0EMOhNEGZYO/tgTMu4IXamPLL1o6cktT2r9mcGeNMfkxba4PLpgi8EQSnXkJTnBieBhLMRwQFfB3OEwF3+7g7EzWorgGWLAgq0qIBafyfFBTW/TfH/gzBQOOUZo+YE053tBV1HWYiXL++snx5W5h7b3Y1d9X7lBTqnjEU/1rmUQezJD5PbeOdG53adHUk/MzidUcV6baavzfIusuL7x5vrdcmGHYp+vDBpJ9VaSJdPc6E/AZ3XN/h02sW+jImJ/t287FTCLXfuOp6kzJsWNbhJckWzGsGK+WTAj7Z0fWSIHnY50ob5nfMgalJ1pHFQgz0V/Ehxu25N7pIsQJ7IzV2JPxHn/hxas39ebLVJNpl2smyj/QOC7+P8ho770nKnA9wWuumSSoS6QgDM8h3+XAy8X2uA4kdnKPZrfT0FvxF4Q0HSwwBywiBqRKxK9DvZ7h3E0EKWj4FAQdXB8vSSeQ3/RWUnFtVKbKnDcI/KrtEVPwlxGQknFFGK7CQztORaAFQuQJx78ieHZB1bHjGWOL/KcExC2qG7I71LSH8i3eURK9ColqTxoYS6Yf6vJ9iJZ5be2917ccZzF33bFwMMvZgH3iAAyyd5S2u1JDWYInGISHSO2u8MrzkeuEN6QAJBw5QT3j5glomLFmaUkEbRHuSC8sufAECj8AtxpNHXKKyLECC05GP7lq+IIlp9vTAQ X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2034c2e6-bb90-4771-1dbe-08db81486688 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 13:20:16.2867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q+rVaRplNv0Yacc4aP2JgmdK/wcVr9Wnge24w6CYMV4op7KrJKehLaaCNiZFG+d/GF19WdiyhGmm8ahU6a5wiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB5131 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_062035_331564_C337C0D1 X-CRM114-Status: GOOD ( 10.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/video/fbdev/imxfb.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index 7020b5f6434d..4582ea801121 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -869,7 +869,6 @@ static int imxfb_probe(struct platform_device *pdev) struct imxfb_info *fbi; struct lcd_device *lcd; struct fb_info *info; - struct resource *res; struct imx_fb_videomode *m; const struct of_device_id *of_id; struct device_node *display_np; @@ -886,10 +885,6 @@ static int imxfb_probe(struct platform_device *pdev) if (of_id) pdev->id_entry = of_id->data; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; - info = framebuffer_alloc(sizeof(struct imxfb_info), &pdev->dev); if (!info) return -ENOMEM; @@ -971,7 +966,7 @@ static int imxfb_probe(struct platform_device *pdev) goto failed_getclock; } - fbi->regs = devm_ioremap_resource(&pdev->dev, res); + fbi->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(fbi->regs)) { ret = PTR_ERR(fbi->regs); goto failed_ioremap; From patchwork Mon Jul 10 13:20:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 13307133 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4FE9C001DE for ; Mon, 10 Jul 2023 13:21:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2IJEdvz8nEF/Ak1kODCsdXJ4p2xfrMqKOxl2KRiaOLw=; b=Z4rCZuPKsEB1E3 TedeKVm4cXmsornKzGsptKLYioVa+tkYjY25ho1DtqjoKLh3if/+U/q/jXfu3GdLpleVQh8TgOpAX tuA3SzbvIuLYXoPIK2rqyMKR029F/sldPwZLrjde3MokibknNJidxPBab6mbUpM9GSmP0SOs5yX7D HG224IW8GEWVzPtOOrPxizszEX8AR87H8RHcXV+zmQRI/zi9Daop39VXSi0jq1+/E8/u0U3fmngau P9qWrhY+VXSWnJFonU4vjz1siU0ph4Qg7fRppB3bqyU+gtcYjnnp10oh9hKyDKhz6zXmSxEIiUhJw 0VFMyaz5rvKfvE7utj6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIqod-00BjkW-0o; Mon, 10 Jul 2023 13:20:35 +0000 Received: from mail-tyzapc01on20723.outbound.protection.outlook.com ([2a01:111:f403:704b::723] helo=APC01-TYZ-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIqoa-00Bjgt-1a for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 13:20:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jivIK3E35MfKd3UUJKReIwrHcXvOfjb2FhKWBA3FzO/t9KYUHktzZo7BN7VNYfaOo/bGnW2G5IV2BkKp/aJXaI4NOLYeYynOFfIG/NZrOmmkQ5WwtB3I6Eo7BTBideUYocFhN2nU8zBgme2QCC3oVfS3DBRDcjiO6mRPxpq7zcCU68IZWwx0ADUiBe9tOVzmgbkP4o/CCw0vQfz2NvrYzKGb8vacLTkZfyu+uZUTNJnh7Q37ynUnUB6WoSrdludhuGh0Bc5kL39usD+UnX/QnwaR4jXd25ITbPjZ+Y/qBALcBvXaYhMp51OARZHtBSMuF827EgmRcXZ2bN8Qgn1Ffg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j3wMfQC2CGe5m7FMGneONO0IFk/KCAXfyyrwnKJ0Gtk=; b=bsueGKnxpaiJd0sWBapIs01TNCvUpyaeVgnwgLW6W7g/W4FGML1iC/wpFMKwlLo5rBXReHYi2+GIkOETp7nX7KUDv8lpUf/JCV8mJkZXpCa2m26j5ioe7bi02BPCZhoZt9BrPOjI5v/QP8BRvgpiaqzd2/kNWV9qYnbs4ptaH01Gl7zIMoDO9FSXjD5cycYChq1RV1pfygEnDWAUnzjvxeUtBmquUqy4PxPwjwSaE3PMDftP/No87dnSp0NxgZAOYiTDcBFSU73+zF1I4is7FCbRiR2p7jKmJ+YS6i1r+UHVz4gqveIan0Q2gbNHhOVYYAuHr7NTdgvSxn08M2OgUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j3wMfQC2CGe5m7FMGneONO0IFk/KCAXfyyrwnKJ0Gtk=; b=FgEZBzupginCJ3uP+xdqOP1RVmSJD8Q50XiK4iK/mfhPoj1agnVoncUoxjG+JYxu73C3V8UUQIsUVyD+BsByDiiWHK0f19f6FSu2VXvaWmFIqDzX8rgg63DGhwnBkCXInvMXmoly5kxnAJ9H2bzEzM763uRT3hWGBIz3tsz5Zmv8Kq9C+I/kQL2PsUjnSlPlP1LzVrpBBMZbVGHtaiYAI7EB9OuunWSOI+NhtgWHJKXnjse5hedjgwaV1RtTQiBhZ40aT3nOw2XrVIS2qELqbPAHJO9C/jVMNOFjWBPhNic5v/o1rrWnlfe4VlvEXH8S5z4Ybeg8HH4+SpGFBMsx5Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB5930.apcprd06.prod.outlook.com (2603:1096:400:336::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.26; Mon, 10 Jul 2023 13:20:18 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Mon, 10 Jul 2023 13:20:18 +0000 From: Yangtao Li To: Sascha Hauer , Pengutronix Kernel Team , Helge Deller , Shawn Guo , Fabio Estevam , NXP Linux Team Cc: Yangtao Li , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/4] fbdev: imxfb: remove unneeded lable Date: Mon, 10 Jul 2023 21:20:01 +0800 Message-Id: <20230710132001.50764-4-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230710132001.50764-1-frank.li@vivo.com> References: <20230710132001.50764-1-frank.li@vivo.com> X-ClientProxiedBy: SGBP274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::17) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB5930:EE_ X-MS-Office365-Filtering-Correlation-Id: c1314334-f83e-42dc-c20a-08db814867e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ziZtKuS1Jbo4j6qyj5+QQj3ygDaRXXSQkwivuituYMGJstAOjOHUolq+3h0N9rF6z7YJrfYx0wVfn2/ry9blE5tEUgnalQ0Xu2XKCVInrfrBJP0jWg1ql51v9ZX8JBx797++NmphLgUyj2CM2k9rfByZPTAmCVbRALZuMvlnnJQi9RkmDscNTq6JTvrouBi8ykcsOd1vCpnd6TuBeqRMeI45P9UCnfKUYyEw5OnuOC0fc0ArvM61xYc5ohHbUcgrdah2GVx9Y6vfE+nsir7Sk95veSGvt7KI26LRzMmriXTZc4tPxWvGxbRZ4GS4ttW6nW36iZVPpJm8Vh//Hsw+91GArOy8isjfbWGIe6qF3B0I9REnPNV6JuCd1pEoC2LLapbCHIJY252Z18G6n4EEZ870HCtLvXE6M2t7VpEsnLLcU5V0GxYRPgXbVFaf/2eEuyOQsEawQLPNUSSrUR+iARFkP7EN/ZGJ+HC6AIzs97g02mP8Y5mvgG14Y9GdMTUZRSKvZro8v4/iYxQeVfYcwThy99UAdgjaTbgUWknJ4jAEU72Fcc+mroTWFvk673suv1eabvCInO5s4xjFQTcLx28qf4Pk4Wg/PIg/v2eknDmzefVFDkpyHYHvEJ/wyOyM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199021)(41300700001)(5660300002)(7416002)(110136005)(316002)(2906002)(8676002)(8936002)(66899021)(6512007)(6486002)(4326008)(66556008)(66476007)(66946007)(6666004)(52116002)(36756003)(478600001)(186003)(86362001)(38100700002)(38350700002)(2616005)(83380400001)(26005)(6506007)(1076003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TVs+iFl6xRLKk7+cbGsv95uCfomV8fLK65gUTsSgv4hnzflCUw7eq3jKwzw2a3tapY4ED3cySLIhOcwXIyfHHWmAi/Nx9CGD2K1HjjM94y35pCKEyhT5NfohQaDfEnV5LlOk8RopeOKNZPV1DZBYTm3Un/1NJScWGymRkU+5s2Z+P3L5idzvHSfVcZEbOly/VmRkOVFdFCOQTm65m5qL011V5kBYVXXEuj3+XMLZeb/ffngq7Tw0W0mRFWGrfhFWTxTTGUnvwbED6eKK+UvAsIvYMBghDe7psHUbLHxk2GyycHykSqiofH7REPSECBrk79XTm8f67uquVrq2MsFIBO9QePLacI2xZf+NWQeTcK5KZNl18GcLp37TjUyNx1dts9A4w5Eo9KC+thaPA7R5wsHDEiG58GA63v55GbwAWJPJoXjbpdkVj8PSz/Xae6NC1aomRWwYha45eCjfAVBA8fSGoe0mhDfuldPT25tkeP28MYVw36VxwysAXf2zzMTpdANcy//M/8V9QVnZR03wOLQAMJdtgIF5AUSdOXq0g5Z4laKnijMR37itRKInkHU2MTSEhwpg0mm8nwe0UD5tQ0RF3IEPiB1ovY2Xa09hfF4mBUKnk6RraP9eRVBanYNH2u6BTIEGQwA1njAcPcCvfUP5/6uKwrNnBHulKE6XU1/UxyF7lMnEEZ1hf+UAz4x7/mdvn3mH+nN59j6h22jHcCEi4hS5x15Jf/2MJZUm7tLJKrswDayF3Cm2zlrUVLVzf188oVExZK44itQ0rhwJxGqx9zFs/nifhr0mw4/R9Na5a4cqbvETgqwfe8ohsoUWl3BMgSvgv/zep6iN8w35qYTV5gNXNQCF6/ioYpNe5UWi9JKO3p6Dv7cKSRdMmvwpta+4Ci3MCSiHdOxmdb3Gd6gp95Lq2rP3DfrAqAk7r+rYYujx1fuY+A7gsy9q2sCEZgsuNWbCBIbMshYjNUh7fWUnyF/kzXRNF8gjb+UEEejbWWnSFPAhsdgrjfcVdPxAbMTb09gqAQf8su3lGvAhlW3ukX2U3jWGcXHMExYjFm+U5Zz8nNtFKXyr1ivM/MUVWGnwGdCsmTNOfOcEOrfo1Rw2ptEfdK9Mr4bfwIml9G9oWvo6SZSmCDdaoiunGTK+/pAaCCkwxg9W+/h6XjWtnOMMaE8uvPCPnyl2o7zaEDjFYdeTmpwQB2zXcCy9QURCES/Pn0O46K8V+NtWwBPEodO0a+6m9pUf82p1Zc8QHd1lqFh88RmtxGRlwpcUyjQts+YaeLA1yZ/o1cyYKRfYbkWVQHMipbis1HgKuw0kcTdvzvgUXbIlBXJ8NXHimKaFhpV+vjEbGcsJ3dQ6D2B+CcuUY73KMy1MSYGFpoNNbbKPPlhDSHVVrCOPa6Rt1vmh0aNdGABfo8kxD0Jgaq/RZpzWu1yn8HSxPClCoT1LgEJjPI0RZ19LMmbUtzfxlzh0zs5fznOOmYLknup6XefnuUkyyXc08DPnfdCc8mSkj4eH6L/PORU9sHIrRKt0KV2wta9uCuvtBkdwYXn8h2+OlDz/K62MxviN+k8VjEhjTBq21yDOm9O3g8ulKCmQzeHB X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1314334-f83e-42dc-c20a-08db814867e1 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 13:20:18.4777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QmOES3Wq5S78FLq7RoE0wG8oc48oAAD5UnoemoQdVHDs4UaI3MPnTPq9waxYs8vnojarPXX7dflAEQaSnbWcCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5930 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_062032_532637_802CF47E X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org These lables are redundant and don't do anything, let's remove it. Signed-off-by: Yangtao Li --- drivers/video/fbdev/imxfb.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index 4582ea801121..77dedd2c05fd 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -903,7 +903,7 @@ static int imxfb_probe(struct platform_device *pdev) if (!display_np) { dev_err(&pdev->dev, "No display defined in devicetree\n"); ret = -EINVAL; - goto failed_of_parse; + goto failed_init; } /* @@ -917,13 +917,13 @@ static int imxfb_probe(struct platform_device *pdev) if (!fbi->mode) { ret = -ENOMEM; of_node_put(display_np); - goto failed_of_parse; + goto failed_init; } ret = imxfb_of_read_mode(&pdev->dev, display_np, fbi->mode); of_node_put(display_np); if (ret) - goto failed_of_parse; + goto failed_init; /* Calculate maximum bytes used per pixel. In most cases this should * be the same as m->bpp/8 */ @@ -936,7 +936,7 @@ static int imxfb_probe(struct platform_device *pdev) fbi->clk_ipg = devm_clk_get(&pdev->dev, "ipg"); if (IS_ERR(fbi->clk_ipg)) { ret = PTR_ERR(fbi->clk_ipg); - goto failed_getclock; + goto failed_init; } /* @@ -951,25 +951,25 @@ static int imxfb_probe(struct platform_device *pdev) */ ret = clk_prepare_enable(fbi->clk_ipg); if (ret) - goto failed_getclock; + goto failed_init; clk_disable_unprepare(fbi->clk_ipg); fbi->clk_ahb = devm_clk_get(&pdev->dev, "ahb"); if (IS_ERR(fbi->clk_ahb)) { ret = PTR_ERR(fbi->clk_ahb); - goto failed_getclock; + goto failed_init; } fbi->clk_per = devm_clk_get(&pdev->dev, "per"); if (IS_ERR(fbi->clk_per)) { ret = PTR_ERR(fbi->clk_per); - goto failed_getclock; + goto failed_init; } fbi->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(fbi->regs)) { ret = PTR_ERR(fbi->regs); - goto failed_ioremap; + goto failed_init; } fbi->map_size = PAGE_ALIGN(info->fix.smem_len); @@ -978,7 +978,7 @@ static int imxfb_probe(struct platform_device *pdev) if (!info->screen_buffer) { dev_err(&pdev->dev, "Failed to allocate video RAM\n"); ret = -ENOMEM; - goto failed_map; + goto failed_init; } info->fix.smem_start = fbi->map_dma; @@ -1030,16 +1030,11 @@ static int imxfb_probe(struct platform_device *pdev) failed_lcd: unregister_framebuffer(info); - failed_register: fb_dealloc_cmap(&info->cmap); failed_cmap: dma_free_wc(&pdev->dev, fbi->map_size, info->screen_buffer, fbi->map_dma); -failed_map: -failed_ioremap: -failed_getclock: -failed_of_parse: failed_init: framebuffer_release(info); return ret;