From patchwork Mon Jul 10 23:03:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307818 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2E35168B0 for ; Mon, 10 Jul 2023 23:03:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8F63F9 for ; Mon, 10 Jul 2023 16:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=9YJYHtPVNWz0vTrE8jX9JgM1vcMFqhu5z9qKG4nWNm8=; b=Zu2lUA+bCUSWwZQPzgtGOJHY+h lHVbBP0F9Mb5bs1EV7JDBBnS6zNdyoefzjwYld0bRCMLY5IgxL+ZtmuQR/5ciDHxYABjmlkWaLaOL JdaghaVOgtPNRG6tOcRvQ60khb7RrTJwNATiIW/vUJE/GaaAmQcYvQXjeGF0BmNup2YkmwjBDdUGP IqQjyquoXFRW9YmDaQsOMpv6E+2cOX7AstvGrC6QJt0WLGnOhABnrq26Ey+FBRAlbAm4sar60jygm zKURhbI7hQl1/xQwgjEP0WeJI2j3IYgjbEiUJc+rYSwBrIWdjzU/Ktmd0Rf3BPbSj9Z7oCjqCaXAw dJTm6qPg==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuU-00CuO1-2F; Mon, 10 Jul 2023 23:03:14 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jay Vosburgh , Andy Gospodarek Subject: [PATCH net 01/12] net: bonding: remove kernel-doc comment marker Date: Mon, 10 Jul 2023 16:03:01 -0700 Message-ID: <20230710230312.31197-2-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Change an errant kernel-doc comment marker (/**) to a regular comment to prevent a kernel-doc warning. bonding.h:282: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Returns NULL if the net_device does not belong to any of the bond's slaves Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Jay Vosburgh Cc: Andy Gospodarek --- include/net/bonding.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/include/net/bonding.h b/include/net/bonding.h --- a/include/net/bonding.h +++ b/include/net/bonding.h @@ -277,7 +277,7 @@ struct bond_vlan_tag { unsigned short vlan_id; }; -/** +/* * Returns NULL if the net_device does not belong to any of the bond's slaves * * Caller must hold bond lock for read From patchwork Mon Jul 10 23:03:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307819 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC62E168B3 for ; Mon, 10 Jul 2023 23:03:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B992D10D; Mon, 10 Jul 2023 16:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=tumxd6dc0vA2G3EW/fnOXAr0IYFDVpLv9/tSCnYJH58=; b=MNrqg8ZIwFfxKGIYijdmU6rN8z xUZdZrBz62rQNWs3uQWIKBLIJIx1kxNHVi3zkAkRQPSSBJ0gwiZySD1ol8/+BtoS16tX60pVIlTpW jwwU5+ErUDgUouPP2HVQZJBPEX6yozCrXfKZFT9D4MWDwRw1qdtYZ8GgL5l1RP868Mf71tGe01LG/ nu5YN7XfjYFTFgs38CoWETwCV7e2mvavhGXmUZoEVAwlNmYccWvbmQLKCrXviZO69gTxivSozv2S5 1hxhFYfKC0i3FDG7G59IHMpv4KZ3zOJyQF2iQPo2Ne9TXaJWBscvnh5RHsW3eVBU7PVkVQMHQMa+Q 4PIJtOBw==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuV-00CuO1-0S; Mon, 10 Jul 2023 23:03:15 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Johannes Berg , linux-wireless@vger.kernel.org, Mauro Carvalho Chehab Subject: [PATCH net 02/12] wifi: cfg80211: remove dead/unused enum value Date: Mon, 10 Jul 2023 16:03:02 -0700 Message-ID: <20230710230312.31197-3-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Drop an unused (extra) enum value to prevent a kernel-doc warning. cfg80211.h:1492: warning: Excess enum value 'STATION_PARAM_APPLY_STA_TXPOWER' description in 'station_parameters_apply_mask' Fixes: 2d8b08fef0af ("wifi: cfg80211: fix kernel-doc warnings all over the file") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Johannes Berg Cc: linux-wireless@vger.kernel.org Cc: Mauro Carvalho Chehab --- include/net/cfg80211.h | 1 - 1 file changed, 1 deletion(-) diff -- a/include/net/cfg80211.h b/include/net/cfg80211.h --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -1479,7 +1479,6 @@ struct iface_combination_params { * @STATION_PARAM_APPLY_UAPSD: apply new uAPSD parameters (uapsd_queues, max_sp) * @STATION_PARAM_APPLY_CAPABILITY: apply new capability * @STATION_PARAM_APPLY_PLINK_STATE: apply new plink state - * @STATION_PARAM_APPLY_STA_TXPOWER: apply tx power for STA * * Not all station parameters have in-band "no change" signalling, * for those that don't these flags will are used. From patchwork Mon Jul 10 23:03:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307827 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB7CC174F8 for ; Mon, 10 Jul 2023 23:03:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BF11E46; Mon, 10 Jul 2023 16:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=129Ywr62GUsnB8fd4+dQPU9Qo62f2KA3pJRQUQ+UrIA=; b=furZUQOYyinrwWKEPxe+fq/sll NyISzldSKhJcVhzfPIf5zPZJZhhh1Q8sTWzgnZg+QpvMNteYMEWmG1qW7P5ksEt9fFv9zyopPCLe4 WFEDJI5b0DTesdRF809fODhcM3MnVXTqKAmN1Sv0M6yyYaYkaJ57naiW/cghV17geEh58FJ0BN3k4 UfegI5VCBXIpAPcIEpofclEyOqB+uohf+VRvvt5fFyKuoTBsRgSKQKL5HJtlR6vvk61QLfB+5kB5S ePIZYb1TmouazCdq4Cr17qKM+SGb6qEtjpW0975ts5cjJfeR3k7wXyrx56Z7/Nw/KOd0zWvLWZypj kSwd3KNQ==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuV-00CuO1-22; Mon, 10 Jul 2023 23:03:15 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Aring , Stefan Schmidt , Miquel Raynal , linux-wpan@vger.kernel.org, Marcel Holtmann Subject: [PATCH net 03/12] net: cfg802154: fix kernel-doc notation warnings Date: Mon, 10 Jul 2023 16:03:03 -0700 Message-ID: <20230710230312.31197-4-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Add an enum heading to the kernel-doc comments to prevent kernel-doc warnings. cfg802154.h:174: warning: Cannot understand * @WPAN_PHY_FLAG_TRANSMIT_POWER: Indicates that transceiver will support on line 174 - I thought it was a doc line cfg802154.h:192: warning: Enum value 'WPAN_PHY_FLAG_TXPOWER' not described in enum 'wpan_phy_flags' cfg802154.h:192: warning: Excess enum value 'WPAN_PHY_FLAG_TRANSMIT_POWER' description in 'wpan_phy_flags' Fixes: edea8f7c75ec ("cfg802154: introduce wpan phy flags") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Alexander Aring Cc: Stefan Schmidt Cc: Miquel Raynal Cc: linux-wpan@vger.kernel.org Cc: Marcel Holtmann Acked-by: Miquel Raynal --- include/net/cfg802154.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/include/net/cfg802154.h b/include/net/cfg802154.h --- a/include/net/cfg802154.h +++ b/include/net/cfg802154.h @@ -170,7 +170,8 @@ wpan_phy_cca_cmp(const struct wpan_phy_c } /** - * @WPAN_PHY_FLAG_TRANSMIT_POWER: Indicates that transceiver will support + * enum wpan_phy_flags - WPAN PHY state flags + * @WPAN_PHY_FLAG_TXPOWER: Indicates that transceiver will support * transmit power setting. * @WPAN_PHY_FLAG_CCA_ED_LEVEL: Indicates that transceiver will support cca ed * level setting. From patchwork Mon Jul 10 23:03:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307820 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FA65171AA for ; Mon, 10 Jul 2023 23:03:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81AB511D for ; Mon, 10 Jul 2023 16:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=zRZXD2Jthz7pgllrXfpIfXTG8eHmdK2Rnbh9jadh1qw=; b=Symwoep1AwgfZ6gFEl3k5l9aVY PvLjcl90Jn96lHWGh5WeIIo66e5bsPDCKXEHOXb2aPBNKxMaNDS3o//DOcwHmcZpuh6dVJYQw6t4R q0s/5+4H8SC5kqAkIlS5UfxMmiBniet0qyZ+nxoxBwhH+pZFk1Y1FwH4uvh7ZTrVq8Z8UcZh65MUD JFS6+7eDvJUPnbfXcfdp3j/zbQAvVbJUcbV2aAbgY03OSVTcGJUMN0dPakwZKSkWqm55DccK+zeTu Lym/uKSyIqGy1nIzx33nEF3G39TF5kofglyp5EvNzWsCy12S7dVg5GqFf0zLEOq0wwFLueEEZ+IyW 3c+soC9w==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuW-00CuO1-0N; Mon, 10 Jul 2023 23:03:16 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Dave Taht Subject: [PATCH net 04/12] codel: fix kernel-doc notation warnings Date: Mon, 10 Jul 2023 16:03:04 -0700 Message-ID: <20230710230312.31197-5-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Use '@' before the struct member names in kernel-doc notation to prevent kernel-doc warnings. codel.h:158: warning: Function parameter or member 'ecn_mark' not described in 'codel_stats' codel.h:158: warning: Function parameter or member 'ce_mark' not described in 'codel_stats' Fixes: 76e3cc126bb2 ("codel: Controlled Delay AQM") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Jamal Hadi Salim Cc: Cong Wang Cc: Jiri Pirko Cc: Dave Taht --- include/net/codel.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/include/net/codel.h b/include/net/codel.h --- a/include/net/codel.h +++ b/include/net/codel.h @@ -145,8 +145,8 @@ struct codel_vars { * @maxpacket: largest packet we've seen so far * @drop_count: temp count of dropped packets in dequeue() * @drop_len: bytes of dropped packets in dequeue() - * ecn_mark: number of packets we ECN marked instead of dropping - * ce_mark: number of packets CE marked because sojourn time was above ce_threshold + * @ecn_mark: number of packets we ECN marked instead of dropping + * @ce_mark: number of packets CE marked because sojourn time was above ce_threshold */ struct codel_stats { u32 maxpacket; From patchwork Mon Jul 10 23:03:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307822 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 854E4171D5 for ; Mon, 10 Jul 2023 23:03:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB20F1B2 for ; Mon, 10 Jul 2023 16:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=BUKHHIWIV70WqkoBT9nqj4AzEgmD1g5PkeHwMxLn0n8=; b=Xs8d2nPqqA2w1+mawSs2qGx2dc WshrxMlC7c4ULkalmNlQ6wquTCNQlnBsC6pFzZui993PrOO4sDZxM0zclzUjuWBzuYoRC/1NRZQoU 8RE08EQ0b+tLv2fnsYuIuL9Os0b9ehyXqFEIH1tu45oMXKGMIOEXJ4TaECWvkC70Y4cWOkcK8Ea6x 68FOuR4KKa0CxFfNpkaMNYMDF1rgpZ7529H7DNI+1mIFGNTJ0q2V/ZCmx+Ee5983I98W9dTs26u4U 1fti52Zz56YTLxAoaPl0UFbedPU1IBirqeHs5DeOKJoY5T4DF+Y/lwnTkqMQHywxE9D08wI1XEiXD XOkBA6uQ==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuW-00CuO1-1w; Mon, 10 Jul 2023 23:03:16 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jiri Pirko , Arkadi Sharshevsky , Moshe Shemesh , Jacob Keller Subject: [PATCH net 05/12] devlink: fix kernel-doc notation warnings Date: Mon, 10 Jul 2023 16:03:05 -0700 Message-ID: <20230710230312.31197-6-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Spell function or struct member names correctly. Use ':' instead of '-' for struct member entries. Mark one field as private in kernel-doc. Add a few entries that were missing. Fix a typo. These changes prevent kernel-doc warnings: devlink.h:252: warning: Function parameter or member 'field_id' not described in 'devlink_dpipe_match' devlink.h:267: warning: Function parameter or member 'field_id' not described in 'devlink_dpipe_action' devlink.h:310: warning: Function parameter or member 'match_values_count' not described in 'devlink_dpipe_entry' devlink.h:355: warning: Function parameter or member 'list' not described in 'devlink_dpipe_table' devlink.h:374: warning: Function parameter or member 'actions_dump' not described in 'devlink_dpipe_table_ops' devlink.h:374: warning: Function parameter or member 'matches_dump' not described in 'devlink_dpipe_table_ops' devlink.h:374: warning: Function parameter or member 'entries_dump' not described in 'devlink_dpipe_table_ops' devlink.h:374: warning: Function parameter or member 'counters_set_update' not described in 'devlink_dpipe_table_ops' devlink.h:374: warning: Function parameter or member 'size_get' not described in 'devlink_dpipe_table_ops' devlink.h:384: warning: Function parameter or member 'headers' not described in 'devlink_dpipe_headers' devlink.h:384: warning: Function parameter or member 'headers_count' not described in 'devlink_dpipe_headers' devlink.h:398: warning: Function parameter or member 'unit' not described in 'devlink_resource_size_params' devlink.h:487: warning: Function parameter or member 'id' not described in 'devlink_param' devlink.h:645: warning: Function parameter or member 'overwrite_mask' not described in 'devlink_flash_update_params' Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)") Fixes: d9f9b9a4d05f ("devlink: Add support for resource abstraction") Fixes: eabaef1896bc ("devlink: Add devlink_param register and unregister") Fixes: 5d5b4128c4ca ("devlink: introduce flash update overwrite mask") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Jiri Pirko Cc: Arkadi Sharshevsky Cc: Moshe Shemesh Cc: Jacob Keller --- include/net/devlink.h | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff -- a/include/net/devlink.h b/include/net/devlink.h --- a/include/net/devlink.h +++ b/include/net/devlink.h @@ -221,7 +221,7 @@ struct devlink_dpipe_field { /** * struct devlink_dpipe_header - dpipe header object * @name: header name - * @id: index, global/local detrmined by global bit + * @id: index, global/local determined by global bit * @fields: fields * @fields_count: number of fields * @global: indicates if header is shared like most protocol header @@ -241,7 +241,7 @@ struct devlink_dpipe_header { * @header_index: header index (packets can have several headers of same * type like in case of tunnels) * @header: header - * @fieled_id: field index + * @field_id: field index */ struct devlink_dpipe_match { enum devlink_dpipe_match_type type; @@ -256,7 +256,7 @@ struct devlink_dpipe_match { * @header_index: header index (packets can have several headers of same * type like in case of tunnels) * @header: header - * @fieled_id: field index + * @field_id: field index */ struct devlink_dpipe_action { enum devlink_dpipe_action_type type; @@ -292,7 +292,7 @@ struct devlink_dpipe_value { * struct devlink_dpipe_entry - table entry object * @index: index of the entry in the table * @match_values: match values - * @matche_values_count: count of matches tuples + * @match_values_count: count of matches tuples * @action_values: actions values * @action_values_count: count of actions values * @counter: value of counter @@ -342,7 +342,9 @@ struct devlink_dpipe_table_ops; */ struct devlink_dpipe_table { void *priv; + /* private: */ struct list_head list; + /* public: */ const char *name; bool counters_enabled; bool counter_control_extern; @@ -355,13 +357,13 @@ struct devlink_dpipe_table { /** * struct devlink_dpipe_table_ops - dpipe_table ops - * @actions_dump - dumps all tables actions - * @matches_dump - dumps all tables matches - * @entries_dump - dumps all active entries in the table - * @counters_set_update - when changing the counter status hardware sync + * @actions_dump: dumps all tables actions + * @matches_dump: dumps all tables matches + * @entries_dump: dumps all active entries in the table + * @counters_set_update: when changing the counter status hardware sync * maybe needed to allocate/free counter related * resources - * @size_get - get size + * @size_get: get size */ struct devlink_dpipe_table_ops { int (*actions_dump)(void *priv, struct sk_buff *skb); @@ -374,8 +376,8 @@ struct devlink_dpipe_table_ops { /** * struct devlink_dpipe_headers - dpipe headers - * @headers - header array can be shared (global bit) or driver specific - * @headers_count - count of headers + * @headers: header array can be shared (global bit) or driver specific + * @headers_count: count of headers */ struct devlink_dpipe_headers { struct devlink_dpipe_header **headers; @@ -387,7 +389,7 @@ struct devlink_dpipe_headers { * @size_min: minimum size which can be set * @size_max: maximum size which can be set * @size_granularity: size granularity - * @size_unit: resource's basic unit + * @unit: resource's basic unit */ struct devlink_resource_size_params { u64 size_min; @@ -457,6 +459,7 @@ struct devlink_flash_notify { /** * struct devlink_param - devlink configuration parameter data + * @id: devlink parameter id number * @name: name of the parameter * @generic: indicates if the parameter is generic or driver specific * @type: parameter type @@ -632,6 +635,7 @@ enum devlink_param_generic_id { * struct devlink_flash_update_params - Flash Update parameters * @fw: pointer to the firmware data to update from * @component: the flash component to update + * @overwrite_mask: which types of flash update are supported (may be %0) * * With the exception of fw, drivers must opt-in to parameters by * setting the appropriate bit in the supported_flash_update_params field in From patchwork Mon Jul 10 23:03:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307821 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BFD0171A9 for ; Mon, 10 Jul 2023 23:03:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EF62F9; Mon, 10 Jul 2023 16:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=eeNKKnFfqVsbTDrMCi8dJOr2RFY9P/RKFkjoayT3ATo=; b=qjHRJLwzXLCekl5/nn+XtGvqYg T5bZ1vMSQFwsG+GI5HMnt+uJRMYn2OwiCXHSneGISwRBIpd0ndwiWUBOX2WsYzto1H6PIC0VjOGZa zAaUDVnO+MX8Yr4lGoARU5WlQBknH9zLUFp8u0Jd4pn53tb+glXIWJ8zzONM8lYJsdNXR2fkUI5od R/lXRbvintmfFws2ud4QDXuNjKPJX7f0dYS8j2BKcV+W/eN5WvMsZDDHDLTYEN6Wz2CXKdDZkE0Lz D77yg1UuBN7E7q4IswO+Pf3DGFPgNrMK8K+Z3fd3sSI4NbNRLnrK/zvm8Z4hePwoSqVx/ceh+Zr0Q xhA9d7Rg==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuW-00CuO1-3D; Mon, 10 Jul 2023 23:03:17 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Johannes Berg , linux-wireless@vger.kernel.org Subject: [PATCH net 06/12] wifi: radiotap: fix kernel-doc notation warnings Date: Mon, 10 Jul 2023 16:03:06 -0700 Message-ID: <20230710230312.31197-7-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Fix a typo (82011 -> 80211) to prevent a kernel-doc warning. Add one missing function parameter description to prevent a kernel-doc warning. ieee80211_radiotap.h:52: warning: expecting prototype for struct ieee82011_radiotap_header. Prototype was for struct ieee80211_radiotap_header instead ieee80211_radiotap.h:581: warning: Function parameter or member 'data' not described in 'ieee80211_get_radiotap_len' Fixes: 42f82e2e62ae ("wireless: radiotap: rewrite the radiotap header file") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Johannes Berg Cc: linux-wireless@vger.kernel.org --- include/net/ieee80211_radiotap.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/include/net/ieee80211_radiotap.h b/include/net/ieee80211_radiotap.h --- a/include/net/ieee80211_radiotap.h +++ b/include/net/ieee80211_radiotap.h @@ -21,7 +21,7 @@ #include /** - * struct ieee82011_radiotap_header - base radiotap header + * struct ieee80211_radiotap_header - base radiotap header */ struct ieee80211_radiotap_header { /** @@ -575,6 +575,7 @@ enum ieee80211_radiotap_eht_usig_tb { /** * ieee80211_get_radiotap_len - get radiotap header length + * @data: pointer to the header */ static inline u16 ieee80211_get_radiotap_len(const char *data) { From patchwork Mon Jul 10 23:03:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307823 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C66BA174C0 for ; Mon, 10 Jul 2023 23:03:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A31D10D for ; Mon, 10 Jul 2023 16:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=u2pYA1XRrYQS8D48dQiK1WJO9vNiX1lIBhn6N2JW9F8=; b=ZJ9SluyNUiBhA2EPF7jKXybAEw P+mUgI+rnfNrBS8OvRKLKvOs1YDWdFSsE01WTFhxXb/MVy175pMKJJtSLu/+3f549vvSvDL1Hsu7m kZ+3ZkRRa5sh0kVFR/Iy0aBK2IACZK0lpsQHbX9OckfLdhXdgtOE8LJsRlhdNAYGsJecIWc6m++h8 a7Le84cPRRGiqMdnBXcsk5L75DL+UC3DN5mK+RdftXMT1o9Ce6z07tDAC9rLyEwTEvdabymyKbjKL BUAP3rhpMjF6EA9z1PxRKlC8+16x1qX/p0RWppYn5iQNFQxnY+4XY6/rmOHYDZEpxMx+FT/T7psf+ dmRVTWXA==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuX-00CuO1-1B; Mon, 10 Jul 2023 23:03:17 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nikolay Aleksandrov Subject: [PATCH net 07/12] inet: frags: remove kernel-doc comment marker Date: Mon, 10 Jul 2023 16:03:07 -0700 Message-ID: <20230710230312.31197-8-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Change an errant kernel-doc comment marker (/**) to a regular comment to prevent a kernel-doc warning. inet_frag.h:33: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Fixes: 1ab1934ed80a ("inet: frags: enum the flag definitions and add descriptions") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Nikolay Aleksandrov --- include/net/inet_frag.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/include/net/inet_frag.h b/include/net/inet_frag.h --- a/include/net/inet_frag.h +++ b/include/net/inet_frag.h @@ -28,7 +28,7 @@ struct fqdir { struct llist_node free_list; }; -/** +/* * fragment queue flags * * @INET_FRAG_FIRST_IN: first fragment has arrived From patchwork Mon Jul 10 23:03:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307824 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32EBE174D9 for ; Mon, 10 Jul 2023 23:03:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E022D11D for ; Mon, 10 Jul 2023 16:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=hszDT02ww50FM3fvOHg2nA28gCNzUF4D7X06zLjN8/M=; b=gtCI/fDQfndPf0XZMy21Iw/zea ulF9RjiOaCaMvcyA17frgRXwOcABUMs8D4uGNdbpvAuy4grNYL7TN8qRU8+L62AZZIvkxkf0P3qWh 9XQDmemXaB6BLRiOD4Fd9D42+xYrhAijXYfKMYT9hJ3K3N3fJK6x47wqRCv/ybZV6S/oMW+6fyCD/ SPrF8GX5iCsoM4oDmujF8Ssz+fGxIQqWzZYI4CbWZHbwEv1qcHswqLwkbq9ejwWRUhSki9EnS2FDV WllRYvrQ+Y3xgxAjJu4p19pMjpt6G2c0sZBmqy0Rogcfz6GiHtqeTo0g2tVj98HJtuYU04ppWap8f h8KZtgAw==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuX-00CuO1-2I; Mon, 10 Jul 2023 23:03:17 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH net 08/12] net: llc: fix kernel-doc notation warnings Date: Mon, 10 Jul 2023 16:03:08 -0700 Message-ID: <20230710230312.31197-9-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Use the corrent function parameter name or format to prevent kernel-doc warnings. Add 2 function parameter descriptions to prevent kernel-doc warnings. llc_pdu.h:278: warning: Function parameter or member 'da' not described in 'llc_pdu_decode_da' llc_pdu.h:278: warning: Excess function parameter 'sa' description in 'llc_pdu_decode_da' llc_pdu.h:330: warning: Function parameter or member 'skb' not described in 'llc_pdu_init_as_test_cmd' llc_pdu.h:379: warning: Function parameter or member 'svcs_supported' not described in 'llc_pdu_init_as_xid_cmd' llc_pdu.h:379: warning: Function parameter or member 'rx_window' not described in 'llc_pdu_init_as_xid_cmd' Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni --- include/net/llc_pdu.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff -- a/include/net/llc_pdu.h b/include/net/llc_pdu.h --- a/include/net/llc_pdu.h +++ b/include/net/llc_pdu.h @@ -269,7 +269,7 @@ static inline void llc_pdu_decode_sa(str /** * llc_pdu_decode_da - extracts dest address of input frame * @skb: input skb that destination address must be extracted from it - * @sa: pointer to destination address (6 byte array). + * @da: pointer to destination address (6 byte array). * * This function extracts destination address(MAC) of input frame. */ @@ -321,7 +321,7 @@ static inline void llc_pdu_init_as_ui_cm /** * llc_pdu_init_as_test_cmd - sets PDU as TEST - * @skb - Address of the skb to build + * @skb: Address of the skb to build * * Sets a PDU as TEST */ @@ -369,6 +369,8 @@ struct llc_xid_info { /** * llc_pdu_init_as_xid_cmd - sets bytes 3, 4 & 5 of LLC header as XID * @skb: input skb that header must be set into it. + * @svcs_supported: The class of the LLC (I or II) + * @rx_window: The size of the receive window of the LLC * * This function sets third,fourth,fifth and sixth bytes of LLC header as * a XID PDU. From patchwork Mon Jul 10 23:03:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307825 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BDEB174C9 for ; Mon, 10 Jul 2023 23:03:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B99F21B2; Mon, 10 Jul 2023 16:03:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=oMzYfni/SqAXGE8TOxN7w+2uYv8fFjCLm4K0/twX6OM=; b=K7VvjRLJQTC/xFqwV3RHdTwTYS m2bhtQ3xb0qZJOrdb6B+iJ5AhfM+iWWkMgm16p+Ewi4TTLEI52/VjurgAlFfs3MMnLBn9DBOyCMMi hs2mgQblUvUhaOv09xqWizRERYP0QDLDCu0HFtc3zorNIUFlyp1Z2bNuRLgArFaVCh8+dYGpgdfh6 lTpYTHuUqxeuWbVm8vFgrUnTTa+CrhwwmY7sOy7qF90CBPYUF7/pGq9tqO/RBSjn1UFig64bS/A8W +E+zqp8PsEr3MfNtpb7IXmL5M4YQyy9RycNKU2NHVyLbWbVm/qP2Xwr/bG6GIsFcCzpCLgzorc3KB 5w7qV1PA==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuY-00CuO1-0T; Mon, 10 Jul 2023 23:03:18 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Johannes Berg , Benjamin Berg , linux-wireless@vger.kernel.org Subject: [PATCH net 09/12] wifi: mac80211: fix kernel-doc notation warning Date: Mon, 10 Jul 2023 16:03:09 -0700 Message-ID: <20230710230312.31197-10-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Add description for struct member 'agg' to prevent a kernel-doc warning. mac80211.h:2289: warning: Function parameter or member 'agg' not described in 'ieee80211_link_sta' Fixes: 4c51541ddb78 ("wifi: mac80211: keep A-MSDU data in sta and per-link") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Johannes Berg Cc: Benjamin Berg Cc: linux-wireless@vger.kernel.org --- include/net/mac80211.h | 1 + 1 file changed, 1 insertion(+) diff -- a/include/net/mac80211.h b/include/net/mac80211.h --- a/include/net/mac80211.h +++ b/include/net/mac80211.h @@ -2259,6 +2259,7 @@ struct ieee80211_sta_aggregates { * @he_cap: HE capabilities of this STA * @he_6ghz_capa: on 6 GHz, holds the HE 6 GHz band capabilities * @eht_cap: EHT capabilities of this STA + * @agg: station's active links data * @bandwidth: current bandwidth the station can receive with * @rx_nss: in HT/VHT, the maximum number of spatial streams the * station can receive at the moment, changed by operating mode From patchwork Mon Jul 10 23:03:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307826 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7680C174E6 for ; Mon, 10 Jul 2023 23:03:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D044BE41 for ; Mon, 10 Jul 2023 16:03:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=f/MtNGpQun39fx6LSI7qRJxRUNBlKML4XkW01NaHDZ8=; b=WUULXNxemv4VjTn+uRbeWtLEkA jwQervK+GQRGJ9qyDdt6XiG876aFdic+Ml8RkJ+94P4HaurbAcjU+yHD8l2VhGahrNDhxXrhO5hxG iZ2XrRHdwAuVzxX5a5PjZsBNMK4vZZXqG/lUMM4KCDgSIpdJAqVOypKrc8CMkDtiJnXaFFAHtqs+P y+r0qnM18UjSKqjUcSfUhOn7UE4DJ81riY9wumTejQgi1wLg0ZpkLlQ+wtGIqB4wSfLnHgsvWN/do 2lktiuNkXwH6QtOJATPhp4zHz2OasNMuHkNwI6h+1PIAJE7+a4kfdps2JLZvuanVYvneNk6yww2uo SGP2uksw==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuY-00CuO1-1r; Mon, 10 Jul 2023 23:03:18 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yi Yang , Jiri Benc Subject: [PATCH net 10/12] net: NSH: fix kernel-doc notation warning Date: Mon, 10 Jul 2023 16:03:10 -0700 Message-ID: <20230710230312.31197-11-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Use the struct member's name and the correct format to prevent a kernel-doc warning. nsh.h:200: warning: Function parameter or member 'context' not described in 'nsh_md1_ctx' Fixes: 1f0b7744c505 ("net: add NSH header structures and helpers") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Yi Yang Cc: Jiri Benc --- include/net/nsh.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/include/net/nsh.h b/include/net/nsh.h --- a/include/net/nsh.h +++ b/include/net/nsh.h @@ -192,7 +192,7 @@ /** * struct nsh_md1_ctx - Keeps track of NSH context data - * @nshc<1-4>: NSH Contexts. + * @context: NSH Contexts. */ struct nsh_md1_ctx { __be32 context[4]; From patchwork Mon Jul 10 23:03:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307830 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2937017744 for ; Mon, 10 Jul 2023 23:03:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9318F11D for ; Mon, 10 Jul 2023 16:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=yBiQr9QkgT2u++uzYKkTCPg+dXnnz/lfTj6BtKd9PYw=; b=wRYNtoebzaQKp0JM2ZILcIXFRk 2jWU5bIyFPtbTN3o4TNXpqbH5XxSO9YpQHuYL0ud0zOtIp0FYyUTh7wt3WjMrx48SJMYVP3hXsX1q tZG9TE9sZPNfJK8YwO+Mf09SJla69/owZsTAL+/POU2iUuRD1OMmtuFb+T2JM1g37mMcWm31EVTTg JYFK00E2ltcIsVe++GS1K326oGuQWO2eQtQqR9dJtwMeeV8+hq/4lrw44ajLqNUl5GlgNYkcGqtXH G044pzeZ3bfNCchyoZxHq/JCTpHuM0zkNPf26YPeKshdJjzVJjNaWb4Z/MPnO6v+f0T7ebWpjoCZP UqpRwQFA==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuZ-00CuO1-0N; Mon, 10 Jul 2023 23:03:19 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Leslie Monis , "Mohit P. Tahiliani" , Gautam Ramakrishnan , Jamal Hadi Salim , Cong Wang , Jiri Pirko Subject: [PATCH net 11/12] pie: fix kernel-doc notation warning Date: Mon, 10 Jul 2023 16:03:11 -0700 Message-ID: <20230710230312.31197-12-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Spell a struct member's name correctly to prevent a kernel-doc warning. pie.h:38: warning: Function parameter or member 'tupdate' not described in 'pie_params' Fixes: b42a3d7c7cff ("pie: improve comments and commenting style") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Leslie Monis Cc: "Mohit P. Tahiliani" Cc: Gautam Ramakrishnan Cc: Jamal Hadi Salim Cc: Cong Wang Cc: Jiri Pirko --- include/net/pie.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/include/net/pie.h b/include/net/pie.h --- a/include/net/pie.h +++ b/include/net/pie.h @@ -17,7 +17,7 @@ /** * struct pie_params - contains pie parameters * @target: target delay in pschedtime - * @tudpate: interval at which drop probability is calculated + * @tupdate: interval at which drop probability is calculated * @limit: total number of packets that can be in the queue * @alpha: parameter to control drop probability * @beta: parameter to control drop probability From patchwork Mon Jul 10 23:03:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13307828 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 292EE17742 for ; Mon, 10 Jul 2023 23:03:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC1CEE48 for ; Mon, 10 Jul 2023 16:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=EyhtIl8iNwnZ53cBhS0nr/S/j3djORhPgE1jFYLM2BY=; b=NH5798TI+tbxZ7e0scBfTXwoNu 9zte4Yy069Wnwl+tw+oOS5tBRKoDcr1mA5xug4WRCE12xyMuFb//fJusl/V02QdzTKOy941OBpygy gy+lPhUBa45DwLeXmJRMYqDyGMEVxr9xrgc/U/8vX2q7cElqUYE9biCR6/jRR/EaHB+glcVj15HsF DMCFR8HKZILkUCQsu6ggxHp5gx+LwZElsKnyBS5K5+HqBs+x+h2juX6w8tYiZ1JzDFMIDI2PqKkYc /vp1wcpiNXsaZT0sKu5xv1HnbkjOP5265VIQuZItglbWANlc31DMKasAHqBGCevDwcesboicStQKe plvh73Ag==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qIzuZ-00CuO1-1z; Mon, 10 Jul 2023 23:03:19 +0000 From: Randy Dunlap To: netdev@vger.kernel.org Cc: Randy Dunlap , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Prameela Rani Garnepudi , Siva Rebbagondla , Amitkumar Karwar , Kalle Valo Subject: [PATCH net 12/12] rsi: remove kernel-doc comment marker Date: Mon, 10 Jul 2023 16:03:12 -0700 Message-ID: <20230710230312.31197-13-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710230312.31197-1-rdunlap@infradead.org> References: <20230710230312.31197-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org Change an errant kernel-doc comment marker (/**) to a regular comment to prevent a kernel-doc warning. rsi_91x.h:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Copyright (c) 2017 Redpine Signals Inc. Fixes: 4c10d56a76bb ("rsi: add header file rsi_91x") Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Prameela Rani Garnepudi Cc: Siva Rebbagondla Cc: Amitkumar Karwar Cc: Kalle Valo Acked-by: Kalle Valo --- include/net/rsi_91x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/include/net/rsi_91x.h b/include/net/rsi_91x.h --- a/include/net/rsi_91x.h +++ b/include/net/rsi_91x.h @@ -1,4 +1,4 @@ -/** +/* * Copyright (c) 2017 Redpine Signals Inc. * * Permission to use, copy, modify, and/or distribute this software for any