From patchwork Wed Jul 12 22:42:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Iuliana Prodan (OSS)" X-Patchwork-Id: 13310950 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F351EB64DA for ; Wed, 12 Jul 2023 22:43:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=MdnOTAyOcR/QultCh3UpgI84EoEriCbE9ILEzIXhT2k=; b=AG9iSXDK5M7sf6 19FIPCSg/Z3qrzSANoiAnDGU6cdI4hlAQHFey0SNqugsFUuj4RJRaZo0JU5nk2GaPa6oqnYSD5aqz 3oXmk13wMegL5U/LVSoeXy+TGqMLwUPen6OPtfZ3eTLRWbHzI97NQbTBzlXaENLAiN1qqQmNzE1zK xhfBtCn4sWI9R9RFQrFm0BYHOJK4K7m3H3g5q57q9UpAo6oE1AF4wgnQ5rjto8t2YH+NSLowcr0PC Z2b/GBsXlx+ryVOV9qJaU7gmY6ImBdHsfAi3LCFRCSUJJYjM2xodlYfLfL1TUBiZZDL7fnEgTRUnQ POZdGg0JE5/8jf/NjoMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJiXz-001Q7n-0z; Wed, 12 Jul 2023 22:42:59 +0000 Received: from mail-db5eur01on0621.outbound.protection.outlook.com ([2a01:111:f400:fe02::621] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJiXv-001Q6R-2S for linux-arm-kernel@lists.infradead.org; Wed, 12 Jul 2023 22:42:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RacgKPtJc84Azu+wLEg5AkKjT6nW9LcBRAPCORUlz/1wzX+V/m+mYpMFd/f8auwBx0LjMnLTMWU8doJ0Rs0NGQF3RWzHqg9/yAePyl9mhO5p3FeG3MTI5T2cEwhifecePJW+/3zQb6zF6mrr/bcZ+Sc/3hLfqu1gLAeMvMG4iAYFilE+Gpyp+vFIJ4S+eKrKO74aKBTDOv4/J9iVaxXDa3GFOvgmmNA/kZYfSG2bqZSpwZhZhmdyVdMhgYg/HpIAzTq6cOiyGBfJ4qLdytbDXmpfIb/OLuxY33IvW21XIS5mdElfw43PW21uXmbpiJWLK7rWWvcl2wgeaVWCxtHAZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BBnmfxiM/+44Im5++FVwTIAmNUtOAjpYqsKqGEDFS5M=; b=mjyK0x5ZXFMNIimsBhBOt++W58brPGvN7q+fpY2o0Oq52gUVLM9r/EFFhH9jtIdw5sCY/c83hkxC90UeOy0k2fTHl7+55UZ4mbIbm7iJZI9Nlg8AnNdkB0CvCxEdJl2FcrdXXzTni7XlcTa7MtccfAi0ygf52pW3nVKPE4xM54pp+UVTFrB5zGnbE+4w0h/JcX8KU3a5+KuArg0IdTJgJAt4YhG4SyQKEK4DBRFErG0P/B48uY+/4uEBNaGjejxK7UXcZksu6UQYFd5Kr0lSnhzggkxtrQKfmmB6l1h/DOKE624dRjNNPo26+JvjDu5PaS56cwybbr9cFXEW1eQ9JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BBnmfxiM/+44Im5++FVwTIAmNUtOAjpYqsKqGEDFS5M=; b=NajU2ZjfEYwgAfLO8/hnPn+gy9cTs4sOlWmmbhfRWwiTkBHQFIrRnxaF2UgL8J4lJOkx7jgw147yoIJFmq3Ze5nA820dbnF7YRjeXhVmq9vZHPuuHgv6nB+O09TspapcmEPxozEQUMPS44waGfjvTefhSLfZN1j0LF2+TkFR8Ew= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8781.eurprd04.prod.outlook.com (2603:10a6:102:20c::22) by AS8PR04MB8545.eurprd04.prod.outlook.com (2603:10a6:20b:420::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Wed, 12 Jul 2023 22:42:44 +0000 Received: from PAXPR04MB8781.eurprd04.prod.outlook.com ([fe80::a576:5bda:df13:4246]) by PAXPR04MB8781.eurprd04.prod.outlook.com ([fe80::a576:5bda:df13:4246%6]) with mapi id 15.20.6544.024; Wed, 12 Jul 2023 22:42:44 +0000 From: "Iuliana Prodan (OSS)" To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , "S.J. Wang" , Fabio Estevam , Daniel Baluta , Mpuaudiosw , Iuliana Prodan Cc: linux-imx , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team , LnxRevLi Subject: [PATCH 1/2] remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op Date: Thu, 13 Jul 2023 01:42:20 +0300 Message-Id: <20230712224220.26430-1-iuliana.prodan@oss.nxp.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: AS4P191CA0017.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d9::7) To PAXPR04MB8781.eurprd04.prod.outlook.com (2603:10a6:102:20c::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8781:EE_|AS8PR04MB8545:EE_ X-MS-Office365-Filtering-Correlation-Id: 6087fa1c-1d14-4859-eaf3-08db83294edc X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VWPFA6ysn1XkbXyFE0P4cpFHFWBhsrUZ3p1f/lnfeXGEj5uHbPo7b6HvMA4N4o2zM/xBEIw9WhoGNgvcYxVRDDEmx0CcfwQ2W5eS9dxs0tkSMA/VXU4HZrTyALU+fJVmzygM0awMHS5U2O89srhzeA4d3uYSiie2vD8haJkX7i9GmbzkDcKr95RRAPfn9T1VQFDHW/v6ZVC2c8btn1hNpjR53ctgNG6ziz0UMlyc6fi4HBbvMdhP0h44amFDMdJ2vuxdL3lWOivysR7ZZXG+sfU5uJ91D/pnAI5Bw42ti3PmuaYGKAomat35r7hlZpmLuRgb/tKLV4aidpKfXEq5CmQziYbal1EFe5lMA3tMhd9HVZ+j97ffQ5vwsxP7FfrkFDS4DCQkDdp6tj5FGur9zXRIwYfu4Ty6yYDCv56KUwup2HJoFsKacrCErJYGvwdv7nNXwLf84CtA/v35v5+ELr1j2ifdLg9Eaqzv7hM56cWLK23lwhXn/HGjvWH+Xzo19Io1DFL3rN6CPDxwHlxJLeqWDmxNQYBS+C1/vMKNHO+GzHW3I7HISgdxJgqV6jKZ83T8+xGjEmM1bnHnLhjlPTYEfs35jDQwfjfh9xyR6GrSofM287vcd/IGOyzc/qS4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8781.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199021)(66476007)(66556008)(4326008)(6506007)(66946007)(1076003)(38100700002)(186003)(38350700002)(26005)(86362001)(478600001)(52116002)(6666004)(6512007)(2906002)(54906003)(6486002)(110136005)(8676002)(2616005)(8936002)(41300700001)(5660300002)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /M5akNiFzLe6HNqTOWiWj0vZbHldu910gd7lzf7IFg4r9deFjJ40XS+PTVyjcvSaHt2e/ajPuS9+1+PoOHzBlJ6JlTPiB2JzHNM94sNRiW7FIFpLJ8lPyZikfzlp8XUn2wxEILFjB0nOQ2hgr4J5pLh6BDayc7bS3mI7cAsxOGCRMRq8dqqWZlRBIJ+Ieg8q++Y8jc0jHrUc6hBpnw8Mhuv4NTiSIboWLMucH7RWRIsv13asSIsEo8mWU5KM33hnn3/dlOLZyHLViOBWVL42ToKdfrglvIGYdGM1x6SStVioxMqep+7JAwh3Pl4XZ3JcftSfHgCCZoZ2GmuVgN6J/+KR09dsYHmSZLaQbmuKV9PGuuSSrGDn4WDoBLFPFCh+NnZzwDZc2pGWW5KwiG+0Iwvnnnw0ebptsjZxzuX6DpB1Dw99xbLpZRKuj0egCB2eu3PZ+kHXErtMkl1pZMG1MS4IeMyLGrHwfkvlQpxpXXH/SVBlOfD+m++MstqlCYqulHhsGzBSeSglXSKro6swSCRKomgZprOecvLcKR+8xcdJZ/rGibZfK4MatWQbmjWmVPQmfEXB7saXw8myJOWstbyUdGizAmRgyDBREkLU+bJVGd8e2lZZztrUMdTnRFjZSqvH9MDSWcxcr0pa1MJ41Q3wUsLsnzRMalitQmz4DoHfj8JaIcXBmalwQUHjOyG5a5N1dgvUVKCt0KDklWGUnCMt+eLO5BQIVm3P0UYY8D+1I9ZwGP+eDJZB47DE/SHRhaKfbx3ppyzMUwrM85vmVh7LgREPuw4YzZP0U8vA5ld4SjnW/wVwylwqVU9wXDln03R7UxNdv3nV+SlD9pDXtebBI5UJ9DWJFcGKg6g85MtSPDdK2d8q9pDuGIRZvZtxZOctAt1KYDfcZMdC0wQIbOFCvL1+ug+4rpYc8wPCHPhBQ911bwPtGqLJcA8jVJbI5LITSrZw1mQB7l/dBg8mVv4FlS7NdTxBI2GDf7ZHNBmCOBK9yocVHgElkpfJ2JDRNj24ycq1Jp2dToROo4TeVWYpWVBqNAGnLlPNzQpWR6LQ6K1M5kZLtVVgriKdB4vMjhg3kb8fpiSEi2XuxXfd9vuKFfOW0G/G8Bic27kfPuwUYARhHx0oymDwa+4hzl7wWey7RwGRXZf1lmQ+Yo4oagyzbIBO+Jb8o4CR870ZjYawCAzS2kd/2qOZurIHfSkURPvHwN2OwRmlnaV6YhJGaffw4FxmW2pH5PSKnHdjvVvp+mPSEGtjvxBUuenhheDxpBb9GscOMFqdutcTLhcdl8p72BY87ss2Cv17O6pce3T4OPzxsH5wVMB/ANJH1lsIQmmuSPyILUHMEp6yHIidURs4bBVLdPsB3+K2Kz+u3RqsgF9a8JTtFu0iGx+qHOntXEZib8RSHqfHc+NMaxSGOz8J2EErfg8nc5MpJ3A79CiqX/gLGTNZk6094QZSOUUtfkyfcncI7fkwqhIzrpLNd4sU44RiTH22Dq/aCEKSf3Q6rJj3s2c0EJtpcFQaUREf5einMDfXkBCy5dAPaypYOzzvc0+mAOcd9y4CmRHlELKJq7eTX4kYnpGxE77jBQHc X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6087fa1c-1d14-4859-eaf3-08db83294edc X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8781.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 22:42:44.5187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KKSkNocAAb/PRfX7DOSxzqwTn9XAo6kwGpsrHeH/Fa5XXFPbPulkDRbuYDT3E2kzZoUhFXwpK0aVJ4KZ3YKnYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8545 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230712_154255_823180_2E7CC6B6 X-CRM114-Status: UNSURE ( 8.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Iuliana Prodan Add the .find_loaded_rsc_table operation for i.MX DSP. We need it for inter-process communication between DSP and main core. This callback is used to find the resource table (defined in remote processor linker script) where the address of the vrings along with the other allocated resources (carveouts etc) are stored. If this is not found, the vrings are not allocated and the IPC between cores will not work. Signed-off-by: Iuliana Prodan Reviewed-by: Daniel Baluta --- drivers/remoteproc/imx_dsp_rproc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c index d95fa5586189..b5634507d953 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -941,6 +941,7 @@ static const struct rproc_ops imx_dsp_rproc_ops = { .kick = imx_dsp_rproc_kick, .load = imx_dsp_rproc_elf_load_segments, .parse_fw = imx_dsp_rproc_parse_fw, + .find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table, .sanity_check = rproc_elf_sanity_check, .get_boot_addr = rproc_elf_get_boot_addr, }; From patchwork Wed Jul 12 22:42:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Iuliana Prodan (OSS)" X-Patchwork-Id: 13310951 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BCA1EB64DA for ; Wed, 12 Jul 2023 22:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+WfaEFz0QOQcb9tm9pCNxw/8k6ndk/oClI2ZuRbgXX0=; b=ROFxlEitRamBtM UGRo5KqhirrCqOpm1KHPSyo9NcIETx302Q84QUtagQCiU/Cpk2rqGr2qprSCTMmpqGLLpx+4P70Lw qS8ibYZc3bqDhKHJp2XtifXxZotxZTedQl31brjZBfol13qXfI9WWR8lLfCz45y+sYT8wKI0g41sw 7NaUbcfLb5ssTzoXy8d730hGihejQkCCBfihI88tz1PIGO9ZNXjTYtH3UIsW2VN/W4yjwR9E2N0J+ t6ILmUJoq0RMT5GSkO1HceJEzMY8+dZUbkp9j0BjFFEoip2ejCWu+iE/7dlWfZhoR0dyu9IJcGfSU aa6pHTVLbtFxHru/SqtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJiYM-001QBI-0C; Wed, 12 Jul 2023 22:43:22 +0000 Received: from mail-am6eur05on20619.outbound.protection.outlook.com ([2a01:111:f400:7e1b::619] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJiYJ-001QAN-1b for linux-arm-kernel@lists.infradead.org; Wed, 12 Jul 2023 22:43:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMUH4u81cKoSYGpbS4HRW2TpTtweQW42ClgRhK/c7X49m5U6cENPi78z4cK7RRhV/sJ4KW2tExmcUmULux5h59xfRet/E6u6Y7SE6Z4P8npExiEnGeaXV/j9pOrDJprCBHbU5kgZPLNvRPuvDozu777HjB2oXxHhhgTLs/tDVsEGCde5R5rAHlj8DV5z0oNpvOGR4aMwtrRQPVJ41Ot8PoEHlVN6m0p3R9THYk70on81h8/Cep8jPoomnC9TT27nwLt66xW4rkEX3aurLBZEFsmvPCJmL19xzJ3j46JtHKZ/kLKyOykOXsJ4ax7ICl9zG4g4C5XFazZMnvhZAn6RJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fe7xGkuFhcHKkTA+9v652itScjQ3pIyJtN+61CmRkvM=; b=VH7VSFaQOo2n3xNUQJfalCx1pmAbZiAncaby+o5QUOiTcKtchywrkqGEiJwaJ6yt5oUtgzIzpE1CKOXq15/5bIgvpu8bKqOVCcfXepEwkLqvpbM8NN2lYOZPMi8kqi4FP0c+p4OWoaogmgYV+TXmGKhMMbdhzIDI4+d5I1f7t9blhnUezZi0Ty/XJx7ASI70k0XQ7HpQ0ETx2pZB923xYAESJkXpjqQm/SR3oukoZ29eyI0h/Forw7jaHtUS9v6Qw2z2cEuLXwXuPnpkhN+8XQS/0xwNUnBgrjsXyWFRDluC4EN1dQGr3x4dUbDJIst5LebK3JCgw+H8wAgv0tws7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fe7xGkuFhcHKkTA+9v652itScjQ3pIyJtN+61CmRkvM=; b=kQpD+xEe224UBX8K2zBMiMv0VxhVGFiVjyHgHriwjntABKNfoQJZSwOQDUjkMv3HhtJHOEZJe/DUyS/tL+ORw3ee2QqmqJS1/+LwF+Ug2YDnP7K4BBhDn2UeUu5BUZbRRspOnfQcovdUW63XvvkeK60w3gKC0pDuFhuXU3cHKG4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8781.eurprd04.prod.outlook.com (2603:10a6:102:20c::22) by AS8PR04MB8545.eurprd04.prod.outlook.com (2603:10a6:20b:420::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Wed, 12 Jul 2023 22:43:11 +0000 Received: from PAXPR04MB8781.eurprd04.prod.outlook.com ([fe80::a576:5bda:df13:4246]) by PAXPR04MB8781.eurprd04.prod.outlook.com ([fe80::a576:5bda:df13:4246%6]) with mapi id 15.20.6544.024; Wed, 12 Jul 2023 22:43:11 +0000 From: "Iuliana Prodan (OSS)" To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , "S.J. Wang" , Fabio Estevam , Daniel Baluta , Mpuaudiosw , Iuliana Prodan Cc: linux-imx , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team , LnxRevLi Subject: [PATCH 2/2] remoteproc: imx_dsp_rproc: add module parameter to ignore ready flag from remote processor Date: Thu, 13 Jul 2023 01:42:51 +0300 Message-Id: <20230712224251.26482-1-iuliana.prodan@oss.nxp.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: AM8P251CA0002.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:21b::7) To PAXPR04MB8781.eurprd04.prod.outlook.com (2603:10a6:102:20c::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8781:EE_|AS8PR04MB8545:EE_ X-MS-Office365-Filtering-Correlation-Id: 939865bd-23bf-4a42-e573-08db83295eae X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rt+qCRdXdQx4jQmeOHbYSlyVHyC4hWDN7oPz/w+XBM2Az4PC0Od+Tvi/2w/Ew03GZZyMQ+EGVpM1d6npkXUHzbvcQR/iNRj6yIROJj/prGFMIqf2cCLmmG5hxziCDa680pYO0lfg+PG+Ge6F2nsDqskjDcPgFnEllXNgPxvaUc9o0zCtdCespMOjrGRFkIExvoysZq/a9gU/5k83CJdD2lO/+oSMi/mJLYvgaG2uQAH5B8HEiIvnRksPon0LvX6gEMSEzdYev33H8ixN/zWTaPBIdAE6bCCeo4m5dEapZKQD8KcsiFCAa04PicM1C/wsD56N73ZEB2ZmF8HFtAckIo770HWYXBC7yrBzk8vwJ7uhOYIKE2RtOYwSAuHJDMsXwAzF+tUlF20zLmwaxEFBUtFe+TYlH/zDk0OFnFys0+ITa6dm3DyvfKPcRJAK1da+neEwucUShId2TbkjgMnbbziuicfgCR2afs4CGnMRXtP+7cmY609vAOtcnt3dhtewx4snSeZiyaDCzKcjRzUlmuHmxhX/FkWME8aQP7GjwE3IXcD3GYli3mzqykgw+kfkLtrn3GMPns1L3bCMNTnGNLS3A9cy7ldPwIIKB4wqEpc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8781.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199021)(66476007)(66556008)(4326008)(6506007)(66946007)(1076003)(38100700002)(186003)(38350700002)(26005)(86362001)(478600001)(83380400001)(52116002)(6666004)(6512007)(2906002)(54906003)(6486002)(110136005)(8676002)(2616005)(8936002)(41300700001)(5660300002)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oKcM7ia/pZ5ENW3knYE7Fnii7UPYUc4wB7bTZQ+YVVNcBw9WceFTDveA3EjForog7tZ0fyM9jaCEW6yt1zX1f2gsp0saoqICYPHHoewEMLjE1fSPvBI0zR4Io9ZmNR8MP66s8X/M1HBirfBLuCxYFAFOg9idO9UEvkhKBOEiu+CNHSFAC7gmc+bRN8wEeCiVbJCqlY7OYD0AlT6atudvmZC3+pvuZUrjsdCqE9cpuFpiObEa21BGIsOHJgeUiBjjJTNiOp2Xg65X4YOEHTOdBcbYQOZzB+Rmc2gyazRWwg/TQwxCxnkyPcLUWmPzdhzekZdvEcxnqE4ZuEhDW7HXo8OssbnXoejIsNOChtZpb5hSjIdyOHggzNK585YPN2iX5Ut2HjBe1k0wpEHKDDaRn7gtWQdS1aZaIUh5OsTDh0R2cx2BQ0nmBLp/jMxpuoglV40g8WR+Q86wry1nHAz2JluWLVIapjmvom+0TRz4NTKEdTuikhDb6jw465S4ukd1zoqdS5TM4YncGLHL564zqZTZwRvMuSUe4KEjsenpzU+xjShDRzJ35D4tBRqxND+ZzdPm9CqAFQi0dpRnDszd4EoqAy6aHesAgGCWdk/JHkceleWPBQSACMZHjgGeR0uwAzfrOqBuB9pVsSdr9mxdSW2L/+2Le/9HsbMtas5BkEWGX9iZJ2YOE9c2BmA4Orw8ug/Oekd8Jh7iDDKM6ohJWVRflZcfpO+beK+vhKzoLE7m8ijYYmD+u11Ngv+y8vBuh8Dzi9lbdbsreK8fC1RkvWQpVDD7NxIkhJPWrSUd5ny5MOzWMOg17axUIxO4ghJDFJxb5KIZyQqhHZeP8L5cBLlSMiVJCjwCstxNTdlVFYEHqzSvVs8CqmmhljFQDir809udA9HGLuT2g/LhInBmnkGCZZsLgIiG66GwHGT+ajg5L8eDsspSXPIxXGwQArJw/0P/9kWc0Y7C8iC5NHmn/EO8lggKUJdVFPyQ9EwrxGokBa6v+ZuL3gKE081gXHf3/K1jSoBNJCcwVGRAQZcaHShNV18Swnlc0t/SGuk2Bc0ryKFxhTEqNTCcDQ8zqCyR+VeK4iIVkj4C/ZBVPPOaR9sALTj4srMja9dJFZ7EdcsesxsKj/G/JBCFx5/TfUf4QrVT7ABWpCAGDcgoVxQD/4mJ/1EKtAj4/yNCRYQJnf76cA8XCnTi/L+twJIxVkt4WV/nK5utV9IlaCyho9GzvNrkanIvUHJB0QwNWF6DZoZoUufeZPAywwmB0Em5tX0lF03niiSkk6PbMz0PoCKlbfGPScoMxNKWUdhCSwDDPRCtcbiJGIjPeMQrkl0uFN4o1qTu1D4IGYX0tuoAfxsBlWRAx+Ky8ytB08gQ1YZsoeGuWRkfzP8Uwjzd+NZj9odCUW6ZuKidIL0egj8FLU27EBlbhhF0db/GSqOb1jQLTDGAUX7QCIqktlIpx9LdKFUxbJ5SGOl8c5lPcZl44aVS5sQBXENyrqRu//Z6J105XyCNqOdwYG2Goew9MdtEIpuZ+iA0HGy4s6fUcUoi0/kaqjKLjwzLbKxd7Nw+XNYC1Sf8KlhxEMjHhm3gAWOBwnLL X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 939865bd-23bf-4a42-e573-08db83295eae X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8781.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 22:43:11.0056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5bhqjP8/LgE5j7VWpfUrsyXIK0Hp2BHPOzasWaBmjvh5fuPtpwBRgXi9MsopWaryNgm9IZjSrPd+yDQIjMzvEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8545 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230712_154319_539529_E070D430 X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Iuliana Prodan There are cases when we want to test samples that do not reply with FW READY message, after fw is loaded and the remote processor started. In these cases, do not wait for a confirmation from the remote processor at start. Added "ignore_dsp_ready" flag while inserting the module to ignore remote processor reply after start. By default, this is off - do not ignore reply from rproc. Signed-off-by: Iuliana Prodan Reviewed-by: Daniel Baluta --- This was discovered while testing openamp_rsc_table sample from Zephyr repo (https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/subsys/ipc/openamp_rsc_table). We have IPC, but the remote proc doesn't send a FW_READY reply. --- drivers/remoteproc/imx_dsp_rproc.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c index b5634507d953..ed89de2f3b98 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -36,7 +36,13 @@ module_param_named(no_mailboxes, no_mailboxes, int, 0644); MODULE_PARM_DESC(no_mailboxes, "There is no mailbox between cores, so ignore remote proc reply after start, default is 0 (off)."); +static unsigned int imx_dsp_rproc_ignore_ready; +module_param_named(ignore_dsp_ready, imx_dsp_rproc_ignore_ready, int, 0644); +MODULE_PARM_DESC(ignore_dsp_ready, + "Ignore remote proc reply after start, default is 0 (off)."); + #define REMOTE_IS_READY BIT(0) +#define REMOTE_IGNORE_READY_REPLY BIT(1) #define REMOTE_READY_WAIT_MAX_RETRIES 500 /* att flags */ @@ -296,6 +302,12 @@ static int imx_dsp_rproc_ready(struct rproc *rproc) if (!priv->rxdb_ch) return 0; + /* + * FW_READY reply is optional/ignored, so don't wait for it. + */ + if (priv->flags & REMOTE_IGNORE_READY_REPLY) + return 0; + for (i = 0; i < REMOTE_READY_WAIT_MAX_RETRIES; i++) { if (priv->flags & REMOTE_IS_READY) return 0; @@ -1119,6 +1131,9 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev) else imx_dsp_rproc_mbox_init = imx_dsp_rproc_mbox_alloc; + if (imx_dsp_rproc_ignore_ready) + priv->flags |= REMOTE_IGNORE_READY_REPLY; + dev_set_drvdata(dev, rproc); INIT_WORK(&priv->rproc_work, imx_dsp_rproc_vq_work);