From patchwork Wed Jul 19 05:37:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Ming X-Patchwork-Id: 13318239 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0B88C001DC for ; Wed, 19 Jul 2023 05:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=waHO03/1Udj/0wkalnQMFtK+OZwo6mp1iXV406CSf2E=; b=pGPPzqsnsI7Eoq iiW2awIdr2tkBaoGwMWtHla9NkC7pFEGqKmpjrQRYXlI0p0zvk7eaeOrpyO2fRRB47cHeEa0r8mBY OEfC89iUx1+H5KuakhfJZly108lvNgsPK/axT6eIDSbVOTRMluVVW5YDoKQkovhgZpcDPoZfPEXf8 /NmBFL1RTDydBGvd2zbaHfJFYQG5XZD1kJDz4Lr4SepV6gn9m9PWhIgzWhMNRpAJGdlGyTI7WPUZU 6gb1DSSYq4WAqoho1zmgPlsW+zrNutz3WbS+qMAajm3dIbmuS9wyN5dJ0fe9vSHxp/EwyWA10gdqg SUnPFa97zP/N33t9HE/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qLzsC-005M6d-0h; Wed, 19 Jul 2023 05:37:16 +0000 Received: from mail-tyzapc01on20723.outbound.protection.outlook.com ([2a01:111:f403:704b::723] helo=APC01-TYZ-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLzs7-005M32-30; Wed, 19 Jul 2023 05:37:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H++J3E9rXWt0pKJJl0ZhmSWY9QG4soFYkxZZPmNVW2R5woNoKDqc3GVkt9OD3ps3q2bPvE582qCIbS7q2dnGvkt7LMu+8G9Ixan43DzbguLJ0qDtrRkXWA9pw6IJZXrwAqhXLrO4ERlgU5k2VD9Q8rvNpozck/Cg532w7+4TZY5zZXseqV+w8ty+3AYyDoa0qlEw5CC44fSWyKnNT8wRa6zIS51NCgHot/R9bcqNegZMoy/Tbbx+fsOkK6d1iCYSiTZnmsR3oBkhkiqkkxZ+dGh6mYgdpRI6z0fynimwSaQeoAxwIlPVvjqNvJ8SldqvRYA4UXtJT4vCa1b0rEyGkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NG2JkQDtttWolau4fcxd3GOfAeOQ91Zas3zpPBSSYN4=; b=jMM+eGA3XOW3qcSikGtnt9l0g/qJE0VfmjnP3YlXysJ1IoeU0C0laTX8oICjI9QiPrsRRFNIiaj7eN8upWP6iMUJs94XNLq1C/bjhiCsj2iHIpP48YJ6YwrO1LpgDcdUtpGI7qMWgkABVHSngckDDFpgn0/zLD+NSYKkpaRfwkqyNUQFVtFYU4ZPKgFKT6P0fa7wEl/Y3Y16nb0xOUGExCu9qRg5gg9mM536NfEa+tTc/AdMkkePC5jvAm89Sz/FT0FBIgXWhdbLOPDes90rwVrVsnHJhOnCdGHxqBokFmefhwla7ooPs+nv3wlDdw0L/1O2TyQxpD0NNSyLlklWZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NG2JkQDtttWolau4fcxd3GOfAeOQ91Zas3zpPBSSYN4=; b=IiijVclOGRTRRcGi3iZW/BuHC3/qId96DvFuVSLsUEZyiYBgtGaVyCuHPbUQDBl+p+gtwMp9luM/kB03QljDN3o7UqfwyNreB64L/8wU0cu2YpkmnBBos5cmhog8JfxnJnTKgNhJ8aHPTgum48S26qbt2LLnkVrUlj4yJNe5XgHEdXcjVKYef85EgNPahTY6D4jJ+pUYIL1wAiGr4MKoWFXxl4vA8w70Rdbb0G+Y6UcYr8wR2/+vTM5ROE6xQU6UfsDIHKrX5C7ofPdvhCbLRhFDrRa5alBSu5ud04kzsVKcuOrr9W8ONv+e0ltJll135u8IY0L24ZEck82fa0sK9A== Received: from SG2PR06MB3743.apcprd06.prod.outlook.com (2603:1096:4:d0::18) by SI2PR06MB5242.apcprd06.prod.outlook.com (2603:1096:4:1e2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Wed, 19 Jul 2023 05:37:02 +0000 Received: from SG2PR06MB3743.apcprd06.prod.outlook.com ([fe80::535e:25af:a3bc:d600]) by SG2PR06MB3743.apcprd06.prod.outlook.com ([fe80::535e:25af:a3bc:d600%4]) with mapi id 15.20.6609.022; Wed, 19 Jul 2023 05:37:02 +0000 From: =?eucgb2312_cn?b?zfXD9y3I7bz+tdey47y8yvWyvw==?= To: Mark Brown , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , "linux-spi@vger.kernel.org" , "linux-rpi-kernel@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" CC: opensource.kernel , =?eucgb2312_cn?b?zfXD9y3I7bz+?= =?eucgb2312_cn?b?tdey47y8yvWyvw==?= Subject: [PATCH v1] spi: Use dev_err_probe instead of dev_err Thread-Topic: [PATCH v1] spi: Use dev_err_probe instead of dev_err Thread-Index: Adm6AwupYKfo8BPWvEO2q5+CNEXUOw== Date: Wed, 19 Jul 2023 05:37:02 +0000 Message-ID: <20230719053649.4632-1-machel@vivo.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR02CA0121.apcprd02.prod.outlook.com (2603:1096:4:188::21) To SG2PR06MB3743.apcprd06.prod.outlook.com (2603:1096:4:d0::18) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SG2PR06MB3743:EE_|SI2PR06MB5242:EE_ x-ms-office365-filtering-correlation-id: 08561b11-75d1-4ac7-6168-08db881a2e25 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lOoczK3ztjql/GRsfBVYIgTyHLVukXtdntQx5D6NVAASP9Z7fvrLcPpbvRue5FHDg8tcVhnXGY//1Bffqja09aXbrWB/zw/W5G9xKJopLBUcwlDeNsRv8I03SKKDILckdy3Agg0epUoWi57wuYv5nw1I9GayxqdciP7c3uBnA14aeBJKtuWEfUrTp9ko08/HARZNdUg3vJz64QadjQz7oEdHpRKilS1rGbHtSoWMOrDQ+hWteVywXCsebUWk3v8DCud6kDeEB5UkMZPSJispnA6T4zwqvzOaGdeHZUMQFhdboEekQrviXzg/clDnBQv1lkRzLWqCsZ/tkTduGqMrRd9bMYI9Pk0MEhe3GhS78V4AuisEmOCt/eD7Tz4UI0u+ZqnaEKLv8BN9dc0NytjdtEK+fvaJrQ4Kuv8TDLTddVbu/jXds1RHgH/gUz28owKDS9tmbCh+lVW2PPWwK890W6kEZW4iUGRzjNCIn44DRqhW8aj8doUXVoQif/WVm7HdwOCWz0qa/pjQGUYpkA8IoEsc/yFzqtLfSxxZ9WFs5qeGB8xjB2FJId+9rLi1DJb5PTYaNuEGGD0Cyxmkcl928fXd1vNrCuswqjhYxk9T1Ufr5eezzj+kUWLDT6szSZER x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SG2PR06MB3743.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(396003)(346002)(366004)(376002)(451199021)(2906002)(54906003)(110136005)(478600001)(41300700001)(8936002)(8676002)(5660300002)(66476007)(66556008)(64756008)(66446008)(66946007)(4326008)(316002)(52116002)(38350700002)(85182001)(2616005)(36756003)(107886003)(86362001)(71200400001)(1076003)(186003)(26005)(122000001)(6506007)(6486002)(83380400001)(6512007)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?eucgb2312_cn?b?dnpjaUk2S3VrcVk3MmZPMkkx?= =?eucgb2312_cn?b?U2lseDNVek8zaVI3VXZBei92Y1R1SWFRcjFIeGRkUTQ0YUFaaDRUcmlNUmt3TDd1?= =?eucgb2312_cn?b?K3hzaHBYeHhQNXlPUXhtMHpKbm92bnR0VmJhR2g2c1dsSVJJV0lId2grRHBWNlFx?= =?eucgb2312_cn?b?cUJXeDZuaWtJYmh5UVdOOUhpRkxWVnFuV21UVnJnekRENTNvUHlHVkpvWDNwRnV4?= =?eucgb2312_cn?b?SW5qOE9VS2U0azhBRTRuaHRFVnVwbUgzNE5FTWNRYjdLVW9JbXpNZWdZVUU0cVB1?= =?eucgb2312_cn?b?d213amh5MHpHZ2RHME5VNGV4anNMbFlRclI5cE9kL3FqcWFSRlRIQUpMY01ETGxK?= =?eucgb2312_cn?b?am50VHZnTERFNHQ1c0N1ZytjTmxUTllSbE9BVktSd3VEZVJQSjJaSmxYSjJ6cmJW?= =?eucgb2312_cn?b?NUIrTTFRMVBnSGxxUlc3cnJ1V2tDZTU2Z0VMMkNZK2tWUU42bXJQUnpkWU91L2lY?= =?eucgb2312_cn?b?dnltT0pQUWtORDc5Q2RoakpQRXJ6QnAvTnE0MnNyOVQ4M2Q3VDhhbnY0MmlWalFt?= =?eucgb2312_cn?b?WmFEcUcveEFFMTZhT2cyenpBYmx3TjN4Sk43VXg5RFNyTUtqRVBBRGpwRjVSMG9r?= =?eucgb2312_cn?b?dVd5RDlRNlBxY1VSSzN5RmQ1eUg4MEtNcngvOGxLUjBoQTVmamlDdmlRUzBBQ0ZX?= =?eucgb2312_cn?b?eTVBQjlsMW9BMlpacnBWdVZTK1RnTlRzQ2toRklqVlRGdndvWE5RRm5lZWhQZm9m?= =?eucgb2312_cn?b?d1o5WWhDdTlqQklPQWZUaXR3bHE5aVl5QnNqc0tvTUJJWmRFQjVyN2JXK1BPU0R6?= =?eucgb2312_cn?b?T1k2cTVsWW9CTFp4OUZWL2F2eGRnUHIvUnFpMkhqVGErTC9zUExmdUlXaWZub0o3?= =?eucgb2312_cn?b?Rjd6blMyaVJ0eFhvRzhPcVZwaGttRlAwMHVHQVZhRDVibEhrRVY3VXdCQlUxZkNJ?= =?eucgb2312_cn?b?K3MvbVEzbk1pZEtrQ3Vyeko1SHdiak5rb3hJN0ZVZS94Q1lIcVdUU0lSeCtXL1Jx?= =?eucgb2312_cn?b?a1p2TzBZd1BKYlRUam0vWmlrazBPUEdaZjVWdmo0cW0vZHZmL2RjblUwZHRidVdy?= =?eucgb2312_cn?b?aS9MRXQ5MGRiVytiY0dVZlBsMnpVMlVWNmN3T3VEVnI5T2V2dWE3d2dpRmYyYzF4?= =?eucgb2312_cn?b?TWtUUVZoRm5DTVljZDYrSjlVNG90TDZkdE1wUWFnRG5KQWo3dmZ4Rnd5eDVuRktu?= =?eucgb2312_cn?b?b3Q1ZWxCbVVTai9HQkErNkhmeUN2WkdLcjYvZXJIS0FkR0svR0tOTnovb2lBekVV?= =?eucgb2312_cn?b?cGlZc05wNU1FQnlsamxBVEFuZnVGY3BUSVdxMlVuNCtEU3FwYlBnUGxtSzJZdjhi?= =?eucgb2312_cn?b?aUttd3F5TzJyUHl3Njd0TjVJNG1wZ1E0ZzVQTUIxZVFTL21FUmFvVTloM0htK1hO?= =?eucgb2312_cn?b?cC9VOEY0NWJOMHNhVWhnMm8reHY2VTdST0J1VmRoTzNMNFdvcWZidms3Z3lxdHJq?= =?eucgb2312_cn?b?dUd6T2duK3EvZUp5clFnek9SekVZUVRIOTYvVEs2US90bXhqUlZpRnpTa0E0bkpL?= =?eucgb2312_cn?b?VEY2WURHYWo5dGw3ZWlhU0RUY09SY0hLZU11WmttYUoyUjQxYWM2MDBvQ05vT1JE?= =?eucgb2312_cn?b?T1orQ3lWZUcyT3JweGh5U1ViaGJHcGJFRlViVWtrSnQzYkJPR2VPaFNkNDJ1RkNH?= =?eucgb2312_cn?b?NmluU2hYT3VBZ0drb01MY0FnT1B5REFsL2txRERBaWFuRmMrcThqcDNiaWtJQWpF?= =?eucgb2312_cn?b?Z0FkK05rVy9vTWJyVVBEWStBSS9Zc2p2bGRzR2lwbGtrZGdaRW9ZcWZXdUkwQ29u?= =?eucgb2312_cn?b?VHZBK0NsNlhkQU9tNGFKUWlPMllLUURqMTM3OHNDb0paQU5BcEIzSUlsdm8vaVJZ?= =?eucgb2312_cn?b?WGN4TEZIbE52TFljbEJ0TFZkUlNvMXZ2UHZvc1Jzc1did21RTHRxMllKUlhNd3NX?= =?eucgb2312_cn?b?M0VGb2dkSE1aeE1ML0w4ZGhFNUFKUUUxd2hLV29SUkFXems0cVo2ZFI5SUF1SjV4?= =?eucgb2312_cn?b?bGt5SnFRM2xJMkpMclhXTldrbEsvMGN6UmRWVU1VbSsrSjZhcFluMURGMEhLTlZz?= =?eucgb2312_cn?b?WjdJU3ppMjA0SllzVTNwMk1iR05DVHJ1NW5FNzI2Y3UvWW9SbTZIRTV3Q0ZPclBZ?= =?eucgb2312_cn?b?TjlFQmM5Nm9Jb2ZFdkpvQUhJWlY1bitRbENzbitIQzV1TVpmaXZZZ1dqUG42eA==?= MIME-Version: 1.0 X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08561b11-75d1-4ac7-6168-08db881a2e25 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2023 05:37:02.7540 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0lIE3H1aNbaBF52cfL89KhTRDYoe8P0BptfeLi6S34aZc4qv72pqkV1prozDNXGzP1rHtpF3iRbjT+39gM/GyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5242 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230718_223711_993643_458C1352 X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It is possible that dma_request_chan will return EPROBE_DEFER, which means that dev is not ready yet. In this case, dev_err(dev), there will be no output. This patch fixes the bug. Signed-off-by: Wang Ming --- drivers/spi/spi-bcm2835.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c index 3b253da98c05..cbf025054c96 100644 --- a/drivers/spi/spi-bcm2835.c +++ b/drivers/spi/spi-bcm2835.c @@ -903,15 +903,15 @@ static int bcm2835_dma_init(struct spi_controller *ctlr, struct device *dev, /* get tx/rx dma */ ctlr->dma_tx = dma_request_chan(dev, "tx"); if (IS_ERR(ctlr->dma_tx)) { - dev_err(dev, "no tx-dma configuration found - not using dma mode\n"); - ret = PTR_ERR(ctlr->dma_tx); + ret = dev_err_probe(dev, PTR_ERR(ctlr->dma_tx), + "no tx-dma configuration found - not using dma mode\n"); ctlr->dma_tx = NULL; goto err; } ctlr->dma_rx = dma_request_chan(dev, "rx"); if (IS_ERR(ctlr->dma_rx)) { - dev_err(dev, "no rx-dma configuration found - not using dma mode\n"); - ret = PTR_ERR(ctlr->dma_rx); + ret = dev_err_probe(dev, PTR_ERR(ctlr->dma_rx), + "no rx-dma configuration found - not using dma mode\n"); ctlr->dma_rx = NULL; goto err_release; }