From patchwork Thu Jul 20 09:41:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13320246 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A315CEB64DA for ; Thu, 20 Jul 2023 09:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h9ZBHLYzqzmgzIgTyfzlOyxepkPL8jwScxQRqz8xdIo=; b=VE1PemZ2J7wsSa LDBcpAn6Eqvt3AUezNC9POadFoHO1aIthVToeIp9kwviMikWQiv+1+iTimkx2XQ8uEQ/LM8er1sK3 kAMEAMYqI6LVS9qS9CNOZREjqQ5DsakMhBh5wiJVt124/HUnb5++x65YSXk2tRkoVlRVKEfsityj9 kyR8L2kmgrS630m+LJ9l0LVvHAUfwnY0nifz0Df5KnBHUIXVKpd7TjiJQzz8t3z1b5QTZevP0ptCZ 6yPdMZGvetqqA/HypGVRzR0xZH3VjZ+YNQVkwKmx5HRqdxtQCSIbrVxJv3OUfIIFB9PqOM4lphwel LxN8Qp5xwtEPg5FmHZ/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMQKG-00Ab4q-1n; Thu, 20 Jul 2023 09:52:00 +0000 Received: from mail-am6eur05on20600.outbound.protection.outlook.com ([2a01:111:f400:7e1b::600] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMQK9-00Ab18-0w for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 09:51:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kLEXo2rlAfVhDEDRBp8/4srsWn+jpnPspzo0HHQ3Mqcciq6TqfXKlgBseJuKLB90uX3OOSdUTodaVz4WMC9IjpyZpv6EelzbO1GnxrDo+Bl2eJx86a3SPFVeEBGTef17n34A0jgyjRFsgPRgiOwI3TlrOXj/fEBD42H4iq6ERpTEDel81sCmqW71sIVpumOkGOuAlZvoiG95MfAzvviE6x9CmgqjW19yGwHuG9Gx/KTDDl7Z6q66MJ9oGH9kdZ0E7d4kvqXqnZ1oyvhBq/hzh05z1Q/MPw28Jf+KsCtzyA3A9moSQ3CQCbcgyKfWv92/XB4s4+8Jk0U2PltE4Pk8Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dgTte7GlTSbVWX7opDfOteIt1OFGfyhUTb9YdXOn4kE=; b=hkjLSD8TuZ70sciQ85izd5hUAsy4JO8Py2THzYILltM1frPvjKmNaIgE2R60aGS+XjjxjEXwIWmvmXSLJIFh+ZtxLJxc8dt0HZq258HLgBI+dGD3+1BmrDb1SNrM8c7kyMJyG7O9uAJOA/ipREjz8ZsDvugmup2yU57IFi3lzILgnccEb40WpL0V45wMiiJkvam4sA4ANPoKH+TVjT4DkjiQdEBxIaN9CjrFnkqkIimOO2gBejAdBJM2Q5j671UU1V7vQu8Q8bYGlAgwemtYikqOwF1MHScOXu6EKd/vTNH/KEvGLjfKWx2i/uTFNvPP0ELwYfVxiZ95NntjQals2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dgTte7GlTSbVWX7opDfOteIt1OFGfyhUTb9YdXOn4kE=; b=fECS3D6bdT7hP8OlKj30ygfmS71CeyMfmMN2l7kWsSSWXkcNVB9pGqnZ1/KRaJGIcVRb29QqgrMvK6GOTjUju6ucsEwzL4T534+m6P5271R0eccsM2LVSrzVRDsAY9XFVRtTPkO5C6W+1iafZTkWh1GmxLoFFIyJD9zjSFhdOTs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Thu, 20 Jul 2023 09:36:48 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.024; Thu, 20 Jul 2023 09:36:48 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 1/8] firmware: imx: scu: change init level to subsys_initcall_sync Date: Thu, 20 Jul 2023 17:41:21 +0800 Message-Id: <20230720094128.536388-2-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230720094128.536388-1-peng.fan@oss.nxp.com> References: <20230720094128.536388-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR03CA0110.apcprd03.prod.outlook.com (2603:1096:4:91::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9367:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c61dd1c-ccda-4538-4525-08db8904d707 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sGTlBZ0+hyPsSh0DFGlm/8ebyTozm00UXu1Iypxd/zIKd/aIYMEXnsbDMc9YbOjPgk30x1y0tWO7IP7EhBcRLznXo5bm1FV1+q7ca0Tv7x+j5E9taWaINzBTCKiZtl0kTJuuEDcvBdslcKnSBh/mJr8LOWsw64NUaj/pHE6OmKvkCpPkgCj+PoaLYnKZFkMJOuB2Xtwa9VX4acxz3rzHTBUcgzzqoC55x2T0jVJ/dMVo8YgRY5PGlZXg5cWcOOCsefBWAH7Jl0iZbCOFeO0Eud66iF3dJ/I0OEG7QqPQ64Jd7ZPPUxGMjP/gYubc/Q21uAFQZfIYwWqnm4HthQZX7yWWwx0M+QQEFHC0biFTJD8QhnY3AS/uqC7EhvqcpJ2eFvRAUlDC0NUBGSLzD2fF4h0HeABfZrvDtuEnofxAJ64qxSKUSMCo/y9EiVfqqR+uWrvlzsGGU3PpvGr/lpnH7f2sHrt3VO+V8ZDhlKzkYIXN/1JtxEfek6zi2Nv7YKoW6t5PwW30d/RaAX98wvAbD/zcePpX0uc/bkAbQEguIWjb59YOvmIi7p0SGFFE+udwugWdVhezMfZmiGOidSrPdGfzNSVn8YazyObxU9hSWUq+om3e8e8or3yAV5T9f+9d X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(451199021)(26005)(83380400001)(6506007)(1076003)(316002)(41300700001)(6512007)(186003)(2616005)(478600001)(66476007)(6666004)(52116002)(6486002)(38350700002)(66946007)(66556008)(4326008)(38100700002)(86362001)(8936002)(4744005)(5660300002)(8676002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 6jqPSgsCXgDFnh3mp5VVLerCGMX5Lxbi3H6teX3AtjCY4kTvRgNA1ALX+OW69FMSDggleijuP9rg1iTT/Tn8R7O0KSKYl1o9XkrH1XiP/J6kFJxawDAHZfKv3PwU422jhHMQoCQkJ6yu7aKg4hrEscajMVhtlquIM2KpxgQNyZTWIupoQtP1uIPKfTVMOrj/XQvnNldt1nG9A+4wqASPQkX1czFz1vXfM6Vlc30faj+l+AKCOcUymP0sB/NVFZDlT8lAMHRJI8NSq/zlMX46UPhi9G/+k2hns2qSM2k54tJDOv7JfOP6N9eJX6i1dyLiQSa3IyIBRmFuTfdBgssh3mGirNqmIMWZ+uRva344OlNUGrJBaHnEE5Ilo0vLlG/+j28SN5in5B6qT1Ux15EyUPLm4BT25qnX2PgSftW0W3A8mhWSLQE6cSAQgd3MpKAv48GwxADpLPThYeqB/DUBlx2MKXK/CaDntt9TF/aSS6nyIEORDYMo98uIWheahHqFwJjO6fNIKCl+GMbRx+MBL+jAXeKxNWm6hOkaL+wSZGmJ9iGp/4bNARlgBSjEGVNT0Hi13xa7jPYfjU05dRKS+Ntg6Y9q+6Hhxu5ZsvjUzQaO5Cf0m1tw4p5xyx7ecV+CLKENBC26Sgl5Fyd3GRzf++GX+0aPngB+nWMviLbyQl0Hv7sz9AgZmlOSYScizAyQIu8s92ycUUrJiD/96CyLQmI5ZdymWkj16gaeRXs3C4fPkOVoVJtgO9aAH52JIA8JeDR9sr/HvhHUM0/91HPAHMZ1mw8sjvWkbUrQgzPaTN79ntN8DHs9HM7/c7w+Q0llUgTWZZe5GCr86PeOuShewhK6lWjdQT0BsEJqwg5gxuYZ2fWTsO66cy3Bgl/J5D1Kpyce6Mf9lEdFybAmmgGxgsxwHyAo+iuRc39kBiUMWl+5ISNFbIw+qQUgusk4nTK/uuw6oV9Ia5hjga80aJGVBqUBX1kSRJ+hOX8XkFKWb7yXeBwzjLZ3ouRz+Ft4tZQa9SN93kwLfVpmEmOqaCIoogqbuIBzg7Rv/Mhiq/Mw60jdtH/YqiXT60i78+nmUlTIPzz+NhXAiyAHjP8EG2MUPDakMEVH+cLuPpUkOtUs4PY2B+Ahfhr9zqWEctC3fbDAn+4VTtaYjjsN31satY967u7bHqo3t7bAcjulTCF2//POAOMJoEzZTqR41j7BVJaouY5yjJ/q3yo+ZgIhna3cB9vjpj+v/StZf8sXk/P2Uv3m+au/YsPyuQdE7OQulcx7v6T6byA8CMGr5XhPsPgXyQ9lmbtUWTDByAxlOznihKldhJ1Ah2qs7Iy8AemSSBsf2h8ITRaFIChZzBpc5LwEtk5QNncyGhlYWJzkH1UNG/5jLHvzErf0SjDcTW1iGi71Xv+L1RNSYjaiHfMQhZInQfVLW30lrDfJ4l+Q+Yo8l0K+J2QPcH/arClS7nnnSD4YliGqT176/yor1OOF2en3IK70LVS3vgYbvPKvKdNWS9/2kes58BErODY14WA2RzrP4MWEsVwfWgEV4NQHr6gmPShzFMLvWf/MoxultSOJbBZBV0aFun4sgvktO1avBYAc X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c61dd1c-ccda-4538-4525-08db8904d707 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 09:36:48.6358 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VEvEOlKLOY54GtlqabKTo4sE3vVkwzFbMhhLWedmZK4itfuBgsLO2h6JXEce1Q60Gia0fsAEDM0Sv7RdcTLgBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9367 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_025153_329915_490EBA3C X-CRM114-Status: UNSURE ( 9.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dong Aisheng Change firmware init level to subsys_initcall_sync to ensure it's probed before most devices to avoid unneccessary defer probe. Signed-off-by: Dong Aisheng Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c index 47db49911e7b..2d24359420d8 100644 --- a/drivers/firmware/imx/imx-scu.c +++ b/drivers/firmware/imx/imx-scu.c @@ -353,7 +353,12 @@ static struct platform_driver imx_scu_driver = { }, .probe = imx_scu_probe, }; -builtin_platform_driver(imx_scu_driver); + +static int __init imx_scu_driver_init(void) +{ + return platform_driver_register(&imx_scu_driver); +} +subsys_initcall_sync(imx_scu_driver_init); MODULE_AUTHOR("Dong Aisheng "); MODULE_DESCRIPTION("IMX SCU firmware protocol driver"); From patchwork Thu Jul 20 09:41:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13320247 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D36DEB64DD for ; Thu, 20 Jul 2023 09:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7MkZpC4FAEJ04lt5OIy5u4rZz6liRiQMKijKTdilLlA=; b=nBlIK552bBCfwP 1LWhi4J04bM3Dr+vZcv1TEm1PI9bay8iWT5i6EGhrjd47/5cWl8rEUrADE6dQRBOx1I49Iv//saH6 B+xw3qQ66bUBEsXWm6uYuBYbMth4OkGRUpwZO0WW9k/4hdW4QwTyjcrOmdyKpE+sgWhGAVBUeeW// jXJVC53sm40MGdvCMsyU0aPgozfyoEMMgv9uu9ZV7hfL5c9ZG4b6Pa/7IOrC2nh3lAJg5FqjNS0UK qLfpA48WDqILJXqcVB1cRoNQKElGfBl334Er+C3Bpyb1adVZ2EmE87RHcOh/P04agsLBf/Ad27h3q RGEKeCBaHATay+hUDQWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMQKb-00AbBF-26; Thu, 20 Jul 2023 09:52:21 +0000 Received: from mail-db8eur05on20609.outbound.protection.outlook.com ([2a01:111:f400:7e1a::609] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMQKY-00Ab9m-2i for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 09:52:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fr0xe+Qj02btzyH4KmclFPQWU3hB1N9m9iXaPHWDfgmxcaHUWHnD5nzUTi5KgkRW2ATHWpd7XXKCh+mBfbjPGOAgDyJJ98IeJXWatMQ/g1GsCExZQ/rtDOW9gD/4OVB0jZB2zTOkZcsJMmPCBIll536F4YN44hYzWwbOM4MnIuC4KxfCBfNf0T/eEh+BrQGhyXCH0uPeYGXmBvLThzig86xhLZzNi7yHHaxULbn5FsI/sedlpNViukvl1cHntEg9TfXj8Bk/YZYRFPGJnAsfoZF5zD1nE+QPCYWv4unctWp20ORq3UdJbGaQ6HQbIkRqfLi47DpMN7mTrp4nry9tdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DF948BRl8NffqmzXY2ZKiRJwHdKM7ujns57fiU8YtXw=; b=je1sbruIwgLGCXV1skM3O3hhSJsr3Er8fmdm70BiW/LkjSu/HWXL2wT9YkaYOdl1qMzUaoHfz+jnqX5A5P7cKxgf6JwZEH4uiTbgIlsKZZPVE/a1woV3uh5g4wlrwzFJhLFswGe7d/94oUu3mdO+faQVXy6QhhC4FL9KV83iE2iMY646Ro4daGGrbRUclnLSIlg6q41xoiK6JSVsEu4Zf83ceAtA72Ml0MiN2GsecUwUjax5fZpy838u08m2SHElb2J1M6tsWKAYU3MabVpqSiI0EzWMYN4Kek+0jFQ7xjNhxv1wiRcptaaqqlvBAs586DXa+SP1cMSqIGTisFjbeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DF948BRl8NffqmzXY2ZKiRJwHdKM7ujns57fiU8YtXw=; b=GIgtKS7BRjWqg9Z0ZNIlPm96MGUCNDfC9xUG46KgqdXf4Jx1f7Vcml+8M+/eY3rAdXY34FQwQd/DGPQn+rdE69tOh0x9UUCR9+oZUo0B87i6qAI39SSoLa7ttJM9VYeZ5CjNuq+pYwoqmO3P2Y2UaTEts3ke9dYGY2KEHjTdibU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Thu, 20 Jul 2023 09:36:52 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.024; Thu, 20 Jul 2023 09:36:52 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 2/8] firmware: imx: scu: increase RPC timeout Date: Thu, 20 Jul 2023 17:41:22 +0800 Message-Id: <20230720094128.536388-3-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230720094128.536388-1-peng.fan@oss.nxp.com> References: <20230720094128.536388-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR03CA0110.apcprd03.prod.outlook.com (2603:1096:4:91::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9367:EE_ X-MS-Office365-Filtering-Correlation-Id: 66b62922-7912-4082-50ae-08db8904d911 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 21YCztD04QcZndJJsDGBvr/bCiRp2qPvL8hjmECGIvV/fHx+MqXvyHU/Knd/G3n1MBBGMqs7moshOAABHQhS/f6ajFgLsnCioOdc+jUVReGpHfrskKIQH1KYvAcyPnrSGzPpc0rzdzPPQeUngHx//+lvbMtC9URMV78zoZ8vtzQbElL2vUG4Gsl5BmEl2x4/mgY67eEJ4K9MOf3BWQZQjQc+wKVp2i+3skDZHqGNgVDTB3ddq0xL/vvShg3Ly2JxWBa1yjGe66PXxeEIfeVIYKZdHjV91nl4Nb2lbEZIlObuI+GiSi0liBrQFidGAoMt1u0sUWB0x030kDPZqxV9tvfPxttFQYaZFNfH6RK0sw9rKZa2miUEKeSldQju5J2UvZ+sYr1cqC3kKxz6GE542O2xSQ1RUOA+BxyRZY5qTg94fwjeLSm87jnXMD9W/iDuIaUZ1myyajeB3cjr6OeH1N+MsqxzqD6wnYeDwPhkHO4K3B/DVBH01hMJ7DcDEx8s5iNgBiHdaLVCbaBkluq3ejFL0RCI/uq92X6jM5gCuZpOEFl/mJ3owIfw5lZlQauYBgS4n47cHBmrz09HkExfMMYZ8pUKL9jZJRMrBDDiEcyebuJwvXV6+/dbDjRYC4xP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(451199021)(26005)(83380400001)(6506007)(1076003)(316002)(41300700001)(6512007)(186003)(2616005)(478600001)(66476007)(6666004)(52116002)(6486002)(38350700002)(66946007)(66556008)(4326008)(38100700002)(86362001)(8936002)(4744005)(5660300002)(8676002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OKWBO3cwHnUyUWSw7a/DQ1ehUKblv/ZXgeydElPzqz26LlpyeJf2qXjq49oURiyO8vryZk4/f4i5ShDKrYLKOaLYbLkQbrh7g3u1pWs975rFvyyy3F1m+a/C5md9Atm+/lkD/p+o/NB89oxcfqxwj4fZ1/GO8+A/SzyhaFN59dhR0B1iOm8xlFlf8/fqfPVpeMFPwmKvYgdFzcM2wrZ98YSlglyPSlPqdfY2U7YUF8+qq06bKAfcaMPfunK0ZnDYJpnR+l58uejVLSfM82bB6BTgl4Ihxtsy4Adg5ST0Kd6Dwcv7n22tRWHA7bfLKL3shWUNyWxwqeZ/sGkyOfXGVRa47HRDCYqBXNEbbyWjH0JFtddvmZzGc0NSl9z55U6ovRNjNTt8BcHYGb6wss2IW4M0BxadTug75SbsDbO1cHb42YdFXb4Get8cbqYRr7RjrQvV0oGNCHoFSaA9ymEJYRhUEOM3mbx+7TDHAg7NBoiHeyi8pQ6S96QHyqs/ufO3vWHipsQM78dncLwan7gxj1nIV8WFGKYtuNy8vFX+99lb8rqBQaGSAg5xp4x+0QUrp71TRuIZC0/uraG4Gmy57Z4FLt4kApAX5MviN6Y99im3eWlaSmTo+8Lofgp1M97WQz4OkrsSElo9r0uU/+bLuEJ8jb1tVUmhG4HJkAv/VstHd0iZbtfAqDB3t0iX4pbj91gMGINk4bg9DWLvrp3w1XehYc044UzFEuwpqVyTuamNiS4m67eXIUgJda71qKDCWwS3n3Z18MFl8jX0USbvSlr0PkNRHVnPgc9IkCwjBEqKyFFZ5mlhGEuquyin3XDPdgLEVLd+pi3+ByV4e1OB0tLCArl+37vla8QPNs/CtuCs02fCC77vfYMm01QyLWKTm6YYvo0krkOPbYSxke/vuJq1xYfEoFVbIdl3+Ej0k2jJak6FYLrx8pGRkZckMmeSXfpexcoC/RMURA0y9PVFFZTkU8AXP1497sUAO/RlsQ3BJ3Ht41ZAz4u42XHY1HRNy56Uw+whrveto4eoZzyWByVjBzl9e7bTylcCXD5FcTe+egQwYymj8Qc8oOVESxGLUFI9k/kBu/Iio+GcrzRACOKCUaamf1udCfIl+/esHUNzUEGcuPj2FROWQi4XgwCjZTyFpM9UL9g2z8/54bcXShnH2o34hJ9FQWz2tmMcvhjKshxCKftK8TF65hzKEBs0IXbslyI82v6RJ+JvlYmDCI+75eEfPZ7Z/yPmke+57b5MCzUsvnJTzTq+f00h1Ap6k40cqiUOFCmTOG9eBgSKDaTpY+HC+ujdhH7nj+mqNbqxGaMYy7PiW1JRopZN/4XAkyvhDsROLar6QYKMa4Rh/7t1L8GnPM3UbKMbPcuWR027l6BWDgSbH8p6rWgrmcJ4Cw0cVn9seS1C62QrVfYXW82vRHrVO8PTFkdkBiIh/fB6o4nZvqV3oI1RumCw0b6Oh7vJspch89A2ts0+Ouo1QYpd+jJouAD0/3Zs9wim7zD/Kbz4qNWctaDDDBV3/ROKOH6JgnFuoN2SuZsQWzyRmIBaEsmXPuYWxo/qErznTdmx8mSfnc8Q7t+/uQeJTcBX X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66b62922-7912-4082-50ae-08db8904d911 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 09:36:52.0762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n9hyoGA4e7N1dcQ9nxTHgOEVGG4RP71fme+FU1NsCAb3VgTTxIs57WTMgEQvHrDzGQPX7fTiFsGFi9ZfaQRsFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9367 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_025218_888766_FA90C720 X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dong Aisheng When system loading is high, we can met some command timeout issue occasionaly, so increase the timeout to a more safe value. Signed-off-by: Dong Aisheng Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c index 2d24359420d8..14ff9d3504bf 100644 --- a/drivers/firmware/imx/imx-scu.c +++ b/drivers/firmware/imx/imx-scu.c @@ -20,7 +20,7 @@ #include #define SCU_MU_CHAN_NUM 8 -#define MAX_RX_TIMEOUT (msecs_to_jiffies(30)) +#define MAX_RX_TIMEOUT (msecs_to_jiffies(3000)) struct imx_sc_chan { struct imx_sc_ipc *sc_ipc; From patchwork Thu Jul 20 09:41:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13320245 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EEEEEB64DA for ; Thu, 20 Jul 2023 09:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+dP5ajb0adLYrT2S9IDaoipRqnP2onrNiUg6nWF5kCs=; b=2xHO8vAr3hRHsd n4/5vrnT6N+5E+6wHL+J3zNBWqA2iNH3wnNCnkWmfb4Rw+6hRkrhD6PUMdnHkSdFCGiRLAhQKNpgQ OxHSnLB6leZnHvrMwBQMVZdBdpvZ7BUDR9RaFZerK7OBeqbvj9zbjV00lGIO/fxLQ63BuuvYQ/bSw g5OGrkkI6V77ZUPjRTchkydNpN/g1UKJeSCOTyjd9ecjkP+RrpLyjE0q5Fg7Y9dWyu9EVVvA0YavH Ti1NBYNZ501mm9GL4XaPa8nVMYjor5FkrXO9ZGy4ppscoI+XkmmnsJGQHFAAkml5/mJqr5kFr0yee z3A3NphNXZqKRH3/nHkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMQK9-00Ab3Q-30; Thu, 20 Jul 2023 09:51:53 +0000 Received: from mail-am6eur05on20600.outbound.protection.outlook.com ([2a01:111:f400:7e1b::600] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMQK7-00Ab18-1m for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 09:51:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TY/pFGWPci5UFTYxovm/UXete/SIkeyRi71mo8ml/KO74zodatWfYgFNsr8zt6Sw5FEqD8dAW66S1VeppZUpfOAi1daPSFI/IceVO4Gbhc0NJpEDfaWpaSpo8Ovlu24cXsPKXX0SCJGPORTKmxoS2hPKYKvdQsYMijikwhHWK1xu7LWusCAFY6wgKONE45/vXxRwQDzlZdi1UuATAPcWqsgf859KBdcEOBBj6o9eIAINFzUk/PzLIomSFhx84b6FnA2BaXNJAfNoKxap9n8ERQGvFjQYmEEx0Hsx+uTn/bag+mKX5ubRZFTcEI54B1RiX86n0R/W98D9oCMzwMlO/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I1EaanuMVw3yN21IXzDoO2thxcz5R4f6468cftBXaho=; b=ll+MJ7XzoJla4hZbMs6oOiJe7AwqFQFRpVPlaQeZO9WhN7xJQnAICHahGEz1bdKY5Pd+QNR1PWCxw2WJblDSt2YJWJyTYfhGsrKWVd61lImQWwY9mqkHscewzq+twHW2qg1JYNfzp3POai2OA90WVdxd83jc8q/zjGoHtsDdByda279t+0ukqWKmvLnL5Q87C64IwihGpp5qqbkswk5b83KLN+nXhMV4za3NroiwMtIk4mzcRGS5ju9VYsm31aip1KAHRtWJEOWZ/QB3cuzbjBLhpM6w17aJFnWALgfqvuk2BuBrAUm9sA3qdFpbNNJoh82DQr5shT8qZJSyMZaeKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I1EaanuMVw3yN21IXzDoO2thxcz5R4f6468cftBXaho=; b=N1/qKbLgg5z6wTRxCSwxwXGj5Oku3JWU9w0+4kCtWkYjmni31G9zalt0dTnT7Mu4+2sYWkfRyIugjrwIyYmGPAgplHOjUbefpGUV3NC8Y7hIj2dasbo5NDF1AKidHk0b6q/PRsu+/CGj902QeNEQ4J699OZGIUjMhbwafntLbkM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Thu, 20 Jul 2023 09:36:55 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.024; Thu, 20 Jul 2023 09:36:55 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 3/8] firmware: imx: scu: drop return value check Date: Thu, 20 Jul 2023 17:41:23 +0800 Message-Id: <20230720094128.536388-4-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230720094128.536388-1-peng.fan@oss.nxp.com> References: <20230720094128.536388-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR03CA0110.apcprd03.prod.outlook.com (2603:1096:4:91::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9367:EE_ X-MS-Office365-Filtering-Correlation-Id: b70c46eb-867c-4933-20ac-08db8904db20 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9Y5767zb8P6yZvh00S05W7ustE9Ua6tyCVInvq/vnrsZ+J/ksae/NS38vyJzmrNUFsiFRZyAnAjQ81MaHI1S26lhGaxV0ZfTxsuCFuJar/nVY3kszFc+yhRAs2ZgQD2L8oXp78Qt2GJ+Yjr1YIRqSk+BoHy/cqvpgpdPvHQV0bkUpWbzVmK7r9kkQ8QxTrXwiSCkpirvDRkRiGv0L44x1Ti5SstGbcjrDzGpUzSFa0pHkib43FmIpdKVdlh6UrS0gqHUWcW1O1xdVUVAq8Pgo6pnw3/aTDKpfxGGE+wvFBO3jwDiGq5LM/SxxwysUUmSYBwPHmrR9ahlHKgdtMFiZpX8PhHBqB618ol3nuSiOI2tTA+AZRN+06a8ae4TeIrcat+b9eRT7F0rXjGaryEkjQO5yLORZBvGZGo36XJzeH3XJhSVcR6d4wdxHsZ3AK63pAoD5SGwNkCTHihrSLLShgs7GafqyMmSWziBYy6EiOQzjugj19dzLKaMGxgyiW+FWHpzeCAXcN+DffhN1lWCZAV+oifBUVu1115w2UyaTrZTp3Q+DIlXHR8osQi+Bog2g1hnvWtjympNSNoBTGwVFuIiyCDc8jEUeM67iPIG4zdPQzS2grtuhxkVekfFd2Eg X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(451199021)(26005)(83380400001)(6506007)(1076003)(316002)(41300700001)(6512007)(186003)(2616005)(478600001)(66476007)(6666004)(52116002)(6486002)(38350700002)(66946007)(66556008)(4326008)(38100700002)(86362001)(8936002)(5660300002)(8676002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: niJoTVWaNuVmqIgDsbilQAvAG2Un3uU3wfoa0HD7jG/45tozxL9TxndSczlyzkyVLDe1OdFljb3FptFdn20VoUdcbbEfkB+Q+v3vcE3LRwuimd7w3GfgI1nkWyjhVpDzR9up94qvA7k1bu4l0X7DrzlLUT/GJJnSYx60puAbdgZTWUkp5f+atC/Gr5BDKoEP97J7cIsv+DX8dJ+V3DgeWnzazY7Gemvb4hHowm421Uc2nBmQPmnUW04A6bz0QWuZqUANsM800mnajZ/MM7AOmcYlDHVoCzeBW6QIbR3D/ZmKZSmFgynNdSszMqTveP1KuZ5ARqqtYL1GxO8OHJ4ixt3DdjaYpI8vK6KBD3YsJQVnBIAKU52IwwSC+P2WQ3hBEgyQadJmVBe1t0hKv+Mywl+tfffTAYxv83HTatYF0UZVQgGbVmoh1hcu7/4vAjGCObdWO/OsywEDAhmMj3pvFA3K9e829SPzDAUkgKjZOLQ5sJHdA21WLH7abOd1Yt8f8Wtiw3jDYzbxOwVaLWBNxQje/XdtJGaF4r/yegdgogr/20zfBIBpmG4cHR4q2OibTtmI2Fm84Jt5SGWM781t7OebSVOS4FOe9crY5klCquM4clA5qkEYPhOqL10sW4Bne5tukdhpEdjK29qRToMdv/Z7azliQBIciGZlg//tqlF3zutLqjFWVdLfO8GhHb3XknRuoeJZLsQ+M+4ADgpHdi4nM6IGEnegcB+xOpajELgTQZ6P3kxIXW5wkSbYB5bQgUJYkKlRnKXm1WFp6aCyVLZwvGQHCHZTZVSgLAn4Lim7TrGHzDKIQP6gJVjtuDgj4n1KPlwSnajPXM16E4XwFKfwDVvsgpo69ZT7o3zNq4HLl63uCEKovUG2n7WX5ywp9tvhcFlediBZ+01uL1kxcnP7NXyPIvWkPoFeZFXrSwDzKlRq7wSO6PSXAHA7IB+uBE95R92KrGiYOFIbrvijYuQuZNC6zy10CSN8uSx2+jF0iR77eHD2nWzlFlEmpAo0GgIQoXXucWN+1b/0dkXdVR+6LmXfMkL2NIYAqYSlEx9/0N03nuoBbaY2i1CqmzOGiFGcdjXjpTMnwHNKo66WTdlHjKfyFg0rOL+NDiuMOMOYyHAIMHtkM4AfDNlHRp7JckgG5EPY4412pL5iHSFJCGHFjej3Aks7sLVBYf32iG4CJEP+w99ZO19tDjmNB7tXjQKv1MpaYUxhKvDJPmSMrAl/CanlmCInNG6mvd0PwkWO14r+6s7Ml7rjuIcoDyB7lJH/Syil5pbvtgpW57KcyoYQnIiEzvJkc1RR+i0Knw17nxv0CpqZ3K6LFk+3EBhUvkkvJ71Wl8PNHUIAkeAZd5t/JhsWN6rd1YmTi4akFsWAq3V53alSgZh93WPMrA8JhIw/lCdZOX04wbkIWzdp07M/X0SbYzO0QwG6rpxOuHNoh7Y5Y40PvuOAw9R4KIV08SFffG75/drGO2ucp1opYvz1Z2LCcDPlUk1IYezTh1wvz6eadvXjHUlEY8+Bi80PZpMWe4r0uBNZGyM3gVwW3EwzXhWdFzApiD1u5tzl6blPJfBJDr6EgYmgWUrFkh6h X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b70c46eb-867c-4933-20ac-08db8904db20 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 09:36:55.5028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gzY3NDG6Givv+RtVNQe1FeEGfs7LvQQXQu8dQK8ULVtB/sMxg7LQ4EfiyaSDg2jyIKGf2PHPs/IIPSce/JCRzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9367 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_025151_597305_09A20011 X-CRM114-Status: GOOD ( 10.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan For IMX_SC_MISC_FUNC_UNIQUE_ID, the scfw has a return value, and the imx-scu always return 0. So drop the return value check. BTW, also initialize msg to 0. Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-soc.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/imx/imx-scu-soc.c b/drivers/firmware/imx/imx-scu-soc.c index 2f32353de2c9..ef9103987e76 100644 --- a/drivers/firmware/imx/imx-scu-soc.c +++ b/drivers/firmware/imx/imx-scu-soc.c @@ -33,20 +33,15 @@ struct imx_sc_msg_misc_get_soc_uid { static int imx_scu_soc_uid(u64 *soc_uid) { - struct imx_sc_msg_misc_get_soc_uid msg; + struct imx_sc_msg_misc_get_soc_uid msg = { 0 }; struct imx_sc_rpc_msg *hdr = &msg.hdr; - int ret; hdr->ver = IMX_SC_RPC_VERSION; hdr->svc = IMX_SC_RPC_SVC_MISC; hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID; hdr->size = 1; - ret = imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true); - if (ret) { - pr_err("%s: get soc uid failed, ret %d\n", __func__, ret); - return ret; - } + imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true); *soc_uid = msg.uid_high; *soc_uid <<= 32; From patchwork Thu Jul 20 09:41:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13320249 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B114BEB64DA for ; Thu, 20 Jul 2023 09:52:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Npzami+3u5kJx2Al+uEJoeVfmoDINszgQP7+B31GIXU=; b=N0TS6Ndhog1VfK oCMz4WGHdhDBw1eJNOmn/apNiXYVUkS7Kdxpy1talbcQjv5pxlhM4qcqOEz9aKRipEGCetuiAPfKx Vuf8fFoHx0AEg2DYt124Ft43kTgFxC/GLBvI5dB5z5vZoi8fEfoDNnZ1WhsZL+TcKOeiLxCO3PF3F Ns6sglFUtR7nGW7f7S652gSP7ZyBcPuDyc6weslHXQzSOY9zWa7X70PzWqGkvjBmy2X9DPuoImahW iuhfrV3hCa/8vkcy15IsMAGoZGAQdv59UY/qhne7hdGLZ++RLxwfGEI0DQz+PXNX4vxL80e/M/BSk bYzJPZFsPjiUxj7RdWrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMQKn-00AbFd-1q; Thu, 20 Jul 2023 09:52:33 +0000 Received: from mail-ve1eur01on0615.outbound.protection.outlook.com ([2a01:111:f400:fe1f::615] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMQKj-00AbDH-0b for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 09:52:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVT29MBdrAeZS1D1RLphqLQwRGgwwMVi/RmEGCHm68SYKvHTQRUczb51j2ofk3cSpTl5mZKFdV2Jm2+SsU1pkyXpGWqWBhb//8lAGPuRzokTsgRfyxsnBaRYF7t9Q337WE8uVNK9Vx11YDp7grOBB/EABTUL9g8B46bmvMBAomx80bvtystSvwkFeL0lqu6sfLTKIIt7/m8Z2bGgjStp9gKhmdjK7w1mQkTTutFN2yyzR1FtBPfJeKgmT+C2Mb1+IpZbNzoTOrlggpL5i5rW49ZkxodL9RgUDtUjwmlYWaKBA5gsdf2vWugQvGoIaJuuMXKELV4IZubpjCrG+nCD9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oI4tLjdGvrvpQt5r0xaIf/zZnKlkwUrXvNkzmXrngp8=; b=SJ94VND7Cq775JJPh7V3O7DDo+z0XNQdSF3K68c8RBCwIMYusK5x76FQ93GqEocb8LaqEb2B4opWIjBYtk6g6whEI9lCJIbiKop3xC73Tv2qYUNmlAwloxXO5dvpemewHk3/UdaxCgfh0sn/OlNAfirBSiddC83EelPZblgfxY+k9o6Sf5grB35rQac4bGjpid+/ud/hClUuZfrsTSQ1HYwFP4w9c+wdcdM4pLlDKfUqJwftMWaB5qJy04Sb7qXk5uP5fks8tqes1XaE6raqJG3DXRU5m6P232BSDBBAtvwusxUGy8QS0JnmhsRQbn0tttwpzhRWEQDtPDflsucCZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oI4tLjdGvrvpQt5r0xaIf/zZnKlkwUrXvNkzmXrngp8=; b=j6kMinNTRomikpVSSDfBVjq8/Glp9MZao/FMDPA1jVjqMXe2tva9HKH5RMVIo78s9eN7xJKSuD70utcReInn6vmUoI616135C6C/7vrXkfFKKJwYILXBkouMG6JLcsTvqeAmWEilkGIGEop1Ogdjj/e8QgafTyWkzAskl3REdTA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Thu, 20 Jul 2023 09:36:59 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.024; Thu, 20 Jul 2023 09:36:59 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 4/8] firmware: imx: scu: use soc name for soc_id Date: Thu, 20 Jul 2023 17:41:24 +0800 Message-Id: <20230720094128.536388-5-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230720094128.536388-1-peng.fan@oss.nxp.com> References: <20230720094128.536388-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR03CA0110.apcprd03.prod.outlook.com (2603:1096:4:91::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9367:EE_ X-MS-Office365-Filtering-Correlation-Id: ed0247ef-5c0c-4484-ca05-08db8904dd27 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zWvp04fyUcUZFBSOzY5W6JoEUB2rfDc4+Os2FLeWKoMEeoUNTo6LWvwhAh8ir7GAZF/S9rxBcsQ/WYf6j6MClxjFsjjRnRJJw/VQtB7unXf6y2UigR0IchcHcDScaqwtxNmPBTP3Wm5nHC2dmW8/oR2Yj3lYabZfzAtF5WyK+/4z1Wu/9Nlhc3VAyTOECvhCD56IH9XW4nKhbGZawqgPBCrouLH4f9TrSoQahST/afhB+e8YI7jJx8rMraSBxjr8LQnxL/qDkgf7tDezCureoObycXWZBdKAclEv3beJZXuoJKu3FnmC5bigefgxchg3GbRMIaSX+stH2tl5fGFPUvOEpOEAiK3ptqybQtXlVo0bt96rFT+mvGqRKEvhXZO7d0UOiEVtLmjpEFypvYPphKcJFp8FDBNXmASg7QTcd8bMNPRrcZ+dth/hpPUAIBthuvzaOHsGf6kDM7oE7v6L309JqhtaXF4eXEUtMRx1HVtiQZCZBk61fQEa7qyAD7WGTPp/Vtjtr1/UyMivBzSETL/eb7mqwdqoHdymbD59fTLpebhiqGw/BtkKONZJ3Af5HMQ1nNYdt2MBs4C2hBlIh1i+x4vNKtYG+YpjJP+yvjiL4vZFioerFFyeJdBYawSM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(451199021)(26005)(83380400001)(6506007)(1076003)(316002)(41300700001)(6512007)(186003)(2616005)(478600001)(66476007)(6666004)(52116002)(6486002)(38350700002)(66946007)(66556008)(4326008)(38100700002)(86362001)(8936002)(5660300002)(8676002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: i4WfVb5CBZueyptXLk+B8PrExQBZ5iSjxj+5aoH+stWewvVpgZQwjkPTkSzTl1tlAuaiKAqPF3iO/aBCrNb9pKK3VP/7G8/OrMKvUImaYYmHC2QRAgwJHr+kLgXKqpaMCDzYivYwe9JOcFehvFfB2efwZZu6oAb2WCC/3B2bCk1N4p7nhQs/iuxysizSeMH41sHNUialZww0Z/VL/zeJjl+OHfdRr66vyjqCvfArTZt75feCR0m4B6iIQ9PcWkja0gJ9wXWQtlHZpSy4xgLM9D/3x8cNYU18ctxdJfLaX+w+EarVDl5QFalcQjQ1xS88NjCIDES4mOTB6Uqx+6FqIE4cYxhxweNXlZHupfN1QdXohR1dv+I5PmG5uGWgieQD2gCfDNGcXoIaCULkY3LOOmIXDo76QUBSkVxU4jISn1vTdt8hScmIU1YI7aC1Ff4JYzhmoYTa2nNOqM/P54MiommAr1CRBQCPFBkcMTv9ZzZz7kKvkXO4rA6HAX/3CS42XFHjErxfWpwuP1+cNQ0SnwXh9jS7snw92Os0hgnAxN5hhsCUKs0l3PD8Il64ZnwqrtEq5MiW/aSEJIhE19vP+GWzQZZuEZaZaHrUtAkCNQlTuiisvGQt9VV32W7HiEdTDK2YrInw7W5BppwDuIinsJdstJEKnHyN7Gg1bt9Nk6N7agSdgVuyys9laaz6Fo6FlOaqWfZ+MgmFvRBXEm+8Y1UBSuAr5DmLCsLtarF1IVa9aaHTPSw61xst/kl+Q9/z2Qmwy5vvCoRrrp8MkzgYJLVQbZHyrAD8v9H9QJ1JczZjhXHrZbo6mXCYLD6AgDsKGWhIceGwQKWJjAbUgCIYNnMwOpYoGTkweURVTn5hNzsPGHKy9FO3mlFL0IQ4/t1pNzzcavk3oR6KpYV/JLQjspbqVNKjpARUZyIMWsHcTJtgzn4n/NBP4hMB/k07XRgzP65zlhC/cBsewyE/1iGipp2hSuVXgIJjJQccRosBCgwSOkYPniwC2H/esXZkJtTU8FahTfdD0hmTI+2n2FnZ5Eu617eXMPmutcX/BAPUdSnCq7j5FpwhgC2G0yiHKSwzYkLv4U8en3f8YROXP2SSEBKNt91wxJG4XAqI770Ga7XCkORv0U3NabBhERaw7EYqHPvq2kFzwMXNU/2ITT2M4Z+RDOc0iekewuhcpzPIEpho1ItfdV7WpFGXtvnxRn11X4CMrl1BDyD2WOZUC17HwEIbNPPcj8hfBSv12s/guL3Y68qHKXFRVzhOrYsKp+WAuXSsPUg/1w5sDzI1ZrSfUN4EO+f1IQpi20Bp0SzPnDnyO6zB5s7wrgtj4TPV9myrBi6JnGfrgiSeBg0Ut/g5zrxpTKv3SEz7btClliSrB/6hGZpvmryud85XkSLuMWSlKDav/rz5akgUV8ZGZcNzNcOC7zVsut2Wo83TJzvGn8kOWVL4o52bxywtz3kDvw4HiL8+Dwfy/kFODhO1RMWcjMi30r7gvQ3QyrIr9YjAhx+qA83/QyzUBHQoZtpW49/26PXMmKF12BEqh3fTfCGN4iG4Wu+4gS2exzO+5tyD9Ej74PtAUb31rU0iW76eoE9y X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed0247ef-5c0c-4484-ca05-08db8904dd27 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 09:36:58.9414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h5vbHcAWw8pfkW/hJ9Y+BSioWKLOhJj6R0lExBXtrCDYKRmjRLKAbt+NwLSCNiYrrrtjpGNCnbjyi3ipeqMr2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9367 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_025229_228110_1FCC474D X-CRM114-Status: UNSURE ( 9.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Same as soc-imx8m and soc-imx driver, use soc name for soc_id Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-soc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/imx/imx-scu-soc.c b/drivers/firmware/imx/imx-scu-soc.c index ef9103987e76..cb8377670a7d 100644 --- a/drivers/firmware/imx/imx-scu-soc.c +++ b/drivers/firmware/imx/imx-scu-soc.c @@ -107,10 +107,12 @@ int imx_scu_soc_init(struct device *dev) return -EINVAL; /* format soc_id value passed from SCU firmware */ - val = id & 0x1f; - soc_dev_attr->soc_id = devm_kasprintf(dev, GFP_KERNEL, "0x%x", val); - if (!soc_dev_attr->soc_id) - return -ENOMEM; + if (of_machine_is_compatible("fsl,imx8qm")) + soc_dev_attr->soc_id = "i.MX8QM"; + else if (of_machine_is_compatible("fsl,imx8qxp")) + soc_dev_attr->soc_id = "i.MX8QXP"; + else if (of_machine_is_compatible("fsl,imx8dxl")) + soc_dev_attr->soc_id = "i.MX8DXL"; /* format revision value passed from SCU firmware */ val = (id >> 5) & 0xf; From patchwork Thu Jul 20 09:41:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13320248 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1D28EB64DA for ; Thu, 20 Jul 2023 09:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y1v3tR6nqJzT1TlcythlxQwqICt/LeURBH6aCuhil3M=; b=iLNfHMLQKwhg8z rzg/YLN4PwZhRRu35WZQqlEAs+pJdZ/dnCXtCr+XgGzFPBrVw56LULFazvs3+2CsEYnIOurWN91Py l1mruBLd5wr4BOArsel+1ofDFEgIUZaqTnBy+tUa4VkJljpjnfoOrIrprD8odmvXogf+1uMZjHTL5 xxDoZwAlrtWGjcDBKDGjFSHgNqC3H3ixrxG1zPybvBETkYDdNxLL5rFhasIRe2/FBIynulC9VzoJG AxK1kiKHVMIrxNhUmaBTnK1aW+UwnKfmQODYPosPe4GRX0t/5Eric77N1o8zjXP4cPDkurUOEyaak uc+6g24WI0lxMlu522Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMQKh-00AbDR-2y; Thu, 20 Jul 2023 09:52:27 +0000 Received: from mail-db8eur05on20609.outbound.protection.outlook.com ([2a01:111:f400:7e1a::609] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMQKa-00Ab9m-11 for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 09:52:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lO6OxfoWDgToZkniyuwpms22kMAnLgW0Z9nttDLDcd90F7xpk+fzDp0Doy/lhhw1kLvz5OZ/a2dKhJxfnybu/gNvi1hygv1vm4zgj0aK7WRrREU2tMawaco3En+vN9d4qVMVutHJmbHRIcIJ0GG2N1UPvLwiYbsIz5vFfFndCBrKWX16UsvxR83s+Gp4YsqZfXq2ntv3B2XguA4N7CrX8BsoNrV/ILuFjM1d5IQGboxe4nBCi/1pKamJnUkz+fq89Kw4DNb6AzLN1Z139rzhyrQm7nOLp8KmeOCT6dtHxRJ+M5NGgaEey9BtUCyrRT4Xjv49ZEPr4Acn5qI2tS69dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=umI6ZrQ15cKelsFX67lK86cAvVI5zNZJ2V7Gcc2eaAA=; b=hU6bx3NpYnjgApc9KEtcLL6D0yw4r+tOPDdK0CCh+jZzuVeTprE2qAwv5bRlUjegCPGZzPVobD5FjCvCLEXtwHIBsiSuwvbVDz4n8EFnrNgpttoWGA0hjU385PZAlcgacrop3dnqnUOFv2eFI/pnINm64rSgdh/I7Tn11vFDovG3+O+T90SR9W2QoMF3bl5n/XFaBR6qlhRRM6IvWSJXHrR2/jeGozYgdozd9HU4fh2U4krcdd6R/FsVZMQDbbGt1M5rhZM1NC1DyxYE+946MBWbBrWt30SpLMU8KWjax5NjkntqAjH0FyWe7+m91nEsFpTB7vjxEb/TCGkezmeheA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=umI6ZrQ15cKelsFX67lK86cAvVI5zNZJ2V7Gcc2eaAA=; b=O9F+xHZglmF2WAiRPP7TkGFkBAsBW4B4SNRyUO3vKFXxsZc8je8cCpx1Rd21C7uAq3xzbUKizRgrjGURlr2uva1LO0zoz+6lwXOdtvxiO+MFhiBYBDa568tP1aQVw8WAbnZhFA1lNcsjR6ENG5oYZanGRo9w+HwX491IWdf93Jw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Thu, 20 Jul 2023 09:37:02 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.024; Thu, 20 Jul 2023 09:37:02 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robin Gong , Peng Fan Subject: [PATCH 5/8] firmware: imx: scu-irq: fix RCU complains after M4 partition reset Date: Thu, 20 Jul 2023 17:41:25 +0800 Message-Id: <20230720094128.536388-6-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230720094128.536388-1-peng.fan@oss.nxp.com> References: <20230720094128.536388-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR03CA0110.apcprd03.prod.outlook.com (2603:1096:4:91::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9367:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a7a0347-bdbe-47e6-5bc3-08db8904df5a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +8JEoG7BM0xzInG0xQaDzPJPkz1/KHvRvidsqSDxIte8+sRVob/PfEJcF1thxq4Z81BhQSPHG9n1P34mBjEybN+smk/MUUHSGbIDXdOHdoc6S+x5QydNRiD9EIq69xoriXg8/gz6ZdaD6IjyoHTmuigBqMh4zeBKsPNgYKhyQkqrdRDZuxFTejyTOoXZeYrBZ9+KUMzV0Ml0CMdC7PNRn9evIUYcOm/Onv2Q6ERb9AWX4p2TQ02V0f4xxbEKy834R8rlIavOhzjnoCQYvdHcA+vnGPJu2tFkHCkkMtBOFwELPzX8n7H/X2BG2SUUEb/ls/gg8hQctNFJw6JIyPiwjiBZvhvkX9r2Jv0iY5A9DI9fT/3227Sug1iFJ8zRuQRrPjVo+kfZgHSalxCFxunQnuTrduQJ01wnLNBku4L8eKSYm7rLHlDu08lxaqY2g3abI/yr9z2T7x0nD67q21nc7OECzybCbdtdvaEP2WSr7P3snryWFW6jKZ+alOny0XGvQEHfP21tKyQTbn70lklVpDgYlwX7MTE8mnydacTLuQG4GI0zjL0I5PN4Qq4nx0D3XzqaSD6flgDVYVsnQCG+cL9UNYn7SRQenv7sxUU0adS9x4McZBoI4QMW07S3HLRn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(451199021)(26005)(83380400001)(6506007)(1076003)(316002)(41300700001)(6512007)(186003)(2616005)(478600001)(45080400002)(54906003)(66476007)(6666004)(52116002)(6486002)(38350700002)(66946007)(66556008)(4326008)(38100700002)(86362001)(8936002)(5660300002)(8676002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7FuxwsEwY0bwXpTuvFfXn4eRa9VUpj8qoFNgHYqGDzH4fUIf+X2W4slqKU8S9sDJxCap8GifQIvffQFSQRb07QJ00UqHsJpDtwnY4mlh9MzjtWV38o0D++voNcYiEe73/poS5b441+DwZ8A5ywMbQYLysqIscXBDUE45wVlWZYvT26l97hlKzJjMRr8Q8QUjLcy8xgi50TIiD+0Q9HEDFPoPfDd13QqwsJqyPDsA4dyU/d+doYIe0TUIUWGXpyXPgkEfDDQK3z0JKHKNoTY6WwM7jMn96C6E2x3tMB1H28en6pd5BD5JRqNVE2xygRYPUsx1XR3AtQdfvrzCcPMPSYQU0IqK+oTV7lxhLkRrCpqn2v6B0fzHLrFAXx/W3JokzaB87oyx9zUMBq6Iugrb0katBqkbDHWZTEgxcWrQPJiZ5XeLSc4K8CE4yRMPAgSk4cThVkRF7lOhZB4lnhmpQgKu+8+qpsAy5sHtFYzClTV6kbIvxuMtwRH/O/Y6EOEKbdHFEMWrZ/cwDBMc/xwtu7PZeF8a3Kh1Bg4A8W6R0M6iRAH0MtQhlr2nGJjQHw00BcuWmf2J+b/AJhwCxrc5VXk7nKeimeDFUmuZJfkajOMI95V0L2a6fIDXE/e6U/unNJ1iOxLikKcfbwth5Ru4jkLVL9Rr2+FDqhlVPowkuYN+zVjsxaCuhjTjXJw9YIIGUgRXMdvxHL+nz6QX8lb3Jvrs7EURH2sbVQaTUbICqCpUPP/Sdu+ml2rND1QToycUb44YuxK/j2lD0MSDmRly/055ARCxjRUMoOOQHdnrjflviKa67X4Cq15dYFIX7oFZ7DW4sgZZslZOJMLRhzed40X5Ku42XbT5VwiAzmpjmfyZOECeCfMYjL/YvVmPySZ52zsrH5vnc7gz48IiaANEO8zXWegQAvtDbV0SLaCFBPG5xuWim+sDiGOFsuxQhVpz8UYb+SgcEb3kOTWijyqf5FEEbWHfEyJgnqkn9JZCcEj8uI4YWZ6pbFoejHk08I7Vch8RpHdMpo/gjTSjn6bPLc6xRhR/fLj6sEbmFVaa7k7sBZHz8RdDP1CJeOQOgZTAVmf7V1myK1cZ2BqKncM7/0C0fei4Trb57FyOYguOfZAYYQtvcNNPeSxqZxOkINSDE/2vuk09FcrsyhqRBcht3MMWAM2nIgFe3cwFJ97MAX/jA+u++0+raNog2AtTU8LzBfoMUz13t0Recf9UauwkXOC7daq1XxiQjXwF+kD9i6M+lhj2VUO+NWcz+B1Eaar0nomvSSajQ+458HkhmV3wUwfJEQVYgK1ctIbPJnMmeBTVzcuhQDlTrLydB6XsjQI/8irw0YO1uW2PZuoIrBMcTM7zhZuSXK43vFzZdjxmeEHD7jBMKaNio3nhCHe1sZcthKkuTJBmUzQGsplBQlZQOuNVHMpT2tYtmXUQXVxo/UVet4JJcZkCW4EO3YdGei9LcvYWemKlKoLMdmrzdShhenzMSWRLqyQBTmGaCEtnUw2voqOSdeI7kzg/5ndZGNLKZRcMfCtOrCDOc7C0ax6z7d/+qbshAW3DU98V12aDEnL9IcovwAIdNLhjLGL7ErJh X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a7a0347-bdbe-47e6-5bc3-08db8904df5a X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 09:37:02.5361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7O+3hk8LifBJB8CrfwSysbbxXi2DN5Krjj/N0ujvV08YLyGDsCp4oIsZITzWvFT4fP/iKaYopRMV9FtSotSMBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9367 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_025220_356850_D0CC5271 X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Robin Gong Use blocking_notifier_chain instead of atomic_notifier_chain, otherwise below RCU complains would come out since unregister/register_virtio_device () will issue mbox message (mbox_send_message() is blocking) again after received M4 partition reset. Actually, no need atomic for notifier which is so tough for user since this notifier is called in worker instead of interrupt handler directly. [ 389.706645] i2c-rpmsg virtio0.rpmsg-i2c-channel.-1.2: i2c rpmsg driver is removed [ 389.767362] Wait for remote ready timeout, use first_notify. [ 389.774084] ------------[ cut here ]------------ [ 389.778729] WARNING: CPU: 0 PID: 397 at kernel/rcu/tree_plugin.h:293 rcu_note_context_switch+0x34/0x338 [ 389.788131] Modules linked in: [ 389.791195] CPU: 0 PID: 397 Comm: kworker/0:13 Not tainted 5.4.0-rc5-02977-g08f78722f07b #26 [ 389.799633] Hardware name: Freescale i.MX8DXL Phantom MEK (DT) [ 389.805481] Workqueue: events imx_scu_irq_work_handler Signed-off-by: Robin Gong Reviewed-by: Dong Aisheng Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-irq.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c index d9dcc20945c6..4408f150b3d5 100644 --- a/drivers/firmware/imx/imx-scu-irq.c +++ b/drivers/firmware/imx/imx-scu-irq.c @@ -42,25 +42,25 @@ struct imx_sc_msg_irq_enable { static struct imx_sc_ipc *imx_sc_irq_ipc_handle; static struct work_struct imx_sc_irq_work; -static ATOMIC_NOTIFIER_HEAD(imx_scu_irq_notifier_chain); +static BLOCKING_NOTIFIER_HEAD(imx_scu_irq_notifier_chain); int imx_scu_irq_register_notifier(struct notifier_block *nb) { - return atomic_notifier_chain_register( + return blocking_notifier_chain_register( &imx_scu_irq_notifier_chain, nb); } EXPORT_SYMBOL(imx_scu_irq_register_notifier); int imx_scu_irq_unregister_notifier(struct notifier_block *nb) { - return atomic_notifier_chain_unregister( + return blocking_notifier_chain_unregister( &imx_scu_irq_notifier_chain, nb); } EXPORT_SYMBOL(imx_scu_irq_unregister_notifier); static int imx_scu_irq_notifier_call_chain(unsigned long status, u8 *group) { - return atomic_notifier_call_chain(&imx_scu_irq_notifier_chain, + return blocking_notifier_call_chain(&imx_scu_irq_notifier_chain, status, (void *)group); } From patchwork Thu Jul 20 09:41:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13320228 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18F39EB64DC for ; Thu, 20 Jul 2023 09:37:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Vxp5AfpM5eXLolpVaodTcPdU5cFKJF8VJCy9M/8KUc=; b=nplm7fxCRcUkJT yo8Y3DYSYxLhM+fuitH15yESZ0oZEu7d0jvOAMAnI/wGGLaBBkZ/L/FF5YfOvUNJkj38TnSh3BJPV ii5QErgfElHOluTV82AUQRSi6vEPbMSyyYkAiby3toh9ZScSScvBNsqCCWxIykFVlXMTmN5g7z1d2 90IN388SAz76ABCpqekKEi2BJ6FnTCIPe0t1P4W/J06Tf1rCg5HUjcnajE+Jen4+GIX5pcvHCMYXl 8qpeMqRp8SerbL4001dMqEydxLmMxDZqYA+SjeuxDtC48pGa+YFDvMmRwd/cwZ9kT1AvmoIeKCXyi ur1eiXoI7mq5U8VekTlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMQ66-00AYjM-1M; Thu, 20 Jul 2023 09:37:22 +0000 Received: from mail-he1eur01on062d.outbound.protection.outlook.com ([2a01:111:f400:fe1e::62d] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMQ63-00AYgq-1C for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 09:37:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bi8UzqKNTsozJMMbJyoz9uFGbOHRpDB4ifLwB3U1cqmF39KZAdmNAm8rjfj/JHU6VBxweOeB8toWivrZXUThRVXQzYmC7hihT8WtgYdBDi6j4n5rRLlqzxVnSVvbMl8YbMWBWgHSeb/ywdsRaRnQrcQfEAxBflYY858DL56cH2ONuye1aaCfDOCJPY2EB6MYlKuQe+Iap30END3u9XVShmxYMFIAstWeAIdPWNH7NEmjuhzjbXHpv4fqYEB2W3TSi228KnGKj+OFaIfhwYYc/bIwKG6uztE7y3wsrznr6ctQyqVHLAAZjXfuO4ooABeUAXRb5mX5Sr8iprz6LWhUWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Usntcsf9jSPDXtSzDmufPBCJAQO95nl0cPYHpk6bmPs=; b=A7lPQ61/bg0tIlDAS/EU0vsdSAyQBWvNa+OPSyf10cyzU2Nfagd+EGb4nsUS6hMG5JnL+dCKuH7bNItPRBFoHVrhHArVhdxJCRaBcKT4iubh9n5jnWEQHbYROB3ywFejuFSqOxowFWlOOGVPQxDqsJdQljC4tkZoHV/I5vajm35lxYrpLyw72kbONhTA3RNd+e0zw8wpYZ9BCVLq7F0lfxJJCCoXcYR1VPQV5JAMI6g8mQbmTUGl5I2+tiDb6V3wIGqlMCTi1i328s3qswLcyv5yaMn7BudREEhBbSdC78A6yimnGcnHP8PPy7xyqU+P9Pe6HiM509HFWDfFYK7o6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Usntcsf9jSPDXtSzDmufPBCJAQO95nl0cPYHpk6bmPs=; b=L9xEN47vz2GE/sBiebUP/NxlmzNXy/WmviOf4o9jMMdGIdoMU6MpvGUYL88rDr3TJJQ1916ttdaHgyk2w3gYKUJF0tnr5qtrHUPdHdxOwITJ4z/PLdiwcfwd0tONlMv2Yr3aduFY7gQsqyTXxgSWrleqa+EqKmPUT7kLgY/kzww= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS8PR04MB8388.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.35; Thu, 20 Jul 2023 09:37:06 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.024; Thu, 20 Jul 2023 09:37:05 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 6/8] firmware: imx: scu-irq: export imx_scu_irq_get_status Date: Thu, 20 Jul 2023 17:41:26 +0800 Message-Id: <20230720094128.536388-7-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230720094128.536388-1-peng.fan@oss.nxp.com> References: <20230720094128.536388-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR03CA0110.apcprd03.prod.outlook.com (2603:1096:4:91::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS8PR04MB8388:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e7f44a3-7bce-4c69-7c04-08db8904e158 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hNMbqc8OMNbvxaNNiF1GPY32UJ0PLC96Rf1PdIGketjrj20seCUZBUlxoOxDIjUt1KJTpKnuIuEsojtpZoXLE7cX4mhogNwckbfoZsPt+Gp1hCk5KpsCypnhuBrEOQ6/P9n2zPQoWne/eiUtWOKY7+zlYe2Ird0FH5MSB63Eg7V4QdBmZh/149fYatt81de8Q+PxD7geLrK+Cc/JpC2l7Y0Pq20pxcX6m6l2ZN1k8rEvWAXdQQD87AcTCQASxyyTy7tgODoKIb5UCF9pXb1DVtqUJ4UZg+Tb2wByjcR6cwY+qMD7wFw5VL9kiPwTOiOlR8z2dIQiLgXgoUXqeex/QGP5pMQZqyy9pz47CSCGvRCTpOi1JJhGXCqy12smXdjSWDmvgCW3vkX7T/Sg/Yzv4c9NnoqAi/im8ZoBJB7VFptT0NABzhJ16T6RbONfS1ZxlLtaWAmkUoLgdyw9x2m/G9KCkuDOnnMfo1WsZiNXvrv0jqHJI2bkwlpDBiXpnQQ1d7Xm7In6OexmWiFBrSQuKnwyQrGN3jpuQQSdCgdvQ3G7cDmd9nseGW7GcQks63chKSweIdPV1iHuTO237lQzoMGT4dEnN+lXoG/9NHAWw57Rlfv44PCSHH5tGdyXi3TC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(451199021)(186003)(2616005)(6512007)(1076003)(6506007)(26005)(83380400001)(316002)(41300700001)(66476007)(66556008)(66946007)(5660300002)(8676002)(8936002)(2906002)(4326008)(6486002)(52116002)(6666004)(478600001)(38100700002)(38350700002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vWkN8PN3MW8WK0Wk7VmsnnR4tYrCIYGSvO8Y8cfYWzLxP2Qx8hbcjjT0bbTKERkIR6MoOx2EOlVscKOctsrb4b8vlzu8raOoeXAmFPktpjOFGzzmY8iyEV7/noUqj/H9pmrQnmXlfbevkT+K9/RVkR8ESe48w8+T0SoL2aDU8GVHBRxh8GHgxNvzSt/GHb5qBkJZ9ifawlE1IkvYfHT7mJOr94xnGpJTNfSqSrikoV84Rp3D8DagxRrNcGRVaU/zrhVVRHMmBdiyiVGDfOERGJwEUIWcUtN+rwA/qV3miHzipslhDXXciTS18kShNX8u4gcGYBLAN/2Vy99dQDmz33Jk0H9pJIyyuMAtriO5ikRdfCn5fZA+WwYr1V9NK5KYlrU+tTY6tWwAC9Jzgm97oTNk1yc9u9E2FFTZYlXaXAO2RD5zQXH3VQVZA1rFW9Tw0/gt7gKHyNR7efh4tw59v6jrZbgMFmKJeO3BHKwfb2Fndfsk56uDpV58HcbqlbStCDIG9GRAaGqa/FssQLNplCoRHV61JgndP7QOszoOl014i2qUg2sV3oG/ZZH++ayZ2RYuWUYtQVdUTwx3N0I3SxB6+r/usq5MlrBvHHUmZ/HZ/JaanNgXo4fQTYS+j6EsEuFHGczrWMaiZDueoC7BRLVqjor6hB2JjBWZ49BGH/5Fb6pAQQZTBKaq4TYcBYWsXnNWJ2JjvBv0If3QECOurDLxCtadTv2Y1RMOHCkZKmuReSTxK9cFEWXhxg/3SBvmiykGPMq/xrcLGM+JeAPyZOZ1cwv0qW9wv7XkoI52YcsLH9VzNIAI4Wri+l2ufQX3UpTRNxml2dtBrxFigyZCbSuu2vc2TbcGO7HaLDzUQuo0IDhKIXH08q1fC6PGLkTVbXXOytXfOxpf83P59n0fKx72sdijpsovq7QsdLG1MwXRBFAMnjILK7iQK9hLggNwqJhXskLgQL+kDTr4s+9zxsus+9YNDWn6J0VVsVBtigpK7m9PPajVroQd95Ck7GjSmkNuXzafvVmAz2777Ji2HjbISuuNa9KzCNuiyERS9EcFi3xoh5TNvRePQsWxUZUtEqbn2UPKorcm76JZeQ0gE6hiY8clG+kymUcMBZoimZApj6bpislzTRU2QsfgArHp0fn/NjetaEIacCkzerCd9tTcx4HwxZovxHem/tvyRkmsCDxtTPyKfaopVd+uW89GbxDeWduKbgPQitHXacJJi25CHuWQzF25gNsMGTD7EkVJMQf5NtykQJ+IJyB05oA/0cazgA4j5F1/VPMovlDIXor31YcBcIg3RvSUGrDt5MSKnput9HxOsDHfL7PE3nkq2mm4SX3jlH8/atp/IwpVK8/KlkGUis8mb4g/OWAUx64Zo4F0x+t/5OaG3VMLNc8zG+VcCcz8QAK3kO97SgUsJjlFRx6TlyABuNSKbmlZEN7ZxHrJqTvlxsWTC/m2bfTtzfyuvkwl438juKqklZXZY4NqtUeUMRLFxHPBfn2S+qNWbp9+vd1DDl6S9pbR6aRpbfQmCeJ+feVo/zvKL9bg+xGq3kF6XH29ERxMKthyhhWf1rRm4usMVKueazU95nlS X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e7f44a3-7bce-4c69-7c04-08db8904e158 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 09:37:05.8165 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d4jzXNweUaytq4yAZqV8u6+HIj8t1IMViHtld28aQ01P5pkRAJ5cTwx+V9MIFeG6vARkOcut+zwQKrJnR+FZKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8388 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_023719_409316_77BE27E9 X-CRM114-Status: GOOD ( 13.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Cleanup code to export imx_scu_irq_get_status API to make it could be used by others, such as SECO. Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-irq.c | 40 ++++++++++++++++++++---------- include/linux/firmware/imx/sci.h | 6 +++++ 2 files changed, 33 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c index 4408f150b3d5..6549f3792a0f 100644 --- a/drivers/firmware/imx/imx-scu-irq.c +++ b/drivers/firmware/imx/imx-scu-irq.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0+ /* - * Copyright 2019 NXP + * Copyright 2019,2023 NXP * * Implementation of the SCU IRQ functions using MU. * @@ -66,29 +66,18 @@ static int imx_scu_irq_notifier_call_chain(unsigned long status, u8 *group) static void imx_scu_irq_work_handler(struct work_struct *work) { - struct imx_sc_msg_irq_get_status msg; - struct imx_sc_rpc_msg *hdr = &msg.hdr; u32 irq_status; int ret; u8 i; for (i = 0; i < IMX_SC_IRQ_NUM_GROUP; i++) { - hdr->ver = IMX_SC_RPC_VERSION; - hdr->svc = IMX_SC_RPC_SVC_IRQ; - hdr->func = IMX_SC_IRQ_FUNC_STATUS; - hdr->size = 2; - - msg.data.req.resource = mu_resource_id; - msg.data.req.group = i; - - ret = imx_scu_call_rpc(imx_sc_irq_ipc_handle, &msg, true); + ret = imx_scu_irq_get_status(i, &irq_status); if (ret) { pr_err("get irq group %d status failed, ret %d\n", i, ret); return; } - irq_status = msg.data.resp.status; if (!irq_status) continue; @@ -97,6 +86,31 @@ static void imx_scu_irq_work_handler(struct work_struct *work) } } +int imx_scu_irq_get_status(u8 group, u32 *irq_status) +{ + struct imx_sc_msg_irq_get_status msg; + struct imx_sc_rpc_msg *hdr = &msg.hdr; + int ret; + + hdr->ver = IMX_SC_RPC_VERSION; + hdr->svc = IMX_SC_RPC_SVC_IRQ; + hdr->func = IMX_SC_IRQ_FUNC_STATUS; + hdr->size = 2; + + msg.data.req.resource = mu_resource_id; + msg.data.req.group = group; + + ret = imx_scu_call_rpc(imx_sc_irq_ipc_handle, &msg, true); + if (ret) + return ret; + + if (irq_status) + *irq_status = msg.data.resp.status; + + return 0; +} +EXPORT_SYMBOL(imx_scu_irq_get_status); + int imx_scu_irq_group_enable(u8 group, u32 mask, u8 enable) { struct imx_sc_msg_irq_enable msg; diff --git a/include/linux/firmware/imx/sci.h b/include/linux/firmware/imx/sci.h index 5cc63fe7e84d..08346f312c51 100644 --- a/include/linux/firmware/imx/sci.h +++ b/include/linux/firmware/imx/sci.h @@ -21,6 +21,7 @@ int imx_scu_enable_general_irq_channel(struct device *dev); int imx_scu_irq_register_notifier(struct notifier_block *nb); int imx_scu_irq_unregister_notifier(struct notifier_block *nb); int imx_scu_irq_group_enable(u8 group, u32 mask, u8 enable); +int imx_scu_irq_get_status(u8 group, u32 *irq_status); int imx_scu_soc_init(struct device *dev); #else static inline int imx_scu_soc_init(struct device *dev) @@ -47,5 +48,10 @@ static inline int imx_scu_irq_group_enable(u8 group, u32 mask, u8 enable) { return -ENOTSUPP; } + +int imx_scu_irq_get_status(u8 group, u32 *irq_status); +{ + return -EOPNOTSUPP; +} #endif #endif /* _SC_SCI_H */ From patchwork Thu Jul 20 09:41:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13320229 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E123EB64DD for ; Thu, 20 Jul 2023 09:37:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JnPAnkBWXmSAPABSzeN/qk6X6XDrmVPN7dQlcnpAxZY=; b=mmyvDkVvbBQcCA 82w3Cge+Av6xWQKLOIwhTBji0tDNZ7s8R434fwZPr7AQWNGODMA5xnwfRXVsUPqny7K08hbWk1P16 ywEmJYkWMFS4YPONGQHRmgPS0G/P3cSJWm9nDXs3j0sSJVRn3UAqPgrKsfRXO/m6kBNdcLNzS94Lf ZiDnsLWYgyMb3BFC6DQbWgZTz4CPgfl6Ad3Wa+0WExeCfzkSoAFGXm2B/VQDsVhsMUbmUoGHzbPmB rSCFhd6Fm/x54ZqMidPKWXbTEwehaBqS38O+1GRrh8GYAfWyKxCqF9wRhAQ9gZ9tonNbQ+TqMvY00 vj8a76AWWqfwFkBMXeOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMQ6D-00AYlE-2x; Thu, 20 Jul 2023 09:37:29 +0000 Received: from mail-he1eur01on062d.outbound.protection.outlook.com ([2a01:111:f400:fe1e::62d] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMQ65-00AYgq-0d for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 09:37:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BEXUP4atnx5r8+rzyP9L/APsLc0I6DSICidB7YatLHviKp0uih9f7+NWfuW9NaAwESWFMaD5zTY1xLAQ3nsNoyYrqxx7wAvUXtpwdUgpsgXCItFEPxGccYLooAPqF2dSFSyVDv1XnGBb3uz68praNTMeXKJXUj2B080i+YqaWN4bdmREnX3IooP7xPKZvh+YXNqfRsgxrEhklunDbpqjZP5mGx+MQjXU+ojzYVVXnYeSn1ekruKF2mlzvd8dX/YspO5Rn3opPa6c17NTg74UBsTxvMqO75QXTON0/s14PL8ivWSf8g3NTj/+K04/IDRQK8bJRkXLLRJgmLoT/4pDXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QALHUzHVhQKD3fKu06vGPOUlJ4GnUotQExquzQP0wVA=; b=Sa3JyQuDXa76uYdFpcmI7geqFkZT14wrw3E3eQOE/mcj6naRCEjOCgfJ9KFk9wlOkSFsEPyzSsKbWvVUyewQSDLxboPaaawvmeCezaOOD1UoHHvcbX4fG0JOMpIIPf1QV3eMOr0AAgpLd5DLnPnztHaz9NJk5VBxqpf9IFNGbANR8U83HDdHdftDSar4GTKTW/PE+nx/CPM8Jq1Jp49jcTeqXF2GIWJTGg1fKStnxf6vW92v+fw+lxoK1qLyaBZKiUiWiRCmBzSPQhQxkUZaUnkNDyk2ryjpkHRExYtj2k9iGSEpp+dzb4SyEdBRHyOO10Af5FWwFyXq6tkEemngLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QALHUzHVhQKD3fKu06vGPOUlJ4GnUotQExquzQP0wVA=; b=doYiCL/8MkODqeA0bfXaefKmEQaeiwkr/HMw+/U/D4Zvfl9Hs8xtO0K7UPcYrYyBhIKXOGAp0SN9Ve06l0enqYeaLF5qNDbhKdXoVNjipkV/fYSwG4lKTVLXfaBXPLAbBzHPUOXH+e9T/v/iuiSledfkrdFzsugf2D2IaLpjvyE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS8PR04MB8388.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.35; Thu, 20 Jul 2023 09:37:09 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.024; Thu, 20 Jul 2023 09:37:09 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 7/8] firmware: imx: scu-irq: enlarge the IMX_SC_IRQ_NUM_GROUP Date: Thu, 20 Jul 2023 17:41:27 +0800 Message-Id: <20230720094128.536388-8-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230720094128.536388-1-peng.fan@oss.nxp.com> References: <20230720094128.536388-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR03CA0110.apcprd03.prod.outlook.com (2603:1096:4:91::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS8PR04MB8388:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a66b296-cf4e-4afd-756f-08db8904e34f X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d6OZu6zSUarqqj0quNXRO+fKjiusQE/Hjzv6bq0tcFm58o5fRvrMtcxAJC4zLrZk5vXelxkoaIi+9S0q/sDRfdMyV1xPtgUweb7xaBrCXKrfNDSESamCZLTSgRk+Xj1rNSIc0uhmBRNqJYG0lYRqdKgSDJUpktVqtMj+PEUpPzAQOv9pOvRE6kFTe+0hYcjI50lXHje1VP+dvFdIqR4YLgXJpklyV66gA+fhSGc/QfSBwtXsX3FL+BtLSSznSt8Pi2NJhHBPGniuEI4N4DviocWgKeQXeLuRQDtecbwoc0XX1Iwoh7560FENwSHCj7wQR4XqM75DlBsY7cQa01Jlzaa7iGaP4lLen8nKOLnUchX85yeJCtwty3tBt8RG3xJybJW6zFEOvdMcFL/gzalFb+bO2Y2Vw08FXGVrU7+PtFkxsGWBG9H1vcluj5TtAcfqWP4SkjM4rN/cbYFTzFeM+6YpAdjKGBq+n4ubnrWjCQCJ4wOTS91dUW0o3TOKc2RRv2tduxRtrP9clVfUSQmaaovXuZ5BpfKNlJ05OUvXKd87NgJDDeTJ0I57ThQFGv5pBE45vrApDyaiZAJ9JvmLTSfFWEnjtwD/HRQtM81RiXyfB3KRwlnq6reNdta0lWPAOA9u5iJX5IRnzRbBrk7J9A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(451199021)(186003)(2616005)(6512007)(1076003)(6506007)(26005)(83380400001)(316002)(41300700001)(4744005)(66476007)(66556008)(66946007)(5660300002)(8676002)(8936002)(2906002)(4326008)(6486002)(52116002)(6666004)(478600001)(38100700002)(38350700002)(86362001)(147533002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zCRLbIEiR9+UCWdqQ3Ki8nq2Wg9PS75nYtoPs9MD+SvyObNOm7dV8Nhb/bJJ3Q3mjvcNsgkdo2spffKm7W+Wogr0+p9UJJvLWX53hL2pWYrhjFL+p7MZ4fiPRG7RAoJOpRfcQg2XGseNGDJFIcyW6+5FJxorLQTDh/XlKogBVcjWOVr0fTDARvh/B+/fmEhFJCPq7lF31GWxhSAU9uREwQQQ36fmvsHjHCHThlcDlQE9Fdxk0at+TDahIYfzHA+5GIPcR4XXBiCrLIWGmkFgodlzGUy45c+Ft+xn1DytgzRSqLJ0eoiGYTYluq8RgNHZEea1ZIFMKvohiPyIFzEY/GTqE6zAEIKBCF8Ge5GbnzcWFQBIJBvn1jWoWhjtMKv8N4balsyycv1SigU3MKVOnNVUDB708ltH1N94BWb3XmZLfzal6nF5sq0to+aSBHDl30qXEIN48OWAhIxDCRELdtKbcJUAbwEHaLC93NDoQUsYlDvn+liYCT8QTuHG6rG/txZGtpxgdHl0dTF0sSinwNRV8YqrlBIS6zI96H/T0GmIjdY/2poEpbFB0GXmFFWTZGexQzB3zJouMRuzWk+3l0STdK3DkG95UuINX6kOEdgkR/1vudpUYWXYUbzAYWAg0XbLbVVTc3HoJYeNi3tm3iZoMJc/cE5KLoUbH3o+15zEM8pDI5DoEtVgAGAhNgBJBIbLmervPWdwiiO0OmU4m0nSVH0es3xW6/OhSnCqqY0/CZZIPNt6qG67MDG+uzGy0GLqHNCJs3q0wGJ+V6VWH5NmGVBAl3uSM2eI58HS2OeauXtIJtPqw2lveSOpDj2gwSCo10pzxNjB1NIgQnQPnj6tLWa1mpO/BoO1Pgwdhd6s1nUL/SZTzCk3emvAb9V88tHtKiJhLG0xbT0kudR1L4OOH9WS4VwU2oGw/yICrGkZ9Vz0sQMzG4ZCPd7K+tJEMK2LpsJLI+xLxiKALnpBlySTr33YQBW8BAoc3MUzvF0AqhEv9k1eajndYPc3hQtSdpNnRoG4A79C0mTCKkatJzU9301+znXvOvy/JsKwW5kIyuW3psIRCYgMBGvPw/UCjo7ruTI6jpxNuiuyl3H02wa+blm7LrVXOhG6LXKNNXetpWGzJ2c6bgtqPuO0dFAtilQAKChzCd1hGk14WwZc9mztpJErHqIQ0F4LVbRg5e8PenQbJ/SQTTarZg9Di9ViyzGHi2Oeeh6coiiyt2+PD8s/Q/WxAXkVvWRJph+decLxhjSdPJFVNWjWI5HtIZybf3eEHUqyeWaFVLpX9Fpkr6QjbOj2d91l1e7v8mzsU1mltJrRMWPTv5sQGdQ6/iG7cRayFhNgBgkCh2dA4V3eFUQHQrMfxRBY97Qg6OFP4TJHXde5XMeOelCbEI2ZBUZxtFSwf7CTuKjDUx2RB3E7p6nneTzHEDqKul8M7xNj4Lm8S2yUcbs7RXbRQmL+qO5wtpGaJtk4/xVBktU24sj5iERv1VMBASkkUXn5E2jjeyGiWusC2UeWszfi/qABEnb2nC+3Wg9qW6/KLnNVSlHrN+4hy9kSl/XGetEp0IXwlNYUn+YZqpbuOldFTj7HWikx X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a66b296-cf4e-4afd-756f-08db8904e34f X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 09:37:09.2819 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FbBbgrDs1rilAU5fVCNGfB1x/Iof1cjTuthWrVrdWzsH5r0EqqAfPpnwshmTWFNRVeb9emYaKeCB3ryu/1nssw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8388 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_023721_231560_F7D30844 X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Per SCFW update, update the IMX_SC_IRQ_NUM_GROUP to 9. Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c index 6549f3792a0f..8d902db1daf2 100644 --- a/drivers/firmware/imx/imx-scu-irq.c +++ b/drivers/firmware/imx/imx-scu-irq.c @@ -14,7 +14,7 @@ #define IMX_SC_IRQ_FUNC_ENABLE 1 #define IMX_SC_IRQ_FUNC_STATUS 2 -#define IMX_SC_IRQ_NUM_GROUP 4 +#define IMX_SC_IRQ_NUM_GROUP 9 static u32 mu_resource_id; From patchwork Thu Jul 20 09:41:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13320230 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAD8DEB64DC for ; Thu, 20 Jul 2023 09:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vq135/7k9SNFABzx6s2Ln4DM4IDzMIFfUO976uToIyE=; b=vi2BylHvMk3OMk UjcfoRKk7V8cay6WS/1UNw82ihW7Mg9jujYTqf1nO6UMxyrMSX4majBrYPBnPS62//0RTRVVxHy/d 7guqoXXlzUNXRG0NQfSDkFtaPXhBIGCpWwQUiVVzN8qaT7xRlGMNC5rGWw7n5L79nhvYKE2nA2TQa 7aa2wv3x262C8OLiH3EfSNb9uVAcbKZcSGEWmDoDYaJs+2tGLJMV8bm/q331kUlRJBij/FNdtQtLX YYytU7hkbq/1fKhl5h7/+zX/TBk1AAmBZW8UQdusNt8qVWOIPASjObnMKmCW2qRp9cgWf3uyWYP9a fjMHZpqI3FOQ6+AeVZyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMQ6E-00AYlb-1O; Thu, 20 Jul 2023 09:37:30 +0000 Received: from mail-he1eur01on062d.outbound.protection.outlook.com ([2a01:111:f400:fe1e::62d] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMQ66-00AYgq-2K for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2023 09:37:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VdnNCjV4D54LBPKjgHJbK3dpQzETJ0NRnya+bPYMhFTLZyWs4Tq9TkHg8h0wSAFlPCngzk6aCQdRJHZJ1UlqRe1ygLB8S5t/Q00G94XanNtEyvITbgVcwnRa7c/VKi4wN7r98C279LFQWH4chc/9V4S8vUKb8aVTztjSMZ4TVwsL5okMKdb1A267sezZ5OReg7Lm7I09gyAKnb8QsrQzGEliD7C6peW/JmRfsO05Mr5iA8LYNq4R5K9Uf/vJhHfWYQvgC56UZEKFUm0e2QJMThJ7OCqFHFd7rz1BagURUJyXVZy+JW/+Xaq4Umy+m9VB2yju7eirQ4Zy5fzRNsVJew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UFLJJaYmUcuamnm0HuIOJj3+EI9yddl12xmxM+3c4MY=; b=fDLSGe9rLYoRsWP0wDDPanUrgNgimWqzg1q+bbjNjn/u5ndJ5kjgPXGU7AjJFU1gFCzuh36C150DdV1YNA3gGXypfDzIpDUkhCXvAhN9dt4QiTfHcD99QfhNWAisonDwOLDkzilHkm3LMUM4carEm1ZRh7MkrFLcn+4bRfYr0eZXvVsyMpsLDuLikgjjP4f5bvL9r5C+8scn4eNWVL7muaSwVwA3sd+FK7Vuk1NET/YUqEm+AEQgSLAM03JmTD78KwIW+7FU6+bzzU2EsNEImr9JCLafwJoVmtQ9usfNMPx/1HBk2MCYuFt72HeNE0coUar/t/3H/fH56e9iu+nGvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UFLJJaYmUcuamnm0HuIOJj3+EI9yddl12xmxM+3c4MY=; b=WKnyODEdGedak5O4aWRza+KPjFKvy6NoSTyuktPE7p0Em0KDTSuAs6/ptvu03x16WMe4d5jcPQTceXzLZCl1rbVdndDYKDRQ8jjN+WbVdmpAGChQq1wLUd2Zs2kUgZdzb1R4PNL04qW2zuA00FkeKpCVD1pN0BkBrykVqhYsgx4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS8PR04MB8388.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.35; Thu, 20 Jul 2023 09:37:12 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.024; Thu, 20 Jul 2023 09:37:12 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ranjani Vaidyanathan , Peng Fan Subject: [PATCH 8/8] firmware: imx: scu-irq: support identifying SCU wakeup source from sysfs Date: Thu, 20 Jul 2023 17:41:28 +0800 Message-Id: <20230720094128.536388-9-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230720094128.536388-1-peng.fan@oss.nxp.com> References: <20230720094128.536388-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR03CA0110.apcprd03.prod.outlook.com (2603:1096:4:91::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS8PR04MB8388:EE_ X-MS-Office365-Filtering-Correlation-Id: 896a9427-3e62-4136-cba5-08db8904e586 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VUFacwTeO66WOViD9rwJuolBQSNkXxSGnOom+SSfXb7vRrAtVL1GVC7z4wfYAiW7mRJEPtE5q4RcptWC+MAMXB+M/ch/7oVUUXU0lQtvvwy0QsH2Ig+fzo+wk3C1XEFjwgUPQjFcPbds9Pmqx1+1T5xv7TMcvyviBgW8C28R8pL3KyUOWaUvF+8ocY7NFxZd65B0hfVcNjeGrj1T2CtmCUWuDpfy7cHY8i7vVfpA75N1aJlBOuZ8XRXp+Ky/pVFmqwd7979RRzqkw48DSgi9rSdW8CTzO71JDsXNw679vWszUh5xUOXnM6p1EBWwXiJW5JeA3JEWn8Bt8225NzgJDgi1uXKtKW9DGinsQN9Afdc4KbUjr82IKdYQHAfUAivHjVpzRUXVEw3QQ+IsnccEA/RE22MVWMXmypnB+7FVVW1cHaKo3RajAudHuuIy5SVA9S8QUJgwg2z2eNpBImW/hoFAzoaxu8WsmVaFaCqId88s2L5FbCAkcuZNS6HZiao7jiRWxi+MBjSW8GG+u/U459c28lRgxGy4Wh5qXIOWJfdAFXZ66DU0xbxEwS5RBPS4Hfx2h7oydjwDSplEiHpGBACd0EBZIwrf9NQnwuTiyluPOUSfp6IOKZeJMcPle8EY X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(451199021)(186003)(2616005)(6512007)(1076003)(6506007)(26005)(83380400001)(316002)(41300700001)(66476007)(66556008)(66946007)(5660300002)(8676002)(8936002)(2906002)(4326008)(6486002)(54906003)(52116002)(6666004)(478600001)(38100700002)(38350700002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VQM0kylK1FLNfT6WvK4EzgotbKqLZ1abJmnRKtBZb+U1VhmZ8D6T2dJdHUY+3EUVpTS6/1BY24FMc9KjpYNZ2xxc8VYpLVec3lGvPcCdTm4SXsVHNVxluTsFPmdVHHyaunYWg8CUsEapLVxl64Oynr6ZIIavJ73jz+/BgmG5jqeu5/cgucW6n3j156t0gINEjUSKuW7gkDRi820ZJ4hUwLllqHlTexgidpXlmI9OnxJtJuiIGcwTEj+91a8bpdCwBwf4tobHDufTJ+qkwk2cmZYv2ZGER0EjU++1u+SO4lF25oSF85c+fPngy8amsAWr4hHjmhTp5pNZYkujPJHS5INp5ZfwCclSeFZ2F/XIZiCUNPiqL2XLkkWDpYZTMgwdRpRpLZ6uvm8AsTnqMICZQa9aQPDiljuvuT+VN1wPSN6O/nrQVo/P5hhXUP0WiLUC2ScXlTjoWzFT03CDNXmdFlqXjg6WW3Ctzpm5B3AjAC1Ikbc28dgdgGdErs8DdAnN5LWcXA4vg/hrdvlx1UILOX/trYIV3u+7rRCTOqNR+GIs7tZfmf0O74bjQXZ2PvFjLPAg3hNck77uNs9LuQQeBdZCwBQhiu90vKmwgvF3xwTq3DJPB7lH3JmE4XFnQ0AOQ6dNW9yeWDuCnfWy6eEZ43ud2WemQXJXDkQ4ItYwcBQV9OgEE4uO3YnrX7eNW+a5oeyZvZwMd4nWAhcM3TQqLcZT7kvO9aAZOFL6hUjugzRm7+ODTOv8x6wWiSXoi4fjkRqnnrSpKvRr8BnK6ajYRsYJAUlkHyiKlOwLgcgJ+TlscR1TZST6WMBhfS8TPZJyv9hCQde0/WexpbYhNSlJjFE93HEhFyJt6NjyP0OKmL8MKqnA40CxcX6YOZCXDqJ6bPEcVYyZRrTQZbbrY3iio5owAoQJbsV1FA9gfGHhnyyGU7JcY/KIW8+O2KfKIH8lJm7gJ1qMuqhGTYNOuMJmPT11l7ZUBdSvoMRXkqEITqSSA98awbZEPLu23e5GLfSng5i/rs5Z0w25IzfDZf6y2DLGD5gOY0RX+kvKjX+T+hqlEOCE5WezaLgUK7HY/slhbf2TbsOPk1PcGlwb5TaWmVt/C6xsmgf7HZvVwQpod9v727WkNDWM9cTEOBfa2yIUN+LCtsz2Fi7Nla40cXXwtz0zBD0Q1Xdr0DmxULTXoJdpUz+3dLQSWkhhl6wp3MXuRW6Kb382AZTvv+VvTojTx0Cqck1YhUcoXRXWbd0rCyYzQmISisQmXUH0ypuSV9KHDV4r/AMyjXOwtpXGDWoxd90vPynCrYXMw9DpuyXlIjNp4p/C9HytHDEnbJpSX1f/egvI5rMTYnk1LEXuC6nc41LT6Anb6ZpMdCL5V41oxkSacdpXAhj4YeNIaYStax/WlV4UoKX4iqCvhI/+cbTrbLgGPtRCh7A7tWvaUSUY5z+9893zrec6+HJFYbFt6lRVE3o2HxKVC8jTtfWk1AfZBz6+SUcLX/gU23g3uwlBJD9YWcKAMLQJTfbGVcBGhQeo3xAiW7FATAN3lvuHS6uUG7ziBxGx7W7uSONlhlIqjFUveR5JBtV+j3oqnyxlUXqD X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 896a9427-3e62-4136-cba5-08db8904e586 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 09:37:12.8545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JZ6nND8H4vvSU+XCaG0hFQLIX4BgMnKm1FrSG8mlctqK+J7lvKXtGbxXYH+RUrdcyKcaa+XoX2B2NdBcr5zzYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8388 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_023722_794553_A2B86E2D X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Ranjani Vaidyanathan Record SCU wakeup interrupt in /sys/power/pm_wakeup_irq The user can further identify the exact wakeup source by using the following interface: cat /sys/firmware/scu_wakeup_source/wakeup_src The above will print the wake groups and the irqs that could have contributed to waking up the kernel. For example if ON/OFF button was the wakeup source: cat /sys/firmware/scu_wakeup_source/wakeup_src Wakeup source group = 3, irq = 0x1 The user can refer to the SCFW API documentation to identify all the wake groups and irqs. Signed-off-by: Ranjani Vaidyanathan Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-irq.c | 64 ++++++++++++++++++++++++++++-- 1 file changed, 61 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c index 8d902db1daf2..30accbfdc8e1 100644 --- a/drivers/firmware/imx/imx-scu-irq.c +++ b/drivers/firmware/imx/imx-scu-irq.c @@ -11,6 +11,8 @@ #include #include #include +#include +#include #define IMX_SC_IRQ_FUNC_ENABLE 1 #define IMX_SC_IRQ_FUNC_STATUS 2 @@ -40,6 +42,20 @@ struct imx_sc_msg_irq_enable { u8 enable; } __packed; +struct scu_wakeup { + u32 mask; + u32 wakeup_src; + bool valid; +}; + +/* Sysfs functions */ +struct kobject *wakeup_obj; +static ssize_t wakeup_source_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf); +static struct kobj_attribute wakeup_source_attr = + __ATTR(wakeup_src, 0660, wakeup_source_show, NULL); + +static struct scu_wakeup scu_irq_wakeup[IMX_SC_IRQ_NUM_GROUP]; + static struct imx_sc_ipc *imx_sc_irq_ipc_handle; static struct work_struct imx_sc_irq_work; static BLOCKING_NOTIFIER_HEAD(imx_scu_irq_notifier_chain); @@ -71,16 +87,24 @@ static void imx_scu_irq_work_handler(struct work_struct *work) u8 i; for (i = 0; i < IMX_SC_IRQ_NUM_GROUP; i++) { + if (scu_irq_wakeup[i].mask) { + scu_irq_wakeup[i].valid = false; + scu_irq_wakeup[i].wakeup_src = 0; + } ret = imx_scu_irq_get_status(i, &irq_status); if (ret) { - pr_err("get irq group %d status failed, ret %d\n", - i, ret); + pr_err("get irq group %d status failed, ret %d\n", i, ret); return; } if (!irq_status) continue; - + if (scu_irq_wakeup[i].mask & irq_status) { + scu_irq_wakeup[i].valid = true; + scu_irq_wakeup[i].wakeup_src = irq_status & scu_irq_wakeup[i].mask; + } else { + scu_irq_wakeup[i].wakeup_src = irq_status; + } pm_system_wakeup(); imx_scu_irq_notifier_call_chain(irq_status, &i); } @@ -135,6 +159,11 @@ int imx_scu_irq_group_enable(u8 group, u32 mask, u8 enable) pr_err("enable irq failed, group %d, mask %d, ret %d\n", group, mask, ret); + if (enable) + scu_irq_wakeup[group].mask |= mask; + else + scu_irq_wakeup[group].mask &= ~mask; + return ret; } EXPORT_SYMBOL(imx_scu_irq_group_enable); @@ -144,6 +173,26 @@ static void imx_scu_irq_callback(struct mbox_client *c, void *msg) schedule_work(&imx_sc_irq_work); } +static ssize_t wakeup_source_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + int i, size; + + for (i = 0; i < IMX_SC_IRQ_NUM_GROUP; i++) { + if (!scu_irq_wakeup[i].wakeup_src) + continue; + + if (scu_irq_wakeup[i].valid) + size = sprintf(buf, "Wakeup source group = %d, irq = 0x%x\n", + i, scu_irq_wakeup[i].wakeup_src); + else + size = sprintf(buf, "Spurious SCU wakeup, group = %d, irq = 0x%x\n", + i, scu_irq_wakeup[i].wakeup_src); + } + + return strlen(buf); +} + int imx_scu_enable_general_irq_channel(struct device *dev) { struct of_phandle_args spec; @@ -183,6 +232,15 @@ int imx_scu_enable_general_irq_channel(struct device *dev) mu_resource_id = IMX_SC_R_MU_0A + i; + /* Create directory under /sysfs/firmware */ + wakeup_obj = kobject_create_and_add("scu_wakeup_source", firmware_kobj); + + if (sysfs_create_file(wakeup_obj, &wakeup_source_attr.attr)) { + pr_err("Cannot create sysfs file......\n"); + kobject_put(wakeup_obj); + sysfs_remove_file(firmware_kobj, &wakeup_source_attr.attr); + } + return ret; } EXPORT_SYMBOL(imx_scu_enable_general_irq_channel);