From patchwork Fri Jul 21 15:09:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13321441 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86150EB64DD for ; Fri, 21 Jul 2023 07:09:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43F75280190; Fri, 21 Jul 2023 03:09:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EED82801A0; Fri, 21 Jul 2023 03:09:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B6F7280190; Fri, 21 Jul 2023 03:09:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F1BDC2801A0 for ; Fri, 21 Jul 2023 03:09:34 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B2092A0157 for ; Fri, 21 Jul 2023 07:09:34 +0000 (UTC) X-FDA: 81034743468.02.72DD867 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf10.hostedemail.com (Postfix) with ESMTP id 6A2FAC0006 for ; Fri, 21 Jul 2023 07:09:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of shikemeng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=shikemeng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689923372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S6DHHezetXuYiiPkMjsDD5fTroDrw06NfY+OaRpHxEA=; b=AKa4LV+H5opOY891YyWQk2qd2GtlpI8l5WSiH++rNZIM2xL5sA8D6eWMEiSEVloUqWLpmB m2OIo0qw/t2Xf/LcXjJGflUHheDe3S5u/IBMastfIp1dOBxG02Q8vWlHYNfFm5JZts7lKu L42S5vJe+aWdouQCi7StdVJbgQqKKu8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of shikemeng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=shikemeng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689923372; a=rsa-sha256; cv=none; b=V+gu9GI6puchLRwjS2AlP9WyyQnlUIqOMw/mpku0LoZR453xCXARBIRPJ2Kji4cj6F1q6e h6c2CPDwq6B9jp4j2sXm5NspzGt2vaHGZvbv+9FteOnHOyJ8uo8D9Ndt/TmsGnrDNJcspj HzitBMVg0+0hhSSoecg2k2ds9QT4nNQ= Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4R6gZf0J1PztRTg; Fri, 21 Jul 2023 15:06:18 +0800 (CST) Received: from huawei.com (10.175.101.6) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 21 Jul 2023 15:09:26 +0800 From: Kemeng Shi To: , , , CC: Subject: [PATCH v2 2/2] mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint is set Date: Fri, 21 Jul 2023 23:09:57 +0800 Message-ID: <20230721150957.2058634-3-shikemeng@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230721150957.2058634-1-shikemeng@huawei.com> References: <20230721150957.2058634-1-shikemeng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 6A2FAC0006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jr8ff6xf8brp4jfa9ss1cmam9s9ja1zw X-HE-Tag: 1689923371-431266 X-HE-Meta: U2FsdGVkX19xTiCtT28YRnMmKJVNeKTKbYheXOswrg5im/xlEyvFO2DZDQXlCKW9kVWeLc9BX4g7yocjVSWbTcKmxJ7w1mqhGXQRVk2tQ9vunZ7EnA1rT67nlUOh83QEw3ZkP7HaNcZmYfxBs7Iv7jVU2JsDFnGdvuFGP2dz8QQ5HCXhdA8k3wgJJlLW8XKIHE0xzQqZyQ/UOfoVmXHpEOSMFDgk24kwDO8oSn/1DxLPGovfdnIlSceTlJW6hivMrl0HgiLhBGDOytMHGSEZVXaml9Rhu3+f13VuNmv+/jYvsofN2zdKP9vsqTk9MRQphVBWrSCTliH7as11NkiPr7WsP6DPQU/T7AGDfkLitSng8RTEYgEgXIh+xd5WNWMmFv6ULMpguHl+TIuFKvoU7kKZ5bcFIHTLRSydqP2DjbZtldjQeGYVOqptcPwUwad2tA/O+d36+qqJ+Rrs8L5mNt5lZ3nQ5WWqPuI/E7HwiIVmTliTtSfxvPCA2l7ummnJ5eFnml2qhsopjhxKMdsI1Lqprei50D4KhxRJP9GCfmBclDWgVrAX1l0/oMUmzrqhIsSNH1VTbAj59jcm8weQhXC/XuHBZ57wCW9/CFM2F74bNnrdp3XdcjVW0b/LwmMJm5MjCVTyAEx2CBJ8QcJmEsMJoy6ImAphyc+b6fPpNMjm6nuLpyHML9o/EB1WsiFEf9gghoMvs3PMisW3ghEP0pC+6CqZMNiAWeyzjFMNM2dWbyNxLxHf6qQ/e1aLB1asZgrJT5gUgyo5WVd36TfYCHtdKIeWwDHGQrJPsQOMnuvbcwCxcq+XysTZUtL6ZTuNTDGayOX1+WiB4X5ox6wgasXk2OeUCcVULHlSDRNKnBo+aPlM3rmyLw8TF5j6aKPvrocTeQ6IawihMwuqESMBPrmgDBkH8yw7o3OB9hYkLuIRWP3EAkIrVMlmdCC5Xp+u9c2MVC4+VKjYmKiUBOY p3+B9C8H +Ujh2dBxZTtGzxsPBGIgp7hEgzv0jBxDSemJbYNWKT/iiAgIwn3N5RjQWLkl1vbQO46axg1UdsgZLVOk035C8qStaQyQRvWhAC8GP2RTQNgN6gQWhrQL0ir6P4J/RN7b7WZMriamqvKSIvL/OYl8kuF+ssv6VvQ89NKf/7OtzaBTbNw0P+SbFvopCKB2elIYVDxaYvj6P5cLp61gQRHoKvbd9tvHFfvTxsqh9UP52+nKLFaOAMRq5uz0zQO0de+1wI/TLIuJpOlTB3e+sIfSMgkYqOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Move pageblock_end_pfn after no_set_skip_hint check to avoid unneeded pageblock_end_pfn if no_set_skip_hint is set. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang Reviewed-by: David Hildenbrand --- mm/compaction.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index c0d8d08fc163..9b7a0a69e19f 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -458,12 +458,12 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) { struct zone *zone = cc->zone; - pfn = pageblock_end_pfn(pfn); - /* Set for isolation rather than compaction */ if (cc->no_set_skip_hint) return; + pfn = pageblock_end_pfn(pfn); + if (pfn > zone->compact_cached_migrate_pfn[0]) zone->compact_cached_migrate_pfn[0] = pfn; if (cc->mode != MIGRATE_ASYNC &&