From patchwork Fri Jul 21 08:07:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 13321553 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB1C9C00528 for ; Fri, 21 Jul 2023 08:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NqcAnVxpvMo7IksBTYj7fHRMjHClyEVoFOPZWnp2zrc=; b=knZcX7idD2ZWNTLp7B+w3AmXZK xhAuT88JJe59g3s08zB8fdVP01t5t2OhL93EHDai212XRwa9im2S+IMFFkgTToORH8tlkTep2a6or F9gmOXMRw23MxAxjREY9+3g7aLi0mFyc9eZn51boUJUdmjKzycc+aURbpkz+55oTfMrQEM+XTwv+1 P+XHwtg4PWiphn0fRh9GARuXCy/C+veItlX4yUQOUBhIozLktqEc48u3sKCYVbQ5SpcrWtUYmS7F2 +WboNbdM2G9Qm8Jwd3rqBiD1naw63fys9mvU9eQUhsLSnGGlZwFb4B4xCa5LCFTo9LxWG8OgcY7+r YqZyLWCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMlBa-00DJLc-31; Fri, 21 Jul 2023 08:08:26 +0000 Received: from mail-yw1-x1133.google.com ([2607:f8b0:4864:20::1133]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMlBT-00DJDw-0N for linux-mediatek@lists.infradead.org; Fri, 21 Jul 2023 08:08:20 +0000 Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-5836d23abebso17453957b3.3 for ; Fri, 21 Jul 2023 01:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689926888; x=1690531688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NqcAnVxpvMo7IksBTYj7fHRMjHClyEVoFOPZWnp2zrc=; b=FiaLlQpG+FX04kcW5hPzlM69UWqegsCa8SHht89DbgfZwxyZ2NPixF4HZ+bjd7wy80 w0A2C7YWmkD11MfX3bs7qVweeGnF99K6lmjgksE4chTNdK2n/UggSDKHtaI5ZUbxNNPO 0aCkJQsa5a3qlFG5A6KhT+53F03Rt19zOX/BM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689926888; x=1690531688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NqcAnVxpvMo7IksBTYj7fHRMjHClyEVoFOPZWnp2zrc=; b=hWMt1JCx66Y7hcQJWXvtEd2tlifW3IJFCMoTl9SvWGSM+LVX9m9tm2pR8yHB5NQPTR UE2QHppzRcXowr8KcqEGos6xDFoPHOZhdnQ/sS2IkKufjeWTD8IsDvICfaqCRt6Dyhfu BQHlhQfsdvMKs/U3zaW8JARvg+3s3Y2rrnDdggk/uX8dYvPZIsMD6j/4nHhZWTz8E3N6 xk1XxvKUDhq57GuiHa6M45tEieXSeN59QemCmDjLD3ML2kw2j0MCm6lmrfb/Tt4xRNeT rhWmyWa9r6/fefb+3Fib75fDEty0lrmZfr/5wqMZUmYbkGtNOyaA3YQnixbI1zq3rcd/ Y1Rg== X-Gm-Message-State: ABy/qLaV/sBHitAsLMKka+L0b+lUtemM/M/AG8L74O9z1OPv7DicMVQw lRP5SG8lm98wXwbPPPQC7vr4hQ== X-Google-Smtp-Source: APBJJlF8D2kE/WLC7WdE8mYRIasoZYyBucxGnkw1pAE30KqjiBSmN0qvmA+xlqWibibNJkQ/CaUsYQ== X-Received: by 2002:a0d:d6cb:0:b0:561:e8d7:ac6b with SMTP id y194-20020a0dd6cb000000b00561e8d7ac6bmr1388896ywd.49.1689926887693; Fri, 21 Jul 2023 01:08:07 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:6d86:d21:714:abab]) by smtp.gmail.com with ESMTPSA id o10-20020a170902bcca00b001b850c9af71sm2740294pls.285.2023.07.21.01.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 01:08:07 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Liam Girdwood , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/7] mfd: mt6358: Add missing registers for LDO voltage calibration Date: Fri, 21 Jul 2023 16:07:42 +0800 Message-ID: <20230721080751.2012318-2-wenst@chromium.org> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog In-Reply-To: <20230721080751.2012318-1-wenst@chromium.org> References: <20230721080751.2012318-1-wenst@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_010819_176563_966E158E X-CRM114-Status: GOOD ( 10.83 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Most of the LDOs, except the "VSRAM_*" ones, on the MT6358 and MT6366 PMICs support a finer output voltage calibration within the range of +0 mV to +100 mV with 10 mV step. Some of the registers for this function are missing from the register table. Add the missing ones for MT6358. Signed-off-by: Chen-Yu Tsai --- include/linux/mfd/mt6358/registers.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/mfd/mt6358/registers.h b/include/linux/mfd/mt6358/registers.h index 3d33517f178c..5ea2590be710 100644 --- a/include/linux/mfd/mt6358/registers.h +++ b/include/linux/mfd/mt6358/registers.h @@ -262,6 +262,12 @@ #define MT6358_LDO_VBIF28_CON3 0x1db0 #define MT6358_VCAMA1_ANA_CON0 0x1e08 #define MT6358_VCAMA2_ANA_CON0 0x1e0c +#define MT6358_VFE28_ANA_CON0 0x1e10 +#define MT6358_VCN28_ANA_CON0 0x1e14 +#define MT6358_VBIF28_ANA_CON0 0x1e18 +#define MT6358_VAUD28_ANA_CON0 0x1e1c +#define MT6358_VAUX18_ANA_CON0 0x1e20 +#define MT6358_VXO22_ANA_CON0 0x1e24 #define MT6358_VCN33_ANA_CON0 0x1e28 #define MT6358_VSIM1_ANA_CON0 0x1e2c #define MT6358_VSIM2_ANA_CON0 0x1e30 From patchwork Fri Jul 21 08:07:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 13321555 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F3C3C04A94 for ; Fri, 21 Jul 2023 08:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VIWYt/VUR+LWe3Ym6ggQYemB73LQMpv4Ia87+08eNu8=; b=NsLRLUl/m6lgxQ9dLTlhaliqu2 X6eGONRVcLkDPgXnMDbnuJrhYIOJvn8c+HgiTD3LOUacb4wFC64oFcN/1jeFal1Cn+MStZsoz28bv crkx4BcvRXbQVxnSgPNnLkHaS3aea+VvGVXgkCbjE9vsQSyF/lQg1m4wpNDJ5vO1OS0wkPPqE15p3 PPnMQNGNl/fCZlruwAhcAI6KWyhXcrZlakw4e9ZZWXevfCLGMQJVGwfrAa6Av5me7iJFZMI3oyZ9n mIoPkspPNqrsddjaMayb7+ThLerokug4JAESxnk8mqj+aijxTke0db71BSo3CepqRU5eEU2ZKDx9M Qc4c7FnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMlBb-00DJMF-1l; Fri, 21 Jul 2023 08:08:27 +0000 Received: from mail-vk1-xa36.google.com ([2607:f8b0:4864:20::a36]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMlBT-00DJEP-34 for linux-mediatek@lists.infradead.org; Fri, 21 Jul 2023 08:08:21 +0000 Received: by mail-vk1-xa36.google.com with SMTP id 71dfb90a1353d-4814505ddbbso732159e0c.0 for ; Fri, 21 Jul 2023 01:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689926890; x=1690531690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VIWYt/VUR+LWe3Ym6ggQYemB73LQMpv4Ia87+08eNu8=; b=mOqIIVg9BcpADuYEnhsJwNphrOGgsZ/jx0kH+3BSYoXkYKZWwTzoWjv28ReLmi9Hp5 fu1Wwau6EMEiARv3e8CYbk+7qFAmYEI57cpZWbaGQn+h1+V3JoGukF52RG5fy7ltxenJ O1SF2oZuyLhxYpQ0yxCuGKxdEvMBZ1CGPiaN8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689926890; x=1690531690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VIWYt/VUR+LWe3Ym6ggQYemB73LQMpv4Ia87+08eNu8=; b=TSWut4D2zDrNK5EpdeObgQTSW0TYZ64lZxq0vOFXYiMln8GLKXMMmlAvs6WYiWdajE AueFsmrlZq1pn5BvNhCrOs0qmfdBjAWRZiKKPD/VxIBXHu3Oz/XR5EyKwDEQ5itiUJhu VPNjg4H1+XASgJmwCSCQixc3Q5zkQDdWp0/RRaRGc0IgqjWHUtZGVyWfIfnh/tLsYD/U NTVdVaB8zdyWRjHAWEFiJwEVRaXBUF0xSnqb0fxvPEv7gAlnncojCJZylB0K2EG0j0HC j8eHuK/pziKROBjbjUyTifwjaDA80JWIgKNuj0p+kuCU4lI4voAONUyB+ymBPRz92sJU +ZWQ== X-Gm-Message-State: ABy/qLZYG6JNvB5MQvWI6+fVo5RiGowUChXwXCnCnb+pVRux6UMvF062 geI4sLEXN9wEGLOKpv9qslyMFQ== X-Google-Smtp-Source: APBJJlEC5hPJcYbZ0l3QzrR9QVptQ1VIfzlcV+K0dtYmvtmyBtq4fo5SPB+MiPVbfac4ByQiUkzN+Q== X-Received: by 2002:a1f:3fc9:0:b0:471:cea:3d62 with SMTP id m192-20020a1f3fc9000000b004710cea3d62mr698570vka.2.1689926890023; Fri, 21 Jul 2023 01:08:10 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:6d86:d21:714:abab]) by smtp.gmail.com with ESMTPSA id o10-20020a170902bcca00b001b850c9af71sm2740294pls.285.2023.07.21.01.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 01:08:09 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Liam Girdwood , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/7] regulator: mt6358: Sync VCN33_* enable status after checking ID Date: Fri, 21 Jul 2023 16:07:43 +0800 Message-ID: <20230721080751.2012318-3-wenst@chromium.org> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog In-Reply-To: <20230721080751.2012318-1-wenst@chromium.org> References: <20230721080751.2012318-1-wenst@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_010820_011689_FE359802 X-CRM114-Status: GOOD ( 13.84 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Syncing VCN33_* enable status should be done after checking the PMIC's ID, to avoid setting random bits on other PMICs. Suggested-by: AngeloGioacchino Del Regno Fixes: 65bae54e08c1 ("regulator: mt6358: Merge VCN33_* regulators") Signed-off-by: Chen-Yu Tsai --- drivers/regulator/mt6358-regulator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c index 31a16fb28ecd..da6b40f947c4 100644 --- a/drivers/regulator/mt6358-regulator.c +++ b/drivers/regulator/mt6358-regulator.c @@ -676,10 +676,6 @@ static int mt6358_regulator_probe(struct platform_device *pdev) const struct mt6358_regulator_info *mt6358_info; int i, max_regulator, ret; - ret = mt6358_sync_vcn33_setting(&pdev->dev); - if (ret) - return ret; - if (mt6397->chip_id == MT6366_CHIP_ID) { max_regulator = MT6366_MAX_REGULATOR; mt6358_info = mt6366_regulators; @@ -688,6 +684,10 @@ static int mt6358_regulator_probe(struct platform_device *pdev) mt6358_info = mt6358_regulators; } + ret = mt6358_sync_vcn33_setting(&pdev->dev); + if (ret) + return ret; + for (i = 0; i < max_regulator; i++) { config.dev = &pdev->dev; config.regmap = mt6397->regmap; From patchwork Fri Jul 21 08:07:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 13321552 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE0BBEB64DD for ; Fri, 21 Jul 2023 08:08:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:To:From:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mjm1htpsgUdaRZcHsGo757GH1rkymaOgiUPQg9DWT7s=; b=DEN0oVtqsX6ZzE a696R/Kz5LH4kBnFZmS8aEbz6lNk4Otaa7URT1eqPeGRg1OrWrDynbFaPMLX9HDvxMj6uEh6nqZhD sITZO5oL/r3FBZngSXigmdiWLkg6CGvLqWsuXEcDpqs/uGKaH/u9c0RVqaxzb7GmN/Hp0Ee9Shyw3 3KFQQ23eQu9A5dyFUyXl+nkRrab5/TNboyoXKLC1rRBiGEwAKcgBN+r9uvnB/HgigwO6aCPE/4gRT 0Tc8tAE4IoSbg5cmF41WvAsPojCJ8/rGod6v2IFnbyIWXyXBkBVWfEhuXvDfv82+2LWzbybcDwRZ3 FfF2KbDSPRX+JBQ9Gdmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMlBa-00DJLQ-23; Fri, 21 Jul 2023 08:08:26 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMlBR-00DJFG-28 for linux-mediatek@lists.infradead.org; Fri, 21 Jul 2023 08:08:20 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-5440e98616cso1953945a12.0 for ; Fri, 21 Jul 2023 01:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689926892; x=1690531692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mjm1htpsgUdaRZcHsGo757GH1rkymaOgiUPQg9DWT7s=; b=apTJsacQxezIERIOQSQqwO451/lek2u8gXH7fZL0cfCdEDjzED1YDa2Baxbhk9Skr8 08FwwyQ/l7u4oL/MEXt8tamuL+5yYji/Mqu99B67oXI7wh9ZmE0PRft4CzhT55XJMN3A dwc5kMyE67C+0BtJfA5fjkXw4DR3dkg7NWXhw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689926892; x=1690531692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mjm1htpsgUdaRZcHsGo757GH1rkymaOgiUPQg9DWT7s=; b=lBQGv4jLkaFEEQ7p/V8FoJ5aQsg6lKqhcJATQhV0PUkNg/eZCjqH+GMjfhxNucpvPb bOJSmpyoLzw6vQw2sT0NhCu8IAi6INeRkGsr0tludyd8LGTdfWGrDFBF1k3aDCMgL8cY xoY5o50BSs0XAwOgoMrWN/T7N3BKIHi2VaR9P7pWVkIzqqBnMkq/mO7uHIxPcmSpkxjf E0kMtDc0jW4jGrQHoYDNVazhVZ1FKZ86YmI5Wzh0X0okq2PLUK29eIKfk6hCvEYX+4SX kKRYUGPScDkn1iEfu7QyCYP1t5tDyKvlb/IGKGNL9RuSD2zGFO2sLCeEwuK3iBBqx17W wyng== X-Gm-Message-State: ABy/qLbwQNzfq0r6w16aLJPk/AGzScVMacR1ml2KTRzolrRWWa4fGMPw nAGYCT/EOw16sdx1zV46wb8TOw== X-Google-Smtp-Source: APBJJlGIS3+ANIVcIUnnknjeeQ8DSn4sVGCY4o1XMTR9Em25tsTHbHUsOx8EeBzPhWHUVPQUYP5HqA== X-Received: by 2002:a17:90a:64c2:b0:25e:f696:1cf8 with SMTP id i2-20020a17090a64c200b0025ef6961cf8mr1951333pjm.14.1689926892623; Fri, 21 Jul 2023 01:08:12 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:6d86:d21:714:abab]) by smtp.gmail.com with ESMTPSA id o10-20020a170902bcca00b001b850c9af71sm2740294pls.285.2023.07.21.01.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 01:08:12 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Liam Girdwood , Matthias Brugger , AngeloGioacchino Del Regno Subject: [PATCH v2 3/7] regulator: mt6358: Fix incorrect VCN33 sync error message Date: Fri, 21 Jul 2023 16:07:44 +0800 Message-ID: <20230721080751.2012318-4-wenst@chromium.org> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog In-Reply-To: <20230721080751.2012318-1-wenst@chromium.org> References: <20230721080751.2012318-1-wenst@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_010817_694419_20ED64C0 X-CRM114-Status: GOOD ( 13.65 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org After syncing the enable status of VCN33_WIFI to VCN33_BT, the driver will disable VCN33_WIFI. If it fails it will error out with a message. However the error message incorrectly refers to VCN33_BT. Fix the error message so that it correctly refers to VCN33_WIFI. Suggested-by: Fei Shao Fixes: 65bae54e08c1 ("regulator: mt6358: Merge VCN33_* regulators") Signed-off-by: Chen-Yu Tsai --- drivers/regulator/mt6358-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c index da6b40f947c4..b9cda2210c33 100644 --- a/drivers/regulator/mt6358-regulator.c +++ b/drivers/regulator/mt6358-regulator.c @@ -661,7 +661,7 @@ static int mt6358_sync_vcn33_setting(struct device *dev) /* Disable VCN33_WIFI */ ret = regmap_update_bits(mt6397->regmap, MT6358_LDO_VCN33_CON0_1, BIT(0), 0); if (ret) { - dev_err(dev, "Failed to disable VCN33_BT\n"); + dev_err(dev, "Failed to disable VCN33_WIFI\n"); return ret; }