From patchwork Sat Jul 22 12:31:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13322944 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9BA2C001B0 for ; Sat, 22 Jul 2023 12:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RiZYRh39biUQD9bN+jHnXl1AcYQeLcbFJB2YJBcD7Gk=; b=vxaZ9qDenz0+YX VSFMfCfpHq0C0OzlAGU5tg4C0ZNNaDaEHLFB4PF+eQWHxgJs4yy202X7uDahSbpWiRL7s50WjeYGa diJ2Tu+zL/1FA13IAh77JhNX+cbeadgypAdmFg4CCmmE/qSxVCAL91eOmjvT4eeoPhVoP8VYaBW8n L72rH+AunobdmWmuLUTuoXG+nTbpZfr5+IqNQx5Da4nnBgR7/UcxpDmO4CV0Xl/xiPc9lIbA8myKv XwBeOYX5mjWhZjldp4dU+VO6Pkmm/9GHw54mu2luaazNQa8S0Bgg4VJnovqe3NKKR1qJbaWoxnqln N5AhCwaLRjXewS/J3jvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhJ-00GgIr-30; Sat, 22 Jul 2023 12:26:57 +0000 Received: from mail-am6eur05on20608.outbound.protection.outlook.com ([2a01:111:f400:7e1b::608] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhB-00GgEy-3D for linux-arm-kernel@lists.infradead.org; Sat, 22 Jul 2023 12:26:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cXuNFmm/su7wKEDYHSirc5eGs0CksZhLiN3XA1QpliE2Std7u6nwWJS82BtGMy6ty9t1UyFy1N7w9xGYsWDroMmnu/q72uN+20l2Knize5qxYI0RwvPXoUbMfJKTUe3PgWQBFXYUmmb37Nue6iCGlwdVw0ewUEE4yrxm24xhk+M72u3l0YKAjv0X4m0uLI/53X1EXli3bHNo0yb3YEZZ6rO/LNVGMya2qZzzdS6o54QExtelf9SsPRxlUD2X5O1xau6vCjq1oZ/wsYSRS+hEMvlKI/kH5sAn62Z7zr+fVugdtVr1XieLcd+sy5EwhNDjPK2uswWUJHFRbobZta3jYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9eXsJHj1jKik5zS42sb9oDfVAHK3/hCH/diRSXT4zP4=; b=R0CT/QTzn7SBsMd+JG8DAkG1VDpfxH1+R37mLVAJYf8ClaSHqf3bgMtOh3Lcxzt8ruSyD0V3PTMlaxge9eOkwVWQ6fKVlVyzbY3aI2HrsIiyQ+i3mpM6nOJCCPucOI/0GlyxIPABe3y3tl1DUoFIFL3gybz2rHd9rDGZM9gHlde3YPU9KdoQ1+fO7wYVInHOaxlkouGtpnSRnpxUrfnIx0BySGRr2YRBIuwfh5TgEVwZHdwHih14yQfUetWJOb34gdEfD9eTTXCfBaGraZzhd7OFVNFr3VEiaPUmjU4uFv+dCefqc5ptAxDnMMvu1xQJISIrGHSv3930hSylqg8iTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9eXsJHj1jKik5zS42sb9oDfVAHK3/hCH/diRSXT4zP4=; b=GomxHV5s4SGCeHCMakbDXFhcdeGAj1w4EiAAf2pyfmzjwXc3dWfj+WwD8A4sdQb9YQuZwblfBrloUmeF6FxIfbZuy16u7Lp+u9WnqdcgXMIqT9r6cax30xzZXHtyj4wv5fCMjdwLJcd6qn3oM31rzKlF4xxz61Qvse7C2FY+8x8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9461.eurprd04.prod.outlook.com (2603:10a6:102:2a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.30; Sat, 22 Jul 2023 12:26:39 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.029; Sat, 22 Jul 2023 12:26:39 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 1/8] firmware: imx: scu: change init level to subsys_initcall_sync Date: Sat, 22 Jul 2023 20:31:12 +0800 Message-Id: <20230722123119.1966998-2-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230722123119.1966998-1-peng.fan@oss.nxp.com> References: <20230722123119.1966998-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR02CA0129.apcprd02.prod.outlook.com (2603:1096:4:188::19) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d0d570d-eb2c-468b-7b17-08db8aaee62c X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dkK+yz1e+/JhBrglxEWLvfmmOlRzBJHFu4s7tN4GEc1uICF+RoNbtrEr9d88VWcGoswDZ++s3jJPev+e8IG1huXf7p5ycZ5pWgq/T98wDjs8POztR+3Udt7R0SuKuZDCbU+FxD6Ibtyp/xMDIyybPLv8OJuMgxQOX16+BqLS5Qlj8fDLKASAal7L4fIvNQ/ox0ZZpQRpm8MgYQw4l0Pyrm0MygkQXkn6gn8mFPDWFEZZi5WomM2932bGVodLAilbYVPlAwrnKFC6a+MrlALdlzCWxOyQQ2kGDGIDRBUm69wJRBCnGL4Ra3Mm94xcIKwhlpMgZx4v6dG0fFXdnaSsL34ZhlgoihRCMaR6Wt/Gkzg2QUw4xR4ywewWNALoUr10jPkDLoX+n3w2Av7e1oXbl3ATVhrmANkjksAPb9+rk+zRRmpE/ZTQdALliqmfTSjJXKD4uC463k074i8iIxruxI3I8kOd5Skf5tP/j82l0/mc7hTAq/8dMzQNGL764audcnsqUEj12ZSDzAQWNAdKGpql4oFqEZMKMRnkPl+lX+5008Dn2cBvsZcdbyX5IXDNIkdwBTLaGftgsnQ7xUMs5SwL0k2hiWCD9TyiXj4+e4ckyH1wc5zG0MGTs159cAOf X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199021)(38100700002)(38350700002)(2616005)(83380400001)(8936002)(8676002)(5660300002)(478600001)(66556008)(66476007)(4326008)(316002)(66946007)(41300700001)(26005)(186003)(1076003)(6506007)(52116002)(6486002)(6512007)(6666004)(4744005)(2906002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LLl5xYvQhSzT0XSdXKNe8EoQUW3iDcWJvli6i16e8qEXYF/sw4betFxHk3uUibghm8Nmpjrnp/VHVKMfMEybm5eDRB0LuKxilH25hPjkNwkDEGpgT914PYVbX86o5yJyvgEvSo6TBjhY1AKdNHelQu8LRbqAkeHpAItcx3uUg7/SklWWx1HTDjdF20UwD6SKLRhiyJnj58AnFzex37kAzMPmV3GecOg/tvW7cA7arDIt1D8A6i/DZkyMwWmOCfEpUAnJgPMi/7ZFTUjcgybTuwBsppjfWNTsd0ieAZjMncLY9E06ZaEK66exYhERn0C1JUtlIm80AFMl9S6Z5lJR70K4IG8Kjc2xH4i+xLLLVaraDfYEGNvTvebCIQ8QJ3m3T59YUcsg6KDMqt6AtH9O/OYVifbaSnXAYZcxWyvU2w1QDtqH+y5PfPQAAX4KlTSet9pxlJBmsvVtJvdagr3gFn7bP/YQN62aB3rU9MqDTZeae8lBBGH5j9qsRH9nHAjU+gbdzC6b3JZnlcXmemPCCxGO8Ob+8UDj385xAWDUOGtklkX6ud1ICrKZe8EHEKoIy1DQDBFR3z10f6kgaP46AYQIMJrDLPD1ItrAVQd/jzNGTPKlc33l3TLCA+Ot7/DMQYpQ4LnAXU229+MvpCxq9DScLxeuCfQ5spdHfLwU7b5DYJ9g2efVOCnscmu80SkJ+YLwiHeJOypZVbqGUBenMoje56xVDhc9V0MTXSX6hECZS4twaH5u9mCPd63VsfytnXOya4phbfBFZr+TXNlUGpFcmyeUVzdizEP4vCtcSWhTqivmFH7xvo707tTxZGSKiwB736EPyVIlIvTH45IIFxfWTzh1O36o/8cKEPLcpeAqj/1IeM5rNEopGVhs+6u6ZD7/91n/SJtr5fM2aLUtlAxgEl6roTMBj5L4wBg8rhlR1Udd/XicrW00CyJcq6pfDZ5j1kv0FMtxWpRzSXHfZu1IUynWjJZ4clgXMHmBWz5QzO644nOxqXwK6JUD4RGz+PnPB41OAsCm9Wl8ldJ5+PHFD7uPwtiPpLDWDPQGxcXbs0UvTPPF2HcU/UngUBbxyIS9OC7KYAyKnxuHNLJmyaVzF6CZ9BIqXnpD7gKxr23wMxdQOEF/hV9LSLTFZFmkyfFGYUt6mRDMqTqsF+GLQYnkPsA3Cpu8l8lfemQ64uQMkt/ZsBajCd/fKRggbewXPxMq43uxLbaPA0ckY6oSlu27xsYtKdPzJqzrwO6vB1cDnAIJBqUDH6/pGvXmTcOm3Gml2qGs2coliT/2xsf2FhRxapjwUe20zftazcKzno+ObwMNTxuO65ekY+8vgYNwDH+J14x742xEW3Riluc0y1nTg3PraZDnFKU5bcy/8tiZITYWH7yvK3IlsLuq3w3hJJalqQlMxmP/8h4h46Auk3xkVfiIQJLe9fIBdh0ffxSYwKEhepH3VOkfuMgNwLkqlGfDpY3veeXV01wMWgl/7x6rTokdaBttYL1uSaloia6vqxAloQOuxcrqG+ldnVkaktSE58P0kq1P3tgq9BH7YGlSTNmtGah1vIWHnWbzxnRwf4YY8OEXOjzSKk7vi/C2 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d0d570d-eb2c-468b-7b17-08db8aaee62c X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 12:26:39.6838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wyJW+Riw6a0iTUHvgKo9JXSq1d+Ymn/yaqlue3vwrEUNE5fh7Q576j+zV3EMsrju5JPbIWj1FZNfO+JLuKxGEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9461 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230722_052650_037148_FF7B8A6A X-CRM114-Status: UNSURE ( 9.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dong Aisheng Change firmware init level to subsys_initcall_sync to ensure it's probed before most devices to avoid unnecessary defer probe. Signed-off-by: Dong Aisheng Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c index 47db49911e7b..2d24359420d8 100644 --- a/drivers/firmware/imx/imx-scu.c +++ b/drivers/firmware/imx/imx-scu.c @@ -353,7 +353,12 @@ static struct platform_driver imx_scu_driver = { }, .probe = imx_scu_probe, }; -builtin_platform_driver(imx_scu_driver); + +static int __init imx_scu_driver_init(void) +{ + return platform_driver_register(&imx_scu_driver); +} +subsys_initcall_sync(imx_scu_driver_init); MODULE_AUTHOR("Dong Aisheng "); MODULE_DESCRIPTION("IMX SCU firmware protocol driver"); From patchwork Sat Jul 22 12:31:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13322942 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 445C7EB64DC for ; Sat, 22 Jul 2023 12:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7MkZpC4FAEJ04lt5OIy5u4rZz6liRiQMKijKTdilLlA=; b=dPFwBC4HC85Wg2 w4Mu27U0LftkH7GlZyXeS6ciCDx1AF6UjEqaepCRWpmr2q0zYrJweDiG8jpqWtERjTXFKagAUM7va 7c27TxsCqCrkPuD17iX+18w7FeRbaQRBP6d6yBWq6q1kMpSqsWuejCukbznvpXPfUI2ko9gk5LLY1 tuzxJrLGnJZC5yjeIbtpVhfvT0U4LYBKHQD+C/jDGmFufQaVTga/JCTF9lB/0NMqW3kwqUha4if3s Zn7/q9kWKK85cxYTMT0hUvo9FyXW3bxH0ZwkIOydB96RAQAMn6940+oaI/3LHhdSyms3JUeVp+QQO gXslxm6E+qnM3BiH4tAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhK-00GgJE-19; Sat, 22 Jul 2023 12:26:58 +0000 Received: from mail-am6eur05on20608.outbound.protection.outlook.com ([2a01:111:f400:7e1b::608] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhD-00GgEy-1S for linux-arm-kernel@lists.infradead.org; Sat, 22 Jul 2023 12:26:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ibp/LJKjpYYDnPKt4xc+r/mNLfXZuuJDXJSQ3PtwnH2Mb2kne8mSASYBfi+Gk/Xb9Qx7x075NBD9r8MxyxACBHQRyLJYR2HfxLza6PpNgS7LTmcPPVB4Ka+AWCOklCCYkrXtCNroZXtkcfmep3dkmcmr0eI2COHaHz9wF47+YZioVpL8hN53h0x5mBZCu/dvwOukV00tD/88bzkXh2/pxV37+Htb2wDfa7gQ4bhoyHp/btmED6QTNSjODkROrIfRTsdmNAM+7T2P0Tr3Os/iTRwCo17jegscCezXSqoZ2j8vz416zyk/l90qLQk3uuQGWKYUVvFrodY9JWACuY61Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DF948BRl8NffqmzXY2ZKiRJwHdKM7ujns57fiU8YtXw=; b=KzCeFzfy7jIoOgQiZBpa2HQA7zCrE6ZW63l7eL14awsNAVmoBbCZUfmiBvqVd4aNpCtPhVsQDtg+nOqjGLG4xL/3UheHLBlKGzPm3EIZeBRABuX+jAc18C3wpl3pNmSpuZM8f7sHhUa9dee06t/HLAIeGPo7xYtRlMvBXNi8Xza+E1XTxLBC+61Cnt8lXHa0Iy1br9lwelRF88vp+gxMmyXYzMALKKbqPCAGX2dpEoQgshhXmYq7UDviZi/zD6pqSzU9DBAnDIvpO2Lj4wYrE9L8eJACj0nF3JWOfZu0/+6IAaZLPlrfHZXAk+H2muBYCYU+2tUOo9cvBsvByawPOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DF948BRl8NffqmzXY2ZKiRJwHdKM7ujns57fiU8YtXw=; b=Dig0Xafyp/fVBSHOScUtlxMCrOZ0PxDYlFTOpu/5qiuzF3OJ3//n6tab3OtfWhpvExl/1kW8ypkR61PW43LOiWYkEpvBhxtK1pXq6mwRzZgUpS/DMpVOt2q9WJAuEM0VLSI2ZqWMlR9tyFvpmztZq31TdwMnwqeBF28y7F8vTkk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9461.eurprd04.prod.outlook.com (2603:10a6:102:2a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.30; Sat, 22 Jul 2023 12:26:43 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.029; Sat, 22 Jul 2023 12:26:43 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 2/8] firmware: imx: scu: increase RPC timeout Date: Sat, 22 Jul 2023 20:31:13 +0800 Message-Id: <20230722123119.1966998-3-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230722123119.1966998-1-peng.fan@oss.nxp.com> References: <20230722123119.1966998-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR02CA0129.apcprd02.prod.outlook.com (2603:1096:4:188::19) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: f2a8b51c-daf6-4c44-ea21-08db8aaee838 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ve0/grBC8ic12rmIiS3W2fdfrdX6wYcVNO6KOuXj7u7jg1SeUT4vfLFhIfdoLb7tORY0UIQualT3WYVzXgYQbs1BhnV0dN5Y/eJcu6RYJTnZvg+nL6kz33zZ2NS1GxSi0wHUmHky0tkIDsHgg+MxPLVfTexi9p9550Cnl3/6YZinVpCz5LsIE3WBoVvTUimdohzDpiNke2n2PEzdM1x0X6P9RvdaGOSLEKHHVZxgs3pb/mCJ6SbAA2u1gVvvPkks2TLKXxNk6kkLeqa+PhAj1wqv0QInnMSH7RJtDn73OiXE4gLqw3e3l+WnCsPZtiasM/CYXAIuRNu1Kb3WRaK8+lPyduJdo0RYGonYECEDKWRJGZfniOgXZCYuWg0iR45eJ1N3sYQlX9uPPS+ilH7O+3lBvbJjZKZA2CySjQblsXhuUQdV6euhZDItWbDGGXG6pLAB25SXMROKK5vTCMFruvuxGp6+KK4i1JA8tD/VW3CbO+NPlPPCGMcPPQEm86wMsjBYax8xmnAuTM5GaEY2Nc+6xA3PlOOiYSk4Iz9dUfZZQL/bPdJ8WLjSdFc0gsH3frDMDZFBjMMhyD+9KEU73A/qF7+lyCyBK8U1eu+pHszOlPdPEJucNvrOfGfWVREH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199021)(38100700002)(38350700002)(2616005)(83380400001)(8936002)(8676002)(5660300002)(478600001)(66556008)(66476007)(4326008)(316002)(66946007)(41300700001)(26005)(186003)(1076003)(6506007)(52116002)(6486002)(6512007)(6666004)(4744005)(2906002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Z3cNrbZzHKSS3WJ0Q4PoVBZKoHRbN/MoW7/d45lk/VcqeA4bmCeJZWW4xK7jmAekHDeBDXdwFuQlvYlEWIG33sgGchmD52e7xF85vOutRqViOaMNdpz5up6rH2PXd+V0dfmtgzqVTTz62lrYg563euI93C/PfmP6N2HPUZBFHdiBER52yi2uPn/Q44KLltxcbV09AbT3a5A28+7DwtkFlsz5c9/kVLqLUX2Lk5wkJ2WrLeTYxfF9YmHhq25ZCqK73rsO2YJKpzQ16GN0V/dJxXFlmlnfieMxyAqU1ejx0Ijsg3hz9kSGSljOaG7uWdNulKE5JRC0wdsMOnHKEEGVqadIHgoOQRZzkA+T65y3zWUWAh84OKEN/nhZKXUtaFgg3T2EvxASO/BZ7bhgtHKqY893Mi2LGj91XI8dhN7GfALgxpT9O4tt5M8aP+PdpMznTViutrCCPXttz/rTkzgCidhfW0fsSX6o383NkfvMabBCh5YoiT1d5NsjB08Csnrk+jVdsZRz+SKwmISuiiSz5dhYem1RcCG0gMXsdsByLNSSAlyWJWwskAxfYKME5zFR+hiFtiuvuy/nhGCs2w/OLrB+aFnOg9s8KPdGLf/iFQji3d5oKnyuOzGCH8kOfwqBzgg9XRzr18RcGpi2WCnNLDv5fygnLYmPiJBoyJ3RbWyvVP4eh6JWjA4iLkzp1ujAXu7qFOYIPxAmV+ZL9LQ1nHQtRtN8W9EGIi4Ex2jCICFjmo460RKyND+F1IzYr10Yrk/Vx4YNqDxGZvpSmyUBps8Ona6oaEhRhvb10882lNJsgB5HEQDTajCCIux+qNoO/mNgEzMPVbDEGx01aeuVOR/ffpKn4jO796rku1fxFFWw2dkEuqV03dXBZ1DPgWW47PdPY9lD/XcgcRLolPwSYCtVy1HwHWNag472iSRAktbAD7i7515eJj9InXf+YpgIFK298qpprS5Kb31EdG1pD2MAfGaoCCryh4WO2fxRfXomBn+zA5tDI5fxGj2OShG4uYvVMqlkPzxo9wnvpA8QM6vDKGgmQ81yr7ZIATLl0zL0F/Pv8XSFdDXqozx75ZySdZpDZ4Wvv7i/UH3RkWfqWPsoaJ92ejMThIG1CtseOL+ZkqjEjsOuSbZmYIgkGrvSIXnBafFzXohB5S7yGpON1b1oBc1RFBlZavBW9uc5LymbyOR+52H1ZWb5uYl/PutCAu97sOb0DHfJb4F5J1I2PI8vmQ/dc9tCfktwoITUJJmjkWwi5IkHouaaHndsx/QeBvUnj1wJOx3dgqX6bmZzLKIh9cQhzth0Dbykj0KQI9wlvCjG42v5tJzm79OD8NpXYi0c0AvT6tXGT2WSFKFXomp9zQ31+s2FCOA+7IUfMVsQXUQAPhchpLAIwHrxnt+ava0qnpBH99MMohAdCAi3U4wPuaK764NGeAzXAnh/7DJSyiT6Oxf9qXihztbcKk8kYloMEPscJcjb9awjbEoUL05ipNDelfqbJ1pOArZp4uyiNb8+lYBXWYCXqLd1HcUUFtuh4eRhsXXw51mmzsRQ8a4Yz2FWxKP/d1PZxw433EDDjifd1Rl8UqfgHUGu1A67 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2a8b51c-daf6-4c44-ea21-08db8aaee838 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 12:26:43.0950 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ja+bIdDABu8HTM4nkWZP4PNj+Eu2cOlw2C0KzUHwuaXDZbUvsGBzXhgaH90hvEo7LPB8GjkRF0Pj1Ak8JtmuPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9461 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230722_052651_494996_D1F9CD73 X-CRM114-Status: GOOD ( 10.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dong Aisheng When system loading is high, we can met some command timeout issue occasionaly, so increase the timeout to a more safe value. Signed-off-by: Dong Aisheng Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c index 2d24359420d8..14ff9d3504bf 100644 --- a/drivers/firmware/imx/imx-scu.c +++ b/drivers/firmware/imx/imx-scu.c @@ -20,7 +20,7 @@ #include #define SCU_MU_CHAN_NUM 8 -#define MAX_RX_TIMEOUT (msecs_to_jiffies(30)) +#define MAX_RX_TIMEOUT (msecs_to_jiffies(3000)) struct imx_sc_chan { struct imx_sc_ipc *sc_ipc; From patchwork Sat Jul 22 12:31:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13322946 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 422DDEB64DC for ; Sat, 22 Jul 2023 12:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+dP5ajb0adLYrT2S9IDaoipRqnP2onrNiUg6nWF5kCs=; b=0RY5mBTVKXBtma kdkUAkrzQZe2GqWxbHj25iTPkJ7cpN7T05cS/U3Su2Y4EzxiClYXULTvMg3uSYSuzR10W4Irff8sw llc/H6yrDZVilMA+FcmplPefqTCyLCKIjJ0XhGySO5F1x9meqJK/03OkNk0qjPx7Y4mOwSiXGbG7f cadnzrZcmgeIPI37sMT/rH05ZtgS16Ua53n8AtUqSFjcSAdrAh91YUY71zqosYJKgDwev+iyyTH/c ZtBYpguT5kYOCr1KI4XjORHWEh2Fvzx+ujGtJrR8g50YQckDVryZRhTA9RxQQwKfpdfXiW75FaFAc zywb4tb3tnkQL/fDSW3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhK-00GgJa-2n; Sat, 22 Jul 2023 12:26:58 +0000 Received: from mail-am6eur05on20608.outbound.protection.outlook.com ([2a01:111:f400:7e1b::608] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhE-00GgEy-2z for linux-arm-kernel@lists.infradead.org; Sat, 22 Jul 2023 12:26:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j8GP516tWs7XekKvvPjQVmJmJcpxiXK4VEiFNaO1uQmRhAbQ3JHtBCAJXGfVI9M/oTjWpFlxxVEi8Vk4/MfPZ3GpEY2qTE+I79FMXFDqLd2zvN/t1qgFll/iBKEK1QfdNVziFXChF5pLSxnfHySd53bWafcHR7JLKpHzc7lJPhOMa2IxkaIdybCgmcDK8CfV6/jt8XpZt5Hyab6M4qrF+tXuiV3vOv1vZdR74qBtzisppRBVSFUblR4a8JPOAYmTzYVszTp8buNfoy79MIDIbMZqJz1yp792I2bofrFsYUPjpRbZnvayuZj/0GKdvhLt3D0jpgojE1NIP/VPfLV0XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I1EaanuMVw3yN21IXzDoO2thxcz5R4f6468cftBXaho=; b=HXaron2imy8369WkkEduDW/lbUQNDpYGw124MMcT1E3XoRh8IP3MQpsIw+vcOQ4Mq1xedYEgHb1G7QnIo8WEcRSR9kAAP17+Qm2v/l9RySWckexMYiW9Jz1n5GHmfoQbOo50ON/YvpuXU6rcDY/bzKMLX87P9Uu8GtZzrOokMClPhayk9esH6QFpVXplfl3SGErbccYlMEDTC84MzITP3+V8dwHxtlQU/fo6IzzMTPBywYuCKWwP36xBCc5ke6oVQq6WdYaJbsaSchMVJru/xkuTvUopNwyjo813BcOzIrKEKP44WG4DDgWYMp7hL2YWbLbJ4CKHiUlBHAoBUN4JTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I1EaanuMVw3yN21IXzDoO2thxcz5R4f6468cftBXaho=; b=SdTne0RLVRj3K+oMIflmtK7XRS9LGZk6UPdgkqYTm/msyWknHIkWD3KJOk5NjQKqogPiq0j7ugZYW1HHiRc1Xyjs4WQ9GYiK0y9oZUhYc0j1F5BCrvqxPb57Ot5d1OEs2BH8MVCVFn2j7Fg2TkZbvB45RurPNOYxV4uxaiNtJ7U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9461.eurprd04.prod.outlook.com (2603:10a6:102:2a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.30; Sat, 22 Jul 2023 12:26:46 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.029; Sat, 22 Jul 2023 12:26:46 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 3/8] firmware: imx: scu: drop return value check Date: Sat, 22 Jul 2023 20:31:14 +0800 Message-Id: <20230722123119.1966998-4-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230722123119.1966998-1-peng.fan@oss.nxp.com> References: <20230722123119.1966998-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR02CA0129.apcprd02.prod.outlook.com (2603:1096:4:188::19) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: 21910de4-88e0-4833-f317-08db8aaeea42 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t69pgKwanB/5juoEdl1SdiTA0fjaQonfyduub18lFPUpyeXVLwJyTlChbwP34yU8mTbSTpKL2t0Xci4Oece/SVIoOqguP8QkxcQA2TRwbwd3bDfdPX1pY5Giu/dp/op1iVCyTZXsdLOYnSkqSMLTQun/ihyjnQqSoYqcbny44ytu/X5vor04xbxXxIshExPPI7MQWNS1qPo4t/a9PmgyarjftxZf/30yPIjKZmJlf8LGXgy9+F5KwqHy5pMwzO61DCxskttNzwAOP0MZA1P9CYe4EPwa/CT/wTKRVbItCLry360MKAb4yX2b+RWIXrOixRu0jSpYNXI0ieYd02DT6hlxlgjWgj2f6VZrSOTReN031hsrJw4a3P/uG1iFttdVDxahYcG+ZFC127mP+RihmZsnzm6AQjS4soxzKs8rmNPV2F8s0UJoQHFVMINul5HGe45W7SUAvTwQrx+45C6/Ow6IbKiw13xUQO3wYOioNsqFrj8S/wApTqd9otH46g5qe1GWH2oZyzhV4lvLlmkNE3gpCrxOtzyIM4ceSp124ZMGcC4X8AYtEmfZW/hfvkIe0lTYQlAI0EUCCQav5wWCxzvHFl8TYzOa/9kvjvu9gjuzYfgyjK8OIYlpLK/NemZi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199021)(38100700002)(38350700002)(2616005)(83380400001)(8936002)(8676002)(5660300002)(478600001)(66556008)(66476007)(4326008)(316002)(66946007)(41300700001)(26005)(186003)(1076003)(6506007)(52116002)(6486002)(6512007)(6666004)(2906002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qpSO267RnlGxWHiAVJ1mKzNseMPfHsrgSXJ3RmSQvfjm11Dpj9KWqwPGvkUa6gss5Yoqo6QzlD2nuJ/mOifte+Bvj/cggtK3lRHr+ywyY+9kXX2Yw7xIGHfxH3AuEUYxTVZk8JwPZ4pc8RmuroZN9E5ydFDQT16SHhI4v3TvhWi+AsVgi6m4H4oNofmKximGmursu3ihBSDtdS7GQLmDnoZCh1wXE7NrULtdIgnC2phuyBOd8lK4VH7a+67XCh5/hLMF7i7wOsMuYyusKTRx/y5JwsV9EGU8zoQ4w5da9b9jsB9UkKJVptzZZfyu9OjwZVKAItHVMMwBLr7FUYPp2FadooNk+zyAvbkSKi50d5Pex+N3IRO8DGXkvePmTNp8Naz531jxOGGg+JRqtASFAdfFBRN85C+Rcrap6FhiZBxRM+ubA7JrNp24v3s719kHN20FY4LwB9WHN2sBCEKEIA3pDZpyzkoOMldvdPGSs5cQA0ZNjguPcbXGs7GoZHoo3qbbgWq6pqeMrkGCCBdT4bZ485zPQYJf1ZvTy+7a+6cnk8P/D00wF6JZZsHezpZrtO84P70pVZBDMif5rdiKU3ByJ/Iaqv58kBeIDwSbFPPUP46DM9n7JpuWCDUUeMzV8OcR9Q+XRY891QThzR6+3yDlpKsbYNnUnpnRGEOt2Bw1cTnRVqEO7JnPXsG6Qe6mwiTjjLX4El5GEEMLmWigVIU/nPAnqmYUf3WONwvRll1KXSf7N+wToQjDd6tZn+0qjP4chIQc3zTOnpaS/ibi0qXlw1KMivVD8E9J7FQHtjSW8zLmhZWWldMDWcW05b4cI7q03foVLcnsQbi2oNIEhax13oVJtIs3xG94v6PN25R4j9ky94rPmZRXj7ZPzzRtxUGkCb2K8x5z443h3ccjhMaWGyfPZ9l4w9n7GUwaeTZc1FVtuWEkUT1pZB9MO1k3BTegrkeqKGqFDOKD7I+Yg8Tc6Ht3/0hbh4bfNvbavHApAZ67YUO7LyDlaVeGxXhVPvnlJcFQ8mtJKSQxxr6nbNgvvGyDlVrfyPONgVYjiyRGga3d18Qxy3ysO+YCZ0I/AWF/hwDNZng4NbZOcC/1yeA9oo8NgXqAs6dWTmt+KbS7xyqdj/odjWGKy7PbPC9Ld2sg8xQL+Fp1BHn6TOvYFwu92mOkdUVOPDCSpdkJdWzVJecPmhgfgUhQWS8VTgYXfwxawwemHwPsVyZYXnI6Lz8o+cE31aplc2fzfIkjZns6jV2ItmtnXE1K0rTs36wHmqG2Crr6OBzB4Q25Hb0FOC4goembxbiaKFdoKVZvZupuE4ot0z+3Y7j/j/sWHuXttf48E8YqDufCcoYhksA8qHXdvHjS8QmbMsdCuVrSml7pqJlJ+pn27KJlfKh9Q+IBevLHc+qkAXWqsTKktRoVFzwQDE2uNBNFtc6BOfGbiOjfPxhS4Te20w1uvG3aNcUrx7Sa7pELlHwdscdDFYRLCoT+JBkcpNWuMAN/1XxQzP5rNFMsEN25XU6wsMMdAt1vR667gxDeagQMNk7FUYkYjNZvJoZQmST6Sxk6mlYTf1RNGjP+yHj7O9o4lrRfIOvf X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21910de4-88e0-4833-f317-08db8aaeea42 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 12:26:46.5406 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xCtrtO0SQkc4Fl0YyTEBHWgP/YSXrWGAagJxvPOXxHZUOkg1G5yFziwl1uiFlfHze70WQ+zZP0Y6ibAWPCgbAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9461 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230722_052652_963140_6A202639 X-CRM114-Status: GOOD ( 10.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan For IMX_SC_MISC_FUNC_UNIQUE_ID, the scfw has a return value, and the imx-scu always return 0. So drop the return value check. BTW, also initialize msg to 0. Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-soc.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/imx/imx-scu-soc.c b/drivers/firmware/imx/imx-scu-soc.c index 2f32353de2c9..ef9103987e76 100644 --- a/drivers/firmware/imx/imx-scu-soc.c +++ b/drivers/firmware/imx/imx-scu-soc.c @@ -33,20 +33,15 @@ struct imx_sc_msg_misc_get_soc_uid { static int imx_scu_soc_uid(u64 *soc_uid) { - struct imx_sc_msg_misc_get_soc_uid msg; + struct imx_sc_msg_misc_get_soc_uid msg = { 0 }; struct imx_sc_rpc_msg *hdr = &msg.hdr; - int ret; hdr->ver = IMX_SC_RPC_VERSION; hdr->svc = IMX_SC_RPC_SVC_MISC; hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID; hdr->size = 1; - ret = imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true); - if (ret) { - pr_err("%s: get soc uid failed, ret %d\n", __func__, ret); - return ret; - } + imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true); *soc_uid = msg.uid_high; *soc_uid <<= 32; From patchwork Sat Jul 22 12:31:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13322943 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6770BEB64DA for ; Sat, 22 Jul 2023 12:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Npzami+3u5kJx2Al+uEJoeVfmoDINszgQP7+B31GIXU=; b=tx7ACrqjfBgmVi 2hMmifuEq/7EbDlSwqBewhOBlI5AKHFiQqlpB8hBZgMvQt9PfNjjLf3JBxNYBnF72xnt4kvwFNS+C Ly1kWCH2XohSN46RAThfSKfGJ6eW/UTkFRVgYxMYngZYFonLIdDGF1/cYU8sTFqdCRI1vvpPEPsFj izbvTuXSb1V8hkJDx12mfzKYBoS/bwL9A6e6mIXf1cDmiOMfXzMQHlKFne+PlAUid4YRou2T07kJ+ S2WSGAWUY7ZdAiw6mDm9JvZAXFEHAoUs3Rj+OwWGSRmrrkphOa0iaxHY4wTMAl01KIUoyScTYJnXp jFhsDq515re6IhJn2fCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhL-00GgJx-14; Sat, 22 Jul 2023 12:26:59 +0000 Received: from mail-am6eur05on20608.outbound.protection.outlook.com ([2a01:111:f400:7e1b::608] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhG-00GgEy-1V for linux-arm-kernel@lists.infradead.org; Sat, 22 Jul 2023 12:26:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PGT4Yylyq2Ixh8ScKvDPh5Alf9um4XFuxnZ2TDAw7MVwMMBcabCo7AJ+nXHGuMd9CV0c1xUfZGTUL5JFyf5S1wmnyuWAm2CwEZ83P061UYFxk/5Iz5VEkeYTclf13fGwery+ei89d8n3ETja08Fdk9k0SnCETFzzy1fuX9zAaMqGcjI9m+1BFrTjuJ/1foE23SBJUz/HsNuCPYowm5bjeSg4FZobp5YWCZn0qZgLbkpwfX1kGpflsF2T7YYZXzBJvqymr1b7kv/LK7O8qyGUlWOu56Rr5Ek0hLVT+toaiSfYtHztEpkCHQd9kB7XH1v5H8An+f7F6pRjy4WOy6BUHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oI4tLjdGvrvpQt5r0xaIf/zZnKlkwUrXvNkzmXrngp8=; b=VcRVsb4Egf277v5vu0shgf/wWm9t5yj7jCKq2k4J3FTXuzN8fZF5opn7CV1yfkDU8KTqnPGoblhN1XwJJh0igO/uq7THX4ysged+QNrYEllTrrbKd/NfotF6C3mc2OfjD8bpN0OO8ghJLuy+eRlLp3SbuzkstibQmkC9MEQ0cyP4xnql1pf1stafW56+I/snMBNEJAjLh43ru1++PPIpheFDepweLfcEjWx9jYldVqrX5J0w2E/BRP+sg0zOe0cHZ6occlRCrl+KGU139yg9I2RgOwsOfrzjS0mQ+dfZqF3doRIPXwuzFvfCqUnjjUuPkPlKYMrFVHaGSIVvop5YYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oI4tLjdGvrvpQt5r0xaIf/zZnKlkwUrXvNkzmXrngp8=; b=CZfh1ffGR+XVZeH/uVZIDWbKxb/y7Mc9Doslhis0jxqZVtcXA00cBxvnUBLJnjWxigbRpY+bngTW9HFGdqrHUXbaDFK7szt1Mr5O7eFfa6tMWNfGK0b73Se8yh7PbDNV5f+T0gzo+t2UhfzgI5ozCqLK5aPSaffwZKxuJcujzZs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9461.eurprd04.prod.outlook.com (2603:10a6:102:2a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.30; Sat, 22 Jul 2023 12:26:50 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.029; Sat, 22 Jul 2023 12:26:50 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 4/8] firmware: imx: scu: use soc name for soc_id Date: Sat, 22 Jul 2023 20:31:15 +0800 Message-Id: <20230722123119.1966998-5-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230722123119.1966998-1-peng.fan@oss.nxp.com> References: <20230722123119.1966998-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR02CA0129.apcprd02.prod.outlook.com (2603:1096:4:188::19) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: 38277c58-ee6b-4b99-6063-08db8aaeec4f X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oq460kv+SDADex3PeFRuejWZv0q6CBIeYD3pnTZ6rhMsyho2frhJPPHdwSztpc1I5LtkjJt+MebMScwinc33pQDEWaBwxjkD+l0tizKQCFQ2Gyiuk9ukuUEpCIZfZeLLTHF9sVqgM90By4eS6HQXOfl8RurbRnvOgMrGe58/7bVznIr9TPS0cKwfOkE9ZFNF38qQPaiawU0gTKhDitBLc1pW7FUSl9Hr13xG+Jyw6qvACpt5jCyIf+/zmVH2ao9UZ/d/OKDch3cGljZ4gWBLbBu0pmeIFBk7PmzWWEqBT54UGtZkF4Ium6FIqFZYuzNEBkS5Bsh3BbUXk5jfhcFQupPcvmFcE+WJs7tEmrB6pM0aKg/wiNRfMJQfA74darhu+DrI4VtdngeQ2WmP0e/seBJ9pma0uV8o8W/fNOmsWqdjBrK4PgY+/+/slsvkicbcp3SqS5Ix9DKH6qz+KRjYag4XzcSqNQyN5CnpbAJPJyWl+fNo1f4SsJ87w9owdK7qOlAMG6RS84OVOe4zjTQaZDjOFsFuYSnb2OD5zDuyIoRYOvpYGVpd+yVUN/Aam+74ZpmQPrc5aNQjErIpV87PP4ZWxtX5Sgs4wsiCWP+23Hotu7kjaTKM87fgRgZDnGDH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199021)(38100700002)(38350700002)(2616005)(83380400001)(8936002)(8676002)(5660300002)(478600001)(66556008)(66476007)(4326008)(316002)(66946007)(41300700001)(26005)(186003)(1076003)(6506007)(52116002)(6486002)(6512007)(6666004)(2906002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: WmRGsAdOUeC6Xx1jrFp3G9xabxcQAItETagq/U/TeD0FwxG0OO5rC8IWfOvqNmAMCO/xSO72uT+fWN9El/Qm0vcxQUQ2UK82GXh4WiV13YMs1VaLBD8mIzvsUhNdGNqFczqe1dzL/zQbstpG9tuzamy7FL9p8VUtsz2GU63UpFwHc1FYXCdC5kT9Uzq49f4AC95G5EU/fbzxKp+EzqmM8yqPrgmEGNTfGz2o9jNvcrZeNeBu9YwC2CmmZ9gLJDL4MLmo1vsV+uZPlCE/rzcljvi3U7oNvgKm7Th8X9HZDdt7YKHkzDw4IqWZ1zsO929QmeE4wvbEOM2Zvej0+uL/qJ9SasVP5aUVM/zj+pqvJ+gbIY6nZJyvJf7oBypaghAUtcL10tYWl3RYhdRQ3JyYiRyF53vpnbX8tuZA4ljJOpPkcpHqOI8x/EiFbY0/ORhu9l/Jw1IfFzwUIp+i5b7s7NFFi9iy4fAeRfYgc36h4zH5rKwc7d/aJyH1b6iLKPf7BCNvESyar8VDp9mhL8G8OykuWttd6FQ/4rzPAh5kHedhmCufOt50HyI2x1pkweNo8vAdmpaAbFMBlQiwtZTGQacyRDGxl0xstaKkSSV9RRltSteF4+d18Hmws0iOsNjTahHFwd8VytkeHc0tTUg85ZMi+E8AMmKMxoTdWwR7pREtuFnMPAHa5KQwjBCQSqsH0pXmpdo8yC/oPyjNFfrOelOc9z2lP+6tVGTiut+vxsZMIEeyzBcba3muML0eAJaeqwNP1jY58z83UfKCn3/7KY+WS0XkOxfWlUoL5qa0izew7VhfhZ8JxssXnq+Pz9iVVrwVwXMocX8RMNDXt27F15N04R25QKazcdwnbjlcbMRH9rs4SxGsSCxEN7EmiKMn3PHDPWQQ5xkt2lEn9GpU/h+NBP/jetClVMEsmTMuIjM3Guq7byDkdxXOXT7z1AONp7CZrte0gn3npDB+sxOF+HTrohDCt45pKDC+HLw9f7fKzVKV08/rSTNSDkE6SrrVKRm1t/CgxM9n76oUtl9BhAh6if1x0yFUUhIgnDigRpE2mdjPl4A4HQXs3ZwausWpDfUQzSZ+2MoJ4ntctNF6Bma3JPdCUv+9HE+SuqH0htn/QrdjIYSEQ8g+4pti00S/DaNr/FArFr6VtIgOfK9YuJHu1S/GHya7OqzZYXIT8VIj04+rmwROg7kqF4G/Wai6HFqdq+2iJJEdWcmXYG78g/gExRBtxjTtM55YDUVwsYK02cPD/kC2a4Wer87QVPG5w+NOIljcjpQJBIR1DFmUsm9daMDKp9DRdQkvbboRL91BlHSu/+37emgFzXZ3BnLqcjj9Etuhn8CE3cNzT1Js6gEH8Gq46d1S6N0S+ClcHiU0e1jndiuJns2n+16WzJXdGFlDgsCOysNpkD5MfSoN6PCNkovgxdPVMhZejBRGgb8NlA25F/sLVuSRF3BpkOWPlLvBwdsy7zhN0miZO2RZM/K9fJCeUaYzuBeXNM2FBFw9NxRkUwp/0fcHtYBWCg56vVEj63T/aFSrbFiXlXlXsPy8Jk0KqsA2A1Hlyp+xSk3lbtdFBpEedQVnsh0uheGq X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38277c58-ee6b-4b99-6063-08db8aaeec4f X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 12:26:49.9945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OzZeNCQQvWHn2O5zKl7QRT4BE5tsNoWSDa4QqICkTBc7HTqwmIiem79yqL4mYbypCPbS/SGPFeY5/vo3KQ9olA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9461 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230722_052654_506307_F3969F47 X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Same as soc-imx8m and soc-imx driver, use soc name for soc_id Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-soc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/imx/imx-scu-soc.c b/drivers/firmware/imx/imx-scu-soc.c index ef9103987e76..cb8377670a7d 100644 --- a/drivers/firmware/imx/imx-scu-soc.c +++ b/drivers/firmware/imx/imx-scu-soc.c @@ -107,10 +107,12 @@ int imx_scu_soc_init(struct device *dev) return -EINVAL; /* format soc_id value passed from SCU firmware */ - val = id & 0x1f; - soc_dev_attr->soc_id = devm_kasprintf(dev, GFP_KERNEL, "0x%x", val); - if (!soc_dev_attr->soc_id) - return -ENOMEM; + if (of_machine_is_compatible("fsl,imx8qm")) + soc_dev_attr->soc_id = "i.MX8QM"; + else if (of_machine_is_compatible("fsl,imx8qxp")) + soc_dev_attr->soc_id = "i.MX8QXP"; + else if (of_machine_is_compatible("fsl,imx8dxl")) + soc_dev_attr->soc_id = "i.MX8DXL"; /* format revision value passed from SCU firmware */ val = (id >> 5) & 0xf; From patchwork Sat Jul 22 12:31:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13322945 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F4045EB64DA for ; Sat, 22 Jul 2023 12:27:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y1v3tR6nqJzT1TlcythlxQwqICt/LeURBH6aCuhil3M=; b=HAut+Nb4tXiJ42 QZNn5M7U935jGdngMNNEzr3eSbP51JwWXQj46EL3aqGWP+Qi/pQpOm0Wuw2YJbpOAHiVL3ELhsFQL K+a2XeWoiAKUFmg2DrRptkVb8KkD2pOK/ICW5qwTy1bInCIg4+sqiRhNHVuL85iXHrGfvwVqz6hkO W/jL11obbq8FlXdTo2auL9T00ropt04IeFyAh0G2drMPgIq33J+jfK+dfeVdYp7hoW5k4gDlmppNP XPD756UqduYNfjgJowcoIezW8N//sNBlibby5wQTSNEjKtEEUq4+Ch0uXD77Ovmsf+s/opHlhdRLL 7wCcEiKB2WqFpOyv6/Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhL-00GgKI-2i; Sat, 22 Jul 2023 12:26:59 +0000 Received: from mail-am6eur05on20608.outbound.protection.outlook.com ([2a01:111:f400:7e1b::608] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhH-00GgEy-33 for linux-arm-kernel@lists.infradead.org; Sat, 22 Jul 2023 12:26:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WxDgZMyy5qm3p0C4dluQZm+RK5K67VJHi3MUSxAyQdcx8209KIrevQiu46LiDFeiOc/y2kGsDq92I3K70xTxh1iZ/bxK1LLAokiPqorvkzD/brEPnjTKQtl+SOP1yi/XAQSfw/TUYO/H5LR3Lsii6bbljPC6/ISY0LQ1NY07VobiGhrsIwJJOlaU8GUq8moCCE7ErGahCcJ5I7AakK4lzYtQr4ZLPEX4Q0vTjg7jaE+m15FzpIB19qZW5Xuq/NfugxfwecU6IWMYxJZQLeSEOPTm/8gE+1iElUWo91PaRQfV7w7MqGXTP8MzmBSPPHPYlIsUT1GPs8fALkN/cXO5yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=umI6ZrQ15cKelsFX67lK86cAvVI5zNZJ2V7Gcc2eaAA=; b=lo689X8JdvmguXy7iSenZpqT/wQ15c+V7LjAB7fHuC4gWxvjZ/JO4LSIq2sx6c9Er7bzuq0YkvtxZ7OnewAEWYwSuRtiPhV9unppraTaCJnQUTkgjr3FTvcLMqFH+1PLjAT4QO3JLxhGYJPq9+qLB7Szpp1aYZJWqw7XQ3N6Bh4WDHUEw2sM35upzkaEtRV3sDbpEVIDJME2yl03FGBH1wT4TLfrM3G+cBcrkkUYL+OtgWtt5VQGqz3F+3LVH4mk2mhqv+bnu6IGedxaLWcFT3TH/PkO87FXRYL3hJobyQpIvl0EKYmbyiqTKSoxrXGD1HoM0t9mgenHSCdHD+LQ+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=umI6ZrQ15cKelsFX67lK86cAvVI5zNZJ2V7Gcc2eaAA=; b=XKzpYB3/v8tiLYQykRyWEjMM9ZfLlrCOP3iF1frJLLw5oHvA3y5R3xrPY3obtjwX1O/cV6h4JDIbj2gNzjwXjVludzTUeE3CAACTZ9zzom0mm7y1IcknhX0nfyJ0k6s/Y4lX0Zw5LGKYcR+M1h6JzGxGa/RgmOyhQ7cNf3o8n2A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9461.eurprd04.prod.outlook.com (2603:10a6:102:2a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.30; Sat, 22 Jul 2023 12:26:53 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.029; Sat, 22 Jul 2023 12:26:53 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robin Gong , Peng Fan Subject: [PATCH 5/8] firmware: imx: scu-irq: fix RCU complains after M4 partition reset Date: Sat, 22 Jul 2023 20:31:16 +0800 Message-Id: <20230722123119.1966998-6-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230722123119.1966998-1-peng.fan@oss.nxp.com> References: <20230722123119.1966998-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR02CA0129.apcprd02.prod.outlook.com (2603:1096:4:188::19) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: 36b85a33-f8b6-411a-f176-08db8aaeee81 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MdfCNvBXux37lpPU/wl+b21P7rPY3rxsNNApoJPSpAKRny5WBXYZ9Bmswitz5+TClEH7BiH587VxmB8DFpnAC5FH+KEtGpyIAQKmiXKjp+YwjhOuSXHY2aDZCeByCrAEc4QfiKGrqNURN0tl/aV6kmEgUYO7iXvGBBbYMHVGBDPTLQm4jt+bgU/ILmx0JmezyFpLqFhcIZKsEPUbnpN3HB4RRSPluVQSBfL7aNeDmNSuPkvi6ejxijrwq1ojaFNpvD/twJuS0D/eMb3Bf9q7901fuctJSr3OpCRV0Jj+VEttrqpWPRNdc8HTWVGdhl4YHzQDDhPlgg9nj39XwI7/kx9ts9ibpbNla9qNWgQJpG1eY0D8nseXJpyaZ5L6uN4775p9p2OiEeb4ijauDfEgof7D852X/a5xrM/pMdxRXyKf9e/n/YedCRiHdqxG21HR46NizzLpXh+Zmp24a/EmAo0hk53dpmdC1Xn8MhTtzkGAgHwow+zpUBXHN3BKoKsUd20I8l5upx9QiwaBnxMmGfrLrcyIyVFygHR/pQHwkJjBWkpqmVxLT7ZKZmXdLhTFxDBTXN/iSHjRHepMT2WeJg67XjMkdl2ITsuKxHIcQiGik0dyYjMBFyNpq9v1A51+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199021)(38100700002)(38350700002)(2616005)(83380400001)(8936002)(8676002)(5660300002)(478600001)(54906003)(66556008)(66476007)(4326008)(316002)(66946007)(41300700001)(26005)(186003)(1076003)(6506007)(52116002)(45080400002)(6486002)(6512007)(6666004)(2906002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zk53eHLUbzJWU/R5tVzqPBDa5LusdLxtRe5B7rPkWC6qD55YsnvmhTpEJGW4SXmVJ+d+I/ybRMi5lPTKKyvPtuiDaretS/91ytaPpUr0N9TOK4ES6LoodByX1pWe8QPCWCkep2pMYRj0qzgvRPC4yF+v2b5ajHRJFiyA4q8u4EOtFDu+iDTAOHhpidMOlJYGcQNYYTKXFKlYlZ/8k+TeO5v1YCx80T0Mc+hcmBzhESf1heYKnlsYCR8i/6Civ3YK+J+7/XV+T1WUr8vn/FZQV70/uvpzU3auLmUlUxcrn8j/JBj9jdXMWWbAyzVpWX7pxNXj6bedXi/h/mpIPyQHyLJKnXxvX8EWYSow7edkYbuK1l8jB9lCtNJVZn/rrDQFDRYGwzCh2Vi1V3aHYQNM9W32xKldO9DfhfsIbJv9UXriczExvdelv5rbJUR7Ou/c9fs0wHNT97ASHZhN4bb089EiPcliVoWLhjH4yi/aH3SRPJmhSHALtggdZliMWjPB5pdHPKNgOLlXKx0RlFVME49gajFCjRagjrd/rGNarLRB1Pcw1MCEPvg6YSeE+HROgv6ETE7xWly0GBOnbUqYVkcRw8hu0jrl6PXNiyC4ns0/VnyvVM1slnXjohe5H10fD92vJSPjQ3cmhYwkxRarjZciR6X2dFnJSWQicNTbG9GFP3C0T45JnpdF8a3a5hpBtwUlOZsoG/149rAyOHuNqzakrHz63bypKKEo7fzQrfB+ueUUzBUWvUbNyJBGtDUBOwSo/2LU3mB6Gj/bI/GuXlVJePSRzSpmI6AcUzXEo1Acx1XdDBdzn8ptq9xIqJOiu/2ygftXtXJR180OAc1ilAoJ50mcx06aEweXmgbg+BPK0vBFp7DafvWd8ailJ9QPyCgV74aJXyfE4bezX0vFsVBKoykP3eWnOf3D3S+NK2fL4MJ0ovBG/kHMmG9jhmcbqD/xEjPJqPr5AntW7OGIkVSSjshHXSaOUOu1zVkGWTB2tdObnUSx/LlWHxiQg1y0QZfcFOHNbVrCacr3bqugacKPMH47L78o1NdLsM9VBX/p4sTDQzwnnEV43Sv1BQ10ZHLpwHzVj+8243gFDSg12phYCQHEfuCSDMgeJqhquzdCfZOaGAMpwokgw0zau0OYIvVmRIy+K0+QIqZ1ysKfqICUOWcR+1eF8ZtlQqgGwUiKlXEFyfKsL3doQdlG5mNcHnvABUUD9te815BOlz32aP/4VpJ5NM7H5IR8k3x9LQhM40p+F9GEIHXub103oeywDYV/t6eIloeROHmAZ+3J0kCe5Ajg2pxhhtdI3FMPZXfk8GAhiWQxAYl3GmjvF4qNbH9QUWp8Jq5ZgT3Yld7D+VDkU0xTa1OE4kW1ImzfAVjtKzq+tXGniuD1dvo/I7oP35ak6P3O3j+TpI0qqvuwjEkjhrIZIUMjTn0SJfm1zn6yUej6aLUzowbsBMHh1PihqnCjBqbzkKAMQrndGVmGlYc1irNYEKid/ZoMD7zp9CBKA/RiQAsnPBWGSX1hDsWCSmaKLGOGqA4jnPX0IizXoISV8wZi6RbfOuNeSB4CGv+EE0AwstTgy/Ml4otp8+FE X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36b85a33-f8b6-411a-f176-08db8aaeee81 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 12:26:53.6389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DiZ8Xy+LFPhcPQTkk4CPrp2nqX/JyN7BAIdytI5siSopBuOqPGAlCbKCJ3WvRG97yRe1qqoM0CsVnBxxfQnx1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9461 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230722_052655_986212_F890D9BE X-CRM114-Status: GOOD ( 10.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Robin Gong Use blocking_notifier_chain instead of atomic_notifier_chain, otherwise below RCU complains would come out since unregister/register_virtio_device () will issue mbox message (mbox_send_message() is blocking) again after received M4 partition reset. Actually, no need atomic for notifier which is so tough for user since this notifier is called in worker instead of interrupt handler directly. [ 389.706645] i2c-rpmsg virtio0.rpmsg-i2c-channel.-1.2: i2c rpmsg driver is removed [ 389.767362] Wait for remote ready timeout, use first_notify. [ 389.774084] ------------[ cut here ]------------ [ 389.778729] WARNING: CPU: 0 PID: 397 at kernel/rcu/tree_plugin.h:293 rcu_note_context_switch+0x34/0x338 [ 389.788131] Modules linked in: [ 389.791195] CPU: 0 PID: 397 Comm: kworker/0:13 Not tainted 5.4.0-rc5-02977-g08f78722f07b #26 [ 389.799633] Hardware name: Freescale i.MX8DXL Phantom MEK (DT) [ 389.805481] Workqueue: events imx_scu_irq_work_handler Signed-off-by: Robin Gong Reviewed-by: Dong Aisheng Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-irq.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c index d9dcc20945c6..4408f150b3d5 100644 --- a/drivers/firmware/imx/imx-scu-irq.c +++ b/drivers/firmware/imx/imx-scu-irq.c @@ -42,25 +42,25 @@ struct imx_sc_msg_irq_enable { static struct imx_sc_ipc *imx_sc_irq_ipc_handle; static struct work_struct imx_sc_irq_work; -static ATOMIC_NOTIFIER_HEAD(imx_scu_irq_notifier_chain); +static BLOCKING_NOTIFIER_HEAD(imx_scu_irq_notifier_chain); int imx_scu_irq_register_notifier(struct notifier_block *nb) { - return atomic_notifier_chain_register( + return blocking_notifier_chain_register( &imx_scu_irq_notifier_chain, nb); } EXPORT_SYMBOL(imx_scu_irq_register_notifier); int imx_scu_irq_unregister_notifier(struct notifier_block *nb) { - return atomic_notifier_chain_unregister( + return blocking_notifier_chain_unregister( &imx_scu_irq_notifier_chain, nb); } EXPORT_SYMBOL(imx_scu_irq_unregister_notifier); static int imx_scu_irq_notifier_call_chain(unsigned long status, u8 *group) { - return atomic_notifier_call_chain(&imx_scu_irq_notifier_chain, + return blocking_notifier_call_chain(&imx_scu_irq_notifier_chain, status, (void *)group); } From patchwork Sat Jul 22 12:31:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13322947 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2371FEB64DC for ; Sat, 22 Jul 2023 12:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Vxp5AfpM5eXLolpVaodTcPdU5cFKJF8VJCy9M/8KUc=; b=OBBBLoROee+knq 2uIK1AlMcjP3t6h5tRmhsQoaISiRKAAXEzk7DKvtWzIaGJerkTHozLcCnYOCkrngoqXttQSovfyOx /Q1RhBklY2+hDXOQOl6PdjoHWKur5gbjYAQFW9d6ZpxUFOAbF7T6SgZQsSXiG/VZAfOBxiX6TW/2J giQ7s8N+BKYBeaQfTp4VBEmMdOvl1OVHAbIakia7DDzFNomhJHgEcEvbbZ0P+nx397WFC8arIsp67 vivx4n3oKJBkyL7OLqJ2fkzpDqHlkLvi1JRo/qZHHdIUvzwNYTRyeqj3KwWvYcKOWcbL+fwEoIRv3 /qwh+NOm2lJw3Cnxin7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhv-00GgXl-1Q; Sat, 22 Jul 2023 12:27:35 +0000 Received: from mail-am6eur05on2061a.outbound.protection.outlook.com ([2a01:111:f400:7e1b::61a] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhU-00GgMU-2Z for linux-arm-kernel@lists.infradead.org; Sat, 22 Jul 2023 12:27:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pc5zN7OaBIMNSqcUqOvwy1+KW20VROA1vAOHT8Vb1cm2mz9mzXfwcm5VEAK77icGStWsjWLRUZMSEjELzhXGiLSLMpDxy/yZF1CMu1BF4+lmrbMd5bXC+jxqVNVQqKvZrPGx5kEteNOCT/Fwgfi8cSOf2UTU0zZSg5d808jJXMuLJPvI+kectfm5rOqYDvqdFcJoSGgVSHo2AmZNzzb6mTh03uP0T7prSXpmvwjIlrY6cSEYDfVbfkBXe8+JwsKksAg6Cvz52kden8CYAIg6X+Iu4Dwyf03FR4fuotTAwVmfibA3nKxVMHyHTgjXIFgdq6OZeaoKLicGAQDa91Rxgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Usntcsf9jSPDXtSzDmufPBCJAQO95nl0cPYHpk6bmPs=; b=ARu1rgc9Jo7MXqx4F3oIyPauPWdk3/T/F5emFQQtckhiyNCRkEkIQ71tT8ul+q9/EL3c1x6l9ufHiNuA/M0G40LoQkfMyZsACzdH2FMJRc6Ys7bMcItFwARt7UcvWTiwKAI4icnsHYsZFPST5goi9iy0P3UleRZJiGCIySxDgycjhBv0ujaQpR8nOBSzHh6Nn08WV3V9v9ccedo7ENpOHdH9oVVXq6HFJdthpr9CceT6HZsjubKaLu/rZitUP/FrCBpU6JOVhvhquLV6z0gxACNCV7SNDuJ4oRFj3K5TKQqbntVkKkE4uPPPcz06QF9D6k7Pn/531PF+WuKwSf692g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Usntcsf9jSPDXtSzDmufPBCJAQO95nl0cPYHpk6bmPs=; b=Kflfshuj0X8Wi2r/0vrko8DtGbZDDdrtcYRedoQjd4Fq7Z4+Vrxu7kczoDrdsmzl46v7CgD18s5NSBMaryMOvjTVyth+sIdiT5mZWwGe37zjOaEL9zNLlLg//HlMrg6+SDtqmWZxzfO1Zmun4iQrR6Xkv1MDJFRunR2hL/iMzBs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9461.eurprd04.prod.outlook.com (2603:10a6:102:2a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.30; Sat, 22 Jul 2023 12:26:57 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.029; Sat, 22 Jul 2023 12:26:56 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 6/8] firmware: imx: scu-irq: export imx_scu_irq_get_status Date: Sat, 22 Jul 2023 20:31:17 +0800 Message-Id: <20230722123119.1966998-7-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230722123119.1966998-1-peng.fan@oss.nxp.com> References: <20230722123119.1966998-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR02CA0129.apcprd02.prod.outlook.com (2603:1096:4:188::19) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: bacb19be-be09-480d-9a30-08db8aaef089 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qCch5sxdL6Q0/UZ8RC3xIKwbSb2+PxXRzXfaBSnZ3j/Hxg6BQC9OPLh7bj9vUTdo5r8/Xow0U2mxxIWQoxn7A0GxWslBt88WHl9/gXH77vRrHnp1ANoOFF6LIQwHvu0Tk6ONWVJpu0Aa+bMiR+gT+/BTvYz7qI4OqkEXH/59glcOM2iosQzQtJat0yQTHE8ezALld9baMqT1NltS7VHpA6x2BkBL+fpP/SQXlcLVtDf0tHDoOKgF2IKyZylLk9tTKnIQfJ9FilQa0lwR7rodwJ4+byid9H3rPqXEd5RVgINf4u2SxMy0z1Zz5ueN3BQENPBBtaUf+mpHKfKpjNnUqUKDnwFNL1XLBGVRIlFLcCAnDEQ2eLiKK2CkO+BliMiiqatn8TFP5u7/aIAk0PHGFzV/M1iimVLuSQmwsH8uLO9/CO1oTEYfxfHiofYNnfRX/1L/fgHMN3Ky8SBncwpCB1/zfcjz8oCSBnp6JwNvsXLFTeDitgMmLRLX2cuPS/3nZpUIra4997fsjKWCQjto7p2GGVGtHz9ulVCmGVedh1PKVcEmJL1ndiSWqc8h9zwkPxjeZW6GhTbFglVuJA0r0k9ZgqgdCUNZBiiUwlTDG6y2fJSDxBtzS8bJNoDMGQbE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199021)(38100700002)(38350700002)(2616005)(83380400001)(8936002)(8676002)(5660300002)(478600001)(66556008)(66476007)(4326008)(316002)(66946007)(41300700001)(26005)(186003)(1076003)(6506007)(52116002)(6486002)(6512007)(6666004)(2906002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: A7G+bUOu5dybaXle4DdYeG3KZAAy2Ss5Yg/5QNmjOOSE28xfW+GAtrWBmTzYc0rD594cMxPwjA1tOkGmdWIQHuAixk5Xgre4lxaYk3nYtQ+A4r+nsIbqgnqw5fKyayM5OrgWJh+7SVSTTZa/HbCyhQya3qIiI9aq+DKXsmtPvWI8lbqWCUshQh2bcX9EP2BJSVC3WNyRl3C9aXy5YzhrXnf+kXspcbWtQvEzbB1OVVnjACWTXf+bgR0hRsWGtAF9GWlm3d9Dv7GHVFNtZcmPr4FxDeFMaeEjsxxn2I6ZIcQiPtgqRqye09dtv+Tx+XqNfn4l9SWU6CZWKcqO82l81Gcqd46dcA05Q0UQm/2Np5GR5q1TQomoPuQ900CW1ZmQLBXozN73lw7h0BCQAJ1pjHscnG0UgHBtLGtRa7IsAWG1BaXGcsr62Ebm9h3GwQc9GxS/8fHRBMHe5UexCULNgFeJX70OcVnJXX5Gg3qXHLo4eEnKXNqd8bvnnwPIzDp7xeV6hsRcAcKA+jXVU9CTz+6Jo+oISZd2Q+qiASCDkr/HS2t7e+5ZsKFdIbbWEfF2VZoU+kFiV4otNQoN+mqUNmdTutZ7m0GF9VSgE4Eg2c84RnaMsYfdr6Q5gqxSvPV5eIVUZXb3hn5oC48CrSJzstpo2mPwRfDu8oGRcqyLqqpY+tRO3AEuqibWvs6THs/uJDZG6F8uTSmhEquqc+67ru+yGaANOUTKwAx6Lxv7uqRwAb3PhLXR922A/1smdgGAUGwMs3Y/RcUFtQ3GDY0X4W6ezf9qJjRe5AabbALKlfBWis72Mek8YMkHSmtHzKNZ/s0aJuvdtysx+TnVbgRiOJ4C+zLxVf9GZf0tseJgoFrcr7xWPfaJiotCPu704WAT/7IlRinV2JqHbckrEI8NLvZrVsExSs+RKWySTgIRqKUTQE2rqnXlaIGMTzVQVIj+ZQywZJszLMyFKHPz2WXSJeOIs5zbMrDJPz12cwEIDngdhNnI3FLyh7hjkjN4H8cP0qhKqPbTzLQL9Ylu+Ss/zhYjK5M9AA1UQpy2kBbaU+QRPi+6rW/s+tkxU0dCP/tEEEOXk6TOdoizE8jTG/p3fR8JaziNs/qxTrr1os6Cvlzf4ILZGHrQnIbblvSOXJwkVx457G7v6GqUowLihREzKN080KPB8mccFOLfx2L9mdwWQPjkuIQlMkhhDJLj7dRuZzb3qmhglyFQies3EZJaIfKIgxmCN3/wzLrWRewsiyGYEAIAQ7NGbiOStu4vettXbpc4Mzpllosxh1i1E7ci64o3HVEHzZLXNRsNO/dX5ExdUdob1eyMXASCAbFk2+JAq7wAoVkSi5JGqfBaLqv6/Xwu79Uu/3dCnHpRRGNLkWGRVx55NbladQsdwZ9AYVKxqI3ogRRbSLWEj4qrIWpo1DrXhq3ZPzKNIx95TCAxuFuYP1B+yLc0/PfdE/+zlT6urXYNJzWsCzlem68P1fGE/hugtYOINAZ51n8w4PwAj4prdTIps8m+ilJmSfp2qEEYbRyfnIpKkuVmhqGCxWvKdlfrMEVqmeOmnHs13SUld76Sgd6gYYUfavPINVulvgDm X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: bacb19be-be09-480d-9a30-08db8aaef089 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 12:26:56.9210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zi+DOHEwOZaf5Q7ux7Isbkp7lKRudC3wYvVrGmxV6EcXlLXq8+CbbLZ5lsWb9nwQKvnJUyRY8Szv/7foT8Vt8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9461 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230722_052708_835743_FEAFE7AB X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Cleanup code to export imx_scu_irq_get_status API to make it could be used by others, such as SECO. Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-irq.c | 40 ++++++++++++++++++++---------- include/linux/firmware/imx/sci.h | 6 +++++ 2 files changed, 33 insertions(+), 13 deletions(-) diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c index 4408f150b3d5..6549f3792a0f 100644 --- a/drivers/firmware/imx/imx-scu-irq.c +++ b/drivers/firmware/imx/imx-scu-irq.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0+ /* - * Copyright 2019 NXP + * Copyright 2019,2023 NXP * * Implementation of the SCU IRQ functions using MU. * @@ -66,29 +66,18 @@ static int imx_scu_irq_notifier_call_chain(unsigned long status, u8 *group) static void imx_scu_irq_work_handler(struct work_struct *work) { - struct imx_sc_msg_irq_get_status msg; - struct imx_sc_rpc_msg *hdr = &msg.hdr; u32 irq_status; int ret; u8 i; for (i = 0; i < IMX_SC_IRQ_NUM_GROUP; i++) { - hdr->ver = IMX_SC_RPC_VERSION; - hdr->svc = IMX_SC_RPC_SVC_IRQ; - hdr->func = IMX_SC_IRQ_FUNC_STATUS; - hdr->size = 2; - - msg.data.req.resource = mu_resource_id; - msg.data.req.group = i; - - ret = imx_scu_call_rpc(imx_sc_irq_ipc_handle, &msg, true); + ret = imx_scu_irq_get_status(i, &irq_status); if (ret) { pr_err("get irq group %d status failed, ret %d\n", i, ret); return; } - irq_status = msg.data.resp.status; if (!irq_status) continue; @@ -97,6 +86,31 @@ static void imx_scu_irq_work_handler(struct work_struct *work) } } +int imx_scu_irq_get_status(u8 group, u32 *irq_status) +{ + struct imx_sc_msg_irq_get_status msg; + struct imx_sc_rpc_msg *hdr = &msg.hdr; + int ret; + + hdr->ver = IMX_SC_RPC_VERSION; + hdr->svc = IMX_SC_RPC_SVC_IRQ; + hdr->func = IMX_SC_IRQ_FUNC_STATUS; + hdr->size = 2; + + msg.data.req.resource = mu_resource_id; + msg.data.req.group = group; + + ret = imx_scu_call_rpc(imx_sc_irq_ipc_handle, &msg, true); + if (ret) + return ret; + + if (irq_status) + *irq_status = msg.data.resp.status; + + return 0; +} +EXPORT_SYMBOL(imx_scu_irq_get_status); + int imx_scu_irq_group_enable(u8 group, u32 mask, u8 enable) { struct imx_sc_msg_irq_enable msg; diff --git a/include/linux/firmware/imx/sci.h b/include/linux/firmware/imx/sci.h index 5cc63fe7e84d..08346f312c51 100644 --- a/include/linux/firmware/imx/sci.h +++ b/include/linux/firmware/imx/sci.h @@ -21,6 +21,7 @@ int imx_scu_enable_general_irq_channel(struct device *dev); int imx_scu_irq_register_notifier(struct notifier_block *nb); int imx_scu_irq_unregister_notifier(struct notifier_block *nb); int imx_scu_irq_group_enable(u8 group, u32 mask, u8 enable); +int imx_scu_irq_get_status(u8 group, u32 *irq_status); int imx_scu_soc_init(struct device *dev); #else static inline int imx_scu_soc_init(struct device *dev) @@ -47,5 +48,10 @@ static inline int imx_scu_irq_group_enable(u8 group, u32 mask, u8 enable) { return -ENOTSUPP; } + +int imx_scu_irq_get_status(u8 group, u32 *irq_status); +{ + return -EOPNOTSUPP; +} #endif #endif /* _SC_SCI_H */ From patchwork Sat Jul 22 12:31:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13322949 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F3BCEB64DA for ; Sat, 22 Jul 2023 12:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JnPAnkBWXmSAPABSzeN/qk6X6XDrmVPN7dQlcnpAxZY=; b=4IDlkHpMeIdbAR t9rRSGXfXGtIahwImmHLtKqyBqrhVi2+adHgezUPLh+8mxdiy7tmTVufPkbwVfNYjiSYEVfIUoXHG mVi2TVLSkohEmmXxxkmbXdRlORVWUySIQaEw11/vJ8NSffN2MTTtEWxwFGN+TZplL7zuaTPbUiUVV pK++rlJy2dy3cG0YhoYQsC2V/mI+D/zImKJvFz3Dat/6EgMvsIgD26AhT4wuWPf3yElgHSnyLd0+q YMZC6RSyMTnZPdOJuLTkI5lA4enQKzd9bsZ6tYXegVrkQ6+5I9zR22ze5DVBnZLp7PteuIKm7HDxc HO97gAXQcw/sl0eas7+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhv-00GgY6-3D; Sat, 22 Jul 2023 12:27:36 +0000 Received: from mail-am6eur05on2061a.outbound.protection.outlook.com ([2a01:111:f400:7e1b::61a] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhW-00GgMU-1T for linux-arm-kernel@lists.infradead.org; Sat, 22 Jul 2023 12:27:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EQLu/2S7aIpbsNT2jfJOkULRLJGTiZ0p+vJpWumNbXnW02OWtmNmcmxcQrBmByR5W9mU1eYqWlEDloLcHK821VU2qn7mCly5+KTsfBf3E+SfbMOOG8GOWU5Hul+RPa4hIa5aaaUoCqsz5I580r0hm/m8rAFVpFxi8fpbfgjj3kKItD7OKtCXlakiniKB4do+H6BUYTiFia6Ahp3eDEjWbIxiZEDprZTE/6NWMNbU0BVIFwJs4RD5bI/w+L+R/WgEn2NbgkSo+pG6YtTTAcgwahtHSFB92LpsZoDKap485LtjPT5ISlp3HQ1Ej42v6P1wZlVdl+KeSCIXYqfDj3FEqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QALHUzHVhQKD3fKu06vGPOUlJ4GnUotQExquzQP0wVA=; b=PENmH1epunbCn+WwhK/gBQrWCz19xvkzNCtN33FcbJrSQYRRfVLpT+L7WR5WcwyfqfEJH4Up/5zln5nqdPNInVyuuLFZ+RDgrPkHPXQWjoA+spTF/9j5AkFTMvZAe0I6hWVubtEcuoY1UpbgNE3RmlVAkQx78xvrsRV4W+6pSjs0OFfnduIncm6IPDCj+Sn9MtTMJcicWseuHOQWehzn0GM6AqR567xozXDR/zdYWu4Ec2y6xMH3F7i+PMm/LyUOutbZn1fXd9H/BMXEMztjs1J6J1Evx7Rwi7jEkCx6mmxZB7pBiyXzvsQSawZ2/IdbCUbOZ+fhRyorvvZWq5zQKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QALHUzHVhQKD3fKu06vGPOUlJ4GnUotQExquzQP0wVA=; b=VHtxXYQ4+VUcqYkgKUVEAtsK6Hs6FJ8pzjsV+lg1s5e973n8Q6sKfiWaTd+q/8PrwXRbAZ6GZCg411O8dGmmmNekNm35LldR7EJw86+daf5VFYgeAGof5dEMCZmazpZbcAzKx9d9NtjphCNAC/xPMpThmRoOr9pqTUewJlVhrEw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9461.eurprd04.prod.outlook.com (2603:10a6:102:2a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.30; Sat, 22 Jul 2023 12:27:01 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.029; Sat, 22 Jul 2023 12:27:00 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: [PATCH 7/8] firmware: imx: scu-irq: enlarge the IMX_SC_IRQ_NUM_GROUP Date: Sat, 22 Jul 2023 20:31:18 +0800 Message-Id: <20230722123119.1966998-8-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230722123119.1966998-1-peng.fan@oss.nxp.com> References: <20230722123119.1966998-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR02CA0129.apcprd02.prod.outlook.com (2603:1096:4:188::19) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e0ef87a-d04d-46a5-91f7-08db8aaef29f X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OBelwg6Xbe6QwzF4kDtw2gPiQKqJWsLC+6oD51W1JqFL9tyOdzyMQAo8Ceui/wo/ysHvxZto1OvEskhHI82zy120qpUG33XUzaSoU1OS8qopsq1l5bdGALCovQgTSaknoalRNZJaYEjsg5mupP+yd4L/SlV17oxg2SyQWzmeEu5RPEyojaMIWUxqSgkckmQuH95q6+876trHDeY7emz2lT8n7HCtK1scmsQ2lN0uLzlNI0lZjmE7YRw4bJ9x2r2mC7JS8gKliC4JkqzMjangjIhCEsEbHMIW9sT+eoUWYDXWxsdiwRpPWuZhwkgUKuW+HB93uQIZ0oZoDvvLxoWQG5GwbyS7VEiZJFBSWJwbGCMbNlCxCysdaxS822WXg+8Mnzr+STnKJslZ3t2t7XAv+i4k11wQl+VG2CI3JQckf835PONn3QQQdnyY/h0Edil49LV48DJZyAYhUD4gXbMavJQKu7dg0TKSapdhU7N7a5hbDnixzNA61oM5nU0+KA2oC4YGVNO98QAfA5D/uqduc+uqXZeNucrGpKSpzMX1xW+FgwnzbYDv5C3STDnsPr0/QaBjJi7/Orpz7PJU1XNWwx92YBpmpkLPV1tpMMHONModI3KZZmmBrA3RId28izcf7LYpU+153IXv8bf6CCoGjg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199021)(38100700002)(38350700002)(2616005)(83380400001)(8936002)(8676002)(5660300002)(478600001)(66556008)(66476007)(4326008)(316002)(66946007)(41300700001)(26005)(186003)(1076003)(6506007)(52116002)(6486002)(6512007)(6666004)(4744005)(2906002)(86362001)(147533002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TlMkIFqY2hDMaRHgd3c9CsYBJTocWWVU2z3AZJGoHBgxnZQMUQsskBXAZVPUWGbIx17P2oz/1pxj4QwhuMp1/+jbqtLSB9vTp1R1wo5Ntwte1d1ERtUntRmYVh1vCWWYrdf7cLQN/D1dxXwWA8uS5y2H6VoY12UBiV4rh4+5oReNllgREprfbJorG3LDA0Q/jRcjSG662bi+9J+zu04ym9sVFf9eEGYhwndEVsm0KBhQYLN2fm4FSmQhlQKMTout1PzB9rtMKaDX/aTshdPkjIAXgyF9t4jaY00V17CaDpUQ6ZnR9yYbkoJzZE0RFkbfO0mBH4o6YOQt5BauknfTmcwZz8NMaddhDkrUxIlDD3jCxnxPw52nJFJuP8CmdwHsw5RrO1lFojrnOSM34SBCP3FUAXo/970X8k8JMwZvHn25VUoJu/990LsJ6NqcjlKbqyvXjWaiLWhit4t6VJM7S7im2zDyAg03aXcg77DbMdLmei4YfQwIxseS3TEXcnxUX8U5bVKHm/KpyUL4HKO7ENVdhW47+BuZ5LvwpXhgVYej7HBR7/RlbcRLJsMftL8Ty5F/sRp8hA/NFmkLPoFbNTg7IHm8bHI3yGN/oGCdxbV/9KIaaoeeFzVRAl7qsjRYitpKuKO8TFB+e2Ix4c+b49rHT9pKPbWHOuAzW7KhP7C/LHwoO5YtLEKnzcJ+QQy/Ml5bQCoV62WmjM3Rv8b7PHGRtPRVX1XBct/b5lIebkJFc5BDblrazFW2DidteLZHNwzcDF6UUc8JmU/YWpfNg605eTkDHfCsDlMD2y+/tZgtWEDz2B/P0nINagdunZGF3kJWSKlsWf+3IZdPXhXMJewHanSAZkQBEwm/LsLzlVOw1k95geb5RlmWqwT3+2c5/smdyYZaF3V2t0tsekhMv56T91IWnAbVubJoR8xIibj03/+DBMj8iP6Z4kLZu1+WgvXM7K7PAaZJlNK6OB3QRkIz7bOwyT3hJB9dbQVyR3IhGaBmWAtvkSij78qGhrwer5tjzAzo1VeYqcjxyuFrxT98564X9tKUnYcbqCf8tdFNZtSa4BOnpEGhmKxJX9bite04ECMjVogrfmQ/ArOiYYf5jqyrCruqV/7DMXsXNnWFHmJBEJP+miDTRoPaZN3FsnE8iF6NCW7jfg3BACmJaCM6WeB8w2eEMNcvP//g17l0KIzNOGa55LGPl6AH244R29e8PYBX6lOTpUo8OL8Dn56o5Pjz8JVCvXGW772p/bNuLiy+Jfx/aH2tFUCHS0Jg+NdeG/Et7HVxPfUDxDxnsH+saqJLaLDClGsENgxmAKH7YUpoqVR2GTeg5YaaN4C0Jdl9IBCIY36NfzbjzyD2bU32aY1os+Q/RlQv6Y9+pmgfcBNTo+gVtlETmzpF6hzsE5UJAj9AvA+r1TuvuRxL7DmEUry0yF8+aWRjOWWQN2yBEKOKEdxIWBTQ0w4mHADFNILXjMZcI7YSy8Y3NpzFxXe5qAOD5YyX8klRaVzXPE7GRJZN4gJIQrDcwfR1rcelwZCTWNFz6309zTguKj7FXSihWNZRKLUzs9/LlPmN+uxfgehFWz0SZEhAvnBgwpPM X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e0ef87a-d04d-46a5-91f7-08db8aaef29f X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 12:27:00.5666 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hjOGehfSHXHjpTXVHDFMi9y1Q9nEh82bVCb/3TM6Dfp9UkcYf2vcYWevN+i3fHpBqWCGwdJKF/0V0pvJr0kyxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9461 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230722_052710_493045_8DA9D427 X-CRM114-Status: UNSURE ( 9.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Per SCFW update, update the IMX_SC_IRQ_NUM_GROUP to 9. Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c index 6549f3792a0f..8d902db1daf2 100644 --- a/drivers/firmware/imx/imx-scu-irq.c +++ b/drivers/firmware/imx/imx-scu-irq.c @@ -14,7 +14,7 @@ #define IMX_SC_IRQ_FUNC_ENABLE 1 #define IMX_SC_IRQ_FUNC_STATUS 2 -#define IMX_SC_IRQ_NUM_GROUP 4 +#define IMX_SC_IRQ_NUM_GROUP 9 static u32 mu_resource_id; From patchwork Sat Jul 22 12:31:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13322948 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70BFBC001B0 for ; Sat, 22 Jul 2023 12:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BuCjR4YRQS7aKj2L894OxwebVAlTJbmUyxPDqZIMf4A=; b=Dsaq4iCBrKT2VB 4W9b2JuqMkLb6W/EPGT2zAqdGzM1gF6vd9klErHvBR95staNpZ/CS9gCmBiJ36MM9GPBa6lARh0Yx zdAmqPx6i6erAxzxGgpE0jO/uZNNEv38ARepM80rEp05tjEqJM0zbr9Io4yLrf5iQ4hfXnwRIy4Fg D8JCZi6ZuTtDBEv6DmUAUroYhdpdIyTR01dNLhU9tF0gZsSF1dcPgp5ur7BY+a46rAbdADljqrXLc CFaapAjDn6RS8sKMBWX/PDunlJuqCUxCJwocb+3cdUziN3srW0ueGGImeVSENZEXDMnkTAeQKnKNm ZAnZUr0LOuDaHs7kDVbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhw-00GgYP-1U; Sat, 22 Jul 2023 12:27:36 +0000 Received: from mail-am6eur05on2061a.outbound.protection.outlook.com ([2a01:111:f400:7e1b::61a] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qNBhX-00GgMU-35 for linux-arm-kernel@lists.infradead.org; Sat, 22 Jul 2023 12:27:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WWOnqVQiPBUEB6JC730pP5TdMWXGRp3fisQPMnwEBkwcLKgLfBModUU7z3HetOTFZxDfo0qaWAMEMvKz+++82HFpYe9c6a2svqzD4Sp29jA+48An2PKJTAXaG1zkjyANgusu70qNZN5RPDItSFTNSR4ogdpGFNM6gav73LgwxVZ/9y3HxF5QFJiD9LeWExe8A1iDkCW5DR8dyLsbMAZeivxpEw30tBgmGNhvylXX4Y/eJMMFrRALxzHmE3K4MU4nlOPAKslHEGTRuhI3Vw1SkTMG+GmcRYpENJBy0E1AZOG2iAKZFnhy3Eqc0iI4/I6tT7Xzl23q689dZhHd9cpoTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OG0c7xlEu5lw/+LfbmcuWV7Q2W2d5z53TXqPTJE8ZOM=; b=PoLuaOs2efA9SU3hCc4rrZLDlsiEXwaEHUcn9OBUtxoMbkRAB98ZvA/a9zvOOd8r2u1cizO/B7uftM0lyvBcaRMXup6sf4IpgfVvrflHdADHYp2XjnGqB2eikjNk/rfEo2DlZx8wkT0OkJGSC/77H3mCNQJwxi/X61ExJKR9IKbsl9UkNs0/1nH50gBmYhAUhBKn6SWCtKdnH/w/gnfjcIM4KinTTBdrzcmXpRATMqM3IqPgBWWuGgP5KFAC5/F1jeUAvgSg/0KbFJKkgYxkD5VjLdgjPMoGFlEwc/jxvE7TxFvwpI2+4vVmLAdVJsrCskLc/ksanPGEY0UPLzChtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OG0c7xlEu5lw/+LfbmcuWV7Q2W2d5z53TXqPTJE8ZOM=; b=fkldCRcdiyx+vM4j1z8Ie3/Sa8w0l2BTZbp+urzp6cZzsun5ArB7R791yhiAwI2Wwd3zCBiv9onVUP1rDjZ/Cl/vr08o2VEggDtc7qBCby4v8yIcQvg/9ITxNOlhbbav9EqKbXuaa3+T++x7esYs+ZXzwhuKa5S+6esSE7eBJuE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA4PR04MB9461.eurprd04.prod.outlook.com (2603:10a6:102:2a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.30; Sat, 22 Jul 2023 12:27:04 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::c874:7c87:c13b:64f8%5]) with mapi id 15.20.6609.029; Sat, 22 Jul 2023 12:27:04 +0000 From: "Peng Fan (OSS)" To: shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ranjani Vaidyanathan , Peng Fan Subject: [PATCH 8/8] firmware: imx: scu-irq: support identifying SCU wakeup source from sysfs Date: Sat, 22 Jul 2023 20:31:19 +0800 Message-Id: <20230722123119.1966998-9-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230722123119.1966998-1-peng.fan@oss.nxp.com> References: <20230722123119.1966998-1-peng.fan@oss.nxp.com> X-ClientProxiedBy: SG2PR02CA0129.apcprd02.prod.outlook.com (2603:1096:4:188::19) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA4PR04MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: 529d1314-8e84-45d5-214f-08db8aaef4d2 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iLo0rQeDaynaPMj8SmIVPFrVwjgcqTA7Lp3N+T4xBj1bdxfOR9sd7/8qM5cIFuv5E/6vrpKNTPyqDztGMYI4qb6HYJg9VbbDw+1OP7OLzX7kiCJp3TfBEurvwNM1238cwQYOL2aGsG9yqCxZdWjWwWdkNV6AjaA987iwZr33hy9kde6RpZSysz1EUEf24sgoP1qRWdUy0QGOwWhA0XeW0FQSRThQj8t2sBv93zmHnxpokFX177BYQSPNazMhV9Aa0niz6jXJiwY0LoX143ASY/yr00aIX6NHyphv6jnT2dEDP0XyVzqoBec6gZcLMJTFFvFiXLgQCZ+OMKNkLWdcqOCnbxcQurUJtUDL9PJvdIGwdwtqvmDqGISb2r1C9AJwZlfzRbMuyK6z/fKYgz9xr0MENlTsPBNG7WG6jQOESJI5tqh2t++hRgtd8wMVJPXzjtOtfjGcTW4E8iqXzQ8hjYukNJ+PifXtE0GTNjsKFE4C289ACPLi92zqZ1KuCv9D9yGNu65UcmzY/c+Khg5XqAND+WKRunlTu91C4gSuqJGzE9y6ODJw99M5TZ3PdzSfCYO6jqhluSUo3cItHlbOTiCsOBNJokuV1DwNOF6cteTqg5wOqmuaHL7gmG8XruZx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199021)(38100700002)(38350700002)(2616005)(83380400001)(8936002)(8676002)(5660300002)(478600001)(54906003)(66556008)(66476007)(4326008)(316002)(66946007)(41300700001)(26005)(186003)(1076003)(6506007)(52116002)(6486002)(6512007)(6666004)(2906002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Q6LRQlgByyONk1fqP3duMDdH1V6INv/NwG3XRGy7F7VgCDqsIAxCCocfWDSxRTfjQme8LI7AnTWjSuZxTaPd6QGCunUY4dTPfCmK9tE9ieaLjAIChgtSmGCNWzkJwwwaLE8UYLSO2n776pjg7Unlmfeq2o12/LJgMEhp7BEYvOKkOMpoNlMlcqWmeJjHjxY13pN67yA/IxOe9FleIK55onJrbTFWF2/mH9tg3KUV4lZFaGtijbDsJmZw6q4FhJC29hL4lG/QdwDBaUJh75yZaDvKXQ4T1fA5BMUbSrjU9z7Lmqq2HGZmXLcZiVmadrumKVac22a8VSKGmNw1KFhopl2b4fhK5TSf6QoYlW5xctxR8vdCxkxLPhOaD9lWwKxB8Xg+SB4DDUrFlQtwdC9kk2JrzNa6fXJp3LjWAkA5XlQTXChee5hvb6jtDyJlXEZUsxc4a9uqdgCj1APl5SS6Oy/8vBRDRu6h3JsOywKXpvRBAfcs+oC2KxjnvBlPS0wdrZxXdNLlTYCdD2/PdKFMO2z07rni2SHf9WDaZHLw8FtLxnsWcvH+PhoZUUC4UmRV7TQmhTNzYuRVEJN1IEQZf0awcPbHmPFppZ2MoOA2TW0BZByCNfzfir78bJA6f73RYSayWacy6lRl1Djwy9TtBN8/Kd8qPRMiz8SkmdFJKvYY2/NG1MfGWvvIajXoc63QPeipNDjpCvVn/KObqXkLC+CcnUUAyfowxc8qTwhpyNsN8+IW38v8YCOQRzCLjMJc46t+cDz0Fa1Gmg+mE1rX5Eo2oI5FAQGNkgm1y6PIT+s0jJbu8IIs+mcdjTS19v0EK7XCnB0ksb04IVGjXTmpfo7EvkcmNxmj1OdtRcaXcbE7HYH9t4hqSnZMUUfrTXpsDyIij2o9OqxkiOd1IcRiwMMU4rMeP6TBUyq3nj4XY8cDSJQrEZ4JcrmeLIB/hCPIjE8XOKAFo/FqZBzHO0Tz/ztRMC8VxwHvTQtaCtQq+OpL7S6Ra6svDFqM6JsRRC1lULI2W2e9JK73qGrzvMcwggiMY005yFf13qitUiZbSK8SJm8GG51DbMtMZQgqgcbwlfISUbCG/eKZXSUEc04/kgYWxuyIIwvetrN7uOC/y5I4khnJiQuOEwk1UIVDRTT8LT8qi5Vqlw0+UrTUeIiDb5xk9PxPeSYe/0WEjsJ1FlNNYH3X+4BJ3Y7PLLdcqe4Z5khXOMQh6MEvdnO2D8SZRYKcz9QWm9DzntEK17W7JE0Toc/z9kk7o58D/DyB/szYKYY1WuNGB4p/HJfIZc9Z3Xf5Gh38qAfkKPVRn4acj25oobKnqkUkeLLd/GnOu0qtlgjU1dUccejwQarL7jMkomQMDAbI19s0+0vLmXSy2FXwlNcHLQemF5Mp2124jjB8jJou3qkyJV/IT09lHrgv+WgiccAB4E9AT8IzHtL1F5TUja1QHMay1oqlPdOL11J3gLRUxdKGzYWu0OyBNOXVtR8CDImH/YqxgFdpMOGTo3NsjGQ9Zzr2VpIDOodexJO2vUa3/UQV7ePTLBZOEh6/HCwYed1eE4PNGZf+jNb21kxx7SgjkTs+ow+yj8bu099I X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 529d1314-8e84-45d5-214f-08db8aaef4d2 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 12:27:04.1055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f1QXYfO79MaD+CMZrNCwkgALvtHORJa9EdtDi/eb5SMaNd2gnFMOVitfC840xqaJH5rl0B7kw9XKBZvisF6u8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9461 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230722_052711_998580_A8C36404 X-CRM114-Status: GOOD ( 17.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Ranjani Vaidyanathan Record SCU wakeup interrupt in /sys/power/pm_wakeup_irq The user can further identify the exact wakeup source by using the following interface: cat /sys/firmware/scu_wakeup_source/wakeup_src The above will print the wake groups and the irqs that could have contributed to waking up the kernel. For example if ON/OFF button was the wakeup source: cat /sys/firmware/scu_wakeup_source/wakeup_src Wakeup source group = 3, irq = 0x1 The user can refer to the SCFW API documentation to identify all the wake groups and irqs. Signed-off-by: Ranjani Vaidyanathan Signed-off-by: Peng Fan --- drivers/firmware/imx/imx-scu-irq.c | 66 +++++++++++++++++++++++++++--- 1 file changed, 61 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c index 8d902db1daf2..79efbf259dd7 100644 --- a/drivers/firmware/imx/imx-scu-irq.c +++ b/drivers/firmware/imx/imx-scu-irq.c @@ -11,6 +11,8 @@ #include #include #include +#include +#include #define IMX_SC_IRQ_FUNC_ENABLE 1 #define IMX_SC_IRQ_FUNC_STATUS 2 @@ -40,6 +42,20 @@ struct imx_sc_msg_irq_enable { u8 enable; } __packed; +struct scu_wakeup { + u32 mask; + u32 wakeup_src; + bool valid; +}; + +/* Sysfs functions */ +struct kobject *wakeup_obj; +static ssize_t wakeup_source_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf); +static struct kobj_attribute wakeup_source_attr = + __ATTR(wakeup_src, 0660, wakeup_source_show, NULL); + +static struct scu_wakeup scu_irq_wakeup[IMX_SC_IRQ_NUM_GROUP]; + static struct imx_sc_ipc *imx_sc_irq_ipc_handle; static struct work_struct imx_sc_irq_work; static BLOCKING_NOTIFIER_HEAD(imx_scu_irq_notifier_chain); @@ -71,16 +87,24 @@ static void imx_scu_irq_work_handler(struct work_struct *work) u8 i; for (i = 0; i < IMX_SC_IRQ_NUM_GROUP; i++) { + if (scu_irq_wakeup[i].mask) { + scu_irq_wakeup[i].valid = false; + scu_irq_wakeup[i].wakeup_src = 0; + } ret = imx_scu_irq_get_status(i, &irq_status); if (ret) { - pr_err("get irq group %d status failed, ret %d\n", - i, ret); + pr_err("get irq group %d status failed, ret %d\n", i, ret); return; } if (!irq_status) continue; - + if (scu_irq_wakeup[i].mask & irq_status) { + scu_irq_wakeup[i].valid = true; + scu_irq_wakeup[i].wakeup_src = irq_status & scu_irq_wakeup[i].mask; + } else { + scu_irq_wakeup[i].wakeup_src = irq_status; + } pm_system_wakeup(); imx_scu_irq_notifier_call_chain(irq_status, &i); } @@ -135,6 +159,11 @@ int imx_scu_irq_group_enable(u8 group, u32 mask, u8 enable) pr_err("enable irq failed, group %d, mask %d, ret %d\n", group, mask, ret); + if (enable) + scu_irq_wakeup[group].mask |= mask; + else + scu_irq_wakeup[group].mask &= ~mask; + return ret; } EXPORT_SYMBOL(imx_scu_irq_group_enable); @@ -144,6 +173,25 @@ static void imx_scu_irq_callback(struct mbox_client *c, void *msg) schedule_work(&imx_sc_irq_work); } +static ssize_t wakeup_source_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) +{ + int i; + + for (i = 0; i < IMX_SC_IRQ_NUM_GROUP; i++) { + if (!scu_irq_wakeup[i].wakeup_src) + continue; + + if (scu_irq_wakeup[i].valid) + sprintf(buf, "Wakeup source group = %d, irq = 0x%x\n", + i, scu_irq_wakeup[i].wakeup_src); + else + sprintf(buf, "Spurious SCU wakeup, group = %d, irq = 0x%x\n", + i, scu_irq_wakeup[i].wakeup_src); + } + + return strlen(buf); +} + int imx_scu_enable_general_irq_channel(struct device *dev) { struct of_phandle_args spec; @@ -173,8 +221,7 @@ int imx_scu_enable_general_irq_channel(struct device *dev) INIT_WORK(&imx_sc_irq_work, imx_scu_irq_work_handler); - if (!of_parse_phandle_with_args(dev->of_node, "mboxes", - "#mbox-cells", 0, &spec)) + if (!of_parse_phandle_with_args(dev->of_node, "mboxes", "#mbox-cells", 0, &spec)) i = of_alias_get_id(spec.np, "mu"); /* use mu1 as general mu irq channel if failed */ @@ -183,6 +230,15 @@ int imx_scu_enable_general_irq_channel(struct device *dev) mu_resource_id = IMX_SC_R_MU_0A + i; + /* Create directory under /sysfs/firmware */ + wakeup_obj = kobject_create_and_add("scu_wakeup_source", firmware_kobj); + + if (sysfs_create_file(wakeup_obj, &wakeup_source_attr.attr)) { + pr_err("Cannot create sysfs file......\n"); + kobject_put(wakeup_obj); + sysfs_remove_file(firmware_kobj, &wakeup_source_attr.attr); + } + return ret; } EXPORT_SYMBOL(imx_scu_enable_general_irq_channel);