From patchwork Wed Jul 26 13:27:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 13328036 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC216C0015E for ; Wed, 26 Jul 2023 13:27:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0344310E47C; Wed, 26 Jul 2023 13:27:31 +0000 (UTC) Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by gabe.freedesktop.org (Postfix) with ESMTPS id 08BA110E199 for ; Wed, 26 Jul 2023 13:27:28 +0000 (UTC) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-686b643df5dso1048916b3a.1 for ; Wed, 26 Jul 2023 06:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690378047; x=1690982847; h=content-transfer-encoding:author:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8lxc77XWTDPTeWKbOVls7trvqC1maeRESKQ7JlGBAVk=; b=tzlf/K6lA2nbzCK73P1REKEDFjco9nWhyDMS8OpMrVB0n5mWFKtD++dNg2lByeu7m0 d/zJYAKzFrMg3vWf5aU7sOnjhvN5QHBX0y7FQ9UYQgnKfr9xuvMsFHiYG2QDmHD7k+8q wvw/MD+Gf1t21AqrcccEsCI6otUTJ+XKxBvHL62rhWbUpKt55bqx0UCVcaZlogJ81HYp Tlhm31L8wPRXG3h53U/ofo4BB5wXwgYOqIGcj+szBaXFhZSG9s6mA/xAfsKweCycf+hG V4WdnEeL5ZPUsyVYERCtTl0/y3YymEbtIwL0xCguLZsY5qIrXdFrHUa1iF3dlgHOdJRZ vCwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690378047; x=1690982847; h=content-transfer-encoding:author:mime-version:message-id:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8lxc77XWTDPTeWKbOVls7trvqC1maeRESKQ7JlGBAVk=; b=GoPOzzrOQgWcwBV+mLrp5t2jDSrhL2AJZrP7x+wcguJfsAWNMMmNyj9bjxIjzcaeyg 9Z9lTk0iChE2ccpFS48dfQVHuurmu/W5RF574pWx1/x01M2ZtqsUmo2BwklKiP7Eo8Ct Zbg9jteQwmyfkL1eg/Zw0PHVfPGqQ8r95AfXBSe8KNJyoNlCiFvoZimPdZ+41EDymXo/ 7Z5g64svSxNaSWzoDahc0qNFz94or3a+ynhenLT0XauuVbq3sKTLFwCR9/Y3clcMHdWX eT7fww5/n5ivpPTwTCbME5cR/wWVBmv3nYK67QMJpvPAFMpjJebq1fj2nBvTQXSg/P4q RwDA== X-Gm-Message-State: ABy/qLYyl0zGpx09DVsG+c6p3a14OgZm8M+wkFsMdpCFhnRB3nBDgRXv 4dIE4Saw7+Oe/SJ8UWKrw9bIqw== X-Google-Smtp-Source: APBJJlEkGaXvYl0Z4D2WNxjIzaFmZ0xG0IQslvweGeXL3npbZc6MEWn92JA3fL7KJSzJy2bGF2OmTQ== X-Received: by 2002:a05:6a00:2d09:b0:667:e17e:85c1 with SMTP id fa9-20020a056a002d0900b00667e17e85c1mr2058353pfb.1.1690378047425; Wed, 26 Jul 2023 06:27:27 -0700 (PDT) Received: from x-wing.lan ([49.207.50.231]) by smtp.gmail.com with ESMTPSA id x52-20020a056a000bf400b00682ba300cd1sm11485918pfu.29.2023.07.26.06.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 06:27:26 -0700 (PDT) From: Amit Pundir To: Bjorn Andersson , Andy Gross , Dmitry Baryshkov , Rob Herring , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Caleb Connolly , Bryan Donoghue , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Krishna Manikandan Subject: [PATCH v6 1/2] dt-bindings: display/msm: mdss-common: add memory-region property Date: Wed, 26 Jul 2023 18:57:18 +0530 Message-Id: <20230726132719.2117369-1-amit.pundir@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Author: Amit Pundir X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dt , linux-arm-msm , lkml , dri-devel , Krzysztof Kozlowski , freedreno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add and document the reserved memory region property in the mdss-common schema. For now (sdm845-db845c), it points to a framebuffer memory region reserved by the bootloader for splash screen. Acked-by: Krzysztof Kozlowski Reviewed-by: Rob Herring Signed-off-by: Amit Pundir --- v6: Re-sending with review and ack tags. Ideally this dt-binding patch should be marked for stable as well, like the follow-up sdm845-db845c.dts patch in the series but it can't be cherry picked cleanly on older LTS versions. I can do it separately if it is required. v5: Moving the dt-binding to mdss-common schema with updated commit message and property description. v4: Adding this new dt-binding patch, in qcom,sdm845-mdss schema, in the v4 of the follow-up patch for sdm845-db845c. https://lore.kernel.org/lkml/20230712130215.666924-2-amit.pundir@linaro.org/ .../devicetree/bindings/display/msm/mdss-common.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml index ccd7d6417523..84ed2757ded5 100644 --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml @@ -77,6 +77,12 @@ properties: items: - description: MDSS_CORE reset + memory-region: + maxItems: 1 + description: + Phandle to a node describing a reserved framebuffer memory region. + For example, the splash memory region set up by the bootloader. + required: - reg - reg-names From patchwork Wed Jul 26 13:27:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 13328037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF6C0C001DF for ; Wed, 26 Jul 2023 13:27:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F25310E199; Wed, 26 Jul 2023 13:27:35 +0000 (UTC) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9869F10E47D for ; Wed, 26 Jul 2023 13:27:33 +0000 (UTC) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-686daaa5f1fso396433b3a.3 for ; Wed, 26 Jul 2023 06:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690378053; x=1690982853; h=content-transfer-encoding:author:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=89pDHiQuuTGBrFn4u+2m7Al4Ng6hp0tFQ+lBB6CO7z8=; b=QzQQ58weFbx13ZPAeX9zmEbDZELDz9db2Ffpc0ES48wh1SJYJGC4Z2mdgS9QFKcYfO EabPeQPjzH93WOaUBhAtkLfpQ3qbdX/+1G87al+3Q5xmyFbaDRV3hVxCGMYSpyUMdfdk SyWTu/4g62HL7jgUwfP6IzAYd+1kBjxQ2ZBj0cyjtR3MfioY1dvqcN0S42qhUi891/mp iNhSgV2sGLEGsDaTfPYotDDu1U5WpavGIR/hLewOnsoO71VMS07S1voZF0xDbMO39Oq3 nK5sdySJ+brI4wBWZEfQpyLbixODkMRrttYeWAE6L/LQ4i9Y9DVlzorkIcr8BVHwDaa4 Zqbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690378053; x=1690982853; h=content-transfer-encoding:author:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=89pDHiQuuTGBrFn4u+2m7Al4Ng6hp0tFQ+lBB6CO7z8=; b=NWxT8UuT943iusD4uR1NuwUg22kDKL0KV2FzUNEOHHfv01x4vVuZr/QlOtZa5F8FEW mI8C+2peJnkhDpjHuSwRSoQfhPMeMFts/1/DGSztjl6hkCteQSHtoDMQC18Xl35nIyVa CLlxqOjcxi1/45imXpi3OYpZHSys+n6FedVp9xJ9MIpZ6x10J+ZhB7eN3NESbO/HWjXm Hrw3IkSHMWoW87Gtb8UXSdu6ZICmmOBEjaMvhC7YioFWq0LSH5YcmmyNYZDdFNFX6tG0 WO/YqTv4u7m5ummZKX8mcVCtAxBCTa7efUneYDIXX+ZOZystK9kITR0sdv71BdEnCSie zSvg== X-Gm-Message-State: ABy/qLYJg3lsy71Y3WJDkMMIt2tk8HnaZuZVdIQlY5/OOiGF5/e66EMU RoQQkt7TLzfGueij9BoTygx0kQ== X-Google-Smtp-Source: APBJJlFizJ74bxiKNwhoKoBmbCLVamjSoW8dbcj9VNixsovbSS+Bhsm7WcaYIWUOWupkeWiuWFNlRA== X-Received: by 2002:a05:6a00:194c:b0:686:dff6:50f with SMTP id s12-20020a056a00194c00b00686dff6050fmr944702pfk.8.1690378053122; Wed, 26 Jul 2023 06:27:33 -0700 (PDT) Received: from x-wing.lan ([49.207.50.231]) by smtp.gmail.com with ESMTPSA id x52-20020a056a000bf400b00682ba300cd1sm11485918pfu.29.2023.07.26.06.27.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 06:27:32 -0700 (PDT) From: Amit Pundir To: Bjorn Andersson , Andy Gross , Dmitry Baryshkov , Rob Herring , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Caleb Connolly , Bryan Donoghue , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Krishna Manikandan Subject: [PATCH v6 2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved Date: Wed, 26 Jul 2023 18:57:19 +0530 Message-Id: <20230726132719.2117369-2-amit.pundir@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230726132719.2117369-1-amit.pundir@linaro.org> References: <20230726132719.2117369-1-amit.pundir@linaro.org> MIME-Version: 1.0 Author: Amit Pundir X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dt , linux-arm-msm , lkml , stable@vger.kernel.org, dri-devel , freedreno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Adding a reserved memory region for the framebuffer memory (the splash memory region set up by the bootloader). It fixes a kernel panic (arm-smmu: Unhandled context fault at this particular memory region) reported on DB845c running v5.10.y. Cc: stable@vger.kernel.org # v5.10+ Reviewed-by: Caleb Connolly Signed-off-by: Amit Pundir Acked-by: Krzysztof Kozlowski --- v6: Collected review tag, updated commit message for the context and marked for stable kernel versions. v5: Re-sending with updated dt-bindings patch in mdss-common schema. v4: Re-sending this along with a new dt-bindings patch to document memory-region property in qcom,sdm845-mdss schema and keep dtbs_check happy. v3: Point this reserved region to MDSS. v2: Updated commit message. There was some dicussion on v1 but it didn't go anywhere, https://lore.kernel.org/linux-kernel/20230124182857.1524912-1-amit.pundir@linaro.org/T/#u. The general consensus is that this memory should be freed and be made resuable but that (releasing this piece of memory) has been tried before and it is not trivial to return the reserved memory node to the system RAM pool in this case. arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index d6b464cb61d6..f546f6f57c1e 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -101,6 +101,14 @@ hdmi_con: endpoint { }; }; + reserved-memory { + /* Cont splash region set up by the bootloader */ + cont_splash_mem: framebuffer@9d400000 { + reg = <0x0 0x9d400000 0x0 0x2400000>; + no-map; + }; + }; + lt9611_1v8: lt9611-vdd18-regulator { compatible = "regulator-fixed"; regulator-name = "LT9611_1V8"; @@ -506,6 +514,7 @@ &i2c14 { }; &mdss { + memory-region = <&cont_splash_mem>; status = "okay"; };