From patchwork Wed Jul 26 15:29:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13328295 X-Patchwork-Delegate: kw@linux.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782E3C001B0 for ; Wed, 26 Jul 2023 15:29:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232343AbjGZP3r (ORCPT ); Wed, 26 Jul 2023 11:29:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231176AbjGZP3p (ORCPT ); Wed, 26 Jul 2023 11:29:45 -0400 Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 055561FFC for ; Wed, 26 Jul 2023 08:29:44 -0700 (PDT) Received: by mail-oo1-xc35.google.com with SMTP id 006d021491bc7-5661e8f4c45so4676213eaf.1 for ; Wed, 26 Jul 2023 08:29:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690385383; x=1690990183; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=U6AGl6EJ9ojfwoIPkx72Nb+mtQBvhnepwNiGsBvw4D0=; b=o2lRCoF8UiW4g2FvhAfGcHRAWarVH1BVZr1TRiXK/HguesFgB+xKw7VvS1aovlHwYp btM0bh5TIHLSfJTKNMemFYfpvPepO4KeteDn3QXnHvXtkx2AVd8F842l8VTteoD6aNa3 W2No7UR1sANH9yQS2q9/XldQaX3WZKEtPsdTHNOmYcAUeLjYJ988VKB6lnlKHk1/OtwF 24g0TgUN1/wMfPYWD0VIqbFQiYahiGwlWwrh9KB3vccu6rAqpn184sEjlu3dJKnXN2gf w0qWpk6HWDTfSSTofgWsKEU6gsaNr5kquhTnOnvYxYi/6ITjfNo9Sk23AKIVpcmDvbzF EqJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690385383; x=1690990183; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U6AGl6EJ9ojfwoIPkx72Nb+mtQBvhnepwNiGsBvw4D0=; b=fRUwiQ8Y+wfz3MNlb5oil44eIWGyN/SnalaVdPsKZ2dp/tKZhSmG4Lyt1uH2kKYZkN DCXaxDlOZNOu53nSL26t2yWOYVXFo9IOMSc3Wg8AIcmEx7qSV0+yGbmXLCx3x34tWmeS b4Cz1bxhBEw5ql2mPm5N/KdfW9uHzSesj+2LDjWTKwLEmjicQUqEFdJOU7F2Cfz7A8Da u3FhNiqXpVcpY8AsxwJ0vJ+z9aHMOVIH30wkCPiTJIoFLstHqiiFLnyOya0hAk+eZAIw gTlmb6aN5gkH8rumjLkzsDJULmkMeitYnHh1C+Wn/OurDJcFDbiACsi7Xv63GoxOoxUE NK/g== X-Gm-Message-State: ABy/qLYGvuvCAiOExNDyGe4ejSzXas73nZnJ0onubm6ebXnvY1ZL1kMP fbOiprw9I7ZtOOWtnR7mHQ52 X-Google-Smtp-Source: APBJJlGTcKYWeISBmDCN0aDKSXjg/bNNvDOKZoF6gCXICknVsGl/EaEkWIvL8cSGJJy86LKI8Jxf9Q== X-Received: by 2002:a05:6358:2607:b0:134:c279:c825 with SMTP id l7-20020a056358260700b00134c279c825mr2799666rwc.12.1690385383248; Wed, 26 Jul 2023 08:29:43 -0700 (PDT) Received: from localhost.localdomain ([120.138.12.53]) by smtp.gmail.com with ESMTPSA id k186-20020a636fc3000000b00553dcfc2179sm12886092pgc.52.2023.07.26.08.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 08:29:42 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kw@linux.com Cc: robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH] PCI: qcom-ep: Treat unknown irq events as an error Date: Wed, 26 Jul 2023 20:59:31 +0530 Message-Id: <20230726152931.18134-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Sometimes, the Qcom PCIe EP controller can receive some interrupts that are not known to the driver like safety interrupts in newer SoCs. In those cases, if the driver doesn't clear the interrupts, then it will end up in interrupt storm. But the users won't have any idea about it due to the log being treated as a debug message. So let's treat the unknown event log as an error, so that it at least makes the user aware, thereby getting fixed eventually. Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c index 267e1247d548..802dedcc929c 100644 --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c @@ -593,7 +593,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data) dw_pcie_ep_linkup(&pci->ep); pcie_ep->link_status = QCOM_PCIE_EP_LINK_UP; } else { - dev_dbg(dev, "Received unknown event: %d\n", status); + dev_err(dev, "Received unknown event: %d\n", status); } return IRQ_HANDLED;