From patchwork Fri Jul 28 11:07:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinichiro Kawasaki X-Patchwork-Id: 13331707 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05934C001DE for ; Fri, 28 Jul 2023 11:07:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236126AbjG1LHZ (ORCPT ); Fri, 28 Jul 2023 07:07:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234277AbjG1LHY (ORCPT ); Fri, 28 Jul 2023 07:07:24 -0400 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEDCA2703 for ; Fri, 28 Jul 2023 04:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1690542443; x=1722078443; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yCNF3JeuVZxf0ne5Pr482n//cL5sopctZx3QYJ+p9h4=; b=B+DcJOwj3cg6rAbX+IbzS0di12vgwjyZF7nd6B2Vo1qPBQ7NH5mgMc/N pml/1m4HBX9zRom4sd/Y1D/tur/xrrg0wTAsIZ1KluKUeEkt3u9bOXWJA BK4VBlY57H0Fv6HOLNhgtWHAZB8PPfpFJ8bQrmeVTCJHNJ/JrKFj+f+m7 RTIWrc7NcBDdOepswcUyPDwvgPfA+uSne+LFGit3JKaXeq0Sx2yYvgxui 3b24rc/eaofjbMySz2VKQ3ABVDEb5xWWsKNPWMRW7Nj57WL34QbfISjEg f8LTTIXnI0vvOgaMlCBbUoiWyh2eSwO0uCrOVI+8S0l0dwQjnShkv9Z3/ Q==; X-IronPort-AV: E=Sophos;i="6.01,237,1684771200"; d="scan'208";a="244001782" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Jul 2023 19:07:22 +0800 IronPort-SDR: RX2LtLkxEgtWRvhmCDsfl7xp5pjMqUQP6nDfHjbK9sAzmptSestKPvNEXqLz5xao0lv5+nldA1 y6yya10DuW2gpyNo2XG5F/nG/ayoxAt45y8yIGBpSd7cfTSNLog7NK3FijNrnz/YIh9wcV7yER JhfuemLehIPLSPxMp98pyXG22IuaCgub6wBu7qPL/KLNn4bgezwBpSIFiZPzfTbZHVfRxx4iZ+ GGucnl9/quLPzXNZQUHqKBwvrldfB/YCW2gbLl3zWQnfT6ajFturx1QlR82kfZveOCZuPi6OVl iyM= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Jul 2023 03:15:22 -0700 IronPort-SDR: Q0nOgS7Eotq66p/yzdwdQ5wl6iqTYjdpxh9QYHA04crJazodW8T9KXuATSJsmS5I7jlqWWenQZ Fn37M6mvSLKl4r5GLRHOlnQ9CGqPKkpSe20CZhCK661R65yrcHCnQ5GUfigVU9rka+kibrFDAI +QBtrN9UrGOfXAqVufQQ3Gj3NijKWzJJMAoZJgkAT/kEvMkf5w+ZSEWkFwxRwDCdZ7YV1djoEm sFVVPuhjqAB1t4UdQlScmBpDc6D1UIc2+7eFuP8sGpdZRqA28OpXSQKwnniYbQgRPeH4N6M5BK h0M= WDCIronportException: Internal Received: from shindev.dhcp.fujisawa.hgst.com (HELO shindev.fujisawa.hgst.com) ([10.149.53.55]) by uls-op-cesaip02.wdc.com with ESMTP; 28 Jul 2023 04:07:22 -0700 From: Shin'ichiro Kawasaki To: linux-block@vger.kernel.org Cc: Omar Sandoval , Omar Sandoval , Chaitanya Kulkarni , Shin'ichiro Kawasaki Subject: [PATCH blktests 1/4] new: don't mandate double square brackets Date: Fri, 28 Jul 2023 20:07:17 +0900 Message-Id: <20230728110720.1280124-2-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230728110720.1280124-1-shinichiro.kawasaki@wdc.com> References: <20230728110720.1280124-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org It was guided for test statements in blktests scripts to use double square brackets [[ ]] form instead of single square brackets [ ] form. However, a number of patch contributors use [ ]. It is not productive to replace them with [[ ]] and discouraging contributions. To avoid those drawbacks, allow both forms and still keep [[ ]] as the preferred form. While at it, fix a typo. Signed-off-by: Shin'ichiro Kawasaki --- new | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/new b/new index e8ee5a0..574d8b4 100755 --- a/new +++ b/new @@ -232,7 +232,7 @@ test() { echo "Test complete" } -# Finally, some coding style guidlines: +# Finally, some coding style guidelines: # - Indent with tabs. # - Don't add a space before the parentheses or a newline before the curly brace # in function definitions. @@ -242,7 +242,7 @@ test() { # - Functions defined by the testing framework or group scripts, including # helpers, have a leading underscore. E.g., _have_scsi_debug. Functions local # to the test should not have a leading underscore. -# - Use the bash [[ ]] form of tests instead of [ ]. +# - Both [[ ]] form and [ ] form are fine for tests. [[ ]] is preferred. # - Always quote variable expansions unless the variable is a number or inside of # a [[ ]] test. # - Use the \$() form of command substitution instead of backticks. From patchwork Fri Jul 28 11:07:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinichiro Kawasaki X-Patchwork-Id: 13331709 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF0FC04A94 for ; Fri, 28 Jul 2023 11:07:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234397AbjG1LH1 (ORCPT ); Fri, 28 Jul 2023 07:07:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236131AbjG1LH0 (ORCPT ); Fri, 28 Jul 2023 07:07:26 -0400 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6FF62723 for ; Fri, 28 Jul 2023 04:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1690542444; x=1722078444; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5uoXmicthBfI1KVabTbY4/3y08MYGGWftLP6ljGdBh4=; b=RcxKaCeWcm5ZJwJHBSkNdOBz9CpXoRw2a7iW+vrEiwaMEsV4vywqu7EG nLs8ZFJclZEIMw5j3YEPEyqj07WL+45C8iwF1KDjh8s2tK0FQFAiw/hir WUq3RXPXkjY9RyoHY8RDIUeD8BXYPDvJzNRMMrPuB0KEq02DGPEGhmpyK yMc55FaxquxmQXdTnkXMrl2wijUyu27lBbuv/z/uZTctNNoJTTLbBuWwo WvGKXT1TzTulmlBhaULss36wjpjyMO9tINMlVF7kaZYSvHrwWnUKcUHlC ZmOht++9iBIfaOIYvKQxLf16f+KGczhvrJAm792pXs4J35naIvi7iCagV Q==; X-IronPort-AV: E=Sophos;i="6.01,237,1684771200"; d="scan'208";a="244001784" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Jul 2023 19:07:23 +0800 IronPort-SDR: PPz1IPpO6ylleguuMeOurcY2GRaZwOxFzPuMDjI0kxg+bcaP9goi+KgJzxVI7QrJvefdNM5UTZ tHEoaYUCUZzs7Y7xkVzq+OoHY+qttIdYybIYTpdHkqFmDTXAc2V+abBKbP1qh7S5oU02Qg37/I wbglwhilQHNfBhBcEbtGqsYVmGbXXMzURrNjPhF/UIzJU4fn0EvF0IkahO2Qxlp9uQTuw0OQo0 BtjzaB9TLhFUFX35X8kQJJhQWfv9eptlgHYFV00IHS9SP8R1D9hesTy4hrQyqgXssQ7Pj0LuHZ 9Nw= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Jul 2023 03:15:23 -0700 IronPort-SDR: 8rXByPWqjhDKaxoJV7Qj3uPXDYqbolEiqrqE1yZhHEeQ1q1UcPsMPX6e1g5JWVziLg5FGdEB/p AesSVTYwOK1fJEE6cVE/7gaCDEpcqv5H6KlSQ938AwmYqFirXj5VWr9PSylJTSEluWMh2kwCYV g5Wr9xSQFjk/x4BaRbFzwt7mXRO1fCWUq+i4gspzF8C+69QZ5h16KVHAn2xN6shSafpNIvINYj 6ceTqknthhQJ54ILrRSCzJUomOqeYLy9vQaIdrrblOfEqIMJS+63YxcGVRWiUOLPjo/OAIYbEa kGk= WDCIronportException: Internal Received: from shindev.dhcp.fujisawa.hgst.com (HELO shindev.fujisawa.hgst.com) ([10.149.53.55]) by uls-op-cesaip02.wdc.com with ESMTP; 28 Jul 2023 04:07:23 -0700 From: Shin'ichiro Kawasaki To: linux-block@vger.kernel.org Cc: Omar Sandoval , Omar Sandoval , Chaitanya Kulkarni , Shin'ichiro Kawasaki Subject: [PATCH blktests 2/4] README: describe what './new' script documents Date: Fri, 28 Jul 2023 20:07:18 +0900 Message-Id: <20230728110720.1280124-3-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230728110720.1280124-1-shinichiro.kawasaki@wdc.com> References: <20230728110720.1280124-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org The knowledge required to implement blktests test cases are documented in './new' script which generates test case script template. This is handy when we implement new test cases. However, it is difficult to refer the documentation when we do not implement new test cases. To help to refer the documentation, add a pointer to it and describe what it documents. Signed-off-by: Shin'ichiro Kawasaki --- README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 186fc3b..1324159 100644 --- a/README.md +++ b/README.md @@ -49,7 +49,10 @@ configuration and running tests. ## Adding Tests The `./new` script creates a new test from a template. The generated template -contains more detailed documentation. +contains more detailed documentation. [The ./new script itself](new) can be +referred as a document. It describes variables and functions that test cases +should implement, global variables that test cases can refer and coding +guidelines. Pull requests on GitHub and patches to are both accepted. See [here](CONTRIBUTING.md) for more information on contributing. From patchwork Fri Jul 28 11:07:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinichiro Kawasaki X-Patchwork-Id: 13331711 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBEDAC001DE for ; Fri, 28 Jul 2023 11:07:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236157AbjG1LHh (ORCPT ); Fri, 28 Jul 2023 07:07:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236142AbjG1LH3 (ORCPT ); Fri, 28 Jul 2023 07:07:29 -0400 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD55D30C2 for ; Fri, 28 Jul 2023 04:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1690542448; x=1722078448; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=URedivequX3b0zm/DhRlNP3wmBxItgwD4zhZNL0Z6Ts=; b=mm8gO/w4XUH+vXMSohe9zs7ZJjUqsNzV/oek9TPrg47wMZFQMT5QIBbL AbapXwe2e8w7ZMkar5q7sToj0za5TBrxNNspvLo88WiMlk+I8TqPm8e0S jVSB0/lOBNpxTv5BP11q85lyvgjbwwkiIzsYFKt9WtWegsTVoKvVaiCWF joYoke3R2bmuYBLemP/hr1UWuO1hraOWsoK1mSYs0SeWvnfLcsPyS5RxV T/qrTRNHT//KldRS1W3jpR8o51fMvRW+bQZ85hW+fqCOm9++d8M7hJc9z /TuNr7x+g1K0zyH+MKB3EFLoXpLFkTqkRdEnVNb6iJX0f9a9EWOuxuKVJ Q==; X-IronPort-AV: E=Sophos;i="6.01,237,1684771200"; d="scan'208";a="244001788" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Jul 2023 19:07:28 +0800 IronPort-SDR: A48ZoRyWXVPuLWQZal2fGPDWCvtulsgmzz6QogKIyIfRnVDUsAHvBzU0zw+Eu9nObMUlA1Mlhk svxGbgN51I53vLSmfEr9MxxYqNC7IfBO6RZTVS+OPwU53tH9xsxsS4DXpOwkG61c9+QY0GkaA7 Ab7YjGeMPPntmsDE1yL89h9rSK9BBimH4BZQWr5LwAT87brhQuUHjti2OiCG5K1XqEqzlTWqq8 Sd7tgSQC6tMhLZU9fGaMc402x4QLyuWQJFMTAz99ykgdQWVKza9CUV0REbWnKi627ufV1QfeQs YHs= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Jul 2023 03:15:28 -0700 IronPort-SDR: dmIZYIP9CWyLpWeWRFhX3yl/hchTSfAo9D2w2x7z+Qf1CyLxWPs39S/zT1c3VVMPWYPAl4YUy5 a4khgAG/6f58aYvpCFPC9Dwgb0TKDrIqJg+OylBjc4B+gPNAI7udDZqhYaN0xtrdNfWZt23iwk qLAnwBu1aA+sC42w7P9q28eNg1ey7Enfuf5GSz8tgtT4c/xOrTqB7luBTnF88DgOUcgQEPJJ8r YcBrP8Na91kxOThN6c5Km7I18GacSrNjcs+P3+wSyIfg5qZsFcI4etm9yjgAuDM/5V+Caemb4p 8v8= WDCIronportException: Internal Received: from shindev.dhcp.fujisawa.hgst.com (HELO shindev.fujisawa.hgst.com) ([10.149.53.55]) by uls-op-cesaip02.wdc.com with ESMTP; 28 Jul 2023 04:07:24 -0700 From: Shin'ichiro Kawasaki To: linux-block@vger.kernel.org Cc: Omar Sandoval , Omar Sandoval , Chaitanya Kulkarni , Shin'ichiro Kawasaki Subject: [PATCH blktests 3/4] CONTRIBUTING, README: recommend patch post for contributions Date: Fri, 28 Jul 2023 20:07:19 +0900 Message-Id: <20230728110720.1280124-4-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230728110720.1280124-1-shinichiro.kawasaki@wdc.com> References: <20230728110720.1280124-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org There are voices that blktests changes through GitHub pull requests are not visible to relevant block sub-system kernel developers who communicate through linux-block mailing list. Some GitHub pull requests in the past needed additional discussion in the linux-block mailing list again to confirm that the changes were good for the kernel developers. To reduce the repeated discussion in the mailing list and GitHub, clarify that contribution by patch post to linux-block is preferred to GitHub pull request. Still GitHub pull requests are open mainly for quick, minor fixes. Signed-off-by: Shin'ichiro Kawasaki --- CONTRIBUTING.md | 14 ++++++++------ README.md | 2 +- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fd232b7..74d9771 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,11 +1,13 @@ # Contributing to blktests -You can contribute to blktests by opening a pull request to the [blktests -GitHub repository](https://github.com/osandov/blktests) or by sending patches -to the mailing list and Shin'ichiro Kawasaki -. If sending patches, please generate the patch with `git -format-patch --subject-prefix="PATCH blktests"`. Consider configuring git to do -this for you with `git config --local format.subjectPrefix "PATCH blktests"`. +You can contribute to blktests by sending patches to the + mailing list and Shin'ichiro Kawasaki +or by opening a pull request to the [blktests GitHub +repository](https://github.com/osandov/blktests). Patch post is more recommended +since it will be visible to more kernel developers and easier to gather +feedback. If sending patches, please generate the patch with `git format-patch +--subject-prefix="PATCH blktests"`. Consider configuring git to do this for you +with `git config --local format.subjectPrefix "PATCH blktests"`. All commits must be signed off (i.e., `Signed-off-by: Jane Doe `) as per the [Developer Certificate of Origin](https://developercertificate.org/). diff --git a/README.md b/README.md index 1324159..201d11c 100644 --- a/README.md +++ b/README.md @@ -54,5 +54,5 @@ referred as a document. It describes variables and functions that test cases should implement, global variables that test cases can refer and coding guidelines. -Pull requests on GitHub and patches to are both +Patches to and pull requests on GitHub are both accepted. See [here](CONTRIBUTING.md) for more information on contributing. From patchwork Fri Jul 28 11:07:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinichiro Kawasaki X-Patchwork-Id: 13331710 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E32AC001DE for ; Fri, 28 Jul 2023 11:07:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234505AbjG1LH2 (ORCPT ); Fri, 28 Jul 2023 07:07:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236131AbjG1LH1 (ORCPT ); Fri, 28 Jul 2023 07:07:27 -0400 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D61FB2701 for ; Fri, 28 Jul 2023 04:07:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1690542446; x=1722078446; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=L7PLwRmCaJnOV181uckfuqpFHDHieZL5cZFhziRG4eA=; b=i5YKFZ/IH6F6rgZZZpdtjcWBmaE4gA4iZKr8AcvOKTLiRdu0EIhf5myl H1DjluP+flc9DGFG/A8nIsxFPUrXJQ8ivIcsppgSECKtzQjZT8vTUW3mq 2GrV0e7SZ7YdsdYOb/BA2FmI3OxcU2oEndAPL+0DYFsXE9LP5EzZA6CEw 2m86pjGJKNUpUmvTdW2i3f4w0SCFz4qEL2hHio5B4BLQTZVsLX92deGSc Vxb7ZLoeGUOacg16guL52xhd0v0ZYo/1+Ssl4sOY2N1uXnVGBNJT1vrgO dtS6UffxHEZoSHx0xAirHYWVYlN0JZRrkjX9vA+TA0a/ytsMz2jswj4l5 Q==; X-IronPort-AV: E=Sophos;i="6.01,237,1684771200"; d="scan'208";a="237709696" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 28 Jul 2023 19:07:26 +0800 IronPort-SDR: 6/jF3LgXCjfaCemAsf2kJcHSWAT4KKcky+S7+1+AZ8rb0UgRnJ+XYpwV36TWtBOwN9f/qADThr xvG2BtYcokphT9XtSEPi9f13Sh9pGTWhoIVYQXsv5PYo1Mc92zY7ffKlVBkq0ZQJbP3cNeRdkI pjWo8K9/zGxSOE5quDiAnpRurJNy4MpibxdOigREcI+qVCRwH4GIeR4xLnhbwghBErarf5FHBI jgfWpzcCkYMrqa76WjXWlE1D4UpvsUTwtgWryDnE3mTVjoVdMlfZbgOhcvusxqxq4e+b93fA6I Yvo= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Jul 2023 03:21:07 -0700 IronPort-SDR: lzbhMetSeLK7o9ClzZ3251QBdLziS1aHDBMjQ04aBZN24jO6ndVsqp8G4Xa63QPNp0+Au6Mt5g d0zE0EL7iQajrG214p21jvaB0bTX7P0OkWNKK9DZ8BbuU6LdCxdsAxkffjSUGzyHM8cc5pEdOE Cdtc1wdhjnoYkajXcGYCNNEdgfH25O4k2wneLQqYvVML9gl8YdaMylplDzAp4+Nrau/E2WzqDE TjJbaE+7qcaUb9G8km8NrwC/GWw6SsiDh2e8WoBSVgtteSnIAOHPIi5vNbiIPLnH8VIqRZa7r+ hI8= WDCIronportException: Internal Received: from shindev.dhcp.fujisawa.hgst.com (HELO shindev.fujisawa.hgst.com) ([10.149.53.55]) by uls-op-cesaip02.wdc.com with ESMTP; 28 Jul 2023 04:07:26 -0700 From: Shin'ichiro Kawasaki To: linux-block@vger.kernel.org Cc: Omar Sandoval , Omar Sandoval , Chaitanya Kulkarni , Shin'ichiro Kawasaki Subject: [PATCH blktests 4/4] README: clarify motivations to add new test cases Date: Fri, 28 Jul 2023 20:07:20 +0900 Message-Id: <20230728110720.1280124-5-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230728110720.1280124-1-shinichiro.kawasaki@wdc.com> References: <20230728110720.1280124-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org It is often questioned when new test cases should be added to blktests. Clarify it in "Adding Tests" section. Signed-off-by: Shin'ichiro Kawasaki --- README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README.md b/README.md index 201d11c..6610078 100644 --- a/README.md +++ b/README.md @@ -48,6 +48,14 @@ configuration and running tests. ## Adding Tests +New test cases are welcomed when, + +- a bug in block layer or storage stack is found and the new test case confirms + fix of the bug, +- a new feature is introduced in block layer or storage stack, and the new test + cases confirm that the feature is working well, or, +- the new test cases extend coverage of block layer and storage stack code. + The `./new` script creates a new test from a template. The generated template contains more detailed documentation. [The ./new script itself](new) can be referred as a document. It describes variables and functions that test cases