From patchwork Mon Jul 31 08:35:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13334029 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70FE7C001DE for ; Mon, 31 Jul 2023 08:36:07 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.572821.896867 (Exim 4.92) (envelope-from ) id 1qQONc-0001mm-Dd; Mon, 31 Jul 2023 08:35:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 572821.896867; Mon, 31 Jul 2023 08:35:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQONc-0001mf-Ax; Mon, 31 Jul 2023 08:35:52 +0000 Received: by outflank-mailman (input) for mailman id 572821; Mon, 31 Jul 2023 08:35:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQONa-0001mZ-Ek for xen-devel@lists.xenproject.org; Mon, 31 Jul 2023 08:35:50 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3fe794b5-2f7d-11ee-b254-6b7b168915f2; Mon, 31 Jul 2023 10:35:48 +0200 (CEST) Received: from Dell.bugseng.com.homenet.telecomitalia.it (host-79-23-62-117.retail.telecomitalia.it [79.23.62.117]) by support.bugseng.com (Postfix) with ESMTPSA id BA5C64EE0737; Mon, 31 Jul 2023 10:35:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3fe794b5-2f7d-11ee-b254-6b7b168915f2 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH] EFI: address violations of MISRA C:2012 Rules 8.2 and 8.3 Date: Mon, 31 Jul 2023 10:35:19 +0200 Message-Id: <83d4091852797044209272dab750f13f7d30d35c.1690792406.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Give a name to unnamed parameters to address violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between parameter names and types used in function declarations and the ones used in the corresponding function definitions, thus addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). No functional changes. Signed-off-by: Federico Serafini Acked-by: Jan Beulich --- xen/common/efi/efi.h | 2 +- xen/include/xen/efi.h | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/common/efi/efi.h b/xen/common/efi/efi.h index c9aa65d506..c02fbb7b69 100644 --- a/xen/common/efi/efi.h +++ b/xen/common/efi/efi.h @@ -49,5 +49,5 @@ const CHAR16 *wmemchr(const CHAR16 *s, CHAR16 c, UINTN n); void *ebmalloc(size_t size); void free_ebmalloc_unused_mem(void); -const void *pe_find_section(const void *image_base, const size_t image_size, +const void *pe_find_section(const void *image, const UINTN image_size, const CHAR16 *section_name, UINTN *size_out); diff --git a/xen/include/xen/efi.h b/xen/include/xen/efi.h index 94a7e547f9..942d2e9491 100644 --- a/xen/include/xen/efi.h +++ b/xen/include/xen/efi.h @@ -39,11 +39,11 @@ unsigned long efi_get_time(void); void efi_halt_system(void); void efi_reset_system(bool warm); #ifndef COMPAT -int efi_get_info(uint32_t idx, union xenpf_efi_info *); -int efi_runtime_call(struct xenpf_efi_runtime_call *); +int efi_get_info(uint32_t idx, union xenpf_efi_info *info); +int efi_runtime_call(struct xenpf_efi_runtime_call *op); #endif -int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *); -int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *); +int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *info); +int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *op); #endif /* !__ASSEMBLY__ */