From patchwork Wed Aug 2 14:47:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13338272 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 295D3C001E0 for ; Wed, 2 Aug 2023 14:48:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3401810E160; Wed, 2 Aug 2023 14:48:01 +0000 (UTC) Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B19210E160 for ; Wed, 2 Aug 2023 14:47:59 +0000 (UTC) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1bc34b32785so4717055ad.3 for ; Wed, 02 Aug 2023 07:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1690987678; x=1691592478; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=34jvrY9iaBvcRp6RfXdi/NZwehC55dKloV135LCo6Q4=; b=ApOIy6Oof+Qo/7c+FEtdZW+BbrbkSOoTTUlpREhL52s9a/El38htUsBtKsr3weJLV2 +dXMUNVFK2+BE/xrnKRHAvNi9FIBpWXkaWXaTtXCl42zHmAoBHaN6lSMr9nZMOEIOlD5 3y/xyRf8LbatSRznjLxKSft9jkvkndOkzb/hc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690987678; x=1691592478; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=34jvrY9iaBvcRp6RfXdi/NZwehC55dKloV135LCo6Q4=; b=NmOZhmZonTCte3CWkZR03vScwLYuWL6tfAUj1RPhV/X3h6RUDrGkpKaDZ39xzrpT1X xMVvbYgeSoB1vbuK+/dkia7CAJnjk+ntRQ0sCcyc6Eig+/QYxtxL+0QK563znNR3C9Uy l21GBo0L/AOo7BJON4gFKyTXWh8HB1KFL39d6zQS/VK6ooxf1Py5eLULc36dgqTvCElD ZRZiWxVVMRLKBeqQt9137RK+6v3QodjU5hW9Wo+dqzOv9JqZ3GCP6MMKyhmxRjMrEtYn EvtjkGM4yzLIvV+5xerDp03HyfqvSGZtHA/TVME5qTC/yzQLEu5pLcVOHriy02HuEPls +KLw== X-Gm-Message-State: ABy/qLbwAto43w7Gkyt4IaNAARNhcv5Jb3GWrdSndcflC+GgNFw4l25A gjP/GNGeLVJGBZ4TnfLW975I/vPy4taJF0DZKkJ6oJSy X-Google-Smtp-Source: APBJJlFPjUDZubqVQL75MLrA9AfOwS26wqtyyCObOSfWkCHMjUe1pBsewbKiHvHWQOXGvHbT0dlkoQ== X-Received: by 2002:a17:902:ed8c:b0:1b8:28f6:20e6 with SMTP id e12-20020a170902ed8c00b001b828f620e6mr13850468plj.34.1690987678407; Wed, 02 Aug 2023 07:47:58 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:6fae:ec4e:7f84:d593]) by smtp.gmail.com with ESMTPSA id b21-20020a170902d31500b001b89891bfc4sm12524139plc.199.2023.08.02.07.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 07:47:57 -0700 (PDT) From: Douglas Anderson To: dri-devel@lists.freedesktop.org, Maxime Ripard Subject: [PATCH 1/2] drm/panel: Fix kernel-doc typo for `follower_lock` Date: Wed, 2 Aug 2023 07:47:27 -0700 Message-ID: <20230802074727.1.I4036706ad5e7f45e80d41b777164258e52079cd8@changeid> X-Mailer: git-send-email 2.41.0.585.gd2178a4bd4-goog MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Thomas Zimmermann , Sam Ravnborg , Neil Armstrong , Daniel Vetter , Douglas Anderson , linux-kernel@vger.kernel.org, Linux Next Mailing List Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In the kernel doc for the `follower_lock` member of `struct drm_panel` there was a typo where it was called `followers_lock`. This resulted in a warning when making "htmldocs": ./include/drm/drm_panel.h:270: warning: Function parameter or member 'follower_lock' not described in 'drm_panel' Fix the typo. Fixes: de0874165b83 ("drm/panel: Add a way for other devices to follow panel state") Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/r/20230802142136.0f67b762@canb.auug.org.au Signed-off-by: Douglas Anderson Reviewed-by: Neil Armstrong --- include/drm/drm_panel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index d6c73f79c131..10015891b056 100644 --- a/include/drm/drm_panel.h +++ b/include/drm/drm_panel.h @@ -238,7 +238,7 @@ struct drm_panel { struct list_head followers; /** - * @followers_lock: + * @follower_lock: * * Lock for followers list. */ From patchwork Wed Aug 2 14:47:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13338273 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48F10C04FE0 for ; Wed, 2 Aug 2023 14:48:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FA8310E1F7; Wed, 2 Aug 2023 14:48:03 +0000 (UTC) Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8627510E1F7 for ; Wed, 2 Aug 2023 14:48:01 +0000 (UTC) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1bbf8cb694aso39176785ad.3 for ; Wed, 02 Aug 2023 07:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1690987680; x=1691592480; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VppVRXoXQvKZJkFtuRWaz8mbgEZARAeuezBGRcJyOiM=; b=hFYWlhmljE/klwppV++NKW84d/Eesf+FCOvycpSLv1wwCQpDOYdQA/icP3xC4HHRIF 7Rvw1vD7plGgiNUFEdgMDG9B+49Prm8n3Uf6scoED+cjMOwuZHCogoPVhnADisSPHX3p HBDr52caGrX81FAcSeufVdwOc1PdpTXeZz/FI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690987680; x=1691592480; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VppVRXoXQvKZJkFtuRWaz8mbgEZARAeuezBGRcJyOiM=; b=UTs2Hjgfv8Gi2M+IRCjfkIAn5MjWdcxKYCKGZiCuHdq3FnHwJyQGtrTy8bRzlwxW6f jjleEs+uvP8KI2hGU07LEmK45ErKx/3T9VH4MfLx2n1/c3ZMSRQz3ZBrenB8d+OOR9Fo TgZA6Kp3tFF+j2DRH9MAOGWRlc0lSgnRCBzSmrRO4tGfzE2CajYvFO8e8eudDhwJyBl8 o5Aft2jZoKdGOi0Y6BF4AQ1N8G/oy6QKv8IymC8v+KtqiPnkqSMnGYOWevwLS5EXg1XW oepD0NYmvFEdC6saJAFVV3ulSbcx6frMPsaouO/WkjeiJW1OJOPhs8IYA3L9Deri5z/7 n8SA== X-Gm-Message-State: ABy/qLYFGq+knnU5NxPv57UNIRFF7ZphbvfJKMi26osHUl9s2CNkx4hd Q85FWIfQaq5W9VlyTiNeDwwetAHFXeTMQOTq68wKmUNN X-Google-Smtp-Source: APBJJlEnKVmSw5s+REAmb9vIHaq2YjWuJwo5aDKSmHQblkNG/fsPSQTcTnzDbOCmKARtJsRK9TdsIg== X-Received: by 2002:a17:902:ec82:b0:1bb:9c45:130f with SMTP id x2-20020a170902ec8200b001bb9c45130fmr19124197plg.69.1690987680161; Wed, 02 Aug 2023 07:48:00 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:6fae:ec4e:7f84:d593]) by smtp.gmail.com with ESMTPSA id b21-20020a170902d31500b001b89891bfc4sm12524139plc.199.2023.08.02.07.47.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 07:47:59 -0700 (PDT) From: Douglas Anderson To: dri-devel@lists.freedesktop.org, Maxime Ripard Subject: [PATCH 2/2] drm/panel: Fix todo indentation for panel prepared/enabled cleanup Date: Wed, 2 Aug 2023 07:47:28 -0700 Message-ID: <20230802074727.2.Iaeb7b0f7951aee6b8c090364bbc87b1ae198a857@changeid> X-Mailer: git-send-email 2.41.0.585.gd2178a4bd4-goog In-Reply-To: <20230802074727.1.I4036706ad5e7f45e80d41b777164258e52079cd8@changeid> References: <20230802074727.1.I4036706ad5e7f45e80d41b777164258e52079cd8@changeid> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Thomas Zimmermann , Neil Armstrong , Daniel Vetter , Jonathan Corbet , Douglas Anderson , linux-doc@vger.kernel.org, Linux Next Mailing List , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel") the formatting for a code block was not quite right. This caused an error when building htmldocs: Documentation/gpu/todo.rst:469: ERROR: Unexpected indentation. Fix the error by using the proper syntax for a code block. Fixes: d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel") Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/r/20230802141724.0edce253@canb.auug.org.au Signed-off-by: Douglas Anderson Reviewed-by: Neil Armstrong --- Documentation/gpu/todo.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index aa0052f9b93b..139980487ccf 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -465,7 +465,8 @@ Clean up checks for already prepared/enabled in panels In a whole pile of panel drivers, we have code to make the prepare/unprepare/enable/disable callbacks behave as no-ops if they've already -been called. To get some idea of the duplicated code, try: +been called. To get some idea of the duplicated code, try:: + git grep 'if.*>prepared' -- drivers/gpu/drm/panel git grep 'if.*>enabled' -- drivers/gpu/drm/panel