From patchwork Thu Aug 3 09:17:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13339703 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64AD4C04A94 for ; Thu, 3 Aug 2023 10:31:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ikhrcTlnt8bDyDebDxvwlpqE+0kkLqMJBP6hJ61SZRo=; b=LaGBmEEITQF0Cn DYOdX/AHdqAY5eS9MnBSoCHBBqJCSH8W5N+f4FBdPtVEtKZ2HxAFfwxxTDVnbtccogDPA9aziYRhP u3wi7j6StkHjNtFfRpOchVWUUOItlcUADXwu0BPBqtkfF4Sai6I1TMxxzWIt0UzLzLo8HPXZib6wz v8eARSQ4YkQTlCzwxeKQPdz1LuLQCed6mtwClHnpqHgGlk543/5HJQR9CH9qWXQT4ReAChJJ10pBk cIA2Q27z2HMTHwRaox7cbwzLNrnkqVu91bhcxeinF5pkvZBRmLdasSsvMTYjGE1Lblq07zip6ufZt oETH5VQd7iacRWWd/Pwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRVbb-007Mvv-2j; Thu, 03 Aug 2023 10:30:55 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRUTd-007AKa-05 for linux-arm-kernel@bombadil.infradead.org; Thu, 03 Aug 2023 09:18:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=Rh9vrHdK4KqwRtkpA9D1DmTbianpSUaHPmcCSHf5Lx0=; b=C//2g1QkX3rHIWylz+37a7ZYLU Zmw6LHMRJHNC1b3WFRPoP7r7APoYJXHTQ/LwILv/xUkwcuxHjFIj4YeZhlJNqzgqLjL2cCAPMfRPd ONllZKPaKIEoXY3BvJXn9zleEx+Ajbe2L0dyRUuTaLLYlkLuVy4tZqLA8rpmAr9omOLRR48wlE+Tk 0x+5v5B+fIbcLX+QLlOjAcyZv8JDGaXueojIuNIvmmjxJNkFw0rt3ZK23jM7JHw0NS4VQFsuRJw9+ HXHY4sj6xucZDiSfmFBI/4dI6k3CRncre1WzlvF047MU7zAauFhIuh26sH9ByovSbI+3/SRmifSJu ayqfeYIg==; Received: from szxga08-in.huawei.com ([45.249.212.255]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRUTZ-00GiB1-2Y for linux-arm-kernel@lists.infradead.org; Thu, 03 Aug 2023 09:18:35 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4RGjsb3rgLz1GDSH; Thu, 3 Aug 2023 17:17:07 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 17:18:10 +0800 From: Ruan Jinjie To: , , Greg Kroah-Hartman , Jiri Slaby , Michal Simek CC: Subject: [PATCH -next] tty: serial: xilinx_uartps: Do not check for 0 return after calling platform_get_irq() Date: Thu, 3 Aug 2023 17:17:12 +0800 Message-ID: <20230803091712.596987-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230803_101834_272022_41DCB66B X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid"), there is no possible for platform_get_irq() to return 0. Use the return value from platform_get_irq(). Signed-off-by: Ruan Jinjie --- drivers/tty/serial/xilinx_uartps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 20a751663ef9..2e5e86a00a77 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1562,8 +1562,8 @@ static int cdns_uart_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - rc = -ENXIO; + if (irq < 0) { + rc = irq; goto err_out_clk_disable; }