From patchwork Thu Aug 3 15:04:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13340246 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE21BC04E69 for ; Thu, 3 Aug 2023 15:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236832AbjHCPEk (ORCPT ); Thu, 3 Aug 2023 11:04:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236820AbjHCPEj (ORCPT ); Thu, 3 Aug 2023 11:04:39 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F37330D7; Thu, 3 Aug 2023 08:04:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HlsX/KeernljT2nobDIb5Q5Fh5doOhjQAlWxoIRGm2myPoCuOfzWVZDcBgS4H2radw2Hti2QkXXeiTYQWzS/cRTcYrLoMoKZf5Z140a72WfTadEVqMYSi5FxYF5KU0Vv7kaRGwgx6AxmRk1W8fn4olXv32Y0LC5YPrAonBVueVoCadi7Xz4m5Dv4R5UdAy/ikVOvkNMeQMEk8xNfhn6iRvv0HR8k8B8qMfv15ldz2NCFEmZXPu2gULztQ9uVEI6kx9Vhha3dpNetld1TafgHTA3zj3149khgJsRyoOhx11QuVXmZQnXi4X3Ga7xmO5DeYiYmElLWCOetHKHxrXgMEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kD/znj39K7OopIjlMAM1QWmL7+eY1yePDeR4tqNfJ1s=; b=JCZyYK3MEs/9wisk2y4gwsxKM0OfPcGeQn9hGV4Tf1lGQj7kWxyHl43nuhnLNCHf3TSuauTuX3klrkoGlGRdds87vNFm9S0mN9K0I1IWRCbG0xigRiv1aLUOmbLuA601S7QLMSlf1Z1Grb8uwhWz5WsM6zddmKWsk5lSB1dJJ2kRj8HeNqspDDXR6c3IRhb0iru+qRcqMx/HKk18lFxTB7q05fw3cdBeFGbBkoOAL6q0Y+Fn/EiXM2nCzNN73IMcl2n8lqTwADk2a103ykY9Yhh6YJnTD2Mm3YPFliF+kv0G8sXdTOqTrvPW46QAMjd3cq2AtHcJzCD4I2BDfZOEUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kD/znj39K7OopIjlMAM1QWmL7+eY1yePDeR4tqNfJ1s=; b=iHHl+zrCET4DCReWQfs3tmXGiHCn4tt/VkkumSFP4HloUkFgEuO4fd9S0CU+Q0ezadCgp+Smxh+pDbxKsTpklNykL6vIlfdHt2cYwpsoCE9awlBhd+0s3Hdh9Q5Fo9Yn1QzmuPl16ExQWeES63qD7qX8CTOhRBfEp/luzK8o8ro= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AS5PR04MB9769.eurprd04.prod.outlook.com (2603:10a6:20b:679::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 15:04:37 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::d0d5:3604:98da:20b1]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::d0d5:3604:98da:20b1%7]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 15:04:36 +0000 From: Frank Li To: helgaas@kernel.org Cc: Frank.li@nxp.com, bhelgaas@google.com, devicetree@vger.kernel.org, gustavo.pimentel@synopsys.com, imx@lists.linux.dev, kw@linux.com, leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, mani@kernel.org, manivannan.sadhasivam@linaro.org, minghuan.lian@nxp.com, mingkai.hu@nxp.com, robh+dt@kernel.org, roy.zang@nxp.com, shawnguo@kernel.org, zhiqiang.hou@nxp.com Subject: [PATCH v8 1/3] PCI: Add macro PCIE_PME_TO_L2_TIMEOUT_US Date: Thu, 3 Aug 2023 11:04:07 -0400 Message-Id: <20230803150409.271155-2-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230803150409.271155-1-Frank.Li@nxp.com> References: <20230803150409.271155-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR03CA0161.namprd03.prod.outlook.com (2603:10b6:a03:338::16) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AS5PR04MB9769:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d7e64b7-4aaf-434b-86c2-08db9432f405 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: un8k+01l+6bLlB2n2RaM7ZLQYhygJ/AjTXUMH5H9hjxoBaOvhClAHu7Skn5zLUe5RNxNu80uBrPcA56hgjP7ew0ua6B1ofhA8uQeF+tVt+9Qz31VdFTKWRtn5C+WNroTMs7Atxnv0WvQQh+PhNm1QRFKFdM3cui/jBEmEf0Ing5BYYk8j4lPJnbrSXJw9ryLVm9Q+UkQBYhtCYi85fQ8MiHiWbP6MiHMgBi9tv6cjJMwdiM/E3nQ0dGI9MY2zffcWLL91n/8LxpE1+kxhmrlqN66g7/f1l3tBrmOFxZntcbAUHu0fDuDmEYzUxxtVzxiJp7SZG8CL3iLCTVwL8mvc8WV0j35cos0gjLHZspOJJRhAtyF6M4ozfQcq6iucu5/NMyGJ/D3CkYrS6kCQZGvlH7lebB3UWfQGSJ1fj9BYr6e4ajEyS+RrtE1Clgqx0eiMBz2IHBVczzS86mmrGzhDu6feapdBbSnBw1Vf1dCJJEjABERDN/CvhOLW6StPAboenhy+3gqkc3OFVRuNzvoUhXQcm6YFhemFmzh5Ac7xgS6aPo3ovYcyp9jDj0McSx2ZgAyg8urmxhz68xFNMd1ENTqwlZGn4JUCMaEDqIsppsBJr8HiHQUhajwuRC1v8qm X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(136003)(396003)(346002)(39860400002)(451199021)(52116002)(1076003)(2616005)(6506007)(41300700001)(26005)(186003)(8676002)(8936002)(4744005)(66556008)(2906002)(4326008)(66946007)(5660300002)(6916009)(316002)(66476007)(7416002)(6666004)(6486002)(6512007)(478600001)(38350700002)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 3mbh7VLUyjaOR/e2/h9F0rU09MRe/Ao3lrIqvDEaVLGEjJNpz6YMnx4+PpayE6cZqbAnPT/iKvpk0EvIQlimPy8wjVgwPgJAwiBBddGAox1iWZEE1oC4KZ6TYcVJLM0DHp4CGUL5q2xr0Hh7swCas9IceUDhrmDynVb5ROQZ5t+A4RQv5LLFzdtcbHmtkXuC2uDhGucepdggPzGkQU0v1hjqqJ9suRrKGSixsUWT986Nyut/F3+B9c8Tilqh5q0/NixNYmquoZOQpXvI2tcfVwUR8Zqew9uHK1kO+Era2Jt0TQQDRtPJM6Y9kKDq6iKl+VkP5VmtU+i8eCbqRIFqayoseE37YzVAES3m/FWotkAqessGdw2doStjhE5+kkbbR5a+5ldvtlsEBpd8Gcqyih3BTx28dAn2RQWMYsEodhEzPH++NvCkdj+6XqP/c5n9GS/ITujYfnSN2ODzd3G+SKvTlYtWJx4Q+ecoLTh4ZLl0QYZwRCRD884Gh45fSdHuxw1B4COSkZKkzrnvSARQ+TptTq7aU5O0uJo5J70eL3olKgkIupsH7Q8HxrzlALWa5GrS9CaW8QEoo8Qk+aueswYk2hAPyXyYFRm6BW6xzXhDby5t6YO6KYPMPNyy7zwjxAFi3XOQTEe48v2McVF5xoZjUqK3VrkOpyd7pPzM0MO4djvNiYOctZxm+76ug2yySca2RIqk2j/mans9u1B6j4TZix7TXINvmG8wl57fRl3hHX74zflHwlpojdtnb4T2ElmwFIUSzF9wGSB/OU75/hQXbY/idwBqUexgr6X0JfDq3hKr36lxxkN7/wV6Kf9ZGPWoAzfDa5MgVGF9b/W4ZlX9tyY4t8eIZitixaBrWstXIfVRNqlPIBuB2/wxB4G3J9n900ghh6lB9uhMD2aGq5HaFbSkgZGCTHhdJx+MtCB8kq4cYpsUwwvFbz6r94X+vhKuPCOkBiMCP1+8YQD0qTGECBF+raHLYpyIHN3r4YyX9KhWN7QpMcrHM43daOUO1uZP/vvRej5KZzYI++AQ+oh/EFGZcBiqfVU4eIhsVPF6+00HqP6uGi0nHNaidDqQX2YR64ERHpo+1p+Fpe+omI2LwBDdlii3vCQcmH4ficXFzgO7xCVopqp0uWP56orNkZ/csk2rBOnjmYSUXpJ+oYu++ShSZMUH9ppvCzbgm5Bcvvgj4j2sn0h8xaWwuInSdKBuXqUSW8v0XnD9RmV9t+TXiw/W8B4FMWJBdWvxbqyD22V2GvJsp3+nH5ZeXtJY5yGNOQ3Hst1JuqxyHaYmRvyUR7+6m6rRaUBhpr9Qu7roJ2QcO5Rph5GHzq2KaJJSAQM3wbxCR0yC/aVA6AUxzA/5HNNtRgB+SBZUrOM5vBLvTgLdMnfd+Ojup4pbIQ+sgn3HuLCMBXxiY4se1uo8kysqwL2MuFOO6FqxLRXktStdvktoXX0vDPiEo3NrUYwHVB6FIGvxFZECeqUo9lsF+N3Pe277/o10dwxTircKcWQPuLsgeJh/LWjWF3rjAMW6hA7mSIO+zHleVzVCwqUyYp9eEGOQXdCPqyvrs1iqoIzEqjSYZbMQA+ooKs+FRPMw X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d7e64b7-4aaf-434b-86c2-08db9432f405 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 15:04:36.9255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oAQzbmHvXVdUPp6FCDyQX/97udVYufFjDRy+98XL61QfiGtkGnuTIb38/SHbgJftDS7DeVMr1nWTAJnVErpI9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9769 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Introduces the PCIE_PME_TO_L2_TIMEOUT_US macro to facilitate checking the PME (Power Management Event) timeout in the PCI subsystem. Signed-off-by: Frank Li --- drivers/pci/pci.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index a4c3974340576..da8156663c825 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -13,6 +13,12 @@ #define PCIE_LINK_RETRAIN_TIMEOUT_MS 1000 +/* + * PCIe r6.0, sec 5.3.3.2.1 + * Recommends 1ms to 10ms timeout to check L2 ready. + */ +#define PCIE_PME_TO_L2_TIMEOUT_US 10000 + extern const unsigned char pcie_link_speed[]; extern bool pci_early_dump; From patchwork Thu Aug 3 15:04:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13340247 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 480AEC04A6A for ; Thu, 3 Aug 2023 15:04:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236848AbjHCPEy (ORCPT ); Thu, 3 Aug 2023 11:04:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236858AbjHCPEu (ORCPT ); Thu, 3 Aug 2023 11:04:50 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2087.outbound.protection.outlook.com [40.107.22.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D6F23594; Thu, 3 Aug 2023 08:04:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TIqDldt3RKAbSeELLmKRAjbMqbNiuikDIuMh6JEQyRejXH0Xcwc6qzivJQv+Kvz21LILloMGgOPDIVVahXVssd4hhsnwH/1b2I8mNde6p0NtsAOcGvMjt68Cz2/PoUiYsOHdd0DCIY/pQ9wyExgj5Gr2z7CXMMzY59xaT+Cy/Ev0kGufiPfEezBah4qbXKL6b8WBbAVDA7YY7FzN7eKbwwU94IARXUx9dEsH8KNVmRf4LKXnVoa4EOgg/FCOdOBB/PPLwnWiftKmuGh7BSizJPt2iuC7d8EUTUdzWsrdZrVcpu3blOFNx2G9ocl8S1U2TuoJwgN+EjBfVyU1CIudQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MyVgJIG1xUEiHEFU0XONJstUNCHuMZBkvO+gavYseuE=; b=c4hX7P8JzxoEtVE+vv4hcqAqXfqX05ZVyGJg801rdV5jg40pmab+WnJprW86LSPQWa85GirXBTcbApxNpRFUsmGKWsREibPdXMS3VRM6A3O1MuEJy4zNpLYE/gnU7OodjuedIt9eTb0VVJBwir2bsPXx6n8f+0lK74yAQeJ0vUTbfg/6J1X2cwuC1OWMwGtKrqCaj2YaT32k4NHINJyGhc0RDiO4SIOr1EjvlHFTNUfuqmSMXgW1puV6l7xoTfig9FYOEJ0lrR5GIpJV3bx1ITsGYJ7jppd4+1CCNJLwr8B4M/xed1OwSr7+PupUrFoybic4SZ6Dv315pV+E10hhtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MyVgJIG1xUEiHEFU0XONJstUNCHuMZBkvO+gavYseuE=; b=BisPwixGd5rvHkpj1w3l4H3EUK0O/bHdDsbbvIOuU8D9YA2cBCptzQbjogUpCUlX6eqUjzOlniHub4LgmCiVbZJUR5AwW8SV+WpJRyBWpsvJpQc6E2kEnuxJRjvHpfIMXDOHuRkuyPP7F1w7mTyUzJZ1cVct2Tyf8Lr1rE/xROg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AS5PR04MB9769.eurprd04.prod.outlook.com (2603:10a6:20b:679::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 15:04:42 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::d0d5:3604:98da:20b1]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::d0d5:3604:98da:20b1%7]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 15:04:42 +0000 From: Frank Li To: helgaas@kernel.org Cc: Frank.li@nxp.com, bhelgaas@google.com, devicetree@vger.kernel.org, gustavo.pimentel@synopsys.com, imx@lists.linux.dev, kw@linux.com, leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, mani@kernel.org, manivannan.sadhasivam@linaro.org, minghuan.lian@nxp.com, mingkai.hu@nxp.com, robh+dt@kernel.org, roy.zang@nxp.com, shawnguo@kernel.org, zhiqiang.hou@nxp.com Subject: [PATCH v8 2/3] PCI: dwc: Implement general suspend/resume functionality for L2/L3 transitions Date: Thu, 3 Aug 2023 11:04:08 -0400 Message-Id: <20230803150409.271155-3-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230803150409.271155-1-Frank.Li@nxp.com> References: <20230803150409.271155-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR03CA0161.namprd03.prod.outlook.com (2603:10b6:a03:338::16) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AS5PR04MB9769:EE_ X-MS-Office365-Filtering-Correlation-Id: 526d092b-2539-47ef-b564-08db9432f72d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LH5sID4tVn45zVeow7pQWF8+WtKJDg7hGRO9yphr28A4/yRMvwJzTD7+rWrIbmEgNMJW2J7CbmFzrfzuiQBNG5DG7I+CtwGT43QVsM4M8JnL54Rl81jrWZG0m0P4lfSA0X4NbyrjAYwTn/WM3zqEzEH4/UeO5Q/tsxu30krBMbGmEapOvzpuAYHJC5TjJueRnNaTvbkk/NFpNOc6IuEqzR4E+qz76MW972tfL9X43xBIBJLyFDpi4NvS0xHC3bP6hYidPmajIS6xMy+Hiw9KYtOUCQYRuqlMkJ6KqpZvRJNrmPA2JJeaUL4qvGmXg4jq1RTOmCSwTPzFRr5/vkzAd07tlZSmDFaLJHOZ4fXuNpYin3qK/iZpmvIryy7MTUiDE0zMUxwYgsLM7lQ9+axHIfhXsNHDqJjLvhTC2hsiBDprwn6ODPAosWI181B7Xb5ZB0ZEk8eVuGoTuX/W+FvWpUfIi9dyhImY02thKcnJDux7CB8xgzPzqZQILoML4Am/XPJF+/tCZj/tb6I386IET/BlRZBoGtuJblBUhawulpaE69pg4svMLp6+YFkpD0xLR7McJlehXTmiIGpPZ7yQTXIdywUTu5n072RtXFmqH6Z58CO8xdo8vUeRSY63yr6U X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(136003)(396003)(346002)(39860400002)(451199021)(52116002)(1076003)(2616005)(83380400001)(6506007)(41300700001)(26005)(186003)(8676002)(8936002)(66556008)(2906002)(4326008)(66946007)(5660300002)(6916009)(316002)(66476007)(7416002)(6666004)(6486002)(15650500001)(6512007)(478600001)(38350700002)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rttyeW+evlMDI1KTl/YDiVRllTF32+KgPvY+Tk2IVTCgFjSRL0f6xlAouM04QwZ+qMqKMrWrCQVOdrBbA11rc5Ke+rn7fZEf5nKHBK1NSav9HGKru65xCZzBE0WiDa9kI/4drKq121NpNdzjq75ds0Qm4l/kE+QPZeqaZabIDf84uz1jP817knXh7VNhyifwlbkMjNZ9v0KdZX4PYn0rd0foeafGpGyvmZU4+k3PVSrshQqOr8AAby+KEREz736j0GjN0AAmx66njK7aY57D8jD/ZfPekGfKyfd52Yrl+9LY/Tzg1jNgT1G4aa9cubqgraYP12L0yjIni9ohXxbiPm8LIzTSdtaiFO4/TO+qRV6GK/05aNQxyp8Y/ltP5QDBCIGu2mYPA52E5be37JuL9J4LVF9jpfczN4m42icgSrIg7gbvQ/oNyF6Ksg867+qtpDZ/lfmXq3+l0VNdb+DKo+mTFxIS2oYn5a8RPThpHjXWbRBbbYi6b0xT4izw9y0plZqSfEQMLJbwS1DtMEGMUZnI+d4k3IQtKKiuIQtSKEF6uAoEiWzejDMrv1mBr4JV5ljvf26/eKg/ao7Mbz0KhtO9PMIKhpZRNWeFmZdp/pzQbCwlFsfh/GKKF5ldVOudctz+C22eUDBHsrpcIC+ItZTgNzF8NDn5a8dXRRwYOLh0ej6t8fAoDgQuIKsznsL34dR61JIS3jNuNg1BDhnKVeLGCtP4OXchLNcknEpUM7R3RNh7HhHatxdzwCXZEXZNNDdUt2pIN9D9c1wkLwnB3og+IzjtJRzb+umNEFnSUcqHXn/NvRhzv/Gd01aPHVFmCR4CmVhbbslRm+ZVXSnJsO7OETCorRRWQuKfXHASr/EME/yPE8t7vVQ/6UpKLwlMSv3bRcxJwcr+7vV1NV8NqQMze1SloEePLWIe2zeE2ztdHl6l1su/N+M65C+OwfhdaOFhyT8+CwOfxVN8+Lou522IZJYh9NRb4Jaq5C+RIITBGVYa7rkQI2uG3HUrdj3OdKJ/KaenwBLwZF8TuHZpn/VmHrk5Byk4YK38o6eRIGPKBRRVSxV4kzLTphiMSJ6IH1rHDR1DrM+KrihP4Oh1L25kDg9gFhJIxBeyUuLx/84sftefilhfDzH0u8CyDHr5GvVW+Elz/WFF39daWWOReF0iBCdacS/+BgOLub2NoR74a2XyJ/gqoSLUhXB5b9MUaUrxcR4Jia5wgg1+6ASvYuoibDUCVzZ/yiyNdKZ/lh/Hm/u+w74mraGlTWtz331TXHBnl6/eOTl66hGY1TJ26rXNEfFQzxG/z0zO6VY2kSonJlxtgQYpipVBd0NilMoHmhsHfZXJU37nSyXxPpq1BWn49iQkKHZFFgha9It6xtuvZwVpint+s4ZqBKM9PTbiEY+KT6+/5NqZ/g3te9u/ceTwaWPxD6HHcpzRzhLeEwGgDl31nwz1WWBdj9ue9BEj7Qeo05ncMFS+mFWv8JitCynO/y/FzM95QKlT6/tiboBVw4hc2QES6zPhbyGDGt0SQ7DRLHQJZK7dsk2MrQ1YVdXzm+3nE4S1YAAiLePrPeuz9n8u6bNc0G+F/3DYF21y X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 526d092b-2539-47ef-b564-08db9432f72d X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 15:04:42.1278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cGyTh6jAQ/TgTdEXWKsoKMpVmTpDpUtqXRTVN4ZY67nOE4Gt9+evVa+l+0O4mVyW4cLghRchXcLnk6a9s6UaEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9769 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Introduce helper function dw_pcie_get_ltssm() to retrieve SMLH_LTSS_STATE. Add callback .pme_turn_off and .exit_from_l2 for platform specific PME handling. Add common dw_pcie_suspend(resume)_noirq() API to avoid duplicated code in dwc pci host controller platform driver. Typical L2 entry workflow/dw_pcie_suspend_noirq() 1. Transmit PME turn off signal to PCI devices and wait for PME_To_Ack. 2. Await link entering L2_IDLE state. Typical L2 exit workflow/dw_pcie_resume_noirq() 1. Issue exit from L2 command. 2. Reinitialize PCI host. 3. Wait for link to become active. Signed-off-by: Frank Li --- .../pci/controller/dwc/pcie-designware-host.c | 75 +++++++++++++++++++ drivers/pci/controller/dwc/pcie-designware.h | 28 +++++++ 2 files changed, 103 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index 9952057c8819c..ec0bbd8bab40d 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -8,6 +8,7 @@ * Author: Jingoo Han */ +#include #include #include #include @@ -807,3 +808,77 @@ int dw_pcie_setup_rc(struct dw_pcie_rp *pp) return 0; } EXPORT_SYMBOL_GPL(dw_pcie_setup_rc); + +int dw_pcie_suspend_noirq(struct dw_pcie *pci) +{ + u8 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); + u32 val; + int ret; + + /* + * If L1SS is supported, then do not put the link into L2 as some + * devices such as NVMe expect low resume latency. + */ + if (dw_pcie_readw_dbi(pci, offset + PCI_EXP_LNKCTL) & PCI_EXP_LNKCTL_ASPM_L1) + return 0; + + if (dw_pcie_get_ltssm(pci) <= DW_PCIE_LTSSM_DETECT_ACT) + return 0; + + if (!pci->pp.ops->pme_turn_off) + return 0; + + pci->pp.ops->pme_turn_off(&pci->pp); + + ret = read_poll_timeout(dw_pcie_get_ltssm, val, val == DW_PCIE_LTSSM_L2_IDLE, + PCIE_PME_TO_L2_TIMEOUT_US/10, + PCIE_PME_TO_L2_TIMEOUT_US, false, pci); + if (ret) { + dev_err(pci->dev, "Timeout waiting for L2 entry! LTSSM: 0x%x\n", val); + return ret; + } + + if (pci->pp.ops->host_deinit) + pci->pp.ops->host_deinit(&pci->pp); + + pci->suspended = true; + + return ret; +} +EXPORT_SYMBOL_GPL(dw_pcie_suspend_noirq); + +int dw_pcie_resume_noirq(struct dw_pcie *pci) +{ + int ret; + + if (!pci->suspended) + return 0; + + pci->suspended = false; + + if (!pci->pp.ops->exit_from_l2) + return 0; + + pci->pp.ops->exit_from_l2(&pci->pp); + + if (pci->pp.ops->host_init) { + ret = pci->pp.ops->host_init(&pci->pp); + if (ret) { + dev_err(pci->dev, "Host init failed! ret = %d\n", ret); + return ret; + } + } + + dw_pcie_setup_rc(&pci->pp); + + ret = dw_pcie_start_link(pci); + if (ret) + return ret; + + ret = dw_pcie_wait_for_link(pci); + if (ret) + return ret; + + return ret; +} +EXPORT_SYMBOL_GPL(dw_pcie_resume_noirq); diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h index 79713ce075cc1..cbba3ed19b3c0 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -288,10 +288,21 @@ enum dw_pcie_core_rst { DW_PCIE_NUM_CORE_RSTS }; +enum dw_pcie_ltssm { + DW_PCIE_LTSSM_UNKNOWN = 0xFFFFFFFF, + /* Need to align with PCIE_PORT_DEBUG0 bits 0:5 */ + DW_PCIE_LTSSM_DETECT_QUIET = 0x0, + DW_PCIE_LTSSM_DETECT_ACT = 0x1, + DW_PCIE_LTSSM_L0 = 0x11, + DW_PCIE_LTSSM_L2_IDLE = 0x15, +}; + struct dw_pcie_host_ops { int (*host_init)(struct dw_pcie_rp *pp); void (*host_deinit)(struct dw_pcie_rp *pp); int (*msi_host_init)(struct dw_pcie_rp *pp); + void (*pme_turn_off)(struct dw_pcie_rp *pp); + void (*exit_from_l2)(struct dw_pcie_rp *pp); }; struct dw_pcie_rp { @@ -364,6 +375,7 @@ struct dw_pcie_ops { void (*write_dbi2)(struct dw_pcie *pcie, void __iomem *base, u32 reg, size_t size, u32 val); int (*link_up)(struct dw_pcie *pcie); + enum dw_pcie_ltssm (*get_ltssm)(struct dw_pcie *pcie); int (*start_link)(struct dw_pcie *pcie); void (*stop_link)(struct dw_pcie *pcie); }; @@ -393,6 +405,7 @@ struct dw_pcie { struct reset_control_bulk_data app_rsts[DW_PCIE_NUM_APP_RSTS]; struct reset_control_bulk_data core_rsts[DW_PCIE_NUM_CORE_RSTS]; struct gpio_desc *pe_rst; + bool suspended; }; #define to_dw_pcie_from_pp(port) container_of((port), struct dw_pcie, pp) @@ -430,6 +443,9 @@ void dw_pcie_iatu_detect(struct dw_pcie *pci); int dw_pcie_edma_detect(struct dw_pcie *pci); void dw_pcie_edma_remove(struct dw_pcie *pci); +int dw_pcie_suspend_noirq(struct dw_pcie *pci); +int dw_pcie_resume_noirq(struct dw_pcie *pci); + static inline void dw_pcie_writel_dbi(struct dw_pcie *pci, u32 reg, u32 val) { dw_pcie_write_dbi(pci, reg, 0x4, val); @@ -501,6 +517,18 @@ static inline void dw_pcie_stop_link(struct dw_pcie *pci) pci->ops->stop_link(pci); } +static inline enum dw_pcie_ltssm dw_pcie_get_ltssm(struct dw_pcie *pci) +{ + u32 val; + + if (pci->ops && pci->ops->get_ltssm) + return pci->ops->get_ltssm(pci); + + val = dw_pcie_readl_dbi(pci, PCIE_PORT_DEBUG0); + + return (enum dw_pcie_ltssm)FIELD_GET(PORT_LOGIC_LTSSM_STATE_MASK, val); +} + #ifdef CONFIG_PCIE_DW_HOST irqreturn_t dw_handle_msi_irq(struct dw_pcie_rp *pp); int dw_pcie_setup_rc(struct dw_pcie_rp *pp); From patchwork Thu Aug 3 15:04:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13340248 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A89FEB64DD for ; Thu, 3 Aug 2023 15:05:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236870AbjHCPFE (ORCPT ); Thu, 3 Aug 2023 11:05:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236839AbjHCPE4 (ORCPT ); Thu, 3 Aug 2023 11:04:56 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B299530E5; Thu, 3 Aug 2023 08:04:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PEj8Htzz/qpTBdl688IMTNodnfyjv02xQrJo/x1kfAvYg7FfFe87yP/JL1o1uTtRPP+QTq6Fbz3lI3btq4Yy5WOQOxg9yDvPvE6tthUnxYBsMS/lFQR+Ip+RoFNocWkcq9QrRj2A1oh3JSub+VCpNb0c3VQH5tSg9yOWzO8XnONBbX6FhPnw+sE14SRlyiPWbLLyqKB0lkD0VCay1emi58fp1ysMdBUbKk5Hj1lkzaNcegY1WS0uKeogvkIr0UB7+H6ZMEj0WmW6MVNqwjQWhq5hokNAJ5zFSy4Vtlxu3IWR1uVph7Pu+PIXVtcppDCA8ahJc+QjyRMY0P/xyzrEeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6eVQ/gUKsRrgSYNWJMpMkCNkyHPHy17Uk/S/LIMiuL8=; b=QFsoTsuJ/6VceHTjMj8RIKzr3kXnBrKdv0aV02z9ngB12UypUWYi92lvIgljPEUlSk/VI8QwiUJtLJYfeg7KHXqtivrC7cEDL60fi33dVR3wJJ/2ZZ66VGr8svzqgf7vlE3PIbnwzQosXVBKUK7CxNl1MObk2z0reIVeQvOWrtgIX0zVe0dAfNMokxd2urvW73dwiU7QbeHyp0Z4DM8JQ3RxK3GgtzIq19QzRI4osjkxnXDhmnOzcEEDqZvCZzXUWVw8QaY9vpXBT0y1m2Pm5Qum4og/TCmocjh543NgmprU3143AZEGE7RiG4jgTW+4m8locwcQarG+dCLQnu93QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6eVQ/gUKsRrgSYNWJMpMkCNkyHPHy17Uk/S/LIMiuL8=; b=M97cgWuK15nOtfZQQu19uP5FqGmMi92BPPnHxrq/x5ldYJBdq0Dv7YYr8asyW9SE1Ofv2c+BSAJiqVkNND3WnEq6NC8p60KJpuqTjOQN4jBVi51ej1SOYmFdkub1OV1H4UC+OXByx309s8rIZ1SbW+immFqRKFkm5AfWCafcQTE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AS5PR04MB9769.eurprd04.prod.outlook.com (2603:10a6:20b:679::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 15:04:48 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::d0d5:3604:98da:20b1]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::d0d5:3604:98da:20b1%7]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 15:04:47 +0000 From: Frank Li To: helgaas@kernel.org Cc: Frank.li@nxp.com, bhelgaas@google.com, devicetree@vger.kernel.org, gustavo.pimentel@synopsys.com, imx@lists.linux.dev, kw@linux.com, leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, mani@kernel.org, manivannan.sadhasivam@linaro.org, minghuan.lian@nxp.com, mingkai.hu@nxp.com, robh+dt@kernel.org, roy.zang@nxp.com, shawnguo@kernel.org, zhiqiang.hou@nxp.com Subject: [PATCH v8 3/3] PCI: layerscape: Add power management support for ls1028a Date: Thu, 3 Aug 2023 11:04:09 -0400 Message-Id: <20230803150409.271155-4-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230803150409.271155-1-Frank.Li@nxp.com> References: <20230803150409.271155-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR03CA0161.namprd03.prod.outlook.com (2603:10b6:a03:338::16) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AS5PR04MB9769:EE_ X-MS-Office365-Filtering-Correlation-Id: eb4d0a8d-0158-47b6-7da2-08db9432fa91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bs48QJOjpnEX15wvJsV5XgEtKlUIRjzz8Sp5XNw9KPNM0VNUP8ouP+cEjHX8o61VzEqXJD9s2Y0keFU3Zs22gop5W8JXbWnWi8y252zdqe2zsqgXLgdCZBbn16aQtOs8WpEeQy+olI3FMeFLXjaPkP/9wzyIJ7kjgRQzgborpxIpTrodhS3y4hPE6xSCOpmcW02+mtY6xKSvW1p5f/papqTbOBnvmViWHUBzBCsudjqsDqLM2T9VJ5YBpo3EGCKuEf9s1NNGCQqGyYAPzSEKpfM3ZrYP29Hjgd94FRlbKpN3XNoDxWmUg1LWTnDG4liq5y/3KUUxAgBVOx3pLcn78DEqw5omhIsCtU6yhlH7twP93kkcS9qivqbMpe5RsXxiuwKDFVW2j1AK1R7akHWVPM/2B7Y3/OtSL1u5XgwENfDtsTwDjjp6uXZHblCuDHFEtRNb5dcC51mOg9BP6d+MVkNPl91/dlFfHXsnM5doaB3xOcMw+81KljJ1vP53vOm0XSN5x4mi4LjTyuhdSLLv5ckWrTiHgcdrA/XnrL0cezME5LWKtw0RAc/F8ASidCzHCJKwTRfQ5FN95LNewIddh50r9ASs693bm7mV8G9oRIcttZ62KFmv+JYH3Tt3VwNp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(136003)(396003)(346002)(39860400002)(451199021)(52116002)(1076003)(2616005)(83380400001)(6506007)(41300700001)(26005)(186003)(8676002)(8936002)(66556008)(2906002)(4326008)(66946007)(5660300002)(6916009)(316002)(66476007)(7416002)(6666004)(6486002)(6512007)(478600001)(38350700002)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VH+3LX4quCodzjqHBgjSpfcMLON/aHAxj1pSW6fnFfyFyAg7WCtCIriE/WG2NmvX7vSbpI1HRM6FHqigUCLx2hzk3Cq/v8EkKv3CNZbKy4NzA+oPj2owk80tGQEXLQ4Vk6WZnsZmxCxeOedSXJHkX2JJk0CgnY2BdCHOoD3MLmXQUpvHrN+wayXIPfuoZjGnxRff9BTdFgz9tR1tOxRDzpvgt+2OEmXpAQh2VmqDxnDwjqApugot+JPjhpNIO5gQzJWSeoo5M/KHa+VjKzuJQ4Jf8u2xNKerG8P6M073o+mJ7KPZutbl8wKJJkjIAgwP5qBd7ukw7IinAiMz+xx/XWT3076Qf/EFuBAWJRplk4XdQaJuUQ5210sjbCqGW31oug3uNwEHEEa0AdKbsws2zsLTyS3UxhvkgfRgR0598lctX1XUT/DBITju3LjC8kcgdRtEtBvoKRhkVhkOD2E6+dGEWwqU4r9Q+YYUrQu86uCcmSXL+Z0MPStEWcZ5WQS6EMy9j/RqCmDwPgmJ0APRUupStAk1GEri0S6kZN7aPHmSjhJcVaGCNjE4oxiVnqT7jTFss5LvrOm6KPIsAGXEBeK9vBeEKf7NnMnCpp1kzjqxN4NXgO1iYye+0wC3khbrElXj23uSXR4K3R31LaCvasCP+FqxFJ5aHC5ouOnqVST6y9ZttyHj+AbHbi7/mzTGno6PxDqDOOavhNh3irzjoOd8Y2vrURcG6QQ2478WGOEiLEnm4G6AxXJniTQ/Yi0I/x29BhvmNvnOYO4/CiesRr+qiOGNzklUNLqK+cHNT8A9XEacafhlORSRqXHq0JHpMmGoScGIiwK3nlPlqoonBmiAevWxmpsO3P5Txk+greGIOUQtZcYb0FvB3kA3WJr2cEqssvBUUPQ7CIN7p5mQ+Y3WJTYPFJtKFupjp6ed6lSkeDm+7J2sguz1O9IwiRVXERlp0rox4/MvB2WCi6/6W4eUDDxUs7ZVMosu4kLqE9xoYCcbolvWc/+632vIcqDb/NvooVGpcKbDKEdFtNtxXqCCkVL4MyqAamG/FA4DCNxvPa+IBjTGs7eLkk4C49nzmiHrSyLWZYRx334xUkaSFkRO4A7R5QLkSiSQKeiLPtCFcmdi4uf8L9iw28x01HH3TpOwuMZ+bAqWlCn2M2oniqQ2qe+cf8fmp1qlkzgQRYNilmK2j3OBnJz9VEryUqjYF9dHYclYitQKKXQDR0HcybKMqZm9kfMDYnXJenttsP46MPJUZXqluAUFIy/rm7zt90OjqL2OjpoJXtF4wgmSgHZt4msxiAQb9VFp9z/VZUT1falxVeJW3sudOVJAXEYFjpDWjhB253YE/8XyFmcO4syDkuL9y/OcshYyh/NGaRTmYnOdEH0WgWGiSdwD/FRQplgeBY6iRrK5tfs4C9P+gudizbvCUz9mNIJQpSDVg5bLwJHwbO6IpHwMe7E9EhoXFckBzIVbNzZf6tyy0TWTn2Hj0DnZEjMbW1wMHSMXiJM9jrPJoGiiq4YyPaw6tCcucWxzGNO0/RS/Dq6b2uUPxqXwAtPzbdCldBNT9n1TRgg= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb4d0a8d-0158-47b6-7da2-08db9432fa91 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 15:04:47.8705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zqq+Epwv2JyuprPU539jO56BMYSfQyTamLn7MXNeJKlrDcYmKiS+x2LcFByOZrqHninSj2mgN6Mty0DTQK8Nrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9769 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Hou Zhiqiang Add PME_Turn_off/PME_TO_Ack handshake sequence for ls1028a platform. Call common dwc dw_pcie_suspend(resume)_noirq() function when system enter/exit suspend state. Signed-off-by: Hou Zhiqiang Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-layerscape.c | 129 ++++++++++++++++++-- 1 file changed, 120 insertions(+), 9 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c index ed5fb492fe084..531b2680fa9d2 100644 --- a/drivers/pci/controller/dwc/pci-layerscape.c +++ b/drivers/pci/controller/dwc/pci-layerscape.c @@ -8,9 +8,11 @@ * Author: Minghuan Lian */ +#include #include #include #include +#include #include #include #include @@ -27,12 +29,26 @@ #define PCIE_ABSERR 0x8d0 /* Bridge Slave Error Response Register */ #define PCIE_ABSERR_SETTING 0x9401 /* Forward error of non-posted request */ +/* PF Message Command Register */ +#define LS_PCIE_PF_MCR 0x2c +#define PF_MCR_PTOMR BIT(0) +#define PF_MCR_EXL2S BIT(1) + #define PCIE_IATU_NUM 6 +struct ls_pcie_drvdata { + const u32 pf_off; + bool pm_support; +}; + struct ls_pcie { struct dw_pcie *pci; + const struct ls_pcie_drvdata *drvdata; + void __iomem *pf_base; + bool big_endian; }; +#define ls_pcie_pf_readl_addr(addr) ls_pcie_pf_readl(pcie, addr) #define to_ls_pcie(x) dev_get_drvdata((x)->dev) static bool ls_pcie_is_bridge(struct ls_pcie *pcie) @@ -73,6 +89,60 @@ static void ls_pcie_fix_error_response(struct ls_pcie *pcie) iowrite32(PCIE_ABSERR_SETTING, pci->dbi_base + PCIE_ABSERR); } +static u32 ls_pcie_pf_readl(struct ls_pcie *pcie, u32 off) +{ + if (pcie->big_endian) + return ioread32be(pcie->pf_base + off); + + return ioread32(pcie->pf_base + off); +} + +static void ls_pcie_pf_writel(struct ls_pcie *pcie, u32 off, u32 val) +{ + if (pcie->big_endian) + iowrite32be(val, pcie->pf_base + off); + else + iowrite32(val, pcie->pf_base + off); +} + +static void ls_pcie_send_turnoff_msg(struct dw_pcie_rp *pp) +{ + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); + struct ls_pcie *pcie = to_ls_pcie(pci); + u32 val; + int ret; + + val = ls_pcie_pf_readl(pcie, LS_PCIE_PF_MCR); + val |= PF_MCR_PTOMR; + ls_pcie_pf_writel(pcie, LS_PCIE_PF_MCR, val); + + ret = readx_poll_timeout(ls_pcie_pf_readl_addr, LS_PCIE_PF_MCR, + val, !(val & PF_MCR_PTOMR), + PCIE_PME_TO_L2_TIMEOUT_US/10, + PCIE_PME_TO_L2_TIMEOUT_US); + if (ret) + dev_err(pcie->pci->dev, "poll turn off message timeout\n"); +} + +static void ls_pcie_exit_from_l2(struct dw_pcie_rp *pp) +{ + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); + struct ls_pcie *pcie = to_ls_pcie(pci); + u32 val; + int ret; + + val = ls_pcie_pf_readl(pcie, LS_PCIE_PF_MCR); + val |= PF_MCR_EXL2S; + ls_pcie_pf_writel(pcie, LS_PCIE_PF_MCR, val); + + ret = readx_poll_timeout(ls_pcie_pf_readl_addr, LS_PCIE_PF_MCR, + val, !(val & PF_MCR_EXL2S), + PCIE_PME_TO_L2_TIMEOUT_US/10, + PCIE_PME_TO_L2_TIMEOUT_US); + if (ret) + dev_err(pcie->pci->dev, "poll exit L2 state timeout\n"); +} + static int ls_pcie_host_init(struct dw_pcie_rp *pp) { struct dw_pcie *pci = to_dw_pcie_from_pp(pp); @@ -91,18 +161,28 @@ static int ls_pcie_host_init(struct dw_pcie_rp *pp) static const struct dw_pcie_host_ops ls_pcie_host_ops = { .host_init = ls_pcie_host_init, + .pme_turn_off = ls_pcie_send_turnoff_msg, + .exit_from_l2 = ls_pcie_exit_from_l2, +}; + +static const struct ls_pcie_drvdata ls1021a_drvdata = { +}; + +static const struct ls_pcie_drvdata layerscape_drvdata = { + .pf_off = 0xc0000, + .pm_support = true, }; static const struct of_device_id ls_pcie_of_match[] = { - { .compatible = "fsl,ls1012a-pcie", }, - { .compatible = "fsl,ls1021a-pcie", }, - { .compatible = "fsl,ls1028a-pcie", }, - { .compatible = "fsl,ls1043a-pcie", }, - { .compatible = "fsl,ls1046a-pcie", }, - { .compatible = "fsl,ls2080a-pcie", }, - { .compatible = "fsl,ls2085a-pcie", }, - { .compatible = "fsl,ls2088a-pcie", }, - { .compatible = "fsl,ls1088a-pcie", }, + { .compatible = "fsl,ls1012a-pcie", .data = &layerscape_drvdata }, + { .compatible = "fsl,ls1021a-pcie", .data = &ls1021a_drvdata }, + { .compatible = "fsl,ls1028a-pcie", .data = &layerscape_drvdata }, + { .compatible = "fsl,ls1043a-pcie", .data = &ls1021a_drvdata }, + { .compatible = "fsl,ls1046a-pcie", .data = &layerscape_drvdata }, + { .compatible = "fsl,ls2080a-pcie", .data = &layerscape_drvdata }, + { .compatible = "fsl,ls2085a-pcie", .data = &layerscape_drvdata }, + { .compatible = "fsl,ls2088a-pcie", .data = &layerscape_drvdata }, + { .compatible = "fsl,ls1088a-pcie", .data = &layerscape_drvdata }, { }, }; @@ -121,6 +201,8 @@ static int ls_pcie_probe(struct platform_device *pdev) if (!pci) return -ENOMEM; + pcie->drvdata = of_device_get_match_data(dev); + pci->dev = dev; pci->pp.ops = &ls_pcie_host_ops; @@ -131,6 +213,10 @@ static int ls_pcie_probe(struct platform_device *pdev) if (IS_ERR(pci->dbi_base)) return PTR_ERR(pci->dbi_base); + pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian"); + + pcie->pf_base = pci->dbi_base + pcie->drvdata->pf_off; + if (!ls_pcie_is_bridge(pcie)) return -ENODEV; @@ -139,12 +225,37 @@ static int ls_pcie_probe(struct platform_device *pdev) return dw_pcie_host_init(&pci->pp); } +static int ls_pcie_suspend_noirq(struct device *dev) +{ + struct ls_pcie *pcie = dev_get_drvdata(dev); + + if (!pcie->drvdata->pm_support) + return 0; + + return dw_pcie_suspend_noirq(pcie->pci); +} + +static int ls_pcie_resume_noirq(struct device *dev) +{ + struct ls_pcie *pcie = dev_get_drvdata(dev); + + if (!pcie->drvdata->pm_support) + return 0; + + return dw_pcie_resume_noirq(pcie->pci); +} + +static const struct dev_pm_ops ls_pcie_pm_ops = { + NOIRQ_SYSTEM_SLEEP_PM_OPS(ls_pcie_suspend_noirq, ls_pcie_resume_noirq) +}; + static struct platform_driver ls_pcie_driver = { .probe = ls_pcie_probe, .driver = { .name = "layerscape-pcie", .of_match_table = ls_pcie_of_match, .suppress_bind_attrs = true, + .pm = &ls_pcie_pm_ops, }, }; builtin_platform_driver(ls_pcie_driver);