From patchwork Fri Aug 4 03:53:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13341227 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3B2CC001DE for ; Fri, 4 Aug 2023 03:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CkuoF5LPymbeDnFLD6d+jlOZQz8XKgWXlu/OJwmfHu8=; b=K7y31OeZ1sSZM9 iCd4/Fxr97+/zFJImpTUG4J9jq8b8N9QM5vFdlNUOPYvNwXwQMxWY6N+MBPwwq8t0FPhgffx8moF8 YMXUAeJFCEPkdwtsPIlp4PeMLaspyrOY66SotvZm9I3sdgz8d5vJ3UjMtenmejvyMDGlmdOdadPv7 L6BgRzwEjFr8DeqsGQjnZi6AMys0dA+qKDhqmofsw+zdTMt8yzhMScI1sT7WvQLjMU+TQXayz/9hh use0pXPuanewBwBbHIxSzlCREXKo+Q32kXRWBO3Kfs1ByppDyoqtxaiQ/DGUc+4SqkWA8ESphBCtE 4F2UDnsmG3t0F7jsAL6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRltx-00BU7i-0I; Fri, 04 Aug 2023 03:54:57 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRltq-00BU2P-1o for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 03:54:53 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RHBb36Vf0zNmlJ; Fri, 4 Aug 2023 11:51:11 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 11:54:37 +0800 From: Ruan Jinjie To: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH -next 1/6] net: thunderx: Remove unnecessary ternary operators Date: Fri, 4 Aug 2023 11:53:41 +0800 Message-ID: <20230804035346.2879318-2-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230804035346.2879318-1-ruanjinjie@huawei.com> References: <20230804035346.2879318-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230803_205450_754859_1A6922C6 X-CRM114-Status: UNSURE ( 9.07 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ther are a little ternary operators, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie --- drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/drivers/net/ethernet/cavium/thunder/nic_main.c index 0ec65ec634df..b7cf4ba89b7c 100644 --- a/drivers/net/ethernet/cavium/thunder/nic_main.c +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c @@ -174,7 +174,7 @@ static void nic_mbx_send_ready(struct nicpf *nic, int vf) if (mac) ether_addr_copy((u8 *)&mbx.nic_cfg.mac_addr, mac); } - mbx.nic_cfg.sqs_mode = (vf >= nic->num_vf_en) ? true : false; + mbx.nic_cfg.sqs_mode = vf >= nic->num_vf_en; mbx.nic_cfg.node_id = nic->node; mbx.nic_cfg.loopback_supported = vf < nic->num_vf_en; diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index a317feb8decb..9e467cecc33a 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -957,7 +957,7 @@ static void bgx_poll_for_sgmii_link(struct lmac *lmac) goto next_poll; } - lmac->link_up = ((pcs_link & PCS_MRX_STATUS_LINK) != 0) ? true : false; + lmac->link_up = (pcs_link & PCS_MRX_STATUS_LINK) != 0; an_result = bgx_reg_read(lmac->bgx, lmac->lmacid, BGX_GMP_PCS_ANX_AN_RESULTS); From patchwork Fri Aug 4 03:53:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13341225 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B93A9C04A94 for ; Fri, 4 Aug 2023 03:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O/hnMsjthrcB8NUgFQl0NcRlRScDVEpsawpI9CfmjvM=; b=FkrvJmT34F/XHo aMX+mBrK0gdGkO14a6QjwBU0dcvdNw1fSOLf0isUZAx+WsmoN9YbDzDOwPS4XUD4i3vP8EbAtMGZA 0bkvw3aw/G35Z7iBunmJC+1/eqq40kI3WtsbMOd8+qje52mC+LIPECzCtRwA1QjnlZ8zTzgqivoY6 L+rOBkNk+abQnJdfdk5KuVWnMyJu6JtLag/m90vRVcqcDW2cla0izS4r4ocoFLMAzHTGCpMmHPL8X /5uImK6DzEKRbvzOtpij6r01IJjBkfNoUDeYyZipRuP/8M9ESqp5dCTjqyHTWpES3Y/mEOtRvW74m rNSz7TrBiPjdY5uRz08w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRltv-00BU6X-0E; Fri, 04 Aug 2023 03:54:55 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRltq-00BU2Q-1C for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 03:54:51 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RHBdp61jnzrS6X; Fri, 4 Aug 2023 11:53:34 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 11:54:38 +0800 From: Ruan Jinjie To: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH -next 2/6] ethernet/intel: Remove unnecessary ternary operators Date: Fri, 4 Aug 2023 11:53:42 +0800 Message-ID: <20230804035346.2879318-3-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230804035346.2879318-1-ruanjinjie@huawei.com> References: <20230804035346.2879318-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230803_205450_590317_38358AD4 X-CRM114-Status: UNSURE ( 8.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ther are a little ternary operators, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie Reviewed-by: Jacob Keller --- drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +- drivers/net/ethernet/intel/igc/igc_phy.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c index a018000f7db9..c123c9dd6a49 100644 --- a/drivers/net/ethernet/intel/igb/e1000_phy.c +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c @@ -1652,7 +1652,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations, udelay(usec_interval); } - *success = (i < iterations) ? true : false; + *success = i < iterations; return ret_val; } diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c index 53b77c969c85..a553e9d719e7 100644 --- a/drivers/net/ethernet/intel/igc/igc_phy.c +++ b/drivers/net/ethernet/intel/igc/igc_phy.c @@ -93,7 +93,7 @@ s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations, udelay(usec_interval); } - *success = (i < iterations) ? true : false; + *success = i < iterations; return ret_val; } From patchwork Fri Aug 4 03:53:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13341229 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3051CC04A94 for ; Fri, 4 Aug 2023 03:55:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O2dwxpBhg5E3+5B+noFgI7Db/kr4jtg7IaMJ2ubcYAg=; b=1ebMMY9+T8MfMc KFLuOuf7mf5swKu4p4ATeyk/kSHIx2YIplbFOKNzABFi/iOnMeTlzdfU3f/heyOFTXV++ad9lZke7 u8EkA5lSPUFp2sAmD4VsJHG628o9oXs9xcYQgiwc+dOL7dHG3xwY1pUE1c1FFiYNH75iOSQ6NxToz 2HSQcg96BQfxw6cCyAnG2asuA87NO0VeMtiXCzb6i7UfCJUEu9c0eobynUemXtGw9r1FPBUXMNwWM LdFpI5zEFtdJ9hVEAkIreTHKbCWEJUhJDW2GTHxygsvYvZ2QrsqZhP0x1bzFBV0ZW2CFHgEgXSg8n XZeSAad/ges9pDgPwSSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRltv-00BU6n-1n; Fri, 04 Aug 2023 03:54:55 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRltq-00BU2W-1W for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 03:54:52 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RHBdr2xFszrS75; Fri, 4 Aug 2023 11:53:36 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 11:54:40 +0800 From: Ruan Jinjie To: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator Date: Fri, 4 Aug 2023 11:53:43 +0800 Message-ID: <20230804035346.2879318-4-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230804035346.2879318-1-ruanjinjie@huawei.com> References: <20230804035346.2879318-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230803_205450_678700_CC8CEFD1 X-CRM114-Status: UNSURE ( 8.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is a ternary operator, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie --- drivers/net/ethernet/mellanox/mlx4/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c index 256a06b3c096..1c289488d050 100644 --- a/drivers/net/ethernet/mellanox/mlx4/port.c +++ b/drivers/net/ethernet/mellanox/mlx4/port.c @@ -176,7 +176,7 @@ static bool mlx4_need_mf_bond(struct mlx4_dev *dev) mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH) ++num_eth_ports; - return (num_eth_ports == 2) ? true : false; + return num_eth_ports == 2; } int __mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac) From patchwork Fri Aug 4 03:53:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13341226 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 456A8C001DE for ; Fri, 4 Aug 2023 03:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E6pJUIoXGUXFHbk+Ms6Neno71t6u76m9aGI/hLSXMaA=; b=WMx02/kHg4KmT4 MKIgGk6ZUCZw8QcEuKAiUYn5APIuh12sUPQ2ReBtgZeLp4OZckZrRuOIKhQNl0BFvqTXSMjG7+Zrp r4T6Lu8Gzr16vseweIgU9bW38KO6QGx1xng6qzZGC5MZ+rVurH0Q3Qj7AjP3nERQ9CsZGV6e8NDDL 3XUwWftfbxeqgxzNkMoFUws+iEkd782+CcmJKj+c8YVgiLUgFp/DgwyTmJi12E5m+MdKaED90Kxkx 0KT8XokYXRdzL1+IZHDPYXejBcT/gu1Lh+wAUFOkUTcxwpHxw20cyFcqiog4zh1wvzIOkGktxG/uL n8kxiEuZCIUomrRQPm1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRltw-00BU79-0D; Fri, 04 Aug 2023 03:54:56 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRltq-00BU2v-1L for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 03:54:52 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RHBb820qSzNmlS; Fri, 4 Aug 2023 11:51:16 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 11:54:41 +0800 From: Ruan Jinjie To: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH -next 4/6] net: ethernet: renesas: rswitch: Remove an unnecessary ternary operator Date: Fri, 4 Aug 2023 11:53:44 +0800 Message-ID: <20230804035346.2879318-5-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230804035346.2879318-1-ruanjinjie@huawei.com> References: <20230804035346.2879318-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230803_205450_608005_1B0828FA X-CRM114-Status: UNSURE ( 9.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is a ternary operator, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie --- drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c index c007e33c47e1..37f7359678e5 100644 --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c @@ -29,7 +29,7 @@ static const struct rcar_gen4_ptp_reg_offset s4_offs = { static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) { struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp); - bool neg_adj = scaled_ppm < 0 ? true : false; + bool neg_adj = scaled_ppm < 0; s64 addend = ptp_priv->default_addend; s64 diff; From patchwork Fri Aug 4 03:53:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13341230 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA782C001DE for ; Fri, 4 Aug 2023 03:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fLDT1Oo82Z93AxysFKsWtOHkgQinAbcfbaQwPbSYk90=; b=Ndy6C6KE+GV8i6 wchtX61N4t1fRh5YouhfrVaaJ3UDQ/zq+ea9wgAivTCZtTHUhZJbBjaL2LDKkeL1d19nzTyE94scp k3BYABm3WYvxvjRDceCI+4cKo4LSo/A6rjsRpzvv98rOtZY5XyVNMyYGhwO/C7eShTZqr0CEmPmXn zubbtO2eYV3AioJfmt9QQ/3ZZiXSDo1Vr/PbTxTbe8PQ4ri9rkX7tesO9NIteLEA9SPU9J+PCqu5+ C6Zp1oFHFQdk3/auDZ5t8rA8g//WIf/yHqfth1vVxdu8ttLQweqwNFO6i2ZcQOJYv4H1ReB8OxkjT WZjEzN7gODCFacjEy5tQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRltx-00BU84-1z; Fri, 04 Aug 2023 03:54:57 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRlts-00BU2w-0L for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 03:54:53 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RHBb94gk1zNmj2; Fri, 4 Aug 2023 11:51:17 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 11:54:43 +0800 From: Ruan Jinjie To: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH -next 5/6] net: fjes: Remove an unnecessary ternary operator Date: Fri, 4 Aug 2023 11:53:45 +0800 Message-ID: <20230804035346.2879318-6-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230804035346.2879318-1-ruanjinjie@huawei.com> References: <20230804035346.2879318-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230803_205452_345688_4A3FF63C X-CRM114-Status: UNSURE ( 8.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is a ternary operator, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie --- drivers/net/fjes/fjes_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index 2513be6d4e11..a0d915d1dbed 100644 --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -612,7 +612,7 @@ fjes_xmit_frame(struct sk_buff *skb, struct net_device *netdev) eth = (struct ethhdr *)skb->data; my_epid = hw->my_epid; - vlan = (vlan_get_tag(skb, &vlan_id) == 0) ? true : false; + vlan = vlan_get_tag(skb, &vlan_id) == 0; data = skb->data; len = skb->len; From patchwork Fri Aug 4 03:53:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13341228 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E7F9C001DB for ; Fri, 4 Aug 2023 03:55:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WfsBUhH+AsQ2WO4YQnE3b72uumuuCEHZCjzrnN/jla0=; b=3djp03CqRQIQ2G Goehl9BUNrVZm6+WNZXiTEWOeQNIQZFVh4craSOHqzuk7mRQXxCEAAn7fQFETM8bFbKQAff2TJ3nk 1K6L/krFxYogulsfDd+dTJWYTDKRYKc5JPFGljfgiQuUeWsRePo3LUJP/BFdAUQTT8iJVkB8Gfvrx dQn7I9PoQXWdStoCtpAvm2hQx7Q4Ic9vyWvRamUFiTv28CxFT0yWB4jS6qpFUb+Pr0i9Ml/hgleku x0pqVfTTo8iQ/YaEal8EUimBZpl4YGMlIywLoKW9WO9XqGSjA2iGxNlH0QVMv99vSkyalmDRR8ZCq b7BnXceU9FaqvSQq/eOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRltw-00BU7S-1u; Fri, 04 Aug 2023 03:54:56 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRltq-00BU30-1i for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 03:54:52 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4RHBdx2X1qz1KCCw; Fri, 4 Aug 2023 11:53:41 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 11:54:44 +0800 From: Ruan Jinjie To: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH -next 6/6] brcm80211: Remove an unnecessary ternary operator Date: Fri, 4 Aug 2023 11:53:46 +0800 Message-ID: <20230804035346.2879318-7-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230804035346.2879318-1-ruanjinjie@huawei.com> References: <20230804035346.2879318-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230803_205450_733576_C4312E45 X-CRM114-Status: UNSURE ( 8.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is a ternary operator, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c index 8580a2754789..8328b22829c5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c @@ -27351,8 +27351,7 @@ static int wlc_phy_cal_rxiq_nphy_rev3(struct brcms_phy *pi, for (rx_core = 0; rx_core < pi->pubpi.phy_corenum; rx_core++) { - skip_rxiqcal = - ((rxcore_state & (1 << rx_core)) == 0) ? true : false; + skip_rxiqcal = (rxcore_state & (1 << rx_core)) == 0; wlc_phy_rxcal_physetup_nphy(pi, rx_core);