From patchwork Fri Aug 4 10:48:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13341658 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F4C9C00528 for ; Fri, 4 Aug 2023 10:48:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E97FB10E6C9; Fri, 4 Aug 2023 10:48:36 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2368810E6C9 for ; Fri, 4 Aug 2023 10:48:31 +0000 (UTC) Received: from [127.0.1.1] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 419C112E4; Fri, 4 Aug 2023 12:47:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691146045; bh=WPn1AxdTbVK2rBt8KyZ5pLuKTboKnk0kbLICj2/CxXg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=eZPgyRl4fhOR+GjfERv8LQ4n8rOr3iNptbLXIhIQn8p9LFWyICnMy95ykPXVxiygY HOPTHnB0hKxAmsNHrLl5HkvnmMwUnVsKZ+ZCqLfP1uOC0Bxhr6IXt1FWhqQUWfn2fO +Ivmo+m828wLDo5bb1YGVb7xhfTuj73DF+R0g9N4= From: Tomi Valkeinen Date: Fri, 04 Aug 2023 13:48:10 +0300 Subject: [PATCH 1/4] drm/bridge: lt8912b: Fix bridge_detach MIME-Version: 1.0 Message-Id: <20230804-lt8912b-v1-1-c542692c6a2f@ideasonboard.com> References: <20230804-lt8912b-v1-0-c542692c6a2f@ideasonboard.com> In-Reply-To: <20230804-lt8912b-v1-0-c542692c6a2f@ideasonboard.com> To: Adrien Grassein , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Francesco Dolcini , Stefan Eichenberger X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2251; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=WPn1AxdTbVK2rBt8KyZ5pLuKTboKnk0kbLICj2/CxXg=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBkzNd6CzQGoXs4vpPoOgcUqTbWmS76ZzxcS1XCy my0BlS41TaJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZMzXegAKCRD6PaqMvJYe 9To5D/96c/eG+8WqJSaQP/PFgeAK5pwqit3+cPaRGEwlYyyG66X1ZsQsfn8Dv0hTEyvTFi4bajt kylDxWgIMMg83AsbK15AgglIlbs4C6EQPQEDBdnawhQTG6VIr3RQ052k4nJi37NRs6enTbPOFfp 6lhf9RsXD5BXEjMk0hHUyV7wxbKvHMMcyoGU3/iRjsTmMPGlhfY9eJEBrFX1I96g+jqwYEjgHb0 4mmlfHL2V5O/Fss0b2K8DbND/7rJmUiICpfpUX/+FlTNjTx/UkUwW7ppA/y69U4kbe9GNSa5Nny vQ33WcfItsgYwSgTAeRs5FCCvYWe1TrM3dTPxjV7g31q3fvGF9t0+IG1mTPc98o3wRknlogBQ+D T0Az2AGczXGERLuHrfOk7k6PTk+OsJui5ES0ve/mk3nkQz3sbNgatiXAi3PxX/ItbJJN4UVuIFn Uk386nTJv2ZVyUqCVw6sbm47dCbTi9o7j55i/YoqoVVLY2RW8ey7w5tCnkoSZr+Fwgr2dZV6H+5 OV60X0aJeR7ze7zSh5GtfIEqQ9FKMKV4EfpaAM1gHXzOqWHnRfRA4fMgvuR84UZ9pJKPXV6lYbc cuOk3nZZh1hiotPRwqBkN1taHArTlGl2wjetqh3du9cxUkcDOZAP2beOI7gAoXkQO/CtEZtGk8a o2chkjn15jPTDDQ== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The driver calls lt8912_bridge_detach() from its lt8912_remove() function. As the DRM core detaches bridges automatically, this leads to calling lt8912_bridge_detach() twice. The code probably has tried to manage the double-call with the 'is_attached' variable, but the driver never sets the variable to false, so its of no help. Fix the issue by dropping the call to lt8912_bridge_detach() from lt8912_remove(), as the DRM core will handle the detach call for us, and also drop the useless is_attached field. Fixes: 88abfc2b9e61 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge") Signed-off-by: Tomi Valkeinen Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c index 4eaea67fb71c..0e581f6e3c88 100644 --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c @@ -45,7 +45,6 @@ struct lt8912 { u8 data_lanes; bool is_power_on; - bool is_attached; }; static int lt8912_write_init_config(struct lt8912 *lt) @@ -575,8 +574,6 @@ static int lt8912_bridge_attach(struct drm_bridge *bridge, if (ret) goto error; - lt->is_attached = true; - return 0; error: @@ -588,15 +585,13 @@ static void lt8912_bridge_detach(struct drm_bridge *bridge) { struct lt8912 *lt = bridge_to_lt8912(bridge); - if (lt->is_attached) { - lt8912_hard_power_off(lt); + lt8912_hard_power_off(lt); - if (lt->hdmi_port->ops & DRM_BRIDGE_OP_HPD) - drm_bridge_hpd_disable(lt->hdmi_port); + if (lt->hdmi_port->ops & DRM_BRIDGE_OP_HPD) + drm_bridge_hpd_disable(lt->hdmi_port); - drm_connector_unregister(<->connector); - drm_connector_cleanup(<->connector); - } + drm_connector_unregister(<->connector); + drm_connector_cleanup(<->connector); } static enum drm_connector_status @@ -750,7 +745,6 @@ static void lt8912_remove(struct i2c_client *client) { struct lt8912 *lt = i2c_get_clientdata(client); - lt8912_bridge_detach(<->bridge); drm_bridge_remove(<->bridge); lt8912_free_i2c(lt); lt8912_put_dt(lt); From patchwork Fri Aug 4 10:48:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13341660 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 660A2C00528 for ; Fri, 4 Aug 2023 10:48:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F060E10E6D8; Fri, 4 Aug 2023 10:48:47 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0AC8910E6C9 for ; Fri, 4 Aug 2023 10:48:32 +0000 (UTC) Received: from [127.0.1.1] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F8E5188E; Fri, 4 Aug 2023 12:47:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691146046; bh=sSHNiN7SCW+dnAbLNBvXVtT0IFfFTc4U7kIWW6bzkcc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=vqtielVZGZwDmNlYBA7mcOvKFUJXxaKDwV9ENxPhnF7RkoKUj+iyBdL5epoZglLE5 +VNMHB42QVM9YKyJhhogRZUWv63tw6wPo7fco2C2XFQ3G4Jn40mEUIz+J2IjEWB99Y H54EXzNb9GqIoivaraSX9uuHRfe0V6QhusyJ5mNM= From: Tomi Valkeinen Date: Fri, 04 Aug 2023 13:48:11 +0300 Subject: [PATCH 2/4] drm/bridge: lt8912b: Fix crash on bridge detach MIME-Version: 1.0 Message-Id: <20230804-lt8912b-v1-2-c542692c6a2f@ideasonboard.com> References: <20230804-lt8912b-v1-0-c542692c6a2f@ideasonboard.com> In-Reply-To: <20230804-lt8912b-v1-0-c542692c6a2f@ideasonboard.com> To: Adrien Grassein , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Francesco Dolcini , Stefan Eichenberger X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4076; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=sSHNiN7SCW+dnAbLNBvXVtT0IFfFTc4U7kIWW6bzkcc=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBkzNd6zGvgxDYCLtrRiFJnpm3hEXSfsh2F+jd0H xfGLVuAJTOJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZMzXegAKCRD6PaqMvJYe 9SAnD/42zhCeSiHSaQ04HYuQVR134RabhRuzmMjSbljYZOMS0jIIWPwPNPHxxU3+zAyYYaGj4Mn yhWybHz/BkupsiT4/o9+2zEtmN+bNf6dULlsP82Vdv3jX+2XBl2HWcecUVlpnI+3e4xIWmK1Tbp +2oMqm3Lxui0ryU6rpjnBbm3SxbmLMeE4/kPv13kZjO9SUpoU6afzUirve+LHO8O9Y/1rfsDqvs 0atCeMQAVmB/vcZMHmM8zQZQy3YILkB03M8PpWqEcNN2F24uM5GAmsyMqmQkFOaWtK3QgxMBFSK r1PYEUj8HMFBQfqA6MxDCns/QPvjT8K+yn7mlaLRC4oZVhRVBZZFRe61GTiCu2nAUk7SrK8WR9T 8HLR1koGTidrYoFH+tzvkZZ1Sk3bLhMhc8ucRE60/SnrIhxLfVcYubrrENMzX4cHhSn3NWoxHr0 +7ar3UgmiJYBohwYEgKMPoVMlIrkdDllu/Aos7rKyJwQvbz7hvaR4W9U8tUldn0kjm5ZX5+FK+U ZQwFxMnIiQM4mijTpP94lTYnBg7OsUbz6p1kRmox0qHxX1rsAsVLSsOwbLwe1KSYrNxHEpkKjY5 I4+7dvcTqIQYSCQTzuQdx+jrGausSMLDE/e5bsXRKvJzrjxw4OCa8axVKXpNy14memcm/1I6QI6 aYnhriViYhLissg== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The lt8912b driver, in its bridge detach function, calls drm_connector_unregister() and drm_connector_cleanup(). drm_connector_unregister() should be called only for connectors explicitly registered with drm_connector_register(), which is not the case in lt8912b. The driver's drm_connector_funcs.destroy hook is set to drm_connector_cleanup(). Thus the driver should not call either drm_connector_unregister() nor drm_connector_cleanup() in its lt8912_bridge_detach(), as they cause a crash on bridge detach: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 Mem abort info: ESR = 0x0000000096000006 EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 FSC = 0x06: level 2 translation fault Data abort info: ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000 CM = 0, WnR = 0, TnD = 0, TagAccess = 0 GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 user pgtable: 4k pages, 48-bit VAs, pgdp=00000000858f3000 [0000000000000000] pgd=0800000085918003, p4d=0800000085918003, pud=0800000085431003, pmd=0000000000000000 Internal error: Oops: 0000000096000006 [#1] PREEMPT SMP Modules linked in: tidss(-) display_connector lontium_lt8912b tc358768 panel_lvds panel_simple drm_dma_helper drm_kms_helper drm drm_panel_orientation_quirks CPU: 3 PID: 462 Comm: rmmod Tainted: G W 6.5.0-rc2+ #2 Hardware name: Toradex Verdin AM62 on Verdin Development Board (DT) pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : drm_connector_cleanup+0x78/0x2d4 [drm] lr : lt8912_bridge_detach+0x54/0x6c [lontium_lt8912b] sp : ffff800082ed3a90 x29: ffff800082ed3a90 x28: ffff0000040c1940 x27: 0000000000000000 x26: 0000000000000000 x25: dead000000000122 x24: dead000000000122 x23: dead000000000100 x22: ffff000003fb6388 x21: 0000000000000000 x20: 0000000000000000 x19: ffff000003fb6260 x18: fffffffffffe56e8 x17: 0000000000000000 x16: 0010000000000000 x15: 0000000000000038 x14: 0000000000000000 x13: ffff800081914b48 x12: 000000000000040e x11: 000000000000015a x10: ffff80008196ebb8 x9 : ffff800081914b48 x8 : 00000000ffffefff x7 : ffff0000040c1940 x6 : ffff80007aa649d0 x5 : 0000000000000000 x4 : 0000000000000001 x3 : ffff80008159e008 x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000 Call trace: drm_connector_cleanup+0x78/0x2d4 [drm] lt8912_bridge_detach+0x54/0x6c [lontium_lt8912b] drm_bridge_detach+0x44/0x84 [drm] drm_encoder_cleanup+0x40/0xb8 [drm] drmm_encoder_alloc_release+0x1c/0x30 [drm] drm_managed_release+0xac/0x148 [drm] drm_dev_put.part.0+0x88/0xb8 [drm] devm_drm_dev_init_release+0x14/0x24 [drm] devm_action_release+0x14/0x20 release_nodes+0x5c/0x90 devres_release_all+0x8c/0xe0 device_unbind_cleanup+0x18/0x68 device_release_driver_internal+0x208/0x23c driver_detach+0x4c/0x94 bus_remove_driver+0x70/0xf4 driver_unregister+0x30/0x60 platform_driver_unregister+0x14/0x20 tidss_platform_driver_exit+0x18/0xb2c [tidss] __arm64_sys_delete_module+0x1a0/0x2b4 invoke_syscall+0x48/0x110 el0_svc_common.constprop.0+0x60/0x10c do_el0_svc_compat+0x1c/0x40 el0_svc_compat+0x40/0xac el0t_32_sync_handler+0xb0/0x138 el0t_32_sync+0x194/0x198 Code: 9104a276 f2fbd5b7 aa0203e1 91008af8 (f85c0420) Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge") Signed-off-by: Tomi Valkeinen Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c index 0e581f6e3c88..2d752e083433 100644 --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c @@ -589,9 +589,6 @@ static void lt8912_bridge_detach(struct drm_bridge *bridge) if (lt->hdmi_port->ops & DRM_BRIDGE_OP_HPD) drm_bridge_hpd_disable(lt->hdmi_port); - - drm_connector_unregister(<->connector); - drm_connector_cleanup(<->connector); } static enum drm_connector_status From patchwork Fri Aug 4 10:48:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13341661 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C90D5C001DF for ; Fri, 4 Aug 2023 10:48:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0616E10E6D9; Fri, 4 Aug 2023 10:48:54 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id F3DD210E6D7 for ; Fri, 4 Aug 2023 10:48:32 +0000 (UTC) Received: from [127.0.1.1] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 584FF1AB3; Fri, 4 Aug 2023 12:47:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691146047; bh=Saj/S8br2Pn8J3bw6L6o8aOvLR2HwJ6wjYN6KAzMzkU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=oujl1umhGiLwwXTZQbcxslb/R63Z5anKl0neAqDGW1DS5Gd2f+c6yewLw7lziR3Oh h6pAmu2zFKS0/ktx/Nr9Ql6+vWxZn8t3n53Px7QEwaUfdCYq/b+oyDnM7bhIRykHuw eCMcRojAZn6A9kM4+KU5RXGL48sbXCRgLMNMRDjM= From: Tomi Valkeinen Date: Fri, 04 Aug 2023 13:48:12 +0300 Subject: [PATCH 3/4] drm/bridge: lt8912b: Manually disable HPD only if it was enabled MIME-Version: 1.0 Message-Id: <20230804-lt8912b-v1-3-c542692c6a2f@ideasonboard.com> References: <20230804-lt8912b-v1-0-c542692c6a2f@ideasonboard.com> In-Reply-To: <20230804-lt8912b-v1-0-c542692c6a2f@ideasonboard.com> To: Adrien Grassein , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Francesco Dolcini , Stefan Eichenberger X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1180; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=Saj/S8br2Pn8J3bw6L6o8aOvLR2HwJ6wjYN6KAzMzkU=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBkzNd6liHCPx0ghKBP8t9JRvjgyQWiphU0oyD/m t9DegCFRgyJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZMzXegAKCRD6PaqMvJYe 9Zc7D/9FlNRiienw4V23B/lNpiOjKqmz7DNA6PdgZUnUnITvIoMehOP1f4ohGTivF9vewrvcPEy I0yY+lrHwzGJJM4H3PhbxlxjWtkHk3cjSfwquFrXXpCoS7eXr06zOK9yqSppAnylU5Ua6PAzegA LkpkfmyOFKJPvxbeL+rEM85MFIm4kbdx1TTYgS8wYI0ZDbk725VfDIMqK9t3xCL7IbN/TDpi+az l36QgZFRabDgyjTVC1/sij878thJr96JSXySEZtbtW/3WqPGDUXARxrkypmdEwaP8YNRuBNUrGl u6ya75o07hZQhkI/fIoOMCp+CavALCs4v9KiRShRh79otuwrKvnL9eXTboMBFDF0IOLHs7/spOi i8rD/onkTUW72a7RAmrgmW4PEwAgSsFXMxA/7BJOQDcDiph0re0aC26/VQko7EGCBlIcht8RRf+ 1nldp4Ik0lTGetaMKY3DoRLNshQ/3l1cVubAAVfyvYYozMkcAAK/THri3yuWeen/VZxfgsXdJT6 CiXkylVveds9/wckOyaq4F1TO0zQlEGqfrP4MLbY+lo1P81YpDFTVbWSjjxPn8eTpbie8h3TsPJ yWhuJ0UcOxF6vL5+E04Peolih8Z7ZCtqJ6c6awI4SsXstywT1Kw10kbdvJykKHhKWe2hccWPX7D Kicpr2fJcnyk0nA== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" lt8912b only calls drm_bridge_hpd_enable() if it creates a connector and the next bridge has DRM_BRIDGE_OP_HPD set. However, when calling drm_bridge_hpd_disable() it misses checking if a connector was created, calling drm_bridge_hpd_disable() even if HPD was nenver enabled. I don't see any issues causing by this wrong call, though. Add the check to avoid wrongly calling drm_bridge_hpd_disable(). Fixes: 3b0a01a6a522 ("drm/bridge: lt8912b: Add hot plug detection") Signed-off-by: Tomi Valkeinen Tested-by: Marcel Ziswiler --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c index 2d752e083433..9ee639e75a1c 100644 --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c @@ -587,7 +587,7 @@ static void lt8912_bridge_detach(struct drm_bridge *bridge) lt8912_hard_power_off(lt); - if (lt->hdmi_port->ops & DRM_BRIDGE_OP_HPD) + if (lt->connector.dev && lt->hdmi_port->ops & DRM_BRIDGE_OP_HPD) drm_bridge_hpd_disable(lt->hdmi_port); } From patchwork Fri Aug 4 10:48:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13341659 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 519C8C00528 for ; Fri, 4 Aug 2023 10:48:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3AB7410E6D7; Fri, 4 Aug 2023 10:48:40 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0BD7F10E6D9 for ; Fri, 4 Aug 2023 10:48:34 +0000 (UTC) Received: from [127.0.1.1] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6299F1BAD; Fri, 4 Aug 2023 12:47:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691146048; bh=wWBZWiT0oUkuBhlljvcPfDGweqQW3nGwmkQPCsaA5Vo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=EqUPkYNaZfDDCDY6q/bvUzfiH177DTQIYGWGLt+YJ7gTR5MuEkuW1reL3elT3R4/B 08tCCc0b8ZCpWDhj0QOMKdxod9okn6nm63Afosmz+nGMaRlYktlWFPF8ZKpke38AN4 Ft6YnhfuxCKkIEs3xhNyJ+25v61M0t2NFQCuZsME= From: Tomi Valkeinen Date: Fri, 04 Aug 2023 13:48:13 +0300 Subject: [PATCH 4/4] drm/bridge: lt8912b: Add missing drm_bridge_attach call MIME-Version: 1.0 Message-Id: <20230804-lt8912b-v1-4-c542692c6a2f@ideasonboard.com> References: <20230804-lt8912b-v1-0-c542692c6a2f@ideasonboard.com> In-Reply-To: <20230804-lt8912b-v1-0-c542692c6a2f@ideasonboard.com> To: Adrien Grassein , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Francesco Dolcini , Stefan Eichenberger X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1199; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=wWBZWiT0oUkuBhlljvcPfDGweqQW3nGwmkQPCsaA5Vo=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBkzNd7/XHP9tGXxHiTXMJmJFkR3wv/kVdAl1HQk 1EWlPEUruGJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZMzXewAKCRD6PaqMvJYe 9TksD/kBNffp85lXTu9sLgSmeOZqRazAJ3G3IkXbZbjX/G1+zevQp7wRgWCjS1uB+7rpsmpF0mY EsJmSQ6k/oUG0AwZfPQ4rgQiINe4rA6QHh5xOE793rl8ahyhf3tv4v7/yGl/m52SwVHm3tqFy+v LJTghF5RZxxDL7HSgv1LYK+38q9pF+v2DhkOOXtPwLxAeN61jtngSpZztzFRWOUKV5aIeyQEbi9 FYTctfPh6zq1jN1IKMo7754SbBb/2ftLq+wWeaTDBE1AILg3J6VKopJUixt4wsvqp5sFtjV+m7y 0hw2t8zhG+jC+blWL9zdfyTzyyg4IFQTQCNLIB4rqmJE7Q1qG7j9E0rael1+47v0WMPfPFQTvFH DDyK7JSBI9F9FA/AeivgbM7M7PqvcEKpcx1eAP6nkdO6tM34ToALLDzduAkMz2Emn5qvt5/mGGq HYL6yzEwMFGatseQHnyb+C31YlkqixNKUGPvZ1fVRvDLUp7ymwUGZaMLWPUfr5XCanrSrkw+z5n INifX2p5sRAAkuqB7O9Yfeq/LQW9e29KBSDYLLvBMXIffb1CwZz1Q2m8gS8p+Tr25vASn3ECGQz /e1NBg+HY45zHyE34cXMD9aE0p4KsYH7sd1kX4GQvginwbDS9JvpRPhEc2Qkt2grvaC0Cq9F1Vn o0NR/Nhe0RZlMrQ== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The driver does not call drm_bridge_attach(), which causes the next bridge to not be added to the bridge chain. This causes the pipeline init to fail when DRM_BRIDGE_ATTACH_NO_CONNECTOR is used. Add the call to drm_bridge_attach(). Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge") Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c index 9ee639e75a1c..03532efb893b 100644 --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c @@ -558,6 +558,13 @@ static int lt8912_bridge_attach(struct drm_bridge *bridge, struct lt8912 *lt = bridge_to_lt8912(bridge); int ret; + ret = drm_bridge_attach(bridge->encoder, lt->hdmi_port, bridge, + DRM_BRIDGE_ATTACH_NO_CONNECTOR); + if (ret < 0) { + dev_err(lt->dev, "Failed to attach next bridge (%d)\n", ret); + return ret; + } + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) { ret = lt8912_bridge_connector_init(bridge); if (ret) {