From patchwork Fri Aug 4 11:51:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: coolrrsh@gmail.com X-Patchwork-Id: 13341726 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0659BC04E69 for ; Fri, 4 Aug 2023 11:51:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbjHDLv3 (ORCPT ); Fri, 4 Aug 2023 07:51:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbjHDLv2 (ORCPT ); Fri, 4 Aug 2023 07:51:28 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFE4A126; Fri, 4 Aug 2023 04:51:27 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1bba2318546so17287795ad.1; Fri, 04 Aug 2023 04:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691149887; x=1691754687; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EpCoMosoIXOO1/gDhVlRe3nSdzU9AxF1CUsvfhuvl64=; b=Q+yg1h+AqmExFO6I6PkkJXrz9I9Q0PZyKNpQsaP5rDr7Yp2ajIjHjOxLY1wIktXqzL 8ovTZi9IZViFTdNhfs1tzTNtnjrJIRji390eUIhUU0AyRIghbjY7PbBvTTlOC1NjVmiy Spt3ki4F0evyXTOXxIJnRUe7P3e6bgdj/W/s7qUOVmtlWnCbgSu5rkMRgIoOY5G69lQG BrwBmcUnl6/Vhe2Pod6t6yKtH7tjzFqZ1JOYu8/11D2QRCaZGf0//ROoBQEGMm8LyArY PSivE6WHV3zUUnOc6Cosa9OD/JQQYPSEWNe2CDi+bQkxF0FxETe34gnMgi25hFftMi5e OhNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691149887; x=1691754687; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EpCoMosoIXOO1/gDhVlRe3nSdzU9AxF1CUsvfhuvl64=; b=J4Tw9PMrsYUuLEi2SaIv8a8jTTyZ7J6skcl5qObc2tiFDkfoXqTiRwBrxwL3qkAS7j LnhvzEhjpJYH8TA+v+VakSQevTPxeIJRxtrT+ef3sXIXXzJBGIF3tlyRJT7NT2weHI8R 8aeGbeuNr8FGBqbxt0d177MlemF1mQER0FySxgClMFr+6b5d2qyQYQrb66ZAapn43nlX /Cf6tNXhP9aMGW0MQh8kr2Djcim7tDlxtkY1u4+fyv8Fn2vrDXMPjo6TW19/gS4z1mVG gblbm5lmG+yNrFhpQ0Eh0DGvo6u00A1shFDJQvJyzzO89IlEJauPg+vZ4Huhp6fIwbwv HzaA== X-Gm-Message-State: AOJu0YzPtq/UDdu01KbHni/ZQS8AM+Lvq9BUA0eLGSx1ll0hBm9/Ay9f 16/cB4aWX0/htnKObhWdsLq50BJm3Rs= X-Google-Smtp-Source: AGHT+IH8TzRuRlHcKcXfFTrYBjw0CCIesfPCEfbmWNWXvGmi6iSEXk400b8aRkLxVaP8Yf4nSuGW5g== X-Received: by 2002:a17:903:41c1:b0:1b1:9233:bbf5 with SMTP id u1-20020a17090341c100b001b19233bbf5mr1811114ple.57.1691149887016; Fri, 04 Aug 2023 04:51:27 -0700 (PDT) Received: from localhost.localdomain ([2409:40c2:1022:c939:1859:30f6:c95a:3e44]) by smtp.gmail.com with ESMTPSA id je19-20020a170903265300b001b9dab0397bsm1587773plb.29.2023.08.04.04.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Aug 2023 04:51:26 -0700 (PDT) From: coolrrsh@gmail.com To: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-kernel-mentees@lists.linuxfoundation.org, Rajeshwar R Shinde Subject: [PATCH 1/2] fixes warning Date: Fri, 4 Aug 2023 17:21:20 +0530 Message-Id: <20230804115121.34035-1-coolrrsh@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org From: Rajeshwar R Shinde drivers/spi/spi-mpc512x-psc.c:493:5-13: WARNING: Unsigned expression compared with zero: mps -> irq < 0 Signed-off-by: Rajeshwar R Shinde --- drivers/spi/spi-mpc512x-psc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c index 99aeef2..50a4f31 100644 --- a/drivers/spi/spi-mpc512x-psc.c +++ b/drivers/spi/spi-mpc512x-psc.c @@ -490,7 +490,7 @@ static int mpc512x_psc_spi_of_probe(struct platform_device *pdev) (struct mpc512x_psc_fifo *)(tempp + sizeof(struct mpc52xx_psc)); mps->irq = platform_get_irq(pdev, 0); - if (mps->irq < 0) + if ((int)mps->irq < 0) return mps->irq; ret = devm_request_irq(dev, mps->irq, mpc512x_psc_spi_isr, IRQF_SHARED, From patchwork Fri Aug 4 11:51:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: coolrrsh@gmail.com X-Patchwork-Id: 13341727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5736C00528 for ; Fri, 4 Aug 2023 11:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229538AbjHDLvd (ORCPT ); Fri, 4 Aug 2023 07:51:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230026AbjHDLvb (ORCPT ); Fri, 4 Aug 2023 07:51:31 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EB4C180; Fri, 4 Aug 2023 04:51:30 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so1357752a12.1; Fri, 04 Aug 2023 04:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691149889; x=1691754689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e2EtyOVR4achsHfoqHulXQMM4qvU1Tc5rB6swnOUt9A=; b=RkXaPq+y0NMC78lUo79YLQxkRdl8QVxoFjh2/Pb8teHzMojIAmXpeIkvM6to9j2877 ZlWpuWKOaunJeaN0afmlmfGTHThR7/9oH9Cfkmjksy1Hr+lxB2vVnGHuBe8RdqhtS3NQ uPNeTOoZhwCHV0zk2g+heC6yoYCdTu59n+tUsBevLutgQ8Yn2cR6lOeG/d2lExMrhWBz FxriyZomUg1pWe6+93XUC/2Y5Ch0myj0nvZ5dOM2+4Up6AXxklX1ehN4uwOCY4hJKu9U zvPdv3PCad31AL1uoYo0RdQ+9jSA6Z7kR78z518SUTclU2ElQEjfMU+qLcg7sP58AhBw rBUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691149889; x=1691754689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e2EtyOVR4achsHfoqHulXQMM4qvU1Tc5rB6swnOUt9A=; b=i2ocQjVIqJ1+2tkt73Z5Ylto11wvTDXGIRnsJluSCi69cQKUFLVHCDgyAoI6UYkACL cLXoEtdqIv0yxKY3vI0qH0k2p/HC2kJbAeaHbvtuMJTMJ/ZOrNzFam7S9YshxSQOD1eA ajEH0P4XnJk6ZcvBBtAbXbDcQI67m3UtvOT9/UZQBH0NeKYX30YIhvZZ1u20lKUzViSN sJZt4liCeFEwI7Aw0j10GZGbxffylUd7aH1XAR8TSjBQaLYh91Y6rW5wfDxQuGleNGmF ftoO27H2SX8slT2JMFyA3whQEujv9MQFkRsYsd95kkrH3KkWf88Jnn4Kl2TvK2WXgGVS Aq6g== X-Gm-Message-State: AOJu0Yx/EJvZbsG7GM2g+yQ4Jv9oyEORS4ejDAKqfd94Y8Zs5HD71z1o DlwFx2g81rp3MRQ2cYyyqrM= X-Google-Smtp-Source: AGHT+IFrlm4tOx+dZl0DNygmKZUm3g3WWUWZy8C2IkoWH/jLQBTmJeONwoqQItdqyH7rurNQ6Cd9rw== X-Received: by 2002:a17:90a:dc06:b0:261:2a59:dc38 with SMTP id i6-20020a17090adc0600b002612a59dc38mr1602346pjv.25.1691149889549; Fri, 04 Aug 2023 04:51:29 -0700 (PDT) Received: from localhost.localdomain ([2409:40c2:1022:c939:1859:30f6:c95a:3e44]) by smtp.gmail.com with ESMTPSA id je19-20020a170903265300b001b9dab0397bsm1587773plb.29.2023.08.04.04.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Aug 2023 04:51:29 -0700 (PDT) From: coolrrsh@gmail.com To: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-kernel-mentees@lists.linuxfoundation.org, Rajeshwar R Shinde Subject: [PATCH 2/2] fixes warning Date: Fri, 4 Aug 2023 17:21:21 +0530 Message-Id: <20230804115121.34035-2-coolrrsh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230804115121.34035-1-coolrrsh@gmail.com> References: <20230804115121.34035-1-coolrrsh@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org From: Rajeshwar R Shinde drivers/spi/spi-mpc52xx-psc.c:332:5-13: WARNING: Unsigned expression compared with zero: mps -> irq < 0 Signed-off-by: Rajeshwar R Shinde --- drivers/spi/spi-mpc52xx-psc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-mpc52xx-psc.c b/drivers/spi/spi-mpc52xx-psc.c index 9a1a080..7452bc9 100644 --- a/drivers/spi/spi-mpc52xx-psc.c +++ b/drivers/spi/spi-mpc52xx-psc.c @@ -329,7 +329,7 @@ static int mpc52xx_psc_spi_of_probe(struct platform_device *pdev) mps->fifo = ((void __iomem *)mps->psc) + sizeof(struct mpc52xx_psc); mps->irq = platform_get_irq(pdev, 0); - if (mps->irq < 0) + if ((int)mps->irq < 0) return mps->irq; ret = devm_request_irq(dev, mps->irq, mpc52xx_psc_spi_isr, 0,