From patchwork Sat Aug 5 16:22:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alper Nebi Yasak X-Patchwork-Id: 13342620 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0577DC001DB for ; Sat, 5 Aug 2023 16:25:55 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D39F4820; Sat, 5 Aug 2023 18:25:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D39F4820 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1691252752; bh=KD1gnX5/eGkeMKLvC989RkR9cLRTLcOZsmWQGd4KHB0=; h=From:To:Cc:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=rEtIi364ZOv8qwNfQSnVlWHe7IuEPEfwnRGU86JUHXHFNT/SUanRhsTnRf4ZQmLUZ 3hjiqDRy8We8bCyleV7S0v+QyXBu8UrqOsAgjoBCQdZIwP4hieFiRoZrHEvQWeT4eQ fdry29tswWTXf4nNRaAstXyZLBTeaLAHYtuzh/Tc= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 59B3BF8053B; Sat, 5 Aug 2023 18:25:02 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 19EB9F80087; Sat, 5 Aug 2023 18:25:02 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 322CAF8025A; Sat, 5 Aug 2023 18:22:37 +0200 (CEST) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3F6D0F80087 for ; Sat, 5 Aug 2023 18:22:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3F6D0F80087 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=niWJpZG0 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3fe426b8583so24513615e9.2 for ; Sat, 05 Aug 2023 09:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691252549; x=1691857349; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SNfDyfwYBpzfaoZbAIE6EgJYECHgCylif4C/yupq9CQ=; b=niWJpZG0OU/zQcYy9oz1AuH4Rjto9ldCL8tUU8Y3Bzn+B8AjIgiBpFJt00QELZHSjD RrBstF67mpu+EHTtmVoIuCJAkCpNtRKGSCXqgT7hN8j+5+CVwNXRjB3QvW4ikRwGGtLS qEgtK7P4ZOg6gX3g14oN5+IYZXkMwKS22pKqZ3+I3wItRser25ryzmS4FqDlRXs0E/0K 7APPoo6PU7JC1ife9DgkOT2bBpPdZn71URlDeBzyyYrMEN0ZzkK7GIfOzMSfrbz9838M 6ttO8QP3HvLG9ViVCQrbrZSuBs85pC4VclwY1bb5SQ0tVNY9bT6IQ67dY0hxY3O2cDOZ 3P1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691252549; x=1691857349; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SNfDyfwYBpzfaoZbAIE6EgJYECHgCylif4C/yupq9CQ=; b=TjT/ZJcX/kKOV10OuCXddChcOd8r+eTodxh2KbL7vUp9Njpy5GeDCxTrhApNhQe2pl uNMxCqWLRHAg7PtYR/0KnJLvp5+eWv3JJ8qRlYRpwdC9Z3T67np73drX+9jYio1LWRk6 X3FckEfL//sguKuw7kvGbzDMzF+Pv8jdms8H9xj6oSVK4MkBR3YURjYHLTgynxpNoPGI 38G9uGkPuK5dU5HXdOr36hUDBTNfVOsLiT8sKGub2bmzcJH4B7PZI3UFqT4l3HazREuJ 4KW9ZUT4npU44fIJGLlD2Zsb4BsYCXPIajRbDUH81j55Y1mWJcfP33F2K6nseMDx5ftq F2dA== X-Gm-Message-State: AOJu0Yw8u0ckeubKmiOE0nuKvgPjrgkA/URbYMOrJqyktXzDP1qpT09O WuZsNT4hY4ieQbSWqHVybd1hQTg0VVI= X-Google-Smtp-Source: AGHT+IFV27M6Ye2RYbBMYwaesczoiT6wmLBTABsbL3gUj4lS4oWUaB3lniwbPRZtWNUdbUQRVSoN1w== X-Received: by 2002:a7b:cb95:0:b0:3fe:374f:f7fd with SMTP id m21-20020a7bcb95000000b003fe374ff7fdmr4008716wmi.33.1691252548785; Sat, 05 Aug 2023 09:22:28 -0700 (PDT) Received: from ALPER-PC.. ([178.233.24.1]) by smtp.gmail.com with ESMTPSA id q7-20020a1cf307000000b003fa98908014sm9733202wmq.8.2023.08.05.09.22.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Aug 2023 09:22:27 -0700 (PDT) From: Alper Nebi Yasak To: alsa-devel@alsa-project.org Cc: Alper Nebi Yasak , linux-kernel@vger.kernel.org, Mark Brown , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , Akihiko Odaki , Vijendar Mukunda Subject: [PATCH] ASoC: amd: acp3x-rt5682-max9836: Configure jack as not detecting Line Out Date: Sat, 5 Aug 2023 19:22:16 +0300 Message-Id: <20230805162216.441410-1-alpernebiyasak@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Message-ID-Hash: PJDQWIGUKJFPINNOCK6A3XRT3BIXMV2G X-Message-ID-Hash: PJDQWIGUKJFPINNOCK6A3XRT3BIXMV2G X-MailFrom: alpernebiyasak@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The RT5682, RT1015 and RT1015p codecs used in this driver do not seem capable of distinguishing Line Out connections from Headphone, but the driver configures its jack object as if it can. Remove the wrong value from the jack creation call to avoid any confusion. Signed-off-by: Alper Nebi Yasak Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki --- Depends on [1] which applies onto of linux-next. Untested, see [2]: [1] https://lore.kernel.org/alsa-devel/20230802175737.263412-5-alpernebiyasak@gmail.com/ [2] https://lore.kernel.org/alsa-devel/3d6794c9-60d3-b8f3-99d2-afdc69593d9f@gmail.com/ sound/soc/amd/acp3x-rt5682-max9836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 626c67169f9972fffcdf3bc3864de421f162ebf5 prerequisite-patch-id: 7158530856f8f97324906b342528a5ffe7b4032b diff --git a/sound/soc/amd/acp3x-rt5682-max9836.c b/sound/soc/amd/acp3x-rt5682-max9836.c index 3bf7e1e83c36..28ad5f5b9a76 100644 --- a/sound/soc/amd/acp3x-rt5682-max9836.c +++ b/sound/soc/amd/acp3x-rt5682-max9836.c @@ -98,7 +98,7 @@ static int acp3x_5682_init(struct snd_soc_pcm_runtime *rtd) rt5682_dai_bclk = clk_get(component->dev, "rt5682-dai-bclk"); ret = snd_soc_card_jack_new_pins(card, "Headset Jack", - SND_JACK_HEADSET | SND_JACK_LINEOUT | + SND_JACK_HEADSET | SND_JACK_BTN_0 | SND_JACK_BTN_1 | SND_JACK_BTN_2 | SND_JACK_BTN_3, &pco_jack,