From patchwork Mon Aug 7 21:30:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 13345056 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 238F3C001DB for ; Mon, 7 Aug 2023 21:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3Vwkdks0SHOFZ9P6FInzxtw7y6nH/YMBiWFsd67WmWY=; b=1WYM5TfVlJLr80Kr++qO7lK3o0 QSg6llAf8zd82KDqPixXqaPOifNEMEihMnAAO8qh2MNrT4zUcUz8bgMD/KeJHpr38kusbEIP86tok ak/yUrcHOPe5u7N9nuIxey0VKou8DeDfJYgxV9M0sBLSmc6qcnXGSu7FX+HHIkh4OFBNtrrze+/Zo 27DU2oqJ8QOhJifoEFQoiKyWznzUHMXV3XACXZMNIRAkQpoJ6yRFGhN6mlL3rAKpU/cXlq78/f0aI vDIjJcK6086gCu8UVJFgZe3p7LgautbhL0WN4gjY00XhtM23U9GujUn9dip5yQ6CbqlB4op1f0Z0g O7fFF+qA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qT7oG-000m2G-1i; Mon, 07 Aug 2023 21:30:40 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qT7oC-000lzl-0D for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 21:30:37 +0000 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-686efb9ee3cso4813831b3a.3 for ; Mon, 07 Aug 2023 14:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1691443834; x=1692048634; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=N8uAVZTzBZzHTlaYxOggupJmvV1pp7v4gyX1+niEtPU=; b=bzuKsBITt2bnDi7FBz8DhYJqGopUhpXufdNcFaXvr43Tr0RKJhktCZf9K2A251rOMh arewQOrt8Ia6uHxz16RUDGHqX/WnC9Q2em5VGRVetIBi0V83RTArhV83Er8Uqc2ziL8b i7pAcwYbgFlscMoPZanjmpyBGJww5kxHtNr7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691443834; x=1692048634; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N8uAVZTzBZzHTlaYxOggupJmvV1pp7v4gyX1+niEtPU=; b=gIHV8uALcnA+CzHKbPJ36fVvqzvsjRF7Ce3eewb8YvQ9vjZVhk7hJ2Y1mDf3w+vXHP XXCXN9z74YyL2+bM/5KJhR91bJv7dcGbPMf2u5StgYXpNMwwOhFizg/mS7JvNJSB0Fy4 iSZ5FPfBLyiVq/N+uqdLHcbi4OaR2z+5K1wAIRHeNe0FlaG6QHUhHFB1hVMaxcWc97Jt Ghees3PmxxoE+/wTmrGkcQDL2G+OQIrEC+IT4h5U1HVZlAM2vzWS2F9gqBQ7VSuasedF jis+9ZxJXc2e0RUQVFaNeScKWBxyXTEorfDoENVMwTzP1+t24yD19jf1hK+o+5dU1+4H ydkw== X-Gm-Message-State: AOJu0YzXAcAtFFdmWUzLWVa013EuTVRjT6j8qkMT+9/ON8r9wtGTw8od KbPhPYD352laLlvLXa0z01rMZA== X-Google-Smtp-Source: AGHT+IHGDF9JBdyq8KbbuIF3YTfh+8q+3TYwg4CGMDcVNGpCQKOwqbACjPLo5ORSWORZUO/pPNL7aw== X-Received: by 2002:a05:6a20:3d05:b0:132:a85f:b20c with SMTP id y5-20020a056a203d0500b00132a85fb20cmr14833895pzi.38.1691443833983; Mon, 07 Aug 2023 14:30:33 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id fm13-20020a056a002f8d00b0064fd4a6b306sm6571822pfb.76.2023.08.07.14.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 14:30:32 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Linus Walleij , Ray Jui , Scott Branden , Broadcom internal kernel review list , Andy Shevchenko , linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE) Subject: [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages Date: Mon, 7 Aug 2023 14:30:21 -0700 Message-Id: <20230807213022.1862903-2-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230807213022.1862903-1-florian.fainelli@broadcom.com> References: <20230807213022.1862903-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_143036_105454_CF36127E X-CRM114-Status: GOOD ( 14.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We can have gpiochip_add_data() return -EPROBE_DEFER which will make us produce the "unable to add GPIO chip" message which is confusing. Use dev_err_probe() to silence probe deferral messages. Signed-off-by: Florian Fainelli --- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c index cc3eb7409ab3..153bfd3a48a4 100644 --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c @@ -892,7 +892,7 @@ static int iproc_gpio_probe(struct platform_device *pdev) ret = gpiochip_add_data(gc, chip); if (ret < 0) { - dev_err(dev, "unable to add GPIO chip\n"); + dev_err_probe(dev, ret, "unable to add GPIO chip\n"); return ret; } From patchwork Mon Aug 7 21:30:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 13345057 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AD01C001DB for ; Mon, 7 Aug 2023 21:31:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=76VGu++PDzCUhGOatLWHrvKD/f+yThnQGgAwLNf7ShE=; b=YxxkYDyibIURI7eOwbNz9GK8/u LQkF47omikqeTUPJRoExT+gMtQ1r10NGzzGQq9i5hRRZd5YsBIivi7fPACb5BTeXI2Xt+QTUPFrhF 3P7htmHOyUl8G6OU5tVGpcFdmYDdy61gWovVCVpCWVWtHMZlxFELNV7FziO1TtJ3kIhUaszq66yzG 9O2BARs0FT8hukbvczdONWC2i1HKja54ojGklL3EHnYkspbcDJQIhahviOlpRbV886FyM7MaOS/zr zoYwO5SDFqfCgTs9Ofhz4UT6wyP4/C6nOIIxp5HTF+K1PVtNdqeVGjsSz3XExoN04B91uQJuo7ZGJ pkfxzIzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qT7oK-000m3w-2O; Mon, 07 Aug 2023 21:30:44 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qT7oE-000m0e-1N for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 21:30:39 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6873a30d02eso3286119b3a.3 for ; Mon, 07 Aug 2023 14:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1691443836; x=1692048636; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=/zdLa45xTF40kgaVQfzcldjAxAgCSbWkC199AaLoK6U=; b=QYy9d+KPAQQNxM3hRTF4MIAKP63NcYa1n1afYjqG4WmSJ9dqp7PMthw4lfkN8XerBY QKx0ROQ1iQEunXtCpbxl6jtQrARFafUNNz4yVILvHaURT7rhgfcQ9Q4Ns0pXvr/M2GPE L1/Y/W18FMoYx3OCTojHy8iRrvU+h2P04ygKM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691443836; x=1692048636; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/zdLa45xTF40kgaVQfzcldjAxAgCSbWkC199AaLoK6U=; b=E812Na+KZ32W5e6bq+2ZPXrAnlklE1CI2Deinkh2drZhdDL1dDnUD4COIzuehsnemH GMoxQz5WBCbTaxra9JhV8jTkrbJW1MR7FGsas4E9rVwXScUtv0MnVfxhQhtGg39NDzyd JvJOIHjE9kcYNa62/F0tPDcoE2kwRxAt4Y7aLoUlUTXWUdS2EtBIZEm5UNYz3d3I0png Fz/xsuAzplQaoaXvB98o0sNegWAsXgFrc2QmPQFd9ONG+8riKBtDvuo2qtCGSsGcKIgc ew65MIkMhB4nL0LJ6vfFGGXhktvB3EWDQw3RI8mA0B4/ifHlSXVq4NILWg/u9Ctbco6D Y/Hw== X-Gm-Message-State: AOJu0YyP/zX/cLDsdScLhRZEq4Ad1A54yeEXgTEsWaJyRphx6uR0Jd+F B3840RkDnxrEVg/9NtaX80V9XQ== X-Google-Smtp-Source: AGHT+IEoqUeOi1Lnwc6XDO9laauwqASSeutSQn6oLmeZyH7g2a+JK7+y6n7HMT2GMjO00VGcdR59fA== X-Received: by 2002:a05:6a20:72ac:b0:13b:a4fd:3017 with SMTP id o44-20020a056a2072ac00b0013ba4fd3017mr10732055pzk.46.1691443836380; Mon, 07 Aug 2023 14:30:36 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id fm13-20020a056a002f8d00b0064fd4a6b306sm6571822pfb.76.2023.08.07.14.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 14:30:35 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Linus Walleij , Ray Jui , Scott Branden , Broadcom internal kernel review list , Andy Shevchenko , linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE) Subject: [PATCH 2/2] pinctrl: nsp-gpio: Silence probe deferral messages Date: Mon, 7 Aug 2023 14:30:22 -0700 Message-Id: <20230807213022.1862903-3-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230807213022.1862903-1-florian.fainelli@broadcom.com> References: <20230807213022.1862903-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_143038_465869_7530B119 X-CRM114-Status: GOOD ( 15.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We can have gpiochip_add_data() return -EPROBE_DEFER which will make us produce the "unable to add GPIO chip" message which is confusing. Use dev_err_probe() to silence probe deferral messages. Signed-off-by: Florian Fainelli --- drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c index 5045a7e57f1d..e32901a92fcf 100644 --- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c @@ -687,7 +687,7 @@ static int nsp_gpio_probe(struct platform_device *pdev) ret = devm_gpiochip_add_data(dev, gc, chip); if (ret < 0) { - dev_err(dev, "unable to add GPIO chip\n"); + dev_err_probe(dev, ret, "unable to add GPIO chip\n"); return ret; }