From patchwork Thu Aug 10 12:25:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13349362 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E052442C for ; Thu, 10 Aug 2023 12:25:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E78B0C433C8; Thu, 10 Aug 2023 12:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691670334; bh=1f1uo4HhIlgH6LQc+YKtqnOOYeuciSTPT0zrCjcnXio=; h=From:To:Cc:Subject:Date:From; b=AerNdbBBddvE2On+cYp4dMdrRdmJXjHtrNolxFfAV6vrZ2QzZ1qT0twkSqjmM23yC K5fy8gieyWVpD5iQoxXB0jSUKvbzzKe9BORAnv0WHXgirr0mUJKYdAeEkBbkEw2WhR 27HVE3jF6a/HaNxFGrLK5dR6KsuhFT/ecpVn2QgZTW9fCLPO7DCRTggzjdq9fBTR48 BzvpjUAJ5KcEs5Gmgyc1Z9Kn3Yy05orERx1bhHepK0A18Jo3rXnoMVktfxTLjNCFjr ZhSdNpD3GJBtyvtMtgL2G5/ffwXQso5G+mFSH92Rcw5LObLD7JEvwFrfHQPjzR8WNO 3h4ggjR0pZfaQ== From: Arnd Bergmann To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Arnd Bergmann , Geoff Levand , Petr Machata , Piotr Raczynski , Wolfram Sang , Liang He , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] ethernet: ldmvsw: mark ldmvsw_open() static Date: Thu, 10 Aug 2023 14:25:15 +0200 Message-Id: <20230810122528.1220434-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Arnd Bergmann The function is exported for no reason and should just be static: drivers/net/ethernet/sun/ldmvsw.c:127:5: error: no previous prototype for 'ldmvsw_open' [-Werror=missing-prototypes] Signed-off-by: Arnd Bergmann Reviewed-by: Simon Horman Tested-by: Simon Horman # build-tested --- drivers/net/ethernet/sun/ldmvsw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c index 734a817d3c945..a9a6670b5ff1f 100644 --- a/drivers/net/ethernet/sun/ldmvsw.c +++ b/drivers/net/ethernet/sun/ldmvsw.c @@ -124,7 +124,7 @@ static void vsw_set_rx_mode(struct net_device *dev) return sunvnet_set_rx_mode_common(dev, port->vp); } -int ldmvsw_open(struct net_device *dev) +static int ldmvsw_open(struct net_device *dev) { struct vnet_port *port = netdev_priv(dev); struct vio_driver_state *vio = &port->vio; @@ -136,7 +136,6 @@ int ldmvsw_open(struct net_device *dev) return 0; } -EXPORT_SYMBOL_GPL(ldmvsw_open); #ifdef CONFIG_NET_POLL_CONTROLLER static void vsw_poll_controller(struct net_device *dev) From patchwork Thu Aug 10 12:25:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13349363 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B21A442C for ; Thu, 10 Aug 2023 12:25:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40B8FC433C7; Thu, 10 Aug 2023 12:25:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691670342; bh=OloAD6QmGKnXstqvq00Y+1wIzRiY4JGxfjab4MiA+Yo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UCUG+UaKbFVMZ9rgnD2AroLE1C9PsQ8Q1mvArgMkR/ncOGxxpBmvZ2n55P2acCo+v rBlTdyWGsxBjjTwfPMv7TdJpnM9bqYSBI6I19btGwMDjXaNy6gzwdC3HMhPb2hB3Uh 3TRtdzVVIwWLO+6cz8EJRN95g8zzhn5A4ckz1abhvlZjSS6N725Xo9dch1PNvke7v2 rJwNyEPg/+fdgzCVxyNi9f7xkqaNvDo3Cz8Xrgr0GGCXssSaIjdnDm0fVm215fSvy4 3864eGhUBbvDZ4I9ivPs0llLT5X1c5KREGx3hi1kD/C6vTyMlnja8v6a1EiGz2DNwN AJlljoPSntnHA== From: Arnd Bergmann To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Arnd Bergmann , Haoyue Xu , Guofeng Yue , Yang Yingliang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] ethernet: atarilance: mark init function static Date: Thu, 10 Aug 2023 14:25:16 +0200 Message-Id: <20230810122528.1220434-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230810122528.1220434-1-arnd@kernel.org> References: <20230810122528.1220434-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Arnd Bergmann The init function is only referenced locally, so it should be static to avoid this warning: drivers/net/ethernet/amd/atarilance.c:370:28: error: no previous prototype for 'atarilance_probe' [-Werror=missing-prototypes] Signed-off-by: Arnd Bergmann Reviewed-by: Yang Yingliang --- drivers/net/ethernet/amd/atarilance.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/atarilance.c b/drivers/net/ethernet/amd/atarilance.c index ec704222925d8..751454d305c64 100644 --- a/drivers/net/ethernet/amd/atarilance.c +++ b/drivers/net/ethernet/amd/atarilance.c @@ -367,7 +367,7 @@ static void *slow_memcpy( void *dst, const void *src, size_t len ) } -struct net_device * __init atarilance_probe(void) +static struct net_device * __init atarilance_probe(void) { int i; static int found;