From patchwork Fri Aug 11 13:06:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 13350908 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 780F4C001DB for ; Fri, 11 Aug 2023 13:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=QXGTLOMhhFnP7P9z/jNCV066WJq1VqI78wxq9zyYlcs=; b=tAB+942FcO+Fse MZ7Syyvrt5Z90LKvCKByQJsvaguD/TdXCOXTf9If34jrAqFhD9ZovG2+/Q9CLUP0NniVwTld50bGT ruhVgADdDpZ9VpzHbY238vu/Xeb/qdyhXKg5xlDAFskyo+qFZhUzqc0xulNpul1KLtBLFpU1K2m00 nzQCLxG/2CjGwujzKYmYuLKO5JFSqttBSd1wuYePbLw+rXXRVwZnmimdOLrtBkaH9GvTLwn+9u7ax 9C9XQnPVvxywxSReG3QxnFSHOjMDcUvMiqs25wtjUDs2sI6OKto+mU1CAFQsu0PRfRBN9Y32/ACrc DEBLaGjsC/t+H0OVlWyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qURrS-00AgHH-1Y; Fri, 11 Aug 2023 13:07:26 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qURrQ-00AgEi-0L; Fri, 11 Aug 2023 13:07:25 +0000 Received: from eugen-station.. (unknown [82.76.24.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madras.collabora.co.uk (Postfix) with ESMTPSA id F38F0660724A; Fri, 11 Aug 2023 14:07:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1691759238; bh=VXusoYfjHaf1R8Q5raJ4gZK4qcwaz24tSqOkD12Aa0A=; h=From:To:Cc:Subject:Date:From; b=m8YQ5hghF7NJPiDxoc0eVVVZW0KT3+2lKdL7KpjLs3T6BxQzGVqflAELP09jpQOva HlTaaoipnyBpu/3hJSrIVt4UDpTzRWTR4qmJhHq9X8Azx4jDM7yZizsCCk3H3t1Fhb ceQ30FZ58AU7DW3MyV5yuuYLrnAwLkSwn2zYf4C/fRHCrPtY36/oyHHugo0IlG4sE1 l/DJM/FmWQsaF94awvFv8xWprPaUGPYDcV0QQPw7J3kx0HwW0xFh6B8SDTexcgr11o 1DPHnpoDWquQy189H7EWvcmQUQPP3Hib3n7MMGjmeJ0749lDj6aXjNAfQkb7dzxTCV D4KR5yNet74cA== From: Eugen Hristev To: linux-mediatek@lists.infradead.org Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, conor+dt@kernel.org, kernel@collabora.com, Eugen Hristev Subject: [PATCH 1/2] dt-bindings: phy: mediatek,tphy: allow simple nodename pattern Date: Fri, 11 Aug 2023 16:06:59 +0300 Message-Id: <20230811130700.72787-1-eugen.hristev@collabora.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230811_060724_315287_A7163044 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The pattern for the nodename only allows t-phy@... , however, for the case when the t-phy has no `reg` and only `ranges` (basically when the t-phy is just a parent node), dtc will throw this warning: Warning (unit_address_vs_reg): /t-phy@1a243000: node has a unit name, but no reg or ranges property For a node like this: sata_phy: t-phy@1a243000 { ranges; sata_port: sata-phy@1a243000 { reg = <0 0x1a243000 0 0x0100>; }; }; it is normal that the parent node 't-phy' would be without any address, as in: sata_phy: t-phy { ranges; sata_port: sata-phy@1a243000 { reg = <0 0x1a243000 0 0x0100>; }; }; because being just a holder it does not have its own reg. However the binding does not allow such a name for the t-phy, so with this patch, making the `@[0-9a-f]+` part optional, such node is possible. Signed-off-by: Eugen Hristev --- Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml index 230a17f24966..2bb91542e984 100644 --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml @@ -64,7 +64,7 @@ description: | properties: $nodename: - pattern: "^t-phy@[0-9a-f]+$" + pattern: "^t-phy(@[0-9a-f]+)?$" compatible: oneOf: From patchwork Fri Aug 11 13:07:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 13350909 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC15DC001DE for ; Fri, 11 Aug 2023 13:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qNhUWVZHDlAG/kcwcjsIhO0tnh9PqClFtSj+I9umFUs=; b=C4Iy1bgECyz/bM W8FknCHr1gm6Jboknoh1g6INztc4VS6+q5sZtPiBb3TViIfupQtFXBMSIuDgDI8luRbnHn/8EJll3 jl1rHAloNufrYATZfdvJ+EhADW9okS45Tq+VKOdIcnqSJEviK6i8ED0qlTUp0wm2TeiiT4RgvDX7x JZhthX8EYss8iJKroj7v3b9SPNRNLs+fT7g6T9urYJzwGwbFlPyEO8hyMzZPFKUXlCykiC1K6kzW1 rfgv4xCR2YV4LXn6Lek0NJOS3xjOyy1eEakAkvrdCoazrJKxsANrKPEYYU3ndDfuG8B1tej6a41PG GEkY1ihZg93BOm1MruGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qURrY-00AgKV-2T; Fri, 11 Aug 2023 13:07:32 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qURrQ-00AgEj-0p; Fri, 11 Aug 2023 13:07:26 +0000 Received: from eugen-station.. (unknown [82.76.24.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4773C660724B; Fri, 11 Aug 2023 14:07:18 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1691759239; bh=pYvofDw9e9+ITQ5T6M5o9bCA2xeJ+ybOXWp8n4SlWjs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kwwtPxd7+qLK4lsEr8RxlqIsd4QXW6rnr0W23fwIHV7RgNE1enjAjPa0uVVn/u5t/ iEzEryq+ZdS80f/J2n6ljCuJRi7Yvl5xQbdhElRA1zz4arhRWw9T3CU4URAViUO3XZ iFVFg8vKD78RIwNoVuT9RzEWOmNH9JFD+7oMOSwyRJZEYt0MU8hGHCTPnnQnRQ05jt 8LciYz1ow66Yo3q6DBOQT/bOAFg8EyMtIWPLrHKOH2zDgUc7vvDvzzFn/3AW+yh/7e WIEZbAuDUMMec+1APblaTsIKnCWpHfJYahJE8cMzNyq52EHHurhCVSYsQlTxqjB4Mj 4qnfQTjY88rug== From: Eugen Hristev To: linux-mediatek@lists.infradead.org Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, conor+dt@kernel.org, kernel@collabora.com, Eugen Hristev Subject: [PATCH 2/2] arm64: dts: mediatek: fix t-phy unit name Date: Fri, 11 Aug 2023 16:07:00 +0300 Message-Id: <20230811130700.72787-2-eugen.hristev@collabora.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230811130700.72787-1-eugen.hristev@collabora.com> References: <20230811130700.72787-1-eugen.hristev@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230811_060724_423227_66506DDC X-CRM114-Status: GOOD ( 11.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix: Warning (unit_address_vs_reg): /t-phy@1a243000: node has a unit name, but no reg or ranges property Warning (unit_address_vs_reg): /soc/t-phy@11c00000: node has a unit name, but no reg or ranges property The ranges is empty thus removing the `@1a243000`, `@11c00000` from the node name. Signed-off-by: Eugen Hristev --- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +- arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi index 36ef2dbe8add..3ee9266fa8e9 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi @@ -905,7 +905,7 @@ sata: sata@1a200000 { status = "disabled"; }; - sata_phy: t-phy@1a243000 { + sata_phy: t-phy { compatible = "mediatek,mt7622-tphy", "mediatek,generic-tphy-v1"; #address-cells = <2>; diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi index 68539ea788df..24eda00e320d 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi @@ -434,7 +434,7 @@ pcie_intc: interrupt-controller { }; }; - pcie_phy: t-phy@11c00000 { + pcie_phy: t-phy { compatible = "mediatek,mt7986-tphy", "mediatek,generic-tphy-v2"; #address-cells = <2>;