From patchwork Fri Aug 18 13:53:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rohan G Thomas X-Patchwork-Id: 13357833 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEC73C71149 for ; Fri, 18 Aug 2023 13:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xdvjLPEEaT5YDc8PMDmBojJVaBH5ydlrWdJP9SrqyDQ=; b=N7+XgywSIhJZIp 4tUCWIexhI5vsin203C+tKnPwO2W+1Ko9AAtufPFVe+CCeF42HQ4IaYUBkCvEomDB8eZr06CgB3eN 9md9pAMhcp03xZ4S86s82spf48frLSJPWNpXq/7da0ilKmZxuJucR7g5evLt83jjrRV228PqvuhNW KyRfStHQ0cKV3N/3qNHD6x+Zg9UBBbSYVEPn2i42PS3bplwBTBESkWT7L/DRacK+VCKweszV7vGPm /dg3CtXjorjosEP9KNTe6tJp9C+XOeHNXSUcMgiWcNurW2wGkTuEqvqWAhPHqhTbxYRocSRFI6DuT akXlLJ3u/82ldQhJrosg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWzvc-009QhG-0Y; Fri, 18 Aug 2023 13:54:16 +0000 Received: from mgamail.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWzvT-009QfL-2w for linux-arm-kernel@lists.infradead.org; Fri, 18 Aug 2023 13:54:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692366847; x=1723902847; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=V1ASKrWZR21qiCs/uTkTgFEuUcWckcx/+Gm2AG2f6Q8=; b=eWH8tRbWblg13VvSN87pT5I5ojSGTlXmgbkOhKbHCbrghGYCtCzyH02k WI9WjISlSNEWZod9DBS3hq6VSZx2+hAlbo1EUXrC6jO6RU2bK4qTYqcJE Kii02uI9GGDtfHF1HMxhNhpTwY4+To5rTE+tKEJxl5f27NTzsfI9PZgdk ZAz3hY6/OH8WFshAdHVCy4U3oGTMwW5hNxAMVYt783LPfQRyajpwo7vbu LpF/YZ7h4Ih/RAOHZ0Js4ts3RzUGc3jsyb6esQ5JTwVz2rEe4GaTtbp+j YtzI6ym8VaBrnJyhYr50lHCn8UoEdspMCVeDEfyCFxz9Prmf8m+JDB0Ah A==; X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="353408018" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="353408018" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2023 06:54:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="849307154" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="849307154" Received: from pglc00067.png.intel.com ([10.221.207.87]) by fmsmga002.fm.intel.com with ESMTP; 18 Aug 2023 06:53:59 -0700 From: Rohan G Thomas To: "David S . Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Giuseppe Cavallaro Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rohan G Thomas , Conor Dooley Subject: [PATCH net-next v4 1/2] dt-bindings: net: snps,dwmac: Tx queues with coe Date: Fri, 18 Aug 2023 21:53:49 +0800 Message-Id: <20230818135350.12474-2-rohan.g.thomas@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20230818135350.12474-1-rohan.g.thomas@intel.com> References: <20230818135350.12474-1-rohan.g.thomas@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230818_065407_979423_5C20DDA2 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add dt-bindings for the number of tx queues with coe support. Some dwmac IPs support tx queues only for a few initial tx queues, starting from tx queue 0. Signed-off-by: Rohan G Thomas Acked-by: Conor Dooley --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index ddf9522a5dc2..0c6431c10cf9 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -313,6 +313,9 @@ properties: snps,tx-queues-to-use: $ref: /schemas/types.yaml#/definitions/uint32 description: number of TX queues to be used in the driver + snps,tx-queues-with-coe: + $ref: /schemas/types.yaml#/definitions/uint32 + description: number of TX queues that support TX checksum offloading snps,tx-sched-wrr: type: boolean description: Weighted Round Robin From patchwork Fri Aug 18 13:53:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rohan G Thomas X-Patchwork-Id: 13357834 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5F28C71150 for ; Fri, 18 Aug 2023 13:54:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2JiTkxbUcx2z9lrpg4RuhIEvKdypoL6waBKjwDxSM5A=; b=nF+74xe1Jg7TUh m9uS6mI1YuGlyjAmBA4jLn1a3EufgKg5Ce/pxYeqgHzrSedfCOLks+HW3bLpErotBG2zGxbo4d1BK LGlTGuVNFSZreHBNbehG3etgALwSGQAIyWOX4u/tyXJJ2oa0kDUs05b/wqz8X1uLUOPLIdsyXVg1f rEyzqon8LuBr32/NSIw7GqCE1t0dyG6g1raKB09EF6VSle2rkxrBZvW52ez5tgIn9t6mmvfdOysxc h3Baqd/EpJih+6iOWE/HHhsn0p0gWzZL/eLc9NNCW2Prc5YC0ItZ7TgEcsg3ZCasJa/vnKhcS5IEu /zwh+t+yMPhsHczhjCQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWzvc-009Qha-2N; Fri, 18 Aug 2023 13:54:16 +0000 Received: from mgamail.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWzvW-009QfL-2U for linux-arm-kernel@lists.infradead.org; Fri, 18 Aug 2023 13:54:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692366850; x=1723902850; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JDFUtXRUDrxtVzEusowNhWGcSf1zOgP5VGknWG1AdaE=; b=hDYMaQZ+SLHHh6e+pa0/FLPeW61PJSlKyQOkS+ORBGcaUJVDWjk7DL+C AR21AkX0w8SV6NecmukyuyxznrhaSj9hqxQKWwcfq4hQsaaCclHtI82cr 8uhWYiQjKfHKYemwEPzzTfa8b5RX+E2kemxoE3MsAj6QXbZx4mlMpLvcj thkUIRIz8B+Fyg1Y04GHKEyogy5zpnISGUML+USngB7NOtS2e/3ZJ0Nj4 /4CAANA9yHkMUv2ZuU28ujm7N7cUVFlTCW6fGFsjuHVZo1/WqYZvwyGjM cwCfPVnOjvq/I6q6k4EmOZUE5ExBcisNMeBbr1dQs/dIwqYUYliaHpH0V Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="353408046" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="353408046" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2023 06:54:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="849307172" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="849307172" Received: from pglc00067.png.intel.com ([10.221.207.87]) by fmsmga002.fm.intel.com with ESMTP; 18 Aug 2023 06:54:06 -0700 From: Rohan G Thomas To: "David S . Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Giuseppe Cavallaro Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rohan G Thomas Subject: [PATCH net-next v4 2/2] net: stmmac: Tx coe sw fallback Date: Fri, 18 Aug 2023 21:53:50 +0800 Message-Id: <20230818135350.12474-3-rohan.g.thomas@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20230818135350.12474-1-rohan.g.thomas@intel.com> References: <20230818135350.12474-1-rohan.g.thomas@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230818_065410_834336_566D217D X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add sw fallback of tx checksum calculation for those tx queues that don't support tx checksum offloading. Because, some DWMAC IPs support tx checksum offloading only for a few initial tx queues, starting from tx queue 0. Signed-off-by: Rohan G Thomas --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 5 +++++ .../net/ethernet/stmicro/stmmac/stmmac_main.c | 19 +++++++++++++++++++ .../ethernet/stmicro/stmmac/stmmac_platform.c | 4 ++++ include/linux/stmmac.h | 1 + 4 files changed, 29 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h index 3401e888a9f6..64d7dbe474bd 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h @@ -210,12 +210,17 @@ struct stmmac_dma_conf { unsigned int dma_tx_size; }; +#define STMMAC_PRIV_FLG_TXQ_COE_LIMIT BIT(0) + struct stmmac_priv { /* Frequently used values are kept adjacent for cache effect */ u32 tx_coal_frames[MTL_MAX_TX_QUEUES]; u32 tx_coal_timer[MTL_MAX_TX_QUEUES]; u32 rx_coal_frames[MTL_MAX_TX_QUEUES]; + u32 flags; + + u32 tx_q_with_coe; int hwts_tx_en; bool tx_path_in_lpi_mode; bool tso; diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 733b5e900817..f9ab6635218c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -4409,6 +4409,17 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev) WARN_ON(tx_q->tx_skbuff[first_entry]); csum_insertion = (skb->ip_summed == CHECKSUM_PARTIAL); + /* Some DWMAC IPs support tx coe only for a few initial tx queues, + * starting from tx queue 0. So checksum offloading for those queues + * that don't support tx coe needs to fallback to software checksum + * calculation. + */ + if (csum_insertion && (priv->flags & STMMAC_PRIV_FLG_TXQ_COE_LIMIT) && + queue >= priv->tx_q_with_coe) { + if (unlikely(skb_checksum_help(skb))) + goto dma_map_err; + csum_insertion = !csum_insertion; + } if (likely(priv->extend_desc)) desc = (struct dma_desc *)(tx_q->dma_etx + entry); @@ -7401,6 +7412,14 @@ int stmmac_dvr_probe(struct device *device, dev_info(priv->device, "SPH feature enabled\n"); } + if (priv->plat->tx_coe && + priv->plat->tx_queues_with_coe < priv->plat->tx_queues_to_use) { + priv->flags |= STMMAC_PRIV_FLG_TXQ_COE_LIMIT; + priv->tx_q_with_coe = priv->plat->tx_queues_with_coe; + dev_info(priv->device, "TX COE limited to %u tx queues\n", + priv->tx_q_with_coe); + } + /* Ideally our host DMA address width is the same as for the * device. However, it may differ and then we have to use our * host DMA width for allocation and the device DMA width for diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index be8e79c7aa34..0138b7c9c7ab 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -225,6 +225,10 @@ static int stmmac_mtl_setup(struct platform_device *pdev, &plat->tx_queues_to_use)) plat->tx_queues_to_use = 1; + if (of_property_read_u32(tx_node, "snps,tx-queues-with-coe", + &plat->tx_queues_with_coe)) + plat->tx_queues_with_coe = plat->tx_queues_to_use; + if (of_property_read_bool(tx_node, "snps,tx-sched-wrr")) plat->tx_sched_algorithm = MTL_TX_ALGORITHM_WRR; else if (of_property_read_bool(tx_node, "snps,tx-sched-wfq")) diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h index 784277d666eb..cb508164eaea 100644 --- a/include/linux/stmmac.h +++ b/include/linux/stmmac.h @@ -252,6 +252,7 @@ struct plat_stmmacenet_data { u32 host_dma_width; u32 rx_queues_to_use; u32 tx_queues_to_use; + u32 tx_queues_with_coe; u8 rx_sched_algorithm; u8 tx_sched_algorithm; struct stmmac_rxq_cfg rx_queues_cfg[MTL_MAX_RX_QUEUES];