From patchwork Mon Aug 13 15:11:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 10564453 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 17F2514C0 for ; Mon, 13 Aug 2018 15:12:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07D5D2946D for ; Mon, 13 Aug 2018 15:12:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EF5F12948A; Mon, 13 Aug 2018 15:12:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8AA362946D for ; Mon, 13 Aug 2018 15:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ZAx9smeAmXmd8zjQ7renjQF94jGE4G5SXUWjtLiSILY=; b=p3HZUWF9ufMgkE FSFkQYiFKxez0rg6rbDud39kFyXCyRfyJiuOcbA0IdW8dTzIW/WnayoZNhgkjOlBVdw3y78t3GYGa WcfeUjIpsU5cp1qLJO34C547HW7oJj0qqPf2FLfHU9VDXVa5Hw/RxM5IBCz5T0I8TuYkjRLXFy8qf xhznk0+I4VInpHazI5zOHDKOdEUbqyCqmG2itV+inOubMjWBKlr7hEiqn2vTu0BA5viK5T+jAPP/h XKCRpYy7Q8GmdvuZLhAvDv9W6c1lvUxZMqoLl0OoDh0k+kdu3bD+OWSxMeTse0PonIxkWV9AViSm+ HG7GyeD2jjYw38UCzfhQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fpEW8-0008OR-Rk; Mon, 13 Aug 2018 15:12:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fpEW4-0008AJ-Px for linux-arm-kernel@lists.infradead.org; Mon, 13 Aug 2018 15:12:22 +0000 Received: from localhost.localdomain (xdsl-188-155-58-14.adslplus.ch [188.155.58.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3CC3721829; Mon, 13 Aug 2018 15:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1534173129; bh=mpAdIh5bskQnJl2meP9mQXucy5zzMEohH6gEC/pODUw=; h=From:To:Subject:Date:From; b=AQ4pFb9WRE/Y95Hn+d/t2NVqBa4pPC+Y1SHSvkwC8fKIMcHVv3/lk7Y2LIsgnVAQm R79ok7qwCmEYUHUaKy/nHqARFHUfTH58nPEM+7cfLpd5JQx9U9fSR3JhZHolV/MwSt ih9SSdB9ou6o0dqJiZ/aatnu2Un8NnODtcQ+35jY= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Thomas Gleixner , Jason Cooper , Marc Zyngier , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] irqchip/s3c24xx: Remove unneeded comparison of unsigned long to 0 Date: Mon, 13 Aug 2018 17:11:44 +0200 Message-Id: <20180813151144.12407-1-krzk@kernel.org> X-Mailer: git-send-email 2.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180813_081220_871537_664D9784 X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP irq_data->hwirq is unsigned long. This fixes GCC warning: drivers/irqchip/irq-s3c24xx.c: In function 's3c_irqext0_type': drivers/irqchip/irq-s3c24xx.c:253:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] if ((data->hwirq >= 0) && (data->hwirq <= 3)) { ^~ Signed-off-by: Krzysztof Kozlowski --- drivers/irqchip/irq-s3c24xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c index f6fd57ebe6e6..c19766fe8a1a 100644 --- a/drivers/irqchip/irq-s3c24xx.c +++ b/drivers/irqchip/irq-s3c24xx.c @@ -250,7 +250,7 @@ static int s3c_irqext0_type(struct irq_data *data, unsigned int type) void __iomem *gpcon_reg; unsigned long gpcon_offset, extint_offset; - if ((data->hwirq >= 0) && (data->hwirq <= 3)) { + if (data->hwirq <= 3) { gpcon_reg = S3C2410_GPFCON; extint_reg = S3C24XX_EXTINT0; gpcon_offset = (data->hwirq) * 2;