From patchwork Thu Aug 24 07:43:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cheng Lin X-Patchwork-Id: 13363661 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A90C7113B for ; Thu, 24 Aug 2023 07:45:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230147AbjHXHoi (ORCPT ); Thu, 24 Aug 2023 03:44:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240436AbjHXHob (ORCPT ); Thu, 24 Aug 2023 03:44:31 -0400 Received: from mxct.zte.com.cn (mxct.zte.com.cn [58.251.27.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4D6510D0; Thu, 24 Aug 2023 00:44:27 -0700 (PDT) Received: from mxde.zte.com.cn (unknown [10.35.20.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4RWZpt1Tz2zQ66; Thu, 24 Aug 2023 15:44:22 +0800 (CST) Received: from mxhk.zte.com.cn (unknown [192.168.250.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mxde.zte.com.cn (FangMail) with ESMTPS id 4RWZpT5yCMzBRHKp; Thu, 24 Aug 2023 15:44:01 +0800 (CST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4RWZpM0vg4z8XrRD; Thu, 24 Aug 2023 15:43:55 +0800 (CST) Received: from szxlzmapp06.zte.com.cn ([10.5.230.252]) by mse-fl2.zte.com.cn with SMTP id 37O7hoQm047164; Thu, 24 Aug 2023 15:43:50 +0800 (+08) (envelope-from cheng.lin130@zte.com.cn) Received: from mapi (szxlzmapp03[null]) by mapi (Zmail) with MAPI id mid14; Thu, 24 Aug 2023 15:43:52 +0800 (CST) Date: Thu, 24 Aug 2023 15:43:52 +0800 (CST) X-Zmail-TransId: 2b0564e70a3801d-0dc13 X-Mailer: Zmail v1.0 Message-ID: <202308241543526473806@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , Subject: =?utf-8?q?=5BPATCH=5D_xfs=3A_introduce_protection_for_drop_nlink?= X-MAIL: mse-fl2.zte.com.cn 37O7hoQm047164 X-Fangmail-Gw-Spam-Type: 0 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 64E70A55.000/4RWZpt1Tz2zQ66 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org From: Cheng Lin An dir nlinks overflow which down form 0 to 0xffffffff, cause the directory to become unusable until the next xfs_repair run. Introduce protection for drop nlink to reduce the impact of this. And produce a warning for directory nlink error during remove. Signed-off-by: Cheng Lin --- fs/xfs/xfs_inode.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index 9e62cc5..536dbe4 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c @@ -919,6 +919,15 @@ STATIC int xfs_iunlink_remove(struct xfs_trans *tp, struct xfs_perag *pag, xfs_trans_t *tp, xfs_inode_t *ip) { + xfs_mount_t *mp; + + if (VFS_I(ip)->i_nlink == 0) { + mp = ip->i_mount; + xfs_warn(mp, "%s: Deleting inode %llu with no links.", + __func__, ip->i_ino); + return 0; + } + xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG); drop_nlink(VFS_I(ip)); @@ -2442,7 +2451,12 @@ STATIC int xfs_iunlink_remove(struct xfs_trans *tp, struct xfs_perag *pag, */ if (is_dir) { ASSERT(VFS_I(ip)->i_nlink >= 2); - if (VFS_I(ip)->i_nlink != 2) { + if (VFS_I(ip)->i_nlink < 2) { + xfs_warn(ip->i_mount, + "%s: Remove dir (inode %llu) with invalid links.", + __func__, ip->i_ino); + } + if (VFS_I(ip)->i_nlink > 2) { error = -ENOTEMPTY; goto out_trans_cancel; }