From patchwork Fri Aug 25 07:19:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13365100 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAA6AC3DA6F for ; Fri, 25 Aug 2023 07:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=uBcSY1JDrBHd86o9izts3yyLbQLunF1rquohiqRykpE=; b=FoyTO39WrAUIqy 1Es+H0eaoMQbZNSkX68uNd9R1O57BOA0aOZrSDlCcMDt4joPHdxrmydK7Wq9vZG9+u4GhruoE/DeM OEeYmtHn+qlMURLjEitaPS/VGdz39DvhAzBxlHC+2KZazrKeZSAu5pMVuszImxwdiDbr3ULK70QTg NtfxENL/esdZj+Tt5e/iWjaIlBOvA5zWPxQ4qLBxw9VFaE1A6+Ovw1GJQ8KapCFe3OFCuzpNbRsLk sx7z3iMubxCNUlHq/fFZif28Ghx+fApaQDQQ5C3ACDxFdABVzTR4GD5EqTAiUA1PYhoANuyOZrGaA C4LOn6SV0kozW7cjz0og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZR6b-004Wzr-2F; Fri, 25 Aug 2023 07:19:41 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZR6X-004WzB-2z for linux-arm-kernel@lists.infradead.org; Fri, 25 Aug 2023 07:19:39 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RXB836w0rzJrnl; Fri, 25 Aug 2023 15:16:19 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 25 Aug 2023 15:19:26 +0800 From: Jinjie Ruan To: , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team CC: Subject: [PATCH -next] bus: imx-weim: Use devm_clk_get_enabled() helper function Date: Fri, 25 Aug 2023 15:19:13 +0800 Message-ID: <20230825071913.2807800-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230825_001938_261528_29B81F68 X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The devm_clk_get_enabled() helper: - calls devm_clk_get() - calls clk_prepare_enable() and registers what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code. Signed-off-by: Jinjie Ruan --- drivers/bus/imx-weim.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c index 42c9386a7b42..5d48dd3d9f92 100644 --- a/drivers/bus/imx-weim.c +++ b/drivers/bus/imx-weim.c @@ -280,20 +280,14 @@ static int weim_probe(struct platform_device *pdev) priv->base = base; dev_set_drvdata(&pdev->dev, priv); - /* get the clock */ - clk = devm_clk_get(&pdev->dev, NULL); + /* get and enable the clock */ + clk = devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(clk)) return PTR_ERR(clk); - ret = clk_prepare_enable(clk); - if (ret) - return ret; - /* parse the device node */ ret = weim_parse_dt(pdev); - if (ret) - clk_disable_unprepare(clk); - else + if (!ret) dev_info(&pdev->dev, "Driver registered.\n"); return ret;