From patchwork Wed Aug 30 21:06:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 13370727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92744C83F01 for ; Wed, 30 Aug 2023 21:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=A/Etim2dRms7ZI/Gz9oDPXEiowdpHQCEmUc2GL67Dxo=; b=fKaG+/3Lhga3pU VnGhHWBbIsG4MSIq1MwfKFNfcZQigL/ru0CNMb3PfTp/BWqM0ziQ/S/ns6TA23mKg1OJV02LUnrIn rfzf/Gj4hC9caP3GpJ5+NnBptLAxIRg/scP4byS5F91mMU2RsibmxfeyW5HcZm/deXUS4FD6Y7TJ9 NGZ5tTpm8o8GzS49ELB/4hMsxCh6FFi93AnQnPLuEFNyjjRCpUyQ3Q8ll8mT3IIvfB9OY95w5bNHf 8It4gatpNpvBZqWeCxc8hJsCwwcOZctZyvLJ65D2+qp+fiy+mAVpUNZnagtnGuNNXr4C3WRzSg02Q 6kkfGxpn365r95kl+x2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbSOY-00EAnV-0z; Wed, 30 Aug 2023 21:06:34 +0000 Received: from smtp-25.smtpout.orange.fr ([80.12.242.25] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbSOV-00EAmQ-0E for linux-arm-kernel@lists.infradead.org; Wed, 30 Aug 2023 21:06:33 +0000 Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id bSOGqx2PaDlJebSOGqE9lA; Wed, 30 Aug 2023 23:06:20 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1693429580; bh=RzybfU0boxWYJNuGa1CY2Ynec75IhyC3G31hAEGouPc=; h=From:To:Cc:Subject:Date; b=mPrO5hn5GG5LU77t1k7/5WO5l+CvjJ29N7m9UBTflaCTVNouFpmoUL4y4lf3E3h8m ovmhshCs/5nFfv+13c172HABJvt+Mycl8lymXklGe4kDwQZbwx7GhsuNVENRtPpJCi s+UjqoGzWyHK+pAqfhfhP/VMgN0NZDYoMZEGUaZ+pi0N25nLmnsi+JLOVY1A5Uyiy+ Loj8GV28MUlbOiOJ55JPXeS0v/lrF/NC83cg82rQbBA92VoZYCfwrBVL+xBpstl8/t NSC1RCgTCI2l66yzce+gpfX+5v/nGoRQqZl9rfjnrHHjdAqd0AR2WYxTPo2UBp5wpt oz9s9SiN9iAvA== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Wed, 30 Aug 2023 23:06:20 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sakari Ailus Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] media: imx-mipi-csis: Remove an incorrect fwnode_handle_put() call Date: Wed, 30 Aug 2023 23:06:14 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230830_140631_268476_28CD0D96 X-CRM114-Status: UNSURE ( 9.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The commit in Fixes has removed an fwnode_graph_get_endpoint_by_id() call in mipi_csis_subdev_init(). So the reference that was taken should not be released anymore in the error handling path of the probe and in the remove function. Remove the now incorrect fwnode_handle_put() calls. Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching") Signed-off-by: Christophe JAILLET Reviewed-by: Laurent Pinchart Reviewed-by: Rui Miguel Silva --- drivers/media/platform/nxp/imx-mipi-csis.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c index 16f19a640130..5f93712bf485 100644 --- a/drivers/media/platform/nxp/imx-mipi-csis.c +++ b/drivers/media/platform/nxp/imx-mipi-csis.c @@ -1490,7 +1490,6 @@ static int mipi_csis_probe(struct platform_device *pdev) v4l2_async_unregister_subdev(&csis->sd); err_disable_clock: mipi_csis_clk_disable(csis); - fwnode_handle_put(csis->sd.fwnode); return ret; } @@ -1510,7 +1509,6 @@ static void mipi_csis_remove(struct platform_device *pdev) mipi_csis_clk_disable(csis); v4l2_subdev_cleanup(&csis->sd); media_entity_cleanup(&csis->sd.entity); - fwnode_handle_put(csis->sd.fwnode); pm_runtime_set_suspended(&pdev->dev); }