From patchwork Fri Sep 8 20:48:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 13377814 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE15EEB571 for ; Fri, 8 Sep 2023 20:49:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237169AbjIHUty (ORCPT ); Fri, 8 Sep 2023 16:49:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235767AbjIHUty (ORCPT ); Fri, 8 Sep 2023 16:49:54 -0400 Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7846C9C; Fri, 8 Sep 2023 13:49:50 -0700 (PDT) Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-34cc8e8cbd4so9094155ab.0; Fri, 08 Sep 2023 13:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694206189; x=1694810989; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hVhxpYw0R4qI6Tx1wydw+Ej+AzCHYQtaynaL7MCVjsw=; b=C32bYFfillHMh78+0FLWiRskWUd5kjK7euw5w0NL4LoWh8uEV4SmIlNb6Yk4u9i79l 3rF9NS1a6FM7zkvkaBq9TCubqrgzcxtFNzgXwoJz/bHD9lp2jPBpMH8uL0ewoKLtv9ve At719UdBriyxoA55v0p5w2z7r4+B6u6oc6s127P9a6yjUridOlnd9w9OdroBwW/eCYAU d3jFCidEBq/bZ7NG0AjnSwojeE/VsHuZHyAYhEHQ3RS9LmzCtTZpjKeP+o/7l9IdCTxq 3QS+qf6aH8DOM4eTP15wrwe95EFtRvGNLPrZQvq2oFulpX2xudskAU6VC71WkSrPGkOh 3tAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694206189; x=1694810989; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hVhxpYw0R4qI6Tx1wydw+Ej+AzCHYQtaynaL7MCVjsw=; b=SaDI8srUM9Y82H+3+CjvxMCcpCg2Z6prhaBbgLK7ZKlXJ7QrMfRm9bgqlHXfAlzV5A Nz+eefp2LXJhhLFBydrwf+cHBIFAAMrA5dGO4EdMRrQIpGpzeXzklM9yINh5bcmX/wyd 6WVoMKGaN00NBPRtmaQJMpp5SRxzqBB0RrLNS3QhtRSr8EArh/pckaer1veCucQ/DrEF m/KibjA6tElEwqJP51qnvdkITs2J5cxz5EnT2ttD/qguJrHW2tKiHxLTyCZHYRQG74+p UhDfRwnELs3Y5wFUXX42LnY2FFw4VfW3YoBIrwEH5leyb1FiefJYwwE2bFj8QXKlIkW7 E7Wg== X-Gm-Message-State: AOJu0YyfZLG4uqvPITqXTjjxyylxVSXPrXLEiPgzumAxETQkM3qJizPv 73urNpDFsLxhYxa8Gr/swi3rbddxaZw= X-Google-Smtp-Source: AGHT+IGco3Pwuo+A++2EIBmDQSEz1vek9i74d02ScqZ0gXe4/EB196BeSxR8vlWHu28bTSR9LjnybQ== X-Received: by 2002:a05:6e02:1001:b0:349:8fb5:87c4 with SMTP id n1-20020a056e02100100b003498fb587c4mr4053181ilj.14.1694206188995; Fri, 08 Sep 2023 13:49:48 -0700 (PDT) Received: from aford-B741.lan ([2601:447:d001:897f:1e20:b059:adc7:9ca8]) by smtp.gmail.com with ESMTPSA id h6-20020a92c086000000b0034ca3b29c5asm711393ile.57.2023.09.08.13.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Sep 2023 13:49:48 -0700 (PDT) From: Adam Ford To: linux-omap@vger.kernel.org Cc: aford@beaconembedded.com, Adam Ford , =?utf-8?q?Beno?= =?utf-8?q?=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Derald D. Woods" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 1/2] arm:dts: am3517-evm: Fix LED3/4 pinmux Date: Fri, 8 Sep 2023 15:48:27 -0500 Message-Id: <20230908204828.5242-1-aford173@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The pinmux for LED3 and LED4 are incorrectly attached to the omap3_pmx_core when they should be connected to the omap3_pmx_wkup pin mux. This was likely masked by the fact that the bootloader used to do all the pinmuxing. Fixes: 0dbf99542caf ("ARM: dts: am3517-evm: Add User LEDs and Pushbutton") Signed-off-by: Adam Ford --- V2: Use current device tree naming convention for led-pins This likely will require a separate patch to apply to previous file location. diff --git a/arch/arm/boot/dts/ti/omap/am3517-evm.dts b/arch/arm/boot/dts/ti/omap/am3517-evm.dts index af9df15274be..866f68c5b504 100644 --- a/arch/arm/boot/dts/ti/omap/am3517-evm.dts +++ b/arch/arm/boot/dts/ti/omap/am3517-evm.dts @@ -271,13 +271,6 @@ OMAP3_CORE1_IOPAD(0x21c4, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c3_sda */ >; }; - leds_pins: leds-pins { - pinctrl-single,pins = < - OMAP3_WKUP_IOPAD(0x2a24, PIN_OUTPUT_PULLUP | MUX_MODE4) /* jtag_emu0.gpio_11 */ - OMAP3_WKUP_IOPAD(0x2a26, PIN_OUTPUT_PULLUP | MUX_MODE4) /* jtag_emu1.gpio_31 */ - >; - }; - mmc1_pins: mmc1-pins { pinctrl-single,pins = < OMAP3_CORE1_IOPAD(0x2144, PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc1_clk.sdmmc1_clk */ @@ -355,3 +348,12 @@ OMAP3430_CORE2_IOPAD(0x25e2, PIN_INPUT | MUX_MODE3) /* etk_d3.hsusb1_data7 */ >; }; }; + +&omap3_pmx_wkup { + leds_pins: leds-pins { + pinctrl-single,pins = < + OMAP3_WKUP_IOPAD(0x2a24, PIN_OUTPUT_PULLUP | MUX_MODE4) /* jtag_emu0.gpio_11 */ + OMAP3_WKUP_IOPAD(0x2a26, PIN_OUTPUT_PULLUP | MUX_MODE4) /* jtag_emu1.gpio_31 */ + >; + }; +}; From patchwork Fri Sep 8 20:48:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 13377815 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64BC1EEB574 for ; Fri, 8 Sep 2023 20:49:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240335AbjIHUt4 (ORCPT ); Fri, 8 Sep 2023 16:49:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235767AbjIHUtz (ORCPT ); Fri, 8 Sep 2023 16:49:55 -0400 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C88A9C; Fri, 8 Sep 2023 13:49:51 -0700 (PDT) Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-34ca860051fso8611745ab.2; Fri, 08 Sep 2023 13:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694206190; x=1694810990; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RwUmP0oAaa2Uc/U4TiMNgqrynwkK7R5pG2+a4FTbZ9M=; b=pVWhb5objXx9tWWMHxNYKOwGFm5PH7Ge04a0y74zG/fbo2qJdbwhQUx1lirMk6P6SJ 9SW2xCd6JP1ptpMWvopkNBRRMHzAvzFtF3wf9dvmZeT9JBMU2Ay2xBUw9//l+uLBI/vn sUPxSjB2MADHmsDe8vGKPUfhcVpViHrMaOndCbchmCoQjWSqHnzWewe7pPm86fhu6x0A YFbWsxPYFRifWjfBQ144ICjPR66cyPltT5GUMdNLsP0Kk0uIEx9AtVAXDyHKdoyCVFui Vt7kPBBSaEzOc6u60lcjXZgW4ZfysIKvGEDcHn2CHbLFJlQOjY8HvFzQlw3TGV3ltxEs 0dTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694206190; x=1694810990; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RwUmP0oAaa2Uc/U4TiMNgqrynwkK7R5pG2+a4FTbZ9M=; b=IhZWPlJT6PUZBewbKegSVAwVWh6mmpYKWNWRjYEH2OPjVw9YGZ+nMRnjhAks8Nw4tT ujvusd69GNuZEOyymmQNr2e924GC0AKGTosDlbGkLCP8lwy2EgHiN/l+R5eYn9O+MaSD nQa3R3HceRYg12Igk3ph8VmjvyNVPg72+2/mSBuGJvFGXqqRU89q7KMUknwIqKFHGtd8 CRFCxujMkGrgKnkh//bI+UbnOt8+fyI8syeWzWxIvEpwBJx+lmGIcx4Hm1tRaT4Xzvqm 74MPTMo3v23K98+Iz+se1lEdrDgZWGcu+8i4iGELD3KCUu+o8F/Y+xK6CXIgXFi3SXsD DPDA== X-Gm-Message-State: AOJu0YyPFNQpsXbuahn5b/p4tYrQhEszVjD8f82Uq7SOi9ouIym1GlNk p+Hz4gBh4PEmBy3ivsbKL7QnFCmRdV4= X-Google-Smtp-Source: AGHT+IEeZjejwIdvy7mNdYAxCvPPYMCsNJMhXLQrkJBmTXX4eWuUmmmqKm1WBgHKmv1DUt0hQLbyRA== X-Received: by 2002:a92:cd52:0:b0:34d:f0b9:97f7 with SMTP id v18-20020a92cd52000000b0034df0b997f7mr3636224ilq.25.1694206190399; Fri, 08 Sep 2023 13:49:50 -0700 (PDT) Received: from aford-B741.lan ([2601:447:d001:897f:1e20:b059:adc7:9ca8]) by smtp.gmail.com with ESMTPSA id h6-20020a92c086000000b0034ca3b29c5asm711393ile.57.2023.09.08.13.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Sep 2023 13:49:50 -0700 (PDT) From: Adam Ford To: linux-omap@vger.kernel.org Cc: aford@beaconembedded.com, Adam Ford , =?utf-8?q?Beno?= =?utf-8?q?=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Derald D. Woods" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 2/2] arm: dts: am3517-evm: Enable Ethernet PHY Interrupt Date: Fri, 8 Sep 2023 15:48:28 -0500 Message-Id: <20230908204828.5242-2-aford173@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230908204828.5242-1-aford173@gmail.com> References: <20230908204828.5242-1-aford173@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The Ethernet PHY interrupt pin is routed to GPIO_58. Create a PHY node to configure this GPIO for the interrupt to avoid polling. Signed-off-by: Adam Ford --- V2: Use current device tree naming convention for led-pins diff --git a/arch/arm/boot/dts/ti/omap/am3517-evm.dts b/arch/arm/boot/dts/ti/omap/am3517-evm.dts index 866f68c5b504..8a3d850a4f0d 100644 --- a/arch/arm/boot/dts/ti/omap/am3517-evm.dts +++ b/arch/arm/boot/dts/ti/omap/am3517-evm.dts @@ -172,11 +172,24 @@ hsusb1_phy: hsusb1_phy { &davinci_emac { pinctrl-names = "default"; pinctrl-0 = <ðernet_pins>; + phy-mode = "rmii"; + phy-handle = <ðphy0>; status = "okay"; }; &davinci_mdio { + #address-cells = <1>; + #size-cells = <0>; status = "okay"; + + ethphy0: ethernet-phy@0 { + pinctrl-names = "default"; + pinctrl-0 = <&enet_phy_pins>; + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0>; + interrupt-parent = <&gpio2>; + interrupts = <26 IRQ_TYPE_LEVEL_LOW>; /* gpio_58 */ + }; }; &dss { @@ -257,6 +270,12 @@ OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50mhz_clk */ >; }; + enet_phy_pins: pinmux_ent_phy_pins { + pinctrl-single,pins = < + OMAP3_CORE1_IOPAD(0x20bc, PIN_INPUT | MUX_MODE4) /* gpmc_ncs7.gpio_57 */ + >; + }; + i2c2_pins: i2c2-pins { pinctrl-single,pins = < OMAP3_CORE1_IOPAD(0x21be, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c2_scl */