From patchwork Tue Sep 12 08:26:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 13381041 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68879CA0ECA for ; Tue, 12 Sep 2023 08:26:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0157A6B00CF; Tue, 12 Sep 2023 04:26:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE0736B00D0; Tue, 12 Sep 2023 04:26:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D83056B00D1; Tue, 12 Sep 2023 04:26:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C66ED6B00CF for ; Tue, 12 Sep 2023 04:26:56 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9B4031CA942 for ; Tue, 12 Sep 2023 08:26:56 +0000 (UTC) X-FDA: 81227264832.12.F180524 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf30.hostedemail.com (Postfix) with ESMTP id C43D180009 for ; Tue, 12 Sep 2023 08:26:54 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=GVtHDHXJ; dmarc=none; spf=none (imf30.hostedemail.com: domain of brgl@bgdev.pl has no SPF policy when checking 209.85.128.52) smtp.mailfrom=brgl@bgdev.pl ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694507215; a=rsa-sha256; cv=none; b=ST4XCwXIl0e7GCBiOW+74w9WkhFYKQY+h2KOtoNrKCVt5aNaBviggE6YzSekAQMaA2AFGm fUR2GG922wBQBkPwOoB63Yivr5JtZ8/ky40qzDCowfAH+I4XVlOyVT5nh0Gia1/ea2vSHY mYK9MajM7+z85calbosXna1BX+LwB9s= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=GVtHDHXJ; dmarc=none; spf=none (imf30.hostedemail.com: domain of brgl@bgdev.pl has no SPF policy when checking 209.85.128.52) smtp.mailfrom=brgl@bgdev.pl ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694507215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=R5ZWDB1FqFuWIcPP5uo4y/kiHrFaFSG3Le/UDhdwTss=; b=JeL1uU/t2Jq4TrBTVNqtUnWqPHC3e9aqIqW/H/R6J0+ocR6a0iSrlth1wnWug/h1f3IvYm +xdFYwYkTiGouMyXkvxtZ5UWFVhkHTlfLcn71lla2+DPk15JqM/FSqfU7+pjbcyAmpcKI+ 94t23QTnay3XiqicmPw6sIK7vWN8aNU= Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-403061cdf2bso27531495e9.2 for ; Tue, 12 Sep 2023 01:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1694507213; x=1695112013; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R5ZWDB1FqFuWIcPP5uo4y/kiHrFaFSG3Le/UDhdwTss=; b=GVtHDHXJ3VhQ+PNyqwrMDYsPHtalmgDi0h5mkmb9IQ5DW9X37SgSXM9Zy5GKaQME+k 6i6QZzwqFpQTP9/b4mvl4ZO6mCQvcLPD0IhO6kbQXWlVa1DSnZP+t51/YBFp+TH7wp2g rbcDi4ve6kVW6MfHMhkl1u7/YpnVFPUKeMa41fg9Kt394hI/SaBqn+pSLL9WMqpdsuSX sZp/ZJxzvjQPojQDjWE6gRac7+CG9qWtqf3mxlSjhMsRMkXFEw2qDhU30119kqU1Mk5v /K17cUT4Yd2BjFHqB+U+GK7rxuW2W+4BrbmJzau1iFT2aa6tp9csqffUIt8RJ2jq5+oz LYAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694507213; x=1695112013; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R5ZWDB1FqFuWIcPP5uo4y/kiHrFaFSG3Le/UDhdwTss=; b=VJRscgk49URbLS5D7M1U+oogQkC8GZF8PVz9qFBVQFbKOV41LR61yCMeoOO1cp7+X3 tdWhhjoBGLA66zFYHm6vGp3Ih3T318cRQIjDn6Jc6eQDQVDriNS3AZR9aQc9wqBUzazb PNj2tzySfihpKd8Mqf2maVu4rCP8+Qa7DS85d0nBy5WLhWrYb2PWyLe1Ua52lXoEP/bh fSFPFHhVVvGCKFlYZkW6HnvBXHUc8e1+vg7U/gtSJbrC7C0BU0M0h+ZNhbVYFq5a49Vk gUdu3EGSSb/3P/M+bvfgNdxuUPaliM5hjUZmANPn6usPATVeZGHV02P9dULxkXjW1Zvv 1Kng== X-Gm-Message-State: AOJu0Yx3BzsRmVh/scq1X9OEerDF/KeqiBALiuJRTdn7YS7uluYG+ZlY 54RtliunnFUpNZ+AGqUsKqm0hA== X-Google-Smtp-Source: AGHT+IHBmdgDBl+nMxBfNCjmsLnlBByQvmI+Z+e3WcXEE5tS6wvEsHVVK0U8DjiYci0H1J7C3kZWUQ== X-Received: by 2002:a05:600c:3b9a:b0:402:f5c4:2e5a with SMTP id n26-20020a05600c3b9a00b00402f5c42e5amr11179870wms.37.1694507212943; Tue, 12 Sep 2023 01:26:52 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:907f:4cd7:f0ae:6b2a]) by smtp.gmail.com with ESMTPSA id e10-20020adf9bca000000b003143cb109d5sm9793110wrc.14.2023.09.12.01.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 01:26:52 -0700 (PDT) From: Bartosz Golaszewski To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Peter Zijlstra Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] slab: drop unneeded NULL-pointer check in kfree auto cleanup Date: Tue, 12 Sep 2023 10:26:43 +0200 Message-Id: <20230912082643.13144-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C43D180009 X-Stat-Signature: 36pf1u6iegpn5tk9rnmswzise4u1gi7m X-HE-Tag: 1694507214-558672 X-HE-Meta: U2FsdGVkX1+vpgI6UkMylMYOAisuhhuVCuvRP8nrzP/gnDPwz8d8PPKv4bRw1eHOfG3LHDFl3S+yeEeojGrtmS/H6fmWuPVRQz/mOe3mOcl3HIvYSPCyz0hbr1/RHsnExDm46dsjV9KGgTQOxGl172FXL28uTTaZw5ILPOQ58osyBrJpw9uaOGLm7seNDzST/I7t9/DL9aA+RWyMB9V5T9U19skVP42De0itEBX0TTT5e1g+tjapHADIR0pPMT2szlshV7Dz2lsCVV8Hyxoc73sx17XPtnGoQckcezj99hOHJg2gvnZY7LpsazIrT8LGgW9WPv0W/17sNte4j2F29DkE/xWlCj6SIrf9gQked7i7/MJuCbHP2iiZ5WkN3c7Lt3rlXm+K3toPJ9lGalKPjrlPEBlukE6lvRdyxX5GxFdAbjtRmshnBiuy0CScXkwBdzbMh6OHJJWwVeMPkKfPA2XceFzT1sLLtyKT4/Zjgfje976KpcYkLyRyUsMrm6fi9CYAlLO1PrnpQg+XX5crqzMJ9BCdo7EI3RxBGn2b1xAV/co+uF165MWk24rt0kiAEC8pZ7wMMAicVgap2TvvSWTAjEbzMcvDCewf+8frA2KsPsUL+ewjCj1twppJoS7FKuKArUGBMLjBxEHv6UVoYCPSprVdOPEH/zjAF9eChqcIfCrLbE4Epa9J57cuPJvUAMbzqo1wdQA5IEUR0IYiD1jkH60/VX/FwIuI/x81yd3gmAI/8zu7l30qbzV9zrBOEgs3Hc9XuGumQGdaEf2/2T4jZReAVHTSGYUgnKXJMpxFMEylHP39/wAjTBULLU8fJB3RLjO901ZoEecPQ0jg7gc0dotIz2YyVksBPGODZs/Bb3vVflOJTi8E1IMXnr5iyTVvAJAXPhhki2lm2q0GpwstomaEsGGGUlJtm+x21caiu81dpdyI5+GY3uZRXMLTXhYO8/bq1m2AWySCIHq 9PBtQIKr jLFSIdITvKspeTWGNvpL9Vjksy+nFucCo2yU76cYdrX/+YZVIVz/Xc4uHN9M5nEEFgYXwl1EKmYCW8416QlQ8ldpQ8jYnwENTf+I2mouBRyL/HR1SSm2E9vu91trwDRkuoQ71azEvUyUFBQDBpD7QyGXZi8C/hyPn8QId92dSHJthHFAedirVF1G1bwp/rf7XQOA1VHCpaMUQNKFv6qrNKjtLJ7vXhE2iJK4yf7r4fNupa/JxUJuO3EtTJgFfxWFxVkhGIcWfSfX/VUlCj/swlVReR99U6E3oLr9OS5KrKieG0wop+yks1LjGLeaK6/+CZMajOVXADkUHXhXiPh0p24ZHmFt+1VF+8MjqQ4+rKNC5+AHSDexFDsWJiltRDztr6xd2k5/H71tgAm62UFPVxLlnhs+cGc/9TLGAavFWAUgSOIbe+K0i2woK22OivCekUzvEx2vI+HiKSgoNQT8cVhLGnCB4lym+yy3WyluMQBZQC/0ghRmHLaluwW/inEsLb2bkfUaRTGEGmW8BH84rdfmiBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bartosz Golaszewski kfree() already accepts and silently ignores NULL-pointers, there's no need to check it when running the auto cleanup routine. Signed-off-by: Bartosz Golaszewski --- include/linux/slab.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/slab.h b/include/linux/slab.h index 8228d1276a2f..fb709ed506ba 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -228,7 +228,7 @@ void kfree(const void *objp); void kfree_sensitive(const void *objp); size_t __ksize(const void *objp); -DEFINE_FREE(kfree, void *, if (_T) kfree(_T)) +DEFINE_FREE(kfree, void *, kfree(_T)) /** * ksize - Report actual allocation size of associated object