From patchwork Mon Feb 11 15:09:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10806063 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AB5541575 for ; Mon, 11 Feb 2019 15:09:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B85E2A99F for ; Mon, 11 Feb 2019 15:09:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8CC2F2A9A2; Mon, 11 Feb 2019 15:09:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,UPPERCASE_50_75 autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 340C42A9A9 for ; Mon, 11 Feb 2019 15:09:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403799AbfBKPJ4 (ORCPT ); Mon, 11 Feb 2019 10:09:56 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43054 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391733AbfBKPJy (ORCPT ); Mon, 11 Feb 2019 10:09:54 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 76B07608C6; Mon, 11 Feb 2019 15:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897793; bh=NOfeJC8Q3GgkEVMREeb0m1P7I26EZcJ28D1CYATd2Ng=; h=From:To:Cc:Subject:Date:From; b=a6RVXdopmmKCBffNzfGT0uwVNJTOdHxCA1Xzt/0Hwl0ZAmK9pdhr3f7TL1e2uWLmo Q3BkTLbnGdbvi0MPYewvTkgbdsVPjaff2glRW8UbK5En2DbYTdGXoHCcHeu1spKnf+ MKZzANCXlMnOX4c61fp8ZJ+vR72LSP4TpKspsV2c= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C7E3860C8E; Mon, 11 Feb 2019 15:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897792; bh=NOfeJC8Q3GgkEVMREeb0m1P7I26EZcJ28D1CYATd2Ng=; h=From:To:Cc:Subject:Date:From; b=Ds7tejanJ4TwjqfNqQMsIXn4U2TM22aYPZFhPW/nXy3pPb662N12Fyp5RtqnaRwDa kTlXqfxnNCI8xVmc3QjG3uuGMtmF93sn3yi0Iog20YUxP32wO3jg9n5xf30f9ZtHke uEHiy1UFjZSYt+IsZZW52bAfUq/YzbQ9R8IZGbl0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C7E3860C8E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [PATCH 1/6] ath10k: add missing values to wmi_service_name() Date: Mon, 11 Feb 2019 17:09:42 +0200 Message-Id: <1549897787-28537-1-git-send-email-kvalo@codeaurora.org> X-Mailer: git-send-email 2.7.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After implementing the next patch GCC reported: drivers/net/wireless/ath/ath10k/wmi.h:385:2: warning: enumeration value 'WMI_SERVICE_BTCOEX' not handled in switch [-Wswitch] drivers/net/wireless/ath/ath10k/wmi.h:385:2: warning: enumeration value 'WMI_SERVICE_MGMT_TX_WMI' not handled in switch [-Wswitch] drivers/net/wireless/ath/ath10k/wmi.h:385:2: warning: enumeration value 'WMI_SERVICE_SPOOF_MAC_SUPPORT' not handled in switch [-Wswitch] drivers/net/wireless/ath/ath10k/wmi.h:385:2: warning: enumeration value 'WMI_SERVICE_VDEV_DISABLE_4_ADDR_SRC_LRN_SUPPORT' not handled in switch [-Wswitch] drivers/net/wireless/ath/ath10k/wmi.h:385:2: warning: enumeration value 'WMI_SERVICE_BB_TIMING_CONFIG_SUPPORT' not handled in switch [-Wswitch] drivers/net/wireless/ath/ath10k/wmi.h:385:2: warning: enumeration value 'WMI_SERVICE_THERM_THROT' not handled in switch [-Wswitch] Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/wmi.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index b10ed523b99e..529f5a26f3f3 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.h +++ b/drivers/net/wireless/ath/ath10k/wmi.h @@ -475,6 +475,7 @@ static inline char *wmi_service_name(int service_id) SVCSTR(WMI_SERVICE_TX_MODE_PUSH_PULL); SVCSTR(WMI_SERVICE_TX_MODE_DYNAMIC); SVCSTR(WMI_SERVICE_VDEV_RX_FILTER); + SVCSTR(WMI_SERVICE_BTCOEX); SVCSTR(WMI_SERVICE_CHECK_CAL_VERSION); SVCSTR(WMI_SERVICE_DBGLOG_WARN2); SVCSTR(WMI_SERVICE_BTCOEX_DUTY_CYCLE); @@ -484,13 +485,18 @@ static inline char *wmi_service_name(int service_id) SVCSTR(WMI_SERVICE_SMART_LOGGING_SUPPORT); SVCSTR(WMI_SERVICE_TDLS_CONN_TRACKER_IN_HOST_MODE); SVCSTR(WMI_SERVICE_TDLS_EXPLICIT_MODE_ONLY); + SVCSTR(WMI_SERVICE_MGMT_TX_WMI); SVCSTR(WMI_SERVICE_TDLS_WIDER_BANDWIDTH); SVCSTR(WMI_SERVICE_HTT_MGMT_TX_COMP_VALID_FLAGS); SVCSTR(WMI_SERVICE_HOST_DFS_CHECK_SUPPORT); SVCSTR(WMI_SERVICE_TPC_STATS_FINAL); SVCSTR(WMI_SERVICE_RESET_CHIP); + SVCSTR(WMI_SERVICE_SPOOF_MAC_SUPPORT); SVCSTR(WMI_SERVICE_TX_DATA_ACK_RSSI); SVCSTR(WMI_SERVICE_VDEV_DIFFERENT_BEACON_INTERVAL_SUPPORT); + SVCSTR(WMI_SERVICE_VDEV_DISABLE_4_ADDR_SRC_LRN_SUPPORT); + SVCSTR(WMI_SERVICE_BB_TIMING_CONFIG_SUPPORT); + SVCSTR(WMI_SERVICE_THERM_THROT); SVCSTR(WMI_SERVICE_RTT_RESPONDER_ROLE); SVCSTR(WMI_SERVICE_PER_PACKET_SW_ENCRYPT); SVCSTR(WMI_SERVICE_REPORT_AIRTIME); From patchwork Mon Feb 11 15:09:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10806083 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B663217E0 for ; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A50D12A9AB for ; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 99DC62A9B8; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 482192A9BA for ; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403918AbfBKPJ7 (ORCPT ); Mon, 11 Feb 2019 10:09:59 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43086 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391736AbfBKPJz (ORCPT ); Mon, 11 Feb 2019 10:09:55 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E25D061981; Mon, 11 Feb 2019 15:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897795; bh=1c38RoAYFWuQaP3caHB3h5toGYUf1hiPzrjOP3sdvcI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EVxLyZ/i3mPH/B1ed8MJJ5/ad29qB+blHZEWT/mD7CnH8jwJglYmqrSwBfoR47l1r gH2dhIozRBcsnlSTTgeF5p7Jb8Q6jDJ677K6X4qVMk2/CsNEMFbc8sfW/JEbSto9SU C3XmkS4IPTPwLZF/AZUXXWeVKHEx1MJIgl+XmUMQ= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 54CC86191A; Mon, 11 Feb 2019 15:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897794; bh=1c38RoAYFWuQaP3caHB3h5toGYUf1hiPzrjOP3sdvcI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F4iG+mMNW/0EXpi+VqwEezJgwJD5JGEA6KLDCQ51Gol65peojpuEgoQcCjZL0tsXS QmSrCRJ/riteYNo+ekNx1s1yw/9SUWJJKJgGsvul5D9i2InzqH+nPGCIJ7BURh3Mj3 U35NWFMuWph2IOnd9WrysbwXLo7D1vagmGgxL1iQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 54CC86191A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [PATCH 2/6] ath10k: make wmi_service_name() warn about missing service ids Date: Mon, 11 Feb 2019 17:09:43 +0200 Message-Id: <1549897787-28537-2-git-send-email-kvalo@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1549897787-28537-1-git-send-email-kvalo@codeaurora.org> References: <1549897787-28537-1-git-send-email-kvalo@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When adding a new value to enum wmi_service it's very easy to miss that the new value should be also added to wmi_service_name() mapping function. Modify the function so that GCC can now warn about this: drivers/net/wireless/ath/ath10k/wmi.h:385:2: warning: enumeration value 'WMI_SERVICE_FOO' not handled in switch [-Wswitch] And also add a reminder to the enum. Thanks to Jouni Malinen for the idea. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/wmi.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index 529f5a26f3f3..74ce1a4c0e8f 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.h +++ b/drivers/net/wireless/ath/ath10k/wmi.h @@ -212,6 +212,8 @@ enum wmi_service { WMI_SERVICE_PER_PACKET_SW_ENCRYPT, WMI_SERVICE_REPORT_AIRTIME, + /* Remember to add the new value to wmi_service_name()! */ + /* keep last */ WMI_SERVICE_MAX, }; @@ -378,7 +380,7 @@ enum wmi_10_4_service { WMI_10_4_SERVICE_REPORT_AIRTIME, }; -static inline char *wmi_service_name(int service_id) +static inline char *wmi_service_name(enum wmi_service service_id) { #define SVCSTR(x) case x: return #x @@ -501,11 +503,13 @@ static inline char *wmi_service_name(int service_id) SVCSTR(WMI_SERVICE_PER_PACKET_SW_ENCRYPT); SVCSTR(WMI_SERVICE_REPORT_AIRTIME); - default: + case WMI_SERVICE_MAX: return NULL; } #undef SVCSTR + + return NULL; } #define WMI_SERVICE_IS_ENABLED(wmi_svc_bmap, svc_id, len) \ From patchwork Mon Feb 11 15:09:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10806085 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D6891188E for ; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5D732A9AB for ; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BA0D82A9BA; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 683AE2AA6D for ; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403912AbfBKPJ7 (ORCPT ); Mon, 11 Feb 2019 10:09:59 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43136 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403802AbfBKPJ5 (ORCPT ); Mon, 11 Feb 2019 10:09:57 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AC05A618E2; Mon, 11 Feb 2019 15:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897796; bh=DxSPw5Ltq7ijmgi6nY3/Z8HDO8TMd5USROHJvM8lWO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LR8EZ+cCUVYb2+9wqJAYsJZJItFAstnvC+b/oxtqnPiDtyVYeLnKouw80dMDzzaMn ItONUqVK9X+rE42TIz1yXeopeTCOLrQa5WVthrgLkQtAgBnae7paoFbDsnlWlvgCpW HEWSktR+3WfkZQJPZECzuehz+HkyWAFHoTGtBODM= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id BA8C1618E2; Mon, 11 Feb 2019 15:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897795; bh=DxSPw5Ltq7ijmgi6nY3/Z8HDO8TMd5USROHJvM8lWO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YlzktFibHMVE8/tTvw83GC4qDafG5m72pler4aTjNVlSR0zdonctkJ7cIhGhnpL8P kDyfv0R/zHKmzofq+vNjcisyHw6JuTZTedNQHo/da7gHKKswyreiADf8ahPfxz4fS/ 1ZfpbUiEGJFUWyPGrl6Up2mwQvCxWR6CHOLMGA3k= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BA8C1618E2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [PATCH 3/6] ath10k: change wmi.h to include only ieee80211.h Date: Mon, 11 Feb 2019 17:09:44 +0200 Message-Id: <1549897787-28537-3-git-send-email-kvalo@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1549897787-28537-1-git-send-email-kvalo@codeaurora.org> References: <1549897787-28537-1-git-send-email-kvalo@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP wmi.h does not use anything from mac80211.h so change it to include only ieee80211.h. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/wmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index 74ce1a4c0e8f..23fe482834b4 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.h +++ b/drivers/net/wireless/ath/ath10k/wmi.h @@ -20,7 +20,7 @@ #define _WMI_H_ #include -#include +#include /* * This file specifies the WMI interface for the Unified Software From patchwork Mon Feb 11 15:09:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10806081 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 938E013A4 for ; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8264E2A9B8 for ; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 774F12A9AB; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 27F052A9B8 for ; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403925AbfBKPKA (ORCPT ); Mon, 11 Feb 2019 10:10:00 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43178 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403911AbfBKPJ7 (ORCPT ); Mon, 11 Feb 2019 10:09:59 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 77BCC619E3; Mon, 11 Feb 2019 15:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897798; bh=MZEcwysdfdD/1wpOHcY3EIBmucsz7ud7wY2EzfG1424=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gtv0/VYcTPWkJCZsJFyXJEiKRGuncP7G8y9UAaddzLxDwPSvWSiNKiPWNt2T9eBwb Bxg30jor0XSDxwhkR+5mCytGRDrnrbGcVvgi4wqjfodLkRoxaU7KTKOzaDfIA7jQA5 qA1xc1PwMH3AapDL9vvnSGzpT/xLkxE2PnwYb2jc= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 792696198C; Mon, 11 Feb 2019 15:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897797; bh=MZEcwysdfdD/1wpOHcY3EIBmucsz7ud7wY2EzfG1424=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SLYCQ7ETpttouTmUnJv6pvfujY92qS5/m1wA0lOi5lKBNbA3jVRpeszYKdYz/ZVYj 4QPZSogaks3CRNjBUN4KSQJ88V04WKurn9sknbOGG6mC9pvKaKCWLhILd9WCYs0Vcq /0hvMOBhArwlimGgopbAK+p0THEIUyYV2KXistzY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 792696198C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [PATCH 4/6] ath10k: align ath10k_htt_txbuf structures Date: Mon, 11 Feb 2019 17:09:45 +0200 Message-Id: <1549897787-28537-4-git-send-email-kvalo@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1549897787-28537-1-git-send-email-kvalo@codeaurora.org> References: <1549897787-28537-1-git-send-email-kvalo@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP With W=1 GCC warns: drivers/net/wireless/ath/ath10k/htt.h:1746:1: warning: alignment 1 of 'struct ath10k_htt_txbuf_32' is less than 4 [-Wpacked-not-aligned] drivers/net/wireless/ath/ath10k/htt.h:1753:1: warning: alignment 1 of 'struct ath10k_htt_txbuf_64' is less than 4 [-Wpacked-not-aligned] Fix that by using __align(4). Compile tested only. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/htt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h index 005fad94edad..d194bbe18fc3 100644 --- a/drivers/net/wireless/ath/ath10k/htt.h +++ b/drivers/net/wireless/ath/ath10k/htt.h @@ -1743,14 +1743,14 @@ struct ath10k_htt_txbuf_32 { struct ath10k_htc_hdr htc_hdr; struct htt_cmd_hdr cmd_hdr; struct htt_data_tx_desc cmd_tx; -} __packed; +} __packed __aligned(4); struct ath10k_htt_txbuf_64 { struct htt_data_tx_desc_frag frags[2]; struct ath10k_htc_hdr htc_hdr; struct htt_cmd_hdr cmd_hdr; struct htt_data_tx_desc_64 cmd_tx; -} __packed; +} __packed __aligned(4); struct ath10k_htt { struct ath10k *ar; From patchwork Mon Feb 11 15:09:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10806067 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3AF5213A4 for ; Mon, 11 Feb 2019 15:10:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2ABD52A99F for ; Mon, 11 Feb 2019 15:10:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F03D2A9A9; Mon, 11 Feb 2019 15:10:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BBF372A99F for ; Mon, 11 Feb 2019 15:10:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403933AbfBKPKB (ORCPT ); Mon, 11 Feb 2019 10:10:01 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43220 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403922AbfBKPKA (ORCPT ); Mon, 11 Feb 2019 10:10:00 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E45E56191A; Mon, 11 Feb 2019 15:09:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897799; bh=rDSLenA25ynzc50KNH0/wVklbe2LQZhxsEtz3RTN0RQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I2hujBnlAEYHNHE3r6vVkHVvMm6wrrgA8rOQNvKVuEpHPp9ilK2yUaSS4kEQxytIl 8ZafJsHbeJLEZlDR/Cw6WgRpQ9rLpciPDLZicWaFymYWJMp1VcT5WjkyufFmqthIJx MWUmbKulIGkz8VU/Nek2joz2jhOoYTbI0kwkTFlw= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 35BC5619D7; Mon, 11 Feb 2019 15:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897799; bh=rDSLenA25ynzc50KNH0/wVklbe2LQZhxsEtz3RTN0RQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I2hujBnlAEYHNHE3r6vVkHVvMm6wrrgA8rOQNvKVuEpHPp9ilK2yUaSS4kEQxytIl 8ZafJsHbeJLEZlDR/Cw6WgRpQ9rLpciPDLZicWaFymYWJMp1VcT5WjkyufFmqthIJx MWUmbKulIGkz8VU/Nek2joz2jhOoYTbI0kwkTFlw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 35BC5619D7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [PATCH 5/6] ath10k: fix documentation in ath10k_wow_convert_8023_to_80211() Date: Mon, 11 Feb 2019 17:09:46 +0200 Message-Id: <1549897787-28537-5-git-send-email-kvalo@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1549897787-28537-1-git-send-email-kvalo@codeaurora.org> References: <1549897787-28537-1-git-send-email-kvalo@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP With W=1 there's a warning: drivers/net/wireless/ath/ath10k/wow.c:93: warning: Function parameter or member 'new' not described in 'ath10k_wow_convert_8023_to_80211' drivers/net/wireless/ath/ath10k/wow.c:93: warning: Function parameter or member 'old' not described in 'ath10k_wow_convert_8023_to_80211' Fix it by changing the documentation marker '/**' to a normal code comment. While at it, clean up the line wrapping. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/wow.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wow.c b/drivers/net/wireless/ath/ath10k/wow.c index 36d4245c308e..b36fa0f8892e 100644 --- a/drivers/net/wireless/ath/ath10k/wow.c +++ b/drivers/net/wireless/ath/ath10k/wow.c @@ -77,7 +77,7 @@ static int ath10k_wow_cleanup(struct ath10k *ar) return 0; } -/** +/* * Convert a 802.3 format to a 802.11 format. * +------------+-----------+--------+----------------+ * 802.3: |dest mac(6B)|src mac(6B)|type(2B)| body... | @@ -88,9 +88,8 @@ static int ath10k_wow_cleanup(struct ath10k *ar) * 802.11: |4B|dest mac(6B)| 6B |src mac(6B)| 8B |type(2B)| body... | * +--+------------+----+-----------+---------------+-----------+ */ -static void ath10k_wow_convert_8023_to_80211 - (struct cfg80211_pkt_pattern *new, - const struct cfg80211_pkt_pattern *old) +static void ath10k_wow_convert_8023_to_80211(struct cfg80211_pkt_pattern *new, + const struct cfg80211_pkt_pattern *old) { u8 hdr_8023_pattern[ETH_HLEN] = {}; u8 hdr_8023_bit_mask[ETH_HLEN] = {}; From patchwork Mon Feb 11 15:09:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10806079 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 743781575 for ; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 64A292A9AB for ; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5929D2AA28; Mon, 11 Feb 2019 15:12:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 06DC42A9AB for ; Mon, 11 Feb 2019 15:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403935AbfBKPKC (ORCPT ); Mon, 11 Feb 2019 10:10:02 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43242 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403932AbfBKPKB (ORCPT ); Mon, 11 Feb 2019 10:10:01 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 33922619D7; Mon, 11 Feb 2019 15:10:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897801; bh=5VXbjWri6vbZxqXQx6NTLrbB3AFtQpJll3z+Risvj1E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aFIK2guvunBgNVY7X8V/xSgdmykLXi09q07rfKegL7uASIGnOKXlEye5XB63vbhrk vk3hPeZDpRjlO7GNKclo6Z3U7W+YXBkt5wjKOs0gfjmstIUrr63fSChArtms9/xpap EnEIpLDc5GqBBwrz9suUrHyIlslBhqeih71/K7VY= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B683B619EB; Mon, 11 Feb 2019 15:09:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549897800; bh=5VXbjWri6vbZxqXQx6NTLrbB3AFtQpJll3z+Risvj1E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LsJdwas3e/HWY8Dv7+GsMEBb8a2a7iJD4HQ7cmob/KSUg6jaCtBkNgxdrjLzfia2p XJ80sw31Z4E7N+ko5ZLABrSr6FFzQNTcpm4A0tBHB9WWsg0CT5eagc8rhHbuyBY4wK nb8ZgLTvsPxf06AOPLQQNY1+kqthhUkE+ZOVKToY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B683B619EB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [PATCH 6/6] ath10k: copy the whole struct ath10k_bus_params in ath10k_core_register() Date: Mon, 11 Feb 2019 17:09:47 +0200 Message-Id: <1549897787-28537-6-git-send-email-kvalo@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1549897787-28537-1-git-send-email-kvalo@codeaurora.org> References: <1549897787-28537-1-git-send-email-kvalo@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Instead of copying fields one by one copy the whole structure. This way there's no need to modify the function every time we add a new field to the struct. Compile tested only. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 6c1dd5f8d012..a1b2aea4a77f 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -2997,9 +2997,8 @@ static void ath10k_core_register_work(struct work_struct *work) int ath10k_core_register(struct ath10k *ar, const struct ath10k_bus_params *bus_params) { - ar->bus_param.chip_id = bus_params->chip_id; - ar->bus_param.dev_type = bus_params->dev_type; - ar->bus_param.link_can_suspend = bus_params->link_can_suspend; + ar->bus_param = *bus_params; + queue_work(ar->workqueue, &ar->register_work); return 0;