From patchwork Mon Feb 11 19:30:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 10806721 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 297396C2 for ; Mon, 11 Feb 2019 19:30:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1AAE32B093 for ; Mon, 11 Feb 2019 19:30:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0BFE72B0A8; Mon, 11 Feb 2019 19:30:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA3E22B093 for ; Mon, 11 Feb 2019 19:30:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731515AbfBKTaf (ORCPT ); Mon, 11 Feb 2019 14:30:35 -0500 Received: from mail-vk1-f202.google.com ([209.85.221.202]:39856 "EHLO mail-vk1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729872AbfBKTae (ORCPT ); Mon, 11 Feb 2019 14:30:34 -0500 Received: by mail-vk1-f202.google.com with SMTP id k8so30403vke.6 for ; Mon, 11 Feb 2019 11:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=yTmTM4lUWy38wNpJAAj82b5/JRtPQPUWiVhvkLc+GmU=; b=IgD0EQVvZuRTW8V34xCcsd5j+kuukE2iC4AfflnsyCWMauneJH9QQAwi3n3dFkIVl1 yQswrFqCX01hxOU9LOZO0jzflZSDdobLsqRH5CHZZS9fyZhRZN6ud1RvJO39OL8fdmbt yLJy++glVR3+LvhqrpbOMBvg79T3MIgcnDdm7OK9ePSvhksVKeSMnZwAsu1RJPhY8pVF UAUdVqmig6Bg1NRh1FsbaVldgBDaN9hsdr5ZXzn4pVerj9lk7g8t8xyKGo6LarW5hRMs Q3HUQFQaraxBEnLMlaCLxHCQs0YFbjOCOpL7Jt8ePKT/VScKQENAsWNu/THSYgipbRiR /zDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=yTmTM4lUWy38wNpJAAj82b5/JRtPQPUWiVhvkLc+GmU=; b=k7P8QU6j5OS3HfAVG+txquI0oNsq73UPyQ2UrN7HVLDl0uPsnnMtYBHmpJ7AkH5LMB ot1jb4LHhYygSn8vktQErsiZqCiA36aE91FKYBPk0iHZrFJDlJSA5eLdnmvx2TJj2jk6 W5LN7517E6fqvKIbtHY4cMqNY0UR4NRjG9MeMemVn1HIPlKLj5QSHTwBsi0B4x1+3aZL O2WvXFY+yor15DU0xk6JOgqXYiBcpSYiBCbnP15Qu4KFUF7Xr3TiexaQKk4BD+TgUsfc jqzdhaMTzONPXDCNpDDnYumS5/Ly99rCjfStYCpJglOVSMV7a7Lx1SnF+p0Lk2+3U2hZ 6cEQ== X-Gm-Message-State: AHQUAuaALLXOj+XVkySNXo5ECe6MSxndRcNv90Ul7Mnr+SJ3xs6lXgzs u5axXg+DnjKiWNVVv4G9cX6UbFfJCM8nkWf2NhU= X-Google-Smtp-Source: AHgI3IYWVYrxBcjc7ylnGQXBCE4Ft/swEAMJWDf3/5UvXBH/BklzcuSloD6V+Nqifugd/XtXLW3Gdz3KUFbiE1Nntpo= X-Received: by 2002:ab0:4e23:: with SMTP id g35mr23818918uah.0.1549913433804; Mon, 11 Feb 2019 11:30:33 -0800 (PST) Date: Mon, 11 Feb 2019 11:30:03 -0800 Message-Id: <20190211193008.24101-1-ndesaulniers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.20.1.791.gb4d0f1c61a-goog Subject: [PATCH v2 1/4] init/Kconfig: add config support for detecting linker From: ndesaulniers@google.com To: yamada.masahiro@socionext.com Cc: natechancellor@gmail.com, sedat.dilek@gmail.com, keescook@chromium.org, samitolvanen@google.com, michal.lkml@markovi.net, akpm@linux-foundation.org, hannes@cmpxchg.org, peterz@infradead.org, linux@dominikbrodowski.net, npiggin@gmail.com, mathieu.desnoyers@efficios.com, gor@linux.ibm.com, adrian@lisas.de, rgb@redhat.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Desaulniers Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Similar to how we differentiate between CONFIG_CC_IS_GCC and CONFIG_CC_IS_CLANG, add CONFIG_LD_IS_BFD, CONFIG_LD_IS_GOLD, and CONFIG_LD_IS_LLD. This simiplifies patches to Makefiles that need to do different things for different linkers. Cc: Sami Tolvanen Suggested-by: Sedat Dilek Reviewed-by: Kees Cook Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor Signed-off-by: Nick Desaulniers --- Changes V1->V2: * Add suggested, reviewed, and tested by tags. init/Kconfig | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/init/Kconfig b/init/Kconfig index c9386a365eea..b6046dcf7794 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -26,6 +26,15 @@ config CLANG_VERSION config CC_HAS_ASM_GOTO def_bool $(success,$(srctree)/scripts/gcc-goto.sh $(CC)) +config LD_IS_BFD + def_bool $(success,$(LD) --version | head -n 1 | grep -q 'GNU ld') + +config LD_IS_GOLD + def_bool $(success,$(LD) --version | head -n 1 | grep -q 'GNU gold') + +config LD_IS_LLD + def_bool $(success,$(LD) --version | head -n 1 | grep -q 'LLD') + config CONSTRUCTORS bool depends on !UML From patchwork Mon Feb 11 19:30:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 10806723 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0B85B6C2 for ; Mon, 11 Feb 2019 19:30:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F17712B093 for ; Mon, 11 Feb 2019 19:30:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E4D372B0A8; Mon, 11 Feb 2019 19:30:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 857FA2B093 for ; Mon, 11 Feb 2019 19:30:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388243AbfBKTak (ORCPT ); Mon, 11 Feb 2019 14:30:40 -0500 Received: from mail-pf1-f202.google.com ([209.85.210.202]:40688 "EHLO mail-pf1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731469AbfBKTaj (ORCPT ); Mon, 11 Feb 2019 14:30:39 -0500 Received: by mail-pf1-f202.google.com with SMTP id g9so59971pfe.7 for ; Mon, 11 Feb 2019 11:30:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=d5X1DHNjDUb5NLL3O4YMEIQYPjCFJAnKD/tNSL5RNTA=; b=ZBVmQgwn6wPvQ808Q2qhEWWaFjM6+9X1q8IZ4ZIKeyEJduZfSgRN2FFUZoJEnmFB61 2izQC8j/FEojBJj296AnNPhLv0IHe8E/75uimTQC+TQnX9aMXrNSlUNjZNg56yooRaO3 LiGHDs/lGY3lEEWv4ziLOkQSDdDXbM9uCuY/bJ1px4k5FfpKNqeLnjCcldjnuDEaeP1a +Z0PuNJIMAGlUG0CtpTgdrTQo/fErysoynGFb9yZi+Qk1oiC93I3p2jnrcTrBRflFBW9 Q5bvbEwRTjz3Rb5FX/HMP5FfhF7CmjZrBR8lM5fozm4sNYfqsPTTIpmougO9/NdQOWik vYVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=d5X1DHNjDUb5NLL3O4YMEIQYPjCFJAnKD/tNSL5RNTA=; b=ApFRDNAjsYV/UvDN8OWpDkT37cJyheDwXz9C3dmg8bCaUaTB/ndKp+7pMpOh/J2x3W Wk5VwfNRWxeYikSXCxfQSD9wlclWBPJDg7k1BEm1eCcY7AqoR3g66AOrJ57nJda7hryG QAjdjg7ppPi2tSvN5/yzVw2YJKuZtNvR568LZxTN0yHPti8DuO/XujMUctiujQKrL76u JZlHCe5DjSmJcMCpFJaUE3f/oa+PkhfazgvwmvVQN84arSBqXFCYKBLUuSP/DlXveXHP Vcjsm0ofzwjnlz1T82j1hd4n0+C7qiNZkFoomJkY++SLJK3xyHgDe7zb+XKHTvzbfWD6 3JWQ== X-Gm-Message-State: AHQUAuYpOIbicGuhJi5SK5Zi9pGIOyC+jGV6kthKE9y1cL2RlEUTq/9f Sq0FABLBLJc3/tehJIegTJXCy+lUw0TZB0yapQM= X-Google-Smtp-Source: AHgI3Ib3P7TggZpwqevlzSKuItbQf2rXHsRRYH3FFQnxMn84Vtvz0Kpep/2mKvDgaWdyk6EZ2VrQF8XPawp0tYV1UB0= X-Received: by 2002:aa7:8acb:: with SMTP id b11mr1064903pfd.72.1549913438630; Mon, 11 Feb 2019 11:30:38 -0800 (PST) Date: Mon, 11 Feb 2019 11:30:04 -0800 In-Reply-To: <20190211193008.24101-1-ndesaulniers@google.com> Message-Id: <20190211193008.24101-2-ndesaulniers@google.com> Mime-Version: 1.0 References: <20190211193008.24101-1-ndesaulniers@google.com> X-Mailer: git-send-email 2.20.1.791.gb4d0f1c61a-goog Subject: [PATCH v2 2/4] Makefile: clang: choose GCC_TOOLCHAIN_DIR not on LD From: ndesaulniers@google.com To: yamada.masahiro@socionext.com Cc: natechancellor@gmail.com, sedat.dilek@gmail.com, keescook@chromium.org, samitolvanen@google.com, michal.lkml@markovi.net, akpm@linux-foundation.org, hannes@cmpxchg.org, peterz@infradead.org, linux@dominikbrodowski.net, npiggin@gmail.com, mathieu.desnoyers@efficios.com, gor@linux.ibm.com, adrian@lisas.de, rgb@redhat.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Desaulniers Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This causes an issue when trying to build with `make LD=ld.lld` if ld.lld and the rest of your cross tools aren't in the same directory (ex. /usr/local/bin) (as is the case for Android's build system), as the GCC_TOOLCHAIN_DIR then gets set based on `which $(LD)` which will point where LLVM tools are, not GCC/binutils tools are located. Instead, select the GCC_TOOLCHAIN_DIR based on another tool provided by binutils for which LLVM does not provide a substitute for, such as elfedit. Fixes commit 785f11aa595b ("kbuild: Add better clang cross build support") Link: https://github.com/ClangBuiltLinux/linux/issues/341 Suggested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor Signed-off-by: Nick Desaulniers --- Changes V1->V2: * add reviewed and tested tags. Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 86cf35d1d79d..d3b65e96d183 100644 --- a/Makefile +++ b/Makefile @@ -492,7 +492,7 @@ endif ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),) ifneq ($(CROSS_COMPILE),) CLANG_FLAGS := --target=$(notdir $(CROSS_COMPILE:%-=%)) -GCC_TOOLCHAIN_DIR := $(dir $(shell which $(LD))) +GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE)elfedit)) CLANG_FLAGS += --prefix=$(GCC_TOOLCHAIN_DIR) GCC_TOOLCHAIN := $(realpath $(GCC_TOOLCHAIN_DIR)/..) endif From patchwork Mon Feb 11 19:30:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 10806725 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 106B817E0 for ; Mon, 11 Feb 2019 19:30:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01BD32B093 for ; Mon, 11 Feb 2019 19:30:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E97CD2B0A8; Mon, 11 Feb 2019 19:30:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE35D2B0A4 for ; Mon, 11 Feb 2019 19:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388263AbfBKTaq (ORCPT ); Mon, 11 Feb 2019 14:30:46 -0500 Received: from mail-it1-f201.google.com ([209.85.166.201]:56347 "EHLO mail-it1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388262AbfBKTap (ORCPT ); Mon, 11 Feb 2019 14:30:45 -0500 Received: by mail-it1-f201.google.com with SMTP id 135so91989itb.6 for ; Mon, 11 Feb 2019 11:30:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=A+p5CcPbc67CNJ+HtkbKBMLEqE5iK/BxBkcy0srR2f4=; b=EUfDjdobRLMV2Tk3lGBtNvj9QujsHoJi9ZqtEcH+YVtBCw0t/FCOOKOLjYPLz2olUE +TKRIo6Qkhd4/yl5EoeB93P6IDHZzfNjrzFK7iELdrQbe/FgB6/rqt0ScvP0xuzVt8hB z3fEBdPiKZndqh/aWqmvhVbI4J2B7eYEVxxuxU9Axu+akFPva/9Qj60M9PMrdYG72vSq Gubv63+gi2EzkY3wnIv2NYmvI/aEm0HnzTlhgrrxsVzTrjldQ24LgR14yr2G4DK4e8hr yPFkN2CogT0A25zsQf9ZCs9OjpRlwz3HR/KZ4hDpMclFW4EC5h+L1Va45mhPLcZKJY2J lLGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=A+p5CcPbc67CNJ+HtkbKBMLEqE5iK/BxBkcy0srR2f4=; b=tkuojd/e/URoPVyO5ahw5YTqpVlc6n4ygWx1iDwD2L0SDHOIyLJgro5iHO7VzDr4JT XnZwfWrgRcXn3NBw5yLe50ct+jg7EzIFb7PGo6Bai2DgDaa9JLM4FAw1XImOox4WycLw lUHGvwUMl3tCmYc+/Xamj2WepbeC0LYKr8q7MUiYWxRnLkaspPcTsIkJvEj/kiwrhYLf zXdNT6wA4gBaXv3ShKy9tGAyCkCsevgpQbu/4x1uPtyg551EI2dHCcBs5HyA4nu4YqgW Vj/zLk8aIr/MHFGgbs0rl2VWFKX0/qoVM6zQpsjGPVSRFGstMa0kz/VgPoeSQ7N2jVYM F1XQ== X-Gm-Message-State: AHQUAuYmYptxlmE1EVreUhQtDKa8JaRJhTM5xU2xAUmcJu1vemqRpWYw l4bNuiDy69c+aFpFUtvINMuXHGhSdEigyZ4bDbw= X-Google-Smtp-Source: AHgI3IYF+PQlndRP+6W1b1+rJPutoAPanw6IRHwvLut+f1J4HrBcdzpQTR7g4ywG2Ll0njjvZe7wN/kSkeOVBeIn3MA= X-Received: by 2002:a24:d82:: with SMTP id 124mr794567itx.10.1549913443054; Mon, 11 Feb 2019 11:30:43 -0800 (PST) Date: Mon, 11 Feb 2019 11:30:05 -0800 In-Reply-To: <20190211193008.24101-1-ndesaulniers@google.com> Message-Id: <20190211193008.24101-3-ndesaulniers@google.com> Mime-Version: 1.0 References: <20190211193008.24101-1-ndesaulniers@google.com> X-Mailer: git-send-email 2.20.1.791.gb4d0f1c61a-goog Subject: [PATCH v2 3/4] Makefile: lld: tell clang to use lld From: ndesaulniers@google.com To: yamada.masahiro@socionext.com Cc: natechancellor@gmail.com, sedat.dilek@gmail.com, keescook@chromium.org, samitolvanen@google.com, michal.lkml@markovi.net, akpm@linux-foundation.org, hannes@cmpxchg.org, peterz@infradead.org, linux@dominikbrodowski.net, npiggin@gmail.com, mathieu.desnoyers@efficios.com, gor@linux.ibm.com, adrian@lisas.de, rgb@redhat.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Desaulniers Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is needed because clang doesn't select which linker to use based on $LD but rather -fuse-ld=lld. This is problematic especially for cc-ldoption, which checks for linker flag support via invoking the compiler, rather than the linker. Link: https://github.com/ClangBuiltLinux/linux/issues/342 Suggested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor Signed-off-by: Nick Desaulniers --- Changes V1->V2: * add reviewed and tested by tags. * move this addition up 2 statments so that it's properly added to KBUILD_*FLAGS as per Nathan. Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index d3b65e96d183..00e8e01d23fc 100644 --- a/Makefile +++ b/Makefile @@ -500,6 +500,9 @@ ifneq ($(GCC_TOOLCHAIN),) CLANG_FLAGS += --gcc-toolchain=$(GCC_TOOLCHAIN) endif CLANG_FLAGS += -no-integrated-as +ifneq ($(shell $(LD) --version 2>&1 | head -n 1 | grep LLD),) +CLANG_FLAGS += -fuse-ld=lld +endif KBUILD_CFLAGS += $(CLANG_FLAGS) KBUILD_AFLAGS += $(CLANG_FLAGS) export CLANG_FLAGS From patchwork Mon Feb 11 19:30:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 10806729 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B811F6C2 for ; Mon, 11 Feb 2019 19:31:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A73DE2B093 for ; Mon, 11 Feb 2019 19:31:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9AD4C2B0A8; Mon, 11 Feb 2019 19:31:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F74E2B093 for ; Mon, 11 Feb 2019 19:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388295AbfBKTat (ORCPT ); Mon, 11 Feb 2019 14:30:49 -0500 Received: from mail-qk1-f201.google.com ([209.85.222.201]:43771 "EHLO mail-qk1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388289AbfBKTat (ORCPT ); Mon, 11 Feb 2019 14:30:49 -0500 Received: by mail-qk1-f201.google.com with SMTP id a11so2119358qkk.10 for ; Mon, 11 Feb 2019 11:30:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=fgo15CY3NgYRpF97TzDUfVV2bSFDYAqgksNtaJxXuEA=; b=P33ZEVn9lWw4ExXF0pVb2kRhsMzsHIZnSCIoTjgHA67m1TBvJkvTccmmchHplJnzYi tK2h0WoALbgU2nZkZBJ2SxgLYpjlLfwsyM0qPDqW+WBGaVbVrCsDmIH6NfN+z6JfOa8G T+CWOFyTf+3H6TpEGTUvVR3EWZKAFrVXa/1HeoxRLcFre021WqnSEaB0okT2cdrUH/Zp j6/LfS6vWUOX8eAWpEshZ9EdhfKAPlTBxfbG9fyzxahFURQCfQqWoyJvynTy4bLNZmAd Fru81lvlu6FIits75GNMSWZETZYzfa/xtYGwkz6eLWKT5EO6vuFx7ZpACi8+YI0l12y3 10LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=fgo15CY3NgYRpF97TzDUfVV2bSFDYAqgksNtaJxXuEA=; b=XLe5o26ZchfqSkFFA2KORkLVcCvlQYpVsT4e1GaLpiDumVEPbTRHj4H5meJvaD42Rw WM+AlH0dDMht5wUBV6P0ZE46afbZxxbb0cebGz1fPkWfDtLLenIOP1RRg2udi6YyCHEQ OGlvb3wrqievU8fn/OskOFU0PgDpIn94Wi6QCnYaj8LVa1+d1EWzau/NLs+5pRV7jEAY t7SfJ7Vs9jMkNrM/SoiK9YCxFcSkyfSSh0x0rbu1EKmWuW/lxgnw6MHFedbqcWEeyJNm Lg5GxzAQpdtfEu0jQb3OMAhMNyN8Vz3vWyJetwFB6QgktBhJJZO31sk/O3bA9y5e+Pdj eyHA== X-Gm-Message-State: AHQUAubcQltc/JrFy658eyh64wqMaKy4BNeTqv7DGCpNYBMf3hoQT3pN xiovifUiCCnvViKCUtR50RdLuULYIrfc9scKO9c= X-Google-Smtp-Source: AHgI3IY6emNTamoLiOwa6pdZ0u5LLMBlSN9RZx8mrz70CAMQpxHxS0uzBm81DdK35Kw3x7EGXJpyDAJvrnUO/HSEvdc= X-Received: by 2002:a0c:add8:: with SMTP id x24mr21936434qvc.16.1549913448304; Mon, 11 Feb 2019 11:30:48 -0800 (PST) Date: Mon, 11 Feb 2019 11:30:06 -0800 In-Reply-To: <20190211193008.24101-1-ndesaulniers@google.com> Message-Id: <20190211193008.24101-4-ndesaulniers@google.com> Mime-Version: 1.0 References: <20190211193008.24101-1-ndesaulniers@google.com> X-Mailer: git-send-email 2.20.1.791.gb4d0f1c61a-goog Subject: [PATCH v2 4/4] Makefile: lld: set -O2 linker flag when linking with LLD From: ndesaulniers@google.com To: yamada.masahiro@socionext.com Cc: natechancellor@gmail.com, sedat.dilek@gmail.com, keescook@chromium.org, samitolvanen@google.com, michal.lkml@markovi.net, akpm@linux-foundation.org, hannes@cmpxchg.org, peterz@infradead.org, linux@dominikbrodowski.net, npiggin@gmail.com, mathieu.desnoyers@efficios.com, gor@linux.ibm.com, adrian@lisas.de, rgb@redhat.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Desaulniers , Rui Ueyama Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For arm64: 0.34% size improvement with lld -O2 over lld for vmlinux. 3.3% size improvement with lld -O2 over lld for Image.lz4-dtb. Link: https://github.com/ClangBuiltLinux/linux/issues/343 Suggested-by: Rui Ueyama Suggested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor Signed-off-by: Nick Desaulniers --- Changes V1->V2: * add tested and reviewed by tags. Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 00e8e01d23fc..8011555745aa 100644 --- a/Makefile +++ b/Makefile @@ -718,6 +718,10 @@ else KBUILD_CFLAGS += -Wno-unused-but-set-variable endif +ifdef CONFIG_LD_IS_LLD +KBUILD_LDFLAGS += -O2 +endif + KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable) ifdef CONFIG_FRAME_POINTER KBUILD_CFLAGS += -fno-omit-frame-pointer -fno-optimize-sibling-calls