From patchwork Mon Sep 18 10:07:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 13389365 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A86FACD37B0 for ; Mon, 18 Sep 2023 10:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/sa0Fb14nel5lsYBgidc96Z2R6XuyzrO4eXlw+d8ShI=; b=iOUnJvGMvQ2EvG RjHzcw5YzV06wGpTIQlO7eiqFtMuDDZ+nHK9TL1To6xp90N0vNrwE/LVhIiQyXnadNgQu2K5XqNuV mJc2SMN8Xyn6svM+nMIDmNheoRdMLpMscgQIn5CkZplZNmtajzO8Be086/I8ssT30db493sxziaOV MvozBOT/CBLRfyl7wYEeRFdkzqUxZRZ0NoTLRTDDbVsGbV0zT+8fGmpws4bmmUmxoPwJ5x3OmyYMr S137iV+03pkSrXDrpbXJZS9IzuCUY97H9aigJWEFAbh8AokCCMLb3BI/YR2ILlkRATbtcZxCtmrN1 ad5uKOe+daoJ6dNu3Raw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiBA7-00F2MI-1R; Mon, 18 Sep 2023 10:07:27 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiBA2-00F2LJ-1J for linux-arm-kernel@lists.infradead.org; Mon, 18 Sep 2023 10:07:24 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-52a1ce529fdso5204697a12.1 for ; Mon, 18 Sep 2023 03:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695031638; x=1695636438; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3CIzAQBDBRAbXi6odnAuwsq+At6oBbxMnuT61WOfur8=; b=hYPwN6jfcQ/jh5PCUV16ke8rmWi2SThAZdW/6li2iVnj/Ic0U1U0zbYAzUyvLPlQep k9PhrEZ/6T7hH5cW0pkKbJRbU8HAcmWJg3/3d749dXJ1Hl+HHowKvdfWPWnEt62M7PZ6 st/2gbPq2rB1cgfgrm6B2j0X+Lbs/VO48glGhdmuazTuFJeMqRblVIHWEDH+xojRag6G e3gPCW9APeurOQnWoFgYiBlS3b5kzsOMMz+dFI4m+b+mlazy/uthViyuN4GckpyLfG4R Ffb1NaLeQSDhtfa8I7WJYDpCETIKqyG0eimv0YbeOimimbm+NFS8XdRxijiapXenpGyM fxOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695031638; x=1695636438; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3CIzAQBDBRAbXi6odnAuwsq+At6oBbxMnuT61WOfur8=; b=NRJ57BPZBRvFRqE+tFMHBIJhyfO9J4X7AHGpBUso+9Fo9K0z/Gb4kqVVZ1i1Dhv6sb U0TORRMLjy/WAHvlcHDMWrbM93mJ9/lbxuIp4M3X8KQy9p/xpwwBVJ7rlczXXoBLIzNY laBoFe8gDxF5uXQ4meSydFAxjeHY13zmJQySYgTGuREZBDhcGbXDsWFRH2gzU4iYh5EN DWlszj5YXy0n6V4RjlfO+DqSLjv345IuIGsjx4JQLL/drkXNYrikXLhhb1twAXR0OHAg uJf5l4Agge0iBIIxG/x/SKQZ8KCYOKe7eT8yTG+rN885Vei4BTnfpLofD2K+xt6lz9k9 8YbQ== X-Gm-Message-State: AOJu0YxbZ2Vdoqf+vRnO4GnN36SjbNnuG/7E70s8jVK/ltUavziwuhya XqNO9Uk+rQ+mGYCffbbQScR27w== X-Google-Smtp-Source: AGHT+IGidGqFde6MO6aKF0/Be311hyX6HKkzV2FNPU58Qptc75KDLExfyXA/sohTN+Ue1NGSHZDpCA== X-Received: by 2002:a05:6402:3494:b0:531:28fd:ad10 with SMTP id v20-20020a056402349400b0053128fdad10mr1459070edc.38.1695031638376; Mon, 18 Sep 2023 03:07:18 -0700 (PDT) Received: from blmsp.fritz.box ([2001:4091:a246:8222:872:4a5b:b69c:1318]) by smtp.gmail.com with ESMTPSA id p21-20020aa7d315000000b00522828d438csm5824096edq.7.2023.09.18.03.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 03:07:17 -0700 (PDT) From: Markus Schneider-Pargmann To: Daniel Lezcano , "Rafael J . Wysocki" , Amit Kucheria , Zhang Rui , Matthias Brugger Cc: AngeloGioacchino Del Regno , Frank Wunderlich , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Markus Schneider-Pargmann , Frank Wunderlich Subject: [PATCH] thermal/drivers/mediatek: Fix probe for THERMAL_V2 Date: Mon, 18 Sep 2023 12:07:06 +0200 Message-Id: <20230918100706.1229239-1-msp@baylibre.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_030722_470239_2D08BE68 X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix the probe function to call mtk_thermal_release_periodic_ts for everything != MTK_THERMAL_V1. This was accidentally changed from V1 to V2 in the original patch. Reported-by: Frank Wunderlich Closes: https://lore.kernel.org/lkml/B0B3775B-B8D1-4284-814F-4F41EC22F532@public-files.de/ Reported-by: Daniel Lezcano Closes: https://lore.kernel.org/lkml/07a569b9-e691-64ea-dd65-3b49842af33d@linaro.org/ Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks") Signed-off-by: Markus Schneider-Pargmann Reviewed-by: AngeloGioacchino Del Regno --- drivers/thermal/mediatek/auxadc_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c index 843214d30bd8..8b0edb204844 100644 --- a/drivers/thermal/mediatek/auxadc_thermal.c +++ b/drivers/thermal/mediatek/auxadc_thermal.c @@ -1267,7 +1267,7 @@ static int mtk_thermal_probe(struct platform_device *pdev) mtk_thermal_turn_on_buffer(mt, apmixed_base); - if (mt->conf->version != MTK_THERMAL_V2) + if (mt->conf->version != MTK_THERMAL_V1) mtk_thermal_release_periodic_ts(mt, auxadc_base); if (mt->conf->version == MTK_THERMAL_V1)