From patchwork Tue Feb 12 01:51:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10807187 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2134A922 for ; Tue, 12 Feb 2019 01:51:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0FE4C2ADFF for ; Tue, 12 Feb 2019 01:51:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 044212AE09; Tue, 12 Feb 2019 01:51:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A51BF2ADFF for ; Tue, 12 Feb 2019 01:51:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727341AbfBLBv1 (ORCPT ); Mon, 11 Feb 2019 20:51:27 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:42701 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726852AbfBLBvZ (ORCPT ); Mon, 11 Feb 2019 20:51:25 -0500 Received: by mail-pg1-f194.google.com with SMTP id d72so444549pga.9; Mon, 11 Feb 2019 17:51:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XhYeWLJELbBbIY+70J27USkrt28o/PdkHlXxy2828Aw=; b=e1JnCf7wRHTPnhwqCvYmVDpF+ygXKWJ2X9sU1PuTUICG57IYl/wersw6LE1ZZfRoSP z0vNsZmaF0uvzQlUM2wVJrDWPDDYEAiw1hsgZqeA2Jz48FjbGU06Mf5XA3BLgaJYfwyU O4qKgpjJY21YjRjaIDHYPgE5rnbltPt3d1eUj8DFG22XmG1JDUkpfU1+rw3UrZLDyVub FFc5dKMDXIYwWazjMLiipCd4n/ZqGlUGo1GZAg0F9mdlhAdkVPL0iHa5AJ8FENM70Yuq Cg7yl6zbTGWWU7EFD9lvhVC2wAfMAfG5rp62ik/Q9AIkqWMG3jdp4mDthl589sdp9N8O a37g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XhYeWLJELbBbIY+70J27USkrt28o/PdkHlXxy2828Aw=; b=d88LZT8MggwxXidY7VJ+rVbJ3h9befDwtkP1zthZIZwPqFho8wmxzUP8wy1a5RYwB5 agcJLPcAcvEp7dfHcoIbK7gYBE2QzqH+U+IbH0XFvjXKWNd7C+XadbWqqk1/0kOuHNEl ccAWCYC0KhA4LCAy48S0pnwSGXYJhEV5zYy2e19zadKoX21iJ7v8S2rBP1HlUEAS8HFa hWfYtMQEw4HkbBHmtQnbhs2PlGZjEan1kenOwfUSxU6+ptxxAbvl8paQ2PDAfvTo2X5S qXohO7rC4LItmUmuJN4UpD3zhwx0xfVSUPCx5h/gPQ9AHGzaVMIBvQHuKuVNbfG3TgN4 Dhzw== X-Gm-Message-State: AHQUAuYutpVJ1hobhz0a2f5k0kMH1TK7TUC+P4bs+X2DzhRLDyHUEb/Q DHQxoitCkPuoeV+b8Tnd5Pg= X-Google-Smtp-Source: AHgI3IbTde5HeivFm3ljicLP4d2ZWPVCAiISH6/qQT+zjCtH9wnU2D75DjAI9R26IehpTVqfat5T6Q== X-Received: by 2002:a63:2bc4:: with SMTP id r187mr1282560pgr.306.1549936284040; Mon, 11 Feb 2019 17:51:24 -0800 (PST) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id h64sm17146941pfc.142.2019.02.11.17.51.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 17:51:23 -0800 (PST) From: Andrey Smirnov To: Lorenzo Pieralisi Cc: Andrey Smirnov , Bjorn Helgaas , Fabio Estevam , Chris Healy , Lucas Stach , Leonard Crestez , "A.s. Dong" , Richard Zhu , linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: imx6q-pcie: Add "pcie_aux" clock for imx8mq Date: Mon, 11 Feb 2019 17:51:07 -0800 Message-Id: <20190212015108.16952-2-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190212015108.16952-1-andrew.smirnov@gmail.com> References: <20190212015108.16952-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add a binding for an extra clock required on i.MX8MQ. Signed-off-by: Andrey Smirnov Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-imx@nxp.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linux-pci@vger.kernel.org Cc: Rob Herring Cc: devicetree@vger.kernel.org Reviewed-by: Lucas Stach Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt index 920ca93870a8..933d98328e07 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt @@ -55,6 +55,10 @@ Additional required properties for imx7d-pcie and imx8mq-pcie: - "apps" - "turnoff" +Additional required properties for imx8mq-pcie: +- clock-names: Must include the following additional entries: + - "pcie_aux" + Example: pcie@01000000 { From patchwork Tue Feb 12 01:51:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10807185 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A0F9A13B4 for ; Tue, 12 Feb 2019 01:51:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 915122ADFF for ; Tue, 12 Feb 2019 01:51:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8552A2AE09; Tue, 12 Feb 2019 01:51:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1EE742ADFF for ; Tue, 12 Feb 2019 01:51:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727354AbfBLBv1 (ORCPT ); Mon, 11 Feb 2019 20:51:27 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:44532 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727305AbfBLBv0 (ORCPT ); Mon, 11 Feb 2019 20:51:26 -0500 Received: by mail-pf1-f196.google.com with SMTP id u6so453738pfh.11; Mon, 11 Feb 2019 17:51:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sMMxpgSAniB8LFv+M0YvWiyKlN5hrWVQrVJB4z8L3aY=; b=Q2NCdLTe3L02gUvsERVySCKHaosfpploZ7PksExlTb+pRbqf4g+/w2laNGEF9s3n7D BvjDsXKQ1OFHZxurw1RKwZgs5DSysAgHmZweQDOXKH2/UQHJ9GqvpAB72R9krft3vAjY qIQazMqb4HojIG9l41zCkgr0+GDKI7/S7ZQjB8ghQOQhArPiu5KYyy3+SM8M9nJm0pbF UKigOQyO6c3HcN5ABEj9YlNZjAEj0ZpaMH/xL+Fh+zpkjM0OnH93929okw6KwBhOphdN JTEwPuV9p7X6LdPzD719lkpRmGreckTQ0huJhT2+fHfJD4TUX0fcWvXhNLDemxkLj7Qz /a6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sMMxpgSAniB8LFv+M0YvWiyKlN5hrWVQrVJB4z8L3aY=; b=fm4C7bVU4+5TOF33/oWA++41RMqXf4kWwQttnqs8HlvKijjhvwznyBZ5qZV+XUvvZc utKLASUzDctzm/LkTxFsGO9Evnic7Q5eYrlQGlPHpUA2nG7jk/L7+XrXhYG6RrFCKV8w DUVak95jgoJz53EJ7JOPjlraVzu10mIVSFzKR9m7/pHvGgbWMXCayvn6WojZ0w6xkcMf wAeeOqb0gvTvwJkjS5MBv1pkOceQ7RoV1iNjzDHuwciHtOfdxs3FxDYIE40eC99oEf1i Vq47X4d4NMk0d5PIiISC4FrLg/hzmvWtXcb4i5AM6JxKKjyQSKNUEFbJSEJAmXll4az2 wv5A== X-Gm-Message-State: AHQUAuboynhH5PqjZKOnHrsy2QMAIT0ijl1Zu4HyNfBj3DkzX0hSHGGj gJQAzR5v2y4sgfHK23Q4FzQ= X-Google-Smtp-Source: AHgI3IZuyGNGaY3+wbNd56v+9F6Z4rVnNcBqyshgVkthaFjRMDAQfmZ2q/nKFILjhcMsn3X28rVzdg== X-Received: by 2002:aa7:85cc:: with SMTP id z12mr1418728pfn.196.1549936285714; Mon, 11 Feb 2019 17:51:25 -0800 (PST) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id h64sm17146941pfc.142.2019.02.11.17.51.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 17:51:25 -0800 (PST) From: Andrey Smirnov To: Lorenzo Pieralisi Cc: Andrey Smirnov , Bjorn Helgaas , Fabio Estevam , Chris Healy , Lucas Stach , Leonard Crestez , "A.s. Dong" , Richard Zhu , linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org Subject: [PATCH 2/2] PCI: imx6: Add code to request/control "pcie_aux" clock for i.MX8MQ Date: Mon, 11 Feb 2019 17:51:08 -0800 Message-Id: <20190212015108.16952-3-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190212015108.16952-1-andrew.smirnov@gmail.com> References: <20190212015108.16952-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP PCIe IP block has additional clock, "pcie_aux", that needs to be controlled by the driver. Add code to support that. Signed-off-by: Andrey Smirnov Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-imx@nxp.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linux-pci@vger.kernel.org Cc: Rob Herring Cc: devicetree@vger.kernel.org Reviewed-by: Lucas Stach --- drivers/pci/controller/dwc/pci-imx6.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 7cdf8f9ab244..1a7031782846 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -65,6 +65,7 @@ struct imx6_pcie { struct clk *pcie_phy; struct clk *pcie_inbound_axi; struct clk *pcie; + struct clk *pcie_aux; struct regmap *iomuxc_gpr; u32 controller_id; struct reset_control *pciephy_reset; @@ -421,6 +422,12 @@ static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6_pcie) case IMX7D: break; case IMX8MQ: + ret = clk_prepare_enable(imx6_pcie->pcie_aux); + if (ret) { + dev_err(dev, "unable to enable pcie_aux clock\n"); + break; + } + offset = imx6_pcie_grp_offset(imx6_pcie); /* * Set the over ride low and enabled @@ -904,6 +911,9 @@ static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie) IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, IMX7D_GPR12_PCIE_PHY_REFCLK_SEL); break; + case IMX8MQ: + clk_disable_unprepare(imx6_pcie->pcie_aux); + break; default: break; } @@ -1049,6 +1059,12 @@ static int imx6_pcie_probe(struct platform_device *pdev) dev_err(dev, "Failed to get PCIE APPS reset control\n"); return PTR_ERR(imx6_pcie->apps_reset); } + + imx6_pcie->pcie_aux = devm_clk_get(dev, "pcie_aux"); + if (IS_ERR(imx6_pcie->pcie_aux)) { + dev_err(dev, "pcie_aux clock source missing or invalid\n"); + return PTR_ERR(imx6_pcie->pcie_aux); + } break; default: break;