From patchwork Wed Sep 27 00:24:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 13399796 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8CE5E7F150 for ; Wed, 27 Sep 2023 01:19:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229530AbjI0BTZ (ORCPT ); Tue, 26 Sep 2023 21:19:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234253AbjI0BRY (ORCPT ); Tue, 26 Sep 2023 21:17:24 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90AE322187 for ; Tue, 26 Sep 2023 17:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695774267; x=1727310267; h=from:date:subject:mime-version:content-transfer-encoding: message-id:to:cc; bh=6Q+yyCEe0DKcBWb6PF0uUikdZ9NOToB+Dd79jqNqRUM=; b=CG6bxZtkP6PbAjnqveK/umpjmeogquZ7HjMimkeZaPsCIhaOBIYZ1rZ4 8kWS5zlwU2mDCGbXGmG5Ri3BJpsPu8+8NTy7wNFTwm/zi0UbjD4bwh8n2 wt1AtVH9eR/CcK4cLk7hIINrOba7EQHajEuQuI9RaCFbDFCfjLvSUhtyR w+s6SyzSTBZexHPqKDIcYGDMxsF3w3ugNnF8fwmgjsZaE+tB6M8CYwgQj j6PoXSwkIlzTDAwNkdHzCexj/Jx6z3yhC78+Azo71DwTMVSANqVEUHZhr OAXuaPGzD3OrRxBlu7S4fgPbOzuiORFGORYe42/WvNcUO4HoKLZ0UVkX1 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="385551286" X-IronPort-AV: E=Sophos;i="6.03,179,1694761200"; d="scan'208";a="385551286" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 17:24:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="819218190" X-IronPort-AV: E=Sophos;i="6.03,179,1694761200"; d="scan'208";a="819218190" Received: from iweiny-mobl.amr.corp.intel.com (HELO localhost) ([10.212.44.218]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 17:24:27 -0700 From: Ira Weiny Date: Tue, 26 Sep 2023 17:24:25 -0700 Subject: [PATCH ndctl] ndctl/cxl/region: Report max size for region creation MIME-Version: 1.0 Message-Id: <20230926-max-size-create-region-v1-1-d3555e91087c@intel.com> X-B4-Tracking: v=1; b=H4sIADh2E2UC/x3NQQqDQAyF4atI1g3oDLa0VyldZGJGs3BakiJS8 e4dXf4PPt4GLqbi8Gg2MFnU9V1qdJcGeKIyCupQG0IbYnsPV5xpRdefIJvQV9BkrAS73N9yjon 7yFBxIhdMRoWng8+k5Zg/JlnX8+/52vc/LNjIMX8AAAA= To: Vishal Verma Cc: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, Ira Weiny X-Mailer: b4 0.13-dev-c6835 X-Developer-Signature: v=1; a=ed25519-sha256; t=1695774266; l=1072; i=ira.weiny@intel.com; s=20221211; h=from:subject:message-id; bh=6Q+yyCEe0DKcBWb6PF0uUikdZ9NOToB+Dd79jqNqRUM=; b=JfGB5H1JVqbYY4ca7m4+v+g8t0G7wq36mNtMGhkxnr9F1jkETw0Cb3/Bl2UQq+p/TS08Bw0ru d4v3GnEeSy4CjG5NeNNBW2faZoyVSiUdFWn7oPe9Sb5MJQDCbejNEd1 X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=noldbkG+Wp1qXRrrkfY1QJpDf7QsOEthbOT7vm0PqsE= Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org When creating a region if the size exceeds the max an error is printed. However, the max available space is not reported which makes it harder to determine what is wrong. Add the max size available to the output error. Signed-off-by: Ira Weiny Reviewed-by: Dave Jiang --- cxl/region.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- base-commit: a871e6153b11fe63780b37cdcb1eb347b296095c change-id: 20230926-max-size-create-region-1f57ff3bc53c Best regards, diff --git a/cxl/region.c b/cxl/region.c index bcd703956207..cb6a547990fb 100644 --- a/cxl/region.c +++ b/cxl/region.c @@ -623,8 +623,8 @@ static int create_region(struct cxl_ctx *ctx, int *count, } if (!default_size && size > max_extent) { log_err(&rl, - "%s: region size %#lx exceeds max available space\n", - cxl_decoder_get_devname(p->root_decoder), size); + "%s: region size %#lx exceeds max available space (%#lx)\n", + cxl_decoder_get_devname(p->root_decoder), size, max_extent); return -ENOSPC; }