From patchwork Wed Sep 27 07:02:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: chenguohua@jari.cn X-Patchwork-Id: 13400026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C635AE80A97 for ; Wed, 27 Sep 2023 07:04:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229882AbjI0HEA (ORCPT ); Wed, 27 Sep 2023 03:04:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjI0HD4 (ORCPT ); Wed, 27 Sep 2023 03:03:56 -0400 Received: from jari.cn (unknown [218.92.28.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EB5C0DE; Wed, 27 Sep 2023 00:03:54 -0700 (PDT) Received: from chenguohua$jari.cn ( [182.148.12.64] ) by ajax-webmail-localhost.localdomain (Coremail) ; Wed, 27 Sep 2023 15:02:35 +0800 (GMT+08:00) X-Originating-IP: [182.148.12.64] Date: Wed, 27 Sep 2023 15:02:35 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: chenguohua@jari.cn To: hare@suse.com, jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [SCSI] aic7xxx: Clean up errors in aiclib.h X-Priority: 3 X-Mailer: Coremail Webmail Server Version 2023.1-cmXT6 build 20230419(ff23bf83) Copyright (c) 2002-2023 www.mailtech.cn mispb-4e503810-ca60-4ec8-a188-7102c18937cf-zhkzyfz.cn MIME-Version: 1.0 Message-ID: <5645eb7.87d.18ad5725a91.Coremail.chenguohua@jari.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID: AQAAfwDHZD+L0xNl4O29AA--.625W X-CM-SenderInfo: xfkh0w5xrk3tw6md2xgofq/1tbiAQAHEWUSpy8AOwABsS X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: return is not a function, parentheses are not required ERROR: space required after that ',' (ctx:VxV) Signed-off-by: GuoHua Cheng --- drivers/scsi/aic7xxx/aiclib.h | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/aic7xxx/aiclib.h b/drivers/scsi/aic7xxx/aiclib.h index ba08eb3c4e3b..a7d0a2d912cd 100644 --- a/drivers/scsi/aic7xxx/aiclib.h +++ b/drivers/scsi/aic7xxx/aiclib.h @@ -57,8 +57,7 @@ #ifndef _AICLIB_H #define _AICLIB_H -struct scsi_sense -{ +struct scsi_sense { uint8_t opcode; uint8_t byte2; uint8_t unused[2]; @@ -72,8 +71,7 @@ struct scsi_sense #define SCSI_REV_SPC 3 #define SCSI_REV_SPC2 4 -struct scsi_sense_data -{ +struct scsi_sense_data { uint8_t error_code; #define SSD_ERRCODE 0x7F #define SSD_CURRENT_ERROR 0x70 @@ -135,7 +133,7 @@ scsi_4btoul(uint8_t *bytes) (bytes[1] << 16) | (bytes[2] << 8) | bytes[3]; - return (rv); + return rv; } /* Macros for generating the elements of the PCI ID tables. */ @@ -144,7 +142,7 @@ scsi_4btoul(uint8_t *bytes) #define ID_C(x, c) \ { \ - GETID(x,32), GETID(x,48), GETID(x,0), GETID(x,16), \ + GETID(x, 32), GETID(x, 48), GETID(x, 0), GETID(x, 16), \ (c) << 8, 0xFFFF00, 0 \ }