From patchwork Wed Sep 27 08:43:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: chenguohua@jari.cn X-Patchwork-Id: 13400386 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56F38E810AC for ; Wed, 27 Sep 2023 08:45:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230290AbjI0IpZ (ORCPT ); Wed, 27 Sep 2023 04:45:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230262AbjI0IpX (ORCPT ); Wed, 27 Sep 2023 04:45:23 -0400 Received: from jari.cn (unknown [218.92.28.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0AAB1DE; Wed, 27 Sep 2023 01:45:21 -0700 (PDT) Received: from chenguohua$jari.cn ( [182.148.12.64] ) by ajax-webmail-localhost.localdomain (Coremail) ; Wed, 27 Sep 2023 16:43:58 +0800 (GMT+08:00) X-Originating-IP: [182.148.12.64] Date: Wed, 27 Sep 2023 16:43:58 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: chenguohua@jari.cn To: gotom@debian.or.jp, yokota@netlab.is.tsukuba.ac.jp, jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: nsp32: Clean up errors in nsp32.h X-Priority: 3 X-Mailer: Coremail Webmail Server Version 2023.1-cmXT6 build 20230419(ff23bf83) Copyright (c) 2002-2023 www.mailtech.cn mispb-4e503810-ca60-4ec8-a188-7102c18937cf-zhkzyfz.cn MIME-Version: 1.0 Message-ID: <703e441c.88c.18ad5cf2bf1.Coremail.chenguohua@jari.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID: AQAAfwBn+D1O6xNlS_u9AA--.629W X-CM-SenderInfo: xfkh0w5xrk3tw6md2xgofq/1tbiAQAHEWUSpy8AOwArs4 X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following errors reported by checkpatch: ERROR: space prohibited before open square bracket '[' ERROR: space prohibited before that close parenthesis ')' ERROR: space prohibited after that open parenthesis '(' ERROR: "foo * bar" should be "foo *bar" Signed-off-by: GuoHua Cheng --- drivers/scsi/nsp32.h | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/nsp32.h b/drivers/scsi/nsp32.h index 924889f8bd37..5f275f3f1408 100644 --- a/drivers/scsi/nsp32.h +++ b/drivers/scsi/nsp32.h @@ -38,7 +38,7 @@ enum { MODEL_PCI_MELCO = 6, }; -static char * nsp32_model[] = { +static char *nsp32_model[] = { "I-O DATA CBSC-II CardBus card", "KME SCSI CardBus card", "Workbit duo SCSI CardBus card", @@ -99,7 +99,7 @@ typedef u16 u16_le; # define IRQ_CONTROL_ALL_IRQ_MASK (PCI_IRQ_MASK | \ TIMER_IRQ_MASK | \ FIFO_IRQ_MASK | \ - SCSI_IRQ_MASK ) + SCSI_IRQ_MASK) # define IRQSTATUS_ANY_IRQ (IRQSTATUS_RESELECT_OCCUER | \ IRQSTATUS_PHASE_CHANGE_IRQ | \ IRQSTATUS_SCSIRESET_IRQ | \ @@ -107,7 +107,7 @@ typedef u16 u16_le; IRQSTATUS_FIFO_SHLD_IRQ | \ IRQSTATUS_PCI_IRQ | \ IRQSTATUS_BMCNTERR_IRQ | \ - IRQSTATUS_AUTOSCSI_IRQ ) + IRQSTATUS_AUTOSCSI_IRQ) #define TRANSFER_CONTROL 0x02 /* BASE+02, W, W */ #define TRANSFER_STATUS 0x02 /* BASE+02, W, R */ @@ -171,7 +171,7 @@ typedef u16 u16_le; FIFO_HOST_POINTER_CLR | \ FIFO_REST_COUNT_CLR | \ BM_COUNTER_CLR | \ - SAVED_ACK_CLR ) + SAVED_ACK_CLR) #define SCSI_BUS_MONITOR 0x12 /* BASE+12, B, R */ # define BUSMON_MSG BIT(0) @@ -413,22 +413,22 @@ typedef u16 u16_le; * Useful Bus Monitor status combinations. */ #define BUSMON_BUS_FREE 0 -#define BUSMON_COMMAND ( BUSMON_BSY | BUSMON_CD | BUSMON_REQ ) -#define BUSMON_MESSAGE_IN ( BUSMON_BSY | BUSMON_MSG | BUSMON_IO | BUSMON_CD | BUSMON_REQ ) -#define BUSMON_MESSAGE_OUT ( BUSMON_BSY | BUSMON_MSG | BUSMON_CD | BUSMON_REQ ) -#define BUSMON_DATA_IN ( BUSMON_BSY | BUSMON_IO | BUSMON_REQ ) -#define BUSMON_DATA_OUT ( BUSMON_BSY | BUSMON_REQ ) -#define BUSMON_STATUS ( BUSMON_BSY | BUSMON_IO | BUSMON_CD | BUSMON_REQ ) -#define BUSMON_RESELECT ( BUSMON_IO | BUSMON_SEL) -#define BUSMON_PHASE_MASK ( BUSMON_MSG | BUSMON_IO | BUSMON_CD | BUSMON_SEL) - -#define BUSPHASE_COMMAND ( BUSMON_COMMAND & BUSMON_PHASE_MASK ) -#define BUSPHASE_MESSAGE_IN ( BUSMON_MESSAGE_IN & BUSMON_PHASE_MASK ) -#define BUSPHASE_MESSAGE_OUT ( BUSMON_MESSAGE_OUT & BUSMON_PHASE_MASK ) -#define BUSPHASE_DATA_IN ( BUSMON_DATA_IN & BUSMON_PHASE_MASK ) -#define BUSPHASE_DATA_OUT ( BUSMON_DATA_OUT & BUSMON_PHASE_MASK ) -#define BUSPHASE_STATUS ( BUSMON_STATUS & BUSMON_PHASE_MASK ) -#define BUSPHASE_SELECT ( BUSMON_SEL | BUSMON_IO ) +#define BUSMON_COMMAND (BUSMON_BSY | BUSMON_CD | BUSMON_REQ) +#define BUSMON_MESSAGE_IN (BUSMON_BSY | BUSMON_MSG | BUSMON_IO | BUSMON_CD | BUSMON_REQ) +#define BUSMON_MESSAGE_OUT (BUSMON_BSY | BUSMON_MSG | BUSMON_CD | BUSMON_REQ) +#define BUSMON_DATA_IN (BUSMON_BSY | BUSMON_IO | BUSMON_REQ) +#define BUSMON_DATA_OUT (BUSMON_BSY | BUSMON_REQ) +#define BUSMON_STATUS (BUSMON_BSY | BUSMON_IO | BUSMON_CD | BUSMON_REQ) +#define BUSMON_RESELECT (BUSMON_IO | BUSMON_SEL) +#define BUSMON_PHASE_MASK (BUSMON_MSG | BUSMON_IO | BUSMON_CD | BUSMON_SEL) + +#define BUSPHASE_COMMAND (BUSMON_COMMAND & BUSMON_PHASE_MASK) +#define BUSPHASE_MESSAGE_IN (BUSMON_MESSAGE_IN & BUSMON_PHASE_MASK) +#define BUSPHASE_MESSAGE_OUT (BUSMON_MESSAGE_OUT & BUSMON_PHASE_MASK) +#define BUSPHASE_DATA_IN (BUSMON_DATA_IN & BUSMON_PHASE_MASK) +#define BUSPHASE_DATA_OUT (BUSMON_DATA_OUT & BUSMON_PHASE_MASK) +#define BUSPHASE_STATUS (BUSMON_STATUS & BUSMON_PHASE_MASK) +#define BUSPHASE_SELECT (BUSMON_SEL | BUSMON_IO) /************************************************************************ @@ -597,7 +597,7 @@ typedef struct _nsp32_hw_data { /* message buffer */ unsigned char msgoutbuf[MSGOUTBUF_MAX]; /* msgout buffer */ char msgout_len; /* msgoutbuf length */ - unsigned char msginbuf [MSGINBUF_MAX]; /* megin buffer */ + unsigned char msginbuf[MSGINBUF_MAX]; /* megin buffer */ char msgin_len; /* msginbuf length */ } nsp32_hw_data;