From patchwork Fri Sep 29 07:43:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Shankar, Uma" X-Patchwork-Id: 13403811 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE1C7E743F3 for ; Fri, 29 Sep 2023 08:23:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D7CB10E58B; Fri, 29 Sep 2023 08:23:43 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA96F10E58B for ; Fri, 29 Sep 2023 08:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695975820; x=1727511820; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=LtHonzyhyUT4OUSjs8lMb9gxChXwrFCg9WKRMlTZRLQ=; b=TG4/aejQA6eTdwxyV8+MD2GmH3XoM65YFdPDBqgct+d5ek6seT2ErcAH KK77N29elAzpgxNjRn+wexAverVvqIWiRwSpz/IoVkrX1NGP341Iv4cXW QBkxjiLOCqQbFg4FEAZTrTNDaVZjoikstF/NrvL9in/6i9XVSmID2jQUc h1CHIukVNCBDdjln0W8zK6aVIyFAvpyPsYMhz4WwLVeaOrjNe0Pj/cu21 M7uW6dQXieN7PrbrovjIlG5mycR4aHxNgaNAhUNcIYVp74h8CJ+chlBlw 1EPcpVAktKYin9BjIJmuMXpdAHre7Zj4cxsE/qi0N7Lf8OXxII/eSHflA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="386115000" X-IronPort-AV: E=Sophos;i="6.03,186,1694761200"; d="scan'208";a="386115000" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 00:36:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="1080838405" X-IronPort-AV: E=Sophos;i="6.03,186,1694761200"; d="scan'208";a="1080838405" Received: from cfl-desktop.iind.intel.com ([10.190.239.20]) by fmsmga005.fm.intel.com with ESMTP; 29 Sep 2023 00:36:02 -0700 From: Uma Shankar To: intel-gfx@lists.freedesktop.org Date: Fri, 29 Sep 2023 13:13:06 +0530 Message-ID: <20230929074306.1533859-1-uma.shankar@intel.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Subject: [Intel-gfx] [v4] drm/i915/display: Created exclusive version of vga decode setup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Current vga arbiter implementation in i915 needs a re-design. The current approach would cause real problems if anyone actually needs to talk another GPU using legacy VGA resources. The main issue is that X becomes a slideshow if it thinks there are multiple GPUs that have VGA decoding enabled as it insists on adjusting the VGA routing pretty much for every little operation involving any of the GPUs. The cleanup will be planned for i915. Meanwhile to focus on Xe upstreaming and have a cleaner separation, the said functionality is being moved to a different file exclusive for i915. Xe driver will re-use rest of the display code from i915. v2: Addressed Jani Nikula's review comments. v3: Dropped a duplicate function (Jani) v4: Updated commit message with reasoning as sugested by Ville. Signed-off-by: Uma Shankar Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_vga.c | 18 +----------------- drivers/gpu/drm/i915/soc/intel_gmch.c | 14 ++++++++++++++ drivers/gpu/drm/i915/soc/intel_gmch.h | 2 ++ 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c index 286a0bdd28c6..4b98833bfa8c 100644 --- a/drivers/gpu/drm/i915/display/intel_vga.c +++ b/drivers/gpu/drm/i915/display/intel_vga.c @@ -3,11 +3,9 @@ * Copyright © 2019 Intel Corporation */ -#include #include #include