From patchwork Sat Sep 30 20:36:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13405201 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A31F633F6 for ; Sat, 30 Sep 2023 20:38:14 +0000 (UTC) Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21DA4DD; Sat, 30 Sep 2023 13:38:13 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2c27d653856so22064941fa.0; Sat, 30 Sep 2023 13:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696106291; x=1696711091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=legsvKyWWxyzmO1CVoext9AuacagNtz6wv7FLmewiU0=; b=cTylJgJ+3i1WG1rzMdUF4LL6XFVQWfAKkAFPpd8o2bG+ULlnfCrJmTA3XryopnSj8X Tx8ygudUQ5C8A2jIOV5vReH2gsHUMjRUziruB7ClzZhwTe440bkjuANfM0fZKNCoa3/A yGP1R2KRupHFYKUh/7iR+veGR0oyN9uPYEr1Hj/qTopJBmRCl719WhNJ75XgA/qW2X26 V2XNQRqV0TeQR7qJUsUGnBuyxtUi6IZmCOY28T/TIRn2J2Q+DY7D6woKY71mXYWhQR+/ cU+9fumVYRmM80MlXfEWE9PKMxGmrjTIQG5TkTAGL2iJGJ3YJ8zYJH5JYe+hiZ9dG6LH MDcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696106291; x=1696711091; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=legsvKyWWxyzmO1CVoext9AuacagNtz6wv7FLmewiU0=; b=oLTnlLJSOHwnarCLnrsnDxprmK6v7Sd2XNjY7Pb3lYk0RRQJCVYqPFIr7Ag0R0PJUj MlStD1guzAWDZRNLQa8GPIHpVk6zDSQER6/8hKb8RFR/4GQp9jQKzJkiZ/narNNAy34r cXS0YaN57tUw6fQZVHqzriXsAyibQdycchaOIzBSkY/mPetgDvBA2aepLpqnJl0S4XnL zLoYM1hAT7EcVVqPh3fkkD9WWqnQFieVsbG7Cyi/ySEoSrI+u2ZMM4axNY/eNd4zlYY1 bar8jK2UDWoolFNCk+MFZZHXufhYTDi6vkck7MIP+01tsY901FnVBbMjm8TIVupfox83 LEug== X-Gm-Message-State: AOJu0YxCLaLn4cUbIJU581fcmlENTfZQOxjWzMkoLv8GPU7E1j1SHMbM g+/RtuSWlScZJn0i6UT2jWrIuPEm0/dhcg== X-Google-Smtp-Source: AGHT+IFQXfgKYyvhsUungqr9rgZDXEe1m1XyQgXJ/ZkVNwWnci64sDZft8ZfIRGkJ6o2oMpG4FRx3w== X-Received: by 2002:a2e:a4d6:0:b0:2bf:f90e:2794 with SMTP id p22-20020a2ea4d6000000b002bff90e2794mr6445483ljm.23.1696106290784; Sat, 30 Sep 2023 13:38:10 -0700 (PDT) Received: from HP-ENVY-Notebook.lan (81-229-94-10-no68.tbcn.telia.com. [81.229.94.10]) by smtp.googlemail.com with ESMTPSA id d8-20020a2eb048000000b002ba7ae1f52asm4654499ljl.0.2023.09.30.13.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 13:38:10 -0700 (PDT) From: Jonathan Bergh To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 1/3] drivers: usb: Fix block comments whose trailing */ was not on a separate line Date: Sat, 30 Sep 2023 22:36:46 +0200 Message-Id: <20230930203646.61863-1-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Fixed various instances where block comments trailing */ where not on a separate line and should be. Signed-off-by: Jonathan Bergh --- drivers/usb/atm/cxacru.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index 4ce7cba2b48a..ba795a8d3888 100644 --- a/drivers/usb/atm/cxacru.c +++ b/drivers/usb/atm/cxacru.c @@ -55,7 +55,8 @@ static const char cxacru_driver_name[] = "cxacru"; #define POLL_INTERVAL 1 /* secs */ /* commands for interaction with the modem through the control channel before - * firmware is loaded */ + * firmware is loaded + */ enum cxacru_fw_request { FW_CMD_ERR, FW_GET_VER, @@ -67,7 +68,8 @@ enum cxacru_fw_request { }; /* commands for interaction with the modem through the control channel once - * firmware is loaded */ + * firmware is loaded + */ enum cxacru_cm_request { CM_REQUEST_UNDEFINED = 0x80, CM_REQUEST_TEST, @@ -369,7 +371,8 @@ static ssize_t adsl_state_store(struct device *dev, /* Line status is only updated every second * and the device appears to only react to * START/STOP every second too. Wait 1.5s to - * be sure that restart will have an effect. */ + * be sure that restart will have an effect. + */ if (!strcmp(str_cmd, "restart")) msleep(1500); @@ -1237,7 +1240,8 @@ static void cxacru_unbind(struct usbatm_data *usbatm_instance, BUG_ON(instance->poll_state == CXPOLL_SHUTDOWN); /* ensure that status polling continues unless - * it has already stopped */ + * it has already stopped + */ if (instance->poll_state == CXPOLL_STOPPED) is_polling = 0; From patchwork Sat Sep 30 20:38:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13405202 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43E59138E for ; Sat, 30 Sep 2023 20:38:47 +0000 (UTC) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 857DDC4; Sat, 30 Sep 2023 13:38:44 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50308217223so23362042e87.3; Sat, 30 Sep 2023 13:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696106323; x=1696711123; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rW993Rk+us1RS2s1pFY5qGoKza1E2XLS3Abi4keOId0=; b=ArRPf2Utr6fD3STr3sEvC6cxzGeLTDNxPMZ6542Rk9G6xhiDoVbaiP1CU1HAlMyB1p UnYYgswYUGaodebDoSh6Doq+ScCJItZ0TqUsWKv6WQVOaSX2jFqWvvqVW1WzW8tCte7z ZQxcncIr97kVN0SHocwMdCs9ZFh5iVnAA17tEYr+2HFpjJ9RxwDM8/WcTgzeAlU9EN1n dHBbJ0AEdEG7GpfcPZYL1i8FzZvzJcgdxk2zRNDO/8ILOXSa/LwpZR9vcfSGjCn3pWLF pHqKYyc8GohkrelUOwj0KVyLGLTYVYXcL9KQWO5aY2Izm3dM5ZAND2I9ShvqRsEzgOow 1lsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696106323; x=1696711123; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rW993Rk+us1RS2s1pFY5qGoKza1E2XLS3Abi4keOId0=; b=mM2LCIfsuYuF+0O93iZCxn8G0HM2mffLzlC1+H2OV/vjDijRbLSbhqp6tAwF4h0Xcu pXBeuEFwysD+B7puNfsNAQY8Htv+N3ZFxM9pQJF08090OLzhxiXawl1iuibFL73SZ56M cRyvNu8oD+km3UjGO79MeLda1HrwfsYmrwW1ifIcArOSVIUHU2MqS+YdaRKJ6qJM+p1m OU4wPETDiaesuH71TZT9OQcWqdnD0o9OgG0PxF7q2r32mxQwEOhJnpj5v+3hxtwvteQn gd2AVBS6h8/mrNWjWRXUztsJ0F04k3NRmzZfjq38DeAuUZP4+d7CJmYz8pxp/dXu4Cir 7n+g== X-Gm-Message-State: AOJu0Ywn4i/91toxdvYWHyTT4nrDNUqQrUSgmK+EwIqHwtQc5pRG/TW5 bw7lrMPoBCupmzAdBMTyzXO5eBb2MUoHHQ== X-Google-Smtp-Source: AGHT+IGt7I0eKG+q25Ok/cEgz+Jsu9oElR0Jj91NbCmBaC80OrAuZCuK9OQueNxi+1nW2dFx5Yg8nQ== X-Received: by 2002:a05:6512:3095:b0:500:94c5:6e06 with SMTP id z21-20020a056512309500b0050094c56e06mr7294226lfd.56.1696106322331; Sat, 30 Sep 2023 13:38:42 -0700 (PDT) Received: from HP-ENVY-Notebook.lan (81-229-94-10-no68.tbcn.telia.com. [81.229.94.10]) by smtp.googlemail.com with ESMTPSA id t6-20020a19ad06000000b00502d7365e8fsm1656082lfc.137.2023.09.30.13.38.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 13:38:41 -0700 (PDT) From: Jonathan Bergh To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 2/3] drivers: usb: Fix issue where *'s in multiline comments were not aligned Date: Sat, 30 Sep 2023 22:38:19 +0200 Message-Id: <20230930203819.61891-1-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Fix formatting issue where *'s in multiline comments were not aligned and should be. Signed-off-by: Jonathan Bergh --- drivers/usb/atm/usbatm.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/atm/usbatm.h b/drivers/usb/atm/usbatm.h index d96658e2e209..500c91b418e4 100644 --- a/drivers/usb/atm/usbatm.h +++ b/drivers/usb/atm/usbatm.h @@ -65,10 +65,10 @@ struct usbatm_data; /* -* Assuming all methods exist and succeed, they are called in this order: -* -* bind, heavy_init, atm_start, ..., atm_stop, unbind -*/ + * Assuming all methods exist and succeed, they are called in this order: + * + * bind, heavy_init, atm_start, ..., atm_stop, unbind + */ struct usbatm_driver { const char *driver_name; From patchwork Sat Sep 30 20:38:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13405203 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56C6F156DF for ; Sat, 30 Sep 2023 20:39:07 +0000 (UTC) Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68790EB; Sat, 30 Sep 2023 13:39:05 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2c12fc235fbso22919201fa.0; Sat, 30 Sep 2023 13:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696106343; x=1696711143; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5cerKNWvS8XiVyEtmI4Mu62KK5k+ONMdTROPcJPxoeU=; b=M0Wo/fLNRePtib6grY1YIO1GJjP/EvB5QOGLsGR2HkrImSRoRHZpTcnPy57/DWisCs Kc47X+1zYzfQGgjMMQtmSYc/pviCv5WAQ2T3wvW/WNGBNtdIgglgzrJ5MN/qs6LMjKNv L9q+dZdf0QLMG/64GmbGPFUEpPb87rDOCqWMQTmSov1MB/tb49vl+sfPuUMiYVsz18Em ro8VOJMymHzYiTaSwL6JrHOK58oox0XHqCz/TX4fnyf+vL6ZOuJjc2+EkG/OwI5eYFwK 1b0d0VaqzYmZ9+UOItadR6IaG0vBjUtqstMX3/x9YZrAP+DeH+bKfgwSMJxwo5YOn4uv 2EOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696106343; x=1696711143; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5cerKNWvS8XiVyEtmI4Mu62KK5k+ONMdTROPcJPxoeU=; b=jNkGtRSMJKxl2b9l8h0yoJDidrivZ4BsvaIbXz/yXNZOnko2vndtNMnByWkOo7S/0m 2r7euubC+Klp8ttiwNhpdCOMG/rIBcmGO12aVFdtvFyS33KBLgGnT9fmwJRcUBi5/vcn 8NYHN/O/KS40zTI6fElJY55pM34UZEQrchE+4F9h/Z1BRI6jeJwLR442O3NC9SSfCqug IOgVj9LNgV2JIq2i2HWwN61htJOVv7NAwlcdjgf69DeFr7dXw26S1G1/L/gVK9uJKC+5 eHhb4RNlABxXDoey3TMwLP2C0pwTUqitq/BEV6fEUyxzjqx/zAqjrpvg3xOey2PbeXl8 DErg== X-Gm-Message-State: AOJu0YxqDWalN1OQjfhnbUQwyd1Jp1K9MpPGwq6zJQR3BY2LegT/IZP4 GXjWZF933EGQ27ioR4SI7Mk= X-Google-Smtp-Source: AGHT+IGB6KYoBU4XTvyWWjQrE+XbD23Dh0jKU/XIEWPyceNspe4d+02zxdquntYKzL5qCHiOTc35Bg== X-Received: by 2002:a05:651c:105:b0:2bc:bc6f:e296 with SMTP id a5-20020a05651c010500b002bcbc6fe296mr6645396ljb.13.1696106343408; Sat, 30 Sep 2023 13:39:03 -0700 (PDT) Received: from HP-ENVY-Notebook.lan (81-229-94-10-no68.tbcn.telia.com. [81.229.94.10]) by smtp.googlemail.com with ESMTPSA id d3-20020a2eb043000000b002c017a56a1asm4579579ljl.70.2023.09.30.13.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 13:39:03 -0700 (PDT) From: Jonathan Bergh To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 3/3] drivers: usb: Remove unnecessary spaces before function pointer arguments Date: Sat, 30 Sep 2023 22:38:51 +0200 Message-Id: <20230930203851.61914-1-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Fixed formating error where unnecessary spaces were included before function pointer arguments and was flagged as a checkpatch issue. Signed-off-by: Jonathan Bergh --- drivers/usb/atm/usbatm.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/atm/usbatm.h b/drivers/usb/atm/usbatm.h index 500c91b418e4..5b1719a58959 100644 --- a/drivers/usb/atm/usbatm.h +++ b/drivers/usb/atm/usbatm.h @@ -74,20 +74,20 @@ struct usbatm_driver { const char *driver_name; /* init device ... can sleep, or cause probe() failure */ - int (*bind) (struct usbatm_data *, struct usb_interface *, + int (*bind)(struct usbatm_data *, struct usb_interface *, const struct usb_device_id *id); /* additional device initialization that is too slow to be done in probe() */ - int (*heavy_init) (struct usbatm_data *, struct usb_interface *); + int (*heavy_init)(struct usbatm_data *, struct usb_interface *); /* cleanup device ... can sleep, but can't fail */ - void (*unbind) (struct usbatm_data *, struct usb_interface *); + void (*unbind)(struct usbatm_data *, struct usb_interface *); /* init ATM device ... can sleep, or cause ATM initialization failure */ - int (*atm_start) (struct usbatm_data *, struct atm_dev *); + int (*atm_start)(struct usbatm_data *, struct atm_dev *); /* cleanup ATM device ... can sleep, but can't fail */ - void (*atm_stop) (struct usbatm_data *, struct atm_dev *); + void (*atm_stop)(struct usbatm_data *, struct atm_dev *); int bulk_in; /* bulk rx endpoint */ int isoc_in; /* isochronous rx endpoint */