From patchwork Mon Oct 2 16:13:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomer Maimon X-Patchwork-Id: 13406451 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AC2C1D6B1; Mon, 2 Oct 2023 16:14:00 +0000 (UTC) Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01hn2213.outbound.protection.outlook.com [52.100.0.213]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7161D9; Mon, 2 Oct 2023 09:13:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W/bczq0MGh9MD9UNLVGWvDorNrNBNyo47FfR4/73MwMM3xpF1S5mqIVgL0EAx0/eHr5oDmcV0YntlbWOv8gPr5kjEQOE/y+s4hHKFQCnde75Lr++/ZXWM/czRyZmrZj8qTxzaRqxT29dnx0FPcsmIWr7G7X2uSjIFbQ4Ha3xuqMvBvQtqqzm1YogXnq9jXCXcc+fQfCtoH2ZuJmHUCkQMMjxtiBFisFs3BtuB5XdbBtmWi3Xg+GaK/Yz/l0PhnIuori9KilQ8BTqlNfTdCb3nB+H3Lkk67w4F3HyDfWHdHQfuULuMj3JDKYTvymK5eHR3rqoBg96nNLTEwZL4hnAew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HJPlBtL4X/T/9aSDc4JYtiVWMLfmJVy5DVI0D2TM3mA=; b=QGqIb+ulg6ynp1k1VGKKMZTc0JV+FuhiPgkW8HFDjervTDC5atiYPWeuIEqsKm1lFhlhJKtUedphSFJXQXpzK3+lnrrFb0eopbiA0TiP1RIO0xJ4p4f7Ia1RxH6tMv+ghcAfp8oc695dngLHEA1NahpZzlK0yLR7Gildq2qFrPw0WIxyBNUFPJ1XI2YJSdl8DFs48NwYXsl/m21ZW8AboiRXxLUgVdwRHRLv9kb9yo910r+J9aYs3Cp6+mZua4aq876sSrhc6cUT3H4dwmqMKR/e6PZ00YVYptZmNiI1WP9u8rNACPAPvm96EYI5odyiMuzcWtglIv0/PuEoNxtTSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 211.75.126.7) smtp.rcpttodomain=gmail.com smtp.mailfrom=nuvoton.com; dmarc=fail (p=none sp=quarantine pct=100) action=none header.from=gmail.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuvoton.onmicrosoft.com; s=selector2-nuvoton-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HJPlBtL4X/T/9aSDc4JYtiVWMLfmJVy5DVI0D2TM3mA=; b=W4UTtAzVUNbnpy6/iU1ryxnOyNNs9FdX+9xATiHJeRCul/2e5F86hMPa/JoTZRqgVV57BoS+nRozp2K3IhiYyWpqlA7NvdQKgj2CV6bX1kgvtsttMhsZWZpkOxDPMEHiV4plMRIfnFEl3GaVad+UBaFaed6nXF28JHycDia1uWw= Received: from SG2PR02CA0039.apcprd02.prod.outlook.com (2603:1096:3:18::27) by TYZPR03MB7956.apcprd03.prod.outlook.com (2603:1096:400:44d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.28; Mon, 2 Oct 2023 16:13:55 +0000 Received: from SG2PEPF000B66CD.apcprd03.prod.outlook.com (2603:1096:3:18:cafe::5c) by SG2PR02CA0039.outlook.office365.com (2603:1096:3:18::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.30 via Frontend Transport; Mon, 2 Oct 2023 16:13:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 211.75.126.7) smtp.mailfrom=nuvoton.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=gmail.com; Received-SPF: Pass (protection.outlook.com: domain of nuvoton.com designates 211.75.126.7 as permitted sender) receiver=protection.outlook.com; client-ip=211.75.126.7; helo=NTHCCAS01.nuvoton.com; pr=C Received: from NTHCCAS01.nuvoton.com (211.75.126.7) by SG2PEPF000B66CD.mail.protection.outlook.com (10.167.240.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6838.19 via Frontend Transport; Mon, 2 Oct 2023 16:13:54 +0000 Received: from NTHCML01A.nuvoton.com (10.1.8.177) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Oct 2023 00:13:54 +0800 Received: from NTHCCAS01.nuvoton.com (10.1.8.28) by NTHCML01A.nuvoton.com (10.1.8.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 3 Oct 2023 00:13:53 +0800 Received: from taln60.nuvoton.co.il (10.191.1.180) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 3 Oct 2023 00:13:53 +0800 Received: by taln60.nuvoton.co.il (Postfix, from userid 10070) id 7A8F364741; Mon, 2 Oct 2023 19:13:52 +0300 (IDT) From: Tomer Maimon To: , , , , , , , , , , , , CC: , , , , Tomer Maimon Subject: [PATCH RESEND v3 1/3] usb: chipidea: add CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS flag Date: Mon, 2 Oct 2023 19:13:48 +0300 Message-ID: <20231002161350.64229-2-tmaimon77@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20231002161350.64229-1-tmaimon77@gmail.com> References: <20231002161350.64229-1-tmaimon77@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NotSetDelaration: True X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG2PEPF000B66CD:EE_|TYZPR03MB7956:EE_ X-MS-Office365-Filtering-Correlation-Id: abac2114-8589-4f04-75e6-08dbc362935e X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qQeSiRa85Vzjt6zJwKiGp+BybZjeRv40yoraAds15JBemtiKuWHEdEEqH3fTQNCQf6lJCjvpHJx1a1Mfxbqt9DYSrMDPpArq68hAsOTLETuCDKJA3INseARymaqqcKCjp4n/zNs2E3juKShKP3poFfd0Desza9PFjFjWh/bQlN6XCyttszgYjF+YGQdFtvSrmT7pBjoz2oIyLWgXvOwIIOef2Y7U5wdTRTexbZOXWJb/LJ5M7ShU1F4upbStWBdEKeqPnmXX5Zrg4Va3Ntk2ZfiGmUrJi5F0oZuANnXZ5ya4hWHWCT31IHOa1tXqMfG8911eAluEV+rVy1+Q6otr5PzuJ+FUOHbx3KIKyXI2XDfhpjGaio6fqEGsns+ntitD26aLwu1usUrD8RkJ4w7ihHkShm+aOgWsRd2zdXK+J0zvd8q4lYDIZ9QqLs5M7LGQ1KAAcMVN+Sr0kWInr6lCGNo+QE+B1dermmfdgLQaCv2EWee1D+E+0zviipKeSr/FiD+yr2OzAesdi96QLUDfUHKvuuNDmryKhLZmDJALXCKQAIO3TqSj1FQh4llnIJghGzhSqfntuX1wsZCwZxf1/6MsmJAbM2OdhSXPj2QZTs3u4s8MbbjXPvhKIl8a2JEyJk9kEds4JbA6ugBZDBkJwCWxAY5gS8cFfiGa3h44EfuZ7d8/mXlr3iQBkcOmQsSbXWEezeHQGAOQvNnfXTm6bW56Ty85tDNMWQrOCGRW1iSMSlKhibCwPvFQ1G426S7AvFiYb+TwQMHN6j9b1FooIOI9PfWxaN5XKwqpH1rfREBTLkXAiYly5PyXmNtjh1RViH2lItqBMv0BlsCyounggYoRbFPjfhFErwxD0Ka/VJK2EWjc1wqybVL8xqJejgMufAPOVuuFjQ14O31oibW5aK9vpfM3tDoJ/S6Bpd5pPbpK++fGn1sl4gDWR6QJ0QrFsuHFbvkQF6HpzuYAOSbL3yAj/oks6ikV9cJZLhWh08I= X-Forefront-Antispam-Report: CIP:211.75.126.7;CTRY:TW;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:NTHCCAS01.nuvoton.com;PTR:211-75-126-7.hinet-ip.hinet.net;CAT:NONE;SFS:(13230031)(4636009)(346002)(376002)(39860400002)(396003)(136003)(230922051799003)(64100799003)(451199024)(5400799018)(82310400011)(186009)(61400799006)(48200799006)(40470700004)(46966006)(36840700001)(40460700003)(316002)(5660300002)(83380400001)(2906002)(41300700001)(40480700001)(42186006)(8936002)(70206006)(4326008)(8676002)(36756003)(2616005)(54906003)(6666004)(55446002)(76482006)(26005)(82202003)(7416002)(6266002)(82740400003)(356005)(336012)(73392003)(1076003)(83170400001)(42882007)(921005)(36860700001)(70586007)(81166007)(478600001)(110136005)(47076005)(34020700004)(45356006)(84790400001)(35450700002)(12100799045);DIR:OUT;SFP:1501; X-OriginatorOrg: nuvoton.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 16:13:54.8615 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: abac2114-8589-4f04-75e6-08dbc362935e X-MS-Exchange-CrossTenant-Id: a3f24931-d403-4b4a-94f1-7d83ac638e07 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a3f24931-d403-4b4a-94f1-7d83ac638e07;Ip=[211.75.126.7];Helo=[NTHCCAS01.nuvoton.com] X-MS-Exchange-CrossTenant-AuthSource: SG2PEPF000B66CD.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB7956 X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Adding CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS flag to modify the vbus_active parameter to active in case the ChipIdea USB IP role is device-only and there is no otgsc register. Signed-off-by: Tomer Maimon Acked-by: Peter Chen --- drivers/usb/chipidea/otg.c | 5 ++++- include/linux/usb/chipidea.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c index f5490f2a5b6b..647e98f4e351 100644 --- a/drivers/usb/chipidea/otg.c +++ b/drivers/usb/chipidea/otg.c @@ -130,8 +130,11 @@ enum ci_role ci_otg_role(struct ci_hdrc *ci) void ci_handle_vbus_change(struct ci_hdrc *ci) { - if (!ci->is_otg) + if (!ci->is_otg) { + if (ci->platdata->flags & CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS) + usb_gadget_vbus_connect(&ci->gadget); return; + } if (hw_read_otgsc(ci, OTGSC_BSV) && !ci->vbus_active) usb_gadget_vbus_connect(&ci->gadget); diff --git a/include/linux/usb/chipidea.h b/include/linux/usb/chipidea.h index 0b4f2d5faa08..5a7f96684ea2 100644 --- a/include/linux/usb/chipidea.h +++ b/include/linux/usb/chipidea.h @@ -64,6 +64,7 @@ struct ci_hdrc_platform_data { #define CI_HDRC_PMQOS BIT(15) #define CI_HDRC_PHY_VBUS_CONTROL BIT(16) #define CI_HDRC_HAS_PORTSC_PEC_MISSED BIT(17) +#define CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS BIT(18) enum usb_dr_mode dr_mode; #define CI_HDRC_CONTROLLER_RESET_EVENT 0 #define CI_HDRC_CONTROLLER_STOPPED_EVENT 1 From patchwork Mon Oct 2 16:13:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomer Maimon X-Patchwork-Id: 13406452 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12CED1DA3A; Mon, 2 Oct 2023 16:14:00 +0000 (UTC) Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01hn2244.outbound.protection.outlook.com [52.100.0.244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB0A7DA; Mon, 2 Oct 2023 09:13:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAbDCpXfmKq2UfqBew0S4vSkzw5wv+IAhIVf9ROCSZoP94guKulHljHOySJ70RI523xU0YW2Ry6WfRq0UO/9GB/iIQ5hbnHZjJ0bZMc+4gMNYZQbOiXcS/vjVwoCrbVw3uIcxVuIIlcfCPsMKRjAkmpyMVljVSp1ofseu1NZPdeCx+o2H/EDiYX6MEUjl+C8BsSgkYf+fooQF89VGNLSPL4EAOqKGlJGqtHgC3p86bD1pzgbAHsisTA4sESKXMlx44HNj+byYxASzjFErmS4T6WxiQSyjMOIAfz0c4qX4Gz7mshmF+fG6Iu1LZ6ATMtpFsGmUgHaZJz1n8MdtfCKvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HhbXqOJR79u+/b1TOeqh2Q568aPZn+33VQAaeCzrrDc=; b=PkmidZibhJMbitNePyFBaodswDWf3ATkFOopwTC2SN6rNe5I67cFMbdvZ9SmrNIYCURpEmtuqmk5uKFxKpycRHTnDYOx2owAD/W6W87eExj5QF7ExoEfO7jd9N5TN4uPs31yZUwAmrUeGc0/u+E/8y++9c+2/iD4fdt5sIuaHvrpTaJue/xCVrRjozoUc+G0ODu5gpnK7IcCn/nEvGJf5jfUXjRiSRDWyoJwXe0oJBAPctah2djY9nKwNekMxIfw853vAIaRZCsFRcxmI9sGl4lUtKFT5n+vn+YJdsh5nplTiM3dnFLo/lNOiB672zpSX7QS5Lqzlv00npAYd9F5Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 175.98.123.7) smtp.rcpttodomain=gmail.com smtp.mailfrom=nuvoton.com; dmarc=fail (p=none sp=quarantine pct=100) action=none header.from=gmail.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuvoton.onmicrosoft.com; s=selector2-nuvoton-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HhbXqOJR79u+/b1TOeqh2Q568aPZn+33VQAaeCzrrDc=; b=jgFd/MMO9fBC4PvrpGtvVQNUsgX9q4fgGYC34C+xg/3tPD/LbypXKVqzI6aitChtowHEHBzxSWx8MBr3qeFol378HlA+pkyTRsyjUclMGGz4xZ0Bl7U0qXqiCAwomSUHGb782b3x0Zm1uJqnOOD3sf0VoyhNA3kGgqvBMdXVLxQ= Received: from SG2PR02CA0030.apcprd02.prod.outlook.com (2603:1096:3:18::18) by SI2PR03MB6439.apcprd03.prod.outlook.com (2603:1096:4:1a2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.24; Mon, 2 Oct 2023 16:13:54 +0000 Received: from SG1PEPF000082E3.apcprd02.prod.outlook.com (2603:1096:3:18:cafe::f3) by SG2PR02CA0030.outlook.office365.com (2603:1096:3:18::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.33 via Frontend Transport; Mon, 2 Oct 2023 16:13:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 175.98.123.7) smtp.mailfrom=nuvoton.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=gmail.com; Received-SPF: Pass (protection.outlook.com: domain of nuvoton.com designates 175.98.123.7 as permitted sender) receiver=protection.outlook.com; client-ip=175.98.123.7; helo=NTHCCAS04.nuvoton.com; pr=C Received: from NTHCCAS04.nuvoton.com (175.98.123.7) by SG1PEPF000082E3.mail.protection.outlook.com (10.167.240.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.6838.14 via Frontend Transport; Mon, 2 Oct 2023 16:13:54 +0000 Received: from NTHCCAS01.nuvoton.com (10.1.8.28) by NTHCCAS04.nuvoton.com (10.1.8.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.14; Tue, 3 Oct 2023 00:13:53 +0800 Received: from taln60.nuvoton.co.il (10.191.1.180) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 3 Oct 2023 00:13:53 +0800 Received: by taln60.nuvoton.co.il (Postfix, from userid 10070) id 8678464742; Mon, 2 Oct 2023 19:13:52 +0300 (IDT) From: Tomer Maimon To: , , , , , , , , , , , , CC: , , , , Tomer Maimon Subject: [PATCH RESEND v3 2/3] dt-bindings: usb: ci-hdrc-usb2: add npcm750 and npcm845 compatible Date: Mon, 2 Oct 2023 19:13:49 +0300 Message-ID: <20231002161350.64229-3-tmaimon77@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20231002161350.64229-1-tmaimon77@gmail.com> References: <20231002161350.64229-1-tmaimon77@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NotSetDelaration: True X-EOPAttributedMessage: 0 X-MS-Exchange-SkipListedInternetSender: ip=[175.98.123.7];domain=NTHCCAS04.nuvoton.com X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG1PEPF000082E3:EE_|SI2PR03MB6439:EE_ X-MS-Office365-Filtering-Correlation-Id: af2a3897-5529-4e03-7a89-08dbc362931c X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k5WP50EDARRw1Dwe/ppDhQ5hnzYhj7ZQSBZ4IwGRqhQGuYzvesm7JpVMoLRamVAeo54jInhXveH22iTsm6WMglBIp4A5UEwfbHsug16PlR4rE5uMkmRpMUaECzijUfRwWWporirBimA3ifwlEGg0188wPEgnZJC12w1ekZimqepeS9hqX44Lb62XGQ/jFPiHGCyAzghwfvBZRig6Vz13m/u72LiKgkdKEFmfPmJWxXqMTx8xYaz5/UO41sGnjORCpkx0N4hLhnfbDx5W6q2X4TThc6WD+HzhErhVaCEQHkJrMMcPSjdhcrr5VwzWqUKHkERF2dAmMxtJ7G3Y8q3QInRjQURLORDiAgKYeD689WRn/BI4rpOGVfWM1mCtaZDIrwo6eVo+CePpAjeibV5vypCK4xXYxxJIv9FuhOltB16qijU2y8en1jj3pIVmzRLXwfq1RBABgiLVMg+x2U0hMD6ivOP7KIJw4WlFkWsb9qzSxcWWuiO0xy1Xevy+9A28iSmG52uyViUKvDwtj8QhqWhCw0fuca0ukZcAhuOxZw3AR/I3pTz6U78WEHfsOqYSyGQDKngRx6x5+rapgvTj9Mo/gT1jLnhqSDjC+TJJ44hbIPSyWVtnvXsM1Lae0ir8fA++c1GOeeLysc7Zt/39mRBEJUhmsLJGRlsq68aDeMSPSF8nQ46ibEUvjjehCcGJEY3cJaUVh72BoHydG7nNib4baGIMZH2oIbw3FcSwkpt9WtvWPduK4MPfb0OzAEp15KbzGtY0IPGezZ4795kSY3Np5+t4/UXuWBbbJZbS7WP4vIiFMaJ3nbvoVkpif1H66O8IAqwxEgpEDxLX7ag9D8C2opzGuMAfmnFMgreFs8ufelooVK+M8KLllUEfj6JFaMMhIiNpIcU6B9tOnuoWcBJAyCjkWjNh75LPYTiRM8lFo5umzW6cnrdGXzlx4kXDddnRRdHUFRZMhzMd7ZkcRWplkaSy56n3pwzv6M0a/no= X-Forefront-Antispam-Report: CIP:175.98.123.7;CTRY:TW;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:NTHCCAS04.nuvoton.com;PTR:175-98-123-7.static.tfn.net.tw;CAT:NONE;SFS:(13230031)(4636009)(376002)(346002)(396003)(136003)(39860400002)(230922051799003)(48200799006)(61400799006)(82310400011)(64100799003)(451199024)(5400799018)(186009)(36840700001)(40470700004)(46966006)(316002)(54906003)(70206006)(8676002)(70586007)(41300700001)(76482006)(4744005)(47076005)(8936002)(7416002)(336012)(2616005)(73392003)(6666004)(478600001)(42882007)(1076003)(82202003)(5660300002)(42186006)(26005)(6266002)(4326008)(110136005)(356005)(83170400001)(82740400003)(81166007)(34020700004)(55446002)(36756003)(921005)(36860700001)(2906002)(40460700003)(40480700001)(45356006)(84790400001)(35450700002)(12100799045);DIR:OUT;SFP:1501; X-OriginatorOrg: nuvoton.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 16:13:54.4290 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af2a3897-5529-4e03-7a89-08dbc362931c X-MS-Exchange-CrossTenant-Id: a3f24931-d403-4b4a-94f1-7d83ac638e07 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a3f24931-d403-4b4a-94f1-7d83ac638e07;Ip=[175.98.123.7];Helo=[NTHCCAS04.nuvoton.com] X-MS-Exchange-CrossTenant-AuthSource: SG1PEPF000082E3.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR03MB6439 X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Add a compatible string for Nuvoton BMC NPCM750 and Nuvoton BMC NPCM845. Signed-off-by: Tomer Maimon --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml index 1394557517b1..a9e173432002 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml @@ -16,6 +16,8 @@ properties: - enum: - chipidea,usb2 - lsi,zevio-usb + - nuvoton,npcm750-udc + - nuvoton,npcm845-udc - nvidia,tegra20-ehci - nvidia,tegra20-udc - nvidia,tegra30-ehci @@ -388,6 +390,8 @@ allOf: enum: - chipidea,usb2 - lsi,zevio-usb + - nuvoton,npcm750-udc + - nuvoton,npcm845-udc - nvidia,tegra20-udc - nvidia,tegra30-udc - nvidia,tegra114-udc From patchwork Mon Oct 2 16:13:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomer Maimon X-Patchwork-Id: 13406453 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 555741DA41; Mon, 2 Oct 2023 16:14:02 +0000 (UTC) Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01hn2231.outbound.protection.outlook.com [52.100.223.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 768B994; Mon, 2 Oct 2023 09:14:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TTGEpg2ap/ngFDkC78gN87eBP+UEtORc1Tb1UvDhjiKYY/rXYkTHhLJlVcuOd94shTRMpOpN4LJ80zKsvbunY5y7w5alF0SYmcvwDk3KPY94JCe3nJ4Z4FVz8OEqgrl9mvZNWZWRHRkSjZ3PN/0QQOea6//4rCbDeDY4JhTZiZYVKkK6rYaiIx0Jhd5A/Yc+S7WFRMQPK9+KkBlUiDeSQ8tdxp2OQRdQ3uBGsSrC4Haz6BNijohWgttJi+69eTECxPDEMJBb7HUn01nos4WxogCtd3eHQYaqVxe9z2NiZIpQRFOqUDCPnGTkbR3iD2kWeHBvN1iRx4iDG/Dmwcs5gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PqdhpXuqvc/cGbndu9wJ6COlL/RiDHNa5WUr+9UxfMg=; b=SSxdlO50cNzFAJiIwCvZQwWMMY6cxE92muaI5SnwQxWC5BDCQ3O/regCAUWySDPnWNtjtocCtPIgsbi92zooKG2Dhhjm3U2+4oZcW259hf+b8Vlfya5Mois+UIgPI/Sz18AEVSJZOqw3QQ5tFG2g4R7xq1yejceAGt9L2JVXL9M6vrSyWq6vB84rbrAdCGIDjOgyMizZXwl/FmTPOT8E0Mre1iU7O2kVWB/VCsD4Nj7NYUvZOrdH06kYDZiw+GNxcWC2OFb+DjnLlH2oPee23j91kWnorO8glqox/WJtDuSPoT17D1Zq+bf6OgZVRMEog68BA1PhFvYRZLd3TaOfJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 175.98.123.7) smtp.rcpttodomain=gmail.com smtp.mailfrom=nuvoton.com; dmarc=fail (p=none sp=quarantine pct=100) action=none header.from=gmail.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuvoton.onmicrosoft.com; s=selector2-nuvoton-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PqdhpXuqvc/cGbndu9wJ6COlL/RiDHNa5WUr+9UxfMg=; b=Zpym6puI/IQm2mlBej+4B0cb4H3q5gaYaoM312yDbvVNlyqQ/3cJXI6EA+YhHbrhJkhF3wtdff42P5aX87GD8iYJUbLrQpa9Xkss1SBFhalvVrgiJUWkQP2p7AtcE3h38yZ4on78Pn6set4hVe77MTEfEqq+0T3JvlK35+LHqPc= Received: from SG2PR02CA0048.apcprd02.prod.outlook.com (2603:1096:3:18::36) by PSAPR03MB5525.apcprd03.prod.outlook.com (2603:1096:301:65::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.29; Mon, 2 Oct 2023 16:13:55 +0000 Received: from SG1PEPF000082E3.apcprd02.prod.outlook.com (2603:1096:3:18:cafe::97) by SG2PR02CA0048.outlook.office365.com (2603:1096:3:18::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.31 via Frontend Transport; Mon, 2 Oct 2023 16:13:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 175.98.123.7) smtp.mailfrom=nuvoton.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=gmail.com; Received-SPF: Pass (protection.outlook.com: domain of nuvoton.com designates 175.98.123.7 as permitted sender) receiver=protection.outlook.com; client-ip=175.98.123.7; helo=NTHCCAS04.nuvoton.com; pr=C Received: from NTHCCAS04.nuvoton.com (175.98.123.7) by SG1PEPF000082E3.mail.protection.outlook.com (10.167.240.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.6838.14 via Frontend Transport; Mon, 2 Oct 2023 16:13:54 +0000 Received: from NTHCCAS02.nuvoton.com (10.1.9.121) by NTHCCAS04.nuvoton.com (10.1.8.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.14; Tue, 3 Oct 2023 00:13:54 +0800 Received: from NTHCCAS01.nuvoton.com (10.1.8.28) by NTHCCAS02.nuvoton.com (10.1.9.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 3 Oct 2023 00:13:53 +0800 Received: from taln60.nuvoton.co.il (10.191.1.180) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 3 Oct 2023 00:13:53 +0800 Received: by taln60.nuvoton.co.il (Postfix, from userid 10070) id 9520F64743; Mon, 2 Oct 2023 19:13:52 +0300 (IDT) From: Tomer Maimon To: , , , , , , , , , , , , CC: , , , , Tomer Maimon Subject: [PATCH RESEND v3 3/3] usb: chipidea: Add support for NPCM Date: Mon, 2 Oct 2023 19:13:50 +0300 Message-ID: <20231002161350.64229-4-tmaimon77@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20231002161350.64229-1-tmaimon77@gmail.com> References: <20231002161350.64229-1-tmaimon77@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NotSetDelaration: True X-EOPAttributedMessage: 0 X-MS-Exchange-SkipListedInternetSender: ip=[175.98.123.7];domain=NTHCCAS04.nuvoton.com X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG1PEPF000082E3:EE_|PSAPR03MB5525:EE_ X-MS-Office365-Filtering-Correlation-Id: a3956aaa-fb42-479f-eafb-08dbc3629350 X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: njeA9KQ+z0dsEbEICYwRYDCLodtzFEeXscZIgh1/BiqgtZ0UDELvpNoTz4HeEaukhFbeAmqKuS9M7LPc74Pjj0ki583HONPK9SEVHHTR5ozltAXHIR8DeUcfCyb9ALQmK+6/mVZld0TDa2H/2fZ+t47Q+KaGUSl5U2+6P2Bz30VoPqGWpNHPmw8Wv7y7dC1cAl1W3QqJvBkVPARMAhnHbnL0VC4GywhLDMfn5oF2tZOowG2bucfpJnLDT2KORwR8GWPW3W30rH8d+0MniFrWsqTPxHS+eFV5v5KqMOArZzGKvyTUMlU/3w65bPv3SLpr2eZ/6A8RBZm11BpFIIjVEZkxxLMnQRlnyvzI4cLtXVQnnjNYaXfdK3sY0E0AFagGemj6S3m+98necN88HIG+Wwd3BPJQZxXlYth5Myx9Bm70cJ5EcKQNv1wCA11iEJJGD61uVfQ+sYw2Hz3x759GehFWMhRw5ASpY+Fy1O636F2y6g4LxQchJWMGjoOrwVYLvdPyNCT2rD+GtotFHQGccckJuOWWwy/ZrYGsscPrIt0JZNcBv8jnUSCHSyuCFYdaOkbQfD0Lz66SGhoLLRDC/L2Cql2D6lYQKp0Ilti9c13OUtIOMoPf5TbO+Em4vtXNR6VfT/YnPojTKq46lI50AoRjR17eP5NXGcF0k2AOJzLTPvluYUWFZ08GEZk9/iz2n6Tb8GjSQ3kCyDVH99Jm5en+w21Srg+xcUOr7KalNCl8IW7dytn7ejGGC4UdCgOmBwpysD+Uq3g0wwZ1eF390SDJ+X4pbH48CZsQDm4hTiolIMxAC79xJAQ9uivBSuwT5HApcrI8aWgoezuGYva8M7d6u2F7DX4PODnCqvik57fk1GULvqLurLXRKynVHi7zupTxvYcVf6LZnTV5pNDtH6m/dZDWQdbsdFkKedvy+8726ZqcRHy8IMX0SaGXDbO87O78sBr+CpgbHkvr8Y8m4TYzbqoerzMsqZfEjWRRF8c= X-Forefront-Antispam-Report: CIP:175.98.123.7;CTRY:TW;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:NTHCCAS04.nuvoton.com;PTR:175-98-123-7.static.tfn.net.tw;CAT:NONE;SFS:(13230031)(4636009)(136003)(39860400002)(396003)(346002)(376002)(230922051799003)(5400799018)(82310400011)(186009)(451199024)(61400799006)(64100799003)(48200799006)(40470700004)(46966006)(36840700001)(40460700003)(40480700001)(478600001)(76482006)(47076005)(34020700004)(36860700001)(55446002)(81166007)(82740400003)(356005)(83170400001)(2906002)(921005)(7416002)(6266002)(83380400001)(336012)(42882007)(73392003)(26005)(82202003)(1076003)(2616005)(36756003)(316002)(54906003)(70206006)(42186006)(5660300002)(70586007)(41300700001)(110136005)(8676002)(4326008)(8936002)(45356006)(84790400001)(35450700002)(12100799045);DIR:OUT;SFP:1501; X-OriginatorOrg: nuvoton.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 16:13:54.7728 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3956aaa-fb42-479f-eafb-08dbc3629350 X-MS-Exchange-CrossTenant-Id: a3f24931-d403-4b4a-94f1-7d83ac638e07 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a3f24931-d403-4b4a-94f1-7d83ac638e07;Ip=[175.98.123.7];Helo=[NTHCCAS04.nuvoton.com] X-MS-Exchange-CrossTenant-AuthSource: SG1PEPF000082E3.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR03MB5525 X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Add Nuvoton NPCM BMC SoCs support to USB ChipIdea driver. NPCM SoC include ChipIdea IP block that used for USB device controller mode. Signed-off-by: Tomer Maimon Acked-by: Peter Chen --- drivers/usb/chipidea/Kconfig | 4 + drivers/usb/chipidea/Makefile | 1 + drivers/usb/chipidea/ci_hdrc_npcm.c | 114 ++++++++++++++++++++++++++++ 3 files changed, 119 insertions(+) create mode 100644 drivers/usb/chipidea/ci_hdrc_npcm.c diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig index c815824a0b2d..bab45bc62361 100644 --- a/drivers/usb/chipidea/Kconfig +++ b/drivers/usb/chipidea/Kconfig @@ -43,6 +43,10 @@ config USB_CHIPIDEA_MSM tristate "Enable MSM hsusb glue driver" if EXPERT default USB_CHIPIDEA +config USB_CHIPIDEA_NPCM + tristate "Enable NPCM hsusb glue driver" if EXPERT + default USB_CHIPIDEA + config USB_CHIPIDEA_IMX tristate "Enable i.MX USB glue driver" if EXPERT depends on OF diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile index 71afeab97e83..718cb24603dd 100644 --- a/drivers/usb/chipidea/Makefile +++ b/drivers/usb/chipidea/Makefile @@ -13,6 +13,7 @@ ci_hdrc-$(CONFIG_USB_OTG_FSM) += otg_fsm.o obj-$(CONFIG_USB_CHIPIDEA_GENERIC) += ci_hdrc_usb2.o obj-$(CONFIG_USB_CHIPIDEA_MSM) += ci_hdrc_msm.o +obj-$(CONFIG_USB_CHIPIDEA_NPCM) += ci_hdrc_npcm.o obj-$(CONFIG_USB_CHIPIDEA_PCI) += ci_hdrc_pci.o obj-$(CONFIG_USB_CHIPIDEA_IMX) += usbmisc_imx.o ci_hdrc_imx.o obj-$(CONFIG_USB_CHIPIDEA_TEGRA) += ci_hdrc_tegra.o diff --git a/drivers/usb/chipidea/ci_hdrc_npcm.c b/drivers/usb/chipidea/ci_hdrc_npcm.c new file mode 100644 index 000000000000..37b64a3dbd96 --- /dev/null +++ b/drivers/usb/chipidea/ci_hdrc_npcm.c @@ -0,0 +1,114 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) 2023 Nuvoton Technology corporation. + +#include +#include +#include +#include +#include +#include +#include +#include + +#include "ci.h" + +struct npcm_udc_data { + struct platform_device *ci; + struct clk *core_clk; + struct ci_hdrc_platform_data pdata; +}; + +static int npcm_udc_notify_event(struct ci_hdrc *ci, unsigned event) +{ + struct device *dev = ci->dev->parent; + + switch (event) { + case CI_HDRC_CONTROLLER_RESET_EVENT: + /* clear all mode bits */ + hw_write(ci, OP_USBMODE, 0xffffffff, 0x0); + break; + default: + dev_dbg(dev, "unknown ci_hdrc event\n"); + break; + } + + return 0; +} + +static int npcm_udc_probe(struct platform_device *pdev) +{ + int ret; + struct npcm_udc_data *ci; + struct platform_device *plat_ci; + struct device *dev = &pdev->dev; + + ci = devm_kzalloc(&pdev->dev, sizeof(*ci), GFP_KERNEL); + if (!ci) + return -ENOMEM; + platform_set_drvdata(pdev, ci); + + ci->core_clk = devm_clk_get_optional(dev, NULL); + if (IS_ERR(ci->core_clk)) + return PTR_ERR(ci->core_clk); + + ret = clk_prepare_enable(ci->core_clk); + if (ret) + return dev_err_probe(dev, ret, "failed to enable the clock: %d\n", ret); + + ci->pdata.name = dev_name(dev); + ci->pdata.capoffset = DEF_CAPOFFSET; + ci->pdata.flags = CI_HDRC_REQUIRES_ALIGNED_DMA | + CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS; + ci->pdata.phy_mode = USBPHY_INTERFACE_MODE_UTMI; + ci->pdata.notify_event = npcm_udc_notify_event; + + plat_ci = ci_hdrc_add_device(dev, pdev->resource, pdev->num_resources, + &ci->pdata); + if (IS_ERR(plat_ci)) { + ret = PTR_ERR(plat_ci); + dev_err(dev, "failed to register HDRC NPCM device: %d\n", ret); + goto clk_err; + } + + pm_runtime_no_callbacks(dev); + pm_runtime_enable(dev); + + return 0; + +clk_err: + clk_disable_unprepare(ci->core_clk); + return ret; +} + +static int npcm_udc_remove(struct platform_device *pdev) +{ + struct npcm_udc_data *ci = platform_get_drvdata(pdev); + + pm_runtime_disable(&pdev->dev); + ci_hdrc_remove_device(ci->ci); + clk_disable_unprepare(ci->core_clk); + + return 0; +} + +static const struct of_device_id npcm_udc_dt_match[] = { + { .compatible = "nuvoton,npcm750-udc", }, + { .compatible = "nuvoton,npcm845-udc", }, + { } +}; +MODULE_DEVICE_TABLE(of, npcm_udc_dt_match); + +static struct platform_driver npcm_udc_driver = { + .probe = npcm_udc_probe, + .remove = npcm_udc_remove, + .driver = { + .name = "npcm_udc", + .of_match_table = npcm_udc_dt_match, + }, +}; + +module_platform_driver(npcm_udc_driver); + +MODULE_DESCRIPTION("NPCM USB device controller driver"); +MODULE_AUTHOR("Tomer Maimon "); +MODULE_LICENSE("GPL v2");