From patchwork Mon Oct 9 10:30:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maciej Wieczor-Retman X-Patchwork-Id: 13413346 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBC7E95A8E for ; Mon, 9 Oct 2023 10:31:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D06B98D004E; Mon, 9 Oct 2023 06:31:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB6EF8D0031; Mon, 9 Oct 2023 06:31:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7FB98D004E; Mon, 9 Oct 2023 06:31:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A6DCF8D0031 for ; Mon, 9 Oct 2023 06:31:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6B8201601E2 for ; Mon, 9 Oct 2023 10:31:21 +0000 (UTC) X-FDA: 81325555962.22.8AE32D6 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by imf23.hostedemail.com (Postfix) with ESMTP id 2160F140018 for ; Mon, 9 Oct 2023 10:31:17 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=e93AHDdU; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf23.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696847478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QMQCUqiKCZ+/b2Fi5Gjj2lldpdCbu3DU7ppITIiqn4U=; b=WrSgQRaL/ycNNwB72eOInkJXpuTuyiHXqotHIEKKrLupX3vQCrgdz9jkR0gK4GQHPGBZ84 k2mZsk4VKf7TA/df/2EIIiNtU/8vPOjiCw+SJGP09rVBI1H+kNQxo8318mddLERe80xpz7 XCgFUxaJNHWoz12pVEcCX9sJvuvclCo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=e93AHDdU; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf23.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696847478; a=rsa-sha256; cv=none; b=v3MQoLzmD+7crEl2rRiKGsz3eKFDc/aTVESrim5+EQhxKzBNZPGY/pv4XnIM5VBw6sw05G Ud4A1vkAc5A0uCGAcSCocpmaP8O/bUtdnl7VcZzRwZGQeB76gSb5maeaxmbwXwVnsU8Qsa ozbdyuCcHMfgTkL4gLp8DQY7MPHTL+U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696847478; x=1728383478; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ArKiKzRHxYzfbJNN+HN0Ktz/ZV7JTI0Hu+EuWZDRMeU=; b=e93AHDdUnRRC9P9BCVTg9A5x+Ub6GctPJvi5aStjsmm1LSok7UkgcjhU 2rEUswsPDnpin2s+i0ZnHESOlhH8LTVHCzzKViKHvSia0pZ3umPTfidpo sRERHM1As57U5KmS8GEyHNZWpG3o5dh7RXr4CKTVPRqXWokdJEwvnXP+8 HgyWTjLo6DcJgw+bFRxlQLQK3lAwKtapNz7ammq6s2AYYTQZxcy7qjUBw TU36Dr8xIRGjsi7YzSCXgUIp33d52tPb/AZ+jMnGr+dZt+ug042GEKYz3 kvHs4WjM3EHETuEvbzMzyyms1I0Mf6apaz4nDIB+7ic8cZxQNFcdhb4e0 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10857"; a="363468382" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="363468382" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 03:31:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10857"; a="926718650" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="926718650" Received: from kkensic-mobl1.ger.corp.intel.com (HELO wieczorr-mobl1.intel.com) ([10.213.30.239]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 03:31:13 -0700 From: Maciej Wieczor-Retman To: Nhat Pham , Johannes Weiner , Shuah Khan Cc: ilpo.jarvinen@linux.intel.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/8] selftests/cachestat: Fix print_cachestat format Date: Mon, 9 Oct 2023 12:30:36 +0200 Message-ID: <2f34bb45233c29fda28eb8fb66215d475c3c7fd6.1696846568.git.maciej.wieczor-retman@intel.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 2160F140018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: oeif1dg39phepmhdaqj489zrfs33yhhj X-HE-Tag: 1696847477-364835 X-HE-Meta: U2FsdGVkX1+Emar0sVLk4C0qS2SyTaVdP+NPF/GCarBvhQlQQmUDK4l/zZwEHK5EGpE21aCSL8ypTtcLuhHAcNDMF5bZavrH3E/a4B1Zg2UD52X4KQNTmV75UCxTanUvKw+wAfVwDAL97bHTx1Lt+yltHRKPLUsQBzD8Vy1cRJRlfJB1eoLjV6XoQWY8JfDpdMnlA4R0MdhMaji8BEd6EdkgeFw0rMy96hETanXnR6QTnu4gCFgXN5/GWMjuoRwKputn7FZi4hmbcNsqKD7CmzS3H85BLyTMSCcBD67s2Gx1wyuQnTjdaC57/reV00S1uCh0I65F70h6nhTmihpHoNfGwCawU3zmHhtrupv0wnn7LFiEGLKEkmfKIgfvRVphiTOL15mSsg5ZAKeblBsgup93gg3u/hwN5BjJ0YqWsOwe4AIe8YsOePSlh9q28ddvjgYDTsAfXPNXBITey5zu7E1J2qHGNGpygpY5672QKf0zZ5gEC3cA3sG/UBqzqsrf9q3rfC1kZ1DZ+OfN6bK+zN14FTgw22wZJWeN7aJ33yLsKoT9njZxycd8+/Bd9OB/HTEE5mIEz2pZI91cdxgajPJ2Y80GaK08sFSMTx/vOEeAP8BY+fJzJSdgGflpq0+ndoKrwMz/aK4/7Rjg930b1rHYy8FT/l4KxN4biTKcWgVF2uYB1WCuUnMra5x7GwjN5A0WTy3rOQxoFGmeOndwIUh1gXTg/GL+Y0KN8Y95gYTA1aVya4h0hsOelJvzBV0SJ6r6MEbLpOq6MqWWNFjAKOVF++sOIQTFwp7eSHLzsvmvnTbJ0Gb8LSkpPkI6gOx9ecqtTRcpIRC4ujTrMr+TyU39R3jnIzZ9bLu6Firl40DyfZTHX3P+1c97cM5cpRdMRwz017WUyDN2QspZ6uFPUhJPizzXJm2i16ptMfpoIjgpIj9nl+95oEcokA8TjqQjOkrdKsBnSECGtIOkSkD py/jRLKG KTyMyWhbfqfGsiN1bs6cyeKAe3rv8CZuepnwgLzFkJBN7byhKdMDjCZF8rmA5zBh9Q0wY2wp8Bz9CoBM7qaB8yrEt6lrMm/p6/Aqbq3s+O4zKe3clgOhxXnifVuW0pmXTb6LOeiug4R7uf0/o11KoHStJM6ouiMCrzhC2W38da44YRI/H2gTQ7MFCNV1zaaPoKstXJ+SSc+NRRBfNdCR+2MN0S93r1Q9z4196 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The format specifier in printf() call expects long int variables and received long long int. Change format specifiers to long long int so they match passed variables. Signed-off-by: Maciej Wieczor-Retman Acked-by: Nhat Pham --- Changelog v2: - Added Acked-by tag (Nhat) tools/testing/selftests/cachestat/test_cachestat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c index 4804c7dc7b31..b171fd53b004 100644 --- a/tools/testing/selftests/cachestat/test_cachestat.c +++ b/tools/testing/selftests/cachestat/test_cachestat.c @@ -27,7 +27,7 @@ static const char * const dev_files[] = { void print_cachestat(struct cachestat *cs) { ksft_print_msg( - "Using cachestat: Cached: %lu, Dirty: %lu, Writeback: %lu, Evicted: %lu, Recently Evicted: %lu\n", + "Using cachestat: Cached: %llu, Dirty: %llu, Writeback: %llu, Evicted: %llu, Recently Evicted: %llu\n", cs->nr_cache, cs->nr_dirty, cs->nr_writeback, cs->nr_evicted, cs->nr_recently_evicted); } From patchwork Mon Oct 9 10:30:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maciej Wieczor-Retman X-Patchwork-Id: 13413347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1790AE95A91 for ; Mon, 9 Oct 2023 10:31:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FA058D004F; Mon, 9 Oct 2023 06:31:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AA748D0031; Mon, 9 Oct 2023 06:31:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 872188D004F; Mon, 9 Oct 2023 06:31:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 76E768D0031 for ; Mon, 9 Oct 2023 06:31:48 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4ACFF1A01D5 for ; Mon, 9 Oct 2023 10:31:48 +0000 (UTC) X-FDA: 81325557096.25.D5EE0CC Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by imf06.hostedemail.com (Postfix) with ESMTP id 48A45180004 for ; Mon, 9 Oct 2023 10:31:45 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="dJh/nImQ"; spf=pass (imf06.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696847506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zFe3KiM0PZDHJfATYmq0bnBkJ6C6pbYUoYQm41KQ3fA=; b=mATV5X2JfvYbBKO0Y5wVF2K52T1cqglP293Cmig1LFtJv7MuqRv2cpxmP8KlFk+yrSA7c3 vK2yOt23Kbx4FlJilPXsNEx2T8vzyOICq7eg6LPQobPpqlir9xqLrpOeDoubjxVDONTRKY 1kGJ5zL1Ot7J403F+T0Elp4uLbbrVF8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696847506; a=rsa-sha256; cv=none; b=F++Wpzvi509aaI2KEgzSFhUyosM/EhTshyXt2J5pjHSWA5pOpOyxNiL3qGUdbwFwnFvnTG Kei8DoDJQEV0DPfJQd8KlguY3bvpG87WnsLusdeaLKxkoYRDcACliqFh/GGvxfrLRpKwCU kGrwXiLlfvPt8+PKz0BQmvuQiA0G/VI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="dJh/nImQ"; spf=pass (imf06.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696847506; x=1728383506; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VXxoZYWc1k9TebbKU7+nIiD46KUiapqhrZ8TkPNyZG4=; b=dJh/nImQmeLc0xqUXfzhPos0EnmQ5jMCr9pz9A4vcrEuLkUt0hOZ6ZcG hnfRPGZGQ0xnd759VYdbq7+e60Zh4xVqQoBWV83N4yfvqQakEOmd1dzvT TsuP70yj9ct+470fcjN2Nw6bJ3+umMTjXzPlAoHrx966JWr+FtLHHG0tB jLyZnRVVuipKIMzVZsghzqqkNecMW7z+3xRd9cIeSMKi2TJTSB1CMxgYg Xd4T9m7J0ri5DjqUjSRh/g1E7YJzJ2AA3dCJvignqeEHqU95zkU61eGvy MGFxWVf3mfJrtLPtOOs4uO+eHSjMk5DBfXFc1pHRpL8cTBS8pjd3ixSAi g==; X-IronPort-AV: E=McAfee;i="6600,9927,10857"; a="363468473" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="363468473" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 03:31:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10857"; a="926718745" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="926718745" Received: from kkensic-mobl1.ger.corp.intel.com (HELO wieczorr-mobl1.intel.com) ([10.213.30.239]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 03:31:41 -0700 From: Maciej Wieczor-Retman To: Andrew Morton , Shuah Khan Cc: ilpo.jarvinen@linux.intel.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 7/8] selftests/mm: Substitute attribute with a macro Date: Mon, 9 Oct 2023 12:30:41 +0200 Message-ID: <288075f2e0d9c34e5789165f688b2fbbc212b56c.1696846568.git.maciej.wieczor-retman@intel.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 48A45180004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hgqwu7xyw3csppozwqfmmfxpmi5u9zxh X-HE-Tag: 1696847505-427225 X-HE-Meta: U2FsdGVkX1/5Fcoj0r/HuPN9ylF1bmK5uBogWFr/Sn+3jXv74FCEaU5g/5b6gQ40LZGDAzHjm78OxOtAU1t7yOPRYIQtcwFfXWufShlaY8QhelxlUGhM5JsPIglrJuLIbbLqzJOpPcIY4SWR/qGn+R54mWAbTEQbYoSXSqUeq1wJcg19YbiKsWi8ODr51nq2p/uptKVUvaoK/AGX+Fwww+bNBBniIufkDJyjS+4D9ExKvqvk8zDU4+oaoxEh4nUbXhb+6Q+WL+Ji/rXOTcz9z4kUF9Tkz5ZXm1qYuqusDk27tL0tAzp725WtUxp0mHb6Bs+nk5N9PvxjZ/uINMeHCKcUFkQA3zfym3UmoiPE18911v1SFXD3+VyQoKjjkUAvd5yDmKhYL7B7HJygPxplg1tXE67y6D6Q3YtWw5b+TeflPADzBsTh+yehqceqXsKirtq34zKBGF5JyErIVM/gWFaAlzNsxJGnOCC0kNaf2whSvQs3cziWwIXX8quzCVFOcNSEhQhod1qJOFN2/C4D/38Tc4McRrYjB/fUOlYeyIupGnIfN6kiNG+dGvtq5qcQCaNU8CsLcf7HEw9ZTDsQMtsCznVRbOxpjLRH37UrJUqYXCsXTcCziZJamFBuFW8MR6WO9egJI5L+YBHO9oER8mo+iOrHyhBSPtLo2jD1wPQawGmEeWLvWR2dQZ23d+b2onO4pizSbejQ3hpSKGR/15K5vXSfoqiJakBzUBwovA9zGlEAUoDJswVtoJILekXtJPzx6kUQ/w/i4GLDoPtyoIDeOVXlaD6JwNf4V4q//2aTltt172twAocKi0aTO7w0HLTrBCi337Qe6zufhkxcRPov1nIOuKBOcCtVw4II37eNgT9Y+NVuBh7fbKNKJJi+2ODCFe+mDLyuWoJvYjwMcymsIsCljDmWLkQtTZpjF/GJjmUW8PuzIwXrXRxNLk2iimxf/DtDyi6CTzScT3+ pIhtzlqO GRHSMLzNWHkB6LBQaBc4/SFj+bZZM9PsLjclQ8W2Qoi7NVZBJPqZ+2LablPFQM4t/kq4vvDNHG1xzkmAAtLXZ0oTsR1MxZJGkEU27+42NyVriQtB5glBIUf8wLO6o3u0Jt2/bxEtYaHi8CNBD2mkQJ4h38w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The mm selftest uses the printf attribute in its full form. Since the header file that uses it also includes kselftests.h it can use the macro defined there. Use __printf() included with kselftests.h instead of the full attribute. Fix a wrong format specifier in ksft_print_msg(). Signed-off-by: Maciej Wieczor-Retman --- Changelog v2: - Added this patch to the series. tools/testing/selftests/mm/mremap_test.c | 2 +- tools/testing/selftests/mm/pkey-helpers.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c index 5c3773de9f0f..1dbfcf6df255 100644 --- a/tools/testing/selftests/mm/mremap_test.c +++ b/tools/testing/selftests/mm/mremap_test.c @@ -338,7 +338,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb, char c = (char) rand(); if (((char *) dest_addr)[i] != c) { - ksft_print_msg("Data after remap doesn't match at offset %d\n", + ksft_print_msg("Data after remap doesn't match at offset %llu\n", i); ksft_print_msg("Expected: %#x\t Got: %#x\n", c & 0xff, ((char *) dest_addr)[i] & 0xff); diff --git a/tools/testing/selftests/mm/pkey-helpers.h b/tools/testing/selftests/mm/pkey-helpers.h index 92f3be3dd8e5..1af3156a9db8 100644 --- a/tools/testing/selftests/mm/pkey-helpers.h +++ b/tools/testing/selftests/mm/pkey-helpers.h @@ -34,7 +34,7 @@ extern int test_nr; extern int iteration_nr; #ifdef __GNUC__ -__attribute__((format(printf, 1, 2))) +__printf(1, 2) #endif static inline void sigsafe_printf(const char *format, ...) {