From patchwork Thu Oct 12 23:00:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomer Maimon X-Patchwork-Id: 13419964 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C276F3D000 for ; Thu, 12 Oct 2023 23:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nuvoton.onmicrosoft.com header.i=@nuvoton.onmicrosoft.com header.b="JK9vgISS" Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01hn2215.outbound.protection.outlook.com [52.100.0.215]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 185E2BE; Thu, 12 Oct 2023 16:01:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3b3Xn8X7IEMJzExZUtREnm6mbA9WCm5Xv+9ZzV8I4YD/Yc/bnC0XBaVc28fT9/JMb17713hbk5N5HEmZipHRuCyqOC1kSJlCdqhC7lR63n7K5t9hEIa0LqCKyyqr2vJbnHACz8DOrrRiV73cgk5hlcJm5cZ+JY4gLxpm03sU6lpFkLMJp8VQf9pIj5/eVPUHp6NyUePZvR4nMuvVLr7kpuY/p0ah00fyOnFsShAjRpbbakzqJEOddDl9FQ2RewAmdXQ9L3VDW5arMfr/ICVoO8bnGuM65WxbvkvJ9LLWqFUY4ylhFTVMz3486fQYFSgOaCrRAAzdpcPLGjRJTWuyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HJPlBtL4X/T/9aSDc4JYtiVWMLfmJVy5DVI0D2TM3mA=; b=bpup+z4OInu9rz2Vkfs3bD0MW89uhJy5W12lXu/uXsqR9YQDK8Cz+Z0C4fym8TdPjBL0Xb9dYBmIA/Lq5KXQlkTCV9OeqPN1qR89dMlJjjM+ADqEn+HJX+KfjQ2qjzeMqqx7SxceOejoPdU4xE+D4e0xEek0U9C5FkrHlWlBjdlcodsVG2Nsmt3Yi3i8xAdq+dmvOxi+vpIOKGNG9t/2CVdOO66xQTaM96wmWfdFxLCpDIAqMCtUrcqqMgQUYJBrtYE9RbGuoHGU7X9WdC4PcnbhL5wMf9pIOjWz2P2eVgybWyEvkkI6A8xvQ/M4yiUeTYgNRcgo9IBvcYT5Ljyd0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 175.98.123.7) smtp.rcpttodomain=gmail.com smtp.mailfrom=nuvoton.com; dmarc=fail (p=none sp=quarantine pct=100) action=none header.from=gmail.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuvoton.onmicrosoft.com; s=selector2-nuvoton-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HJPlBtL4X/T/9aSDc4JYtiVWMLfmJVy5DVI0D2TM3mA=; b=JK9vgISSlGgy7qLw/IQiWnP12Qa+t6/3RhqqUe1quelBG9o6b58ttRm65PjQwuPdlcdNZZjAkt5rF//Oz0B6gg5kR+qMKgTR6r1CUGf9QaghWtG8Uz56QesTrJG3WASMQkVOhHcRLUCUPf1lHnxlMPygTiiNdIdYVEfYHwAkoq4= Received: from SI2PR04CA0013.apcprd04.prod.outlook.com (2603:1096:4:197::6) by TYZPR03MB5501.apcprd03.prod.outlook.com (2603:1096:400:c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.46; Thu, 12 Oct 2023 23:01:04 +0000 Received: from HK2PEPF00006FAF.apcprd02.prod.outlook.com (2603:1096:4:197:cafe::3d) by SI2PR04CA0013.outlook.office365.com (2603:1096:4:197::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.27 via Frontend Transport; Thu, 12 Oct 2023 23:01:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 175.98.123.7) smtp.mailfrom=nuvoton.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=gmail.com; Received-SPF: Pass (protection.outlook.com: domain of nuvoton.com designates 175.98.123.7 as permitted sender) receiver=protection.outlook.com; client-ip=175.98.123.7; helo=NTHCCAS04.nuvoton.com; pr=C Received: from NTHCCAS04.nuvoton.com (175.98.123.7) by HK2PEPF00006FAF.mail.protection.outlook.com (10.167.8.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.6838.22 via Frontend Transport; Thu, 12 Oct 2023 23:01:03 +0000 Received: from NTHCCAS01.nuvoton.com (10.1.8.28) by NTHCCAS04.nuvoton.com (10.1.8.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.14; Fri, 13 Oct 2023 07:01:02 +0800 Received: from taln58.nuvoton.co.il (10.191.1.178) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 13 Oct 2023 07:01:01 +0800 Received: from taln60.nuvoton.co.il (taln60 [10.191.1.180]) by taln58.nuvoton.co.il (Postfix) with ESMTP id CF58168E71; Fri, 13 Oct 2023 02:01:00 +0300 (IDT) Received: by taln60.nuvoton.co.il (Postfix, from userid 10070) id C9BA621CFCC4; Fri, 13 Oct 2023 02:01:00 +0300 (IDT) From: Tomer Maimon To: , , , , , , , , CC: , , , Tomer Maimon Subject: [PATCH v6 1/3] usb: chipidea: add CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS flag Date: Fri, 13 Oct 2023 02:00:55 +0300 Message-ID: <20231012230057.3365626-2-tmaimon77@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20231012230057.3365626-1-tmaimon77@gmail.com> References: <20231012230057.3365626-1-tmaimon77@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NotSetDelaration: True X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HK2PEPF00006FAF:EE_|TYZPR03MB5501:EE_ X-MS-Office365-Filtering-Correlation-Id: a27f68e7-531f-4357-ab7f-08dbcb771bf5 X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eGhjJ/aQ8XX3fyMCD/uhH4aTaPAIXjGbWWbaGo47Z56p6vqRhH6ITB1jFVr3yaJrd8YnUKzK6dFnypH6Ldc8d61c9LIdbsxJbZBWxjqAc7CSRxUhVDI702gzyZcNcjvS6LCpUnLe3r6upe5xCsAUzUiG3WWMbirUyvkSHJu5M8pPcMdAUttyASlyuxmYeIZXMMldfwVEHPKDRl3qMPyyD4jN4xG8EhAxAl9XBIuChGror/ciQT1tGDbqxgVGeybK/pIHOrsuuZvkHO1bhux+3PzYup4Df/azk/gyXvHQDdikRexEH9xRYGrHsBABa8iFLpJud5usxparhZLHptcgPj8sL2eJnRPrnq9JVR3qe8ca+aDpuU8ZzJlDmLKC2fZ6bqKAovkpNoBMpRkTp7YoERZu2Z4PgZHdpceXM8hhMQ5EM8s3zdIq0FyaOzgBL34McWUGDWNu4dYE01uA2xAGaQ7out1OPVY+lFoRFRPXXj0HIrYlW62M+IHtlgTWjWT1XdXkjP+vb4vWN0+YKWu2UkfSzGNgh+nvM5rH1OxcWLRjo9kr6IktZF2aWx5pt67uGW+5YqgSaXj+CxhX7hxzogia0fzstNMKPVkKeDlX+hQlPuPBD3c/ZsTHw09Tf5aaufn961A25iiXQvdUv/42qTO5DxPh5347YEES4QewZB9e3m2oEzZOKLJfhe3rDM/XfYb3en18faV2jkoC1D2giUy5Oepme0U9lmSePyvqz58HC2CFFVAFdJGs004Oad2Qnns52KNM4LszatirF+p5hDmHDKFxzune05RNbv6wGhWHYVdhR58UKE2F7onWFPryP8ciThwEos24mb9tWbYVhErvX8mT1kL4b7M9Lt6lE4sEKa82QF77L2NEvmxj1XGt02DmFQLEPMt9wLpeUaOrar3OpX9HLJFA+pomyal8p26mK55sQR9DRRK6QuB/8O7KmSpIiuZiWNntKu3vseRX7yu0xu5O6D3pBT1X7xwfaEg= X-Forefront-Antispam-Report: CIP:175.98.123.7;CTRY:TW;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:NTHCCAS04.nuvoton.com;PTR:175-98-123-7.static.tfn.net.tw;CAT:NONE;SFS:(13230031)(4636009)(136003)(346002)(39860400002)(376002)(396003)(230922051799003)(186009)(5400799018)(64100799003)(61400799006)(48200799006)(451199024)(82310400011)(46966006)(40470700004)(36840700001)(47076005)(83380400001)(36860700001)(34020700004)(26005)(40460700003)(83170400001)(42882007)(6266002)(73392003)(336012)(40480700001)(81166007)(55446002)(7416002)(2906002)(5660300002)(4326008)(8936002)(8676002)(6666004)(110136005)(316002)(70586007)(70206006)(54906003)(42186006)(76482006)(41300700001)(36756003)(356005)(2616005)(82740400003)(1076003)(82202003)(478600001)(45356006)(35450700002)(84790400001)(12100799048);DIR:OUT;SFP:1501; X-OriginatorOrg: nuvoton.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 23:01:03.3376 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a27f68e7-531f-4357-ab7f-08dbcb771bf5 X-MS-Exchange-CrossTenant-Id: a3f24931-d403-4b4a-94f1-7d83ac638e07 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a3f24931-d403-4b4a-94f1-7d83ac638e07;Ip=[175.98.123.7];Helo=[NTHCCAS04.nuvoton.com] X-MS-Exchange-CrossTenant-AuthSource: HK2PEPF00006FAF.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB5501 X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Adding CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS flag to modify the vbus_active parameter to active in case the ChipIdea USB IP role is device-only and there is no otgsc register. Signed-off-by: Tomer Maimon Acked-by: Peter Chen --- drivers/usb/chipidea/otg.c | 5 ++++- include/linux/usb/chipidea.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c index f5490f2a5b6b..647e98f4e351 100644 --- a/drivers/usb/chipidea/otg.c +++ b/drivers/usb/chipidea/otg.c @@ -130,8 +130,11 @@ enum ci_role ci_otg_role(struct ci_hdrc *ci) void ci_handle_vbus_change(struct ci_hdrc *ci) { - if (!ci->is_otg) + if (!ci->is_otg) { + if (ci->platdata->flags & CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS) + usb_gadget_vbus_connect(&ci->gadget); return; + } if (hw_read_otgsc(ci, OTGSC_BSV) && !ci->vbus_active) usb_gadget_vbus_connect(&ci->gadget); diff --git a/include/linux/usb/chipidea.h b/include/linux/usb/chipidea.h index 0b4f2d5faa08..5a7f96684ea2 100644 --- a/include/linux/usb/chipidea.h +++ b/include/linux/usb/chipidea.h @@ -64,6 +64,7 @@ struct ci_hdrc_platform_data { #define CI_HDRC_PMQOS BIT(15) #define CI_HDRC_PHY_VBUS_CONTROL BIT(16) #define CI_HDRC_HAS_PORTSC_PEC_MISSED BIT(17) +#define CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS BIT(18) enum usb_dr_mode dr_mode; #define CI_HDRC_CONTROLLER_RESET_EVENT 0 #define CI_HDRC_CONTROLLER_STOPPED_EVENT 1 From patchwork Thu Oct 12 23:00:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomer Maimon X-Patchwork-Id: 13419967 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D56AB3D02F for ; Thu, 12 Oct 2023 23:01:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nuvoton.onmicrosoft.com header.i=@nuvoton.onmicrosoft.com header.b="Ib2gi3F/" Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01hn2204.outbound.protection.outlook.com [52.100.0.204]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 045E0BE; Thu, 12 Oct 2023 16:01:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AqJ48aChpKnA8IUNpdKQa5FrxRmJOwoRMvlFNMkqnoOskx4bxltQdcNAbkaFV7OZKv+2RBNgML4N2Sc69w+N4j+Yak4V9uqpKDaOc2GWUwp1vVaRFiWFG2vEMAj5EiM2/yrv2YKo0SU6VP640iHaRpn2HA9EGOF9dACeYtZB3uMRDrkuVx0TnjP7eGQ807DZKsYq0cm7Pw17UCdpvbO0QAz5IYw2KQ7f2WUCBEyuYdYa+A6s9EL8XTkdFILS/6D+aVkOevmYRyvgBdG+o1I9VTXZAtzL5BEnLr6RKQJGR+OshhzztAuE4Z0OlbTVvZh2wwpEt8mLSxcMRKZkPgWyjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5zChZKIeJd8lTeYa9kwcv8k5MX2Iud+Zox3b5ytRjRQ=; b=NCv1NBzg0t3SecowOaylX5/x4zIwZR3UhAWcQdpmYsUgk+PhrGcayk9SRQ/uzBmamvrkhPHxzcrKuXCSMl7SCvFgHbn3Z0MhAJItHcHp4dIZnjQcDUXOLyoCd4O0Towaah+pYOoxa9AcVbFg1IAJDFiw/OigKZy4CZrPQlxxU1/EVTdW3p2pbYpcuia1hvH3P+DV66TElZjpJW0lGqFCnRB6Ez2tr/lTX0e7B0Mz0gfMSRo31gfxOBMtGXgqoV9wWg+/tJSQNH5d+56o9I0lxreiaa0xejb6jEA0lc6NHzaQxQlgDWxWs1q8vT4vFlp6Z7G0+r78i1yNZRz5E8qT5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 211.75.126.7) smtp.rcpttodomain=gmail.com smtp.mailfrom=nuvoton.com; dmarc=fail (p=none sp=quarantine pct=100) action=none header.from=gmail.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuvoton.onmicrosoft.com; s=selector2-nuvoton-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5zChZKIeJd8lTeYa9kwcv8k5MX2Iud+Zox3b5ytRjRQ=; b=Ib2gi3F/DF1SipGqeYjd0C5xlzJH8Bx0E10hmWdHMzMXSxkfc9MGmDSyJ4ScjewtPGk+qjf/UthL5pETsgPXeyk9ucox0CnBq3H5CMu2rdn6VGA+Oc8GIeiA1m8nA067xuwB85wOaGkZmphiekJ5twl2kaZLPcVZpRbFRA43Fp4= Received: from PS2PR03CA0016.apcprd03.prod.outlook.com (2603:1096:300:5b::28) by SEYPR03MB6795.apcprd03.prod.outlook.com (2603:1096:101:8d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.41; Thu, 12 Oct 2023 23:01:33 +0000 Received: from HK3PEPF00000221.apcprd03.prod.outlook.com (2603:1096:300:5b:cafe::d7) by PS2PR03CA0016.outlook.office365.com (2603:1096:300:5b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.29 via Frontend Transport; Thu, 12 Oct 2023 23:01:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 211.75.126.7) smtp.mailfrom=nuvoton.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=gmail.com; Received-SPF: Pass (protection.outlook.com: domain of nuvoton.com designates 211.75.126.7 as permitted sender) receiver=protection.outlook.com; client-ip=211.75.126.7; helo=NTHCCAS01.nuvoton.com; pr=C Received: from NTHCCAS01.nuvoton.com (211.75.126.7) by HK3PEPF00000221.mail.protection.outlook.com (10.167.8.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6838.22 via Frontend Transport; Thu, 12 Oct 2023 23:01:33 +0000 Received: from NTHCCAS01.nuvoton.com (10.1.8.28) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 13 Oct 2023 07:01:02 +0800 Received: from taln58.nuvoton.co.il (10.191.1.178) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 13 Oct 2023 07:01:02 +0800 Received: from taln60.nuvoton.co.il (taln60 [10.191.1.180]) by taln58.nuvoton.co.il (Postfix) with ESMTP id 66C5A68E73; Fri, 13 Oct 2023 02:01:01 +0300 (IDT) Received: by taln60.nuvoton.co.il (Postfix, from userid 10070) id 5D02B21CFCC4; Fri, 13 Oct 2023 02:01:01 +0300 (IDT) From: Tomer Maimon To: , , , , , , , , CC: , , , Tomer Maimon Subject: [PATCH v6 2/3] dt-bindings: usb: ci-hdrc-usb2: add npcm750 and npcm845 compatible Date: Fri, 13 Oct 2023 02:00:56 +0300 Message-ID: <20231012230057.3365626-3-tmaimon77@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20231012230057.3365626-1-tmaimon77@gmail.com> References: <20231012230057.3365626-1-tmaimon77@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NotSetDelaration: True X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HK3PEPF00000221:EE_|SEYPR03MB6795:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ea55f65-90a2-4f22-bd1c-08dbcb772df7 X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mKx/dvxF9c8QL52KBaIcsn/e4r/qyPYtmBJb+rd9CMbODM0LUszV1tKl2tpcJ2kSKVG36sFusf0zW/QkYBBIOleTm5edSc/3k5J2Yo0OCH4pnL8KQ7/B05U02w5eqH1JbsHeSlPtcfwzzsFSSxBWvEqdjloeZY4W+9rhf9+fKbJue2pPTPc9nREVthzHdVU1+HOgEhDotJWC3P4r0L30Q93zU+GJfj7hd6nJABdLZXB+NJfHLMafWGNJbINSaPnc8o7t8OxNMhYdb9G/ZQ4D1UMCIrZh68E5H9S98LES7KF71BOEzDLT5Ke6Po7gZ2JJZvRDVnXmNxMwI1pqUAQshvyG50FnZAgQ8ZV7TfI4mqYCXAY1XSP1POv9LvlfthjsEGfHJrePUVxgDdPUBmCBf9SiXSHsRrsFqWLT0Rz50niGOsYdLWvU01zgY+l5CNCMDPHD08wB0PXaWKHV5fgbksLOr6EwkmATSjgnDwsEAnXH+d7TZh0eRj2udMaAhRkocbT0LXio3Krpvqswc4gRATG65y940m2kh/7MJZSA0yzBKmAplDhUzgRcZTNiHMdnSA0pmdJtR//3zhrhB1gPhZ4dIB9ekam0oLvvlAdx8bJ4aiqTMUC+KN7fURJfJpGNa+smIEF9A+k+K9KqeY//r2pLdur1Xr5dyLZnUxEJ4NHjqgphvu5Dijc+Bn4Klc1j0QWKNPexeiaHNGRq+Vkwvj668dorYtfFzVwKdeWH8ckOLjixrhNiiZu/JfQtYcYTVoB8nCoInuQ+pCI6b0icshuflyL3Lnv2ahoQjeECjgiS2SPh46aKKs8edcPa4G3TYS9bdfwM0MHrbJFIJBaAoGBYjoR+mQ5N1oQZcWUc7xXsoAhgiVuF0+PXjnqVbJJTTRtov9ujqNTeGZ6lo7VOwVLB37eShVYNtXIQm/ztsBXW5Uurv4B5/ODq0phnUxkQoSmVuJQRTpUgTulMYMJCPQkwD71nINFAg0042x30qLE= X-Forefront-Antispam-Report: CIP:211.75.126.7;CTRY:TW;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:NTHCCAS01.nuvoton.com;PTR:211-75-126-7.hinet-ip.hinet.net;CAT:NONE;SFS:(13230031)(4636009)(39860400002)(396003)(136003)(346002)(376002)(230922051799003)(61400799006)(186009)(48200799006)(64100799003)(82310400011)(5400799018)(451199024)(46966006)(36840700001)(40470700004)(40460700003)(1076003)(2616005)(478600001)(82202003)(7416002)(42882007)(34020700004)(6666004)(336012)(6266002)(73392003)(47076005)(2906002)(76482006)(70206006)(54906003)(8676002)(5660300002)(110136005)(70586007)(41300700001)(42186006)(4326008)(8936002)(26005)(316002)(83170400001)(82740400003)(356005)(40480700001)(81166007)(36860700001)(36756003)(55446002)(45356006)(84790400001)(35450700002)(12100799048);DIR:OUT;SFP:1501; X-OriginatorOrg: nuvoton.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 23:01:33.5501 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea55f65-90a2-4f22-bd1c-08dbcb772df7 X-MS-Exchange-CrossTenant-Id: a3f24931-d403-4b4a-94f1-7d83ac638e07 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a3f24931-d403-4b4a-94f1-7d83ac638e07;Ip=[211.75.126.7];Helo=[NTHCCAS01.nuvoton.com] X-MS-Exchange-CrossTenant-AuthSource: HK3PEPF00000221.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR03MB6795 X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Add a compatible string for Nuvoton BMC NPCM750 and Nuvoton BMC NPCM845. Signed-off-by: Tomer Maimon --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml index 1394557517b1..f5ec1aef839e 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml @@ -16,6 +16,7 @@ properties: - enum: - chipidea,usb2 - lsi,zevio-usb + - nuvoton,npcm750-udc - nvidia,tegra20-ehci - nvidia,tegra20-udc - nvidia,tegra30-ehci @@ -66,6 +67,10 @@ properties: - items: - const: xlnx,zynq-usb-2.20a - const: chipidea,usb2 + - items: + - enum: + - nuvoton,npcm845-udc + - const: nuvoton,npcm750-udc reg: minItems: 1 @@ -388,6 +393,7 @@ allOf: enum: - chipidea,usb2 - lsi,zevio-usb + - nuvoton,npcm750-udc - nvidia,tegra20-udc - nvidia,tegra30-udc - nvidia,tegra114-udc From patchwork Thu Oct 12 23:00:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomer Maimon X-Patchwork-Id: 13419966 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 965BCD2EE for ; Thu, 12 Oct 2023 23:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nuvoton.onmicrosoft.com header.i=@nuvoton.onmicrosoft.com header.b="mLIluoo1" Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01hn2213.outbound.protection.outlook.com [52.100.164.213]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0F73C9; Thu, 12 Oct 2023 16:01:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hgOpL/ysJCUF0p9lbOWrZ4/tVXSc1IQ6NLZXVLtXAxXXq6L/CuMsAOPazVfTYXmNElZyJBaPxl4yGHen7QdTrrpNjZqKKOxpE2sQhfoMWFKV8G6fNd+VEqAaj3z71iOGex8zx5I3RLxfA0c+DEZzWyc2281s25v+R2MW6Iv3J8WYffvmcXeDTSxTdOgER3hv8ij4hn5XVWSUzHpyUc84EqWNRBjMB6WllXY+50z/uj+/3Ackfgm5dmbdzo4Q2pRHp2l45KrLCfv54xL9DjfWDxpvaoqMgXujA9ncH3u2Ob7BRJTl8V199WdOBcv6W2TnT8jxfF8fS9s1Vijsx4l3oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PqdhpXuqvc/cGbndu9wJ6COlL/RiDHNa5WUr+9UxfMg=; b=SP2wkCigrSjoeWn5dQWvYWEnzcIexY5k2D+BfaPOugsYOJ7pkdbqgrJHu5clYvxW8q3hxfHNCz/qDNJTgbHbzKaAjIdFJlpssD9XxhA0x1i371R9ktfCl/jsQAn73R90/SfQbAihDvN8vmcx6aoyQ888KGNh10+RBex55fmfjkw9VW+ESJ/xcyoJ4ZKS0zugWKPmKNQtusB1SSk75IFuoOZMxz4pru+ANdkRn2/z9aOhNn0gaMzS5i2BKZzSoZUEMRH9w+smqWoynAD2R6ShfRoPPWuClxqmQ1DVPwvECB/rsXMr89pP+sCyVTQr1sx14Dcvdv2C1Q7kdxMwpMmAsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 175.98.123.7) smtp.rcpttodomain=gmail.com smtp.mailfrom=nuvoton.com; dmarc=fail (p=none sp=quarantine pct=100) action=none header.from=gmail.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuvoton.onmicrosoft.com; s=selector2-nuvoton-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PqdhpXuqvc/cGbndu9wJ6COlL/RiDHNa5WUr+9UxfMg=; b=mLIluoo1dIC65547QrHCIkekEY3UD9nbF+MhHcECWqmVAzoUGR3hNnCQ2L9xbRxt7h49ykV1heD55MhdrcYvLWvmkA8eWH8xjv1UYsyjGtU3hmyJUWUQvQx+3kZDuS5GNujNvnR0SHd01x/KS/FMtKB6grTl0xE33JfLy+b+VeM= Received: from SI2PR04CA0001.apcprd04.prod.outlook.com (2603:1096:4:197::12) by PUZPR03MB6048.apcprd03.prod.outlook.com (2603:1096:301:b7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.46; Thu, 12 Oct 2023 23:01:05 +0000 Received: from HK2PEPF00006FAF.apcprd02.prod.outlook.com (2603:1096:4:197:cafe::f1) by SI2PR04CA0001.outlook.office365.com (2603:1096:4:197::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.29 via Frontend Transport; Thu, 12 Oct 2023 23:01:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 175.98.123.7) smtp.mailfrom=nuvoton.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=gmail.com; Received-SPF: Pass (protection.outlook.com: domain of nuvoton.com designates 175.98.123.7 as permitted sender) receiver=protection.outlook.com; client-ip=175.98.123.7; helo=NTHCCAS04.nuvoton.com; pr=C Received: from NTHCCAS04.nuvoton.com (175.98.123.7) by HK2PEPF00006FAF.mail.protection.outlook.com (10.167.8.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.6838.22 via Frontend Transport; Thu, 12 Oct 2023 23:01:05 +0000 Received: from NTHCML01B.nuvoton.com (10.1.8.178) by NTHCCAS04.nuvoton.com (10.1.8.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.14; Fri, 13 Oct 2023 07:01:03 +0800 Received: from NTHCCAS01.nuvoton.com (10.1.8.28) by NTHCML01B.nuvoton.com (10.1.8.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 13 Oct 2023 07:01:03 +0800 Received: from taln58.nuvoton.co.il (10.191.1.178) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 13 Oct 2023 07:01:03 +0800 Received: from taln60.nuvoton.co.il (taln60 [10.191.1.180]) by taln58.nuvoton.co.il (Postfix) with ESMTP id E91BA68E78; Fri, 13 Oct 2023 02:01:01 +0300 (IDT) Received: by taln60.nuvoton.co.il (Postfix, from userid 10070) id C15BA21CFCC4; Fri, 13 Oct 2023 02:01:01 +0300 (IDT) From: Tomer Maimon To: , , , , , , , , CC: , , , Tomer Maimon Subject: [PATCH v6 3/3] usb: chipidea: Add support for NPCM Date: Fri, 13 Oct 2023 02:00:57 +0300 Message-ID: <20231012230057.3365626-4-tmaimon77@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20231012230057.3365626-1-tmaimon77@gmail.com> References: <20231012230057.3365626-1-tmaimon77@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NotSetDelaration: True X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HK2PEPF00006FAF:EE_|PUZPR03MB6048:EE_ X-MS-Office365-Filtering-Correlation-Id: d7847b67-6607-4a00-d8db-08dbcb771d26 X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CSigZHrJTJ0Fl4A8IY37PBznPDLGsuPYy7oHFuTeTs6wjaNmklK3dTy23OCtdxMEfWZdKPdR9iRTIczvcIhdMJY9j4NYFN0WNUiTQIeqWN1+s/PSfzHlKbEsa/0ZedQYwcxhVn3M3j0DxmK7Pnkp7qNGUDCHFD0zxoCzBf5ouqnPbCqQ1/4min5k5bwDm3wowisbxS3Z8eYTdq4/EdbgwQ2bNXf6+Mn6tG47S2KxhJAO77ZCsoRXcwhS6DWNwlWVhgb8m53YFiz5agxKlwJVXDEVvcutbg4PucdQoK+SKY0LkLbGt5cdMxzQ6d+KIHWa0WT2/e8y+8tFtjaaZxC9b0SEvPYTwyBpfp8jn2fWNEE0bx4XcmCW4U1Wf4Y1PvxaQ5bcSI6QDVVysaiNi70lrxHg4cCtgxn93KqMey6nzjG/YXlacYVcny5KfBLuw5mR+pE1pV3wlyXXHhYyN/HeugKh8yDLrS9PNmALrxkLlyMmzLhkE7JL0nwqaImnWO+jC1GFx2jlBpLYJ8J/T+P2mlX5av8PY03xUlSDu8XdRIzWdm7fX44SozGcIc0yIJhs8mekOwp4D8hx5QHcl1iGF0LNAbwASa01oyOQb0j54fett3ee4d/olRosad5Tcngaj5nRQnHWVy88g1UsyB7TM8GetsR9gKFL412d4zrwGzPEXf7K7S4GA0CYKyvWmBX1PwUaeDe+FSTyfNFbGkt6eyJv28NS7mbGOt2qhptWNEf3Ggx64phz0OsSSOyXt/3Ibt4Lpv39NT1lWwZtG7j54WKwUgwDsEq2PN4ywu+uvLbDO5qVgz7e5Yqnf6BZU495FW1v9bH2pG3x5tALtP9OPmeldJocOIIAxORzyyJJVTCoDwm5FGXJiweBEgLubKzLvtCAnYmKZ1VrbEHcV++5wdGiOf5p/a1ZmsIxrOM0a/gco8joQjINTDU38FLIH87z894haq8ZI8GP060RVqpodttdCHFWPTuifVoWWrqfQN8= X-Forefront-Antispam-Report: CIP:175.98.123.7;CTRY:TW;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:NTHCCAS04.nuvoton.com;PTR:175-98-123-7.static.tfn.net.tw;CAT:NONE;SFS:(13230031)(4636009)(396003)(39860400002)(136003)(346002)(376002)(230922051799003)(5400799018)(48200799006)(61400799006)(451199024)(82310400011)(186009)(64100799003)(40470700004)(46966006)(36840700001)(7416002)(478600001)(40460700003)(2616005)(36756003)(82202003)(26005)(1076003)(336012)(73392003)(42882007)(6266002)(2906002)(356005)(81166007)(82740400003)(83170400001)(83380400001)(55446002)(36860700001)(47076005)(34020700004)(40480700001)(6666004)(4326008)(110136005)(8936002)(8676002)(76482006)(70586007)(70206006)(42186006)(54906003)(316002)(41300700001)(5660300002)(45356006)(35450700002)(84790400001)(12100799048);DIR:OUT;SFP:1501; X-OriginatorOrg: nuvoton.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 23:01:05.3376 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d7847b67-6607-4a00-d8db-08dbcb771d26 X-MS-Exchange-CrossTenant-Id: a3f24931-d403-4b4a-94f1-7d83ac638e07 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a3f24931-d403-4b4a-94f1-7d83ac638e07;Ip=[175.98.123.7];Helo=[NTHCCAS04.nuvoton.com] X-MS-Exchange-CrossTenant-AuthSource: HK2PEPF00006FAF.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR03MB6048 X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Add Nuvoton NPCM BMC SoCs support to USB ChipIdea driver. NPCM SoC include ChipIdea IP block that used for USB device controller mode. Signed-off-by: Tomer Maimon Acked-by: Peter Chen --- drivers/usb/chipidea/Kconfig | 4 + drivers/usb/chipidea/Makefile | 1 + drivers/usb/chipidea/ci_hdrc_npcm.c | 114 ++++++++++++++++++++++++++++ 3 files changed, 119 insertions(+) create mode 100644 drivers/usb/chipidea/ci_hdrc_npcm.c diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig index c815824a0b2d..bab45bc62361 100644 --- a/drivers/usb/chipidea/Kconfig +++ b/drivers/usb/chipidea/Kconfig @@ -43,6 +43,10 @@ config USB_CHIPIDEA_MSM tristate "Enable MSM hsusb glue driver" if EXPERT default USB_CHIPIDEA +config USB_CHIPIDEA_NPCM + tristate "Enable NPCM hsusb glue driver" if EXPERT + default USB_CHIPIDEA + config USB_CHIPIDEA_IMX tristate "Enable i.MX USB glue driver" if EXPERT depends on OF diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile index 71afeab97e83..718cb24603dd 100644 --- a/drivers/usb/chipidea/Makefile +++ b/drivers/usb/chipidea/Makefile @@ -13,6 +13,7 @@ ci_hdrc-$(CONFIG_USB_OTG_FSM) += otg_fsm.o obj-$(CONFIG_USB_CHIPIDEA_GENERIC) += ci_hdrc_usb2.o obj-$(CONFIG_USB_CHIPIDEA_MSM) += ci_hdrc_msm.o +obj-$(CONFIG_USB_CHIPIDEA_NPCM) += ci_hdrc_npcm.o obj-$(CONFIG_USB_CHIPIDEA_PCI) += ci_hdrc_pci.o obj-$(CONFIG_USB_CHIPIDEA_IMX) += usbmisc_imx.o ci_hdrc_imx.o obj-$(CONFIG_USB_CHIPIDEA_TEGRA) += ci_hdrc_tegra.o diff --git a/drivers/usb/chipidea/ci_hdrc_npcm.c b/drivers/usb/chipidea/ci_hdrc_npcm.c new file mode 100644 index 000000000000..37b64a3dbd96 --- /dev/null +++ b/drivers/usb/chipidea/ci_hdrc_npcm.c @@ -0,0 +1,114 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) 2023 Nuvoton Technology corporation. + +#include +#include +#include +#include +#include +#include +#include +#include + +#include "ci.h" + +struct npcm_udc_data { + struct platform_device *ci; + struct clk *core_clk; + struct ci_hdrc_platform_data pdata; +}; + +static int npcm_udc_notify_event(struct ci_hdrc *ci, unsigned event) +{ + struct device *dev = ci->dev->parent; + + switch (event) { + case CI_HDRC_CONTROLLER_RESET_EVENT: + /* clear all mode bits */ + hw_write(ci, OP_USBMODE, 0xffffffff, 0x0); + break; + default: + dev_dbg(dev, "unknown ci_hdrc event\n"); + break; + } + + return 0; +} + +static int npcm_udc_probe(struct platform_device *pdev) +{ + int ret; + struct npcm_udc_data *ci; + struct platform_device *plat_ci; + struct device *dev = &pdev->dev; + + ci = devm_kzalloc(&pdev->dev, sizeof(*ci), GFP_KERNEL); + if (!ci) + return -ENOMEM; + platform_set_drvdata(pdev, ci); + + ci->core_clk = devm_clk_get_optional(dev, NULL); + if (IS_ERR(ci->core_clk)) + return PTR_ERR(ci->core_clk); + + ret = clk_prepare_enable(ci->core_clk); + if (ret) + return dev_err_probe(dev, ret, "failed to enable the clock: %d\n", ret); + + ci->pdata.name = dev_name(dev); + ci->pdata.capoffset = DEF_CAPOFFSET; + ci->pdata.flags = CI_HDRC_REQUIRES_ALIGNED_DMA | + CI_HDRC_FORCE_VBUS_ACTIVE_ALWAYS; + ci->pdata.phy_mode = USBPHY_INTERFACE_MODE_UTMI; + ci->pdata.notify_event = npcm_udc_notify_event; + + plat_ci = ci_hdrc_add_device(dev, pdev->resource, pdev->num_resources, + &ci->pdata); + if (IS_ERR(plat_ci)) { + ret = PTR_ERR(plat_ci); + dev_err(dev, "failed to register HDRC NPCM device: %d\n", ret); + goto clk_err; + } + + pm_runtime_no_callbacks(dev); + pm_runtime_enable(dev); + + return 0; + +clk_err: + clk_disable_unprepare(ci->core_clk); + return ret; +} + +static int npcm_udc_remove(struct platform_device *pdev) +{ + struct npcm_udc_data *ci = platform_get_drvdata(pdev); + + pm_runtime_disable(&pdev->dev); + ci_hdrc_remove_device(ci->ci); + clk_disable_unprepare(ci->core_clk); + + return 0; +} + +static const struct of_device_id npcm_udc_dt_match[] = { + { .compatible = "nuvoton,npcm750-udc", }, + { .compatible = "nuvoton,npcm845-udc", }, + { } +}; +MODULE_DEVICE_TABLE(of, npcm_udc_dt_match); + +static struct platform_driver npcm_udc_driver = { + .probe = npcm_udc_probe, + .remove = npcm_udc_remove, + .driver = { + .name = "npcm_udc", + .of_match_table = npcm_udc_dt_match, + }, +}; + +module_platform_driver(npcm_udc_driver); + +MODULE_DESCRIPTION("NPCM USB device controller driver"); +MODULE_AUTHOR("Tomer Maimon "); +MODULE_LICENSE("GPL v2");