From patchwork Fri Oct 13 15:24:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13421005 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FC5BCDB483 for ; Fri, 13 Oct 2023 15:25:08 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.616662.958831 (Exim 4.92) (envelope-from ) id 1qrK23-000300-2o; Fri, 13 Oct 2023 15:24:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 616662.958831; Fri, 13 Oct 2023 15:24:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK23-0002zt-00; Fri, 13 Oct 2023 15:24:55 +0000 Received: by outflank-mailman (input) for mailman id 616662; Fri, 13 Oct 2023 15:24:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK21-0002kj-SX for xen-devel@lists.xenproject.org; Fri, 13 Oct 2023 15:24:53 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7a569e1-69dc-11ee-9b0e-b553b5be7939; Fri, 13 Oct 2023 17:24:52 +0200 (CEST) Received: from Dell.bugseng.com (unknown [37.161.222.93]) by support.bugseng.com (Postfix) with ESMTPSA id 2E9B24EE073D; Fri, 13 Oct 2023 17:24:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7a569e1-69dc-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [XEN PATCH 01/10] arm/gic: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 13 Oct 2023 17:24:31 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names, no functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini --- xen/arch/arm/include/asm/gic.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h index f1ef347edc..03f209529b 100644 --- a/xen/arch/arm/include/asm/gic.h +++ b/xen/arch/arm/include/asm/gic.h @@ -246,7 +246,7 @@ void gic_set_irq_type(struct irq_desc *desc, unsigned int type); /* Program the GIC to route an interrupt */ extern void gic_route_irq_to_xen(struct irq_desc *desc, unsigned int priority); -extern int gic_route_irq_to_guest(struct domain *, unsigned int virq, +extern int gic_route_irq_to_guest(struct domain *d, unsigned int virq, struct irq_desc *desc, unsigned int priority); @@ -330,11 +330,11 @@ struct gic_hw_operations { /* Initialize the GIC and the boot CPU */ int (*init)(void); /* Save GIC registers */ - void (*save_state)(struct vcpu *); + void (*save_state)(struct vcpu *v); /* Restore GIC registers */ - void (*restore_state)(const struct vcpu *); + void (*restore_state)(const struct vcpu *v); /* Dump GIC LR register information */ - void (*dump_state)(const struct vcpu *); + void (*dump_state)(const struct vcpu *v); /* hw_irq_controller to enable/disable/eoi host irq */ hw_irq_controller *gic_host_irq_type; @@ -369,9 +369,9 @@ struct gic_hw_operations { /* Clear LR register */ void (*clear_lr)(int lr); /* Read LR register and populate gic_lr structure */ - void (*read_lr)(int lr, struct gic_lr *); + void (*read_lr)(int lr, struct gic_lr *lr_reg); /* Write LR register from gic_lr structure */ - void (*write_lr)(int lr, const struct gic_lr *); + void (*write_lr)(int lr, const struct gic_lr *lr_reg); /* Read VMCR priority */ unsigned int (*read_vmcr_priority)(void); /* Read APRn register */ From patchwork Fri Oct 13 15:24:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13421010 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FED3CDB47E for ; Fri, 13 Oct 2023 15:25:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.616663.958837 (Exim 4.92) (envelope-from ) id 1qrK23-00032i-Ep; Fri, 13 Oct 2023 15:24:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 616663.958837; Fri, 13 Oct 2023 15:24:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK23-00031i-7t; Fri, 13 Oct 2023 15:24:55 +0000 Received: by outflank-mailman (input) for mailman id 616663; Fri, 13 Oct 2023 15:24:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK22-0002kz-6T for xen-devel@lists.xenproject.org; Fri, 13 Oct 2023 15:24:54 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a816777d-69dc-11ee-98d4-6d05b1d4d9a1; Fri, 13 Oct 2023 17:24:53 +0200 (CEST) Received: from Dell.bugseng.com (unknown [37.161.222.93]) by support.bugseng.com (Postfix) with ESMTPSA id 480814EE0744; Fri, 13 Oct 2023 17:24:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a816777d-69dc-11ee-98d4-6d05b1d4d9a1 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [XEN PATCH 02/10] arm/cpufeature: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 13 Oct 2023 17:24:32 +0200 Message-Id: <3b28dca993cac9391b997c1744218cf4062907df.1697207038.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names, no functional change. Signed-off-by: Federico Serafini --- xen/arch/arm/include/asm/cpufeature.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index 8011076b8c..41e97c23dd 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -127,8 +127,8 @@ static inline void cpus_set_cap(unsigned int num) struct arm_cpu_capabilities { const char *desc; u16 capability; - bool (*matches)(const struct arm_cpu_capabilities *); - int (*enable)(void *); /* Called on every active CPUs */ + bool (*matches)(const struct arm_cpu_capabilities *caps); + int (*enable)(void *ptr); /* Called on every active CPUs */ union { struct { /* To be used for eratum handling only */ u32 midr_model; @@ -448,10 +448,10 @@ struct cpuinfo_arm { extern struct cpuinfo_arm system_cpuinfo; -extern void identify_cpu(struct cpuinfo_arm *); +extern void identify_cpu(struct cpuinfo_arm *c); #ifdef CONFIG_ARM_64 -extern void update_system_features(const struct cpuinfo_arm *); +extern void update_system_features(const struct cpuinfo_arm *new); #else static inline void update_system_features(const struct cpuinfo_arm *cpuinfo) { From patchwork Fri Oct 13 15:24:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13421004 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AF0ECDB47E for ; Fri, 13 Oct 2023 15:25:07 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.616664.958851 (Exim 4.92) (envelope-from ) id 1qrK25-0003X3-Ix; Fri, 13 Oct 2023 15:24:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 616664.958851; Fri, 13 Oct 2023 15:24:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK25-0003Wn-FG; Fri, 13 Oct 2023 15:24:57 +0000 Received: by outflank-mailman (input) for mailman id 616664; Fri, 13 Oct 2023 15:24:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK24-0002kz-0m for xen-devel@lists.xenproject.org; Fri, 13 Oct 2023 15:24:56 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a96ddf56-69dc-11ee-98d4-6d05b1d4d9a1; Fri, 13 Oct 2023 17:24:55 +0200 (CEST) Received: from Dell.bugseng.com (unknown [37.161.222.93]) by support.bugseng.com (Postfix) with ESMTPSA id 6B48C4EE0745; Fri, 13 Oct 2023 17:24:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a96ddf56-69dc-11ee-98d4-6d05b1d4d9a1 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [XEN PATCH 03/10] arm/smpboot: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 13 Oct 2023 17:24:33 +0200 Message-Id: <9ff244730ac8a69598699acf663c086a5272ac82.1697207038.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter name, no functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini --- xen/arch/arm/arm64/smpboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c index 9637f42469..bf81d018b3 100644 --- a/xen/arch/arm/arm64/smpboot.c +++ b/xen/arch/arm/arm64/smpboot.c @@ -10,7 +10,7 @@ #include struct smp_enable_ops { - int (*prepare_cpu)(int); + int (*prepare_cpu)(int cpu); }; static paddr_t cpu_release_addr[NR_CPUS]; From patchwork Fri Oct 13 15:24:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13421011 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA570CDB487 for ; Fri, 13 Oct 2023 15:25:18 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.616665.958861 (Exim 4.92) (envelope-from ) id 1qrK27-0003qJ-QF; Fri, 13 Oct 2023 15:24:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 616665.958861; Fri, 13 Oct 2023 15:24:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK27-0003q6-NO; Fri, 13 Oct 2023 15:24:59 +0000 Received: by outflank-mailman (input) for mailman id 616665; Fri, 13 Oct 2023 15:24:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK26-0002kj-Ek for xen-devel@lists.xenproject.org; Fri, 13 Oct 2023 15:24:58 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa679a67-69dc-11ee-9b0e-b553b5be7939; Fri, 13 Oct 2023 17:24:56 +0200 (CEST) Received: from Dell.bugseng.com (unknown [37.161.222.93]) by support.bugseng.com (Postfix) with ESMTPSA id 911BB4EE0746; Fri, 13 Oct 2023 17:24:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa679a67-69dc-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [XEN PATCH 04/10] arm/setup: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 13 Oct 2023 17:24:34 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names, no functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini --- xen/arch/arm/include/asm/setup.h | 5 +++-- xen/arch/arm/setup.c | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index b8866c20f4..98af6f55f5 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -141,7 +141,8 @@ void alloc_static_evtchn(void); void discard_initial_modules(void); void fw_unreserved_regions(paddr_t s, paddr_t e, - void (*cb)(paddr_t, paddr_t), unsigned int first); + void (*cb)(paddr_t ps, paddr_t pe), + unsigned int first); size_t boot_fdt_info(const void *fdt, paddr_t paddr); const char *boot_fdt_cmdline(const void *fdt); @@ -189,7 +190,7 @@ extern lpae_t boot_second_id[XEN_PT_LPAE_ENTRIES]; extern lpae_t boot_third_id[XEN_PT_LPAE_ENTRIES]; /* Find where Xen will be residing at runtime and return a PT entry */ -lpae_t pte_of_xenaddr(vaddr_t); +lpae_t pte_of_xenaddr(vaddr_t va); extern const char __ro_after_init_start[], __ro_after_init_end[]; diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index db748839d3..3f3a45719c 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -207,7 +207,7 @@ static void __init processor_id(void) } static void __init dt_unreserved_regions(paddr_t s, paddr_t e, - void (*cb)(paddr_t, paddr_t), + void (*cb)(paddr_t ps, paddr_t pe), unsigned int first) { unsigned int i, nr; @@ -324,7 +324,7 @@ static bool __init bootmodules_overlap_check(struct bootmodules *bootmodules, } void __init fw_unreserved_regions(paddr_t s, paddr_t e, - void (*cb)(paddr_t, paddr_t), + void (*cb)(paddr_t ps, paddr_t pe), unsigned int first) { if ( acpi_disabled ) From patchwork Fri Oct 13 15:24:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13421006 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 556C8CDB482 for ; Fri, 13 Oct 2023 15:25:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.616666.958867 (Exim 4.92) (envelope-from ) id 1qrK28-0003vP-9l; Fri, 13 Oct 2023 15:25:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 616666.958867; Fri, 13 Oct 2023 15:25:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK28-0003uS-2u; Fri, 13 Oct 2023 15:25:00 +0000 Received: by outflank-mailman (input) for mailman id 616666; Fri, 13 Oct 2023 15:24:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK27-0002kj-Iq for xen-devel@lists.xenproject.org; Fri, 13 Oct 2023 15:24:59 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab17a39d-69dc-11ee-9b0e-b553b5be7939; Fri, 13 Oct 2023 17:24:58 +0200 (CEST) Received: from Dell.bugseng.com (unknown [37.161.222.93]) by support.bugseng.com (Postfix) with ESMTPSA id DB3C94EE073C; Fri, 13 Oct 2023 17:24:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab17a39d-69dc-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [XEN PATCH 05/10] arm/p2m: address a violation of MISRA C:2012 Rule 8.2 Date: Fri, 13 Oct 2023 17:24:35 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter name, no functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini --- xen/arch/arm/include/asm/p2m.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h index 940495d42b..9ad312bfb5 100644 --- a/xen/arch/arm/include/asm/p2m.h +++ b/xen/arch/arm/include/asm/p2m.h @@ -21,7 +21,7 @@ extern unsigned int p2m_root_level; struct domain; -extern void memory_type_changed(struct domain *); +extern void memory_type_changed(struct domain *d); /* Per-p2m-table state */ struct p2m_domain { From patchwork Fri Oct 13 15:24:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13421012 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2770DCDB47E for ; Fri, 13 Oct 2023 15:25:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.616667.958881 (Exim 4.92) (envelope-from ) id 1qrK2A-0004PD-Hj; Fri, 13 Oct 2023 15:25:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 616667.958881; Fri, 13 Oct 2023 15:25:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK2A-0004Oy-DS; Fri, 13 Oct 2023 15:25:02 +0000 Received: by outflank-mailman (input) for mailman id 616667; Fri, 13 Oct 2023 15:25:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK28-0002kz-TI for xen-devel@lists.xenproject.org; Fri, 13 Oct 2023 15:25:00 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ac42960f-69dc-11ee-98d4-6d05b1d4d9a1; Fri, 13 Oct 2023 17:25:00 +0200 (CEST) Received: from Dell.bugseng.com (unknown [37.161.222.93]) by support.bugseng.com (Postfix) with ESMTPSA id 9739C4EE073D; Fri, 13 Oct 2023 17:24:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac42960f-69dc-11ee-98d4-6d05b1d4d9a1 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [XEN PATCH 06/10] arm/cmpxchg: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 13 Oct 2023 17:24:36 +0200 Message-Id: <7323f8210d16e58d8b4cdac89a10d67e7d7d023f.1697207038.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names, no functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini --- xen/arch/arm/include/asm/arm32/cmpxchg.h | 2 +- xen/arch/arm/include/asm/arm64/cmpxchg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/include/asm/arm32/cmpxchg.h b/xen/arch/arm/include/asm/arm32/cmpxchg.h index b0bd1d8b68..37b2d64eb6 100644 --- a/xen/arch/arm/include/asm/arm32/cmpxchg.h +++ b/xen/arch/arm/include/asm/arm32/cmpxchg.h @@ -3,7 +3,7 @@ #include -extern void __bad_xchg(volatile void *, int); +extern void __bad_xchg(volatile void *ptr, int size); static inline unsigned long __xchg(unsigned long x, volatile void *ptr, int size) { diff --git a/xen/arch/arm/include/asm/arm64/cmpxchg.h b/xen/arch/arm/include/asm/arm64/cmpxchg.h index 10e4edc022..dbfaf91567 100644 --- a/xen/arch/arm/include/asm/arm64/cmpxchg.h +++ b/xen/arch/arm/include/asm/arm64/cmpxchg.h @@ -1,7 +1,7 @@ #ifndef __ASM_ARM64_CMPXCHG_H #define __ASM_ARM64_CMPXCHG_H -extern void __bad_xchg(volatile void *, int); +extern void __bad_xchg(volatile void *ptr, int size); static inline unsigned long __xchg(unsigned long x, volatile void *ptr, int size) { From patchwork Fri Oct 13 15:24:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13421007 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 788A9CDB47E for ; Fri, 13 Oct 2023 15:25:14 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.616668.958891 (Exim 4.92) (envelope-from ) id 1qrK2C-0004ja-RV; Fri, 13 Oct 2023 15:25:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 616668.958891; Fri, 13 Oct 2023 15:25:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK2C-0004jA-NS; Fri, 13 Oct 2023 15:25:04 +0000 Received: by outflank-mailman (input) for mailman id 616668; Fri, 13 Oct 2023 15:25:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK2A-0002kz-SM for xen-devel@lists.xenproject.org; Fri, 13 Oct 2023 15:25:02 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad7bdd30-69dc-11ee-98d4-6d05b1d4d9a1; Fri, 13 Oct 2023 17:25:02 +0200 (CEST) Received: from Dell.bugseng.com (unknown [37.161.222.93]) by support.bugseng.com (Postfix) with ESMTPSA id 7F18C4EE0744; Fri, 13 Oct 2023 17:25:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad7bdd30-69dc-11ee-98d4-6d05b1d4d9a1 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [XEN PATCH 07/10] arm/traps: address a violation of MISRA C:2012 Rule 8.2 Date: Fri, 13 Oct 2023 17:24:37 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter name, no functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini --- xen/arch/arm/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index ce89f16404..5aa14d4707 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1236,7 +1236,7 @@ int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) if ( id == BUGFRAME_run_fn ) { - void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; + void (*fn)(const struct cpu_user_regs *regs) = (void *)regs->BUG_FN_REG; fn(regs); return 0; From patchwork Fri Oct 13 15:24:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13421008 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA3CBCDB484 for ; Fri, 13 Oct 2023 15:25:16 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.616674.958906 (Exim 4.92) (envelope-from ) id 1qrK2G-0005Bf-OT; Fri, 13 Oct 2023 15:25:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 616674.958906; Fri, 13 Oct 2023 15:25:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK2G-0005B4-ET; Fri, 13 Oct 2023 15:25:08 +0000 Received: by outflank-mailman (input) for mailman id 616674; Fri, 13 Oct 2023 15:25:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK2E-0002kj-Te for xen-devel@lists.xenproject.org; Fri, 13 Oct 2023 15:25:06 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aed9cfbb-69dc-11ee-9b0e-b553b5be7939; Fri, 13 Oct 2023 17:25:04 +0200 (CEST) Received: from Dell.bugseng.com (unknown [37.161.222.93]) by support.bugseng.com (Postfix) with ESMTPSA id 929B34EE073C; Fri, 13 Oct 2023 17:25:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aed9cfbb-69dc-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [XEN PATCH 08/10] arm/vgic-v3: address a violation of MISRA C:2012 Rule 8.2 Date: Fri, 13 Oct 2023 17:24:38 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter name, no functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini --- xen/arch/arm/vgic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 05a009409a..cc38327701 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -360,7 +360,7 @@ read_unknown: static uint64_t vgic_sanitise_field(uint64_t reg, uint64_t field_mask, int field_shift, - uint64_t (*sanitise_fn)(uint64_t)) + uint64_t (*sanitise_fn)(uint64_t field)) { uint64_t field = (reg & field_mask) >> field_shift; From patchwork Fri Oct 13 15:24:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13421013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B9CACDB47E for ; Fri, 13 Oct 2023 15:25:27 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.616672.958901 (Exim 4.92) (envelope-from ) id 1qrK2G-00058R-6D; Fri, 13 Oct 2023 15:25:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 616672.958901; Fri, 13 Oct 2023 15:25:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK2G-00058K-1N; Fri, 13 Oct 2023 15:25:08 +0000 Received: by outflank-mailman (input) for mailman id 616672; Fri, 13 Oct 2023 15:25:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK2E-0002kz-1u for xen-devel@lists.xenproject.org; Fri, 13 Oct 2023 15:25:06 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af5963f0-69dc-11ee-98d4-6d05b1d4d9a1; Fri, 13 Oct 2023 17:25:05 +0200 (CEST) Received: from Dell.bugseng.com (unknown [37.161.222.93]) by support.bugseng.com (Postfix) with ESMTPSA id 7779B4EE073D; Fri, 13 Oct 2023 17:25:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af5963f0-69dc-11ee-98d4-6d05b1d4d9a1 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [XEN PATCH 09/10] arm/domain: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 13 Oct 2023 17:24:39 +0200 Message-Id: <8bf0994b7796ecca215f73a6a1f5acc892bd2a97.1697207038.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names, no funtional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini --- xen/arch/arm/include/asm/domain.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index 99e798ffff..5fb8cd79c0 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -243,8 +243,8 @@ struct arch_vcpu } __cacheline_aligned; -void vcpu_show_registers(const struct vcpu *); -void vcpu_switch_to_aarch64_mode(struct vcpu *); +void vcpu_show_registers(const struct vcpu *v); +void vcpu_switch_to_aarch64_mode(struct vcpu *v); /* * Due to the restriction of GICv3, the number of vCPUs in AFF0 is From patchwork Fri Oct 13 15:24:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13421014 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C5ECCDB483 for ; Fri, 13 Oct 2023 15:25:28 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.616677.958918 (Exim 4.92) (envelope-from ) id 1qrK2I-0005at-3W; Fri, 13 Oct 2023 15:25:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 616677.958918; Fri, 13 Oct 2023 15:25:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK2H-0005Zq-PJ; Fri, 13 Oct 2023 15:25:09 +0000 Received: by outflank-mailman (input) for mailman id 616677; Fri, 13 Oct 2023 15:25:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qrK2G-0002kj-64 for xen-devel@lists.xenproject.org; Fri, 13 Oct 2023 15:25:08 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b0359cd3-69dc-11ee-9b0e-b553b5be7939; Fri, 13 Oct 2023 17:25:06 +0200 (CEST) Received: from Dell.bugseng.com (unknown [37.161.222.93]) by support.bugseng.com (Postfix) with ESMTPSA id 6E65A4EE0744; Fri, 13 Oct 2023 17:25:05 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0359cd3-69dc-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Julien Grall , Rahul Singh , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [XEN PATCH 10/10] arm/smmu: address violation of MISRA C:2012 Rule 8.2 Date: Fri, 13 Oct 2023 17:24:40 +0200 Message-Id: <199886f6ba1f2d5701eabd080b4f9723fc28f4b9.1697207038.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names, no functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini --- xen/drivers/passthrough/arm/smmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 71799064f8..11fc1d22ef 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -277,8 +277,8 @@ static void iommu_group_put(struct iommu_group *group) } static void iommu_group_set_iommudata(struct iommu_group *group, - struct arm_smmu_master_cfg *cfg, - void (*releasefn)(void *)) + struct arm_smmu_master_cfg *cfg, + void (*releasefn)(void *data)) { /* TODO: Store the releasefn for the PCI */ ASSERT(releasefn == NULL); @@ -2082,7 +2082,7 @@ static int arm_smmu_add_device(struct device *dev) struct arm_smmu_device *smmu; struct arm_smmu_master_cfg *cfg; struct iommu_group *group; - void (*releasefn)(void *) = NULL; + void (*releasefn)(void *data) = NULL; int ret; smmu = find_smmu_for_device(dev);