From patchwork Mon Oct 16 04:18:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 13422459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63C92CDB465 for ; Mon, 16 Oct 2023 04:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=gPtczKIugtzWQOtmQPcyemezmrZ8vg1DOxaQXGjbUOQ=; b=OqrmRTiI45rGt9 2Qksc8JVvfJPATW1q4wsYxQUDbgXaQIZAwqkR+xVnEgxUqb/jo1OrZibEVPhjkgasPzlkp/DV5Hm2 ZaYdNqASb6r0AOlVXyT3SD4h5+X2iKSmjTgRu8fAkU4QXtzQ3z8oIsWUlQZk0pa4+QkQJPEgbs2Z1 g3ghmxWr1MF9xjlpnfgnKd4tIYqWXH82bWDrLxB0U6RhoKiiG9NFSUMkaOCXZkzdy2eYhWR0z0Xuo EbrloZQ8IdhAIJNgzlETDqfyMa0P+U5b3t/2QefNfNEWRG6KA2mPq/K0r5XDUExU2P9O8IdyjPbD9 lh+rOEH/CsLlgG1wrNVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qsF3v-008GKf-1g; Mon, 16 Oct 2023 04:18:39 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qsF3r-008GIJ-2b for linux-arm-kernel@lists.infradead.org; Mon, 16 Oct 2023 04:18:37 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C5DD440005; Mon, 16 Oct 2023 04:18:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1697429910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=x6Nt+lmoIZYSVOu6ZTlQjSZu1KbJRj9ixtTG2gZ2sqg=; b=YC6sEOm62jCK773k2RKL/MqbmZJ0ktqxrjnpdXnEBrwg3alwv/F52dDYgbwWgdYu46d7qe sWiFLZK9we8VfHTGPlkFkYSOm+8JKvyUaYIIiiDedQCISh9mV66HgNyD72IA9kTuYbD8jc 0goBpM9S0KTNrB7ax8p9Ylq/CkCT16MIHvHszGqTUkQbkxAJq2lgatcEIxMYwnZRDDiUNT sSPBBsRKJbVJzlm4QlGHFT/rTlZu8aINo235VAjohBpVsE+W8goymtlevj0slPZ5/yBYj5 /0tD1t69Hvy02zDdlkL1CbzWKG4GW/gZ7TPmzp+ABRBDeeUT3/3xH8qKqoNVwA== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni , Nicolas Ferre , Claudiu Beznea Cc: kernel test robot , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] rtc: at91rm9200: annotate at91_rtc_remove with __exit again Date: Mon, 16 Oct 2023 06:18:16 +0200 Message-ID: <20231016041816.246426-1-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-GND-Sasl: alexandre.belloni@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231015_211836_011039_CE9643C3 X-CRM114-Status: GOOD ( 12.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Alexandre Belloni Without __exit, having the driver as a builtin after dropping the __exit annotation results in: >> drivers/rtc/rtc-at91rm9200.c:561:13: warning: 'at91_rtc_remove' defined but not used [-Wunused-function] 561 | static void at91_rtc_remove(struct platform_device *pdev) | ^~~~~~~~~~~~~~~ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202310160705.vlElNOGb-lkp@intel.com/ Signed-off-by: Alexandre Belloni Acked-by: Nicolas Ferre --- drivers/rtc/rtc-at91rm9200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index 3f5ff9867c02..c16fe711a0d9 100644 --- a/drivers/rtc/rtc-at91rm9200.c +++ b/drivers/rtc/rtc-at91rm9200.c @@ -558,7 +558,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev) /* * Disable and remove the RTC driver */ -static void at91_rtc_remove(struct platform_device *pdev) +static void __exit at91_rtc_remove(struct platform_device *pdev) { /* Disable all interrupts */ at91_rtc_write_idr(AT91_RTC_ACKUPD | AT91_RTC_ALARM |