From patchwork Mon Oct 16 11:19:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 13423076 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A39B6CDB465 for ; Mon, 16 Oct 2023 11:20:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5D4310E1BB; Mon, 16 Oct 2023 11:19:59 +0000 (UTC) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3245110E1C5 for ; Mon, 16 Oct 2023 11:19:58 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40675f06f1fso33337355e9.1 for ; Mon, 16 Oct 2023 04:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697455196; x=1698059996; darn=lists.freedesktop.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=A8KsGpPOOoWej+EABAJ7O0MnezxzJN0p6iOYP9JLBdQ=; b=cf1eCCL4Gz1DX3TfD1gGQmeJwvHdYK4VmAdc6KowqdDWcW2quAsxvdvSQlON3450h4 8obKMKrIbRNxkEhRPQhFHCnJ1HVPyCpmQow0mMbaUjh7KMwtr2K4PxwLnZpEBrFN/hWg IRlkvL9aZKr0bOqxzvOCFY3EO90+q6zi/UcgzVLD9ki7eTWcB1DrXs21pfeOBHvzVscz J4nWWNNggfHNWahh5f8zcgRKSV5o/QL15QzcfiecJ/YePz/6snLBTHs+beoXyUj7rB6e N4hyq8iyeXuJEwNK/dhjPAsf/J4Ar5/62AfBA9c5dw+IAw9Xm0OpGEQfD4O/bBiP+3kz 0iew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697455196; x=1698059996; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A8KsGpPOOoWej+EABAJ7O0MnezxzJN0p6iOYP9JLBdQ=; b=roCOVrLFb+ZdHrSEpPJA9rubtyz+yWQdHCGnaEWuRcAZVUHKUZWySirdq4SkLlFHRI P6/T4W/P1ZTqhr2aLKnIWWLE/eBQFbbRs9S8KvowdJBH3+kk/4GsGyb2yghjlcDJ/Pan u9xjIv8EHHOLCFhdMKsc/xFgtQjbk5JXrPUcMqg53Nwj9dNuN4fVxVIaOZZ6L589uRdO dYVnOQIvQOjH9FacX5OYCFJKnBU+xBzT8BXS83xLImaPjWr3KsQTE0Q4/+n3dK93v6kn ejSMptSrYMycu2bmO1l/jwy6vQ0cYlXdIq4AqfroAAhaKViPwzsv2r01kPPEUSsdAG+6 h14A== X-Gm-Message-State: AOJu0Yz8kTuAnZj1O3Ei8+WXxT0Lx50jBwKLN0jBjeVM1dw6iiEpd2+U 1Bfl3wnhKRiTP4zxQCwYuIJvTQ== X-Google-Smtp-Source: AGHT+IEwsg3DmJum5HD3wiLEYwzwIlJS3Ala8HDGksmUXDObbnciWs0r3lFHIdZY4gQew0/dSIC84g== X-Received: by 2002:a05:600c:1552:b0:407:7def:382c with SMTP id f18-20020a05600c155200b004077def382cmr4012116wmg.13.1697455196603; Mon, 16 Oct 2023 04:19:56 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id p11-20020a05600c358b00b004075d5664basm6983560wmq.8.2023.10.16.04.19.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 04:19:56 -0700 (PDT) Date: Mon, 16 Oct 2023 14:19:52 +0300 From: Dan Carpenter To: Helge Deller Subject: [PATCH] fbdev: omapfb: fix some error codes Message-ID: <843b063c-ee4a-4e17-add6-75e2cc82c2f4@moroto.mountain> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Xu Panda , Lucy Mielke , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , Uwe =?iso-8859-1?q?Kleine-K=F6nig?= , linux-omap@vger.kernel.org, Sam Ravnborg , Yang Yang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Return negative -ENXIO instead of positive ENXIO. Signed-off-by: Dan Carpenter --- No fixes tag because the caller doesn't check for errors. drivers/video/fbdev/omap/omapfb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c index f28cb90947a3..42c96f1cfc93 100644 --- a/drivers/video/fbdev/omap/omapfb_main.c +++ b/drivers/video/fbdev/omap/omapfb_main.c @@ -1645,13 +1645,13 @@ static int omapfb_do_probe(struct platform_device *pdev, } fbdev->int_irq = platform_get_irq(pdev, 0); if (fbdev->int_irq < 0) { - r = ENXIO; + r = -ENXIO; goto cleanup; } fbdev->ext_irq = platform_get_irq(pdev, 1); if (fbdev->ext_irq < 0) { - r = ENXIO; + r = -ENXIO; goto cleanup; }